[00:00:49] (03CR) 10Trevor Parscal: [C: 032] Add indicators to demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/117421 (owner: 10Esanders) [00:01:42] (03Merged) 10jenkins-bot: Add indicators to demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/117421 (owner: 10Esanders) [00:01:44] (03CR) 10Trevor Parscal: [C: 032] Add missing 75% transparency to add-item [oojs/ui] - 10https://gerrit.wikimedia.org/r/117426 (owner: 10Esanders) [00:02:15] (03Merged) 10jenkins-bot: Add missing 75% transparency to add-item [oojs/ui] - 10https://gerrit.wikimedia.org/r/117426 (owner: 10Esanders) [00:05:07] (03CR) 10Trevor Parscal: [C: 032] Balance margins around icon on iconed ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/117422 (owner: 10Esanders) [00:05:32] (03Merged) 10jenkins-bot: Balance margins around icon on iconed ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/117422 (owner: 10Esanders) [00:07:52] * Krinkle wants to make a dozen or so breaking changes to oojs/ui [00:08:00] repo breaking that is, nothing compat breaking [00:11:53] Krinkle: Do you have them ready to go? [00:12:06] James_F: No, not by a long shot [00:12:12] Krinkle: If so, go for it; I don't think we're going to have a better time. [00:12:13] Oh. [00:12:18] I'll do them over the weekend and fine a moment where Trevor or Roan is online to merge them asap [00:12:23] * James_F nods. [00:12:24] find* [00:12:45] Maybe tell them why you want to make the changes now so they can give suggestions before you spend the whole weekend? :-) [00:12:57] change 1) Rid all file prefixes (this is a repo breaking change, but thanks to git trivial to auto rebase), 2) Adopt .super stuff (find/replace) [00:13:19] Krinkle: File prefixes? [00:13:35] RoanKattouw: OO.ui.Dialog.js -> Dialog.js [00:13:49] Hmmmmmmm [00:13:50] OK [00:14:19] You already agreed to it a few months ago :P [00:14:26] But thanks for the confidence. [00:15:58] Krinkle: Roan a few months ago didn't know what he knows now. :-) [00:16:37] Haha [00:16:42] No it seems reasonable enough [00:16:53] It just ... violates the pattern we have in VE [00:18:26] RoanKattouw: Bottom up, you know where this is going [00:18:43] oojs core -> ui -> ve core -> ve mw -> mw core -> ?? [00:18:56] progressive world domination [00:18:58] Are we gonna be stripping ve.* from VE files too? [00:19:06] Maybe, depends on a few things [00:19:12] The pattern isn't exactly the same [00:19:18] beause of namespaces [00:19:37] but I wouldn't say definitely not [00:19:50] Anyways yeah for OOUI it seems reasonable [00:19:54] How long has super been in MW core? [00:20:03] Cause we should probably just convert all of our repos [00:23:05] (03CR) 10Krinkle: "fixme: query parameter" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113665 (owner: 10Alex Monk) [00:24:54] (03CR) 10Catrope: [C: 04-1] Table of contents widget (0320 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [00:25:13] rmoen: I read through the code and commented on what I saw, but I don't see an obvious cause for the undo/redo bug yet [00:25:30] Except mayyyybe the disconnect thing but I don't think that should be able to break it [00:31:44] (03CR) 10Catrope: [C: 04-1] Keep label and disabled state of transclusion dialog apply button in sync (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal) [00:36:57] RoanKattouw: It's in OOjs core, not released yet. [00:37:08] (inheritClass 'super') [00:37:21] (03CR) 10Catrope: Add fallback template description with link to template page (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [00:37:35] Krinkle: OK. It should land in MW core before we convert anything [00:37:39] I'm gonna convert ooui locally later today I think, and if it all works properly I'll do release and upgrade all the repos [00:38:21] (03CR) 10Catrope: [C: 031] Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [00:40:33] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/117479/ [00:43:27] (03PS1) 10Krinkle: Registry: Remove redundant type validation logic in #register [oojs/core] - 10https://gerrit.wikimedia.org/r/117627 [00:43:36] RoanKattouw, do you pay attention to the order in which methods are defined? e.g. A invokes B, should B be before A or after A? [00:43:47] jgonera: That doesn't matter [00:43:49] ok [00:44:51] Krinkle: Riiight, it works for the first level but then it gets stuck in a loop [00:45:35] (03PS2) 10Krinkle: Registry: Remove redundant type validation logic in #register [oojs/core] - 10https://gerrit.wikimedia.org/r/117627 [00:45:53] (03CR) 10Krinkle: "Simplify even further by not doing any of the assertions twice." [oojs/core] - 10https://gerrit.wikimedia.org/r/117627 (owner: 10Krinkle) [00:46:25] (03PS3) 10Krinkle: Registry: Remove redundant type validation logic in #register [oojs/core] - 10https://gerrit.wikimedia.org/r/117627 [00:47:17] Krinkle: It still makes me sad though that we have to repeat the name of the class :( [00:47:29] (03CR) 10Catrope: [C: 032] inheritClass: Use Class.super instead of this.constructor.super [oojs/core] - 10https://gerrit.wikimedia.org/r/117479 (owner: 10Krinkle) [00:47:31] RoanKattouw: Yeah, but only the name of the current class. [00:47:37] Yeah [00:47:41] At least we don't need the name of the parent class [00:47:43] So that's an improvement [00:47:49] (03Merged) 10jenkins-bot: inheritClass: Use Class.super instead of this.constructor.super [oojs/core] - 10https://gerrit.wikimedia.org/r/117479 (owner: 10Krinkle) [00:47:50] which is already repeated 100 times in a class file in the proto assignment [00:47:55] Right :) [00:48:08] Which is something I'd also like to get rid of, but oh well. [00:48:16] (03CR) 10Catrope: [C: 032] Registry: Remove redundant type validation logic in #register [oojs/core] - 10https://gerrit.wikimedia.org/r/117627 (owner: 10Krinkle) [00:48:28] (03CR) 10Catrope: [C: 032] Add required indicators to parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117327 (owner: 10Trevor Parscal) [00:48:37] (03Merged) 10jenkins-bot: Registry: Remove redundant type validation logic in #register [oojs/core] - 10https://gerrit.wikimedia.org/r/117627 (owner: 10Krinkle) [00:49:01] When we get closures, we might go for something like var self = ve.foo.Bar = function VeFooBar() { }; $.extend( self.prototype, { methodA: function () { .. } [00:49:06] RoanKattouw: ^ [00:49:16] Yeah [00:49:45] Although that does break the web console's notion of what the method is named, doesn't it? [00:49:51] (03Merged) 10jenkins-bot: Add required indicators to parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117327 (owner: 10Trevor Parscal) [00:49:57] Assuming we repeat that pattern exactly, it'll be the same compression for gzip, but a lot less smaller expanded. And faster because less global variable and property level resolutions [00:50:02] Right now the inspector knows my method name is ve.ui.Foo.prototype.Bar [00:50:06] RoanKattouw: No [00:50:23] It uses class name + method name [00:50:27] that won't change [00:50:33] OK... [00:50:41] in fact, even if it would use the path where it is stored, it'll still be same [00:50:53] it's just assigned automatically [00:50:53] File path you mean? [00:50:58] no [00:51:04] ve.foo.Bar.prototype.method = function () {} [00:51:53] Hm.. actually maybe.. [00:51:57] let me double check [00:53:39] (03CR) 10Catrope: [C: 032] Make parameter search widget case insensitive [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117305 (owner: 10Trevor Parscal) [00:54:01] RoanKattouw: indeed. [00:54:06] It uses class name + method [00:54:20] not the identifier of how the method was initially assigned to a protype (or mixin) [00:54:36] Right [00:54:59] (03Merged) 10jenkins-bot: Make parameter search widget case insensitive [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117305 (owner: 10Trevor Parscal) [00:59:33] (03PS1) 10Krinkle: Factory: Use Class.super instead of hard coding parent class [oojs/core] - 10https://gerrit.wikimedia.org/r/117633 [00:59:49] (03CR) 10Catrope: [C: 032] Abstract tracking and specify which target it came from (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/100520 (owner: 10Robmoen) [01:00:05] (03CR) 10Catrope: [C: 032] Factory: Use Class.super instead of hard coding parent class [oojs/core] - 10https://gerrit.wikimedia.org/r/117633 (owner: 10Krinkle) [01:00:22] (03CR) 10Catrope: [C: 032] Remove unneeded assignment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117459 (owner: 10JGonera) [01:00:27] (03Merged) 10jenkins-bot: Factory: Use Class.super instead of hard coding parent class [oojs/core] - 10https://gerrit.wikimedia.org/r/117633 (owner: 10Krinkle) [01:01:00] (03CR) 10Catrope: [C: 032] Add missing returns documentation to getSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117430 (owner: 10Esanders) [01:01:09] (03Merged) 10jenkins-bot: Abstract tracking and specify which target it came from [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/100520 (owner: 10Robmoen) [01:01:40] (03Merged) 10jenkins-bot: Remove unneeded assignment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117459 (owner: 10JGonera) [01:02:10] (03Merged) 10jenkins-bot: Add missing returns documentation to getSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117430 (owner: 10Esanders) [01:07:49] (03CR) 10Catrope: [C: 032] Fix application of slug focus classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117214 (owner: 10Esanders) [01:08:08] (03CR) 10Catrope: [C: 032] Have Protected/ResizableNode respond to rerender event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117215 (owner: 10Esanders) [01:08:47] (03Merged) 10jenkins-bot: Fix application of slug focus classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117214 (owner: 10Esanders) [01:09:05] (03Merged) 10jenkins-bot: Have Protected/ResizableNode respond to rerender event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117215 (owner: 10Esanders) [01:11:49] (03CR) 10Catrope: [C: 032] Rerender focusedNode after slug collapse [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117216 (owner: 10Esanders) [01:12:53] (03Merged) 10jenkins-bot: Rerender focusedNode after slug collapse [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117216 (owner: 10Esanders) [01:12:55] (03Merged) 10jenkins-bot: Use en-us spelling 'focused' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117217 (owner: 10Esanders) [01:14:35] (03CR) 10Catrope: [C: 04-1] Add text direction to SA demo (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 (owner: 10Esanders) [01:38:18] RoanKattouw: https://gerrit.wikimedia.org/r/117636 and https://gerrit.wikimedia.org/r/117637 [01:40:51] TrevorParscal, where is that JSON file with dependencies? [01:41:19] build/modules.json [01:41:27] thanks [01:49:58] TrevorParscal, I'm getting Object # has no method 'getTagName' from oojs-ui.js when trying to use VE on mobile [11:59:38] (03PS2) 10Esanders: Add text direction to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 [12:02:11] (03PS1) 10Esanders: Restore error box to VE demo page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117652 [12:04:17] (03CR) 10Esanders: Add text direction to SA demo (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 (owner: 10Esanders) [12:04:47] (03CR) 10Esanders: "Before: http://i.imgur.com/IdX8tVp.png" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117652 (owner: 10Esanders) [12:08:44] (03CR) 10Esanders: "Re: toolbar bug, I fixed it so that none of the re-rendering happened until the slideUp animation resolved (which would have caused the to" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 (owner: 10Esanders) [15:25:19] (03PS1) 10Esanders: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 [15:25:54] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [17:54:38] (03PS1) 10Alex Monk: Rename 'wasve' parameter to 'veswitched' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117660 [18:05:51] (03CR) 10Alex Monk: Track edits where user switched into wikitext editor from VE (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113665 (owner: 10Alex Monk)