[00:00:51] (03Merged) 10jenkins-bot: Add phan [extensions/PopupAlerts] - 10https://gerrit.wikimedia.org/r/694776 (owner: 10Zoranzoki21) [00:01:06] (03Merged) 10jenkins-bot: Add phan [extensions/ShowMe] - 10https://gerrit.wikimedia.org/r/694786 (owner: 10Zoranzoki21) [00:01:14] (03Merged) 10jenkins-bot: Add phan [extensions/SaveSpinner] - 10https://gerrit.wikimedia.org/r/694785 (owner: 10Zoranzoki21) [00:01:48] (03PS8) 10Nray: Move talk page notification data from 'user-menu' to 'notifications' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/691282 (https://phabricator.wikimedia.org/T274428) [00:02:24] (03PS9) 10Nray: Move talk page notification data from 'user-menu' to 'notifications' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/691282 (https://phabricator.wikimedia.org/T274428) [00:02:28] 10SRE, 10SRE-Access-Requests: access to analytics data for wdqs - https://phabricator.wikimedia.org/T283632 (10Dzahn) Hi @jmixter please see https://wikitech.wikimedia.org/wiki/Production_access#Access_Request_Process for the access request process Others might pick this up, but there are a few things that... [00:02:43] (03CR) 10jerkins-bot: [V: 04-1] Remove FlaggableWikiPage inheritence logic [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/688756 (owner: 10Aaron Schulz) [00:03:44] (03PS10) 10Nray: Move talk page notification data from 'user-menu' to 'notifications' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/691282 (https://phabricator.wikimedia.org/T274428) [00:04:32] (03CR) 10AndyRussG: [C: 03+2] "Yaaaaaayyyy" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/693266 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [00:04:41] (03CR) 10Jdlrobson: Create new user menu template for consolidated user links in logged out users (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/686781 (https://phabricator.wikimedia.org/T276564) (owner: 10Bernard Wang) [00:06:57] 10SRE, 10SRE-Access-Requests: access to analytics data for wdqs for jmixter - https://phabricator.wikimedia.org/T283632 (10Dzahn) [00:08:39] (03CR) 10Jdlrobson: Move talk page notification data from 'user-menu' to 'notifications' (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/691282 (https://phabricator.wikimedia.org/T274428) (owner: 10Nray) [00:10:07] (03CR) 10Jdlrobson: [C: 04-1] "Finishing for today, but will pick up review tomorrow." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/691282 (https://phabricator.wikimedia.org/T274428) (owner: 10Nray) [00:10:16] 10SRE, 10SRE-Access-Requests: access to analytics data for wdqs for jmixter - https://phabricator.wikimedia.org/T283632 (10Dzahn) @Ottomata Hi! I see this in wikitech "The project lead where your access will be granted. For Analytics and Data systems this is Andrew Otto.". Does this apply here because it's ana... [00:14:07] (03PS6) 10Aaron Schulz: Remove FlaggableWikiPage inheritence logic [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/688756 [00:14:36] (03CR) 10Dzahn: [C: 03+2] "as Ema once said there is no maximum in the RFC https://phabricator.wikimedia.org/T209590#4856116" [puppet] - 10https://gerrit.wikimedia.org/r/694731 (https://phabricator.wikimedia.org/T281390) (owner: 1020after4) [00:19:03] (03CR) 10jerkins-bot: [V: 04-1] Remove FlaggableWikiPage inheritence logic [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/688756 (owner: 10Aaron Schulz) [00:19:17] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Fundraising Sprint Ketchup Flume Ride: Enable SSL for CiviCRM DB connections - https://phabricator.wikimedia.org/T280080 (10Eileenmcnaughton) @Dwisehaupt that's probably enough to +2 the patch so we can deploy & then the next testing will be in conjunction wit... [00:20:38] 10The-Wikipedia-Library (Kanban): Answer analytics question: What percentage of users who arrive on the homepage (logged out) log in? - https://phabricator.wikimedia.org/T282714 (10Scardenasmolinar) Relevant PR has been merged https://github.com/WikipediaLibrary/TWLight/pull/713 [00:22:11] (03CR) 10Dzahn: "to be fair http://httpd.apache.org/docs/2.4/mod/core.html#limitrequestline says "under normal circumstances" this should not be changed an" [puppet] - 10https://gerrit.wikimedia.org/r/694731 (https://phabricator.wikimedia.org/T281390) (owner: 1020after4) [00:22:13] (03Merged) 10jenkins-bot: Move alterLogTables & alterTriggerInfo to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/693266 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [00:25:14] (03PS11) 10Nray: Move talk page notification data from 'user-menu' to 'notifications' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/691282 (https://phabricator.wikimedia.org/T274428) [00:27:05] 10Growth-Team, 10Growth-Team-Filtering, 10Notifications, 10MinervaNeue (Tracking): Mobile IP editors not given any indication that they have new messages - https://phabricator.wikimedia.org/T240889 (10Proc) >>! In T240889#7113694, @AlexisJazz wrote: >>>! In T240889#7108934, @MMiller_WMF wrote: >> Hi @Alexi... [00:28:31] (03CR) 10Clare Ming: Create new user menu template for consolidated user links in logged out users (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/686781 (https://phabricator.wikimedia.org/T276564) (owner: 10Bernard Wang) [00:29:23] (03CR) 10jerkins-bot: [V: 04-1] build: Updating browserslist to 4.16.6 [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/694818 (owner: 10Libraryupgrader) [00:30:03] (03CR) 10Dzahn: "apache2 was restarted on phab2001 and reload on phab1001, please test the actual limit if you can" [puppet] - 10https://gerrit.wikimedia.org/r/694731 (https://phabricator.wikimedia.org/T281390) (owner: 1020after4) [00:31:48] 10Commons, 10Wikimedia-Site-requests, 10video2commons: Server side upload for Sturm - https://phabricator.wikimedia.org/T283645 (10Sturm) [00:42:05] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/694827 [00:42:23] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/694827 (owner: 10Eileen) [00:42:25] 10Mobile: Desktop / mobile choice cookie should expire in one day - https://phabricator.wikimedia.org/T283640 (10Kizule) [00:43:12] (03CR) 10DannyS712: "Assuming its okay to review even with the -2" [core] - 10https://gerrit.wikimedia.org/r/681393 (https://phabricator.wikimedia.org/T280806) (owner: 10Ppchelko) [00:44:00] (03PS1) 10Nray: Add conditional around EchoHooks::onPersonalUrls call [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/694835 (https://phabricator.wikimedia.org/T274428) [00:44:47] (03PS2) 10Nray: Add conditional around EchoHooks::onPersonalUrls call [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/694835 (https://phabricator.wikimedia.org/T274428) [00:45:08] (03PS1) 10Eileen: Add ja to matching gifts url in Japanese thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/694836 (https://phabricator.wikimedia.org/T283600) [00:45:33] (03CR) 10DannyS712: [C: 04-1] Move User::changeable(By)Groups methods to UserGroupManager (033 comments) [core] - 10https://gerrit.wikimedia.org/r/694311 (https://phabricator.wikimedia.org/T254838) (owner: 10Ppchelko) [00:47:15] 10MediaWiki-API, 10Platform Engineering, 10Dependency injection, 10User-DannyS712: Convert ApiPageSet to a service rather than a subclass of ApiBase - https://phabricator.wikimedia.org/T283314 (10DannyS712) @BPirkle can you clarify if #platform_engineering would support such a change? I'm happy to try and... [00:47:18] 10Thumbor: Opacity errors with WebP Files - https://phabricator.wikimedia.org/T283646 (10Jonteemil) [00:50:20] (03CR) 10jerkins-bot: [V: 04-1] Add conditional around EchoHooks::onPersonalUrls call [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/694835 (https://phabricator.wikimedia.org/T274428) (owner: 10Nray) [00:52:01] (03CR) 10Nray: Move talk page notification data from 'user-menu' to 'notifications' (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/691282 (https://phabricator.wikimedia.org/T274428) (owner: 10Nray) [00:52:41] (03CR) 10Nray: "recheck" [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/694835 (https://phabricator.wikimedia.org/T274428) (owner: 10Nray) [00:53:46] (03CR) 10DannyS712: Service for associate pages lookups (036 comments) [core] - 10https://gerrit.wikimedia.org/r/673298 (owner: 10Ppchelko) [00:58:28] (03CR) 10DannyS712: [C: 03+2] Drop hard-deprecated and unused DatabaseBlock::chooseBlock [core] - 10https://gerrit.wikimedia.org/r/694757 (owner: 10Ppchelko) [01:03:09] 10Anti-Harassment, 10MediaWiki-Blocks: Enable partial action blocks - https://phabricator.wikimedia.org/T280531 (10DannyS712) >>! In T280531#7112240, @Niharika wrote: >>>! In T280531#7105165, @DannyS712 wrote: >> Please remember that T280808 should be resolved before enabling on production non-test wikis (per... [01:04:39] 10Product-Analytics (Kanban): Establish an easy and secure process for sharing confidential data - https://phabricator.wikimedia.org/T272986 (10nshahquinn-wmf) >>! In T272986#7083428, @nshahquinn-wmf wrote: > We still need to continue the discussion so I know how much I can document publicly. I just asked Lega... [01:11:30] 10Wikimedia-Site-requests, 10User-Zabe: Remove education program namespaces from hewiki - https://phabricator.wikimedia.org/T217137 (10IKhitron) >>! In T217137#7108568, @Zabe wrote: > Done, sorry that this took so long :) How long it will take to work? [01:15:55] (03Merged) 10jenkins-bot: Drop hard-deprecated and unused DatabaseBlock::chooseBlock [core] - 10https://gerrit.wikimedia.org/r/694757 (owner: 10Ppchelko) [01:24:39] 10Vue.js Migration, 10Performance-Team (Radar): Migrate WVUI library to Rollup or Vite - https://phabricator.wikimedia.org/T272879 (10egardner) a:03egardner [01:36:20] 10Growth-Scaling, 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), and 3 others: Provide custom editing interface for GrowthExperiments on-wiki configuration - https://phabricator.wikimedia.org/T274031 (10Etonkovidova) [01:36:22] 10Growth-Scaling, 10GrowthExperiments, 10Growth-Team (Current Sprint), 10User-Urbanecm_WMF (Engineering): Special:EditGrowthConfig does not allow users to use interwiki titles - https://phabricator.wikimedia.org/T279886 (10Etonkovidova) 05Open→03Resolved Checked in betalabs - the interwikilinks, e.g. `... [01:37:50] 10phan, 10User-DannyS712: Phan should understand IResultWrapper::numRows() - https://phabricator.wikimedia.org/T283647 (10DannyS712) [01:42:14] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Fundraising Sprint Ketchup Flume Ride: Enable SSL for CiviCRM DB connections - https://phabricator.wikimedia.org/T280080 (10Eileenmcnaughton) Actually @Dwisehaupt - it needs to work with & without ssl to +2 it - it's not working without ssl now but I think tha... [01:43:33] 10SRE, 10SRE-Access-Requests: access to analytics data for wdqs for jmixter - https://phabricator.wikimedia.org/T283632 (10Ottomata) Heya! Approval is the same as any SRE shell access, plus a designated Analytics team approver, which is currently me. @jmxixter maybe copy and paste from https://phabricator.... [01:44:42] 10Timeless, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Timeless WTE2017 preview has inconsistent styling - https://phabricator.wikimedia.org/T185284 (10alistair3149) For some reason VE is loading core styles (maybe skinning interface but I'm not sure) inline in the head element in preview.... [01:49:36] (03CR) 10DannyS712: "Filed T283647 for the numRows() issue" [core] - 10https://gerrit.wikimedia.org/r/693646 (https://phabricator.wikimedia.org/T283298) (owner: 10DannyS712) [01:53:53] (03CR) 10DannyS712: [C: 04-1] Add phan (031 comment) [extensions/MassMessageEmail] - 10https://gerrit.wikimedia.org/r/694741 (owner: 10Zoranzoki21) [01:54:32] (03CR) 10DannyS712: [C: 04-1] Add phan (031 comment) [extensions/UserProtect] - 10https://gerrit.wikimedia.org/r/694793 (owner: 10Zoranzoki21) [01:54:40] (03CR) 10DannyS712: [C: 04-1] Add phan (031 comment) [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/694784 (owner: 10Zoranzoki21) [01:54:51] (03CR) 10DannyS712: [C: 04-1] Add phan (031 comment) [extensions/NamespaceHTML] - 10https://gerrit.wikimedia.org/r/694767 (owner: 10Zoranzoki21) [01:55:07] (03CR) 10DannyS712: [C: 04-1] Add phan and make tests passing (031 comment) [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/694755 (owner: 10Zoranzoki21) [01:55:18] (03CR) 10DannyS712: [C: 04-1] Add phan (031 comment) [extensions/LegalLogin] - 10https://gerrit.wikimedia.org/r/694730 (owner: 10Zoranzoki21) [01:55:36] (03CR) 10DannyS712: [C: 04-1] Add phan and make tests passing (031 comment) [extensions/GroupWhitelist] - 10https://gerrit.wikimedia.org/r/694719 (owner: 10Zoranzoki21) [01:55:48] (03CR) 10DannyS712: [C: 04-1] Add phan and make tests passing (031 comment) [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/694702 (owner: 10Zoranzoki21) [01:55:56] (03CR) 10DannyS712: [C: 04-1] Add phan and make tests passing (031 comment) [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/694693 (owner: 10Zoranzoki21) [01:56:04] (03CR) 10DannyS712: [C: 04-1] Add phan (031 comment) [extensions/EncryptedUploads] - 10https://gerrit.wikimedia.org/r/694678 (owner: 10Zoranzoki21) [01:58:18] (03CR) 10DannyS712: [C: 04-1] Add phpcs, phan and make it pass (031 comment) [extensions/Tooltip] - 10https://gerrit.wikimedia.org/r/693573 (owner: 10Zoranzoki21) [02:07:23] (03CR) 10jerkins-bot: [V: 04-1] Phan: enable PhanPossiblyUndeclaredVariable issue warnings [core] - 10https://gerrit.wikimedia.org/r/693646 (https://phabricator.wikimedia.org/T283298) (owner: 10DannyS712) [02:07:52] 10Tool-bridgebot, 10User-bd808: Clean up Freenode bridges - https://phabricator.wikimedia.org/T283397 (10bd808) 05Open→03Resolved a:03bd808 [02:08:19] 10Tool-bridgebot, 10User-bd808: Bridge #mediawiki across freenode and Libera chat - https://phabricator.wikimedia.org/T283274 (10bd808) This bridge is now shutdown. [02:08:27] 10Tool-bridgebot, 10User-bd808: Have wm-bridgebot bridge #wikipedia-it-sysop on Libera like it does on freenode - https://phabricator.wikimedia.org/T283357 (10bd808) This bridge is now shutdown. [02:08:36] 10Tool-bridgebot, 10User-bd808: Bridge #countervandalism between Libera Chat and Freenode IRC - https://phabricator.wikimedia.org/T283297 (10bd808) This bridge is now shutdown. [02:08:44] 10Tool-bridgebot, 10User-bd808: Bridge #wikipedia-nl across freenode and Libera chat - https://phabricator.wikimedia.org/T283430 (10bd808) This bridge is now shutdown. [02:09:00] 10Jouncebot, 10User-bd808: Shutdown Jouncebot on Freenode - https://phabricator.wikimedia.org/T283264 (10bd808) 05Open→03Resolved [02:09:20] 10Stashbot, 10User-bd808: Shutdown Stashbot on Freenode after community migration - https://phabricator.wikimedia.org/T283263 (10MacFan4000) 05Open→03Resolved This has now been done [02:10:17] 10SRE, 10wikimedia-irc-libera: Move SRE-related IRC channels to Libera - https://phabricator.wikimedia.org/T283230 (10bd808) [02:22:26] (03PS6) 10DannyS712: Phan: enable PhanPossiblyUndeclaredVariable issue warnings [core] - 10https://gerrit.wikimedia.org/r/693646 (https://phabricator.wikimedia.org/T283298) [02:22:34] (03PS7) 10DannyS712: Phan: enable PhanPossiblyUndeclaredVariable issue warnings [core] - 10https://gerrit.wikimedia.org/r/693646 (https://phabricator.wikimedia.org/T283298) [02:22:40] (03CR) 10DannyS712: Phan: enable PhanPossiblyUndeclaredVariable issue warnings (033 comments) [core] - 10https://gerrit.wikimedia.org/r/693646 (https://phabricator.wikimedia.org/T283298) (owner: 10DannyS712) [02:27:25] (03PS2) 10Accraze: create external transformer for outlink model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/694756 (https://phabricator.wikimedia.org/T276862) [02:30:05] (03PS2) 10Ejegg: Show non-USD minimum on monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/694729 (https://phabricator.wikimedia.org/T283262) [02:31:08] 10Fundraising-Backlog, 10Fundraising Sprint Ketchup Flume Ride, 10Patch-For-Review: Monthly convert: donate_interface-smallamount-error message not showing correct amount - https://phabricator.wikimedia.org/T283262 (10Ejegg) Good catch on the missing variable substitution, @Pcoombe ! [02:41:16] (03PS1) 10Ejegg: QS option for debugging monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/694897 (https://phabricator.wikimedia.org/T283262) [02:42:47] (03PS1) 10JJMC89: Revert "[IMPR] Use different logfiles for multiple processes (Step 2)" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/694318