[00:00:59] (03PS2) 10BryanDavis: i18n: Add @intlify/eslint-plugin-vue-i18n linter [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652218 [00:02:19] 10Toolhub, 10User-bd808: Configure fallback locales for vue-i18n - https://phabricator.wikimedia.org/T270671 (10bd808) 05Open→03Resolved [00:02:48] 10Toolhub, 10User-bd808: Customize vue-i18n plural support for languages with complex pluralization rules - https://phabricator.wikimedia.org/T270633 (10bd808) 05Open→03Resolved [00:03:12] 10Toolhub, 10User-bd808: Figure out how to provide uselang=qqx equivalent functionality - https://phabricator.wikimedia.org/T269164 (10bd808) 05Open→03Resolved [00:08:13] 10Toolhub, 10I18n: [[Wikimedia:Toolhub-js-newtoolsfound/he]] translation issue - https://phabricator.wikimedia.org/T270810 (10bd808) Related to {T270787}. This is indeed the plural form used by [[https://kazupon.github.io/vue-i18n/|vue-i18n]]. [00:18:16] 10Cloud-VPS (Quota-requests): Request increased quota for wikidumpparse Cloud VPS project - https://phabricator.wikimedia.org/T270637 (10notconfusing) Thanks @Andrew for pointing out that it would be a pain to use a floating IP for a custom domain. I am happy to migrate to the project to use `wmcloud.org` , but... [00:20:02] (03PS3) 10MarkAHershberger: Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 [00:20:04] (03PS4) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [00:20:06] (03PS4) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [00:20:08] (03PS1) 10MarkAHershberger: Ensure that $id is populated for all existing users [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) [00:22:58] (03CR) 10jerkins-bot: [V: 04-1] Ensure that $id is populated for all existing users [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) (owner: 10MarkAHershberger) [00:23:00] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [00:23:14] (03CR) 10jerkins-bot: [V: 04-1] Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 (owner: 10MarkAHershberger) [00:23:16] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [00:29:58] 10MathSearch, 10Goal, 10Platform Team Initiatives (Abstract Schema), 10User-Physikerwelt: Convert MathSearch to AbstractSchema - https://phabricator.wikimedia.org/T270882 (10Peachey88) [00:30:08] 10Structured-Data-Backlog, 10artificial-intelligence: Implement NSFW image classifier using Open NSFW - https://phabricator.wikimedia.org/T214201 (10APerson) True. I propose a rename to "Machine learning filter for shock image vandalism" or something like that. There are probably better terms than "shock image... [00:34:59] 10Toolhub, 10I18n: [[Wikimedia:Toolhub-js-auditlog-summary/he]] translation issue - https://phabricator.wikimedia.org/T270809 (10bd808) The [[https://kazupon.github.io/vue-i18n/|vue-i18n]] library currently being used in the Toolhub project allows `{keyword}` syntax for placeholders that will be replaced with... [00:42:47] (03PS5) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [00:42:49] (03PS5) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [00:45:08] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [00:45:15] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [00:52:16] 10Wikimedia-Fundraising-Banners: Lock icon offset significantly from text on IE browsers - https://phabricator.wikimedia.org/T270899 (10spatton) Sure! I'll ping Sadok on slack. [00:53:15] 10Wikimedia-Fundraising-Banners: Secure 1 variant - https://phabricator.wikimedia.org/T270893 (10spatton) This feedback makes sense, @jbolorinos-ctr, but I'd prefer to keep it unlinked for now! [00:53:18] (03PS1) 10Legoktm: More branch-friendly links [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652221 [00:53:20] (03CR) 10Legoktm: [C: 03+2] More branch-friendly links [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652221 (owner: 10Legoktm) [00:53:22] (03PS1) 10Legoktm: Better skip code for npm advisory 118 [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652222 [00:53:24] (03CR) 10Legoktm: [C: 03+2] Better skip code for npm advisory 118 [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652222 (owner: 10Legoktm) [00:54:00] (03Merged) 10jenkins-bot: More branch-friendly links [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652221 (owner: 10Legoktm) [00:54:04] 10Trust-and-Safety: Disable 2FA for SUL user `Kiran Gopi` - https://phabricator.wikimedia.org/T270881 (10DannyS712) [00:54:07] (03Merged) 10jenkins-bot: Better skip code for npm advisory 118 [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652222 (owner: 10Legoktm) [00:55:24] 10Wikimedia-Fundraising-Banners: Secure 1 variant - https://phabricator.wikimedia.org/T270893 (10spatton) I reviewed all the screenshots and they look good to me, @jbolorinos-ctr. [00:57:38] 10Wikimedia-Fundraising-Banners: Secure 2 variant - https://phabricator.wikimedia.org/T270894 (10spatton) I've reviewed these screenshots, @jbolorinos-ctr, and don't see any errors! [00:59:07] 10Wikimedia-Fundraising-Banners: Secure 3 variant - https://phabricator.wikimedia.org/T270895 (10spatton) I've reviewed these screenshots and don't see any issues w/ the logo, @jbolorinos-ctr. [01:02:19] 10MediaWiki-extensions-Translate, 10I18n: [[MediaWiki:Tpt-old-pages/en]] grammar issue - https://phabricator.wikimedia.org/T270854 (10Tacsipacsi) >>! In T270854#6713153, @Aklapper wrote: > And I don't get what you mean. :) I explained what the problem is with translations; I don't know what makes you think tha... [01:13:06] (03PS1) 10Legoktm: Add tests for build_message() [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652223 [01:13:08] (03CR) 10Legoktm: [C: 03+2] Add tests for build_message() [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652223 (owner: 10Legoktm) [01:13:10] (03PS1) 10Legoktm: Fix loop nesting in build_message() [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652224 [01:13:12] (03CR) 10Legoktm: [C: 03+2] Fix loop nesting in build_message() [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652224 (owner: 10Legoktm) [01:13:53] (03Merged) 10jenkins-bot: Add tests for build_message() [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652223 (owner: 10Legoktm) [01:13:55] (03Merged) 10jenkins-bot: Fix loop nesting in build_message() [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652224 (owner: 10Legoktm) [01:17:16] (03PS1) 10Legoktm: Fix the 118 skip code, one more try [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652225 [01:17:18] (03CR) 10Legoktm: [C: 03+2] Fix the 118 skip code, one more try [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652225 (owner: 10Legoktm) [01:18:05] (03Merged) 10jenkins-bot: Fix the 118 skip code, one more try [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652225 (owner: 10Legoktm) [01:19:18] (03PS1) 10Legoktm: Adjust Dockerfile so we only reinstall requirements.txt when something changes [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652266 [01:19:20] (03CR) 10Legoktm: [C: 03+2] Adjust Dockerfile so we only reinstall requirements.txt when something changes [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652266 (owner: 10Legoktm) [01:20:10] (03Merged) 10jenkins-bot: Adjust Dockerfile so we only reinstall requirements.txt when something changes [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652266 (owner: 10Legoktm) [01:21:06] (03PS1) 10BryanDavis: i18n: Document parameters & plurals; tense change [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) [01:21:34] (03PS1) 10Legoktm: Fix requirements.txt to not install `libup` package [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652268 [01:21:36] (03CR) 10Legoktm: [C: 03+2] Fix requirements.txt to not install `libup` package [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652268 (owner: 10Legoktm) [01:22:19] (03CR) 10BryanDavis: "Amir, are these helpful qqq updates?" [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) (owner: 10BryanDavis) [01:22:21] (03Merged) 10jenkins-bot: Fix requirements.txt to not install `libup` package [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652268 (owner: 10Legoktm) [01:27:05] (03PS1) 10Legoktm: More branch-aware links [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652269 [01:27:06] (03CR) 10Legoktm: [C: 03+2] More branch-aware links [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652269 (owner: 10Legoktm) [01:27:46] (03Merged) 10jenkins-bot: More branch-aware links [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652269 (owner: 10Legoktm) [01:35:45] (03PS1) 10Legoktm: web: Output the 15 most recent runs on the homepage [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652270 [01:35:47] (03CR) 10Legoktm: [C: 03+2] web: Output the 15 most recent runs on the homepage [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652270 (owner: 10Legoktm) [01:36:30] (03Merged) 10jenkins-bot: web: Output the 15 most recent runs on the homepage [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652270 (owner: 10Legoktm) [01:40:34] (03PS1) 10Legoktm: build: Add .eslintignore [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 [02:03:08] (03PS1) 10Legoktm: Treat npm audit "install" actions as updates [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652272 [02:03:10] (03CR) 10Legoktm: [C: 03+2] Treat npm audit "install" actions as updates [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652272 (owner: 10Legoktm) [02:03:12] (03PS1) 10Legoktm: web: Display CVEs for /vulns/npm when available [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652273 [02:03:14] (03CR) 10Legoktm: [C: 03+2] web: Display CVEs for /vulns/npm when available [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652273 (owner: 10Legoktm) [02:03:56] (03Merged) 10jenkins-bot: Treat npm audit "install" actions as updates [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652272 (owner: 10Legoktm) [02:03:58] (03Merged) 10jenkins-bot: web: Display CVEs for /vulns/npm when available [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652273 (owner: 10Legoktm) [02:07:17] (03PS1) 10TrainBranchBot: Branch commit for wmf/1.36.0-wmf.24 [core] (wmf/1.36.0-wmf.24) - 10https://gerrit.wikimedia.org/r/652274 [02:22:57] 10Cloud-VPS (Quota-requests): Request increased quota for wikidumpparse Cloud VPS project - https://phabricator.wikimedia.org/T270637 (10bd808) >>! In T270637#6713321, @notconfusing wrote: > Is custom domains supported with wmcloud? No, vanity domains are not currently supported by the Cloud VPS HTTPS proxy. In... [02:25:24] 10Toolhub, 10I18n, 10Patch-For-Review, 10User-bd808: [[Wikimedia:Toolhub-js-newtoolsfound/he]] translation issue - https://phabricator.wikimedia.org/T270810 (10bd808) p:05Triage→03Medium a:03bd808 [02:25:46] 10Toolhub, 10I18n, 10Patch-For-Review, 10User-bd808: [[Wikimedia:Toolhub-js-auditlog-summary/he]] translation issue - https://phabricator.wikimedia.org/T270809 (10bd808) p:05Triage→03Medium a:03bd808 [02:41:50] (03PS2) 10DannyS712: Branch commit for wmf/1.36.0-wmf.24 [core] (wmf/1.36.0-wmf.24) - 10https://gerrit.wikimedia.org/r/652274 (https://phabricator.wikimedia.org/T267417) (owner: 10TrainBranchBot) [02:41:58] (03Abandoned) 10DannyS712: Branch commit for wmf/1.36.0-wmf.24 [core] (wmf/1.36.0-wmf.24) - 10https://gerrit.wikimedia.org/r/652274 (https://phabricator.wikimedia.org/T267417) (owner: 10TrainBranchBot) [02:42:14] 10Release, 10Train Deployments: 1.36.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T267417 (10DannyS712) [03:03:26] (03CR) 10DannyS712: "why is this needed for LibUp? It doesn't fail for the GlobalWatchlist extension, and that also doesn't have an eslintignore file" [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [03:06:18] (03PS1) 10Eileen: Migrate creation of wmf financial types to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652275 (https://phabricator.wikimedia.org/T270680) [03:07:32] 10Fr-drupal-upgrade-2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fundraising Sprint Zeitgeistbusters, 10Patch-For-Review: Clean up install script from wmf_civicrm & move relevant parts to the extension - https://phabricator.wikimedia.org/T270680 (10Eileenmcnaughton) I'm starting with t... [03:09:01] (03PS2) 10Eileen: Migrate creation of wmf financial types to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652275 (https://phabricator.wikimedia.org/T270680) [03:13:01] (03CR) 10jerkins-bot: [V: 04-1] Migrate creation of wmf financial types to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652275 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [03:16:37] 10Cloud-VPS: IABot needs a new large exec node - https://phabricator.wikimedia.org/T270900 (10Cyberpower678) [03:43:20] 10Cloud-VPS (Quota-requests): IABot needs a new large exec node - https://phabricator.wikimedia.org/T270900 (10JJMC89) [04:03:58] 10Toolhub, 10User-bd808: Investigate using banana-i18n in Toolhub - https://phabricator.wikimedia.org/T270787 (10bd808) p:05Triage→03High a:03bd808 [04:06:54] 10Cloud-VPS (Quota-requests): IABot needs a new large exec node - https://phabricator.wikimedia.org/T270900 (10Legoktm) @Cyberpower678 please use the template at https://phabricator.wikimedia.org/project/view/2880/ to fill out your request [04:13:06] 10Toolhub, 10User-bd808: Investigate using banana-i18n in Toolhub - https://phabricator.wikimedia.org/T270787 (10bd808) The most direct way of integrating Banana would be to implement a vue-i18n custom formatter. This would look something like: `lang=js,lines=10 export default class BananaFormatter { /**... [04:20:33] (03CR) 10Legoktm: "> Patch Set 1:" [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [04:49:24] 04(no projects): API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10Base) [04:54:09] 10Continuous-Integration-Config: Bundlesize should not be cause V-1 when size increases by a few bytes - https://phabricator.wikimedia.org/T270883 (10Ammarpad) It could even fail, and give V-1, when the change is so insignificant to the extent that we end up with strange error due to rounding, see {T268593}. I d... [04:56:18] (03CR) 10DannyS712: [C: 03+1] "> Patch Set 1:" [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [04:58:42] 10Fresh: Document the security reasons for mounting .git as read-only - https://phabricator.wikimedia.org/T259977 (10Legoktm) In addition to writing to .git/hooks, you could also add malicious commits to a git repository that doesn't go through code review. [04:59:52] 10Fresh: Add support for non-rooted container runtime - https://phabricator.wikimedia.org/T259974 (10Legoktm) I'm back to doing development on Fedora, which generally works better with `podman`, so I thought I'd look into this. After doing `s/docker/podman/`, I had to remove the `consistency=` mount options, wh... [05:13:44] 10Front-end-Standards-Group, 10LibUp: LibUp should automatically re-write .eslintrc.json files into the new .eslint.config.js format when using an appropriate (forthcoming) version of eslint - https://phabricator.wikimedia.org/T267941 (10Legoktm) 05Open→03Stalled Please unstall once this is ready for imple... [05:16:44] 10LibUp, 10MediaWiki-extensions-CentralNotice: libup does not commit proposed patch set to gerrit for repo CentralNotice - https://phabricator.wikimedia.org/T264234 (10Legoktm) 05Open→03Resolved a:03Legoktm I noticed this last night when debugging other stuff, the problem used to be that it would clone t... [05:18:46] 10LibUp, 10UI-Standardization: Auto re-configure stylelint to lint vue files too - https://phabricator.wikimedia.org/T264252 (10Legoktm) So is the proposal to have libup find stuff like https://codesearch.wmcloud.org/search/?q=%5C*%5C*%2F%5C*.%5C%7Bcss%2Cless%5C%7D&i=nope&files=&repos= and add `vue` unconditio... [05:21:34] 10LibUp, 10Page-Previews, 10Readers-Web-Backlog (Tracking): Update nvm for libup to match CI - https://phabricator.wikimedia.org/T264328 (10Legoktm) 05Open→03Stalled At this time LibUp is going to continue using the nodejs version in whichever apt packages are convenient. Given that this only an issue fo... [05:24:57] 10LibUp: Automatically clean up the parallel-lint command in composer.json files - https://phabricator.wikimedia.org/T266305 (10Legoktm) https://codesearch.wmcloud.org/search/?q=parallel-lint%20.&i=nope&files=%5Ecomposer.json%24&repos= There are also a few that don't exclude `node_modules`, though those might b... [05:32:02] 10LibUp: Have LibUp track (but not try to upgrade) mediawiki/core and mediawiki/vendor - https://phabricator.wikimedia.org/T268086 (10Legoktm) The data gathering and upgrading phases are pretty linked, I think we should just add those two repos back to the config and let them fail at updating (or miraculously wo... [05:32:57] (03PS1) 10Legoktm: Add mediawiki/core and mediawiki/vendor [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652276 (https://phabricator.wikimedia.org/T268086) [05:32:59] (03CR) 10Legoktm: [C: 03+2] Add mediawiki/core and mediawiki/vendor [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652276 (https://phabricator.wikimedia.org/T268086) (owner: 10Legoktm) [05:33:33] (03Merged) 10jenkins-bot: Add mediawiki/core and mediawiki/vendor [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652276 (https://phabricator.wikimedia.org/T268086) (owner: 10Legoktm) [05:33:56] 10LibUp, 10Patch-For-Review: Have LibUp track (but not try to upgrade) mediawiki/core and mediawiki/vendor - https://phabricator.wikimedia.org/T268086 (10Legoktm) 05Open→03Resolved a:03Legoktm Should show up in the next 24-48 hours. [05:35:02] 10LibUp: Move libup data storage into mysql - https://phabricator.wikimedia.org/T241035 (10Legoktm) 05Open→03Resolved a:03Legoktm [05:35:04] 10LibUp: libup2: Error 502: cannot see individual repository details - https://phabricator.wikimedia.org/T238136 (10Legoktm) [05:35:06] 10LibUp: libup move celery workers to another instance - https://phabricator.wikimedia.org/T228197 (10Legoktm) [05:42:33] (03PS1) 10Legoktm: Bump mediawiki/mediawiki-codesniffer to 19.1.0 on REL1_31 [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652277 (https://phabricator.wikimedia.org/T236070) [05:42:34] (03CR) 10Legoktm: [C: 03+2] Bump mediawiki/mediawiki-codesniffer to 19.1.0 on REL1_31 [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652277 (https://phabricator.wikimedia.org/T236070) (owner: 10Legoktm) [05:43:04] (03Merged) 10jenkins-bot: Bump mediawiki/mediawiki-codesniffer to 19.1.0 on REL1_31 [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652277 (https://phabricator.wikimedia.org/T236070) (owner: 10Legoktm) [05:47:12] 10LibUp, 10Patch-For-Review: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Legoktm) a:03Legoktm I took the long route on this and tried to refactor everything along the way...but I think it's paid off. Just about everything on the web interface https://libraryupgrader2.w... [05:48:07] 10LibUp: libup run of repo Popups fails on npm test with warnings - https://phabricator.wikimedia.org/T243788 (10Legoktm) [05:48:09] 10LibUp, 10Page-Previews, 10Readers-Web-Backlog (Tracking): Update nvm for libup to match CI - https://phabricator.wikimedia.org/T264328 (10Legoktm) [05:49:42] 10LibUp, 10WikibaseMediaInfo, 10Patch-For-Review: libup run of repo WikibaseMediaInfo fails on npm ci with failing wikibase dependencies - https://phabricator.wikimedia.org/T243787 (10Legoktm) >>! In T243787#6309557, @matthiasmullie wrote: > That said, if it's causing issues elsewhere, we can pin it to a spe... [05:55:47] 10LibUp: libup should set warnings to off in .eslintrc.json when using maxWarnings: 0 - https://phabricator.wikimedia.org/T263922 (10Legoktm) https://codesearch.wmcloud.org/search/?q=maxWarnings&i=nope&files=Gruntfile.js&repos= looks like just two repos have this option right now. [05:57:13] (03PS1) 10Legoktm: build: Remove maxWarnings: 0 from eslint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652278 (https://phabricator.wikimedia.org/T263922) [05:57:51] (03PS1) 10Legoktm: build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) [05:59:59] 10Vector: Bundlesize should not be cause V-1 when size increases by a few bytes - https://phabricator.wikimedia.org/T270883 (10Legoktm) This is not an issue in the Wikimedia CI system, but a configuration that is in #Vector and under the control of that component's maintainers. See https://gerrit.wikimedia.org/r... [06:01:40] 10LibUp: 502 Bad Gateway on https://libraryupgrader2.wmcloud.org/ - https://phabricator.wikimedia.org/T262228 (10Legoktm) 05Open→03Resolved [06:04:28] 10LibUp: libup could remove eslint.options.extensions from Gruntfile.js for newer eslint-config-wikimedia - https://phabricator.wikimedia.org/T262221 (10Legoktm) >>! In T262221#6441331, @Esanders wrote: > Specifically, since ESLint 7.0, configs can now set which extensions should be linted, so it doesn't need to... [06:14:32] 10LibUp: libup could remove eslint.options.extensions from Gruntfile.js for newer eslint-config-wikimedia - https://phabricator.wikimedia.org/T262221 (10Legoktm) Hmm, https://github.com/wikimedia/eslint-config-wikimedia/pull/318#issuecomment-692089763 isn't in a release version yet - is that a prerequisite for d... [06:14:46] (03PS1) 10Legoktm: Remove eslint "extensions" config when possible [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652280 (https://phabricator.wikimedia.org/T262221) [06:15:23] (03CR) 10jerkins-bot: [V: 04-1] Remove eslint "extensions" config when possible [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652280 (https://phabricator.wikimedia.org/T262221) (owner: 10Legoktm) [06:17:25] (03PS2) 10Legoktm: Remove eslint "extensions" config when possible [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652280 (https://phabricator.wikimedia.org/T262221) [06:21:50] 10LibUp, 10phan: Teach LibUp how to migrate to new phan using ConfigBuilder - https://phabricator.wikimedia.org/T254571 (10Legoktm) @Daimona: is this ready to be implemented with the current version of mediawiki-phan-config? What's the minimum version that phan needs to be at before this can be used? [06:24:09] (03CR) 10Pastakhov: "This change is ready for review." [extensions/LegalLogin] - 10https://gerrit.wikimedia.org/r/635890 (owner: 10Pastakhov) [06:25:53] (03CR) 10jerkins-bot: [V: 04-1] build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [06:26:55] (03PS2) 10Legoktm: build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) [06:30:33] 10MediaWiki-General: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10Base) [06:37:37] 10LibUp, 10Composer, 10Continuous-Integration-Config, 10Security: Investigate switching PHP security checks to use packagist's new API endpoint - https://phabricator.wikimedia.org/T258291 (10Legoktm) 05Open→03Declined The endpoint doesn't actually do what we need... :( [06:44:30] 10LibUp: libup sometimes cannot update to eslint-config-wikimedia because new errors not added to .eslintrc.json as warning - https://phabricator.wikimedia.org/T262450 (10Legoktm) How are we supposed to figure out which file it should be disabled in? Should we just add it to the closest `.eslintrc.json` and hope... [06:46:46] 10LibUp: libup fails to update eslint-config-wikimedia to 0.17.0 due to old eslint - https://phabricator.wikimedia.org/T261520 (10Legoktm) I believe this is taken care of now that we manually force the bumping of eslint, is that correct? [06:51:25] 10LibUp, 10Patch-For-Review: Puppetize setup on upgrader-06.wmflabs - https://phabricator.wikimedia.org/T173478 (10Legoktm) 05Open→03Resolved Pretty sure this was all finished. [07:00:51] 10MediaWiki-API: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10DannyS712) [07:01:32] 10MediaWiki-API: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10DannyS712) per instructions at #mediawiki-extensions-apisandbox "New tasks regarding API sandbox should go under the MediaWiki-API project." [07:01:56] (03PS1) 10Legoktm: web: Add some more emojis for wm_deployed and bundled repos [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/652281 [07:03:48] 10LibUp: libraryupgrader web ui should mark libs also as "Wikimedia-deployed" - https://phabricator.wikimedia.org/T256635 (10Legoktm) It would be really nice if this could be implemented by adding to https://gerrit.wikimedia.org/r/plugins/gitiles/integration/utils/+/refs/heads/master/wikimediaci_utils/__init__.p... [07:04:52] 10LibUp: Keep the list of packages in libup web when clone fails - https://phabricator.wikimedia.org/T255183 (10Legoktm) 05Open→03Resolved a:03Legoktm This is not a problem in the new database backend because we just won't replace the existing dependency list if the clone fails. [07:07:10] 10LibUp: implement php security scanning in libup - https://phabricator.wikimedia.org/T228108 (10Legoktm) 05Stalled→03Resolved a:03Legoktm Said case appeared: https://libraryupgrader2.wmcloud.org/vulns/composer [07:08:35] 10LibUp: Make a bot to bump our trivial-but-with-security-warnings Ruby CI dependency chain - https://phabricator.wikimedia.org/T181576 (10Legoktm) Is this still needed? For what it's worth, adding a new language/package manager should be much easier now... [07:16:32] 10LibUp: Why libup does not run update of jakub-onderka/php-console-highlighter and mediawiki/minus-x as bundle? - https://phabricator.wikimedia.org/T243862 (10Legoktm) 05Open→03Resolved a:03Legoktm The new configuration system has weights will allow for making sure this happens. Each update in the config... [07:19:22] 10LibUp: libup: Add some form of monitoring or a status page - https://phabricator.wikimedia.org/T229519 (10Legoktm) 05Open→03Resolved a:03Legoktm I'm OK with what's been added so far. We don't monitor the ssh-agent because I don't want the web server to have access to it at all. [07:23:34] 10LibUp: libup move celery workers to another instance - https://phabricator.wikimedia.org/T228197 (10Legoktm) 05Stalled→03Declined {F33977278} This really isn't an issue anymore. [07:23:49] 10LibUp: When bumping devDeps but everything already passes, add a positive message - https://phabricator.wikimedia.org/T195934 (10Legoktm) I don't know what to do with this request. [07:32:25] (03PS1) 10Legoktm: Bump ockcyp/covers-validator to 1.3.3 [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652282 (https://phabricator.wikimedia.org/T270863) [07:45:12] 10Magnus Sälgö: Meeting SKBL dec 2020 - https://phabricator.wikimedia.org/T269498 (10Salgo60) [08:03:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] ParserPreloadTest: Remove unneeded unset calls [core] - 10https://gerrit.wikimedia.org/r/651725 (owner: 10DannyS712) [08:12:18] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/652290 (owner: 10L10n-bot) [08:12:56] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [labs/tools/watch-translations] - 10https://gerrit.wikimedia.org/r/652297 (owner: 10L10n-bot) [08:12:59] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [labs/tools/weapon-of-mass-description] - 10https://gerrit.wikimedia.org/r/652298 (owner: 10L10n-bot) [08:17:36] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/652301 (owner: 10L10n-bot) [08:33:03] (03Merged) 10jenkins-bot: ParserPreloadTest: Remove unneeded unset calls [core] - 10https://gerrit.wikimedia.org/r/651725 (owner: 10DannyS712) [08:52:04] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/RSS] - 10https://gerrit.wikimedia.org/r/652370 (owner: 10L10n-bot) [08:52:23] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/652377 (owner: 10L10n-bot) [08:54:24] 10CheckUser, 10Schema-change: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10Nikerabbit) [08:56:05] 10CheckUser, 10Schema-change: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10Nikerabbit) p:05Triage→03High #7 /srv/mediawiki/workdir/extensions/CheckUser/includes/specials/SpecialCheckUser.php(2033): Wikimedia\\Rdbms\\DBConnRef->selectField('logging', '1', A... [08:57:53] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/RSS] - 10https://gerrit.wikimedia.org/r/652370 (owner: 10L10n-bot) [08:57:56] 10Math, 10Patch-For-Review, 10Platform Team Initiatives (Abstract Schema): Convert Math to AbstractSchema - https://phabricator.wikimedia.org/T268561 (10Ladsgroup) Please read https://www.mediawiki.org/wiki/Manual:Coding_conventions/Database Naming, prefixes, index names, they all need to be fixed here. [08:58:50] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/652377 (owner: 10L10n-bot) [09:12:10] (03PS1) 10Elukey: role::analytics_cluster::hadoop::ui: set analytics-hive endpoint [puppet] - 10https://gerrit.wikimedia.org/r/652394 [09:12:40] (03CR) 10Elukey: [C: 03+2] role::analytics_cluster::hadoop::ui: set analytics-hive endpoint [puppet] - 10https://gerrit.wikimedia.org/r/652394 (owner: 10Elukey) [09:15:44] 10Gerrit, 10Upstream: Use user-select: none for line numbers in Gitiles - https://phabricator.wikimedia.org/T188172 (10Nikerabbit) I cannot reproduce. Fixed? [09:17:23] 10Gerrit: Gitiles does not provide raw view of the file for copy-pasting - https://phabricator.wikimedia.org/T270903 (10Nikerabbit) [09:17:50] (03PS8) 10Pastakhov: Initial commit [extensions/LegalLogin] - 10https://gerrit.wikimedia.org/r/635890 [09:25:41] (03PS1) 10Prernaswarna: Change font and line height Pagelist description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) [09:25:43] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) (owner: 10Prernaswarna) [09:44:24] 10MediaWiki-extensions-Translate, 10I18n: [[MediaWiki:Tpt-old-pages/en]] grammar issue - https://phabricator.wikimedia.org/T270854 (10Aklapper) But proper translations are currently impossible. See what I wrote before here. (Please don't re-subscribe me - thanks a lot! :) [09:48:05] 10Gerrit: Gitiles does not provide raw view of the file for copy-pasting (txt download is base64 encoded) - https://phabricator.wikimedia.org/T270903 (10Aklapper) [09:51:19] 10Gerrit, 10Upstream: Use user-select: none for line numbers in Gitiles - https://phabricator.wikimedia.org/T188172 (10Aklapper) 05Open→03Resolved Indeed, this looks fixed [09:54:14] 10Commons, 10MediaWiki-File-management, 10I18n: In SVG files larger than 256kB with elements, the translations are not recognized - https://phabricator.wikimedia.org/T270889 (10Aklapper) [10:02:44] 10Pywikibot: Edits done by Pywikibot are not flagged as made by bot - https://phabricator.wikimedia.org/T270904 (10RedKhan16) [10:04:27] 10Release, 10Train Deployments: 1.36.0-wmf.25 deployment blockers - https://phabricator.wikimedia.org/T267418 (10DannyS712) [10:04:29] 10CheckUser, 10Schema-change: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10DannyS712) [10:04:31] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Schema-change, 10affects-translatewiki.net: Wikimedia\Rdbms\DBQueryError: Error 1176: Key 'times' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270769 (10DannyS712) [10:08:42] (03CR) 10DannyS712: "This change is ready for review." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [10:08:50] 10Cloud-VPS (Quota-requests): IABot needs a new large exec node - https://phabricator.wikimedia.org/T270900 (10Aklapper) 05Open→03Stalled Please fill out all required data and then reset the status to open. Thanks. [10:09:03] 10CheckUser, 10Patch-For-Review, 10Schema-change, 10User-DannyS712: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10DannyS712) p:05High→03Unbreak! a:03DannyS712 Train blocker -> UBN [10:12:22] 10CheckUser, 10Patch-For-Review, 10Schema-change, 10User-DannyS712: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10Ladsgroup) p:05Unbreak!→03High It is not a train blocker, the log index schema changes won't go live any time soon. [10:14:01] 10Fr-drupal-upgrade-2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fundraising Sprint Zeitgeistbusters, 10Patch-For-Review: Determine if wmf_reports is used by anyone & possibly remove - https://phabricator.wikimedia.org/T270684 (10RLewis) @Eileenmcnaughton and @NNichols I checked with... [10:27:27] (03CR) 10Ladsgroup: [C: 04-1] "This wouldn't work in production, the index is not yet renamed in all database and will cause issues. One way to move forward is to remove" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [10:30:00] 10Pywikibot: Edits done by Pywikibot are not flagged as made by bot - https://phabricator.wikimedia.org/T270904 (10Bugreporter) Please link to a specific recent changes. Does your bot account have bot flag? [10:37:55] (03CR) 10DannyS712: "> Patch Set 2: Code-Review-1" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [10:39:40] 10Pywikibot: Edits done by Pywikibot are not flagged as made by bot - https://phabricator.wikimedia.org/T270904 (10RedKhan16) >>! In T270904#6713545, @Bugreporter wrote: > Please link to a specific recent changes. https://ageofempires.fandom.com/wiki/Special:RecentChanges Name of my bot is [[ https://ageofempire... [10:40:28] 10MathSearch, 10User-Physikerwelt: Convert MathSearch to AbstractSchema - https://phabricator.wikimedia.org/T270882 (10Aklapper) [10:43:14] (03PS1) 10Addshore: Fix typo in BulkSubscriptionUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/652396 [10:43:32] (03CR) 10jerkins-bot: [V: 04-1] Fix typo in BulkSubscriptionUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/652396 (owner: 10Addshore) [10:48:14] 10Pywikibot: Edits done by Pywikibot are not flagged as made by bot - https://phabricator.wikimedia.org/T270904 (10Amire80) 05Open→03Invalid It happens on the level of the account, not on the level of the software you use to make edits. The Red_Khan_Bot must be added to the bots group, and then all its edits... [10:50:47] 10ContentTranslation: Fix bug in the content translator: unwanted scrolling up - https://phabricator.wikimedia.org/T270625 (10Amire80) [10:52:11] (03CR) 10Ladsgroup: [C: 04-1] "> Patch Set 2:" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [11:00:50] 10Growth-Team, 10Notifications: The Echo extension personalUrl hook should use a string and not an array for css class - https://phabricator.wikimedia.org/T262160 (10Seb35) @Mainframe98 Your recent commit a5a8f46958aa82adbb2bc8b531484025b145d5cf is related to this issue, but I’m not sure if you are aware of it... [11:05:02] 10ContentTranslation: The Special:ContentTranslation sometimes a bug in automatic saving occurs - https://phabricator.wikimedia.org/T268070 (10Amire80) [11:05:11] 10Growth-Team, 10Notifications: The Echo extension personalUrl hook should use a string and not an array for css class - https://phabricator.wikimedia.org/T262160 (10Mainframe98) This sounds (and looks) suspiciously like the issue I encountered (and then fixed). If you could confirm that it fixes it, that woul... [11:15:28] 10ContentTranslation, 10Technical-Debt (Deprecation process): fix deprecation issues on cx - https://phabricator.wikimedia.org/T260374 (10Amire80) [11:16:17] (03PS1) 10Majavah: New sniff: `MissingControlStructureBetweenBracketsSniff` [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) [11:16:54] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-Majavah: Create PHPCS/ESLint rule to disallow `if else` blocks with an unnamed block likely intended as `else` - https://phabricator.wikimedia.org/T186939 (10Majavah) a:03Majavah [11:21:08] 10MediaWiki-extensions-SendGrid: Always returns "Unknown error in PHP's mail() function" error - https://phabricator.wikimedia.org/T270905 (10lucamauri) [11:27:18] 10ContentTranslation: CX2 adds nowiki around tags for no reason - https://phabricator.wikimedia.org/T214770 (10Amire80) [11:31:53] 10Wikipedia-Android-App-Backlog, 10Accessibility: Change article toolbar icon and label color to color_group_63 - https://phabricator.wikimedia.org/T270906 (10schoenbaechler) [11:33:04] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Usability test analysis and recommendations - https://phabricator.wikimedia.org/T266884 (10schoenbaechler) Thanks @Janw – this is legit feedback. I just verified the toolbar color and it wasn’t complying our accessibility standards in “Li... [11:42:28] 10Math, 10Patch-For-Review, 10Platform Team Initiatives (Abstract Schema): Convert Math to AbstractSchema - https://phabricator.wikimedia.org/T268561 (10Physikerwelt) >>! In T268561#6713495, @Ladsgroup wrote: > Please read https://www.mediawiki.org/wiki/Manual:Coding_conventions/Database > > Naming, prefixe... [11:52:45] 10Growth-Team, 10MediaWiki-Watchlist: Watchlist grouping mode miscalculates revisions diff - https://phabricator.wikimedia.org/T174567 (10matej_suchanek) [11:53:08] 10Growth-Team, 10MediaWiki-Watchlist: Watchlist grouping mode miscalculates revisions diff - https://phabricator.wikimedia.org/T174567 (10matej_suchanek) [11:53:10] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist: Watchlist and recent changes edits in the same minute are sorted wrong. - https://phabricator.wikimedia.org/T149558 (10matej_suchanek) [11:53:42] 10Wikidata: Number of bytes is not correct in the watchlist - https://phabricator.wikimedia.org/T219217 (10matej_suchanek) [11:53:44] 10Growth-Team, 10MediaWiki-Watchlist: Watchlist grouping mode miscalculates revisions diff - https://phabricator.wikimedia.org/T174567 (10matej_suchanek) [11:59:18] (03PS1) 10Majavah: Use MovePageFactory [extensions/Flow] - 10https://gerrit.wikimedia.org/r/652398 (https://phabricator.wikimedia.org/T252934) [11:59:48] 10Release, 10Train Deployments: 1.36.0-wmf.25 deployment blockers - https://phabricator.wikimedia.org/T267418 (10Majavah) [11:59:50] 10CheckUser, 10Patch-For-Review, 10Schema-change, 10User-DannyS712: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10Majavah) [12:00:01] 10CheckUser, 10Patch-For-Review, 10Schema-change, 10User-DannyS712: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10Majavah) Removing parent task per Amir's comment [12:00:42] 10Growth-Team, 10Notifications: The Echo extension personalUrl hook should use a string and not an array for css class - https://phabricator.wikimedia.org/T262160 (10Carl) @Mainframe98 thanks, unfortunately, I steal stuck in MediaWiki 1.34 due to lack of time to update, so I can't test it but it's reassuring t... [12:04:45] 10Vector: Bundlesize should not be cause V-1 when size increases by a few bytes - https://phabricator.wikimedia.org/T270883 (10Esanders) This is for discussing guidance that would apply to multiple extensions/skins. I don’t know if there is a more appropriate tag, but it is not just Vector. [12:24:10] 10Abstract Wikipedia: [Abstract Wikipedia data science] Modify code to make it usable from both Toolforge and outside environment - https://phabricator.wikimedia.org/T270825 (10LostEnchanter) 05Open→03Resolved [12:24:12] 10Abstract Wikipedia: [Abstract Wikipedia data science] "Quality-of-life" project modifications - https://phabricator.wikimedia.org/T270824 (10LostEnchanter) [12:35:17] 10Math, 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Platform Team Workboards (External Code Reviews), 10Technical-Debt, 10User-DannyS712: Math extension needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T248550 (10Majavah) @DannyS712: is this done? I can't see any uses remaining... [12:36:30] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) [12:37:58] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) a:03LostEnchanter [12:40:17] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) [12:41:36] (03PS1) 10Majavah: Deprecate User::getGrantName in favor of MWGrants::grantName [core] - 10https://gerrit.wikimedia.org/r/652399 (https://phabricator.wikimedia.org/T245963) [12:42:27] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712, 10User-Majavah: Deprecate User::getGrantName in favor of MWGrants::grantName - https://phabricator.wikimedia.org/T245963 (10Majavah) a:03Majavah [12:46:36] 10Wikimedia-Site-requests, 10Wikisource: Delete Translation: namespace to Ukrainian Wikisource - https://phabricator.wikimedia.org/T270628 (10Base) @Arxivist , https://uk.wikisource.org/wiki/Спеціальна:Усі_сторінки/Переклад%3A — оці сторінки тоді стануть сторінками основного простору — це те що ти хочеш? // (... [12:54:49] (03PS1) 10Ammarpad: Handle Logging index that's being renamed [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652400 (https://phabricator.wikimedia.org/T270902) [12:56:36] (03PS1) 10Ammarpad: Better handling for Logging index that's being renamed [core] - 10https://gerrit.wikimedia.org/r/652401 (https://phabricator.wikimedia.org/T270769) [13:03:52] 10WMIT-Infrastructure: Install PHP-FPM in Wikimedia Italia VPS centos01 (to coexist PHP 5.6 with 7.3) - https://phabricator.wikimedia.org/T270776 (10valerio.bozzolan) WARNING: I'm working on this now. [13:05:11] (03CR) 10Ammarpad: [C: 03+2] build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [13:06:44] 10Wikidata, 10Wikidata-Query-Service, 10Discovery-Search (Current work), 10Patch-For-Review: SPARQL-Query shows entries, which should be filter out; number of entries in result set might change when executed repeatedly (possible caching/indexing problem) - https://phabricator.wikimedia.org/T267175 (10Multic... [13:08:34] 10Pywikibot: Edits done by Pywikibot are not flagged as made by bot - https://phabricator.wikimedia.org/T270904 (10Xqt) 05Invalid→03Open Reopened because Red_Khan_Bot is a member of bot class see: https://ageofempires.fandom.com/wiki/Special:Log?type=rights&user=&page=Red_Khan_Bot&wpdate=&tagfilter=&subtype=... [13:16:09] 10MediaWiki-extensions-SendGrid: Always returns "Unknown error in PHP's mail() function" error - https://phabricator.wikimedia.org/T270905 (10Aklapper) Hmm, in theory https://www.mediawiki.org/wiki/Manual:How_to_debug#PHP_errors but not sure if `mail()` exposes any error codes... [13:19:24] 10MediaWiki-extensions-SendGrid: Always returns "Unknown error in PHP's mail() function" error - https://phabricator.wikimedia.org/T270905 (10Majavah) I don't think the extension is supposed to use `mail()` at all - looking at the code it uses SendGrid's HTTP api to send the messages [13:20:34] 10Pywikibot: Edits done by Pywikibot are not flagged as made by bot - https://phabricator.wikimedia.org/T270904 (10Xqt) @RedKhan16: could you please verify the bot flag right for your bot via userinfo content e.g. like: ` >>> import pywikibot >>> site = pywikibot.Site() >>> site.sitename 'wikipedia:de' >>> info... [13:21:29] 04(no projects): test all templates in the kaios app - https://phabricator.wikimedia.org/T270907 (10Jpita) [13:22:00] (03CR) 10Ammarpad: [C: 03+2] Drop maintenance scripts for pre-Actor migration, now no-ops [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605872 (owner: 10Jforrester) [13:22:25] (03CR) 10Ammarpad: [C: 03+2] Drop wgActorTableSchemaMigrationStage compatibility [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605870 (owner: 10Jforrester) [13:22:44] 10Inuka-Team (Kanban): test all templates in the kaios app - https://phabricator.wikimedia.org/T270907 (10Jpita) [13:26:04] 10SyntaxHighlight, 10Upstream: syntaxhighlight doesn't highlight "VALUES" in SPARQL - https://phabricator.wikimedia.org/T264175 (10Aklapper) 05Stalled→03Open >>! In T264175#6670961, @LucasWerkmeister wrote: > updated Pygments recently ([I0be3c1c204](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Syn... [13:31:07] 10Wikibugs, 10phabricator maintenance bot: Don't notify actions by @Phabricator_maintenance - https://phabricator.wikimedia.org/T141570 (10Nintendofan885) [13:32:15] 10Phabricator, 10phabricator maintenance bot: Share the @Phabricator_maintenance account credentials (password) with at least one Phabricator Admin - https://phabricator.wikimedia.org/T141641 (10Nintendofan885) [13:32:46] 10phabricator maintenance bot, 10Phabricator (Upstream), 10Upstream: Need a way to disable web notifications from certain accounts (phabricator_maintenance) - https://phabricator.wikimedia.org/T142918 (10Nintendofan885) [13:33:26] (03Merged) 10jenkins-bot: build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [13:33:28] (03Merged) 10jenkins-bot: Drop wgActorTableSchemaMigrationStage compatibility [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605870 (owner: 10Jforrester) [13:33:30] (03Merged) 10jenkins-bot: Drop maintenance scripts for pre-Actor migration, now no-ops [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605872 (owner: 10Jforrester) [13:34:55] (03CR) 10Ladsgroup: [C: 03+2] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/652401 (https://phabricator.wikimedia.org/T270769) (owner: 10Ammarpad) [13:35:53] 10Phabricator, 10phabricator maintenance bot: Create special maintenance account - https://phabricator.wikimedia.org/T141638 (10Nintendofan885) [13:37:01] 10Math, 10Patch-For-Review, 10Platform Team Initiatives (Abstract Schema): Convert Math to AbstractSchema - https://phabricator.wikimedia.org/T268561 (10Ladsgroup) PK doesn't need a name, for PK you can just use the "pk" option. See https://github.com/wikimedia/mediawiki/blob/master/maintenance/tables.json f... [13:38:34] 10Wikimedia-Site-requests, 10Wikisource: Delete Translation: namespace to Ukrainian Wikisource - https://phabricator.wikimedia.org/T270628 (10Urbanecm) From a technical perspective, it is preferable to only delete namespaces when they were never used. Deleting a namespace would mean that all pages that are/wer... [13:43:55] (03CR) 10Ammarpad: "recheck" [core] - 10https://gerrit.wikimedia.org/r/651506 (https://phabricator.wikimedia.org/T147908) (owner: 10Diwanshu885) [13:44:06] 10MediaWiki-API: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10Base) So it was quite hastily submitted, here is a better example: I need to restore a revision for a page: * I execute an action=query&prop=deletedrevisions query and get a a timestamp like `2020-12-29... [13:44:35] (03PS1) 10Majavah: Remove usage of hard deprecated function wfIsBadImage() [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/652402 (https://phabricator.wikimedia.org/T249459) [13:44:37] (03PS4) 10Ammarpad: Prevent rcfilters menuselect widgets from winding up behind content on some skins [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [13:45:23] 10WMIT-Infrastructure: Wikimedia Italia's Kanboard: try plugin-budget - https://phabricator.wikimedia.org/T270759 (10valerio.bozzolan) WARNING: I'm working on this now to celebrate my Christmas holidays 🎉 [13:46:55] 10WMIT-Infrastructure: Wikimedia Italia's Kanboard: try plugin-budget - https://phabricator.wikimedia.org/T270759 (10valerio.bozzolan) 05Open→03Resolved Done. The user documentation is here: https://github.com/kanboard/plugin-budget/find/master#documentation [13:48:05] 10Wikimedia-Site-requests, 10Wikisource: Delete Translation: namespace to Ukrainian Wikisource - https://phabricator.wikimedia.org/T270628 (10Base) > Deleting a namespace would mean that all pages that are/were in it (deleted or not) would be inaccessible without sysadmin intervention, since the system would n... [13:49:54] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Patch-For-Review, 10Technical-Debt (Deprecation process): Hard deprecate global function wfIsBadImage and remove a release later - https://phabricator.wikimedia.org/T249459 (10Majavah) I sent patches to mediawiki/extensions/PhpTagsWidgets... [13:52:52] (03PS1) 10Majavah: Remove hard deprecated wfIsBadImage() [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) [13:53:42] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-Majavah: Hard deprecate global function wfIsBadImage and remove a release later - https://phabricator.wikimedia.org/T249459 (10Majavah) a:03Majavah [13:55:16] (03PS2) 10Majavah: Remove hard deprecated wfIsBadImage() [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) [13:57:53] 10SyntaxHighlight, 10Upstream: syntaxhighlight doesn't highlight "VALUES" in SPARQL - https://phabricator.wikimedia.org/T264175 (10LucasWerkmeister) 05Open→03Resolved Verification doesn’t hurt: {F33977566} It works \o/ [13:58:02] 10Growth-Team, 10Notifications: The Echo extension personalUrl hook should use a string and not an array for css class - https://phabricator.wikimedia.org/T262160 (10Seb35) 05Open→03Resolved a:03Mainframe98 I was not able to reproduce it when I originally seen it with the skin Chameleon (versions changed... [13:59:10] (03CR) 10Ammarpad: [C: 03+2] build: Remove maxWarnings: 0 from eslint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652278 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [14:01:55] 10Pywikibot: Edits done by Pywikibot are not flagged as made by bot - https://phabricator.wikimedia.org/T270904 (10RedKhan16) @Xqt Sorry, took me some time to figure out how to use the API. Request `/api.php?action=query&format=json&meta=userinfo&uiprop=blockinfo%7Cgroups%7Crights%7Chasmsg` Result ` { "ba... [14:05:19] (03Merged) 10jenkins-bot: Better handling for Logging index that's being renamed [core] - 10https://gerrit.wikimedia.org/r/652401 (https://phabricator.wikimedia.org/T270769) (owner: 10Ammarpad) [14:05:57] (03Merged) 10jenkins-bot: build: Remove maxWarnings: 0 from eslint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652278 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [14:13:06] (03CR) 10Ammarpad: [C: 03+2] Add data attribute to the elements with class "history-size" [core] - 10https://gerrit.wikimedia.org/r/651506 (https://phabricator.wikimedia.org/T147908) (owner: 10Diwanshu885) [14:13:38] 10LibUp, 10Documentation: Document weight - https://phabricator.wikimedia.org/T270908 (10Reedy) [14:15:36] (03PS1) 10Majavah: Soft deprecate wfIncrStats() [core] - 10https://gerrit.wikimedia.org/r/652404 (https://phabricator.wikimedia.org/T250316) [14:15:39] (03CR) 10Xqt: Move -except and -excepttext to global page generator filters (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/639204 (https://phabricator.wikimedia.org/T219281) (owner: 10Diwanshu885) [14:15:54] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Deprecate global function wfIncrStats - https://phabricator.wikimedia.org/T250316 (10Majavah) The only remaining use is in [[ https://www.mediawiki.org/wiki/Extension:ParsoidBatchAPI | ParsoidBatchAPI ]] which may be archived so... [14:16:00] (03CR) 10Xqt: [C: 04-1] Move -except and -excepttext to global page generator filters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/639204 (https://phabricator.wikimedia.org/T219281) (owner: 10Diwanshu885) [14:17:00] (03Abandoned) 10Reedy: Add support for branches to libraryupgrader config [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/586408 (https://phabricator.wikimedia.org/T236071) (owner: 10Reedy) [14:17:15] (03Abandoned) 10Reedy: Add branch support to libup [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/586401 (https://phabricator.wikimedia.org/T236071) (owner: 10Reedy) [14:17:55] (03PS4) 10Reedy: Update TOTP Scrach Tokens to array [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/548481 (https://phabricator.wikimedia.org/T237303) [14:17:57] 10Pywikibot, 10Pywikibot-pagegenerators.py, 10Pywikibot-replace.py, 10Patch-For-Review, 10good first task: Move -except from add_text.py and -excepttext from replace.py to global page generator filters - https://phabricator.wikimedia.org/T219281 (10Xqt) -excepttext from replace.py has a different meaning... [14:18:07] (03PS5) 10Reedy: Update TOTP Scratch Tokens to array [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/548481 (https://phabricator.wikimedia.org/T237303) [14:19:37] (03PS2) 10Reedy: Remove comment about "Same regex as above in https_recv_redirect" [puppet] - 10https://gerrit.wikimedia.org/r/606457 [14:19:41] (03PS3) 10Reedy: Remove comment about "Same regex as above in https_recv_redirect" [puppet] - 10https://gerrit.wikimedia.org/r/606457 [14:19:53] (03CR) 10jerkins-bot: [V: 04-1] Update TOTP Scratch Tokens to array [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/548481 (https://phabricator.wikimedia.org/T237303) (owner: 10Reedy) [14:20:13] (03PS4) 10Reedy: Remove comment about "Same regex as above in https_recv_redirect" [puppet] - 10https://gerrit.wikimedia.org/r/606457 [14:20:56] (03PS9) 10Reedy: Make import.php call delete.php as it has the same functionality [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/479901 [14:21:54] 10MediaWiki-Cache, 10Performance-Team, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Technical-Debt (Deprecation process): Deprecate and remove SquidPurgeClient classes - https://phabricator.wikimedia.org/T250417 (10Majavah) 1.36 cycle is now on-going. What would be the next step? Those classes aren't `@n... [14:22:09] (03Abandoned) 10Reedy: Updating composer/semver (1.5.1 => 2.0.0) [core] - 10https://gerrit.wikimedia.org/r/600365 (owner: 10Reedy) [14:22:59] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Platform Team Workboards (Clinic Duty Team), 10Technical-Debt (Deprecation process): Deprecate and remove CachedAction, SpecialCachedPage and CacheHelper after 1.35 is branched - https://phabricator.wikimedia.org/T249230 (10Majavah) 05Stalled→03Open Movi... [14:23:42] (03CR) 10Reedy: [C: 03+2] Leave comment about adding and removing users [wikimedia/security/tooling/peek] - 10https://gerrit.wikimedia.org/r/642920 (owner: 10Reedy) [14:24:10] (03Merged) 10jenkins-bot: Leave comment about adding and removing users [wikimedia/security/tooling/peek] - 10https://gerrit.wikimedia.org/r/642920 (owner: 10Reedy) [14:24:38] (03Abandoned) 10Reedy: Link to phab pastes [labs/tools/stashbot] - 10https://gerrit.wikimedia.org/r/637065 (https://phabricator.wikimedia.org/T266848) (owner: 10Reedy) [14:25:05] (03PS3) 10Reedy: Score: Use fluidsynth instead of timidity [vagrant] - 10https://gerrit.wikimedia.org/r/634716 [14:25:29] (03PS2) 10Reedy: Remove old list of sites listed on miscweb [puppet] - 10https://gerrit.wikimedia.org/r/627551 [14:28:07] (03PS1) 10Majavah: Remove Revision::getParentLengths() [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) [14:28:37] (03PS5) 10Xqt: [cleanup] remove deprecated weblinkchecker LinkChecker class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/649665 [14:31:39] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] remove deprecated weblinkchecker LinkChecker class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/649665 (owner: 10Xqt) [14:31:48] 10InternetArchiveBot: IABot job 6943 is not working - https://phabricator.wikimedia.org/T270831 (10Nintendofan885) [14:33:06] 10InternetArchiveBot: IABot job 6943 is not working - https://phabricator.wikimedia.org/T270831 (10Nintendofan885) This is do to T269831 [14:33:26] 10Magnus Sälgö: SOFI dialects - https://phabricator.wikimedia.org/T235738 (10Salgo60) [14:33:52] 10InternetArchiveBot: IABot job 6943 is not working - https://phabricator.wikimedia.org/T270831 (10Nintendofan885) [14:33:58] 10InternetArchiveBot: IABot job queue has been stuck for weeks again - https://phabricator.wikimedia.org/T269831 (10Nintendofan885) [14:35:06] 10Magnus Sälgö: New version "SOFI namnregister" for places - https://phabricator.wikimedia.org/T235814 (10Salgo60) [14:38:45] (03PS9) 10Xqt: [IMPR] Improvements for solve_disambiguation.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/638038 (https://phabricator.wikimedia.org/T266997) [14:38:46] 10Structured Data Engineering, 10Structured-Data-Backlog, 10UploadWizard: Cannot choose "of" as qualifier from suggestion box in UploadWizard - https://phabricator.wikimedia.org/T269496 (10Aklapper) [14:40:08] 10MediaWiki-extensions-Other: WindowsAzureStorage Extension - extension need to use latest Azure storage blob sdk. - https://phabricator.wikimedia.org/T256492 (10Mglaser) @Tam-edwin-microsoft I merged your changes. If you have more stuff that needs to be merged, please feel free to ping me at glaser@hallowelt.co... [14:41:14] (03Merged) 10jenkins-bot: Add data attribute to the elements with class "history-size" [core] - 10https://gerrit.wikimedia.org/r/651506 (https://phabricator.wikimedia.org/T147908) (owner: 10Diwanshu885) [14:41:41] (03PS6) 10Xqt: [cleanup] remove deprecated weblinkchecker LinkChecker class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/649665 [14:41:58] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromRow - https://phabricator.wikimedia.org/T248504 (10Majavah) Code search is claiming this has some uses in [[ https://github.com/enterprisemediawiki/WatchAnalytics | enterprisemediawiki/WatchAnalyti... [14:43:56] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getRevisionText - https://phabricator.wikimedia.org/T248549 (10Majavah) This has some uses in Translate, one of them has a comment saying `Should only happen with MW < 1.34.` [14:44:16] (03PS2) 10Majavah: Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) [14:46:41] (03CR) 10Mpaa: [C: 03+1] Move -except and -excepttext to global page generator filters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/639204 (https://phabricator.wikimedia.org/T219281) (owner: 10Diwanshu885) [14:49:16] 10LibUp, 10Documentation: Document weight - https://phabricator.wikimedia.org/T270908 (10Reedy) [15:05:17] 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth, 10Platform Team Initiatives (Decoupling (CDP2)): Remove UserRightsProxy and replace it's usages with UserGroupManager - https://phabricator.wikimedia.org/T255309 (10Majavah) [15:06:05] 10Wikimedia-Site-requests, 10Wikisource: Delete Translation: namespace to Ukrainian Wikisource - https://phabricator.wikimedia.org/T270628 (10Arxivist) >>! In T270628#6713622, @Base wrote: > @Arxivist , https://uk.wikisource.org/wiki/Спеціальна:Усі_сторінки/Переклад%3A — оці сторінки тоді стануть сторінками о... [15:11:58] (03CR) 10jerkins-bot: [V: 04-1] Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [15:13:03] 10Wikimedia-Site-requests, 10Wikisource: Delete Translation: namespace to Ukrainian Wikisource - https://phabricator.wikimedia.org/T270628 (10Arxivist) >>! In T270628#6713658, @Urbanecm wrote: > From a technical perspective, it is preferable to only delete namespaces when they were never used. Deleting a names... [15:14:00] (03PS3) 10Majavah: Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) [15:31:53] 10PAWS: Some public PAWS files give 504 errors - https://phabricator.wikimedia.org/T270820 (10Daniel_Mietchen) p:05Triage→03High [15:34:52] 10Phabricator: Create special maintenance account - https://phabricator.wikimedia.org/T141638 (10Nintendofan885) [15:35:54] 10Phabricator (Upstream), 10Upstream: Need a way to disable web notifications from certain accounts (phabricator_maintenance) - https://phabricator.wikimedia.org/T142918 (10Nintendofan885) [15:36:03] 10Phabricator: Share the @Phabricator_maintenance account credentials (password) with at least one Phabricator Admin - https://phabricator.wikimedia.org/T141641 (10Nintendofan885) [15:36:13] 10Wikibugs: Don't notify actions by @Phabricator_maintenance - https://phabricator.wikimedia.org/T141570 (10Nintendofan885) [15:42:18] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Ipatrol) tstarling, do you know why it currently works so long as the vorbis=1 parameter is removed?... [15:46:14] (03PS3) 10Majavah: Update GlobalBlocking to use the new HookContainer/HookRunner system [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652184 (https://phabricator.wikimedia.org/T270871) [15:48:12] (03CR) 10Majavah: Update GlobalBlocking to use the new HookContainer/HookRunner system (033 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652184 (https://phabricator.wikimedia.org/T270871) (owner: 10Majavah) [15:50:19] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Ipatrol) Also, I need to know what "time" means here, because the above fact means that it's possible... [16:01:15] 10MediaWiki-extensions-Translate, 10I18n: [[MediaWiki:Tpt-old-pages/en]] grammar issue - https://phabricator.wikimedia.org/T270854 (10Tacsipacsi) I could perfectly translate this for example into German: ` {{PLURAL:$1|Die neuste Version dieser Seite ist|Die neusten Versionen dieser Seiten sind}} zur Übersetzun... [16:02:13] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) Note that the new DNS record `matomo.wikimedia.it` is not available yet. ` $ nslookup matomo.wikimedia.it ** server can't find matomo.wikimedia.it: NXDOMAIN ` [16:10:05] 10Phabricator, 10Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586 (10Aklapper) >>! In T108586#6711982, @Ladsgroup wrote: > @Aklapper Hey, is it fine if we move the group 4 herald rules to maintenance bot? Is there any general info av... [16:16:33] 10Diff-blog, 10Operations, 10Technical blog, 10Traffic, 10HTTPS: Send HSTS header on all Wordpress VIP-hosted domains - https://phabricator.wikimedia.org/T270034 (10Nintendofan885) [16:25:20] 10MediaWiki-extensions-General, 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews), and 2 others: Wikimedia deployed extensions need uses of global $wgOut removed - https://phabricator.wikimedia.org/T252978 (10Majavah) [16:28:49] 10Cloud-VPS (Quota-requests): IABot needs a new large exec node - https://phabricator.wikimedia.org/T270900 (10Cyberpower678) 05Stalled→03Open Project Name: cyberbot Type of quota increase requested: 8 CPUs and 16 GB RAM Reason: IABot is expanding on to more WMF wikis, which requires more processing power.... [16:31:30] 10Wikimedia-Site-requests, 10Wikisource: Delete Translation: namespace to Ukrainian Wikisource - https://phabricator.wikimedia.org/T270628 (10Urbanecm) >>! In T270628#6713666, @Base wrote: >> Deleting a namespace would mean that all pages that are/were in it (deleted or not) would be inaccessible without sysad... [16:36:53] 10Wikimedia-Fundraising-Banners: QA: wider mobile small banner - https://phabricator.wikimedia.org/T270909 (10Pcoombe) [16:40:10] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Reedy) You'll have to ask the people working on it. You probably won't get an answer till next week.... [16:50:17] 10Wikidata: Add a rank for outdated but correct data - https://phabricator.wikimedia.org/T210961 (10Nikki) This could potentially be useful for old URLs too: We could display URLs in outdated statements differently from those in normal/preferred rank statements. e.g. There was a topic on Wikidata:Administrators... [16:58:40] 10Math, 10Patch-For-Review, 10Platform Team Initiatives (Abstract Schema): Convert Math to AbstractSchema - https://phabricator.wikimedia.org/T268561 (10Physikerwelt) >>! In T268561#6713656, @Ladsgroup wrote: > PK doesn't need a name, for PK you can just use the "pk" option. See https://github.com/wikimedia/... [16:58:42] 10Wikimedia-Fundraising-Banners: QA: wider mobile small banner - https://phabricator.wikimedia.org/T270909 (10jbolorinos-ctr) Sure! Taking a look now [17:01:59] (03PS1) 10Jack Phoenix: Fix Vector themes for MW 1.35, bump ext. version number + explicitly require MW 1.35(+) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/652406 [17:02:32] 10Pywikibot: Pywikibot does not suppress InvalidTitle error traceback - https://phabricator.wikimedia.org/T270910 (10Dominicbm) [17:04:11] 10Wikimedia-Fundraising-Banners: QA: wider mobile small banner - https://phabricator.wikimedia.org/T270909 (10jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/za320c13140b698b637f Screenshot Test Results - Mobile (Expanded): https://app.cr... [17:05:00] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Community-consensus-needed: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Multichill) [17:06:28] 10Android-app-Bugs, 10Page Content Service, 10Product-Infrastructure-Team-Backlog, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: [BUG] Thumb border images in articles shown are being shown with no border in the Android app - https://phabricator.wikimedia.org/T198534 (10vadim-kovalenko) a:03vadim-... [17:06:30] 10Wikimedia-Fundraising-Banners: Secure 1 variant - https://phabricator.wikimedia.org/T270893 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr Thanks for also double checking that Sam! Signing off on QA for this now, no blockers found and everything looks good. Closing as Resolved [17:06:32] 10Wikimedia-Fundraising-Banners: Dsk lg security lock icons below form - https://phabricator.wikimedia.org/T270890 (10jbolorinos-ctr) [17:07:00] 10Wikimedia-Fundraising-Banners: Secure 2 variant - https://phabricator.wikimedia.org/T270894 (10jbolorinos-ctr) Signing off on QA for this variant now. No blockers found, this banner is READY TO TEST! [17:07:05] 10Wikimedia-Fundraising-Banners: Dsk lg security lock icons below form - https://phabricator.wikimedia.org/T270890 (10jbolorinos-ctr) [17:07:07] 10Wikimedia-Fundraising-Banners: Secure 2 variant - https://phabricator.wikimedia.org/T270894 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr [17:07:41] 10AbuseFilter, 10Wikimedia-Site-requests, 10Wikimedia-abusefilter-global-maintainers: Devise a strategy for optimal utilization of abusefilter-maintainers group - https://phabricator.wikimedia.org/T251051 (10Majavah) Does this task have anything actionable remaining or can it be closed? [17:08:23] 10Wikimedia-Fundraising-Banners: Dsk lg security lock icons below form - https://phabricator.wikimedia.org/T270890 (10jbolorinos-ctr) [17:09:01] 10Wikimedia-Fundraising-Banners: Secure 3 variant - https://phabricator.wikimedia.org/T270895 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr Signing off on QA for this variant now. No Blockers found, closing as Resolved [17:11:22] 10Wikimedia-Fundraising-Banners: Lock icon offset significantly from text on IE browsers - https://phabricator.wikimedia.org/T270899 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr Fix verified: {F33977705} [17:11:24] 10Wikimedia-Fundraising-Banners: Icon lock variant - https://phabricator.wikimedia.org/T270896 (10jbolorinos-ctr) [17:11:26] 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Syntax highlighting does not recognise slash in tag parameter string correctly - https://phabricator.wikimedia.org/T270880 (10Aklapper) [17:11:28] 10MediaWiki-extensions-Page_Forms: Add example to #arraymap function documentation - https://phabricator.wikimedia.org/T270869 (10Aklapper) [17:11:30] 10Wikimedia-Fundraising-Banners: Icon lock variant - https://phabricator.wikimedia.org/T270896 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr Signing off on QA for this now, all issues found have been reported and addressed. Closing as Resolved [17:11:32] 10Wikimedia-Fundraising-Banners: Dsk lg security lock icons below form - https://phabricator.wikimedia.org/T270890 (10jbolorinos-ctr) [17:11:51] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Community-consensus-needed: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Multichill) [17:11:54] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Community-consensus-needed: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Fuzheado) I concur with this - for the GLAM community, we have not recommended GWToolset at all in the last two years, and have... [17:11:55] 10Wikimedia-Fundraising-Banners: Dsk lg security lock icons below form - https://phabricator.wikimedia.org/T270890 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr Signing off on QA now for these variants @spatton All bugs found have been reported and addressed! Closing task as Resolved [17:12:02] 10MediaWiki-File-management, 10SRE-swift-storage, 10Wikimedia-production-error: Cannot delete one image file on Thai Wikipedia: Error deleting file: An unknown error occurred in storage backend "local-multiwrite" - https://phabricator.wikimedia.org/T270811 (10Aklapper) Thanks for reporting this. For future r... [17:12:04] 10MediaWiki-File-management, 10SRE-swift-storage, 10Wikimedia-production-error: Cannot delete one image file on Thai Wikipedia: Error deleting file: An unknown error occurred in storage backend "local-multiwrite" - https://phabricator.wikimedia.org/T270811 (10Aklapper) [17:12:54] 10Pywikibot: "ratelimited" API error does not wait to retry for purge - https://phabricator.wikimedia.org/T270912 (10Dominicbm) [17:13:02] 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-Other, 10Technical-Debt (Deprecation process), 10User-DannyS712: Consider removing wfIncrStats - https://phabricator.wikimedia.org/T264977 (10Majavah) [17:13:05] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Deprecate global function wfIncrStats - https://phabricator.wikimedia.org/T250316 (10Majavah) [17:13:25] 10Wikimedia-Fundraising-Banners: [Enhancement] Rearrange CC logos in a line rather than a square (for better viewing on tablets and horizontal orientations) - https://phabricator.wikimedia.org/T270913 (10jbolorinos-ctr) [17:15:11] 10Wikimedia-Fundraising-Banners: Mobile small w/ payment methods visible in step 2 - https://phabricator.wikimedia.org/T270887 (10jbolorinos-ctr) Hey @EWilfong_WMF, yes this is the same as control, so I agree for the purpose of this test it doesnt make sense to update it. I've jotted this note down as an enhance... [17:15:41] 10Wikimedia-Fundraising-Banners: Mobile small w/ payment methods visible in step 2 - https://phabricator.wikimedia.org/T270887 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr Signing off on QA for this variant now - all bugs found have been reported and addressed. Closing this task as Resolved. [17:18:44] 10Beta-Cluster-Infrastructure, 10Wikidata, 10Wikidata-Campsite, 10Regression, and 2 others: A revision of https://wikidata.beta.wmflabs.org/wiki/Q64 consistently doesn't load on beta wikidata - https://phabricator.wikimedia.org/T249018 (10Majavah) I can't reproduce this anymore - can this be closed? [17:26:39] (03PS2) 10Majavah: New sniff: `MissingControlStructureBetweenBracketsSniff` [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) [17:29:11] 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Developer account creation without OpenStackManager - https://phabricator.wikimedia.org/T196171 (10Majavah) Is this still stalled? #CAS-SSO was rolled out earlier this year [17:31:08] 10Pywikibot: Pywikibot does not handle InvalidTitle error - https://phabricator.wikimedia.org/T270910 (10Dominicbm) [17:38:00] 10Wikimedia-Fundraising-Banners: QA: wider mobile small banner - https://phabricator.wikimedia.org/T270909 (10jbolorinos-ctr) No blockers found, these variants look great! [17:44:55] 10AutoWikiBrowser, 10WorkType-Maintenance: General fixes reorders {{Ds/talk notice}} and {{Gs/talk notice}} improperly - https://phabricator.wikimedia.org/T270914 (10GoingBatty) [17:45:09] 10AutoWikiBrowser, 10WorkType-Maintenance: General fixes reorders {{Ds/talk notice}} and {{Gs/talk notice}} improperly - https://phabricator.wikimedia.org/T270914 (10GoingBatty) [17:49:32] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) [17:51:58] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) I support this generally. Do we know how widely it's actually used? Obviously that needs to be a factor, mak... [17:52:49] 10AutoWikiBrowser, 10WorkType-Maintenance: General fixes reorders {{Ds/talk notice}} and {{Gs/talk notice}} improperly - https://phabricator.wikimedia.org/T270914 (10GoingBatty) [17:54:40] 10PAWS: Set up a Wikimedia BinderHub deployment to allow PAWS-hosted public notebooks to be run - https://phabricator.wikimedia.org/T270915 (10Daniel_Mietchen) [17:54:59] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Wittylama) >>! In T270911#6713903, @Reedy wrote: > Do we know how widely it's actually used? It is rarely used, and... [17:55:54] 10PAWS: "Launch in Binder" button for public PAWS notebooks - https://phabricator.wikimedia.org/T266943 (10Daniel_Mietchen) I just set up T270915 to discuss a Wikimedia BinderHub deployment. [17:56:03] 10AutoWikiBrowser, 10WorkType-Maintenance: General fixes reorders {{Ds/talk notice}} and {{Gs/talk notice}} improperly - https://phabricator.wikimedia.org/T270914 (10GoingBatty) [17:57:08] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Majavah) The [[ https://commons.wikimedia.org/wiki/Special:ListUsers/gwtoolset | user group ]] is currently granted... [17:57:51] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) >>! In T270911#6713918, @Wittylama wrote: >>>! In T270911#6713903, @Reedy wrote: >> Do we know how widely it'... [18:05:53] 10Thumbor: Some SVG elements failed to convert into PNG image because they are refering another elements - https://phabricator.wikimedia.org/T270630 (10SiBr4) The same issue occurred on the Olympic flag files [[ https://commons.wikimedia.org/wiki/User_talk:SiBr4#File:Flag_of_the_Solomon_Islands.svg |... [18:07:06] 10MediaWiki-General: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) [18:07:49] 10MediaWiki-General: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) [18:10:27] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) So since 2016, ~550K log entries: `lang=sql MariaDB [commonswiki]> select COUNT(ct_id) from change_tag where... [18:13:46] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Multichill) Thanks Sam, can you do a per user per year breakdown? I expect a small number of users with a lot of upl... [18:16:51] 10Thumbor: Some SVG elements failed to convert into PNG image because they are refering another elements - https://phabricator.wikimedia.org/T270630 (10Great_Brightstar) [18:17:52] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) And in a bit more of a graphical format `lang=csv, lines=10 2016-02, 7578 2016-03, 3907 2016-04, 4889 2016-0... [18:21:54] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) Totals per year... `lang=sql MariaDB [commonswiki]> select YEAR(log_timestamp), count(ct_id) from change_tag... [18:24:01] (03PS2) 10Subramanya Sastry: Experimental: Disable rt-testing mode [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 [18:24:57] 10MediaWiki-REST-API, 10Parsoid, 10VisualEditor: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Reedy) [18:29:21] (03CR) 10Bartosz Dziewoński: [C: 03+2] Use LESS nesting in messageBoxes.less [core] - 10https://gerrit.wikimedia.org/r/651982 (owner: 10Esanders) [18:30:09] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) >>! In T270911#6713923, @Majavah wrote: > The [[ https://commons.wikimedia.org/wiki/Special:ListUsers/gwtools... [18:35:32] (03CR) 10Subramanya Sastry: [C: 03+2] "Merging to kick off rt testing to see what falls out. Can revert if we decide not to pursue this for whatever reasons. But, the holiday ti" [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 (owner: 10Subramanya Sastry) [18:43:00] 10MediaWiki-REST-API, 10Parsoid, 10VisualEditor: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) Seems to affect Flow only, works with VE. [18:45:51] 10MediaWiki-REST-API, 10Parsoid, 10VisualEditor: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) URL: "https://test2.miraheze.org/w/rest.php/test2.miraheze.org/v3/transform/wikitext/to/html/Topic%3AVz5uwxnb5dt80i8u" [18:50:25] (03CR) 10Reedy: [C: 04-1] Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [18:52:04] (03Merged) 10jenkins-bot: Use LESS nesting in messageBoxes.less [core] - 10https://gerrit.wikimedia.org/r/651982 (owner: 10Esanders) [18:52:07] (03CR) 10jerkins-bot: [V: 04-1] Experimental: Disable rt-testing mode [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 (owner: 10Subramanya Sastry) [18:54:44] 10Pywikibot: Pywikibot does not handle Wikibase "wikibase-validator-sitelink-conflict" error - https://phabricator.wikimedia.org/T270917 (10Dominicbm) [18:56:59] 10MediaWiki-extensions-Pluggable-Auth: PluggableAuth: Add hook when users are created - https://phabricator.wikimedia.org/T270918 (10MarkAHershberger) [18:58:14] (03PS2) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [19:07:25] 10ULS-CompactLinks, 10UniversalLanguageSelector: CLL - double entries for language selection - https://phabricator.wikimedia.org/T191272 (10Amire80) [19:08:35] (03CR) 10Reedy: [C: 04-1] Update SpecialRenameuser to inject services (037 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:14:33] (03PS3) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [19:14:38] (03CR) 10Majavah: Update SpecialRenameuser to inject services (037 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:14:50] (03CR) 10Majavah: Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:16:22] 10AutoWikiBrowser, 10WorkType-Maintenance: General fixes reorders {{Old XfD multi}} improperly - https://phabricator.wikimedia.org/T270919 (10GoingBatty) [19:18:39] (03CR) 10Bartosz Dziewoński: "I can reproduce that. It only affects Chrome though. Seems to be caused by the 'tabIndex: -1' in LinkAnnotation." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/651722 (https://phabricator.wikimedia.org/T172694) (owner: 10Esanders) [19:19:29] 10AutoWikiBrowser, 10WorkType-Maintenance: General fixes does not reorder {{Hong Kong English}} - https://phabricator.wikimedia.org/T270920 (10GoingBatty) [19:21:59] 10AutoWikiBrowser, 10WorkType-Maintenance: General fixes does not reorder all Varieties of English templates - https://phabricator.wikimedia.org/T270920 (10GoingBatty) [19:22:39] 10MediaWiki-extensions-Pluggable-Auth: PluggableAuth: Add hook when users are created - https://phabricator.wikimedia.org/T270918 (10MarkAHershberger) I guess what I'm saying is; Should I just use the UserAuthorization hook? It looks like I should, so feel free to WONTFIX. Still, I'm leery of the possibility t... [19:25:19] 10AutoWikiBrowser, 10WorkType-Maintenance: Talk page general fixes does not reorder all Varieties of English templates - https://phabricator.wikimedia.org/T270920 (10GoingBatty) [19:25:26] 10AutoWikiBrowser, 10WorkType-Maintenance: Talk page general fixes reorders {{Old XfD multi}} improperly - https://phabricator.wikimedia.org/T270919 (10GoingBatty) [19:25:31] (03CR) 10Subramanya Sastry: [C: 03+2] "recheck" [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 (owner: 10Subramanya Sastry) [19:25:34] 10AutoWikiBrowser, 10WorkType-Maintenance: Talk page general fixes reorders {{Ds/talk notice}} and {{Gs/talk notice}} improperly - https://phabricator.wikimedia.org/T270914 (10GoingBatty) [19:25:51] 10AutoWikiBrowser, 10WorkType-Maintenance: Talk page general fixes does not move {{GA}} to proper position - https://phabricator.wikimedia.org/T270745 (10GoingBatty) [19:26:12] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) Is there much work to migrate from GWToolset to Pattypan? It feels like one of those if there's not, and no... [19:29:22] (03CR) 10Reedy: [C: 04-1] Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:31:14] (03PS4) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [19:32:35] (03CR) 10Majavah: Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:36:25] 10AutoWikiBrowser, 10WorkType-Maintenance: Talk page general fixes reorders {{Peer review}} improperly - https://phabricator.wikimedia.org/T270921 (10GoingBatty) [19:39:15] 10MediaWiki-File-management, 10SRE-swift-storage, 10Wikimedia-production-error: Cannot delete one image file on Thai Wikipedia: Error deleting file: An unknown error occurred in storage backend "local-multiwrite" - https://phabricator.wikimedia.org/T270811 (10Timekeepertmk) Thank you for your suggestion and... [19:41:39] (03CR) 10jerkins-bot: [V: 04-1] Experimental: Disable rt-testing mode [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 (owner: 10Subramanya Sastry) [19:42:41] (03CR) 10Subramanya Sastry: [C: 03+2] "Really strange. Only php 7.4 tests are failing." [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 (owner: 10Subramanya Sastry) [19:43:09] (03CR) 10Subramanya Sastry: [V: 03+2 C: 03+2] Experimental: Disable rt-testing mode [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 (owner: 10Subramanya Sastry) [19:43:44] (03CR) 10Subramanya Sastry: [V: 03+2 C: 03+2] "I am going to force merge this for running tests. The jenkins issues can be investigated next week." [services/parsoid] - 10https://gerrit.wikimedia.org/r/652200 (owner: 10Subramanya Sastry) [19:50:07] 10AutoWikiBrowser: Change one criteria of tagging in ARwiki - https://phabricator.wikimedia.org/T270922 (10Jar) [19:58:56] 10Commons, 10GLAM, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Wittylama) >>! In T270911#6713999, @Reedy wrote: > Is there much work to migrate from GWToolset to Pattypan? What d... [19:59:29] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate $wgConf - https://phabricator.wikimedia.org/T212739 (10Majavah) As far as I can see the SiteConfiguration class/$wgConf has two distinct purposes. First, it can configure MediaWiki based on the current wiki's database name and "wiki tags" w... [20:11:09] (03CR) 10Reedy: [C: 03+2] build: Add .eslintignore [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [20:15:27] (03Merged) 10jenkins-bot: build: Add .eslintignore [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [20:19:25] (03PS1) 10Andrew Bogott: nfs: include python3-dateutil [puppet] - 10https://gerrit.wikimedia.org/r/652407 [20:19:42] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Schema-change, 10affects-translatewiki.net: Wikimedia\Rdbms\DBQueryError: Error 1176: Key 'times' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270769 (10Umherirrender) In the past there was some index alias support... [20:21:41] (03CR) 10Andrew Bogott: [C: 03+2] nfs: include python3-dateutil [puppet] - 10https://gerrit.wikimedia.org/r/652407 (owner: 10Andrew Bogott) [20:23:38] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10RhinosF1) [20:24:24] 10WMIT-Infrastructure: Install PHP-FPM in Wikimedia Italia VPS centos01 (to coexist PHP 5.6 with 7.3) - https://phabricator.wikimedia.org/T270776 (10valerio.bozzolan) 05Open→03Resolved Here the intervention interaction: ` $ sudo yum -y install centos-release-scl.noarch Loaded plugins: fastestmirror Loading... [20:24:26] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) [20:25:32] 10ProofreadPage: ProofreadPage should support jpg/png as single-page documents - https://phabricator.wikimedia.org/T270924 (10kamholz) [20:27:55] 10MediaWiki-Codesniffer: phpcs should treat {@inheritDoc} like @inheritDoc - https://phabricator.wikimedia.org/T270830 (10Umherirrender) The extra {} are not used on mediawiki code style (at least on single tags) and therefor not detected as valid tag. [20:29:26] (03CR) 10DannyS712: [C: 04-1] "Per https://gerrit.wikimedia.org/r/c/mediawiki/core/+/614027/ we are waiting until 1.37 to remove the Revision stuff" [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [20:30:10] (03PS1) 10David Kamholz: Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) [20:30:30] 10Growth-Team, 10MediaWiki-REST-API, 10Parsoid, 10StructuredDiscussions: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Universal_Omega) [20:34:22] (03CR) 10jerkins-bot: [V: 04-1] Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [20:34:46] (03CR) 10DannyS712: ""ControlStructure" is just a fancy way of saying "else" in this case, right? Since the sniff's full name already includes ControlStructure" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [20:35:23] (03PS1) 10Umherirrender: Handle possible whitespace on license names [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652409 [20:36:00] (03CR) 10DannyS712: New sniff: `MissingControlStructureBetweenBracketsSniff` (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [20:36:31] (03PS1) 10Amire80: Remove an unnecessary space in a message [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/652410 [20:36:33] 10Wikidata, 10Maps (Kartographer): Kartographer maplink (via Wikidata) provides several broken links to external map services - https://phabricator.wikimedia.org/T270925 (10UV) [20:36:51] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Reedy) 05Open→03Invalid Pretty sure you've not deployed a schema change - {T231170} brought it up to 767 chars [20:37:57] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10RhinosF1) 2019? Is there any easy way to look for schema changes not done? [20:37:59] 10Mathe für Nicht-Freaks: Epimorphismus: Satz zur Äquivalente Charakterisierung auch für nicht endlich erzeuge VR hinzufügen - https://phabricator.wikimedia.org/T270261 (10Mathewally) a:03Mathewally [20:38:23] 10Mathe für Nicht-Freaks: Epimorphismus: Satz zur Äquivalente Charakterisierung auch für nicht endlich erzeuge VR hinzufügen - https://phabricator.wikimedia.org/T270261 (10Mathewally) Satz ergänzt [20:38:44] 10MediaWiki-Codesniffer: phpcs ObjectTypeHintParam is incorrect. - https://phabricator.wikimedia.org/T269332 (10Umherirrender) Various extensions get fixed in the past weeks https://codesearch.wmcloud.org/search/?q=ObjectTypeHint&i=nope&files=&repos= Some libs are not fixable, because there are valid use cases... [20:40:23] 10Math, 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Platform Team Workboards (External Code Reviews), 10Technical-Debt, 10User-DannyS712: Math extension needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T248550 (10DannyS712) 05Open→03Resolved a:03DannyS712 >>! In T248550#6... [20:40:26] 10MediaWiki-extensions-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), 10Patch-For-Review, and 2 others: WMF deployed extensions need uses of global $wgUser removed [tracking] - https://phabricator.wikimedia.org/T245959 (10DannyS712) [20:42:01] (03CR) 10DannyS712: [C: 03+1] Handle possible whitespace on license names [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652409 (owner: 10Umherirrender) [20:42:56] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Paladox) >>! In T270923#6714071, @Reedy wrote: > Pretty sure you've not deployed a schema change - {T231170} brought it up to 767 chars We that applied: ` | gb... [20:43:15] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10RhinosF1) 05Invalid→03Open [20:44:21] (03CR) 10Umherirrender: "Does this (release branches) run with autofix?" [labs/libraryupgrader/config] - 10https://gerrit.wikimedia.org/r/652277 (https://phabricator.wikimedia.org/T236070) (owner: 10Legoktm) [20:45:29] (03CR) 10Majavah: "> Patch Set 2:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [20:45:45] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Reedy) ` php > var_dump( strlen( '(Likely web host with a company name like Triple T Internet Company Limited, a Pakkret, Nonthaburi, Thailand-based concern.) Us... [20:46:13] (03PS1) 10Reedy: Updating christian-riesen/base32 (1.3.2 => 1.4.0) [vendor] - 10https://gerrit.wikimedia.org/r/652411 [20:46:36] (03PS1) 10Reedy: Update christian-riesen/base32 (1.3.2 => 1.4.0 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/652412 [20:46:39] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Paladox) "Web host or proxy. Contact cvt{{@}}miraheze.org if affected.: (Likely web host with a company name like Triple T Internet Company Limited, a Pakkret, N... [20:48:06] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Reedy) ` php > var_dump( strlen( 'Web host or proxy. Contact cvt{{@}}miraheze.org if affected.: (Likely web host with a company name like Triple T Internet Compa... [20:48:50] (03CR) 10Majavah: "ah, I just read your comments that said "Cannot be removed until 1.36". I'll abandon if the whole class is going to be removed then anyway" [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [20:49:17] (03Abandoned) 10Majavah: Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [20:50:59] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Paladox) Yeh, I checked the db and the schema it shows is: ` MariaDB [metawiki]> describe globalblocks; +----------------+----------------+------+-----+--------... [20:51:43] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Paladox) some how manually running it worked. [20:56:16] (03CR) 10DannyS712: [C: 03+2] "hard deprecated in 1.35" [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [20:56:34] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Paladox) Found it... I was looking at the wrong database. ` MariaDB [mhglobal]> describe globalblocks; +----------------+----------------+------+-----+---------... [20:57:05] (03CR) 10DannyS712: [C: 04-1] Remove usage of hard deprecated function wfIsBadImage() (031 comment) [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/652402 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [20:59:34] (03Abandoned) 10Majavah: Remove usage of hard deprecated function wfIsBadImage() [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/652402 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [21:00:43] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:00:51] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:08] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:13] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromPageId - https://phabricator.wikimedia.org/T248424 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:14] (03PS1) 10Reedy: Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 [21:01:15] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getParentLengths - https://phabricator.wikimedia.org/T248036 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:17] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:19] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getTimestampFromId - https://phabricator.wikimedia.org/T248423 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:33] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::userCanBitfield - https://phabricator.wikimedia.org/T246411 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:46] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:54] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromRow - https://phabricator.wikimedia.org/T248504 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:56] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:58] 10MediaWiki-Revision-backend, 10MediaWiki-extensions-Duplicator, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newNullRevision - https://phabricator.wikimedia.org/T245703 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision r... [21:02:00] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:02:02] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:02:13] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromTitle - https://phabricator.wikimedia.org/T250705 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:02:15] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getRevisionText - https://phabricator.wikimedia.org/T248549 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:02:17] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:02:21] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromId - https://phabricator.wikimedia.org/T254704 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:04:16] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getRevisionText - https://phabricator.wikimedia.org/T248549 (10DannyS712) >>! In T248549#6713735, @Majavah wrote: > This has some uses in Translate, one of them has a comment saying `Should only happen wi... [21:04:32] 10GlobalBlocking, 10Schema-change, 10User-RhinosF1: Error 1406: Data too long for column 'gb_reason' - https://phabricator.wikimedia.org/T270923 (10Reedy) 05Open→03Invalid >>! In T270923#6714071, @Reedy wrote: > Pretty sure you've not deployed a schema change - {T231170} brought it up to 767 chars [21:05:07] (03CR) 10jerkins-bot: [V: 04-1] Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 (owner: 10Reedy) [21:05:10] (03PS1) 10Umherirrender: Allow parenthesis as punction on @var types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652414 (https://phabricator.wikimedia.org/T268087) [21:05:36] 10MediaWiki-Codesniffer, 10Patch-For-Review: False positive MediaWiki.Commenting.PropertyDocumentation.NotPunctuationVarType - https://phabricator.wikimedia.org/T268087 (10Umherirrender) p:05Triage→03Medium a:03Umherirrender [21:05:51] (03PS2) 10Reedy: Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 [21:08:56] 10MediaWiki-Codesniffer, 10PHP 8.0 support, 10User-DannyS712: Create sniff for `match` errors in PHP 8.0 - https://phabricator.wikimedia.org/T267689 (10Umherirrender) `php -l`/parallel-lint would fail when running with php8 - but the newer versions are not running as part of the normal pipeline and in the pa... [21:11:37] (03CR) 10Umherirrender: [V: 03+2] "no jenkins here" [extensions/LDAPSyncAll] - 10https://gerrit.wikimedia.org/r/652023 (owner: 10Libraryupgrader) [21:12:17] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/650719 (owner: 10Libraryupgrader) [21:13:41] (03CR) 10DannyS712: [C: 03+2] Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 (owner: 10Reedy) [21:14:41] (03CR) 10DannyS712: [C: 03+2] Remove an unnecessary space in a message [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/652410 (owner: 10Amire80) [21:14:53] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/650869 (owner: 10Libraryupgrader) [21:16:48] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Nemo_bis) >>! In T257066#6713124, @Ipatrol wrote: > Assuming the problem is the CVE, Debian [[ https:... [21:17:25] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:17:38] (03CR) 10DannyS712: [C: 04-1] Update SpecialRenameuser to inject services (034 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [21:20:36] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/650932 (owner: 10Libraryupgrader) [21:22:19] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:23:17] (03CR) 10Amire80: "> Patch Set 1:" [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) (owner: 10BryanDavis) [21:24:03] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [21:24:27] (03Merged) 10jenkins-bot: Remove hard deprecated wfIsBadImage() [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [21:24:30] (03Merged) 10jenkins-bot: Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 (owner: 10Reedy) [21:24:32] (03Merged) 10jenkins-bot: Remove an unnecessary space in a message [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/652410 (owner: 10Amire80) [21:26:10] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 (032 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/650932 (owner: 10Libraryupgrader) [21:26:41] (03PS2) 10Amire80: Fix the message "The language in which this toolinfo..." [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/651912 [21:28:16] (03PS4) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [21:33:03] (03CR) 10Esanders: Added bracket matching (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/647320 (https://phabricator.wikimedia.org/T261857) (owner: 10Svantje Lilienthal) [21:33:15] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:33:48] (03CR) 10Esanders: [C: 04-1] "This change is ready for review." [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:34:07] (03PS4) 10Esanders: Integrated bracket matching for CodeMirror with VisualEditor [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:34:15] (03CR) 10jerkins-bot: [V: 04-1] Integrated bracket matching for CodeMirror with VisualEditor [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:34:22] (03PS5) 10Esanders: Integrated bracket matching for CodeMirror with VisualEditor [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:35:16] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/TwoColConflict] - 10https://gerrit.wikimedia.org/r/650937 (owner: 10Libraryupgrader) [21:36:40] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:37:13] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/650893 (owner: 10Libraryupgrader) [21:41:47] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/650833 (owner: 10Libraryupgrader) [21:43:32] 10AutoWikiBrowser: ApiXmlException in ApiEdit.CheckForErrors - https://phabricator.wikimedia.org/T270884 (10yisrael12) [21:44:07] 10AutoWikiBrowser: ApiXmlException in ApiEdit.CheckForErrors - https://phabricator.wikimedia.org/T270884 (10yisrael12) [21:44:42] (03PS2) 10Umherirrender: build: Updating dependencies [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/652022 (owner: 10Libraryupgrader) [21:45:33] (03PS4) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:47:16] (03PS1) 10Umherirrender: Forbid compact() as opposite of forbidden extract() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652415 [21:49:41] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:50:20] (03CR) 10Umherirrender: "Usage:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652415 (owner: 10Umherirrender) [21:52:55] 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Refine bracket matching styling - https://phabricator.wikimedia.org/T270926 (10Esanders) [21:53:13] (03PS5) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:53:55] (03CR) 10Umherirrender: "[It seems taint-check cannot track the taintness of array keys when using compact()]" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:55:41] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [21:56:30] (03CR) 10DannyS712: [C: 03+1] Forbid compact() as opposite of forbidden extract() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652415 (owner: 10Umherirrender) [21:57:11] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Technical-Debt (Deprecation process), 10User-Majavah: Hard deprecate global function wfIsBadImage and remove a release later - https://phabricator.wikimedia.org/T249459 (10DannyS712) 05Open→03Resolved [21:58:32] (03PS1) 10Umherirrender: Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 [22:00:48] (03PS1) 10Umherirrender: Replace compact() with real array [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/652417 [22:02:11] (03PS1) 10Umherirrender: Replace compact() with real array [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/652418 [22:02:30] (03PS6) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [22:02:47] (03CR) 10jerkins-bot: [V: 04-1] Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 (owner: 10Umherirrender) [22:03:03] (03PS7) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [22:07:03] (03PS2) 10Umherirrender: Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 [22:09:28] 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Refine bracket matching styling - https://phabricator.wikimedia.org/T270926 (10Esanders) Atom/Sublime style: {F33977965} `lang=less &.CodeMirror-matchingbracket { color: inherit; border-bottom: 1px solid #000; } ` Ace/VSCode style: {F33977963} `lang=less... [22:11:01] (03CR) 10Hashar: [C: 04-1] "doc1001 is still on Debian Stretch with php7.0. Guess we can look at moving it to php 7.2 like the MediaWiki app servers or align it with " [integration/docroot] - 10https://gerrit.wikimedia.org/r/651195 (owner: 10Jforrester) [22:11:37] (03CR) 10jerkins-bot: [V: 04-1] Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 (owner: 10Umherirrender) [22:12:34] 10phan-taint-check-plugin: taint-check does not support compact() - https://phabricator.wikimedia.org/T270927 (10Umherirrender) [22:14:05] (03PS3) 10Umherirrender: Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 [22:14:56] (03CR) 10Esanders: Integrated bracket matching for CodeMirror with VisualEditor (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [22:17:20] (03PS5) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [22:17:59] 04(no projects): Double slash bug for resource URLs on MW 1.36-alpha (f7cba78) with Vector (c5a6164) - https://phabricator.wikimedia.org/T269955 (10Aklapper) 05Stalled→03Declined Unfortunately closing this Phabricator task as no further information has been provided. @ishlo_je: After you have provided the... [22:18:14] 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Refine bracket matching styling - https://phabricator.wikimedia.org/T270926 (10Esanders) [22:18:20] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/650893 (owner: 10Libraryupgrader) [22:25:26] (03CR) 10Esanders: TableDiffFormatter: Build HTML using utility class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/652191 (owner: 10Esanders) [22:25:47] (03PS2) 10Esanders: TableDiffFormatter: Build HTML using utility class [core] - 10https://gerrit.wikimedia.org/r/652191 [22:25:49] (03PS5) 10Esanders: Create diff markers with CSS [core] - 10https://gerrit.wikimedia.org/r/651809 [22:25:51] (03PS7) 10Esanders: POC Re-arrange diff into a grid layout [core] - 10https://gerrit.wikimedia.org/r/651830 (https://phabricator.wikimedia.org/T270775) [22:26:32] (03PS1) 10Umherirrender: Fix object docs and remove return value from hook [extensions/ArticleIndex] - 10https://gerrit.wikimedia.org/r/652419 [22:31:11] (03PS1) 10Umherirrender: Improve some docs [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/652420 [22:32:16] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Upstream: Gerrit out of heap - https://phabricator.wikimedia.org/T263008 (10hashar) a:03hashar [22:32:59] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/652421 [22:34:34] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/652422 [22:38:29] (03PS1) 10Umherirrender: Improve some param docs [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/652423 [22:42:57] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/652424 [22:44:02] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/652425 [22:46:34] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/652426 [22:47:25] (03PS3) 10BryanDavis: i18n: Add @intlify/eslint-plugin-vue-i18n linter [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652218 [22:47:45] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/652427 [22:48:08] (03PS2) 10BryanDavis: i18n: Document parameters & plurals; tense change [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) [22:55:32] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/SemanticGenealogy] - 10https://gerrit.wikimedia.org/r/652428 [22:56:45] (03CR) 10jerkins-bot: [V: 04-1] Use real types instead of object type in documentation [extensions/SemanticGenealogy] - 10https://gerrit.wikimedia.org/r/652428 (owner: 10Umherirrender) [22:58:12] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/652429 [22:59:05] (03PS1) 10Umherirrender: Fix documentation stdClass array as object type [extensions/THICC] - 10https://gerrit.wikimedia.org/r/652430 [22:59:54] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/652431 [23:01:34] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/652432 [23:02:21] (03CR) 10jerkins-bot: [V: 04-1] Fix documentation about stdClass as object type [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/652424 (owner: 10Umherirrender) [23:04:26] 10MediaWiki-extensions-Pluggable-Auth: PluggableAuth: Add hook when users are created - https://phabricator.wikimedia.org/T270918 (10cicalese) p:05Triage→03Low I think it would be best to use the UserAuthorization hook for now. I have plans to do some refactoring. I don't anticipate that hook changing place,... [23:04:44] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/652433 [23:06:29] (03CR) 10jerkins-bot: [V: 04-1] Fix documentation about stdClass as object type [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/652432 (owner: 10Umherirrender) [23:08:44] (03PS2) 10Umherirrender: Fix documentation about stdClass as object type [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/652432 [23:09:24] 10Community-Tech, 10IA Upload, 10Internet-Archive: Not upload djvu files because pd file was uploaded - https://phabricator.wikimedia.org/T270928 (10Shooke) [23:11:24] 10Community-Tech, 10IA Upload, 10Internet-Archive: Not upload djvu files because pdf file was uploaded with ia-upload.toolforge.org - https://phabricator.wikimedia.org/T270928 (10Shooke) [23:11:44] 10Community-Tech, 10IA Upload, 10Internet-Archive: Not upload djvu files because pdf file was uploaded with ia-upload.toolforge.org - https://phabricator.wikimedia.org/T270928 (10Shooke) [23:14:22] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/652434 [23:15:34] 10Community-Tech, 10IA Upload, 10Internet-Archive: Not upload djvu files ia-upload.toolforge.org because pdf file was uploaded - https://phabricator.wikimedia.org/T270928 (10Shooke) [23:15:54] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/BlueSpiceNSFileRepoConnector] - 10https://gerrit.wikimedia.org/r/652435 [23:16:00] 10Community-Tech, 10IA Upload, 10Internet-Archive: Not upload djvu files with ia-upload.toolforge.org because pdf file was uploaded - https://phabricator.wikimedia.org/T270928 (10Shooke) [23:17:21] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/652436 [23:18:13] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/652437 [23:19:01] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/652438 [23:19:05] (03CR) 10Cicalese: [C: 04-1] "-1 due to concerns about potentially overwriting the value of $id. Should it check to see if $id is set first?" (031 comment) [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) (owner: 10MarkAHershberger) [23:20:24] (03CR) 10Cicalese: [C: 03+1] Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 (owner: 10MarkAHershberger) [23:21:29] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/652439 [23:22:15] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/652440 [23:23:00] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/652441 [23:23:41] 10Data-Services, 10cloud-services-team (Kanban): meta_p treats skrwiki as English-language wiki - https://phabricator.wikimedia.org/T270839 (10Urbanecm) I always add new language to langlist when I make the initial config patch. I'm not sure if that used to be different before I and @Ladsgroup took over wiki c... [23:24:13] 10Community-Tech, 10IA Upload, 10Wikisource: Presence of PDF file with given filename or IA identifer blocks attempts to regenerate alternate file for the associated identifier - https://phabricator.wikimedia.org/T269518 (10Shooke) I had not seen that you had reported the same problem, ( i reported https://... [23:24:46] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpiceUEModuleBookPDF] - 10https://gerrit.wikimedia.org/r/652442 [23:25:24] (03CR) 10Cicalese: [C: 03+1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [23:26:23] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/652443 [23:27:51] (03PS1) 10Umherirrender: build: Explict exclude object type hint inline [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/652444 [23:39:51] (03PS1) 10Eileen: Move total_usd field to custom field code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652445 (https://phabricator.wikimedia.org/T270680) [23:42:56] (03PS1) 10Eileen: Move gateway_account to array-based install [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652446 (https://phabricator.wikimedia.org/T270680) [23:55:01] (03PS1) 10Eileen: Move update 7005 custom field adds to array-based install [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652447 (https://phabricator.wikimedia.org/T270680) [23:56:37] (03CR) 10jerkins-bot: [V: 04-1] Move total_usd field to custom field code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652445 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [23:58:10] (03CR) 10jerkins-bot: [V: 04-1] Move gateway_account to array-based install [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652446 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [23:59:53] (03PS1) 10Eileen: Move update 7012 custom field adds to array-based install [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/652448 (https://phabricator.wikimedia.org/T270680)