[00:00:50] (03Merged) 10jenkins-bot: Explicitly call Message::parse instead of string cast [extensions/FileImporter] - 10https://gerrit.wikimedia.org/r/598201 (owner: 10Umherirrender) [00:01:27] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/598215 [00:11:03] (03CR) 10Krinkle: [C: 03+2] "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/593882 (owner: 10Shirayuki) [00:11:34] (03PS6) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [00:12:08] (03CR) 10Krinkle: "Confirmed meanwhile. The implicit default from __toString() is already parse()." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/598202 (owner: 10Umherirrender) [00:13:31] (03PS2) 10Krinkle: Explicitly format Message oject instead of string cast [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/598202 (owner: 10Umherirrender) [00:13:41] (03PS7) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [00:14:19] (03CR) 10Krinkle: [C: 03+1] "LGTM. Might be worth explaining though why these two should have simple text only? I think that's generally a good direction to use (less " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/598202 (owner: 10Umherirrender) [00:16:58] (03PS8) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [00:21:20] (03PS9) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [00:22:21] (03CR) 10Krinkle: [C: 04-1] Add new SiteStatistics class to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [00:25:27] (03PS10) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [00:27:44] (03PS11) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [00:27:49] (03CR) 10DannyS712: Add new SiteStatistics class to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [00:27:59] (03PS12) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [00:29:50] (03PS11) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [00:30:27] (03Merged) 10jenkins-bot: site: Update @since tag from 1.20 to 1.21 for $wgSiteTypes [core] - 10https://gerrit.wikimedia.org/r/593882 (owner: 10Shirayuki) [00:31:18] (03PS13) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [00:31:30] (03CR) 10Krinkle: Merge htmlform.checker.js into special.userlogin.signup.js (032 comments) [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) (owner: 10DannyS712) [00:32:00] (03PS9) 10Krinkle: Merge htmlform.checker.js into special.userlogin.signup.js module [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) (owner: 10DannyS712) [00:34:23] (03CR) 10Krinkle: [C: 03+1] "Tested by opening Special:CreateAccount, typing an existing username, moving to the next field, and confirming that 1) It says the name is" [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) (owner: 10DannyS712) [00:47:26] (03CR) 10jerkins-bot: [V: 04-1] Merge htmlform.checker.js into special.userlogin.signup.js module [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) (owner: 10DannyS712) [00:47:53] (03PS1) 10Krinkle: LoginSignupSpecialPage: Clean up old/confusing module structure [core] - 10https://gerrit.wikimedia.org/r/598216 [00:52:20] (03CR) 10Krinkle: Add new SiteStatistics class to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [00:52:23] (03CR) 10Krinkle: [C: 03+1] Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [00:53:59] (03CR) 10Krinkle: [C: 03+1] "Looiks like the linter is confused by the ".js" directly. I find it confusing as well and fixed that in the next commit, but.. oh well, lo" [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) (owner: 10DannyS712) [01:00:07] (03PS12) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [01:00:51] (03PS1) 10Krinkle: Rename mediawiki.special.userlogin.signup.js to mediawiki.special.createaccount [core] - 10https://gerrit.wikimedia.org/r/598217 [01:03:37] (03CR) 10jerkins-bot: [V: 04-1] LoginSignupSpecialPage: Clean up old/confusing module structure [core] - 10https://gerrit.wikimedia.org/r/598216 (owner: 10Krinkle) [01:03:47] (03PS10) 10Krinkle: Merge htmlform.checker.js into special.userlogin.signup.js module [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) (owner: 10DannyS712) [01:15:55] (03PS13) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [01:35:25] (03PS10) 10Ephemeralwaves: Selenium: add page object [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/592508 (https://phabricator.wikimedia.org/T240766) [01:36:39] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10tstarling) >>! In T242218#6160632, @Krinkle wrote: > The `array_push` construct is very rare in our code, and to my knowledge there is no preference or behavioural preference for it from anyon... [02:07:21] 10Wikimedia-General-or-Unknown: Eliminate the toil in WMF wiki creation - https://phabricator.wikimedia.org/T253439 (10Peachey88) [02:21:53] (03CR) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [02:26:46] (03PS1) 10Shirayuki: Add Special:MyLanguage for better user experience [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598218 [02:35:56] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) Is it worth Cindy trying an older version of the phan plugin etc? [02:43:44] (03PS1) 10Shirayuki: i18n: Fix MediaWiki.org link [extensions/FileImporter] - 10https://gerrit.wikimedia.org/r/598219 [02:52:15] (03PS1) 10Ephemeralwaves: Selenium: move helper function [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/598220 (https://phabricator.wikimedia.org/T240766) [02:57:50] 10Spike, 10Vue.js (Vue.js-Search): [Spike] Build step, ResourceLoader, or both for Vue.js search? - https://phabricator.wikimedia.org/T249350 (10Niedzielski) [03:18:22] (03CR) 10Yaron Koren: "I still think the commit message needs to change more. The handling of multiple values is not really what this patch changes - that's just" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [03:19:06] (03PS14) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [03:22:12] (03PS15) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [03:26:16] (03PS16) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [03:33:05] (03PS17) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [03:39:29] (03PS18) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [03:45:59] (03CR) 10Jdlrobson: Treat languages and toolbox like other sidebar links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [03:47:29] (03PS19) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [03:49:26] (03PS7) 10Sahajsk: Enable multiple HOLDS clauses in a single query. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 [03:52:25] (03PS20) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [04:00:31] (03PS21) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [04:07:29] (03PS22) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [04:09:25] 10CodeEditor, 10CSS: Ignore cssLint warning about box-sizing - https://phabricator.wikimedia.org/T253463 (10Iniquity) [04:16:42] (03CR) 10Ammarpad: [C: 03+1] "LGTM" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/598212 (https://phabricator.wikimedia.org/T250593) (owner: 10Pppery) [04:43:01] 10CodeEditor, 10Patch-For-Review: Update Ace Editor library to a more recent version - https://phabricator.wikimedia.org/T202121 (10Iniquity) Done by @Esanders: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CodeEditor/+/588696/? [04:45:43] 10AbuseFilter, 10Move-Files-To-Commons: Bypassing AbuseFilters is not possible when importing a file and a warning is shown - https://phabricator.wikimedia.org/T249234 (10Billinghurst) FWIW if an abuse filter is causing false positives, then the abuse filter should be modified as the first point of call [04:52:04] 10XTools: XTools displaying weird percentages - https://phabricator.wikimedia.org/T253464 (10Eumat114) [04:59:11] (03PS23) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [05:03:51] (03PS24) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [05:05:30] 10Wikidata, 10Maps (Kartographer): Show OpenStreetMap features associated with Wikidata items - https://phabricator.wikimedia.org/T173052 (10Salgo60) Cant we cache the OSM value? [05:07:49] (03PS25) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [05:11:32] 10Inuka-Team, 10KaiOS-Wikipedia-app: search results page show instead of empty search page with a slow internet connection - https://phabricator.wikimedia.org/T253465 (10Jpita) [05:11:44] 10Inuka-Team, 10KaiOS-Wikipedia-app: search results page show instead of empty search page with a slow internet connection - https://phabricator.wikimedia.org/T253465 (10Jpita) [05:12:16] (03PS26) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [05:14:16] 10Move-Files-To-Commons: Provide a way to move a file to Commons when it has an OTRS tag - https://phabricator.wikimedia.org/T224802 (10Billinghurst) >>! In T224802#5970934, @Tacsipacsi wrote: > I examined the logs for a few examples of mine (a few months ago), and it seems that AbuseFilter kicks in for old revi... [05:18:58] (03PS27) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [05:22:48] (03CR) 10DannyS712: Add new SiteStatistics class to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [05:26:51] 10Inuka-Team, 10KaiOS-Wikipedia-app: [IMPROVEMENT] add a loading gif on the gallery when the image is loading - https://phabricator.wikimedia.org/T253466 (10Jpita) [05:31:55] (03PS28) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [05:34:49] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/FileImporter] - 10https://gerrit.wikimedia.org/r/598219 (owner: 10Shirayuki) [05:36:57] (03PS1) 10DannyS712: Whitelist: Add Shirayuki [integration/config] - 10https://gerrit.wikimedia.org/r/598221 [05:38:16] (03PS2) 10DannyS712: Whitelist: Add Shirayuki [integration/config] - 10https://gerrit.wikimedia.org/r/598221 [05:39:17] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598218 (owner: 10Shirayuki) [05:41:31] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/598217 (owner: 10Krinkle) [05:45:37] (03PS11) 10DannyS712: Merge htmlform.checker.js into special.userlogin.signup.js module [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) [05:46:00] (03CR) 10DannyS712: "> Patch Set 11: Published edit on patch set 10." [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) (owner: 10DannyS712) [05:52:24] (03CR) 10DannyS712: [C: 03+2] i18n: Fix MediaWiki.org link [extensions/FileImporter] - 10https://gerrit.wikimedia.org/r/598219 (owner: 10Shirayuki) [05:52:26] (03CR) 10DannyS712: [C: 03+2] Add Special:MyLanguage for better user experience [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598218 (owner: 10Shirayuki) [05:56:45] (03PS29) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [05:59:47] (03CR) 10DannyS712: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [06:00:58] (03CR) 10DannyS712: "In there a task for this?" [core] - 10https://gerrit.wikimedia.org/r/598104 (owner: 10Paladox) [06:10:53] (03Merged) 10jenkins-bot: i18n: Fix MediaWiki.org link [extensions/FileImporter] - 10https://gerrit.wikimedia.org/r/598219 (owner: 10Shirayuki) [06:10:55] (03Merged) 10jenkins-bot: Add Special:MyLanguage for better user experience [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598218 (owner: 10Shirayuki) [06:18:56] (03PS1) 10DannyS712: Add a ChangeTagLookup store for looking up different lists of tags [core] - 10https://gerrit.wikimedia.org/r/598222 (https://phabricator.wikimedia.org/T245964) [06:19:08] 10ContentTranslation, 10Performance-Team (Radar): Explore ResourceLoader package files feature as way to reduce number of modules - https://phabricator.wikimedia.org/T231326 (10Ladsgroup) >>! In T231326#5490022, @Nikerabbit wrote: > Thanks! A bunch of those involve CX1 which we would prefer not to touch at all... [06:22:05] (03PS2) 10DannyS712: Add a ChangeTagLookup store for looking up different lists of tags [core] - 10https://gerrit.wikimedia.org/r/598222 (https://phabricator.wikimedia.org/T245964) [06:22:15] (03Abandoned) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 (owner: 10DannyS712) [06:23:15] 10MediaWiki-Change-tagging, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10User-DannyS712: Factor some static methods out of the ChangeTags class - https://phabricator.wikimedia.org/T245964 (10DannyS712) [06:24:14] (03PS3) 10DannyS712: Add a ChangeTagLookup service for looking up different lists of tags [core] - 10https://gerrit.wikimedia.org/r/598222 (https://phabricator.wikimedia.org/T245964) [06:29:40] 10MediaWiki-Change-tagging, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10User-DannyS712: Factor some static methods out of the ChangeTags class - https://phabricator.wikimedia.org/T245964 (10DannyS712) [06:30:03] 10MediaWiki-Change-tagging, 10Core Platform Team Workboards (External Code Reviews), 10Dependency injection, 10Patch-For-Review, 10User-DannyS712: Split up and servicify ChangeTags class - https://phabricator.wikimedia.org/T245964 (10DannyS712) [06:32:33] (03PS1) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [06:46:06] 10Toolforge, 10cloud-services-team (Kanban): Preserve the ability to make interwiki links to Toolforge tools under the host based routing scheme - https://phabricator.wikimedia.org/T247432 (10Billinghurst) Are we right to change these over? ` |- | guc || https://guc.toolforge.org/?user=$1 |- | gucprefix || h... [06:50:16] (03PS2) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [06:52:41] (03PS3) 10Abijeet Patro: Split message index rebuild off of TranslationsUpdateJob and enable deduplication [extensions/Translate] - 10https://gerrit.wikimedia.org/r/597539 (https://phabricator.wikimedia.org/T221119) (owner: 10Nikerabbit) [06:53:11] (03PS3) 10Abijeet Patro: Remove redundant dependency on 'mediawiki.notify' (part 2) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/597902 (https://phabricator.wikimedia.org/T233676) (owner: 10Krinkle) [06:58:29] (03PS3) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [06:59:11] (03PS4) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [06:59:41] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [07:03:09] (03PS5) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [07:06:16] (03CR) 10Physikerwelt: Add MathCheckerFactory Service (036 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/596006 (https://phabricator.wikimedia.org/T252390) (owner: 10Physikerwelt) [07:07:01] (03PS6) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [07:08:43] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10Kanak8278) Hey, I am Kanak Raj. I am just new to this community and a whole to open source. I will love to join the community and get familiar with Wikimedia. I will love to... [07:09:01] (03PS7) 10Physikerwelt: Add MathCheckerFactory Service [extensions/Math] - 10https://gerrit.wikimedia.org/r/596006 (https://phabricator.wikimedia.org/T252390) [07:11:55] (03PS7) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [07:14:51] (03PS8) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [07:42:02] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10Kanak8278) Which technologies I have to be familiar with completing this task? [[ https://www.mediawiki.org/wiki/PAWS | PAWS MediaWiki ]] link I get the idea about the PAWS pr... [07:45:52] 10Cloud-Services, 10Huggle: Huggle development environment - portable virtual box - https://phabricator.wikimedia.org/T177145 (10Rishacha) @Petrb I am trying to get familiar with the portable development environment, but I couldn't find the password for the VM anywhere in the developer docs. Can you please hel... [07:51:24] 10MediaWiki-Revision-deletion: Allow revdel for the edit summaries of oversight-style deleted diffs - https://phabricator.wikimedia.org/T253462 (10Peachey88) [08:01:05] 10ContentTranslation, 10Performance-Team (Radar): Explore ResourceLoader package files feature as way to reduce number of modules - https://phabricator.wikimedia.org/T231326 (10Nikerabbit) [08:01:07] 10ContentTranslation: Remove CX1 codebase once there are no translations started with version 1 - https://phabricator.wikimedia.org/T232369 (10Nikerabbit) [08:08:53] 10VisualEditor: When switching from source mode to visual mode all content is gone for new articles - https://phabricator.wikimedia.org/T253467 (10Mbch331) [08:12:20] 10VisualEditor: When switching from source mode to visual mode all content is gone for new articles - https://phabricator.wikimedia.org/T253467 (10Mbch331) [08:17:52] (03PS1) 10Amire80: [JsonConfig] Add several optional messages with URLs [translatewiki] - 10https://gerrit.wikimedia.org/r/598224 [08:17:54] (03PS9) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [08:17:57] (03CR) 10Raimond Spekking: [C: 03+2] [JsonConfig] Add several optional messages with URLs [translatewiki] - 10https://gerrit.wikimedia.org/r/598224 (owner: 10Amire80) [08:18:01] (03Merged) 10jenkins-bot: [JsonConfig] Add several optional messages with URLs [translatewiki] - 10https://gerrit.wikimedia.org/r/598224 (owner: 10Amire80) [08:18:12] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [08:19:27] 10Dumps-Generation, 10Core Platform Team Workboards (Clinic Duty Team): stubs dumps (plus all later stages) broken on select wikis - https://phabricator.wikimedia.org/T253468 (10ArielGlenn) p:05Triage→03Unbreak! [08:20:43] (03PS10) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [08:23:53] 10MediaWiki-Revision-deletion: Allow revdel for the edit summaries of oversight-style deleted diffs - https://phabricator.wikimedia.org/T253462 (10Koavf) [08:24:28] 10Dumps-Generation, 10Core Platform Team Workboards (Clinic Duty Team): stubs dumps (plus all later stages) broken on select wikis - https://phabricator.wikimedia.org/T253468 (10ArielGlenn) I guess that we need to wrap $page->getRedirectTarget() with invokeLenient() and make sure that no other parts of the cod... [08:24:55] (03PS11) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [08:30:46] (03PS1) 10ArielGlenn: Xml dumps should not die when the page redirect target cannot be determined [core] - 10https://gerrit.wikimedia.org/r/598225 (https://phabricator.wikimedia.org/T253468) [08:30:48] (03PS12) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [08:30:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "So many questions:" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/598142 (https://phabricator.wikimedia.org/T77258) (owner: 10Krinkle) [08:34:48] (03CR) 10jerkins-bot: [V: 04-1] mmv.bootstrap: Remove direct static call to OO.Router.prototype [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/598142 (https://phabricator.wikimedia.org/T77258) (owner: 10Krinkle) [08:39:10] (03CR) 10Umherirrender: "When there are comments than the sniff cannot autofix:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) (owner: 10Umherirrender) [08:43:49] (03CR) 10Umherirrender: Fix use of const and function imports in unsorted statement sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 (owner: 10Umherirrender) [08:49:01] (03CR) 10Umherirrender: Explicitly format Message oject instead of string cast (034 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/598202 (owner: 10Umherirrender) [08:49:58] (03PS13) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 [08:56:20] 10Dumps-Generation, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: stubs dumps (plus all later stages) broken on select wikis - https://phabricator.wikimedia.org/T253468 (10ArielGlenn) I have tested the above patch on snapshot1010 and the exception is suppressed. I have manually dep... [08:57:54] (03PS17) 10Art-Baltai: SkinTemplate: increase test coverage to 55.84% [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) [08:58:53] (03CR) 10Matěj Suchánek: [C: 04-1] [FEAT] Add support for Lexicographical data (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/461372 (https://phabricator.wikimedia.org/T189321) (owner: 10Rua) [09:10:57] (03PS1) 10DannyS712: Add a new ChangeTagQueryUtils service for adding tag info to queries [core] - 10https://gerrit.wikimedia.org/r/598226 (https://phabricator.wikimedia.org/T245964) [09:12:11] (03PS2) 10DannyS712: Add a new ChangeTagQueryUtils service for adding tag info to queries [core] - 10https://gerrit.wikimedia.org/r/598226 (https://phabricator.wikimedia.org/T245964) [09:12:30] (03Abandoned) 10DannyS712: [WIP] ChangeTagQueryUtils [core] - 10https://gerrit.wikimedia.org/r/598223 (owner: 10DannyS712) [09:13:18] 10MediaWiki-Change-tagging, 10Core Platform Team Workboards (External Code Reviews), 10Dependency injection, 10Patch-For-Review, 10User-DannyS712: Split up and servicify ChangeTags class - https://phabricator.wikimedia.org/T245964 (10DannyS712) [09:14:43] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplate: increase test coverage to 55.84% [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [09:22:07] 10MediaWiki-Change-tagging, 10Core Platform Team Workboards (External Code Reviews), 10Dependency injection, 10Patch-For-Review, 10User-DannyS712: Split up and servicify ChangeTags class - https://phabricator.wikimedia.org/T245964 (10DannyS712) Notes to help with review: * Each patch adds a narrow servic... [09:28:09] (03CR) 10DannyS712: SkinTemplate: increase test coverage to 55.84% (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [09:31:37] (03CR) 10Daimona Eaytoy: "I haven't checked this patch deeply, but it does seem like the XSS warning is a false positive (tested on both taint-check 2.0.1 and 3.0.2" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 (owner: 10Krinkle) [09:38:28] (03CR) 10Daimona Eaytoy: [C: 03+1] "I haven't checked the build failure, it may well be unrelated." (032 comments) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/598204 (owner: 10Umherirrender) [09:40:33] (03CR) 10Daimona Eaytoy: [C: 03+1] Escape return of Language::formatTimePeriod [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 (owner: 10Umherirrender) [09:47:15] 10Analytics, 10Analytics-Kanban: Spike, see how easy/hard is to scoop all tables from Eventlogging log database - https://phabricator.wikimedia.org/T250709 (10Milimetric) Ok, I sqooped 4 tables, some big some small. I can't for some reason get a Hive table created on top of them, but it's very easy to put a S... [09:48:20] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Daimona) >>! In T253322#6160642, @Reedy wrote: > Is it worth Cindy trying an older version of the phan plugin etc? It's possible. I think this might be due to an o... [09:55:10] 10InternetArchiveBot, 10User-Cirdan: URL fälschlicherweise "Weißgelistet" - https://phabricator.wikimedia.org/T245942 (10Cirdan) a:03Cirdan [10:00:08] 10InternetArchiveBot: Webarchiv wird hinter Vorlage Literatur gesetzt, obwohl schon unter Parameter Online vorhanden - https://phabricator.wikimedia.org/T233210 (10Cirdan) [10:00:10] 10InternetArchiveBot (v2.0), 10User-Cirdan: IABot 2.0beta14 appends Webarchiv template to Literatur template which already contains Webarchiv template - https://phabricator.wikimedia.org/T221448 (10Cirdan) [10:03:08] 10InternetArchiveBot (v2.0): Disable IABot on {{Literatur}} - https://phabricator.wikimedia.org/T253469 (10Cirdan) [10:14:02] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [10:17:58] 10Toolforge (Software install/update): Request for supporting Deno on Toolforge - https://phabricator.wikimedia.org/T253470 (10Premeditated) [10:18:20] (03PS1) 10Xqt: [IMPR] use float for statistics [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598227 [10:29:01] (03CR) 10Xqt: "Is this still an active branch?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/595987 (owner: 10Andre Engels) [10:29:22] (03CR) 10Xqt: "Is this still an active branch?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/595988 (owner: 10Andre Engels) [10:32:49] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [10:36:53] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [10:41:26] 04(no projects): [cricket] In Shakib Al hasan's career statistics, the runs scored in the test cricket is displayed wrong '3862 2' and it is unclear - https://phabricator.wikimedia.org/T253471 (10Hemanthkumar.hk1) [10:43:25] (03PS1) 10Daimona Eaytoy: linkrenderer: Annotate first param of makeBrokenLink as not tainted [core] - 10https://gerrit.wikimedia.org/r/598228 [10:46:57] (03PS1) 10Daimona Eaytoy: Add explicit taint info for LinkRenderer::makeBrokenLink [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598229 [10:59:10] 10Pywikibot: Make Pywikibot daemon logs unexecutable - https://phabricator.wikimedia.org/T253472 (10Tacsipacsi) [10:59:34] 04(no projects): [cricket] In Shakib Al hasan's career statistics, the runs scored in the test cricket is displayed wrong '3862 2' and it is unclear - https://phabricator.wikimedia.org/T253471 (10RhinosF1) 05Open→03Invalid Fixed but in future, please direct these issues to the appropiate on wiki talk page. [11:02:03] (03PS2) 10D3r1ck01: linkeddata: Fix PHPStorm warning for var $parts after calling explode() [core] - 10https://gerrit.wikimedia.org/r/598135 [11:02:28] (03PS11) 10D3r1ck01: linker: Move normalize target related code to appropriate class [core] - 10https://gerrit.wikimedia.org/r/598094 [11:06:08] 04(no projects): [cricket] In Shakib Al hasan's career statistics, the runs scored in the test cricket is displayed wrong '3862 2' and it is unclear - https://phabricator.wikimedia.org/T253471 (10Aklapper) @Hemanthkumar.hk1: Hi, [Wikimedia Phabricator](https://www.mediawiki.org/wiki/Phabricator) is for reportin... [11:07:36] 10CodeEditor, 10CSS: Ignore cssLint warning about box-sizing (because applies to IE6/IE7 only) - https://phabricator.wikimedia.org/T253463 (10Aklapper) [11:07:39] (03CR) 10Umherirrender: Parse messages in string context (031 comment) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/598204 (owner: 10Umherirrender) [11:07:44] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [11:10:43] 10Toolforge (Software install/update): Request for supporting Deno on Toolforge - https://phabricator.wikimedia.org/T253470 (10Aklapper) Hi @Premeditated, servers run on Debian, hence we need Debian packages to install. Please link to a Debian package for Deno. [11:23:12] (03CR) 10Umherirrender: "phan taint only reports the return statement of the called function as caught, not the line where there the unescaped string is concat wit" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 (owner: 10Krinkle) [11:25:54] (03PS1) 10Umherirrender: DNM: Remove caching from Skin::getCachedNotice [core] - 10https://gerrit.wikimedia.org/r/598230 [11:27:48] (03CR) 10Umherirrender: Use TalkPageNotificationManager (031 comment) [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/596733 (https://phabricator.wikimedia.org/T239640) (owner: 10Clarakosi) [11:28:25] (03CR) 10Xqt: "Please deactivate style checks as I proposed by my uploaded patch." (0313 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/597350 (owner: 10Andre Engels) [11:29:37] (03PS8) 10Umherirrender: Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 [11:36:35] 10phan-taint-check-plugin: taint-check does not analyze code with BagOStuff::getWithSetCallback correctly - https://phabricator.wikimedia.org/T253473 (10Umherirrender) [11:37:10] (03CR) 10Umherirrender: "My patch set passed without the getWitthSetCallback, I have created T253473 to track it" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 (owner: 10Krinkle) [11:43:20] (03PS2) 10Umherirrender: Add return-taint to Skin::getCachedNotice [core] - 10https://gerrit.wikimedia.org/r/598230 (https://phabricator.wikimedia.org/T253473) [11:44:03] (03CR) 10Umherirrender: "recheck" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [11:47:28] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [11:49:13] (03PS1) 10Umherirrender: Replace aassertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 [11:50:42] (03PS3) 10Umherirrender: Add return-taint to Skin::getSiteNotice [core] - 10https://gerrit.wikimedia.org/r/598230 (https://phabricator.wikimedia.org/T253473) [11:51:21] (03PS2) 10Umherirrender: Replace aassertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 [11:51:23] (03CR) 10jerkins-bot: [V: 04-1] Replace aassertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 (owner: 10Umherirrender) [11:51:38] (03CR) 10Umherirrender: "recheck" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [11:54:18] (03CR) 10jerkins-bot: [V: 04-1] Replace aassertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 (owner: 10Umherirrender) [11:55:17] (03PS3) 10Umherirrender: Replace aassertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 [11:56:51] (03PS1) 10RhinosF1: Remove ext-sitescout [translatewiki] - 10https://gerrit.wikimedia.org/r/598232 (https://phabricator.wikimedia.org/T253452) [11:57:35] (03CR) 10jerkins-bot: [V: 04-1] Replace aassertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 (owner: 10Umherirrender) [11:57:58] (03PS2) 10RhinosF1: Remove ext-sitescout [translatewiki] - 10https://gerrit.wikimedia.org/r/598232 (https://phabricator.wikimedia.org/T253452) [11:58:30] (03CR) 10Umherirrender: [C: 04-2] "Does not help with the return taint" [core] - 10https://gerrit.wikimedia.org/r/598230 (https://phabricator.wikimedia.org/T253473) (owner: 10Umherirrender) [11:59:31] (03PS1) 10RhinosF1: Archive SiteScout [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) [12:00:53] (03PS2) 10RhinosF1: Archive SiteScout [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) [12:01:43] (03PS1) 10Umherirrender: Use IDatabase::ALL_ROWS on update to avoid deprecation notice [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598234 [12:04:05] (03CR) 10Raimond Spekking: [C: 03+2] Remove ext-sitescout [translatewiki] - 10https://gerrit.wikimedia.org/r/598232 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [12:04:27] (03PS4) 10Umherirrender: Replace aassertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 [12:05:15] (03PS3) 10Umherirrender: Parse messages in string context [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/592707 [12:05:17] (03CR) 10Daimona Eaytoy: [C: 03+1] Parse messages in string context (031 comment) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/598204 (owner: 10Umherirrender) [12:10:33] (03CR) 10Daimona Eaytoy: "> phan taint only reports the return statement of the called function" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 (owner: 10Krinkle) [12:12:29] (03PS1) 10RhinosF1: Archive SiteScout [extensions] - 10https://gerrit.wikimedia.org/r/598235 [12:13:56] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) About to empty the repo Leaving: Remove manifest/other references from mediawiki/vagrant if they exist. Remove from https:/... [12:13:58] 10Toolforge: /bin/sh: 1: [: missing ] for cron on toolforge - https://phabricator.wikimedia.org/T253474 (10Mbch331) [12:16:09] (03PS2) 10RhinosF1: Archive SiteScout [extensions] - 10https://gerrit.wikimedia.org/r/598235 (https://phabricator.wikimedia.org/T253452) [12:17:59] 10Convenient-Discussions, 10translatewiki.net, 10Language-Team (Language-2020-Focus-Sprint), 10Patch-For-Review: Add convenient-discussions to translatewiki.net - https://phabricator.wikimedia.org/T253037 (10Jack_who_built_the_house) I guess everything is ready on my part. Is there anything else needed? [12:21:28] (03CR) 10Huji: [C: 03+2] [IMPR] Check for missing generator after setup() call [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598157 (owner: 10Xqt) [12:22:47] (03CR) 10Daimona Eaytoy: [C: 04-1] "-1 is for the rebase artefact." (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) (owner: 10DannyS712) [12:23:08] (03PS1) 10RhinosF1: Archive -- Bug:T253452 [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/598236 [12:23:31] (03PS1) 10Umherirrender: build: Bump phan to 0.10.2, remove taint-check [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 [12:23:41] (03Merged) 10jenkins-bot: [IMPR] Check for missing generator after setup() call [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598157 (owner: 10Xqt) [12:23:49] (03PS2) 10RhinosF1: Archive [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/598236 (https://phabricator.wikimedia.org/T253452) [12:25:58] (03PS1) 10Xqt: [IMPR] Make Pywikibot daemon logs unexecutable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) [12:26:02] (03PS3) 10Umherirrender: Escape return of Language::formatTimePeriod [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 [12:26:16] (03CR) 10jerkins-bot: [V: 04-1] build: Bump phan to 0.10.2, remove taint-check [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 (owner: 10Umherirrender) [12:27:08] 10Pywikibot, 10Patch-For-Review: Make Pywikibot daemon logs unexecutable - https://phabricator.wikimedia.org/T253472 (10Xqt) a:03Xqt [12:27:26] 10Pywikibot, 10Patch-For-Review: Make Pywikibot daemon logs unexecutable - https://phabricator.wikimedia.org/T253472 (10Xqt) p:05Triage→03Low [12:29:46] (03PS2) 10Umherirrender: build: Bump phan to 0.10.2, remove taint-check [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 [12:30:54] (03PS3) 10Umherirrender: build: Bump phan to 0.10.2, remove taint-check [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 [12:31:07] (03CR) 10Umherirrender: "The failure is fixed in Iedeb313dc0aabfc9ab3f8bdf96f8725f9d016b35" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 (owner: 10Umherirrender) [12:32:44] (03PS4) 10Umherirrender: Escape return of Language::formatTimePeriod [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 [12:32:58] (03PS4) 10Umherirrender: build: Bump phan to 0.10.2, remove taint-check [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 [12:33:17] (03PS5) 10Umherirrender: build: Bump phan to 0.10.2, remove taint-check [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 [12:45:03] (03PS1) 10Umherirrender: Parse messages in string context [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/598239 [12:46:47] (03PS1) 10Umherirrender: Parse messages in string context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/598240 [12:49:13] (03PS1) 10Umherirrender: Do not pass Message to HtmlForm::setWrapperLegend [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/598241 [12:53:12] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) [12:54:11] (03PS1) 10Umherirrender: Parse messages in string context [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/598242 [12:55:17] (03PS4) 10Zoranzoki21: Enable subpages in Page namespace on napwikisource [mediawiki-config] - 10https://gerrit.wikimedia.org/r/596477 (https://phabricator.wikimedia.org/T252755) [12:55:48] (03CR) 10jerkins-bot: [V: 04-1] Parse messages in string context [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/598242 (owner: 10Umherirrender) [12:56:29] (03PS4) 10TK-999: Trim comment field content prior to insertion [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) [12:57:46] (03CR) 10TK-999: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [13:01:05] (03PS1) 10Umherirrender: Parse messages in string context [extensions/WikibaseLexeme] - 10https://gerrit.wikimedia.org/r/598243 [13:02:13] (03PS2) 10Umherirrender: Parse messages in string context [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/598242 [13:08:35] 10Wikimedia-Site-requests, 10User-RhinosF1: Add autoreviewrestore into the rollbacker group in hiwiki - https://phabricator.wikimedia.org/T252986 (10RhinosF1) 05Stalled→03Open I've discussed this with @Urbanecm and we've agreed to proceed with this. As we count the discussion, there is overall more people... [13:10:07] (03PS1) 10Yaron Koren: Move datepicker help URL out of i18n [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598244 [13:10:18] (03PS1) 10RhinosF1: Add autoreviewrestore into the rollbacker group in hiwiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/598245 [13:11:52] (03PS1) 10Umherirrender: Parse messages in string context [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/598246 [13:13:25] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/598247 [13:14:25] (03PS1) 10Umherirrender: Parse messages in string context [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/598248 [13:14:37] (03PS2) 10Yaron Koren: Move datepicker help URL out of i18n [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598244 [13:15:15] 10Toolforge (Software install/update): Request for supporting Deno on Toolforge - https://phabricator.wikimedia.org/T253470 (10Zoranzoki21) >>! In T253470#6160825, @Aklapper wrote: > Hi @Premeditated, servers run on Debian, hence we need Debian packages to install. Please link to a Debian package for Deno. @Akl... [13:15:48] (03PS1) 10Umherirrender: Parse messages in string context [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598249 [13:15:57] (03PS2) 10RhinosF1: Add autoreviewrestore into the rollbacker group in hiwiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/598245 (https://phabricator.wikimedia.org/T252986) [13:16:48] (03CR) 10jerkins-bot: [V: 04-1] Add autoreviewrestore into the rollbacker group in hiwiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/598245 (https://phabricator.wikimedia.org/T252986) (owner: 10RhinosF1) [13:17:49] 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-RhinosF1: Add autoreviewrestore into the rollbacker group in hiwiki - https://phabricator.wikimedia.org/T252986 (10RhinosF1) p:05Low→03Medium [13:20:06] 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-RhinosF1: Add autoreviewrestore into the rollbacker group in hiwiki - https://phabricator.wikimedia.org/T252986 (10RhinosF1) [13:21:02] 10Toolforge (Software install/update): Request for supporting Deno on Toolforge - https://phabricator.wikimedia.org/T253470 (10Premeditated) At this point there are no Debian package (https://github.com/denoland/deno/issues/1583). It can be installed via a bash script, like mentioned by @Zoranzoki21. And updated... [13:22:17] (03CR) 10Umherirrender: "> The results of my investigation were a bit different. The issue came from bottomLinks(), specifically the calls to editThisPage() and wa" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 (owner: 10Krinkle) [13:22:48] (03PS3) 10RhinosF1: Add autoreviewrestore into the rollbacker group in hiwiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/598245 (https://phabricator.wikimedia.org/T252986) [13:25:23] (03PS1) 10Umherirrender: Parse messages in string context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/598250 [13:27:29] (03CR) 10Yaron Koren: [C: 03+2] Move datepicker help URL out of i18n [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598244 (owner: 10Yaron Koren) [13:29:52] (03Merged) 10jenkins-bot: Move datepicker help URL out of i18n [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598244 (owner: 10Yaron Koren) [13:30:08] (03CR) 10Jack Phoenix: [C: 03+2] Archive [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/598236 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:32:36] (03Merged) 10jenkins-bot: Archive [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/598236 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:33:53] (03CR) 10Jack Phoenix: [C: 03+2] "Confirmed working on my 1.34 box. Thank you for your hard work on this, Danny, much appreciated!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593663 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [13:34:31] (03PS1) 10Umherirrender: Parse messages in string context [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/598251 [13:35:23] (03PS7) 10AlQaholic007: Cypress: Setup Cypress and configure ESLint for Cypress. [core] - 10https://gerrit.wikimedia.org/r/597125 (https://phabricator.wikimedia.org/T248220) [13:36:05] (03Merged) 10jenkins-bot: Remove use of DifferenceEngine::$mNewRev and $mOldRev [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593663 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [13:39:02] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) [13:39:22] (03CR) 10Yaron Koren: "I still think the commit message needs to change more. I mean, this patch changes the whole underlying SQL for HOLDS queries. Of course, t" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [13:42:22] (03PS1) 10Umherirrender: Parse messages in string context [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/598252 [13:43:22] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) [13:43:24] (03PS5) 10Umherirrender: Replace assertContains by assertStringContainsString in unit tests [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/598231 [13:46:38] (03CR) 10MarcoAurelio: "Usually when archiving an extension we move it to a section at the bottom of the file and use the 'archived' template. Given that the repo" [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:47:25] (03CR) 10MarcoAurelio: "Rebasing before merging." [extensions] - 10https://gerrit.wikimedia.org/r/598235 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:47:34] (03PS3) 10MarcoAurelio: Archive SiteScout [extensions] - 10https://gerrit.wikimedia.org/r/598235 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:47:38] (03PS4) 10MarcoAurelio: Archive SiteScout [extensions] - 10https://gerrit.wikimedia.org/r/598235 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:47:51] (03PS5) 10MarcoAurelio: Archive SiteScout [extensions] - 10https://gerrit.wikimedia.org/r/598235 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:48:10] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Archive SiteScout [extensions] - 10https://gerrit.wikimedia.org/r/598235 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:49:09] (03CR) 10MarcoAurelio: [C: 03+1] Add phpcs and make it pass [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/598247 (owner: 10Zoranzoki21) [13:49:53] (03PS1) 10AlQaholic007: Cypress: Implement a simple test to check for default main page heading [core] - 10https://gerrit.wikimedia.org/r/598253 [13:51:19] (03PS28) 10Xqt: [script] port speedy_delete.py to core [pywikibot/core] - 10https://gerrit.wikimedia.org/r/148646 (https://phabricator.wikimedia.org/T66880) (owner: 10Ricordisamoa) [13:51:27] (03CR) 10jerkins-bot: [V: 04-1] [script] port speedy_delete.py to core [pywikibot/core] - 10https://gerrit.wikimedia.org/r/148646 (https://phabricator.wikimedia.org/T66880) (owner: 10Ricordisamoa) [13:51:45] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/148646 (https://phabricator.wikimedia.org/T66880) (owner: 10Ricordisamoa) [13:53:26] (03PS29) 10Xqt: [script] port speedy_delete.py to core [pywikibot/core] - 10https://gerrit.wikimedia.org/r/148646 (https://phabricator.wikimedia.org/T66880) (owner: 10Ricordisamoa) [13:55:03] (03PS20) 10Xqt: Porting parser_function_count.py from compat to core/scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/181724 (https://phabricator.wikimedia.org/T66878) (owner: 10Prianka) [13:56:42] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) Column hidden [13:58:19] 10XTools: Request to add RedWarn to AutoEdits - https://phabricator.wikimedia.org/T253275 (101234qwer1234qwer4) [13:58:48] 10MediaWiki-Revision-deletion: Allow revdel for the edit summaries of oversight-style deleted diffs - https://phabricator.wikimedia.org/T253462 (10Izno) [13:59:13] (03PS14) 10Xqt: [IMPR] Derive RedirectRobot from MultipleSitesBot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/456998 (https://phabricator.wikimedia.org/T211586) [13:59:44] (03PS2) 10Alexandros Kosiaris: Remove install[12]002 site.pp entries [puppet] - 10https://gerrit.wikimedia.org/r/598071 (https://phabricator.wikimedia.org/T224576) [13:59:46] (03PS1) 10Alexandros Kosiaris: kubernetes2007-2014: Move to role kubernetes::worker [puppet] - 10https://gerrit.wikimedia.org/r/598254 (https://phabricator.wikimedia.org/T252185) [14:00:06] 10AntiSpoof, 10Stewards-and-global-tools, 10TitleBlacklist: Required new attribute to selectively exclude unicode text - https://phabricator.wikimedia.org/T253367 (10MarcoAurelio) I wonder why do we allow these kinds of "weird" fonts to register accounts in the first place. Those is being used to actively ci... [14:00:10] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) [14:01:04] (03CR) 10Alexandros Kosiaris: [C: 03+2] Remove install[12]002 site.pp entries [puppet] - 10https://gerrit.wikimedia.org/r/598071 (https://phabricator.wikimedia.org/T224576) (owner: 10Alexandros Kosiaris) [14:01:08] (03PS8) 10Sahajsk: Enable multiple HOLDS clauses in a single query. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 [14:02:14] (03CR) 10Alexandros Kosiaris: [C: 03+2] kubernetes2007-2014: Move to role kubernetes::worker [puppet] - 10https://gerrit.wikimedia.org/r/598254 (https://phabricator.wikimedia.org/T252185) (owner: 10Alexandros Kosiaris) [14:03:26] (03CR) 10Sahajsk: "> Patch Set 7:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [14:03:38] (03CR) 10jerkins-bot: [V: 04-1] Cypress: Implement a simple test to check for default main page heading [core] - 10https://gerrit.wikimedia.org/r/598253 (owner: 10AlQaholic007) [14:04:20] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10Pppery) [14:07:04] (03PS1) 10Xqt: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598255 [14:09:58] (03CR) 10Yaron Koren: "It doesn't need to be longer (the current commit message might be too long already), just different. For example, it's not true that this " [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [14:11:07] (03CR) 10Yaron Koren: [C: 03+2] Make required extension names "space-insensitive" [extensions/PageExchange] - 10https://gerrit.wikimedia.org/r/598083 (owner: 10Yaron Koren) [14:13:16] (03Merged) 10jenkins-bot: Make required extension names "space-insensitive" [extensions/PageExchange] - 10https://gerrit.wikimedia.org/r/598083 (owner: 10Yaron Koren) [14:15:50] 10Project-Admins, 10User-Zoranzoki21: Create new project User-Examknow - https://phabricator.wikimedia.org/T253419 (10Zoranzoki21) 05Open→03Resolved Requested public project #user-examknow has been created: https://phabricator.wikimedia.org/project/view/4787/ Please encourage interested people to visit th... [14:15:55] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555 (10Zoranzoki21) [14:15:57] 10Operations, 10ops-codfw, 10serviceops: (Need by: TBD) rack/setup/install kubernetes20[07-14].codfw.wmnet and kubestage200[1-2].codfw.wmnet. - https://phabricator.wikimedia.org/T252185 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by akosiaris on cumin1001.eqiad.wmnet for hosts: ` ['kubernetes... [14:17:00] (03PS1) 10Yaron Koren: Fix "types handled" for datepicker input [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 [14:19:09] (03PS9) 10Sahajsk: Change in SQL querying of HOLDS clause [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 [14:19:10] (03PS2) 10Yaron Koren: Fix "types handled" for datepicker input [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 [14:20:26] (03CR) 10Zoranzoki21: [C: 04-1] Fix "types handled" for datepicker input (031 comment) [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 (owner: 10Yaron Koren) [14:21:26] 10Wikipedia-Android-App-Backlog: Remove + sign before tags in SE v4 - https://phabricator.wikimedia.org/T253475 (10Charlotte) [14:23:03] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.31x-P-Pryanik): [SPIKE] Encourage account creation - https://phabricator.wikimedia.org/T252550 (10Charlotte) Good stuff - thanks @cooltey. Now that we know we can tease account creation to only people who are likely to be able to create accounts (pendin... [14:23:29] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.31x-P-Pryanik): [SPIKE] Encourage account creation - https://phabricator.wikimedia.org/T252550 (10Charlotte) a:05cooltey→03None [14:24:01] 10Pywikibot: Massive image upload with pywikibot - https://phabricator.wikimedia.org/T216015 (10Xqt) > upload of images by means of pywikibot is a task that takes several seconds per image (I assume this is a constraint set by any kind of policy) This is the usual put_throttle delay for each write operation (he... [14:25:02] 10Pywikibot: Massive image upload with pywikibot - https://phabricator.wikimedia.org/T216015 (10Xqt) 05Open→03Invalid [14:27:21] (03PS1) 10AlQaholic007: Puppeteer: Setup puppeteer and configure ESLint for puppeteer [core] - 10https://gerrit.wikimedia.org/r/598257 (https://phabricator.wikimedia.org/T248219) [14:28:26] (03CR) 10Yaron Koren: "Better! But still not ideal. Sorry to keep pushing back - though coming up with good commit messages is important, so hopefully you're lea" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [14:29:38] (03PS2) 10AlQaholic007: Cypress: Implement a simple test to check for default main page heading [core] - 10https://gerrit.wikimedia.org/r/598253 [14:30:04] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [14:31:27] (03PS3) 10AlQaholic007: Cypress: Implement a simple test to check for default main page heading [core] - 10https://gerrit.wikimedia.org/r/598253 (https://phabricator.wikimedia.org/T248220) [14:34:11] (03PS2) 10ArielGlenn: Xml dumps should not die when the page redirect target cannot be determined [core] - 10https://gerrit.wikimedia.org/r/598225 (https://phabricator.wikimedia.org/T253468) [14:37:42] (03CR) 10Sahajsk: "> Patch Set 9:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [14:40:39] (03CR) 10Nuria: "code tested, please @jeniferwang verify select" [analytics/reportupdater-queries] - 10https://gerrit.wikimedia.org/r/593092 (https://phabricator.wikimedia.org/T247099) (owner: 10Nuria) [14:40:47] (03PS1) 10Umherirrender: Parse messages in string context [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/598258 [14:45:13] (03PS1) 10Pcoombe: Fix case in message to match others [extensions/AdvancedSearch] - 10https://gerrit.wikimedia.org/r/598259 [14:46:16] (03CR) 10jerkins-bot: [V: 04-1] Cypress: Implement a simple test to check for default main page heading [core] - 10https://gerrit.wikimedia.org/r/598253 (https://phabricator.wikimedia.org/T248220) (owner: 10AlQaholic007) [14:49:19] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [14:53:46] (03CR) 10Yaron Koren: "Yes. I'm not saying that's the best commit message, but it's at least more informative." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [14:55:32] 10MediaWiki-Docker, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10kostajh) > Would everyone prefer if I leave that alone for now and alter this patch to in... [14:55:37] 10Toolforge: /bin/sh: 1: [: missing ] for cron on toolforge - https://phabricator.wikimedia.org/T253474 (10Mahir256) Have you tried adding a space between the '"12"' and the ']'? [14:56:34] (03PS3) 10Yaron Koren: Fix "types handled" for datepicker input [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 [14:56:53] (03CR) 10Yaron Koren: "@Zoranzoki21 - since you asked for it, here you go!" [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 (owner: 10Yaron Koren) [14:58:02] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [14:58:10] (03PS1) 10Umherirrender: Parse messages in string context [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/598260 [15:00:49] (03PS10) 10Sahajsk: Change in SQL querying of HOLDS clause [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 [15:06:09] (03CR) 10Daimona Eaytoy: "> > The results of my investigation were a bit different. The issue" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 (owner: 10Krinkle) [15:12:04] (03PS1) 10Umherirrender: Parse messages in string context [extensions/Math] - 10https://gerrit.wikimedia.org/r/598261 [15:13:44] (03CR) 10Yaron Koren: "You still haven't changed the main commit message... the top sentence is the most important one, because that's the one that shows up in c" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [15:13:56] (03CR) 10jerkins-bot: [V: 04-1] Parse messages in string context [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/598260 (owner: 10Umherirrender) [15:15:14] 10MediaWiki-Parser: Allowing comments between the brackets of a wikilink should not depend on pipe-trick being used or not - https://phabricator.wikimedia.org/T253476 (10Dalba) [15:15:54] (03PS1) 10Umherirrender: Parse messages in string context [extensions/Flow] - 10https://gerrit.wikimedia.org/r/598262 [15:16:08] 10Toolforge: /bin/sh: 1: [: missing ] for cron on toolforge - https://phabricator.wikimedia.org/T253474 (10zhuyifei1999) heh. `[` is actually an executable that looks for `]` as the very last argument. https://github.com/coreutils/coreutils/blob/46e0ce5e5d03891d7b175d5050cf7cce0632c668/src/test.c#L849 `lang=C i... [15:16:17] 10Operations, 10ops-codfw, 10serviceops: (Need by: TBD) rack/setup/install kubernetes20[07-14].codfw.wmnet and kubestage200[1-2].codfw.wmnet. - https://phabricator.wikimedia.org/T252185 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['kubernetes2007.codfw.wmnet', 'kubernetes2011.codfw.wmnet', 'kub... [15:18:14] (03PS1) 10Esanders: Prefer let/const to var in server side code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/598263 [15:18:32] (03CR) 10jerkins-bot: [V: 04-1] Prefer let/const to var in server side code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/598263 (owner: 10Esanders) [15:22:25] (03PS1) 10Daimona Eaytoy: [WIP] overrideContext [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598264 [15:23:54] (03PS2) 10Umherirrender: Parse messages in string context [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/598260 [15:24:37] (03CR) 10Tacsipacsi: "Thanks for the fast action! I have one minor suggestion." (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) (owner: 10Xqt) [15:24:41] (03CR) 10Zoranzoki21: [C: 03+1] "Much better! Thanks Yaron!" [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 (owner: 10Yaron Koren) [15:29:15] (03PS2) 10Daimona Eaytoy: [WIP] overrideContext [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598264 [15:30:11] (03CR) 10jerkins-bot: [V: 04-1] [WIP] overrideContext [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598264 (owner: 10Daimona Eaytoy) [15:30:56] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10zhuyifei1999) This task is literally writing a `README.md` for the repository https://github.com/toolforge/paws. * `README` is the go-to file to read when someone sees the re... [15:31:03] (03PS1) 10Umherirrender: Parse messages in string context [extensions/Translate] - 10https://gerrit.wikimedia.org/r/598265 [15:33:18] (03PS2) 10Umherirrender: Use UserNameUtils in GenderCache [core] - 10https://gerrit.wikimedia.org/r/585310 [15:33:32] (03CR) 10Umherirrender: Use UserNameUtils in GenderCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585310 (owner: 10Umherirrender) [15:34:50] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [15:35:35] (03CR) 10Daimona Eaytoy: [C: 03+2] "Very good! A couple false positives were fixed, and some new "true positives" (as far as the plugin can know) were found in maintenance sc" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598237 (owner: 10Umherirrender) [15:41:25] (03CR) 10jerkins-bot: [V: 04-1] Parse messages in string context [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/598260 (owner: 10Umherirrender) [15:41:53] (03PS3) 10Umherirrender: Parse messages in string context [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/598260 [15:43:31] (03PS11) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [15:49:07] (03PS7) 10Daimona Eaytoy: Track returned objects in-place, delete GetReturnObjVisitor [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/589862 (https://phabricator.wikimedia.org/T250671) [15:49:24] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [15:52:44] (03PS9) 10Daimona Eaytoy: Rewrite findDeprecated using phan instead of php-parser [core] - 10https://gerrit.wikimedia.org/r/566537 (https://phabricator.wikimedia.org/T243403) [15:58:45] (03PS7) 10Daimona Eaytoy: Use PHPUnit hooks for augmented logs [core] - 10https://gerrit.wikimedia.org/r/566829 (https://phabricator.wikimedia.org/T243600) [16:00:06] 10MediaWiki-extensions-OATHAuth: Recovery option for Webauthn - https://phabricator.wikimedia.org/T244348 (10jeblad) Posted a note at Torget and told people to use TOTP, this solution is not ready for production. [16:00:52] (03PS5) 10Daimona Eaytoy: phan: Conditionally load PHP extension stubs with dedicated option [core] - 10https://gerrit.wikimedia.org/r/574705 [16:01:47] (03CR) 10Martineznovo: [C: 03+1] Fix links to pages on Wikimedia commons when used on other wikis [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/598212 (https://phabricator.wikimedia.org/T250593) (owner: 10Pppery) [16:04:57] (03CR) 10Martineznovo: Fix migration script for when actor_id is null (031 comment) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 (owner: 10Paladox) [16:08:21] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) @Daimona, thank you! I was following the instructions at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_exte... [16:08:43] 10Social-Tools, 10SocialProfile: Visiting the user page of an IP address causes fatal error - https://phabricator.wikimedia.org/T253249 (10Ciencia_Al_Poder) 05Open→03Resolved a:03ashley Cool thanks! Indeed it fixes the issue [16:10:28] (03CR) 10jerkins-bot: [V: 04-1] Rewrite findDeprecated using phan instead of php-parser [core] - 10https://gerrit.wikimedia.org/r/566537 (https://phabricator.wikimedia.org/T243403) (owner: 10Daimona Eaytoy) [16:20:09] (03PS1) 10Bmansurov: Copy external assets to the repo [research/wikiworkshop] - 10https://gerrit.wikimedia.org/r/598266 (https://phabricator.wikimedia.org/T251732) [16:20:41] (03CR) 10Bmansurov: [V: 03+2 C: 03+2] Copy external assets to the repo [research/wikiworkshop] - 10https://gerrit.wikimedia.org/r/598266 (https://phabricator.wikimedia.org/T251732) (owner: 10Bmansurov) [16:23:25] (03CR) 10Xqt: [IMPR] Make Pywikibot daemon logs unexecutable (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) (owner: 10Xqt) [16:39:04] 10MediaWiki-Parser: Allowing comments between the brackets of a wikilink should not depend on pipe-trick being used or not - https://phabricator.wikimedia.org/T253476 (10Aklapper) p:05Triage→03Lowest [16:45:36] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) >>! In T253322#6160961, @CCicalese_WMF wrote: > The instructions for running phan should be updated to point to the version in vendor/bin. Do you agree? I'm... [16:45:55] (03CR) 10Umherirrender: Use StatsdDataFactory service in ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/589110 (owner: 10Umherirrender) [16:46:14] (03PS7) 10Umherirrender: Use StatsdDataFactory service in ParserCache [core] - 10https://gerrit.wikimedia.org/r/589110 [16:46:53] 10MediaWiki-extensions-Translate, 10Security-Team, 10phan-taint-check-plugin, 10Patch-For-Review, and 3 others: SpecialLanguageStats.php fails phan tests due to possible XSS - https://phabricator.wikimedia.org/T253383 (10MarcoAurelio) [16:49:55] 10Analytics, 10Operations, 10ops-eqiad: an-presto1004 down - https://phabricator.wikimedia.org/T253438 (10Cmjohnson) I submitted a ticket with Dell for a replacement CPU. SR1025619583 [16:50:33] 10LibUp: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Reedy) [16:50:43] 10LibUp, 10phan: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Reedy) [16:59:48] (03CR) 10Tacsipacsi: [IMPR] Make Pywikibot daemon logs unexecutable (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) (owner: 10Xqt) [17:01:40] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) The ` composer require --dev "mediawiki/mediawiki-phan-config: 0.10.2" ` installs phan as a dependency, so a separate require for phan is not neces... [17:10:30] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Error editing a page in the user space using the Android Wikipedia app - https://phabricator.wikimedia.org/T253478 (10Amire80) [17:11:35] (03PS1) 10Bmansurov: 2015: remove YUI js and (most of) CSS [research/wikiworkshop] - 10https://gerrit.wikimedia.org/r/598267 (https://phabricator.wikimedia.org/T251732) [17:11:59] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Daimona) >>! In T253322#6160961, @CCicalese_WMF wrote: > @Daimona, thank you! I was following the instructions at https://www.mediawiki.org/wiki/Continuous_integrat... [17:12:03] (03CR) 10Bmansurov: [V: 03+2 C: 03+2] 2015: remove YUI js and (most of) CSS [research/wikiworkshop] - 10https://gerrit.wikimedia.org/r/598267 (https://phabricator.wikimedia.org/T251732) (owner: 10Bmansurov) [17:12:42] (03CR) 10Yaron Koren: [C: 03+2] Fix "types handled" for datepicker input [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 (owner: 10Yaron Koren) [17:15:07] (03Merged) 10jenkins-bot: Fix "types handled" for datepicker input [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/598256 (owner: 10Yaron Koren) [17:16:40] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) >>! In T253322#6161010, @Daimona wrote: >>>! In T253322#6160961, @CCicalese_WMF wrote: >> But, since the mediawiki/mediawiki-phan-config requirement... [17:19:08] 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10phan: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) >>! In T253322#6160975, @Reedy wrote: > I'm partially wondering why we haven't put a "composer phan" type command into composer.json rather than peop... [17:26:37] 10LibUp, 10phan: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Daimona) For completeness, I believe that the command should be `vendor/bin/phan -d . --long-progress-bar` if the version of mediawiki-phan-config is >=0.9.0, and `vendor/bin/phan -d . -p` otherwise. [17:33:30] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Flags in infoboxes in the Wikipedia Android app are shown with a wrong-looking border - https://phabricator.wikimedia.org/T253479 (10Amire80) [17:38:19] 10Tools, 10Wikidata: Duplicate statements by QuickStatements within one batch - https://phabricator.wikimedia.org/T234162 (10M2k_dewiki) Hello, the problem, that Quickstatements creates two or more (in same cases three or four) identical objects within one batch run still seems to exist. For details, please... [17:39:01] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Krinkle) [18:01:06] (03PS1) 10Bmansurov: WIP: Upgrade bootstrap [research/wikiworkshop] - 10https://gerrit.wikimedia.org/r/598268 (https://phabricator.wikimedia.org/T251732) [18:02:25] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10Kanak8278) a:05Vaibhav_apt→03None Can I claim this task as it is previously assigned to @Vaibhav_apt ? [18:02:32] 10Operations, 10Privacy Engineering, 10Research, 10Traffic, and 2 others: wikiworkshop.org has Facebook button, external statcounter, https to http redirect - https://phabricator.wikimedia.org/T251732 (10bmansurov) Just a little status update: I've removed YUI and working on upgrading bootstrap. Since a lo... [18:04:28] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10zhuyifei1999) Looking at it, https://github.com/toolforge/paws/blob/master/README.md already exists. Probably nothing to be done and should close instead. [18:05:36] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10Kanak8278) a:03Vaibhav_apt Sorry for the previous removal of the assignee. It was done by mistake. I must ask before claiming the task... [18:07:23] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10Kanak8278) Ok, so can I update the README.md file or can you help me find any other beginners task @zhuyifei1999 [18:08:31] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10zhuyifei1999) 05Open→03Resolved [18:10:12] 10Library-Card-Platform: Improve translation documentation - https://phabricator.wikimedia.org/T253480 (10Nikkimaria) [18:14:53] 10Product-Infrastructure-Team-Backlog: The number of citation doesn't match when using `/api/rest_v1/page/mobile-sections/` - https://phabricator.wikimedia.org/T253481 (10hueitan) [18:16:39] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): App doesn't work properly after having reference preview error - https://phabricator.wikimedia.org/T252387 (10hueitan) Ticket created here {T253481}, I hope the description is clear, do update if the provided information isn't enough. [18:16:53] 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, 10Wikimedia-GitHub, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) [18:17:29] 10PAWS, 10Documentation, 10good first task: Create a README.md file for PAWS on Github - https://phabricator.wikimedia.org/T246031 (10Soda) >>! In T246031#6161040, @Kanak8278 wrote: > Sorry for the previous removal of the assignee. It was done by mistake. I must ask before claiming the task... Generally no... [18:19:41] (03PS1) 10Xqt: [IMPR] Throttle requests after ratelimits exceeded [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598269 (https://phabricator.wikimedia.org/T253180) [18:20:14] 10Pywikibot, 10Patch-For-Review: touch.py does not throttle for rate limits correctly - https://phabricator.wikimedia.org/T253180 (10Xqt) a:03Xqt [18:21:47] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Throttle requests after ratelimits exceeded [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598269 (https://phabricator.wikimedia.org/T253180) (owner: 10Xqt) [18:22:01] 10Pywikibot, 10Patch-For-Review: "ratelimited" API error does not throttle for rate limits - https://phabricator.wikimedia.org/T253180 (10Xqt) [18:23:13] (03PS2) 10Xqt: [IMPR] Throttle requests after ratelimits exceeded [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598269 (https://phabricator.wikimedia.org/T253180) [18:28:48] (03PS2) 10Xqt: [IMPR] Make Pywikibot daemon logs unexecutable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) [18:30:23] (03CR) 10Xqt: [IMPR] Make Pywikibot daemon logs unexecutable (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) (owner: 10Xqt) [18:31:41] 10Cloud-Services, 10LDAP: Remove shell user "80686" - https://phabricator.wikimedia.org/T63967 (10Aklapper) This task has been stalled for three years. Tasks should not be stalled forever. It seems the options on the table are: 1) Changing regexes. 2) Renaming the user account. 3) Declining this task. Could s... [18:35:49] 10MediaWiki-Language-converter, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Contractor Workboard), 10I18n: Avoid using getNsIndex from UI / SpecialNewpages.php - https://phabricator.wikimedia.org/T253325 (10daniel) [18:36:08] (03CR) 10Daniel Kinzler: language: WIP! Introduce NamespaceNameLocalizer and NamespaceNameFormatter (032 comments) [core] - 10https://gerrit.wikimedia.org/r/596229 (https://phabricator.wikimedia.org/T252137) (owner: 10Peter.ovchyn) [18:41:09] 10AutoWikiBrowser, 10WorkType-NewFunctionality: Remove empty "See also"-section - https://phabricator.wikimedia.org/T105498 (10Aklapper) 05Stalled→03Open The previous comments don't explain what/who exactly this task is stalled on (["If a report is waiting for further input (e.g. from its reporter or a thi... [18:51:36] 10phan-taint-check-plugin: Report implicit or explict usage of Message::__toString in the phan-taint-check-plugin - https://phabricator.wikimedia.org/T252946 (10Umherirrender) [18:53:14] 10Tools, 10Wikidata: Duplicate statements by QuickStatements within one batch - https://phabricator.wikimedia.org/T234162 (10Epidosis) See also https://www.wikidata.org/wiki/Topic:Vkhd578n4cv9ndew. [18:57:20] (03PS1) 10Umherirrender: Fix return type for SpecialBlock::validateTargetField [core] - 10https://gerrit.wikimedia.org/r/598270 [19:00:45] (03PS1) 10Umherirrender: Fix param type for Status::msgInLang [core] - 10https://gerrit.wikimedia.org/r/598271 [19:01:40] (03CR) 10Huji: [C: 03+2] [cleanup] warnfile.py wasn't ported to core [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598180 (owner: 10Xqt) [19:01:47] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] warnfile.py wasn't ported to core [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598180 (owner: 10Xqt) [19:06:51] (03CR) 10Huji: [C: 03+2] [IMPR] Enable tuple for regex parameter in RegexFilter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598199 (owner: 10Xqt) [19:07:20] 10Wikidata, 10Maps (Kartographer): Show OpenStreetMap features associated with Wikidata items - https://phabricator.wikimedia.org/T173052 (10Pigsonthewing) >>! In T173052#6154762, @mxn wrote: > I think that would require a WDS query on every page load, which would spare one API by hammering another. Would i... [19:09:15] (03Merged) 10jenkins-bot: [IMPR] Enable tuple for regex parameter in RegexFilter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598199 (owner: 10Xqt) [19:10:07] (03PS4) 10Vidhi-Mody: Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) [19:11:28] (03CR) 10Reedy: [C: 03+2] Fix return type for SpecialBlock::validateTargetField [core] - 10https://gerrit.wikimedia.org/r/598270 (owner: 10Umherirrender) [19:11:48] (03PS1) 10Umherirrender: Parse messages in string context [core] - 10https://gerrit.wikimedia.org/r/598272 [19:11:51] 10DiscussionTools: Reply tool should not prefix template parameters with colons - https://phabricator.wikimedia.org/T253482 (10Tacsipacsi) [19:12:43] (03PS2) 10Umherirrender: Parse messages in string context [core] - 10https://gerrit.wikimedia.org/r/598272 [19:14:40] (03PS1) 10Paladox: Add .off file format to mime list [core] - 10https://gerrit.wikimedia.org/r/598273 [19:15:20] (03PS2) 10Paladox: Add .off file format to mime list [core] - 10https://gerrit.wikimedia.org/r/598273 [19:18:15] 10MediaWiki-libs-Mime, 10Performance-Team: MimeAnalyzer::improveTypeFromExtension() may return null - https://phabricator.wikimedia.org/T253483 (10ori) [19:20:13] 10Analytics: Revision_text field of mediawiki_wikitext_current is Not properly mapped - https://phabricator.wikimedia.org/T253484 (10DED) [19:22:26] (03CR) 10Bartosz Dziewoński: "Thanks, neat." [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/598086 (owner: 10Bartosz Dziewoński) [19:25:13] (03CR) 10jerkins-bot: [V: 04-1] Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) (owner: 10Vidhi-Mody) [19:25:29] 10VisualEditor, 10VisualEditor-MediaWiki: Fix arwiki's edit notice hacks to use enwiki's hack, so that it doesn't show up as "One notice" but blank - https://phabricator.wikimedia.org/T129773 (10Aklapper) 05Stalled→03Open No idea who exactly this task is stalled on, hence resetting task status as I can sti... [19:27:37] 10Wikibase-Lua, 10Wikidata: Add a Lua call that returns a list of defined properties without requiring a call to getEntity - https://phabricator.wikimedia.org/T253485 (10Mike_Peel) [19:27:41] (03Merged) 10jenkins-bot: Fix return type for SpecialBlock::validateTargetField [core] - 10https://gerrit.wikimedia.org/r/598270 (owner: 10Umherirrender) [19:27:50] 10Revision-Slider, 10WMDE-MediaWiki-maintenance: Should the Revision Slider still display suppressed users & summaries to users with rights to view them? - https://phabricator.wikimedia.org/T181223 (10Aklapper) 05Stalled→03Open >>! In T181223#4010051, @Addshore wrote: > This needs product / design input I... [19:29:11] 10Wikidata, 10Wikidata-Termbox, 10wikidata-tech-focus: Browserslist: caniuse-lite is outdated. Please run next command `npm update caniuse-lite browserslist` - https://phabricator.wikimedia.org/T226097 (10WMDE-leszek) [19:29:26] 10Pywikibot, 10Patch-For-Review: "ratelimited" API error does not throttle for rate limits - https://phabricator.wikimedia.org/T253180 (10JJMC89) Re 598269 PS2: The patch iterates a specific set of groups and calculates the delay based on the first one hit. It should iterate the groups in the response and cal... [19:29:40] 10Parsing-Team, 10TechCom-RFC: RFC: Accessing page properties from wiki pages - https://phabricator.wikimedia.org/T154738 (10Aklapper) 05Stalled→03Open The previous comments don't explain what/who exactly this task is stalled on (["If a report is waiting for further input (e.g. from its reporter or a third... [19:29:51] (03CR) 10JJMC89: [C: 04-1] [IMPR] Throttle requests after ratelimits exceeded (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598269 (https://phabricator.wikimedia.org/T253180) (owner: 10Xqt) [19:30:48] 10phan-taint-check-plugin: Report implicit or explict usage of Message::__toString in the phan-taint-check-plugin - https://phabricator.wikimedia.org/T252946 (10Umherirrender) A overview how often it is happen that a explict convert is missing: * * * * * * * * * * * * [19:33:51] 10MediaWiki-Interface, 10JavaScript: jquery.highlightText: Add support for matching multiple (non-adjecant) words - https://phabricator.wikimedia.org/T69784 (10Aklapper) 05Stalled→03Open The previous comments don't explain what/who exactly this task is stalled on (["If a report is waiting for further input... [19:38:53] 10Mobile-Content-Service, 10Product-Infrastructure-Team-Backlog, 10RESTBase-API: The number of citation doesn't match when using `/api/rest_v1/page/mobile-sections/` - https://phabricator.wikimedia.org/T253481 (10Aklapper) @hueitan: Assuming this task is about #RESTBase-API / #Mobile-Content-Service code pro... [19:49:53] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10I18n, 10RTL: "did you know that everyone can edit Wikipedia" toast may be shown with wrong directionality - https://phabricator.wikimedia.org/T253486 (10Amire80) [19:51:50] (03PS1) 10Ori.livneh: mime: Document null return from MimeAnalyzer::improveTypeFromExtension() [core] - 10https://gerrit.wikimedia.org/r/598274 (https://phabricator.wikimedia.org/T253483) [19:52:51] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10I18n, 10RTL: "did you know that everyone can edit Wikipedia" toast may be shown with wrong directionality - https://phabricator.wikimedia.org/T253486 (10Amire80) [19:59:22] 10Wikidata, 10User-Addshore: Productionize Generation of Wikidata maps and associated data (currently at https://tools.wmflabs.org/wikidata-analysis/) - https://phabricator.wikimedia.org/T184057 (10Aklapper) 05Stalled→03Open The previous comments don't explain what/who exactly this task is stalled on (["If... [20:00:24] (03CR) 10Bartosz Dziewoński: [C: 03+1] "I don't think this is ideal but I also don't want to block it forever and I can't commit to working on another solution." [core] - 10https://gerrit.wikimedia.org/r/585811 (https://phabricator.wikimedia.org/T236828) (owner: 10C. Scott Ananian) [20:02:04] 10Toolforge, 10Documentation, 10User-srodlund: Suggesting addition to tool labs documentation regarding tools that delibrately chmod their tool home dirs o-rx - https://phabricator.wikimedia.org/T164272 (10Aklapper) 05Stalled→03Open The previous comments don't explain what/who exactly this task is stalle... [20:07:37] 10StructuredDataOnCommons, 10Tools, 10Vue.js, 10Wikimedia-Hackathon-2020: Create a Structured Data on Commons search prototype (and create a Vue-based component library in the process) - https://phabricator.wikimedia.org/T252251 (10Husky) @Ramsey-WMF you might want to take a look at the prototype again, i'... [20:09:35] (03PS1) 10Umherirrender: Add escaping to LogPage::getTitleLink [core] - 10https://gerrit.wikimedia.org/r/598275 [20:12:00] (03PS5) 10Vidhi-Mody: Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) [20:13:30] (03PS1) 10D3r1ck01: changetags: ChangeTags::truncateTagDescription() has been deprecated [core] - 10https://gerrit.wikimedia.org/r/598276 [20:22:15] 10Commons, 10Discovery: Commons search page should be redesigned to make finding images easier - https://phabricator.wikimedia.org/T104565 (10Husky) Note that i've been working on a tool called [[ https://tools.wmflabs.org/hay/sdsearch/# | Structured Search ]] that is pretty much a proof-of-concept of how a re... [20:24:45] 10WikibaseMediaInfo: Upgrade WebdriverIO in the WikibaseMediaInfo repository - https://phabricator.wikimedia.org/T253487 (10Vidhi-Mody) [20:25:17] (03Abandoned) 10Aklapper: Update from v1.2.8 to ace v1.4.1 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/453402 (https://phabricator.wikimedia.org/T202121) (owner: 10Gvozdet) [20:26:12] 10CodeEditor: Update Ace Editor library to a more recent version - https://phabricator.wikimedia.org/T202121 (10Aklapper) 05Open→03Resolved a:03Esanders Indeed, thanks for catching that! Resolving. [20:31:16] 10translatewiki.net: Run deleteAutoPatrolLogs.php on translatewiki.net - https://phabricator.wikimedia.org/T199760 (10Aklapper) [20:31:17] 10MediaWiki-Maintenance-system: Make deleteAutopatrolLogs.php a logged update - https://phabricator.wikimedia.org/T201978 (10Aklapper) [20:32:25] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/598276 (owner: 10D3r1ck01) [20:36:44] 10MediaWiki-General, 10Wikidata-Page-Banner, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Display banners on diff pages - https://phabricator.wikimedia.org/T147946 (10Aklapper) 05Stalled→03Open Resetting task status as T147946#2837351 seems to answer T147946#2835467. (If this is technically not... [20:37:01] 10MediaWiki-General, 10Wikidata-Page-Banner, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Display banners on diff pages - https://phabricator.wikimedia.org/T147946 (10Aklapper) p:05Medium→03Low [20:43:39] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598180 (owner: 10Xqt) [20:47:45] (03PS57) 10Kosta Harlan: Help panel: Add quick start tips to guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593062 (https://phabricator.wikimedia.org/T244541) [20:48:56] 10Mobile-Content-Service, 10Product-Infrastructure-Team-Backlog: The number of citation doesn't match when using `/api/rest_v1/page/mobile-sections/` - https://phabricator.wikimedia.org/T253481 (10Mholloway) Thanks for the project tags, @Aklapper. I'll remove #restbase-api since this bug is almost certainly i... [20:49:13] 10Pywikibot, 10Patch-For-Review: "ratelimited" API error does not throttle for rate limits - https://phabricator.wikimedia.org/T253180 (10Xqt) Many thanks for this response sample [20:49:47] (03CR) 10Kosta Harlan: "> Patch Set 56:" (0317 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593062 (https://phabricator.wikimedia.org/T244541) (owner: 10Kosta Harlan) [20:51:11] (03PS1) 10Mholloway: Hygiene: Update diff fixtures [services/mobileapps] - 10https://gerrit.wikimedia.org/r/598277 [20:51:25] (03CR) 10Mholloway: [C: 03+2] Hygiene: Update diff fixtures [services/mobileapps] - 10https://gerrit.wikimedia.org/r/598277 (owner: 10Mholloway) [20:51:37] 10MediaWiki-Interface, 10JavaScript: jquery.highlightText: Add support for matching multiple (non-adjecant) words - https://phabricator.wikimedia.org/T69784 (10Krinkle) 05Open→03Declined This jQuery plugin primarily exists for the highlighting of text in short and prefix-based search suggestions. If it hap... [20:53:23] (03Merged) 10jenkins-bot: Hygiene: Update diff fixtures [services/mobileapps] - 10https://gerrit.wikimedia.org/r/598277 (owner: 10Mholloway) [20:54:02] (03CR) 10jerkins-bot: [V: 04-1] Help panel: Add quick start tips to guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593062 (https://phabricator.wikimedia.org/T244541) (owner: 10Kosta Harlan) [20:58:00] (03PS1) 10Paladox: Fix "Key 'page_random' doesn't exist in table 'image'" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 [20:58:21] (03PS2) 10Paladox: Fix "Key 'page_random' doesn't exist in table 'image'" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 [21:00:02] (03CR) 10Tacsipacsi: [C: 03+1] [IMPR] Make Pywikibot daemon logs unexecutable (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) (owner: 10Xqt) [21:00:11] (03CR) 10Paladox: "This broke the extension:" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/519103 (owner: 10Aaron Schulz) [21:00:41] (03PS58) 10Kosta Harlan: Help panel: Add quick start tips to guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593062 (https://phabricator.wikimedia.org/T244541) [21:05:06] (03CR) 10Xqt: [C: 03+2] [IMPR] Make Pywikibot daemon logs unexecutable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) (owner: 10Xqt) [21:05:29] 10Pywikibot, 10Patch-For-Review: Make Pywikibot daemon logs unexecutable - https://phabricator.wikimedia.org/T253472 (10Xqt) 05Open→03Resolved [21:05:47] (03CR) 10Reedy: "But it exists on the page table, which is included in the query?" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [21:07:17] (03Merged) 10jenkins-bot: [IMPR] Make Pywikibot daemon logs unexecutable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598238 (https://phabricator.wikimedia.org/T253472) (owner: 10Xqt) [21:09:21] (03CR) 10Yaron Koren: [C: 03+2] Preserve search terms (_search_A[0]=B) in links like "Next 250 results" [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/598214 (owner: 10Edward Chernenko) [21:11:58] (03Merged) 10jenkins-bot: Preserve search terms (_search_A[0]=B) in links like "Next 250 results" [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/598214 (owner: 10Edward Chernenko) [21:13:41] 10Privacy Engineering, 10Security-Team, 10TechCom, 10TechCom-RFC, and 4 others: RFC: Partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10AlexisJazz) >>! In T208188#6160584, @Krinkle wrote: > This RFC is about gadgets and other user-generated scripts which are n... [21:23:08] (03PS1) 10Alexandros Kosiaris: kafka-dev: Drop redundant YAML doc starts [deployment-charts] - 10https://gerrit.wikimedia.org/r/598279 [21:23:10] (03PS1) 10Alexandros Kosiaris: rake: Add kubeyaml validation [deployment-charts] - 10https://gerrit.wikimedia.org/r/598280 [21:24:04] 10DiscussionTools: Reply Tool try to indent the source code within the syntaxhighlight tag - https://phabricator.wikimedia.org/T253488 (10Lofhi) [21:24:40] (03PS5) 10Gergő Tisza: Add wsoauth role [vagrant] - 10https://gerrit.wikimedia.org/r/584900 [21:24:42] (03PS11) 10Gergő Tisza: [DNM] Wikispore modifications [vagrant] - 10https://gerrit.wikimedia.org/r/546156 [21:24:44] (03PS1) 10Gergő Tisza: Avoid shell expansion in mysql::sql commands [vagrant] - 10https://gerrit.wikimedia.org/r/598281 [21:24:46] (03PS1) 10Gergő Tisza: Add mediawiki::interwiki for defining interwikis [vagrant] - 10https://gerrit.wikimedia.org/r/598282 [21:25:22] (03CR) 10jerkins-bot: [V: 04-1] Add wsoauth role [vagrant] - 10https://gerrit.wikimedia.org/r/584900 (owner: 10Gergő Tisza) [21:25:24] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Wikispore modifications [vagrant] - 10https://gerrit.wikimedia.org/r/546156 (owner: 10Gergő Tisza) [21:25:27] (03CR) 10jerkins-bot: [V: 04-1] Add mediawiki::interwiki for defining interwikis [vagrant] - 10https://gerrit.wikimedia.org/r/598282 (owner: 10Gergő Tisza) [21:28:29] 10DiscussionTools: Reply tool should not prefix template parameters with colons - https://phabricator.wikimedia.org/T253482 (10Lofhi) [21:28:31] 10DiscussionTools: Reply Tool try to indent the source code within the syntaxhighlight tag - https://phabricator.wikimedia.org/T253488 (10Lofhi) [21:28:45] 10Privacy Engineering, 10Security-Team, 10TechCom, 10TechCom-RFC, and 4 others: RFC: Partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10Aklapper) >>! In T208188#6161207, @AlexisJazz wrote: > What do you mean by "this already works today"? It doesn't work on be... [21:39:03] (03CR) 10Paladox: "@Reedy i'm getting:" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [21:39:22] (03CR) 10Paladox: "Removing FORCE INDEX (xxx) from it, fixed the issue." [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [21:40:49] (03CR) 10Brian Wolff: [C: 03+2] [SECURITY] Fix various classic CSRF points in the special pages and API module + improve no-JS usability as well [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/598213 (https://phabricator.wikimedia.org/T248583) (owner: 10Jack Phoenix) [21:42:17] (03CR) 10Lokal Profil: [C: 04-1] "I'm pretty sure there is no need for us to implement any of the storage solutions by ourselves. If a wiki is using swift then default shou" (0352 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [21:43:06] (03Merged) 10jenkins-bot: [SECURITY] Fix various classic CSRF points in the special pages and API module + improve no-JS usability as well [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/598213 (https://phabricator.wikimedia.org/T248583) (owner: 10Jack Phoenix) [21:46:19] (03CR) 10Reedy: [C: 04-1] "I think the actual problem is the tables aren't joined. The original was LEFT JOIN'd, the new one isn't" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [21:47:18] 10DiscussionTools: Reply tool should not prefix template parameters or extension tags with colons - https://phabricator.wikimedia.org/T253482 (10Tacsipacsi) [21:47:22] (03CR) 10Reedy: Simplify pickFromDatabase() to only use IDatabase methods (031 comment) [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/519103 (owner: 10Aaron Schulz) [21:55:57] 10CPT Initiatives (API Gateway): Enable Phan on Bootstrap Extension - https://phabricator.wikimedia.org/T253323 (10CCicalese_WMF) See https://github.com/ProfessionalWiki/Bootstrap/pull/35. [21:56:04] (03CR) 10Reedy: [C: 04-1] "So it doesn't actually return an image then.." [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:00:36] (03PS3) 10Paladox: Fix "Key 'page_random' doesn't exist in table 'image'" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 [22:00:48] (03CR) 10Paladox: "@Reedy done, tested locally and exception fixed." [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:04:58] (03CR) 10Reedy: [C: 04-1] Fix "Key 'page_random' doesn't exist in table 'image'" (034 comments) [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:08:40] (03CR) 10Gehel: [C: 03+1] "LGTM" [puppet] - 10https://gerrit.wikimedia.org/r/598038 (owner: 10Elukey) [22:10:10] 10ExtensionDistributor, 10VPS-project-Extdist, 10MW-1.33-release, 10MW-1.34-release: Missing dependencies in extension snapshots - https://phabricator.wikimedia.org/T215713 (10Bawolff) Appears there are two issues: * Composer is checking platform-requirements. The php cli doesn't have very many extensions... [22:12:14] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/588180 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:16] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/Comments] - 10https://gerrit.wikimedia.org/r/588182 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:18] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/588183 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:20] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/588184 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:22] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/ImageRating] - 10https://gerrit.wikimedia.org/r/588186 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:24] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/588187 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:26] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/NumberOfWikis] - 10https://gerrit.wikimedia.org/r/588188 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:28] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/588189 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:30] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/588190 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:32] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/588191 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:34] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/588192 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:36] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache, require MW 1.34+ & minor cleanup [extensions/RandomImageByCategory] - 10https://gerrit.wikimedia.org/r/588193 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:38] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/Video] - 10https://gerrit.wikimedia.org/r/588195 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:40] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/588964 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:12:42] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache, explicitly require MW 1.34+, bump version number [extensions/SharedHelpPages] - 10https://gerrit.wikimedia.org/r/588972 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:13:07] (03CR) 10Jack Phoenix: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/588974 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:13:44] (03PS1) 10Brian Wolff: Allow installing composer dependencies even if missing php extensions [labs/tools/extdist] - 10https://gerrit.wikimedia.org/r/598283 (https://phabricator.wikimedia.org/T215713) [22:15:06] (03CR) 10Reedy: [C: 03+2] Allow installing composer dependencies even if missing php extensions [labs/tools/extdist] - 10https://gerrit.wikimedia.org/r/598283 (https://phabricator.wikimedia.org/T215713) (owner: 10Brian Wolff) [22:16:10] (03Merged) 10jenkins-bot: Allow installing composer dependencies even if missing php extensions [labs/tools/extdist] - 10https://gerrit.wikimedia.org/r/598283 (https://phabricator.wikimedia.org/T215713) (owner: 10Brian Wolff) [22:17:51] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/588180 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:17:57] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/Comments] - 10https://gerrit.wikimedia.org/r/588182 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:17:59] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/588183 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:18:21] (03CR) 10Paladox: "@Reedy doing:" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:18:44] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/588184 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:19:14] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/ImageRating] - 10https://gerrit.wikimedia.org/r/588186 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:19:16] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/588187 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:19:18] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/NumberOfWikis] - 10https://gerrit.wikimedia.org/r/588188 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:19:20] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/588189 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:19:22] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/588190 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:22:31] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/588191 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:22:33] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/588192 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:22:35] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache, require MW 1.34+ & minor cleanup [extensions/RandomImageByCategory] - 10https://gerrit.wikimedia.org/r/588193 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:22:37] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/Video] - 10https://gerrit.wikimedia.org/r/588195 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:22:39] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/588964 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:22:41] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache, explicitly require MW 1.34+, bump version number [extensions/SharedHelpPages] - 10https://gerrit.wikimedia.org/r/588972 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:22:43] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/588974 (https://phabricator.wikimedia.org/T243336) (owner: 10Jack Phoenix) [22:24:09] (03CR) 10Reedy: [C: 04-1] "Look at the query, it's missing the LEFT JOIN still" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:25:21] (03PS1) 10Brian Wolff: Include unzip package on extdist cloud vps tool for composer [puppet] - 10https://gerrit.wikimedia.org/r/598284 (https://phabricator.wikimedia.org/T215713) [22:28:39] (03CR) 10Paladox: "@Reedy ok, managed to get it include the left join now, but still failing with a syntax error now." [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:29:41] (03CR) 10Paladox: "Moving FORCE INDEX (page_random) to before the left query works, how do i do this in the selectRow function?" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:30:39] (03CR) 10Reedy: [C: 04-1] "MW puts the FORCE INDEX in the wrong place. I'll file a bug" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:34:25] 10Core Platform Team, 10Wikimedia-Rdbms: FORCE INDEX ends up in the wrong place with a join and force index - https://phabricator.wikimedia.org/T253489 (10Reedy) [22:36:02] (03CR) 10Reedy: [C: 03+2] "Have to go with the hack for now. T253489 filed for fixing it" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:38:39] (03Merged) 10jenkins-bot: Fix "Key 'page_random' doesn't exist in table 'image'" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/598278 (owner: 10Paladox) [22:39:01] 10Wikipedia-Android-App-Backlog: Nearby: Allow switching back to list view - https://phabricator.wikimedia.org/T126885 (10Charlotte) 05Open→03Invalid [22:39:03] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog: [EPIC] Improve search and discovery experience of "Nearby" in Android - https://phabricator.wikimedia.org/T205541 (10Charlotte) [22:39:10] 10Core Platform Team, 10Wikimedia-Rdbms: FORCE INDEX ends up in the wrong place with a join and force index - https://phabricator.wikimedia.org/T253489 (10Reedy) [22:39:17] 10Android-app-feature-Navigation, 10Wikipedia-Android-App-Backlog, 10Epic: Create a prototype to test an "Explicit reading mode" app and article navigation concept - https://phabricator.wikimedia.org/T196372 (10Charlotte) [22:39:19] 10Android-app-feature-Navigation, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Visual design updates to the Explore feed and bottom navigation bar for the "Explicit reading" mode - https://phabricator.wikimedia.org/T197705 (10Charlotte) 05Open→03Declined [22:39:53] (03CR) 10Krinkle: content: Add hidden preference to disable PST on CSS/JS content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585811 (https://phabricator.wikimedia.org/T236828) (owner: 10C. Scott Ananian) [22:40:10] (03PS1) 10Paladox: Fix "Key 'page_random' doesn't exist in table 'image'" [extensions/RandomImage] (REL1_34) - 10https://gerrit.wikimedia.org/r/598285 [22:41:35] (03CR) 10Krinkle: [C: 03+2] mime: Document null return from MimeAnalyzer::improveTypeFromExtension() [core] - 10https://gerrit.wikimedia.org/r/598274 (https://phabricator.wikimedia.org/T253483) (owner: 10Ori.livneh) [22:41:42] (03CR) 10Reedy: [C: 03+2] Fix "Key 'page_random' doesn't exist in table 'image'" [extensions/RandomImage] (REL1_34) - 10https://gerrit.wikimedia.org/r/598285 (owner: 10Paladox) [22:42:43] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog: [EPIC] Improve search and discovery experience of "Nearby" in Android - https://phabricator.wikimedia.org/T205541 (10Charlotte) 05Open→03Invalid [22:44:10] (03Merged) 10jenkins-bot: Fix "Key 'page_random' doesn't exist in table 'image'" [extensions/RandomImage] (REL1_34) - 10https://gerrit.wikimedia.org/r/598285 (owner: 10Paladox) [22:44:43] 10Dumps-Generation: Infoboxes are mistaken for abstracts in page abstract dumps. - https://phabricator.wikimedia.org/T111775 (10DED) I came to report this issue and I found that it exists since 2015. My estimate is that **half** of the abstracts dataset does not contain any info at all, but rather few bytes fro... [22:45:56] (03CR) 10Krinkle: mtail: update varnishrls compatibility with rc35 (031 comment) [puppet] - 10https://gerrit.wikimedia.org/r/594316 (https://phabricator.wikimedia.org/T251466) (owner: 10Cwhite) [22:45:59] (03CR) 10Krinkle: [C: 03+1] mtail: update varnishrls compatibility with rc35 [puppet] - 10https://gerrit.wikimedia.org/r/594316 (https://phabricator.wikimedia.org/T251466) (owner: 10Cwhite) [22:51:30] (03PS5) 10Krinkle: SpamChecker: Skip spam regex when input is null or empty string [core] - 10https://gerrit.wikimedia.org/r/596853 (https://phabricator.wikimedia.org/T252963) (owner: 10Ammarpad) [22:53:09] (03CR) 10Krinkle: [C: 03+1] "I still think the null issue needs solving at the source as well, but that can be done separately." [core] - 10https://gerrit.wikimedia.org/r/596853 (https://phabricator.wikimedia.org/T252963) (owner: 10Ammarpad) [22:54:33] 10Wikisource: Changing the link of the Upload file section in the tools tab - https://phabricator.wikimedia.org/T253490 (10Satirdan_kahraman) [22:55:06] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal exception of type "TypeError": Argument 1 passed to MediaWiki\EditPage\SpamChecker::checkSummary() must be of the type string,... - https://phabricator.wikimedia.org/T252963 [22:55:46] (03CR) 10Krinkle: [C: 04-1] "I see https://gerrit.wikimedia.org/r/596854 already exists, which does what I propose." [core] - 10https://gerrit.wikimedia.org/r/596853 (https://phabricator.wikimedia.org/T252963) (owner: 10Ammarpad) [22:57:01] (03CR) 10Krinkle: [C: 03+1] "This fixes an unbreak now without introducing any kind of regression. It merely restores status quo. If we cannot find the bug in 24 hours" [core] - 10https://gerrit.wikimedia.org/r/596854 (https://phabricator.wikimedia.org/T252963) (owner: 10DannyS712) [22:57:47] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal TypeError: Argument to SpamChecker::checkSummary() must be of the type string, null given - https://phabricator.wikimedia.org/T252963 (10Krinkle) [22:58:04] (03Merged) 10jenkins-bot: mime: Document null return from MimeAnalyzer::improveTypeFromExtension() [core] - 10https://gerrit.wikimedia.org/r/598274 (https://phabricator.wikimedia.org/T253483) (owner: 10Ori.livneh) [22:58:21] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal TypeError: Argument to SpamChecker::checkSummary() must be of the type string, null given - https://phabricator.wikimedia.org/T252963 (10Krinkle) [22:58:52] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal TypeError: Argument to SpamChecker::checkSummary() must be of the type string, null given - https://phabricator.wikimedia.org/T252963 (10Krinkle) [22:58:54] 10Release, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10Krinkle) [22:59:22] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal TypeError: Argument to SpamChecker::checkSummary() must be of the type string, null given - https://phabricator.wikimedia.org/T252963 (10Krinkle) p:05High→03Unbreak! [22:59:53] 10MediaWiki-Vagrant: Add Mediawiki-Vagrant role for MailCatcher - https://phabricator.wikimedia.org/T235174 (10Tgr) Can this be resolved then? FWIW Vagrant sends the email to localhost so you can check it by SSH-ing in and running `mail`. [23:00:34] 10Tools, 10Wikidata: Duplicate statements by QuickStatements within one batch - https://phabricator.wikimedia.org/T234162 (10M2k_dewiki) Also see https://www.wikidata.org/wiki/Help_talk:QuickStatements#duplicated_items_created [23:00:36] (03CR) 10Krinkle: "CI failing at https://gerrit.wikimedia.org/r/#/c/operations/software/thumbor-plugins/+/597998/" [integration/config] - 10https://gerrit.wikimedia.org/r/597992 (owner: 10Gilles) [23:02:49] 10MediaWiki-Parser: Allowing comments between the brackets of a wikilink should not depend on pipe-trick being used or not - https://phabricator.wikimedia.org/T253476 (10Dinoguy1000) The same thing happens if you use `` instead of a comment, with the same HTML output. Probably it would also happen th... [23:02:51] (03CR) 10Krinkle: "> How did this happened?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/598142 (https://phabricator.wikimedia.org/T77258) (owner: 10Krinkle) [23:06:05] (03PS12) 10Krinkle: linker: Move normalize target related code to appropriate class [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:06:32] (03PS13) 10Krinkle: linker: Move normalize target related code to appropriate class [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:07:33] (03PS14) 10Krinkle: linker: Move Linker::normalizeTarget to LinkRenderer service [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:07:37] (03CR) 10Krinkle: [C: 03+2] linker: Move Linker::normalizeTarget to LinkRenderer service [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:09:44] 10Technical-Tool-Request: Set up convos.by on Toolforge - https://phabricator.wikimedia.org/T253491 (10Tgr) [23:09:49] (03PS3) 10Krinkle: ParserOptionsTest: Rename non-global variable `$wgLang` [core] - 10https://gerrit.wikimedia.org/r/598143 (owner: 10DannyS712) [23:10:01] (03CR) 10DannyS712: linker: Move Linker::normalizeTarget to LinkRenderer service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:10:30] 10Wikimedia-Site-requests: Changing the link of the Upload file section in the tools tab - https://phabricator.wikimedia.org/T253490 (10Pppery) [23:11:00] (03PS4) 10Krinkle: ParserOptionsTest: Rename non-global variable `$wgLang` [core] - 10https://gerrit.wikimedia.org/r/598143 (https://phabricator.wikimedia.org/T160814) (owner: 10DannyS712) [23:11:13] (03CR) 10Krinkle: [C: 03+2] ParserOptionsTest: Rename non-global variable `$wgLang` [core] - 10https://gerrit.wikimedia.org/r/598143 (https://phabricator.wikimedia.org/T160814) (owner: 10DannyS712) [23:12:00] (03PS15) 10Krinkle: linker: Move Linker::normaliseSpecialPage to LinkRenderer class [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:12:04] (03CR) 10Krinkle: [C: 03+2] linker: Move Linker::normaliseSpecialPage to LinkRenderer class [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:14:22] 10Wikimedia-Site-requests: Changing the link of the Upload file section in the tools tab - https://phabricator.wikimedia.org/T253490 (10Satirdan_kahraman) [23:15:13] 10Wikispore: Email on Wikispore - https://phabricator.wikimedia.org/T243345 (10Tgr) The relevant docs are at [[https://wikitech.wikimedia.org/wiki/Help:Email_in_Cloud_VPS|Help:Email in Cloud VPS]]. [23:15:39] (03CR) 10Krinkle: [C: 04-1] Add URL template to the return data of mw.util.parseImageUrl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598127 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [23:16:55] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal TypeError: Argument to SpamChecker::checkSummary() must be of the type string, null given - https://phabricator.wikimedia.org/T252963 (10DannyS712) >>! In T252963#61612... [23:16:58] (03CR) 10Krinkle: "Oops, missed that. Thanks!" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/505826 (owner: 10Daimona Eaytoy) [23:20:08] (03CR) 10Krinkle: [C: 03+1] Add new SiteStatistics class to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [23:20:56] (03CR) 10Krinkle: filerepo: make ForeignDBRepo::getSharedKey() use the DB domain ID for consistency (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598183 (owner: 10Aaron Schulz) [23:27:34] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal TypeError: Argument to SpamChecker::checkSummary() must be of the type string, null given - https://phabricator.wikimedia.org/T252963 (10Krinkle) [23:29:30] (03CR) 10DannyS712: Add new SiteStatistics class to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [23:31:07] (03PS2) 10Gergő Tisza: Add mediawiki::interwiki for defining interwikis [vagrant] - 10https://gerrit.wikimedia.org/r/598282 [23:31:08] (03PS6) 10Gergő Tisza: Add wsoauth role [vagrant] - 10https://gerrit.wikimedia.org/r/584900 [23:31:10] (03PS12) 10Gergő Tisza: [DNM] Wikispore modifications [vagrant] - 10https://gerrit.wikimedia.org/r/546156 [23:31:38] (03Merged) 10jenkins-bot: ParserOptionsTest: Rename non-global variable `$wgLang` [core] - 10https://gerrit.wikimedia.org/r/598143 (https://phabricator.wikimedia.org/T160814) (owner: 10DannyS712) [23:31:42] (03PS14) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [23:31:47] (03Merged) 10jenkins-bot: linker: Move Linker::normaliseSpecialPage to LinkRenderer class [core] - 10https://gerrit.wikimedia.org/r/598094 (owner: 10D3r1ck01) [23:32:38] (03PS15) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [23:32:58] (03CR) 10Gergő Tisza: [C: 03+2] Parse messages in string context [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/598208 (owner: 10Umherirrender) [23:33:44] (03PS16) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [23:38:13] (03CR) 10Gergő Tisza: Add URL template to the return data of mw.util.parseImageUrl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598127 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [23:38:45] (03PS7) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) [23:38:52] (03CR) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) (owner: 10DannyS712) [23:40:11] (03Merged) 10jenkins-bot: Parse messages in string context [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/598208 (owner: 10Umherirrender) [23:40:22] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal TypeError: Argument to SpamChecker::checkSummary() must be of the type string, null given - https://phabricator.wikimedia.org/T252963 (10Krinkle) [23:40:43] (03CR) 10Krinkle: Inject SpamChecker where needed, hard deprecate EditPage static methods (032 comments) [core] - 10https://gerrit.wikimedia.org/r/596287 (https://phabricator.wikimedia.org/T251015) (owner: 10DannyS712) [23:41:13] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate $wgLang - https://phabricator.wikimedia.org/T160814 (10DannyS712) [23:42:09] (03PS11) 10DannyS712: Inject SpamChecker where needed, hard deprecate EditPage static methods [core] - 10https://gerrit.wikimedia.org/r/596287 (https://phabricator.wikimedia.org/T251015) [23:42:13] (03CR) 10DannyS712: Inject SpamChecker where needed, hard deprecate EditPage static methods (032 comments) [core] - 10https://gerrit.wikimedia.org/r/596287 (https://phabricator.wikimedia.org/T251015) (owner: 10DannyS712) [23:42:38] (03PS12) 10DannyS712: Inject SpamChecker where needed, hard deprecate EditPage static methods [core] - 10https://gerrit.wikimedia.org/r/596287 (https://phabricator.wikimedia.org/T251015) [23:42:40] (03CR) 10Gergő Tisza: Add URL template to the return data of mw.util.parseImageUrl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598127 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [23:45:28] (03PS11) 10Art-Baltai: Work with visibility and phpdoc of ConverterRule and LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) [23:45:37] (03CR) 10Ammarpad: ">If you cannot find the bug" [core] - 10https://gerrit.wikimedia.org/r/596853 (https://phabricator.wikimedia.org/T252963) (owner: 10Ammarpad) [23:47:31] (03PS11) 10Sahajsk: Use of SQL subqueries for every HOLDS occurrence [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 [23:49:26] (03CR) 10Sahajsk: "> Patch Set 10:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [23:50:18] 10AbuseFilter, 10User-DannyS712: Special:AbuseFilter/tools shown empty grey bar - https://phabricator.wikimedia.org/T253492 (10DannyS712) [23:53:12] (03CR) 10Ammarpad: ">I would prefer the SpamChecker service not need to support forever the mistake of passing null." [core] - 10https://gerrit.wikimedia.org/r/596853 (https://phabricator.wikimedia.org/T252963) (owner: 10Ammarpad) [23:56:55] (03PS3) 10Tim Starling: Use HttpRequestFactory::createMultiClient() in core where possible [core] - 10https://gerrit.wikimedia.org/r/597671 (https://phabricator.wikimedia.org/T245170) [23:57:25] (03CR) 10Yaron Koren: "Oh! Sorry for the confusion. The commit message is looking better now! Although now there's the opposite problem, where it doesn't mention" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597267 (owner: 10Sahajsk) [23:57:33] (03PS3) 10Art-Baltai: Add tests MessageCache::updateMessageOverride [core] - 10https://gerrit.wikimedia.org/r/588829 (https://phabricator.wikimedia.org/T243743) [23:57:52] (03CR) 10Tim Starling: Use HttpRequestFactory::createMultiClient() in core where possible (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597671 (https://phabricator.wikimedia.org/T245170) (owner: 10Tim Starling)