[00:00:16] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:04:32] (03PS5) 10Ejegg: WIP: fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) [00:06:19] 10Anti-Harassment (Zayin - ז): Design an interface for a BlockManager class(es) - https://phabricator.wikimedia.org/T219441 (10dbarratt) Factories (service): * `Block::newFromID()` * `Block::newLoad()` (this method should take in a target and return a block) * `Block::initFromRow()` * `Block::newFromRow()` *... [00:07:40] (03PS11) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [00:07:52] (03PS8) 10Zoranzoki21: Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) [00:08:14] (03CR) 10jenkins-bot: Clean up some database domain ID related code and fix some comments [core] - 10https://gerrit.wikimedia.org/r/500139 (owner: 10Aaron Schulz) [00:08:32] (03Merged) 10jenkins-bot: Replace several uses of wfWikiId() with WikiMap methods [core] - 10https://gerrit.wikimedia.org/r/500140 (owner: 10Aaron Schulz) [00:08:37] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of deprecated "wikiId" parameter for FileBackend [core] - 10https://gerrit.wikimedia.org/r/500141 (owner: 10Aaron Schulz) [00:08:40] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of deprecated wikiId field in JobQueue [core] - 10https://gerrit.wikimedia.org/r/500142 (owner: 10Aaron Schulz) [00:08:42] (03CR) 10jerkins-bot: [V: 04-1] Introduce registrationStart and registrationEnd audience checks [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/500107 (https://phabricator.wikimedia.org/T218304) (owner: 10Pmiazga) [00:08:44] (03CR) 10jerkins-bot: [V: 04-1] Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:09:11] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:10:06] (03CR) 10Dmaza: [C: 03+2] Fix function/class case [core] - 10https://gerrit.wikimedia.org/r/500150 (owner: 10MaxSem) [00:11:17] (03CR) 10Krinkle: [C: 04-1] "Looks like the browser test may've actually caught a bug." [core] - 10https://gerrit.wikimedia.org/r/500093 (owner: 10Aaron Schulz) [00:11:34] 10Core Platform Team, 10MediaWiki-Authentication-and-authorization: Undeprecate User::setInternalPassword() - https://phabricator.wikimedia.org/T219689 (10Isarra) [00:11:56] (03CR) 10jenkins-bot: Make RefreshLinksJob run DataUpdates such that they have outer scope [core] - 10https://gerrit.wikimedia.org/r/499958 (owner: 10Aaron Schulz) [00:14:48] (03PS12) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [00:14:58] (03PS9) 10Zoranzoki21: Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) [00:15:02] (03PS10) 10Zoranzoki21: Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) [00:15:04] (03CR) 10jenkins-bot: Replace several uses of wfWikiId() with WikiMap methods [core] - 10https://gerrit.wikimedia.org/r/500140 (owner: 10Aaron Schulz) [00:15:07] (03CR) 10jerkins-bot: [V: 04-1] Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:15:12] 10Core Platform Team, 10MediaWiki-Authentication-and-authorization: Undeprecate User::setInternalPassword() - https://phabricator.wikimedia.org/T219689 (10Krinkle) I haven't looked into the details (apologies), but my first thought is: What method is maintenance/changePassword.php using? If those are public an... [00:15:28] (03CR) 10Pmiazga: "instead of hardcoding this value, can we make it configurable? Just in case something somewhere explodes?" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/500132 (owner: 10Jdlrobson) [00:15:44] (03CR) 10jerkins-bot: [V: 04-1] Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:16:03] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:16:18] 10ContentTranslation, 10VisualEditor: Editing tooltip shown in read-only column - https://phabricator.wikimedia.org/T218752 (10Pginer-WMF) p:05Triage→03Low [00:16:25] (03CR) 10Divec: "We currently use it like this to analyse hard-to-reproduce IME issues on live sites. More than once before we've solved an issue by asking" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498345 (owner: 10Divec) [00:18:05] (03PS13) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [00:18:14] (03PS11) 10Zoranzoki21: Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) [00:18:56] (03CR) 10jerkins-bot: [V: 04-1] Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:19:18] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:20:40] (03CR) 10Krinkle: [C: 03+2] Avoid use of deprecated "wikiId" parameter for FileBackend [core] - 10https://gerrit.wikimedia.org/r/500141 (owner: 10Aaron Schulz) [00:21:18] (03CR) 10Krinkle: [C: 03+2] rdbms: add and enforce DB_REPLICA/DB_MASTER roles in DBConnRef [core] - 10https://gerrit.wikimedia.org/r/498202 (owner: 10Aaron Schulz) [00:22:29] (03Merged) 10jenkins-bot: Fix function/class case [core] - 10https://gerrit.wikimedia.org/r/500150 (owner: 10MaxSem) [00:22:55] (03CR) 10Krinkle: "Oh, that's why it was creating it..." [extensions/ArticlePlaceholder] - 10https://gerrit.wikimedia.org/r/500112 (https://phabricator.wikimedia.org/T219663) (owner: 10Krinkle) [00:24:53] (03PS14) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [00:25:05] (03PS12) 10Zoranzoki21: Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) [00:25:39] (03CR) 10jerkins-bot: [V: 04-1] Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:26:05] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:26:27] 10Core Platform Team, 10MediaWiki-Authentication-and-authorization: Undeprecate User::setInternalPassword() - https://phabricator.wikimedia.org/T219689 (10Isarra) ...it seems maintenance/changePassword.php just duplicates the content of setPasswordInternal(), which apparently //isn't// deprecated, just really... [00:26:39] 04(no projects): Formula cutoff in Russian and Ukrainian - https://phabricator.wikimedia.org/T219690 (10ABorbaWMF) [00:26:42] 10Core Platform Team, 10MediaWiki-Authentication-and-authorization: Undeprecate User::setInternalPassword() - https://phabricator.wikimedia.org/T219689 (10Isarra) 05Open→03Invalid I am so confused. [00:27:51] (03CR) 10jenkins-bot: Fix function/class case [core] - 10https://gerrit.wikimedia.org/r/500150 (owner: 10MaxSem) [00:28:04] (03PS15) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [00:28:21] (03PS13) 10Zoranzoki21: Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) [00:29:30] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [00:30:30] (03PS16) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [00:31:13] (03PS4) 10Krinkle: Fix broken sinon.stub use in createArticleTranslation.test.js [extensions/ArticlePlaceholder] - 10https://gerrit.wikimedia.org/r/500112 (https://phabricator.wikimedia.org/T219663) [00:31:46] (03PS4) 10Isarra: Add option to check for stub users, i.e. user table entries where user_password is empty [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/499671 (owner: 10Jack Phoenix) [00:32:37] (03PS5) 10Isarra: Add option to check for stub users, i.e. user table entries where user_password is empty [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/499671 (owner: 10Jack Phoenix) [00:36:31] (03PS1) 10Zoranzoki21: Remove namespace 104 from FlaggedRevs configuration for arwiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/500153 (https://phabricator.wikimedia.org/T217507) [00:36:39] (03PS2) 10Zoranzoki21: Remove namespace 104 from FlaggedRevs configuration for arwiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/500153 (https://phabricator.wikimedia.org/T217507) [00:37:27] (03PS3) 10Zoranzoki21: Remove namespace 104 from FlaggedRevs configuration for arwiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/500153 (https://phabricator.wikimedia.org/T217507) [00:37:40] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests, 10Patch-For-Review: FlaggedRevs still treats a removed namespace as if it still exists (arwiki) - https://phabricator.wikimedia.org/T217507 (10Zoranzoki21) a:03Zoranzoki21 Reclaimed, because I found solution for fix. [00:40:43] (03CR) 10jerkins-bot: [V: 04-1] Fix broken sinon.stub use in createArticleTranslation.test.js [extensions/ArticlePlaceholder] - 10https://gerrit.wikimedia.org/r/500112 (https://phabricator.wikimedia.org/T219663) (owner: 10Krinkle) [00:43:40] (03Merged) 10jenkins-bot: Avoid use of deprecated "wikiId" parameter for FileBackend [core] - 10https://gerrit.wikimedia.org/r/500141 (owner: 10Aaron Schulz) [00:43:49] (03Merged) 10jenkins-bot: Avoid use of deprecated wikiId field in JobQueue [core] - 10https://gerrit.wikimedia.org/r/500142 (owner: 10Aaron Schulz) [00:43:55] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add and enforce DB_REPLICA/DB_MASTER roles in DBConnRef [core] - 10https://gerrit.wikimedia.org/r/498202 (owner: 10Aaron Schulz) [00:45:08] 10Design: Formula cutoff in Russian and Ukrainian - https://phabricator.wikimedia.org/T219690 (10Zoranzoki21) [00:47:19] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Editor requests/feedback - https://phabricator.wikimedia.org/T219691 (10ABorbaWMF) [00:47:54] 10Commons, 10Wikimedia-Site-requests, 10Tracking: Add domains to $wgCopyUploadsDomains (tracking) - https://phabricator.wikimedia.org/T60224 (10Zoranzoki21) [00:47:56] (03CR) 10jenkins-bot: Avoid use of deprecated wikiId field in JobQueue [core] - 10https://gerrit.wikimedia.org/r/500142 (owner: 10Aaron Schulz) [00:47:57] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Design: Formula cutoff in Russian and Ukrainian - https://phabricator.wikimedia.org/T219690 (10ABorbaWMF) [00:48:00] 10Commons, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Please add mojnews.com to the wgCopyUploadsDomains whitelist of Wikimedia Commons - https://phabricator.wikimedia.org/T213901 (10Zoranzoki21) 05Stalled→03Declined If you still want this, please reopen task. [00:49:42] 10Commons, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Please add uni-hamburg.de to $wgCopyUploadsDomains - https://phabricator.wikimedia.org/T216886 (10Zoranzoki21) >>! In T216886#5056221, @Framawiki wrote: >>>! In T216886#5056126, @Zoranzoki21 wrote: >> Ok, so I will add only uni-hamburg.de >> >> Thank... [00:50:08] (03PS5) 10Krinkle: Fix broken sinon.stub use in createArticleTranslation.test.js [extensions/ArticlePlaceholder] - 10https://gerrit.wikimedia.org/r/500112 (https://phabricator.wikimedia.org/T219663) [00:52:04] (03CR) 10Krinkle: [C: 04-1] "Still same sqlite error as commented on PS5. Not flaky then I guess, but due to this commit." [core] - 10https://gerrit.wikimedia.org/r/498202 (owner: 10Aaron Schulz) [00:52:41] (03CR) 10jenkins-bot: Avoid use of deprecated "wikiId" parameter for FileBackend [core] - 10https://gerrit.wikimedia.org/r/500141 (owner: 10Aaron Schulz) [00:55:17] (03PS1) 10Zoranzoki21: Add three domains at wgCopyUploadDomains [mediawiki-config] - 10https://gerrit.wikimedia.org/r/500154 (https://phabricator.wikimedia.org/T216886) [01:02:17] (03CR) 10Krinkle: [C: 03+2] Move all Paint Timing event collection to Schema:PaintTiming (031 comment) [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/495839 (https://phabricator.wikimedia.org/T217395) (owner: 10Gilles) [01:04:09] 10MediaWiki-Internationalization, 10I18n: Remove tokipona support - https://phabricator.wikimedia.org/T132899 (10Zoranzoki21) [01:05:51] (03PS2) 10Aaron Schulz: Add UserOptionsUpdateJob class and use it for namespaces at SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/499985 (https://phabricator.wikimedia.org/T92357) [01:08:27] (03CR) 10Krinkle: [WIP] Tweak MysqlUpdater::doWatchlistUpdate query (031 comment) [core] - 10https://gerrit.wikimedia.org/r/499733 (https://phabricator.wikimedia.org/T160993) (owner: 10Aaron Schulz) [01:09:00] (03CR) 10Krinkle: [C: 03+2] mediawiki.user: Improve test suite [core] - 10https://gerrit.wikimedia.org/r/500113 (owner: 10Krinkle) [01:09:08] (03CR) 10Krinkle: [C: 03+2] mediawiki.user: Use then() instead of done() [core] - 10https://gerrit.wikimedia.org/r/500092 (owner: 10Krinkle) [01:11:13] (03CR) 10Smalyshev: "recheck" [extensions/WikibaseLexeme] - 10https://gerrit.wikimedia.org/r/499878 (https://phabricator.wikimedia.org/T216206) (owner: 10Smalyshev) [01:12:46] 10Advanced Mobile Contributions, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Cannot access user contributions when following red link to user page on mobile - https://phabricator.wikimedia.org/T201339 (1... [01:14:34] 10Editing-team, 10ImageMap, 10VisualEditor, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 3 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Begoon) Agree that floats should be permitted, and any type conversion only done after sc... [01:15:56] 10Advanced Mobile Contributions, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Cannot access user contributions when following red link to user page on mobile - https://phabricator.wikimedia.org/T201339 (1... [01:19:24] (03Merged) 10jenkins-bot: Move all Paint Timing event collection to Schema:PaintTiming [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/495839 (https://phabricator.wikimedia.org/T217395) (owner: 10Gilles) [01:24:07] (03Merged) 10jenkins-bot: mediawiki.user: Improve test suite [core] - 10https://gerrit.wikimedia.org/r/500113 (owner: 10Krinkle) [01:24:56] (03PS10) 10Aaron Schulz: rdbms: add and enforce DB_REPLICA/DB_MASTER roles in DBConnRef [core] - 10https://gerrit.wikimedia.org/r/498202 [01:28:02] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): MFA: ImageOverlay should be an Overlay Composed of Comp... - https://phabricator.wikimedia.org/T216198 [01:28:04] (03CR) 10jenkins-bot: mediawiki.user: Improve test suite [core] - 10https://gerrit.wikimedia.org/r/500113 (owner: 10Krinkle) [01:29:08] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): MFA: ImageOverlay should be an Overlay Composed of Comp... - https://phabricator.wikimedia.org/T216198 [01:29:41] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): MFA: ImageOverlay should be an Overlay Composed of Comp... - https://phabricator.wikimedia.org/T216198 [01:34:45] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Setting system display size to larger (accessibility) - https://phabricator.wikimedia.org/T219692 (10ABorbaWMF) [01:35:39] (03Merged) 10jenkins-bot: mediawiki.user: Use then() instead of done() [core] - 10https://gerrit.wikimedia.org/r/500092 (owner: 10Krinkle) [01:36:03] 10DBA, 10Wikimedia-Site-requests: Global rename of Foundling → Expósito: supervision needed - https://phabricator.wikimedia.org/T219693 (101997kB) [01:38:32] (03CR) 10Sbisson: Logging: HomepageModule events (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/500101 (https://phabricator.wikimedia.org/T219583) (owner: 10Sbisson) [01:39:30] (03CR) 10jenkins-bot: mediawiki.user: Use then() instead of done() [core] - 10https://gerrit.wikimedia.org/r/500092 (owner: 10Krinkle) [01:57:10] (03CR) 10Krinkle: [C: 04-1] "check php" [core] - 10https://gerrit.wikimedia.org/r/498202 (owner: 10Aaron Schulz) [01:57:30] (03CR) 10Krinkle: [C: 04-1] "(sqlite and psql only run on gate, and on 'check php')" [core] - 10https://gerrit.wikimedia.org/r/498202 (owner: 10Aaron Schulz) [02:02:46] (03PS1) 10Aaron Schulz: jobqueue: fix DBO_TRX logic in JobQueueDB for avoiding transactions [core] - 10https://gerrit.wikimedia.org/r/500155 [02:04:34] (03PS11) 10Aaron Schulz: rdbms: add and enforce DB_REPLICA/DB_MASTER roles in DBConnRef [core] - 10https://gerrit.wikimedia.org/r/498202 [02:06:01] (03CR) 10VolkerE: [C: 04-1] Reset history page styles for Minerva (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/500133 (owner: 10Jdlrobson) [02:08:19] (03CR) 10Krinkle: [C: 04-1] Add node selenium tests for revision highlight feature (032 comments) [extensions/RevisionSlider] - 10https://gerrit.wikimedia.org/r/499855 (owner: 10WMDE-Fisch) [02:10:35] (03CR) 10Krinkle: [C: 04-1] Add node selenium tests for revision highlight feature (031 comment) [extensions/RevisionSlider] - 10https://gerrit.wikimedia.org/r/499855 (owner: 10WMDE-Fisch) [02:24:33] (03CR) 10Krinkle: Special:Contribution form can be collapsed (032 comments) [core] - 10https://gerrit.wikimedia.org/r/490493 (https://phabricator.wikimedia.org/T191868) (owner: 10Jdlrobson) [02:29:08] (03CR) 10Krinkle: build: Do not duplicate localisation messages and their docs in JS code (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/492943 (owner: 10Bartosz Dziewoński) [02:31:01] (03PS12) 10Aaron Schulz: rdbms: add and enforce DB_REPLICA/DB_MASTER roles in DBConnRef [core] - 10https://gerrit.wikimedia.org/r/498202 [02:31:28] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Edtadros) === Test Result **Status:** ❓ Please review **OS:** macOS Moja... [02:31:49] (03PS2) 10Aaron Schulz: [WIP] Tweak MysqlUpdater::doWatchlistUpdate query [core] - 10https://gerrit.wikimedia.org/r/499733 (https://phabricator.wikimedia.org/T160993) [02:32:54] (03CR) 10Aaron Schulz: [C: 03+2] auth: Make 'LocalUserCreated' hook non-abortable [core] - 10https://gerrit.wikimedia.org/r/500094 (owner: 10Krinkle) [02:35:08] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Edtadros) [02:35:19] (03CR) 10Krinkle: Treat ambiguous values in $wgVisualEditorAvailableNamespaces as names (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499945 (https://phabricator.wikimedia.org/T219562) (owner: 10Bartosz Dziewoński) [02:38:59] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team, 10Quibble: Enable compression for MW web responses in Jenkins Jenkins (e.g. Quibble, Fresnel) - https://phabricator.wikimedia.org/T219694 (10Krinkle) [02:39:28] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team, 10Quibble: Enable compression for MW web responses in Jenkins Jenkins (e.g. Quibble, Fresnel) - https://phabricator.wikimedia.org/T219694 (10Krinkle) [02:41:42] 10AbuseFilter, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable wgAbuseFilterNotificationsPrivate on commons.wikimedia.org - https://phabricator.wikimedia.org/T218527 (10MusikAnimal) @Daimona Did this get deployed? One of the private filters I monitor was tripped today but I don't think it was reported... [02:45:43] 10AbuseFilter, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable wgAbuseFilterNotificationsPrivate on commons.wikimedia.org - https://phabricator.wikimedia.org/T218527 (10MusikAnimal) I don't see it at https://noc.wikimedia.org/conf/highlight.php?file=abusefilter.php so I'm guessing that's a no. It's not... [02:45:59] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add and enforce DB_REPLICA/DB_MASTER roles in DBConnRef [core] - 10https://gerrit.wikimedia.org/r/498202 (owner: 10Aaron Schulz) [02:48:11] (03Merged) 10jenkins-bot: auth: Make 'LocalUserCreated' hook non-abortable [core] - 10https://gerrit.wikimedia.org/r/500094 (owner: 10Krinkle) [02:51:35] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team, 10Quibble: Enable compression for MW web responses in Jenkins Jenkins (e.g. Quibble, Fresnel) - https://phabricator.wikimedia.org/T219694 (10Krinkle) I thought maybe that our use of the PHP built-in webserver (`php -S`) is causing thi... [02:52:21] (03CR) 10jenkins-bot: auth: Make 'LocalUserCreated' hook non-abortable [core] - 10https://gerrit.wikimedia.org/r/500094 (owner: 10Krinkle) [02:59:07] (03PS1) 10Krinkle: resourceloader: Remove deprecated MessageBlobStore::getBlob [core] - 10https://gerrit.wikimedia.org/r/500156 [02:59:55] (03PS2) 10Krinkle: resourceloader: Remove deprecated MessageBlobStore::getBlob [core] - 10https://gerrit.wikimedia.org/r/500156 [03:01:28] (03PS1) 10Aaron Schulz: Remove old non-functional job related scripts [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/500157 [03:02:12] (03CR) 10Krinkle: "@Volker I think you may've misunderstood. This patch is about removing the attribute on purpose." [skins/Vector] - 10https://gerrit.wikimedia.org/r/318043 (owner: 10Fomafix) [03:02:32] (03PS1) 10Krinkle: Fix invalid lang attribute on first heading [skins/Vector] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500158 (https://phabricator.wikimedia.org/T219359) [03:02:44] 10Vector, 10Wikidata, 10Wikidata-Campsite, 10Accessibility, and 3 others: lang attribute of page title is empty - https://phabricator.wikimedia.org/T219359 (10Krinkle) 05Open→03Resolved a:03Krinkle [03:04:03] (03CR) 10Krinkle: [C: 03+2] Fix invalid lang attribute on first heading [skins/Vector] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500158 (https://phabricator.wikimedia.org/T219359) (owner: 10Krinkle) [03:04:10] 10Vector, 10Wikidata, 10Wikidata-Campsite, 10Accessibility, and 3 others: lang attribute of page title is empty - https://phabricator.wikimedia.org/T219359 (10Krinkle) This was a regression from https://gerrit.wikimedia.org/r/493093 due to a typo in the variable name. Now fixed, and backported. [03:05:59] 10MediaWiki-Core-Testing, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Add EditPage to wdio-mediawiki - https://phabricator.wikimedia.org/T219653 (10Krinkle) >>! In T219653#5070334, @zeljkofilipin wrote: > I think it would be better to add the functionality to `Api.edit()` than to use `EditPage... [03:06:40] 10MediaWiki-Core-Testing, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Add EditPage to wdio-mediawiki - https://phabricator.wikimedia.org/T219653 (10Krinkle) >>! In T219653#5070364, @WMDE-Fisch wrote: > At least for #two-column-edit-conflict-merge I need to do a "real manual" edit with the edit... [03:09:33] (03Merged) 10jenkins-bot: Fix invalid lang attribute on first heading [skins/Vector] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500158 (https://phabricator.wikimedia.org/T219359) (owner: 10Krinkle) [03:10:02] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10Edtadros) a:05Edtadros→03matthiasmullie === Test Result **Status:** : ❌ FAIL **OS:** macOS Mojave **Browser:** Chrome *... [03:10:18] 10Editing-team, 10ImageMap, 10VisualEditor, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 3 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Krinkle) 05Resolved→03Open p:05Triage→03Unbreak! This is breaking real content th... [03:10:19] (03PS1) 10Krinkle: Revert "Warn user about invalid coordinates" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500159 [03:10:28] (03PS2) 10Krinkle: Revert "Warn user about invalid coordinates" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500159 (https://phabricator.wikimedia.org/T217087) [03:10:33] (03CR) 10jenkins-bot: Fix invalid lang attribute on first heading [skins/Vector] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500158 (https://phabricator.wikimedia.org/T219359) (owner: 10Krinkle) [03:10:35] (03PS1) 10Krinkle: Revert "Warn user about invalid coordinates" [extensions/ImageMap] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500160 (https://phabricator.wikimedia.org/T217087) [03:12:36] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10Edtadros) [03:13:17] (03CR) 10Krinkle: [C: 03+1] "wmfManageJobs is relatively new. It's main purpose was to help delete stray legacy jobs from deleted wikis." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/500157 (owner: 10Aaron Schulz) [03:14:32] 10Release, 10Release-Engineering-Team (Kanban), 10Train Deployments: 1.33.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T206678 (10Krinkle) [03:14:40] 10Editing-team, 10ImageMap, 10VisualEditor, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 4 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Krinkle) [03:15:39] (03CR) 10Krinkle: [C: 03+2] Revert "Warn user about invalid coordinates" [extensions/ImageMap] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500160 (https://phabricator.wikimedia.org/T217087) (owner: 10Krinkle) [03:16:10] 10Editing-team, 10ImageMap, 10VisualEditor, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 4 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Krinkle) Reverted in-branch to unbreak prod. Still broken in master, to be fixed (or also... [03:19:32] 10Anti-Harassment, 10MediaWiki-User-management, 10Wikimedia-production-error (Shared Build Failure): Flaky test BlockListPagerTest::testFormatValue - https://phabricator.wikimedia.org/T219695 (10Krinkle) [03:21:28] 10Anti-Harassment, 10MediaWiki-User-management, 10Wikimedia-production-error (Shared Build Failure): Flaky test BlockListPagerTest::testFormatValue - https://phabricator.wikimedia.org/T219695 (10Krinkle) Git says it was introduced in 170c49d61c (ref T197143, [Gerrit change](https://gerrit.wikimedia.org/r/#/c... [03:24:01] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10MediaWiki-JobQueue, and 3 others: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB) - https://phabricator.wikimedia.org/T124196 (10Krinkle) [03:24:11] 10CirrusSearch, 10Discovery-Search, 10Wikimedia-production-error: Fatal "cannot perform this operation with arrays" from Job/ElasticaWrite.php - https://phabricator.wikimedia.org/T218943 (10Krinkle) [03:24:13] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10MediaWiki-JobQueue, and 3 others: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB) - https://phabricator.wikimedia.org/T124196 (10Krinkle) [03:25:25] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10MediaWiki-JobQueue, and 3 others: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB) - https://phabricator.wikimedia.org/T124196 (10Krinkle) Still seen. Causing some search jobs to fail for wikitech.wikimed... [03:27:27] (03Merged) 10jenkins-bot: Revert "Warn user about invalid coordinates" [extensions/ImageMap] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500160 (https://phabricator.wikimedia.org/T217087) (owner: 10Krinkle) [03:28:26] (03CR) 10jenkins-bot: Revert "Warn user about invalid coordinates" [extensions/ImageMap] (wmf/1.33.0-wmf.23) - 10https://gerrit.wikimedia.org/r/500160 (https://phabricator.wikimedia.org/T217087) (owner: 10Krinkle) [03:30:56] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10MediaWiki-JobQueue, and 3 others: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB) - https://phabricator.wikimedia.org/T124196 (10Krinkle) >>! In T218943#5067284, @EBernhardson wrote: > The two available... [03:33:49] (03PS1) 10Aaron Schulz: jobqueue: remove entire unused JobQueueAggregator class hierarchy [core] - 10https://gerrit.wikimedia.org/r/500161 [03:37:54] 10Editing-team, 10ImageMap, 10VisualEditor, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 4 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Krinkle) >>! In T217087#5071494, @Krinkle wrote: > This is breaking real content that has... [03:41:37] 10Recommendation-API, 10Google-Summer-of-Code (2019): Recommendation API: output source language - https://phabricator.wikimedia.org/T219505 (10Usmanmuhd) I followed all the steps, and when I run `npm start server.js | bunyan` I get ` usman@lenovo:~/recommendation-api$ npm start server.js | bunyan bunyan: comm... [03:45:14] (03PS1) 10Aaron Schulz: Do not return invalid JSON in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/500162 [03:49:50] 10Operations, 10Prod-Kubernetes, 10Kubernetes: Alert "kubelet operational latencies" - https://phabricator.wikimedia.org/T219696 (10Krinkle) [03:50:26] 10Operations, 10Prod-Kubernetes, 10Kubernetes: Alert "kubelet operational latencies" - https://phabricator.wikimedia.org/T219696 (10Krinkle) [03:54:27] (03CR) 10Aaron Schulz: "Anything using JobQueueAggregator::singleton() is not going to work at all" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/500157 (owner: 10Aaron Schulz) [03:56:18] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts and other statements on a bicycle), 10SDC-Statements (Depicts-on-training-wheels): Build search/depicts prototype - https://phabricator.wikimedia.org/T199120 (10Edtadros) === Test Result **Status:** ✅ PASS **OS:** ma... [03:57:14] 10Recommendation-API, 10Google-Summer-of-Code (2019): Recommendation API: output source language - https://phabricator.wikimedia.org/T219505 (10Usmanmuhd) When I navigate to http://localhost:6927/en/v1/article/creation/morelike/book I get: ` [2019-03-30T03:53:56.675Z] TRACE: recommendation-api/26082 on lenovo:... [03:59:10] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts and other statements on a bicycle), 10SDC-Statements (Depicts-on-training-wheels): Build search/depicts prototype - https://phabricator.wikimedia.org/T199120 (10Edtadros) [03:59:44] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts and other statements on a bicycle), 10SDC-Statements (Depicts-on-training-wheels): Build search/depicts prototype - https://phabricator.wikimedia.org/T199120 (10Edtadros) a:05Edtadros→03Ramsey-WMF @Ramsey-WMF This... [04:00:45] (03PS1) 10Smalyshev: Allow extension not to have extra fields but still use this test. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/500163 [04:01:09] (03PS5) 10Smalyshev: Remove Elastic/Cirrus code - moved to WikibaseLexemeCirrusSearch [extensions/WikibaseLexeme] - 10https://gerrit.wikimedia.org/r/499878 (https://phabricator.wikimedia.org/T216206) [04:01:35] (03CR) 10Smalyshev: "recheck" [extensions/WikibaseLexemeCirrusSearch] - 10https://gerrit.wikimedia.org/r/499401 (https://phabricator.wikimedia.org/T216206) (owner: 10Smalyshev) [04:03:08] (03PS13) 10Aaron Schulz: rdbms: add and enforce DB_REPLICA/DB_MASTER roles in DBConnRef [core] - 10https://gerrit.wikimedia.org/r/498202 [04:03:31] (03CR) 10Aaron Schulz: "check php" [core] - 10https://gerrit.wikimedia.org/r/498202 (owner: 10Aaron Schulz) [04:07:14] (03CR) 10Krinkle: [C: 03+2] Remove old non-functional job related scripts [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/500157 (owner: 10Aaron Schulz) [04:08:34] (03PS1) 10Mholloway: Hygiene: Update diff fixtures [services/mobileapps] - 10https://gerrit.wikimedia.org/r/500164 [04:11:21] (03Merged) 10jenkins-bot: Remove old non-functional job related scripts [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/500157 (owner: 10Aaron Schulz) [04:12:26] (03CR) 10jenkins-bot: Remove old non-functional job related scripts [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/500157 (owner: 10Aaron Schulz) [04:13:03] (03CR) 10Krinkle: "Is it broken or unused by wmf?" [core] - 10https://gerrit.wikimedia.org/r/500161 (owner: 10Aaron Schulz) [04:13:13] (03CR) 10jerkins-bot: [V: 04-1] Move Cirrus configs to the extension [extensions/WikibaseLexemeCirrusSearch] - 10https://gerrit.wikimedia.org/r/499401 (https://phabricator.wikimedia.org/T216206) (owner: 10Smalyshev) [04:13:44] (03CR) 10Krinkle: [C: 03+2] Do not return invalid JSON in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/500162 (owner: 10Aaron Schulz) [04:14:33] (03CR) 10Mholloway: [C: 03+2] Hygiene: Update diff fixtures [services/mobileapps] - 10https://gerrit.wikimedia.org/r/500164 (owner: 10Mholloway) [04:15:32] (03CR) 10Krinkle: [C: 03+1] "LGTM, but somewhat surprised this is needed. I recall something about things like caching, localisation and jobs using a separate db/conne" [core] - 10https://gerrit.wikimedia.org/r/500155 (owner: 10Aaron Schulz) [04:16:07] (03Merged) 10jenkins-bot: Hygiene: Update diff fixtures [services/mobileapps] - 10https://gerrit.wikimedia.org/r/500164 (owner: 10Mholloway) [04:22:12] (03CR) 10Krinkle: [C: 03+1] "Got an idea that might allow us to avoid closures for all newer updates that don't take titles." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/499985 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [04:22:22] (03CR) 10Aaron Schulz: "There are cases were it is still stuck using the main DB. One of my installer patches is also still pending (which would solve other cases" [core] - 10https://gerrit.wikimedia.org/r/500155 (owner: 10Aaron Schulz) [04:23:16] (03CR) 10Krinkle: "Not landing so as to make it easy to follow-up with a fix in master. But if not by Tuesday, then land this instead." [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500159 (https://phabricator.wikimedia.org/T217087) (owner: 10Krinkle) [04:25:51] (03PS3) 10Aaron Schulz: Add UserOptionsUpdateJob class and use it for namespaces at SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/499985 (https://phabricator.wikimedia.org/T92357) [04:25:54] (03CR) 10Krinkle: [C: 03+1] "Ah, is that https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/495418/ ?" [core] - 10https://gerrit.wikimedia.org/r/500155 (owner: 10Aaron Schulz) [04:26:06] (03Merged) 10jenkins-bot: Do not return invalid JSON in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/500162 (owner: 10Aaron Schulz) [04:27:35] (03CR) 10Aaron Schulz: "I thought about using a trivial interface and is_subclass_of() in Job::factory(). That could work." [core] - 10https://gerrit.wikimedia.org/r/499985 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [04:32:29] (03CR) 10jenkins-bot: Do not return invalid JSON in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/500162 (owner: 10Aaron Schulz) [04:51:18] (03PS1) 10Aaron Schulz: Avoid using deprecated JobQueue::getWiki() method [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/500165 [05:20:20] 10Editing-team, 10ImageMap, 10VisualEditor, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 4 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Begoon) >>! In T217087#5071532, @Krinkle wrote: >>>! In T217087#5071494, @Krinkle wrote:... [05:29:08] (03CR) 10AndyRussG: "Here's a more specific proposal regarding tests: why don't we add one test for the most important non-preview functionality of SpecialBann" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: 10Vedmaka Wakalaka) [05:39:24] (03PS6) 10VolkerE: Reset history page styles for Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/500133 (owner: 10Jdlrobson) [05:44:56] (03CR) 10Niedzielski: Demo: Viewless BetaOptInPanel (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/498196 (owner: 10Niedzielski) [05:59:40] (03PS1) 10VolkerE: Reduce `li` selector specificity for general li treatment [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/500166 [06:00:18] (03CR) 10VolkerE: "Triggered by Ic57cb79903e90ce1bbfa6d87ab0499f09373e732" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/500166 (owner: 10VolkerE) [06:33:02] 04(no projects): Suggestion: implement shadow banning on Wikimedia wikis - https://phabricator.wikimedia.org/T219697 (10UpsandDowns1234) [06:41:13] 10MediaWiki-extensions-WikimediaBadges, 10Documentation: Document WikimediaBadges - https://phabricator.wikimedia.org/T212020 (10Eisheeta) @Aklapper Hi! I've updated the [[ https://www.mediawiki.org/wiki/Extension:WikimediaBadges | wikimediabadges ]] page. I have incorporated these subheadings: Description, Do... [06:56:57] 10PAWS, 10Documentation: Document how to add library support in PAWS - https://phabricator.wikimedia.org/T219354 (10Psychoslave) By the way @Chicocvenancio, what about making most popular module preinstalled? I don't know how popular tensorflow is among PAWS users, but surely they are module that are popular... [07:09:11] (03PS9) 10Smalyshev: Move Cirrus configs to the extension [extensions/WikibaseLexemeCirrusSearch] - 10https://gerrit.wikimedia.org/r/499401 (https://phabricator.wikimedia.org/T216206) [07:20:00] (03CR) 10jerkins-bot: [V: 04-1] Move Cirrus configs to the extension [extensions/WikibaseLexemeCirrusSearch] - 10https://gerrit.wikimedia.org/r/499401 (https://phabricator.wikimedia.org/T216206) (owner: 10Smalyshev) [07:33:16] (03PS13) 10Pablo Grass (WMDE): Introduce edit-label, -descriptions and -aliases [wikibase/termbox] - 10https://gerrit.wikimedia.org/r/499043 (https://phabricator.wikimedia.org/T218572) (owner: 10Matthias Geisler) [07:34:08] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test" [wikibase/termbox] - 10https://gerrit.wikimedia.org/r/499043 (https://phabricator.wikimedia.org/T218572) (owner: 10Matthias Geisler) [07:56:22] (03PS1) 10Urbanecm: Add script resolved [labs/tools/urbanecmbot] - 10https://gerrit.wikimedia.org/r/500167 [07:56:42] (03CR) 10Urbanecm: [C: 03+2] Add script resolved [labs/tools/urbanecmbot] - 10https://gerrit.wikimedia.org/r/500167 (owner: 10Urbanecm) [07:56:59] (03Merged) 10jenkins-bot: Add script resolved [labs/tools/urbanecmbot] - 10https://gerrit.wikimedia.org/r/500167 (owner: 10Urbanecm) [07:59:51] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [Bug][Alpha] Unable to save edits on the app - https://phabricator.wikimedia.org/T219698 (10Kaartic) [08:00:50] (03PS6) 10Smalyshev: Remove Elastic/Cirrus code - moved to WikibaseLexemeCirrusSearch [extensions/WikibaseLexeme] - 10https://gerrit.wikimedia.org/r/499878 (https://phabricator.wikimedia.org/T216206) [08:01:29] (03PS10) 10Smalyshev: Move Cirrus configs to the extension [extensions/WikibaseLexemeCirrusSearch] - 10https://gerrit.wikimedia.org/r/499401 (https://phabricator.wikimedia.org/T216206) [08:11:35] (03PS1) 10Urbanecm: Typo [labs/tools/urbanecmbot] - 10https://gerrit.wikimedia.org/r/500168 [08:12:51] (03CR) 10Urbanecm: [C: 03+2] Typo [labs/tools/urbanecmbot] - 10https://gerrit.wikimedia.org/r/500168 (owner: 10Urbanecm) [08:15:58] 10AbuseFilter, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable wgAbuseFilterNotificationsPrivate on commons.wikimedia.org - https://phabricator.wikimedia.org/T218527 (10Daimona) @MusikAnimal Actually it wasn't. My patches were last, and took up more time than they should because the other 2 (for T19103... [08:17:39] (03CR) 10Isarra: "I AM A MORON HOW DO I REVERT" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/499671 (owner: 10Jack Phoenix) [08:18:19] (03CR) 10Isarra: "SOMEONE WHO ISN'T A MORON NEEDS TO TEST THIS, BUT I'M PRETTY SURE PATCHSET 3 WAS FINE. I BROKE IT." [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/499671 (owner: 10Jack Phoenix) [08:23:31] 10Pywikibot, 10Pywikibot-pagegenerators.py, 10Pywikibot-replace.py, 10good first bug: Move -except from add_text.py and -excepttext from replace.py to global page generator filters - https://phabricator.wikimedia.org/T219281 (10Mahveotm) I'm willing to work on this. @Xqt , got any comments? [08:24:57] (03PS6) 10Jack Phoenix: Check for stub users, i.e. user table entries where user_password is empty; don't try authenticating against the remote wiki for such users [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/499671 [08:30:25] (03CR) 10Gergő Tisza: [C: 03+1] Cleanup: Remove obsolete WikimediaEditorTasks beta cluster prefs [mediawiki-config] - 10https://gerrit.wikimedia.org/r/500049 (owner: 10Mholloway) [08:32:47] (03CR) 10Gergő Tisza: [C: 04-1] Don't penalize users for self-reverts (031 comment) [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/499218 (owner: 10Mholloway) [08:46:31] (03PS6) 10Pwirth: Extend MWTimestamp instead of static functions to get "age string" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/487854 [08:50:29] 10Core Platform Team, 10MediaWiki-Authentication-and-authorization: Undeprecate User::setInternalPassword() - https://phabricator.wikimedia.org/T219689 (10Tgr) `setPasswordInternal` is private so probably not much help. (`setInternalPassword` was also internal, as the name suggests, MediaWiki just hasn't been... [08:53:58] (03CR) 10Gergő Tisza: [C: 04-1] "You should redirect stderr as well, everything that gets output goes to cronmail, which is not a useful place to go to." [puppet] - 10https://gerrit.wikimedia.org/r/500104 (https://phabricator.wikimedia.org/T218136) (owner: 10Mholloway) [08:54:25] (03PS20) 10Daimona Eaytoy: [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [08:56:29] (03CR) 10Daimona Eaytoy: [WIP] Add a maintenance script to clean afl_var_dump (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [08:59:54] 10MediaWiki-Change-tagging, 10MediaWiki-Logging, 10MediaWiki-extensions-OAuth: Patrol log entries generated via OAuth are not tagged with OAuth consumer - https://phabricator.wikimedia.org/T219655 (10Tgr) Adding new arguments to a hook should be safe, as long as it doesn't alter the handling of the existing... [09:05:22] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [09:07:24] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [09:10:44] (03CR) 10Daimona Eaytoy: [C: 04-1] [WIP] Add a maintenance script to clean afl_var_dump (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [09:11:43] 10Code-Health-Metrics, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Generate baseline analysis of all extensions - https://phabricator.wikimedia.org/T219156 (10zeljkofilipin) Extensions and their folders: P8320 [09:13:05] 10CirrusSearch, 10Discovery-Search, 10ProofreadPage, 10Wikisource: proofread-page content model content is not indexed by CirrusSearch - https://phabricator.wikimedia.org/T219229 (10Alex_brollo) I'm daily contributing to [[ https://it.wikisource.org/wiki/Indice:Tiraboschi_-_Storia_della_letteratura_italia... [09:15:33] 10Addwiki: [mediawiki-api] Add method to PageListGetter to get list of outgoing links from a page - https://phabricator.wikimedia.org/T186581 (10jeropbrenda) a:03jeropbrenda [09:15:46] 10VisualEditor: [Regression wmf.23] Searching image is broken on both Beta and test.wiki - https://phabricator.wikimedia.org/T219675 (10Schnark) Very likely caused by {rEVED21e9db7d13393bba46a1a26be31423062fc3f6e4}. [09:17:18] 10MediaWiki-API, 10Documentation, 10good first bug: API: Purpose of "batchcomplete" property and implementation - https://phabricator.wikimedia.org/T84977 (10jeropbrenda) a:03jeropbrenda [09:19:56] (03CR) 10Daimona Eaytoy: [C: 04-1] Move per-filter matches profiling to per-filter data (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489445 (https://phabricator.wikimedia.org/T53294) (owner: 10Daimona Eaytoy) [09:32:45] (03CR) 10Zfilipin: Add node selenium tests for revision highlight feature (031 comment) [extensions/RevisionSlider] - 10https://gerrit.wikimedia.org/r/499855 (owner: 10WMDE-Fisch) [09:33:47] 10Wikidata: Convert property Guggenheim fellows ID (P6594) from string to identifier - https://phabricator.wikimedia.org/T219699 (10Multichill) [09:39:51] 10WMSE-Riksarkivet-TORA: ISNI i SKBL <-> Wikidata - https://phabricator.wikimedia.org/T219700 (10Salgo60) [09:41:19] 10WMSE-Riksarkivet-TORA: SKBL <-> KARP Svenskt kvinnobiografiskt lexikon - https://phabricator.wikimedia.org/T218782 (10Salgo60) [09:42:21] (03PS1) 10Aaron Schulz: jobqueue: change MWException throw statements to using JobQueueError [core] - 10https://gerrit.wikimedia.org/r/500169 [09:42:23] (03PS1) 10Aaron Schulz: jobqueue: dependency inject more objects into JobQueue [core] - 10https://gerrit.wikimedia.org/r/500170 [09:42:25] (03PS1) 10Aaron Schulz: [WIP] jobqueue: add GenericParameterJob and RunnableJob interface [core] - 10https://gerrit.wikimedia.org/r/500171 [09:42:45] (03CR) 10Zfilipin: "🎉" [integration/config] - 10https://gerrit.wikimedia.org/r/498887 (https://phabricator.wikimedia.org/T219156) (owner: 10Kosta Harlan) [09:46:30] (03CR) 10Aaron Schulz: "The redis backend doesn't use this. The methods are no-oped. It doesn't need to (unlike very early versions of the redis backend)." [core] - 10https://gerrit.wikimedia.org/r/500161 (owner: 10Aaron Schulz) [09:49:54] (03CR) 10Aaron Schulz: [C: 03+2] resourceloader: Remove deprecated MessageBlobStore::getBlob [core] - 10https://gerrit.wikimedia.org/r/500156 (owner: 10Krinkle) [09:52:57] (03PS6) 10Daimona Eaytoy: Reduce the amount of returns [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/474702 [09:53:52] (03PS5) 10Daimona Eaytoy: Slightly improve degroup action, remove Phan suppressions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486803 [09:53:54] (03CR) 10jerkins-bot: [V: 04-1] [WIP] jobqueue: add GenericParameterJob and RunnableJob interface [core] - 10https://gerrit.wikimedia.org/r/500171 (owner: 10Aaron Schulz) [09:54:56] (03PS11) 10Daimona Eaytoy: Restore (temporarily?) unit tests for CachingParser and fix it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454557 (https://phabricator.wikimedia.org/T201193) [09:55:01] (03CR) 10jerkins-bot: [V: 04-1] [WIP] jobqueue: add GenericParameterJob and RunnableJob interface [core] - 10https://gerrit.wikimedia.org/r/500171 (owner: 10Aaron Schulz) [09:56:56] (03PS19) 10Daimona Eaytoy: Overhaul Blockautopromote action [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445986 (https://phabricator.wikimedia.org/T49412) [09:58:09] (03PS30) 10Daimona Eaytoy: Improve var dumping in /details, /examine and /tools [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/421966 (https://phabricator.wikimedia.org/T190653) [09:58:12] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10matthiasmullie) QA test failure probably because of T219540. Will assign back to self and look into Monday. [09:59:11] (03PS5) 10Daimona Eaytoy: Fix error display on ViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/485173 [10:01:07] (03CR) 10jerkins-bot: [V: 04-1] Overhaul Blockautopromote action [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445986 (https://phabricator.wikimedia.org/T49412) (owner: 10Daimona Eaytoy) [10:03:38] (03PS20) 10Daimona Eaytoy: Overhaul Blockautopromote action [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445986 (https://phabricator.wikimedia.org/T49412) [10:05:06] (03Merged) 10jenkins-bot: resourceloader: Remove deprecated MessageBlobStore::getBlob [core] - 10https://gerrit.wikimedia.org/r/500156 (owner: 10Krinkle) [10:09:11] (03CR) 10jerkins-bot: [V: 04-1] Restore (temporarily?) unit tests for CachingParser and fix it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454557 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [10:10:03] (03CR) 10jenkins-bot: resourceloader: Remove deprecated MessageBlobStore::getBlob [core] - 10https://gerrit.wikimedia.org/r/500156 (owner: 10Krinkle) [10:15:15] (03PS12) 10Daimona Eaytoy: Restore (temporarily?) unit tests for CachingParser and fix it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454557 (https://phabricator.wikimedia.org/T201193) [10:16:41] 10UniversalLanguageSelector, 10Russian-Sites: Adding fonts for Church Slavonic language in ULS - https://phabricator.wikimedia.org/T156843 (10Vladis13) T219065 [10:17:37] 10UniversalLanguageSelector, 10Russian-Sites: Adding fonts to Wikisource - https://phabricator.wikimedia.org/T219065 (10Vladis13) [10:18:13] (03CR) 10jerkins-bot: [V: 04-1] [WIP] jobqueue: add GenericParameterJob and RunnableJob interface [core] - 10https://gerrit.wikimedia.org/r/500171 (owner: 10Aaron Schulz) [10:40:28] 10UniversalLanguageSelector, 10Russian-Sites: Adding fonts to Wikisource - https://phabricator.wikimedia.org/T219065 (10Vladis13) [10:42:28] 10Huggle, 10Documentation, 10Need-volunteer, 10good first bug: Update the screenshots for the "Huggle" software in the user manual on mediawiki.org - https://phabricator.wikimedia.org/T181946 (10Didicodes) a:03Didicodes [10:45:44] 10Operations, 10Traffic, 10VisualEditor, 10Wikimedia-Apache-configuration, 10User-Ryasmeen: Visual Editor gets stuck opening article (net::ERR_SPDY_PROTOCOL_ERROR 200/Loading failed for the