[00:00:02] (03Merged) 10jenkins-bot: Add basic tests for ULS' ResourceLoader modules [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/479553 (owner: 10Thiemo Kreuz (WMDE)) [00:02:17] (03CR) 10jenkins-bot: Add basic tests for ULS' ResourceLoader modules [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/479553 (owner: 10Thiemo Kreuz (WMDE)) [00:03:15] 10Community-Tech, 10Event Metrics: Add 'Pages Improved' data to downloadable csv - https://phabricator.wikimedia.org/T212546 (10jmatazzoni) p:05Triage→03Normal [00:05:59] (03CR) 10Krinkle: [C: 03+1] Use check keys for message group cache key (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/479157 (owner: 10Aaron Schulz) [00:06:22] (03PS4) 10Krinkle: Do not call FRInclusionCache::setRevIncludes when the value is not used [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/470625 (owner: 10Aaron Schulz) [00:06:31] 10Community-Tech, 10Tools: Investigation: Why has Google API Proxy usage doubled since December 8th - https://phabricator.wikimedia.org/T212541 (10kaldari) [00:09:12] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-General-or-Unknown: User rights and actions on titles are conflated - https://phabricator.wikimedia.org/T212345 (10Tgr) Are they? They seem to be used for user rights pretty consistently. Calling them actions in the documentation is a bit confusing, alt... [00:09:21] (03PS3) 10Aaron Schulz: Pass READ_LATEST in $flags to Title::loadRestrictions [core] - 10https://gerrit.wikimedia.org/r/480574 (https://phabricator.wikimedia.org/T210983) (owner: 10Ejegg) [00:09:45] (03PS1) 10Krinkle: Add "-is:ignored" to "Other patches" to match Gerrit default [performance] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/481221 [00:09:54] (03CR) 10Krinkle: [V: 03+2 C: 03+2] Add "-is:ignored" to "Other patches" to match Gerrit default [performance] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/481221 (owner: 10Krinkle) [00:10:49] (03PS3) 10Krinkle: XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions() [core] - 10https://gerrit.wikimedia.org/r/480098 (owner: 10D3r1ck01) [00:11:08] (03CR) 10Krinkle: [C: 03+2] "Indeed. Took the liberty to amend as it seems uncontroversial." [core] - 10https://gerrit.wikimedia.org/r/480098 (owner: 10D3r1ck01) [00:11:37] (03PS1) 10Sharvaniharan: Converting EditTask related classes to Kotlin [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/481222 [00:13:28] (03PS1) 10BryanDavis: Add wikitech to whitelist [analytics/refinery] - 10https://gerrit.wikimedia.org/r/481223 (https://phabricator.wikimedia.org/T153821) [00:15:38] (03CR) 10Brian Wolff: "Seems kind of weird that we are removing the path in the quick check but not the query parameters?" [core] - 10https://gerrit.wikimedia.org/r/481206 (https://phabricator.wikimedia.org/T207900) (owner: 10Krinkle) [00:16:06] 10Operations: puppet compiler set to eqiad as primary dc while prod is codfw - https://phabricator.wikimedia.org/T206166 (10Dzahn) 05Open→03Resolved Back then i wanted to talk more about it but now i am fine with that. As long as one is aware of it. Next time we switch to codfw i might get back to it to adju... [00:16:16] (03CR) 10Krinkle: tests: Add message parameter to MediaWikiTestCase::assertArrayEquals() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478995 (https://phabricator.wikimedia.org/T92992) (owner: 10D3r1ck01) [00:19:15] (03CR) 10Aaron Schulz: [C: 03+1] Pass READ_LATEST in $flags to Title::loadRestrictions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/480574 (https://phabricator.wikimedia.org/T210983) (owner: 10Ejegg) [00:19:20] (03CR) 10Krinkle: "@Brian Can you elaborate and/or confirm that this is still applicable to the current patch set? It does first a strict comparison (like be" [core] - 10https://gerrit.wikimedia.org/r/481206 (https://phabricator.wikimedia.org/T207900) (owner: 10Krinkle) [00:19:34] (03PS1) 10BryanDavis: Add wikitech to pageview definition [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/481224 (https://phabricator.wikimedia.org/T153821) [00:20:47] (03CR) 10MaxSem: [V: 03+2] XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions() [core] - 10https://gerrit.wikimedia.org/r/480098 (owner: 10D3r1ck01) [00:20:51] 10Community-Tech, 10Event Metrics: Add 'Files Uploaded' data to downloadable csv - https://phabricator.wikimedia.org/T212547 (10jmatazzoni) p:05Triage→03Normal [00:25:20] (03Merged) 10jenkins-bot: XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions() [core] - 10https://gerrit.wikimedia.org/r/480098 (owner: 10D3r1ck01) [00:25:29] (03CR) 10Krinkle: [C: 03+2] Do not call FRInclusionCache::setRevIncludes when the value is not used [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/470625 (owner: 10Aaron Schulz) [00:25:42] 10Performance-Team: Decom "xhprof" viewer - https://phabricator.wikimedia.org/T196406 (10Dzahn) The node using the `xhgui::app` role which is using this is tungsten. tungsten was installed back in 2015 in T117888 as a test system for InfluxDB. [00:26:27] (03CR) 10Brian Wolff: "Sorry, i must of misread that or was looking at wrong patchset or something." [core] - 10https://gerrit.wikimedia.org/r/481206 (https://phabricator.wikimedia.org/T207900) (owner: 10Krinkle) [00:27:46] (03CR) 10jenkins-bot: XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions() [core] - 10https://gerrit.wikimedia.org/r/480098 (owner: 10D3r1ck01) [00:28:57] (03CR) 10Aaron Schulz: [C: 03+2] navtiming: Log deprecation message when seeing legacy userAgent fields [performance/navtiming] - 10https://gerrit.wikimedia.org/r/481217 (https://phabricator.wikimedia.org/T212537) (owner: 10Krinkle) [00:29:46] (03Merged) 10jenkins-bot: navtiming: Log deprecation message when seeing legacy userAgent fields [performance/navtiming] - 10https://gerrit.wikimedia.org/r/481217 (https://phabricator.wikimedia.org/T212537) (owner: 10Krinkle) [00:29:54] (03CR) 10Aaron Schulz: WikiPage::doUpdateRestrictions checks DB_MASTER (031 comment) [core] - 10https://gerrit.wikimedia.org/r/480990 (https://phabricator.wikimedia.org/T210983) (owner: 10Ejegg) [00:30:30] 10Community-Tech, 10Event Metrics: Add 'Files Uploaded' data to downloadable csv - https://phabricator.wikimedia.org/T212547 (10jmatazzoni) [00:30:36] 10InteractionTimeline: Remove jQuery Dependency - https://phabricator.wikimedia.org/T212548 (10dbarratt) [00:34:52] 10Performance-Team: Decom "xhprof" viewer - https://phabricator.wikimedia.org/T196406 (10Krinkle) Yeah, but it's gone through decom and since been repurposed for XHGui. And since then, again being decom'ed now as part of T158837. We're mostly done with moving the webperf stuff from old hardware (hafnium and tung... [00:34:58] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Ubuntu Trusty Deprecation): cloudvps: deployment-prep project trusty deprecation - https://phabricator.wikimedia.org/T204500 (10Krenair) 05Open→03Resolved a:03Krenair [00:35:07] (03PS1) 10BryanDavis: Add new Cloud VPS ip addresses to network origin UDF [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/481225 [00:35:48] 10Beta-Cluster-Infrastructure, 10Kubernetes: Set up new Zotero on beta cluster - https://phabricator.wikimedia.org/T212549 (10Krenair) [00:41:52] 10Anti-Harassment, 10InteractionTimeline: Remove jQuery Dependency - https://phabricator.wikimedia.org/T212548 (10dbarratt) https://github.com/wikimedia/InteractionTimeline/pull/99 [00:42:01] (03PS3) 10Sbailey: Test token transformers for transformTests.js env mocking [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) [00:42:40] 10OOUI, 10UI-Standardization, 10Tracking, 10UI-Standardization-Kanban: Sub-pixel rendering layout issues with `em` or `%` relative units – General discussion and tracking - https://phabricator.wikimedia.org/T130691 (10Volker_E) Just came across {F27699846 width=50%} in GDocs, which made me smirk. [00:43:56] (03PS1) 10Dbarratt: Update package description [react.i18n] - 10https://gerrit.wikimedia.org/r/481226 [00:44:18] (03CR) 10Dbarratt: [C: 03+2] Update package description [react.i18n] - 10https://gerrit.wikimedia.org/r/481226 (owner: 10Dbarratt) [00:45:43] (03CR) 10Aaron Schulz: Use check keys for message group cache key (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/479157 (owner: 10Aaron Schulz) [00:49:11] (03CR) 10jerkins-bot: [V: 04-1] Test token transformers for transformTests.js env mocking [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [00:49:27] (03CR) 10Dzahn: [C: 03+1] "no difference on contint* https://puppet-compiler.wmflabs.org/compiler1001/81/" [puppet] - 10https://gerrit.wikimedia.org/r/481201 (https://phabricator.wikimedia.org/T209361) (owner: 10Hashar) [00:52:22] (03PS2) 10Alex Monk: toolforge: add the new cloud region to all_networks [puppet] - 10https://gerrit.wikimedia.org/r/481215 (https://phabricator.wikimedia.org/T212327) (owner: 10Bstorm) [00:53:13] (03PS3) 10Alex Monk: network: Add the new cloud region to all_networks [puppet] - 10https://gerrit.wikimedia.org/r/481215 (https://phabricator.wikimedia.org/T212327) (owner: 10Bstorm) [00:54:14] 10Cloud-VPS, 10Mail, 10MediaWiki-Email, 10Beta-Cluster-reproducible, 10Patch-For-Review: Beta Cluster mailer not sending emails - https://phabricator.wikimedia.org/T212327 (10Krenair) [00:54:24] 10Cloud-VPS, 10Mail, 10Beta-Cluster-reproducible, 10Patch-For-Review: Beta Cluster mailer not sending emails - https://phabricator.wikimedia.org/T212327 (10Krenair) [00:56:17] 10Gerrit, 10Scoring-platform-team: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed) - https://phabricator.wikimedia.org/T212544 (10Zoranzoki21) Maybe this: https://github.com/git-lfs/git-lfs/issues/911 [01:06:54] (03CR) 10Krinkle: InterwikiResolver: set MultiHttpClient timeouts (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/481145 (https://phabricator.wikimedia.org/T212455) (owner: 10DCausse) [01:10:18] 10Gerrit, 10Scoring-platform-team: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed) - https://phabricator.wikimedia.org/T212544 (10awight) Note that there was a different error caused by a history rewrite in GitHub. I force-pushed a new master to editquality which is built on the old... [01:13:17] (03CR) 10Smalyshev: [C: 03+1] InterwikiResolver: set MultiHttpClient timeouts (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/481145 (https://phabricator.wikimedia.org/T212455) (owner: 10DCausse) [01:16:55] (03PS4) 10Awight: [WIP] Import ORES scores into an archival table [analytics/refinery] - 10https://gerrit.wikimedia.org/r/481025 (https://phabricator.wikimedia.org/T209732) [01:18:33] 10Trust-and-Safety, 10Wikimedia-Site-requests: Restore access to account F.Ponizil@SUL - https://phabricator.wikimedia.org/T211003 (10Urbanecm) @jrbs: I'm sorry if this looks inpatient, but is there any progress? [01:18:44] 10Operations, 10TechCom-RFC, 10Wikidata, 10Wikidata-Termbox-Hike, and 5 others: New Service Request: Wikidata Termbox SSR - https://phabricator.wikimedia.org/T212189 (10Krinkle) >>! In T212189#4840406, @daniel wrote: > So, overall, it seems like the solution proposed by the Wikidata team is the only one vi... [01:20:51] 10MediaWiki-Internationalization, 10MediaWiki-Language-converter, 10Chinese-Sites: Change ZhConversion conversion tables to JSON - https://phabricator.wikimedia.org/T129499 (10Krinkle) @RazeSoldier Yes, I believe that would be in line with the larger direction of how we store data on disk for MediaWiki. [01:21:00] 10MediaWiki-Internationalization, 10MediaWiki-Language-converter, 10Chinese-Sites: Move ZhConversion conversion tables from static class to array file - https://phabricator.wikimedia.org/T129499 (10Krinkle) [01:25:21] (03CR) 10Sbailey: "recheck" [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [01:25:41] (03CR) 10jerkins-bot: [V: 04-1] Do not call FRInclusionCache::setRevIncludes when the value is not used [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/470625 (owner: 10Aaron Schulz) [01:28:13] (03CR) 10jerkins-bot: [V: 04-1] Test token transformers for transformTests.js env mocking [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [01:29:46] 10Wikidata, 10Wikidata-Query-Service: Implement support for ChronologyProtection in RDF export - https://phabricator.wikimedia.org/T212550 (10Smalyshev) [01:30:05] 10Wikidata, 10Wikidata-Query-Service: Implement support for ChronologyProtection in RDF export - https://phabricator.wikimedia.org/T212550 (10Smalyshev) p:05Triage→03Normal [01:30:32] 10Growth-Team, 10MediaWiki-API, 10MediaWiki-Page-editing, 10MediaWiki-Recent-changes, and 4 others: Ensure consistency of secondary data for external consumers - https://phabricator.wikimedia.org/T149239 (10Smalyshev) [01:30:35] 10Wikidata, 10Wikidata-Query-Service: Implement support for ChronologyProtection in RDF export - https://phabricator.wikimedia.org/T212550 (10Smalyshev) [01:31:14] 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, 10WMF-JobQueue, 10Wikimedia-production-error: EventBus or CirrusSearch: DomainException from line 353 of /srv/mediawiki/php-1.33.0-wmf.9/vendor/firebase/php-jwt/src/JWT.php: Unknown JSON error: 5 - https://phabricator.wikimedia.org/T212335 (10Krink... [01:33:38] 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, 10WMF-JobQueue, 10Wikimedia-production-error: EventBus or CirrusSearch: DomainException from line 353 of /srv/mediawiki/php-1.33.0-wmf.9/vendor/firebase/php-jwt/src/JWT.php: Unknown JSON error: 5 - https://phabricator.wikimedia.org/T212335 (10Krink... [01:35:57] (03CR) 10Sbailey: "recheck" [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [01:36:45] (03CR) 10Aaron Schulz: "recheck" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/470625 (owner: 10Aaron Schulz) [01:38:59] 10Wikidata, 10Wikidata-Query-Service, 10Discovery-Search (Current work): Increase deployment window of wdqs or parallelize scap deployment - https://phabricator.wikimedia.org/T207676 (10Smalyshev) I think we can parallelize, but we should do it in a smart way, so no more than one server in each cluster out o... [01:41:21] (03CR) 10Sbailey: Test token transformers for transformTests.js env mocking (031 comment) [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [01:41:42] 10Math, 10Browser-Support-Opera, 10Core Platform Team Backlog (Watching / External), 10Patch-For-Review, 10Services (watching): Check SVG -> PNG fall-back image loading in Opera 9 - https://phabricator.wikimedia.org/T137765 (10Krinkle) 05Open→03Declined @crh23 @Pkra If you or someone you know is affe... [01:42:36] (03PS7) 10Arlolra: [WIP] Add media info in a post-processing pass [services/parsoid] - 10https://gerrit.wikimedia.org/r/463125 (https://phabricator.wikimedia.org/T153080) [01:43:32] (03CR) 10Aaron Schulz: [C: 03+2] "retry" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/470625 (owner: 10Aaron Schulz) [01:44:34] 10Growth-Team: [minor] Help panel: the checkmark for "Your question has been posted" displayed on a new line - https://phabricator.wikimedia.org/T212551 (10Etonkovidova) [01:46:05] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add media info in a post-processing pass [services/parsoid] - 10https://gerrit.wikimedia.org/r/463125 (https://phabricator.wikimedia.org/T153080) (owner: 10Arlolra) [01:47:04] 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, 10WMF-JobQueue, 10Wikimedia-production-error: EventBus or CirrusSearch: DomainException from line 353 of /srv/mediawiki/php-1.33.0-wmf.9/vendor/firebase/php-jwt/src/JWT.php: Unknown JSON error: 5 - https://phabricator.wikimedia.org/T212335 (10Smaly... [01:49:22] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Help panel: allow users to "Ask a question" to help desk - https://phabricator.wikimedia.org/T209318 (10Etonkovidova) @MMiller_WMF - all specs (UI and funcitonality) seem to be in place. (1) There is one minor,... [01:51:00] (03CR) 10jerkins-bot: [V: 04-1] Test token transformers for transformTests.js env mocking [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [01:52:48] (03Merged) 10jenkins-bot: Do not call FRInclusionCache::setRevIncludes when the value is not used [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/470625 (owner: 10Aaron Schulz) [02:02:39] 10Wikidata, 10Wikidata-Query-Service, 10Technical-Debt: Migrate WDQS tools from JewelCli to actively supported command-line parsing library - https://phabricator.wikimedia.org/T201354 (10Smalyshev) Alternatives: * [[ https://dzone.com/articles/java-command-line-interfaces-part-1-apache-commons | Apache CLI ]... [02:04:40] 10Wikidata, 10Wikidata-Query-Service: wikibase:mwapi query returns empty objects - https://phabricator.wikimedia.org/T212084 (10Smalyshev) Could you describe what you mean by "shows as empty"? Do you mean this request does not return anything or that it returns some response, but some parts are empty? Which ones? [02:07:10] 10Wikidata, 10Wikidata-Campsite, 10Wikidata-Query-Service, 10User-Smalyshev: Number of Senses is decreasing on ListeriaBot's report - https://phabricator.wikimedia.org/T210495 (10Smalyshev) Is it still the issue? [02:08:20] 10Wikidata, 10Wikidata-Query-Service, 10User-Smalyshev: Restore polling page-properties-change - https://phabricator.wikimedia.org/T208014 (10Smalyshev) p:05Triage→03Normal [02:23:14] 10MinervaNeue, 10Performance-Team (Radar), 10Readers-Web-Backlog (Design): "Related articles" appears too late and displaces footer links (FOUC; content jump) - https://phabricator.wikimedia.org/T208180 (10Krinkle) I assume the existing backend query can be performed as-is in MediaWiki PHP. In terms of back... [02:23:50] (03Abandoned) 10Krinkle: Emit debug logs when filtering without title [extensions/AbuseFilter] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479531 (https://phabricator.wikimedia.org/T144265) (owner: 10Krinkle) [02:25:11] 10MediaWiki-Vagrant: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10brion) [02:27:31] (03CR) 10Krinkle: InterwikiResolver: set MultiHttpClient timeouts (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/481145 (https://phabricator.wikimedia.org/T212455) (owner: 10DCausse) [02:28:54] (03CR) 10Smalyshev: [C: 03+1] InterwikiResolver: set MultiHttpClient timeouts (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/481145 (https://phabricator.wikimedia.org/T212455) (owner: 10DCausse) [02:30:49] (03PS2) 10VolkerE: DropdownWidget: Alternative ARIA roles and attributes approach [oojs/ui] - 10https://gerrit.wikimedia.org/r/481052 (https://phabricator.wikimedia.org/T212186) [02:34:53] (03CR) 10VolkerE: "This is ready to be reviewed. I don't want to have the revert and this merged before we're not 99% sure this is an approach that satisfies" [oojs/ui] - 10https://gerrit.wikimedia.org/r/481052 (https://phabricator.wikimedia.org/T212186) (owner: 10VolkerE) [02:45:28] 04(no projects): Coordinate Wikimedia's participation in Google Summer of Code 2019 / Outreachy Round 18 - https://phabricator.wikimedia.org/T212553 (10srishakatux) [02:45:46] 10Developer-Advocacy (Jan-Mar 2019): Coordinate Wikimedia's participation in Google Summer of Code 2019 / Outreachy Round 18 - https://phabricator.wikimedia.org/T212553 (10srishakatux) p:05Triage→03Normal [02:47:19] 10Developer-Advocacy (Jan-Mar 2019): Coordinate Wikimedia's participation in Google Summer of Code 2019 / Outreachy Round 18 - https://phabricator.wikimedia.org/T212553 (10srishakatux) Recruited @psinghal20 and @D3r1ck01 to help coordinate the next round of Google Summer of Code 2019 and Outreachy Round 18 with... [02:52:40] (03PS4) 10Dbarratt: Create the GraphQL extension. [extensions/GraphQL] - 10https://gerrit.wikimedia.org/r/474477 (https://phabricator.wikimedia.org/T209133) [02:52:57] 10Developer-Advocacy (Jan-Mar 2019): Coordinate Wikimedia's participation in Google Summer of Code 2019 / Outreachy Round 18 - https://phabricator.wikimedia.org/T212553 (10srishakatux) Made some documentation improvements to [[ https://www.mediawiki.org/wiki/Outreach_programs | Outreach programs ]] guides: Cre... [02:54:16] 10AbuseFilter, 10SpamBlacklist: Make SpamBlacklist clearly act prior to AbuseFilter on WMF operational wikis - https://phabricator.wikimedia.org/T211680 (10Billinghurst) @vermont fyi [02:54:47] 10Developer-Advocacy (Jan-Mar 2019): Coordinate Wikimedia's participation in Google Summer of Code 2019 / Outreachy Round 18 - https://phabricator.wikimedia.org/T212553 (10srishakatux) a:03srishakatux [02:55:31] (03PS5) 10Dbarratt: Create the GraphQL extension. [extensions/GraphQL] - 10https://gerrit.wikimedia.org/r/474477 (https://phabricator.wikimedia.org/T209133) [02:59:45] 10AbuseFilter, 10SpamBlacklist: Make SpamBlacklist clearly act prior to AbuseFilter on WMF operational wikis - https://phabricator.wikimedia.org/T211680 (10Billinghurst) This month is truly a good indicator of how we could make abuse filters useful instead of clagged with superfluous, duplicated hits. FWIW th... [03:32:02] (03CR) 10Nuria: [C: 03+2] Add wikitech to pageview definition [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/481224 (https://phabricator.wikimedia.org/T153821) (owner: 10BryanDavis) [03:35:31] (03CR) 10Aaron Schulz: "DerivedPageUpdater::doUpdates calls doSecondaryDataUpdates with POSTSEND, MediaWiki::restInPeace() calls DeferredUpdates::doUpdates with '" [core] - 10https://gerrit.wikimedia.org/r/470099 (owner: 10Aaron Schulz) [03:37:06] (03Merged) 10jenkins-bot: Add wikitech to pageview definition [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/481224 (https://phabricator.wikimedia.org/T153821) (owner: 10BryanDavis) [03:53:02] 10MediaWiki-User-management, 10I18n: Do not split string [[MediaWiki:Listgrouprights-helppage]] into page name and separate hardcoded namespace - https://phabricator.wikimedia.org/T212229 (10Praveenp) No it is not. Please see the screenshot taken while [[ https://ml.wikipedia.org/w/index.php?title=%E0%B4%AE%E... [03:59:34] 10MediaWiki-User-management, 10I18n, 10Malayalam-Sites: Do not split string [[MediaWiki:Listgrouprights-helppage]] into page name and separate hardcoded namespace - https://phabricator.wikimedia.org/T212229 (10Praveenp) [04:05:34] (03PS2) 10Aaron Schulz: Use check keys for message group cache key [extensions/Translate] - 10https://gerrit.wikimedia.org/r/479157 [04:05:49] (03PS3) 10Aaron Schulz: Use check keys for message group cache key [extensions/Translate] - 10https://gerrit.wikimedia.org/r/479157 [04:12:45] 10MediaWiki-Internationalization, 10I18n, 10Malayalam-Sites: Do not split string [[MediaWiki:Listgrouprights-helppage]] into page name and separate hardcoded namespace - https://phabricator.wikimedia.org/T212229 (10JJMC89) [04:20:08] (03PS6) 10Dbarratt: Create the GraphQL extension. [extensions/GraphQL] - 10https://gerrit.wikimedia.org/r/474477 (https://phabricator.wikimedia.org/T209133) [04:20:32] (03CR) 10Huji: [C: 04-1] "Postgres version of the column is missing from cu_log.pg.sql" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [04:20:43] (03CR) 10jerkins-bot: [V: 04-1] Create the GraphQL extension. [extensions/GraphQL] - 10https://gerrit.wikimedia.org/r/474477 (https://phabricator.wikimedia.org/T209133) (owner: 10Dbarratt) [04:30:43] (03CR) 10Sbailey: "recheck" [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [04:37:51] (03CR) 10jerkins-bot: [V: 04-1] Test token transformers for transformTests.js env mocking [services/parsoid] - 10https://gerrit.wikimedia.org/r/481219 (https://phabricator.wikimedia.org/T211365) (owner: 10Sbailey) [05:01:23] 10VisualEditor: Visual editor source editing preview does not link to changed reference footnotes - https://phabricator.wikimedia.org/T212554 (10AxelBoldt) [05:08:05] 10Wikidocumentaries: Definition of done: Kone - https://phabricator.wikimedia.org/T212400 (10Susannaanas) [05:14:04] 10MediaWiki-Internationalization, 10MediaWiki-Language-converter, 10Chinese-Sites: Move ZhConversion conversion tables from static class to array file - https://phabricator.wikimedia.org/T129499 (10RazeSoldier) It seems that this task is a bit complicated to implement for me, because we need to rebuild the m... [05:22:10] (03CR) 10Krinkle: "@Aaron: Good point regarding canonical for edit filters, I didn't realise that filters operate on parsed content, I thought was raw input " [core] - 10https://gerrit.wikimedia.org/r/470099 (owner: 10Aaron Schulz) [05:24:15] (03PS1) 10Mholloway: Hygiene: Update diffs [services/mobileapps] - 10https://gerrit.wikimedia.org/r/481227 [05:27:42] (03CR) 10Mholloway: [C: 03+2] "Self merging because it'll drive me crazy otherwise knowing this test is failing every hour all break long." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/481227 (owner: 10Mholloway) [05:29:22] (03Merged) 10jenkins-bot: Hygiene: Update diffs [services/mobileapps] - 10https://gerrit.wikimedia.org/r/481227 (owner: 10Mholloway) [05:36:22] (03PS1) 10Krinkle: init: Improve dnt code with idiomatic patterns [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481228 [05:38:31] (03PS2) 10Krinkle: init: Improve dnt code with idiomatic patterns [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481228 [05:38:50] (03PS3) 10Krinkle: init: Improve dnt code with idiomatic patterns [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481228 [05:44:47] (03PS1) 10Krinkle: build: Update eslint rules and remove redundant aliases [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481229 (https://phabricator.wikimedia.org/T208951) [05:48:10] (03PS1) 10Krinkle: utils: Simplify getEditCountBucket function [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481230 [05:48:51] (03CR) 10Krinkle: [C: 03+1] Put profiler hostnames in ProductionServices.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/477957 (owner: 10Tim Starling) [05:53:04] (03CR) 10Krinkle: Excimer and Tideways support (031 comment) [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478137 (owner: 10Tim Starling) [05:53:04] (03CR) 10Krinkle: [C: 03+1] Excimer and Tideways support [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478137 (owner: 10Tim Starling) [05:54:57] 10Timeless: Compile list of gadgets across various projects that broke in timeless, and why - https://phabricator.wikimedia.org/T211398 (10Evad37) Resolving T181362 fixed a whole lot of scripts/gadgets, which was due to mismatched ids, and the omission rather than hiding of empty portlets. Another one that come... [05:56:39] 10MediaWiki-Internationalization, 10MediaWiki-Language-converter, 10Chinese-Sites: Move ZhConversion conversion tables from static class to array file - https://phabricator.wikimedia.org/T129499 (10Chiefwei) >>! In T129499#2242289, @Liuxinyu970226 wrote: >>>! In T129499#2153486, @Nbdd0121 wrote: >>>>! In T12... [06:21:30] (03PS1) 10Krinkle: Use OO.inheritClass directly for improved readability [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481231 [06:21:32] (03PS1) 10Krinkle: Remove indirection of 'views' subnamespace [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481232 [06:21:34] (03PS1) 10Krinkle: utils: Document "XX" code and remove copy of CentralNotice logic [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481233 [06:24:25] (03CR) 10jerkins-bot: [V: 04-1] Remove indirection of 'views' subnamespace [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481232 (owner: 10Krinkle) [06:24:27] (03CR) 10jerkins-bot: [V: 04-1] utils: Document "XX" code and remove copy of CentralNotice logic [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481233 (owner: 10Krinkle) [06:32:08] (03PS2) 10Krinkle: Remove indirection of 'views' subnamespace [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481232 [06:32:10] (03PS2) 10Krinkle: utils: Document "XX" code and remove copy of CentralNotice logic [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481233 [06:32:12] (03PS1) 10Krinkle: Remove outdated use of jQuery in favour of native methods [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481234 [06:39:46] 10MediaWiki-Internationalization, 10MediaWiki-Language-converter, 10Chinese-Sites: Move ZhConversion conversion tables from static class to array file - https://phabricator.wikimedia.org/T129499 (10RazeSoldier) [06:56:56] (03CR) 10ArielGlenn: "Thanks for looking at this. I don't understand why nfs port values are being moved out to separate files and duplicated, when they are com" [puppet] - 10https://gerrit.wikimedia.org/r/479335 (owner: 10Dzahn) [06:57:34] 10MediaWiki-Email, 10TechCom, 10Patch-For-Review: Improve maintainability and scalability of Mail component - https://phabricator.wikimedia.org/T207621 (10Krinkle) [06:58:49] 10Core Platform Team, 10MediaWiki-Email, 10TechCom, 10Patch-For-Review: Improve maintainability and scalability of Mail component - https://phabricator.wikimedia.org/T207621 (10Krinkle) When we talk about design, we usually refer to graphical design of user interfaces. In the context of code, we usually ca... [07:01:21] (03CR) 10Krinkle: "I think we should limit the number of classes a bit. Specifically, I think we do not need a class to represent a fully-prepared e-mail to " [core] - 10https://gerrit.wikimedia.org/r/471313 (https://phabricator.wikimedia.org/T207621) (owner: 10星耀晨曦) [07:07:17] (03CR) 10Krinkle: Improve maintainability and scalability of Mail component (031 comment) [core] - 10https://gerrit.wikimedia.org/r/471313 (https://phabricator.wikimedia.org/T207621) (owner: 10星耀晨曦) [07:08:34] (03PS2) 10Krinkle: eval.php: write error messages to stderr [core] - 10https://gerrit.wikimedia.org/r/468626 (https://phabricator.wikimedia.org/T121597) (owner: 1020after4) [07:08:43] (03CR) 10Krinkle: [C: 03+2] "Oops :)" [core] - 10https://gerrit.wikimedia.org/r/468626 (https://phabricator.wikimedia.org/T121597) (owner: 1020after4) [07:11:20] (03CR) 10Krinkle: "Hi Raze, sorry for the delay. There were more problems in rdbms than this one, and Aaron and I together made a larger change that fixes th" [core] - 10https://gerrit.wikimedia.org/r/463640 (https://phabricator.wikimedia.org/T39159) (owner: 10星耀晨曦) [07:14:45] (03CR) 10Krinkle: [C: 04-1] tests: enable MariaDB/MySQL strict mode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/429386 (https://phabricator.wikimedia.org/T119371) (owner: 10Hashar) [07:16:00] (03PS4) 10Krinkle: Add method XmlSelect::addAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:16:44] (03PS5) 10Krinkle: Add method XmlSelect::addAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:17:14] (03PS6) 10Krinkle: Xml: Add XmlSelect::setAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:19:45] (03CR) 10jerkins-bot: [V: 04-1] Xml: Add XmlSelect::setAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:19:47] (03PS7) 10Krinkle: Xml: Add XmlSelect::setAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:22:15] (03CR) 10jerkins-bot: [V: 04-1] Xml: Add XmlSelect::setAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:22:49] (03PS8) 10Krinkle: Xml: Add XmlSelect::setAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:23:28] (03CR) 10Krinkle: [C: 03+1] "Rebased, and amended to address concerns. LGTM, but would like IAlex to confirm with a +1 (or -1) given it's their name on the change, bef" [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:25:36] (03CR) 10Krinkle: Sort user groups (031 comment) [core] - 10https://gerrit.wikimedia.org/r/350908 (https://phabricator.wikimedia.org/T164211) (owner: 10MaxSem) [07:27:34] (03Abandoned) 10星耀晨曦: Coding to handle write queries in sqlite implement [core] - 10https://gerrit.wikimedia.org/r/463640 (https://phabricator.wikimedia.org/T39159) (owner: 10星耀晨曦) [07:28:16] 10MediaWiki-Database, 10Performance-Team, 10SQLite, 10goodfirstbug: sqlite: DatabaseBase::delete and DatabaseBase::update return ResultWrapper object - https://phabricator.wikimedia.org/T39159 (10RazeSoldier) a:05RazeSoldier→03aaron [07:28:59] (03Merged) 10jenkins-bot: eval.php: write error messages to stderr [core] - 10https://gerrit.wikimedia.org/r/468626 (https://phabricator.wikimedia.org/T121597) (owner: 1020after4) [07:31:16] (03CR) 10jenkins-bot: eval.php: write error messages to stderr [core] - 10https://gerrit.wikimedia.org/r/468626 (https://phabricator.wikimedia.org/T121597) (owner: 1020after4) [07:34:35] 10Scoring-platform-team: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed) - https://phabricator.wikimedia.org/T212544 (10hashar) [07:35:30] 10Cloud-VPS (Project-requests): Request creation of VPS project - https://phabricator.wikimedia.org/T211523 (10maskaravivek) Excited to see VideoWiki exclusively use Commons content. :) [07:36:25] (03CR) 10jerkins-bot: [V: 04-1] Xml: Add XmlSelect::setAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [07:38:08] (03PS5) 10Krinkle: user: Ensure returned user groups are sorted [core] - 10https://gerrit.wikimedia.org/r/350908 (https://phabricator.wikimedia.org/T164211) (owner: 10MaxSem) [07:38:28] (03CR) 10Krinkle: [C: 03+1] "Rebased with suggestions applied, as well as the temporary workaround removed in favour of a cache bump." [core] - 10https://gerrit.wikimedia.org/r/350908 (https://phabricator.wikimedia.org/T164211) (owner: 10MaxSem) [07:38:57] (03PS6) 10Krinkle: user: Ensure returned user groups are sorted [core] - 10https://gerrit.wikimedia.org/r/350908 (https://phabricator.wikimedia.org/T164211) (owner: 10MaxSem) [07:39:28] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10Patch-For-Review: "Conflict of user rights changes! Please review and confirm your changes." in Special:Userrights - https://phabricator.wikimedia.org/T164211 (10Krinkle) [07:39:40] 10MediaWiki-User-management, 10Patch-For-Review: "Conflict of user rights changes! Please review and confirm your changes." in Special:Userrights - https://phabricator.wikimedia.org/T164211 (10Krinkle) [07:42:55] 10MediaWiki-User-management, 10Design: Special:UserRights should order list of groups alphabetically by label - https://phabricator.wikimedia.org/T172687 (10Krinkle) [07:46:24] 10MediaWiki-User-management, 10Design: Special:UserRights should order list of groups alphabetically by label - https://phabricator.wikimedia.org/T172687 (10Krinkle) For the record T164211, will make this slightly better by making the internal User logic consistently ordered. Right now the form has no sorting... [07:46:29] 10MediaWiki-User-management, 10Design: Special:UserRights should order list of groups alphabetically by label - https://phabricator.wikimedia.org/T172687 (10Krinkle) p:05Triage→03Low [07:59:51] 10Cloud-VPS (Project-requests): Request creation of VPS project - https://phabricator.wikimedia.org/T211523 (10Doc_James) Is anything further needed before this move can occur? [08:12:40] (03PS8) 10Fomafix: WebInstallerOutput: Add getLanguage() [core] - 10https://gerrit.wikimedia.org/r/469216 [08:26:23] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Assign "suppressredirect" to patroller on Chinese Wikivoyage - https://phabricator.wikimedia.org/T212272 (10RazeSoldier) [08:37:50] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Support for references added by name when the details are inside a template - https://phabricator.wikimedia.org/T209266 (10Doc_James) Hum. I have asked Ladsgroup about building a simple tool that will move the metadata from within the... [08:49:09] (03CR) 10Thiemo Kreuz (WMDE): "Thanks a lot for the extra code search! Very much appreciated!" [core] - 10https://gerrit.wikimedia.org/r/480995 (owner: 10Thiemo Kreuz (WMDE)) [08:55:29] (03CR) 10Thiemo Kreuz (WMDE): Avoid expensive array_shift where possible (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/480044 (owner: 10Thiemo Kreuz (WMDE)) [09:09:57] (03CR) 10Dvorapa: [C: 03+1] "I don't like this "feature" too. Makes no difference between stdout and stderr if error is thrown." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481121 (owner: 10Zhuyifei1999) [09:11:32] 10Packaging, 10Parsoid: Require nodejs 6.x in Parsoid Debian package - https://phabricator.wikimedia.org/T212555 (10Seb35) [09:14:35] 10Operations, 10ops-eqiad: frdb1001 RAID controller battery failure - https://phabricator.wikimedia.org/T212556 (10Jgreen) p:05Triage→03Unbreak! [09:41:01] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10ShakespeareFan00) [09:41:35] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10ShakespeareFan00) Updated original example to be clearer. [09:46:46] 10MediaWiki-extensions-Cargo: Special:Drilldown not showing the articles when going in a category - https://phabricator.wikimedia.org/T211819 (10DSwissK) 05Open→03Resolved Works perfectly. Thanks for the fast resolution. Enjoy your holidays. (?) [10:08:17] 10Product-Analytics, 10Reading-analysis: Request: Top articles of 2018 on all Wikipedias - https://phabricator.wikimedia.org/T211827 (10geraki) If you can add Greek, we'd be very happy :-) [10:23:08] 10Striker: Wikimedia VPS uses wrong email for Wikimedia developer account - https://phabricator.wikimedia.org/T212394 (10DannyS712) 05Open→03Resolved a:03DannyS712 Nevermind - I logged out and back in again [10:56:40] (03CR) 10Jforrester: [C: 03+2] "Oops." [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/481173 (owner: 10Umherirrender) [10:57:01] (03CR) 10Jforrester: [C: 03+2] build: Run stylelint for less [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/481172 (owner: 10Umherirrender) [11:00:27] (03Merged) 10jenkins-bot: build: Run stylelint also for less [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/481173 (owner: 10Umherirrender) [11:00:54] (03Merged) 10jenkins-bot: build: Run stylelint for less [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/481172 (owner: 10Umherirrender) [11:02:36] (03CR) 10jenkins-bot: build: Run stylelint for less [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/481172 (owner: 10Umherirrender) [11:04:38] (03CR) 10Jforrester: [C: 03+2] Reduce code duplication in JS/PHP comparison tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/481096 (owner: 10Bartosz Dziewoński) [11:07:53] 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Localisation of user categories for nap.wikipedia - https://phabricator.wikimedia.org/T123188 (10Sannita) >>! In T123188#4841560, @Urbanecm wrote: > Unfortunately, it will be processed after the end of the year due to all WMF holidays, there are... [11:10:50] 10Operations, 10TechCom-RFC, 10Wikidata, 10Wikidata-Termbox-Hike, and 5 others: New Service Request: Wikidata Termbox SSR - https://phabricator.wikimedia.org/T212189 (10daniel) @Krinkle said: > Rather, it starts out on the assumption that we're going to have UI code in production (based on Vue.js) written... [11:11:20] (03PS7) 10Jforrester: Fix the cache timestamp for forced updates. [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/481015 (https://phabricator.wikimedia.org/T210307) (owner: 10Reedy) [11:12:18] (03CR) 10Jforrester: [C: 03+2] Fix the cache timestamp for forced updates. [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/481015 (https://phabricator.wikimedia.org/T210307) (owner: 10Reedy) [11:14:28] 10WMDE-FUN-Team, 10WMDE-Fundraising-Campaign-2018, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2018: Banner #28 Landingpage - Test III - https://phabricator.wikimedia.org/T212203 (10gabriel-wmde) @tmletzko I've activated the test on the donation page, you can now preview the changes on the live page. [11:14:53] (03CR) 10Jforrester: [C: 03+2] Force flake8 to run under Python 2 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/480910 (owner: 10Legoktm) [11:14:56] (03Merged) 10jenkins-bot: Reduce code duplication in JS/PHP comparison tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/481096 (owner: 10Bartosz Dziewoński) [11:15:33] (03PS1) 10D3r1ck01: ffs: Fix PHPDoc return type for readRow() method [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481235 [11:17:40] (03CR) 10Jforrester: "Shouldn't this be in the user pack instead?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/480816 (https://phabricator.wikimedia.org/T212299) (owner: 10VolkerE) [11:25:41] (03CR) 10jenkins-bot: Reduce code duplication in JS/PHP comparison tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/481096 (owner: 10Bartosz Dziewoński) [11:27:39] (03Merged) 10jenkins-bot: Fix the cache timestamp for forced updates. [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/481015 (https://phabricator.wikimedia.org/T210307) (owner: 10Reedy) [11:27:41] (03Merged) 10jenkins-bot: Force flake8 to run under Python 2 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/480910 (owner: 10Legoktm) [11:27:43] (03Merged) 10jenkins-bot: build: Set "root": true, in .eslintrc.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/480378 (https://phabricator.wikimedia.org/T206485) (owner: 10Legoktm) [11:28:18] (03PS1) 10D3r1ck01: specials: Fix PHPDoc comments & return type for isValidValue() method [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481236 [11:29:45] 10Cloud-VPS (Project-requests): Request creation of VPS project - https://phabricator.wikimedia.org/T211523 (10Krenair) Theoretically I think this should've been reviewed on the 18th December, but now I think it'll have to wait until the 8th. [11:29:53] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481235 (owner: 10D3r1ck01) [11:30:12] (03CR) 10jenkins-bot: Force flake8 to run under Python 2 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/480910 (owner: 10Legoktm) [11:30:23] (03CR) 10jenkins-bot: Fix the cache timestamp for forced updates. [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/481015 (https://phabricator.wikimedia.org/T210307) (owner: 10Reedy) [11:32:29] (03CR) 10jenkins-bot: build: Set "root": true, in .eslintrc.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/480378 (https://phabricator.wikimedia.org/T206485) (owner: 10Legoktm) [11:33:08] (03CR) 10Daniel Kinzler: "> Patch Set 9:" [core] - 10https://gerrit.wikimedia.org/r/470099 (owner: 10Aaron Schulz) [11:33:44] (03PS1) 10Jforrester: Update OOUI to v0.30.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481237 [11:34:59] (03PS1) 10Jforrester: Update OOUI to v0.30.0 [vendor] - 10https://gerrit.wikimedia.org/r/481238 [11:37:15] (03PS1) 10Jforrester: Update OOUI to v0.30.0 [core] - 10https://gerrit.wikimedia.org/r/481239 (https://phabricator.wikimedia.org/T150071) [11:45:15] (03PS1) 10Urbanecm: New throttle rule for students writing Wikipedia program [mediawiki-config] - 10https://gerrit.wikimedia.org/r/481240 (https://phabricator.wikimedia.org/T212226) [11:46:58] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481236 (owner: 10D3r1ck01) [11:58:31] 10MediaWiki-API, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Waiting for Review), 10MW-1.32-release, and 3 others: Forcelinkupdate appears to have stopped working (on ENWIKI at least) - https://phabricator.wikimedia.org/T210307 (10Jdforrester-WMF) I don't think that this is something urgent en... [12:00:25] (03PS1) 10Jforrester: RELEASE-NOTES-1.32: Add notes for T210307 [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/481241 [12:02:50] 10WMDE-FUN-Team, 10WMDE-Fundraising-Campaign-2018, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2018: Banner #28 Landingpage - Test III - https://phabricator.wikimedia.org/T212203 (10tmletzko) looks good to me. thanks @gabriel-wmde [12:02:59] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10Multimedia-Team-Working-Board: Caption language selector shows interface language version of the language name on selection, but otherwise the native one - https://phabricator.wikimedia.org/T209380 (10Jdforrester-WMF) [12:04:20] 10MediaWiki-Configuration, 10MediaWiki-extensions-General: Update extensions to specify platform requirements - https://phabricator.wikimedia.org/T212489 (10Jdforrester-WMF) [12:07:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] specials: Fix PHPDoc comments & return type for isValidValue() method [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481236 (owner: 10D3r1ck01) [12:07:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] ffs: Fix PHPDoc return type for readRow() method [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481235 (owner: 10D3r1ck01) [12:11:30] (03CR) 10D3r1ck01: "> Patch Set 1: Code-Review+2" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481235 (owner: 10D3r1ck01) [12:11:51] (03CR) 10D3r1ck01: "> Patch Set 1: Code-Review+2" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481236 (owner: 10D3r1ck01) [12:16:20] (03CR) 10Thiemo Kreuz (WMDE): "Hehe. ;-) I started this after I did some micro-benchmarks for other code, and realized how insane array_shift can behave on bigger arrays" [core] - 10https://gerrit.wikimedia.org/r/480048 (owner: 10Thiemo Kreuz (WMDE)) [12:18:44] (03PS1) 10D3r1ck01: tag: Fix some incorrect PHPDoc comments in tag/ files [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481242 [12:21:27] (03Merged) 10jenkins-bot: specials: Fix PHPDoc comments & return type for isValidValue() method [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481236 (owner: 10D3r1ck01) [12:21:35] (03Merged) 10jenkins-bot: ffs: Fix PHPDoc return type for readRow() method [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481235 (owner: 10D3r1ck01) [12:23:54] 10WikiEditor, 10OOUI (OOUI-0.30.0), 10Patch-For-Review: Provide localized Bold and Italic icons for Urdu - https://phabricator.wikimedia.org/T196208 (10Jdforrester-WMF) >>! In T196208#4840589, @MuhammadShuaib wrote: >>>! In T196208#4828239, @Jdforrester-WMF wrote: >> Thank you, @Tulsi_Bhagat and @Esanders. T... [12:25:53] (03CR) 10Jforrester: [C: 04-1] "Daniel said we shouldn't ship this in 1.32." [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/481018 (https://phabricator.wikimedia.org/T194046) (owner: 10Reedy) [12:30:08] (03PS3) 10Jforrester: Docker: Move MobileApps to …-deploy-npm6-node-6-docker [integration/config] - 10https://gerrit.wikimedia.org/r/478762 (https://phabricator.wikimedia.org/T211785) [12:30:31] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog, 10Continuous-Integration-Config, 10JavaScript, 10Patch-For-Review: Upgrade the mobileapps CI job from npm3 to npm6 - https://phabricator.wikimedia.org/T211785 (10Jdforrester-WMF) a:03Jdforrester-WMF Oh, oops, sorry. [12:30:33] 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Temporary lift of IP cap on en.wikipedia for 29 Jan 2019 - https://phabricator.wikimedia.org/T212226 (10Urbanecm) Thanks. [12:30:58] (03CR) 10jerkins-bot: [V: 04-1] Docker: Move MobileApps to …-deploy-npm6-node-6-docker [integration/config] - 10https://gerrit.wikimedia.org/r/478762 (https://phabricator.wikimedia.org/T211785) (owner: 10Jforrester) [12:32:23] 10VPS-project-Wikistats: List of largest MediaWikis does not update Wikias - https://phabricator.wikimedia.org/T172481 (10LWChris) @Aklapper When I look at the [[ http://wikistats.wmflabs.org/largest_html.php?th=0&lines=20 | List of largest MediaWikis ]], I see that at the moment, in the "Last checked" column, a... [12:40:12] (03PS1) 10Xqt: [doc] Credits to Maze (Davide Laezza) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481243 [12:42:49] (03CR) 10Xqt: "Lines 831 and 2130 are longer than 79 char. You should shorten them" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481184 (owner: 10محمد شعیب) [12:43:13] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481242 (owner: 10D3r1ck01) [12:44:12] (03CR) 10D3r1ck01: "> Indeed. Took the liberty to amend as it seems uncontroversial." [core] - 10https://gerrit.wikimedia.org/r/480098 (owner: 10D3r1ck01) [12:48:00] 10Technical-Tool-Request, 10artificial-intelligence: Twitter article info bot - https://phabricator.wikimedia.org/T161236 (10Superyetkin) Is this aimed at Twitter only? It would be a good idea to create a tool that generates a short URL to a page listing helpful information about wiki pages. [12:50:30] (03CR) 10Nathan fraignt: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480734 (https://phabricator.wikimedia.org/T212109) (owner: 10Nathan fraignt) [12:51:33] (03PS3) 10Nathan fraignt: Show trackerpreferences in API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480734 (https://phabricator.wikimedia.org/T212109) [13:08:57] 10MediaWiki-extensions-Newsletter: Fix Newsletter failing builds on Jenkins - https://phabricator.wikimedia.org/T212558 (1001tonythomas) [13:16:51] 10Wikidata, 10Wikidata-Query-Service: wikibase:mwapi query returns empty objects - https://phabricator.wikimedia.org/T212084 (10Vort) Bug with Q59641456 (part two) is not reproducing anymore. But empty values still can be seen with such request (part one): `lang=sparql SELECT ?item ?title WHERE { SERVICE wik... [13:19:44] 10Growth-Team, 10MediaWiki-Watchlist, 10Regression, 10User-Ladsgroup: A particular edit not showing on watchlist - https://phabricator.wikimedia.org/T211849 (10Pruem) 05Resolved→03Open This bug is defintitely not solved in 1.33.0-wmf.9, which is the currently running version on dewiki per 10Cloud-VPS (Project-requests): Request creation of VPS project - https://phabricator.wikimedia.org/T211523 (10Videowiki123) [13:25:15] 10Cleanup, 10GitHub-Mirrors, 10User-MarcoAurelio: Archive labs-tools-signpost - https://phabricator.wikimedia.org/T212559 (10MarcoAurelio) [13:25:31] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Regression, 10User-Ladsgroup: A particular edit not showing on watchlist - https://phabricator.wikimedia.org/T211849 (10Pruem) [13:31:49] 10Cleanup, 10GitHub-Mirrors, 10User-MarcoAurelio: Archive labs-tools-signpost - https://phabricator.wikimedia.org/T212559 (10MarcoAurelio) 05Open→03Resolved Done. [13:36:00] 10Operations, 10ops-codfw: Degraded RAID on ms-be2018 - https://phabricator.wikimedia.org/T212560 (10ops-monitoring-bot) [13:36:21] (03PS3) 10Nathan fraignt: Use API instead of display_items on ticket list. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480742 (https://phabricator.wikimedia.org/T212110) [13:37:13] (03CR) 10Xqt: "Another idea, see below" (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481121 (owner: 10Zhuyifei1999) [13:37:55] 10Wikipedia-Android-App-Backlog: Add sentences to the translatewiki.net from Wikipedia Android app - https://phabricator.wikimedia.org/T212499 (10Patriccck) p:05Normal→03Triage [13:38:28] 10Wikipedia-Android-App-Backlog: Localized Wikipedia logo in mobile app for Android - https://phabricator.wikimedia.org/T212500 (10Patriccck) >>! In T212500#4840621, @Urbanecm wrote: > Please do not set priority. It is up to teams to set it. Thanks! OK, thanks for warning. [13:49:46] 10Wikimedia-Site-requests, 10Turkish-Sites: uca-tr collation lists "I" as "ı" in category pages on trwiki - https://phabricator.wikimedia.org/T203158 (10Superyetkin) What needs to be done to fix this issue? A patch? [14:33:04] 10Shape Expressions, 10Wikidata: expanded SpecialPage for creating a new Schema - https://phabricator.wikimedia.org/T212562 (10Lydia_Pintscher) [14:33:55] 10VisualEditor: p-views tab bar is too big in local version of global user page with French l10n - https://phabricator.wikimedia.org/T212563 (10Pols12) [14:34:01] (03CR) 10Daniel Kinzler: [C: 04-2] "yea, please don't. It's not needed." [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/481018 (https://phabricator.wikimedia.org/T194046) (owner: 10Reedy) [14:35:32] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Regression, 10User-Ladsgroup: A particular edit not showing on watchlist - https://phabricator.wikimedia.org/T211849 (10daniel) It's possible that this was caused by . Shouldn't... [15:05:56] 10Scoring-platform-team: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed) - https://phabricator.wikimedia.org/T212544 (10Ladsgroup) I actually saw this before and there is no easy way to properly fix it but there is a very easy way to go around it. Just add gerrit as another remote to y... [15:13:07] 10MediaWiki-Categories, 10Wikimedia-Site-requests, 10Turkish-Sites: uca-tr collation lists "I" as "ı" in category pages on trwiki - https://phabricator.wikimedia.org/T203158 (10Aklapper) [15:14:57] 10Technical-Tool-Request, 10artificial-intelligence: Twitter article info bot - https://phabricator.wikimedia.org/T161236 (10Aklapper) @Superyetkin: This task is not about short URLs? What is an example for "a page listing helpful information about wiki pages"? [15:16:20] 10Security, 10Trash: 🌷 - https://phabricator.wikimedia.org/T212557 (10Aklapper) 05Open→03Invalid [15:16:45] 10Shape Expressions, 10Wikidata: create Schema entity - https://phabricator.wikimedia.org/T212564 (10Lydia_Pintscher) [15:17:00] 10Trash: 🌷 - https://phabricator.wikimedia.org/T212557 (10Aklapper) [15:18:11] 10Trash: 🌷 - https://phabricator.wikimedia.org/T212557 (10Aklapper) This is not a place to play. [15:18:27] 10Shape Expressions, 10Wikidata: create Schema entity - https://phabricator.wikimedia.org/T212564 (10Lydia_Pintscher) [15:22:56] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10Aklapper) p:05Triage→03Lowest [15:26:13] 10XTools: PLEASE REPLACE WITH A DESCRIPTION OF THE ERROR - https://phabricator.wikimedia.org/T212565 (10LordCoutts) [15:31:10] 10Wikidata, 10Wikidata-primary-sources, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Wikidata primary sources tool deployment review - https://phabricator.wikimedia.org/T196073 (10Lydia_Pintscher) I'm aware that it's coming, yes. We do want the Primary Sources Tool to be improved so are... [15:34:29] 10Wikidata, 10Wikimedia-Language-setup, 10Wiktionary: Cannot add yue.wt sitelinks onto Wikidata items - https://phabricator.wikimedia.org/T211530 (10Lydia_Pintscher) @Ladsgroup any idea where this is broken? [15:35:07] 10ContentTranslation, 10WorkType-NewFunctionality: Allow different users to translate the same topic independently - https://phabricator.wikimedia.org/T86151 (101997kB) Another [[https://meta.wikimedia.org/wiki/Steward_requests/Username_changes#Esther1888|issue]] in which the user is same but forgot the passwo... [15:36:14] 10Wikidata, 10Wikimedia-Language-setup, 10Wiktionary: Cannot add yue.wt sitelinks onto Wikidata items - https://phabricator.wikimedia.org/T211530 (10Ladsgroup) @Lydia_Pintscher Yup, it's on T209820#4831103 TLDR. It's fixable but needs deployment after the holidays. [15:36:47] 10Wikidata: Browser search function to find work on a Wikidata item sometimes doesn't work - https://phabricator.wikimedia.org/T211877 (10Lydia_Pintscher) Can you share links to 2 or 3 items where this happened for you? [15:37:58] 10Wikidata, 10Wikimedia-Language-setup, 10Wiktionary: Cannot add yue.wt sitelinks onto Wikidata items - https://phabricator.wikimedia.org/T211530 (10Lydia_Pintscher) Ok great :) [15:38:30] 10Math, 10Epic, 10Hindi-Sites, 10I18n, and 2 others: Math extension doesn't support many languages including Malayalam, Hindi, and Tamil - https://phabricator.wikimedia.org/T50032 (10Liuxinyu970226) As recent discussions are generally Indic languages related only, I've removed this tag, @Arthur2e5 if you t... [15:39:14] 10Lexicographical data, 10Wikidata: Lemma box too narrow for longer words - https://phabricator.wikimedia.org/T211761 (10Lydia_Pintscher) p:05Triage→03Normal [15:40:14] 10Lexicographical data, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, and 2 others: Glosses: display the language name instead of the language code - https://phabricator.wikimedia.org/T203457 (10Lydia_Pintscher) Thank you! [15:59:40] 10XTools: RouterListener.php: 139 - No route found - https://phabricator.wikimedia.org/T212565 (10Izno) [16:04:54] (03CR) 10Ladsgroup: [C: 03+2] Define a constant for the judgment model [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476993 (owner: 10Awight) [16:10:29] (03Merged) 10jenkins-bot: Define a constant for the judgment model [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476993 (owner: 10Awight) [16:11:07] (03Merged) 10jenkins-bot: Rename functions to match the new model name [extensions/JADE] - 10https://gerrit.wikimedia.org/r/477000 (owner: 10Awight) [16:14:18] (03CR) 10jenkins-bot: Define a constant for the judgment model [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476993 (owner: 10Awight) [16:14:47] 10MediaWiki-Interwiki, 10Wikimedia-Interwiki-links: Update [[Special:Interwiki]] for wikilivres.org (biblio.wiki) - https://phabricator.wikimedia.org/T212566 (10Vladis13) [16:18:10] (03CR) 10jenkins-bot: Rename functions to match the new model name [extensions/JADE] - 10https://gerrit.wikimedia.org/r/477000 (owner: 10Awight) [16:24:32] 10Scoring-platform-team: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed) - https://phabricator.wikimedia.org/T212544 (10Ladsgroup) I pushed all of the updates to gerrit. I found out that drafttopic and draftquality are not actually using git lfs. I need to fix that later. [16:32:57] 10ContentTranslation, 10WorkType-NewFunctionality: Allow different users to translate the same topic independently - https://phabricator.wikimedia.org/T86151 (10Nick) Why is the tool breaking one of our most important, long standing and cherished policies, namely https://en.wikipedia.org/wiki/Wikipedia:Ownersh... [17:00:04] 10AbuseFilter, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (101997kB) Until it's fixed, should we stop renaming people who have accounts on these wikis as i... [17:11:28] (03PS1) 10Urbanecm: Localisation of Babel categories on nap.wikipedia.org [mediawiki-config] - 10https://gerrit.wikimedia.org/r/481244 (https://phabricator.wikimedia.org/T123188) [17:23:40] (03PS1) 10Amire80: Update deletion stat scripts for new tags and date format [analytics/limn-language-data] - 10https://gerrit.wikimedia.org/r/481245 [17:31:18] 10AbuseFilter, 10SpamBlacklist, 10User-Daimona: Make SpamBlacklist clearly act prior to AbuseFilter on WMF operational wikis - https://phabricator.wikimedia.org/T211680 (10Daimona) @Billinghurst I can try to add the new variable, I think that would be a reasonably quick solution. FWIW I can take a look at th... [17:34:42] 10AbuseFilter, 10SpamBlacklist: Whether or not the user recently hit the spam blacklist (abuse filter) - https://phabricator.wikimedia.org/T75417 (10Daimona) While coding this feature shouldn't be hard, I guess we should first think of a decent name for this variable and, primarily, to the time period to keep... [17:44:45] (03PS1) 10Daimona Eaytoy: [WIP] Add an AbuseFilter variable with the content of the spam blacklist [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/481246 (https://phabricator.wikimedia.org/T211680) [18:06:05] 10Cloud-VPS (Project-requests): Request creation of VPS project - https://phabricator.wikimedia.org/T211523 (10Andrew) 05Open→03Resolved a:03Andrew Sorry for the delay! This was stalled for lack of hardware but we got a new server online a couple of days ago so I've created the project now. @... [18:08:49] 10Cloud-VPS (Project-requests): Request creation of lewton-test VPS project - https://phabricator.wikimedia.org/T212063 (10Andrew) 05Open→03Resolved a:03Andrew Sorry for the delay -- we were waiting on new hardware to add additional projects. I've now created this project; @Est31 is projectadmin and can a... [18:10:09] 10MobileFrontend, 10Readers-Web-Backlog (Tracking), 10User-D3r1ck01: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class - https://phabricator.wikimedia.org/T209765 (10D3r1ck01) p:05Normal→03Triage [18:11:36] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) [18:15:47] (03PS2) 10Daimona Eaytoy: [WIP] Add an AbuseFilter variable with the content of the spam blacklist [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/481246 (https://phabricator.wikimedia.org/T211680) [18:17:29] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add an AbuseFilter variable with the content of the spam blacklist [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/481246 (https://phabricator.wikimedia.org/T211680) (owner: 10Daimona Eaytoy) [18:17:31] (03CR) 10Daimona Eaytoy: "Note: This patch isn't merged because it's marked as WIP. Could you please confirm that there's nothing more to do here and it's ready to " [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481030 (owner: 10محمد شعیب) [18:20:53] (03PS5) 10محمد شعیب: Correction of Date formats & month names for Urdu language [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481184 [18:21:10] (03CR) 10محمد شعیب: "> Lines 831 and 2130 are longer than 79 char. You should shorten them" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481184 (owner: 10محمد شعیب) [18:21:52] (03PS3) 10Daimona Eaytoy: [WIP] Add an AbuseFilter variable with the content of the spam blacklist [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/481246 (https://phabricator.wikimedia.org/T211680) [18:27:31] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) Today's run ` ------------------------------------------- TOTAL 294 29 90% ` 10% more to go! :) [18:30:25] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) [18:31:08] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) [18:33:19] (03PS1) 10Fomafix: Avoid using core module 'mediawiki.special.search' [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/481247 (https://phabricator.wikimedia.org/T211384) [18:33:45] 10MediaWiki-extensions-ReplaceText, 10Patch-For-Review: Special:ReplaceText generates Error: Widget not found: searchText in JavaScript console - https://phabricator.wikimedia.org/T211384 (10Fomafix) a:03Fomafix [18:34:38] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add an AbuseFilter variable with the content of the spam blacklist [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/481246 (https://phabricator.wikimedia.org/T211680) (owner: 10Daimona Eaytoy) [18:36:53] (03CR) 10jerkins-bot: [V: 04-1] Avoid using core module 'mediawiki.special.search' [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/481247 (https://phabricator.wikimedia.org/T211384) (owner: 10Fomafix) [18:38:28] (03CR) 10Zhuyifei1999: "Ok. I'm fine with this as long as it doesn't write to stdout." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481121 (owner: 10Zhuyifei1999) [18:38:43] (03CR) 10Daimona Eaytoy: "Uhm does this needs to be linked to AF in CI, or what else?" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/481246 (https://phabricator.wikimedia.org/T211680) (owner: 10Daimona Eaytoy) [18:38:54] (03CR) 10Daimona Eaytoy: "> Uhm does this needs to be linked to AF in CI, or what else?" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/481246 (https://phabricator.wikimedia.org/T211680) (owner: 10Daimona Eaytoy) [18:45:13] 10Wikimedia-Site-requests, 10Security, 10User-MarcoAurelio, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10LinedMaster1) [18:45:50] (03PS1) 10Elukey: profile::hadoop::hdfs_balancer: fix logrotate path [puppet] - 10https://gerrit.wikimedia.org/r/481248 [18:46:56] (03CR) 10Elukey: [C: 03+2] profile::hadoop::hdfs_balancer: fix logrotate path [puppet] - 10https://gerrit.wikimedia.org/r/481248 (owner: 10Elukey) [18:47:58] (03CR) 10Zhuyifei1999: "Wait a sec, right now `message` is used on both `hasattr(sys, 'last_type')` and else, and the format only applies to the former. So we'd e" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481121 (owner: 10Zhuyifei1999) [18:54:07] (03CR) 10Sbisson: Help Panel: Remove {{SITENAME}} and link to Special:Notifications (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/481208 (owner: 10Kosta Harlan) [18:56:45] 10Wikimedia-Site-requests, 10Security, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10LinedMaster1) [18:58:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] tag: Fix some incorrect PHPDoc comments in tag/ files (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481242 (owner: 10D3r1ck01) [19:02:17] 10Wikimedia-Site-requests, 10Security, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10Krenair) Is the abuse filter system not sufficient for admins to prevent this sort of thing? [19:07:40] 10Community-Tech, 10SVG Translate Tool, 10Community-Tech-Sprint: Image preview functionality - https://phabricator.wikimedia.org/T207203 (10Samwilson) WIP PR: https://github.com/wikimedia/svgtranslate/pull/42 Is mostly working, but still shall be polished maybe. [19:09:21] 10DBA, 10Data-Services, 10Tracking: Wikireplica service for tools and labs - issues and missing available views (tracking) - https://phabricator.wikimedia.org/T150767 (10Superyetkin) [19:09:27] 10Wikimedia-Site-requests, 10Security, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10LinedMaster1) Hi, Thanks for quick response. Yet blanking pages is problematic and they must have priority to stop someone who try to remove all of Meta pages as w... [19:09:29] 10Data-Services, 10Technical-Tool-Request, 10Tools, 10goodfirstbug: Create web version of metainformation table on replica servers - https://phabricator.wikimedia.org/T56703 (10Superyetkin) 05Open→03Resolved a:03Superyetkin [19:09:36] (03PS2) 10Fomafix: Avoid using core module 'mediawiki.special.search' [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/481247 (https://phabricator.wikimedia.org/T211384) [19:11:40] 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, 10Developer-Advocacy (Oct-Dec 2018), 10MW-1.27-release-notes, and 3 others: Rename generic "Help" link in MediaWiki sidebar, as many wiki users do not understand it's only for a software called MediaWiki - https://phabricator.wikimedia.org/T209335 (10Ak... [19:11:53] (03Merged) 10jenkins-bot: tag: Fix some incorrect PHPDoc comments in tag/ files [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481242 (owner: 10D3r1ck01) [19:12:57] (03CR) 10Gergő Tisza: "That's a breaking change so we'd have to deprecate it first. Note though that PasswordCannotBePopular is the only way to add a weak check " [core] - 10https://gerrit.wikimedia.org/r/481113 (owner: 10Gergő Tisza) [19:13:07] (03CR) 10jerkins-bot: [V: 04-1] Avoid using core module 'mediawiki.special.search' [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/481247 (https://phabricator.wikimedia.org/T211384) (owner: 10Fomafix) [19:15:49] 10Wikimedia-Site-requests, 10Security, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10Krenair) It sounds to me like you are suggesting admin (rather than developer) action, so this task would be invalid [19:19:04] 10MediaWiki-Interwiki, 10Wikimedia-Interwiki-links: Update [[Special:Interwiki]] for wikilivres.org (biblio.wiki) - https://phabricator.wikimedia.org/T212566 (10MarcoAurelio) 05Open→03Invalid This request is for https://meta.wikimedia.org/Talk:Interwiki_map. Once the code is modified there, a SWAT deploy i... [19:19:44] 10Wikimedia-Site-requests, 10Security, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10LinedMaster1) Proving that this task would be invalid is not enough, but is suggestive. I have opened this ticket to focus issues of blanking page on Meta-Wiki! [19:20:29] 10Wikimedia-Site-requests, 10Security, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10MarcoAurelio) 05Open→03Invalid Per @Krenair. This is an issue that can be dealt with locally for now. Feel free to reach the admins at https://meta.wikimedia.o... [19:20:58] (03PS1) 10Thiemo Kreuz (WMDE): Prefer "self" references where possible [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481249 [19:21:21] (03CR) 10D3r1ck01: tag: Fix some incorrect PHPDoc comments in tag/ files (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481242 (owner: 10D3r1ck01) [19:22:38] (03PS1) 10Thiemo Kreuz (WMDE): Make use of the …::class feature in some cases [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481250 [19:27:00] (03PS1) 10Thiemo Kreuz (WMDE): Remove documentation that does not add any information [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481251 [19:27:05] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) Thank you @Jayprakash12345 :) [19:32:50] (03PS3) 10Fomafix: Avoid using core module 'mediawiki.special.search' [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/481247 (https://phabricator.wikimedia.org/T211384) [19:33:17] 10Wikimedia-Site-requests, 10Security, 10Wikimedia-Incident: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10LinedMaster1) >>! In T212567#4842117, @MarcoAurelio wrote: > Per @Krenair. This is an issue that can be dealt with locally for now. Feel free to reach the admins a... [19:34:33] (03CR) 10D3r1ck01: [C: 03+1] "This indeed also future proves the code as if the class name changes, not a single reference to the class in the code will be touched as "" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481249 (owner: 10Thiemo Kreuz (WMDE)) [19:40:10] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-General-or-Unknown: Blocks should be an implementation detail of an abstract authorization system - https://phabricator.wikimedia.org/T212311 (10Tgr) See T212341#4841566 on why this is not that easy without major changes to the authorization system. The... [19:43:34] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-management, 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Backlog (Later): Create a PermissionManager service - https://phabricator.wikimedia.org/T208768 (10Tgr) See also {T212311} and {T212341} (and my comment there) if the... [19:44:27] 10MediaWiki-Authentication-and-authorization, 10Epic: All permission checks should be able to return a custom error message - https://phabricator.wikimedia.org/T180888 (10Tgr) Somewhat related: {T203083} [19:57:25] (03PS1) 10MarcoAurelio: minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 [19:57:48] (03CR) 10jerkins-bot: [V: 04-1] minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 (owner: 10MarcoAurelio) [19:57:50] (03PS2) 10MarcoAurelio: minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 [19:58:00] (03CR) 10MarcoAurelio: [C: 03+2] minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 (owner: 10MarcoAurelio) [19:58:12] (03CR) 10jerkins-bot: [V: 04-1] minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 (owner: 10MarcoAurelio) [19:58:26] (03CR) 10jerkins-bot: [V: 04-1] minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 (owner: 10MarcoAurelio) [19:59:40] 10AbuseFilter, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10Daimona) @1997kB You may ask for that filters to be changed by local filter managers. It shoul... [20:02:05] (03CR) 10D3r1ck01: [C: 03+1] "I love resolving class names with this! Thanks @Thiemo :)" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481250 (owner: 10Thiemo Kreuz (WMDE)) [20:10:44] 10AbuseFilter, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10MarcoAurelio) @Daimona Unfortunatelly global renamer is a local user group at Meta-Wiki so glo... [20:11:12] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481184 (owner: 10محمد شعیب) [20:14:21] (03PS1) 10MarcoAurelio: Fix pycodestyle issues with autopep8 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 [20:14:42] (03CR) 10jerkins-bot: [V: 04-1] Fix pycodestyle issues with autopep8 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 (owner: 10MarcoAurelio) [20:16:46] (03PS2) 10MarcoAurelio: Fix pycodestyle issues with autopep8; exclude E999 flake8 error [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 [20:17:06] (03CR) 10jerkins-bot: [V: 04-1] Fix pycodestyle issues with autopep8; exclude E999 flake8 error [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 (owner: 10MarcoAurelio) [20:22:31] (03PS3) 10MarcoAurelio: Fix E211 & W504; exclude E999 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 [20:22:51] (03CR) 10jerkins-bot: [V: 04-1] Fix E211 & W504; exclude E999 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 (owner: 10MarcoAurelio) [20:24:01] (03CR) 10Xqt: "is it ready for review?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481184 (owner: 10محمد شعیب) [20:24:50] (03PS4) 10MarcoAurelio: Fix E211, W503 & W504; exclude E999 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 [20:25:11] (03CR) 10jerkins-bot: [V: 04-1] Fix E211, W503 & W504; exclude E999 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 (owner: 10MarcoAurelio) [20:25:16] (03Abandoned) 10MarcoAurelio: Fix E211, W503 & W504; exclude E999 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481253 (owner: 10MarcoAurelio) [20:26:20] (03PS3) 10MarcoAurelio: minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 [20:26:40] (03CR) 10jerkins-bot: [V: 04-1] minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 (owner: 10MarcoAurelio) [20:27:13] (03Abandoned) 10MarcoAurelio: minus-x to 0.3.2 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/481252 (owner: 10MarcoAurelio) [20:30:46] 10Tool-stewardbots, 10WorkType-Maintenance: Several pycodestyle errors - https://phabricator.wikimedia.org/T212568 (10MarcoAurelio) [20:31:58] (03Abandoned) 10MarcoAurelio: Convert EmailCapture to use extension registration [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/479908 (owner: 10MarcoAurelio) [20:33:45] (03PS2) 10MarcoAurelio: Add keys for 'banner-protect' permissions [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/479129 (https://phabricator.wikimedia.org/T209763) [20:40:17] (03CR) 10محمد شعیب: "> is it ready for review?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481184 (owner: 10محمد شعیب) [20:46:27] (03CR) 10محمد شعیب: "> Note: This patch isn't merged because it's marked as WIP. Could you" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481030 (owner: 10محمد شعیب) [20:59:06] 10MediaWiki-Interwiki, 10Wikimedia-Interwiki-links: Update [[Special:Interwiki]] for wikilivres.org (biblio.wiki) - https://phabricator.wikimedia.org/T212566 (10Vladis13) I found it there https://meta.wikimedia.org/wiki/Talk:Interwiki_map#Bibliowiki. Thanks. [21:07:18] (03PS8) 10MR70: Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) [21:08:32] 10MediaWiki-Interwiki, 10Wikimedia-Interwiki-links: Update [[Special:Interwiki]] for wikilivres.org (biblio.wiki) - https://phabricator.wikimedia.org/T212566 (10MarcoAurelio) No problem. I am not sure when the change will go live though, due to Christmas Hollydays, etc. [21:16:57] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10ShakespeareFan00) [21:17:34] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10ShakespeareFan00) Because the UL list should be part of the first item. [21:20:05] (03CR) 10jerkins-bot: [V: 04-1] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [21:20:13] 10MediaWiki-extensions-WikimediaMaintenance: unsuppressCrossWiki has the account to fix hardcoded - https://phabricator.wikimedia.org/T212569 (10MarcoAurelio) [21:25:58] 10AbuseFilter, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10Daimona) Ah! Anyway there are other options: check summary, check the username, ... [21:33:28] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10Aklapper) >>! In T212509#4842149, @ShakespeareFan00 wrote: > Because the UL list should be part of the first item, Unless I am misunderstanding HTML Hmm, not in my understanding... [21:34:55] (03CR) 10MR70: "Looks like jenkins failure related to Flow extension" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [21:35:12] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10ShakespeareFan00) Okay so how to put something that's a BOX based DIV into the first item.. I.e How to make : https://en.wiktionary.org/w/index.php?title=%E1%BC%88%CF%81%CE%B9%C... [21:37:00] 10Wikimedia-General-or-Unknown, 10Security: Meta-Wiki and blanking page problems. - https://phabricator.wikimedia.org/T212567 (10Aklapper) If there is a specific discussion on WM:RFH please provide a permalink to its section. [21:38:43] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10Aklapper) I don't know what "BOX based DIV" means exactly and I am not into templates, sorry. [21:42:52] (03CR) 10MR70: "recheck" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [21:50:57] 10ProofreadPage, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Give all users (including IPs) the pagequality right in plwikisource - https://phabricator.wikimedia.org/T212478 (10Urbanecm) Hi @Ankry, as you can see in [a mirror of our repository](https://phabricator.wikimedia.org/source/m... [21:53:47] (03PS1) 10Paladox: wmlib: Move def function in ini and php_ini within newfunction [puppet] - 10https://gerrit.wikimedia.org/r/481254 [21:53:54] 10Horizon: Follow up T131367: Clean up existing cases of proxies matching project names - https://phabricator.wikimedia.org/T212570 (10Krenair) p:05Triage→03Normal [21:54:07] 10Horizon: Follow up T131367: Clean up existing cases of proxies matching project names - https://phabricator.wikimedia.org/T212570 (10Krenair) [21:54:10] 10Horizon, 10Patch-For-Review: Proxy corner case: proxy name foo.wmflabs.org == domain name foo.wmflabs.org - https://phabricator.wikimedia.org/T131367 (10Krenair) [21:54:22] (03PS2) 10Paladox: wmlib: Move def function in ini and php_ini within newfunction [puppet] - 10https://gerrit.wikimedia.org/r/481254 [21:54:25] 10Cloud-VPS: Follow up T131367: Clean up existing cases of proxies matching project names - https://phabricator.wikimedia.org/T212570 (10Krenair) [21:55:23] (03CR) 10jerkins-bot: [V: 04-1] wmlib: Move def function in ini and php_ini within newfunction [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [21:55:30] (03PS3) 10Paladox: wmlib: Fix support for puppet6 in php_ini.rb and ini.rb [puppet] - 10https://gerrit.wikimedia.org/r/481254 [21:55:36] (03CR) 10Paladox: "check experimental" [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [21:56:28] (03CR) 10jerkins-bot: [V: 04-1] wmlib: Fix support for puppet6 in php_ini.rb and ini.rb [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [21:56:34] (03CR) 10jerkins-bot: [V: 04-1] wmlib: Fix support for puppet6 in php_ini.rb and ini.rb [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [21:58:30] (03PS4) 10Paladox: wmlib: Fix support for puppet6 in php_ini.rb and ini.rb [puppet] - 10https://gerrit.wikimedia.org/r/481254 [21:58:37] (03CR) 10Paladox: "check experimental" [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [22:00:46] (03PS5) 10Paladox: wmlib: Fix support for puppet6 in php_ini.rb and ini.rb [puppet] - 10https://gerrit.wikimedia.org/r/481254 [22:00:51] (03CR) 10Paladox: "check experimental" [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [22:02:05] (03CR) 10Paladox: "puppet catalog https://puppet-compiler.wmflabs.org/compiler1001/86/" [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [22:02:29] (03CR) 10Paladox: "error i got without this:" [puppet] - 10https://gerrit.wikimedia.org/r/481254 (owner: 10Paladox) [22:10:02] 10MediaWiki-Parser: List incorrectly terminated when multiline
embedded inside it - https://phabricator.wikimedia.org/T212509 (10ShakespeareFan00) This was what I was trying to do:- * {{rfap||US|lang=en|inline=yes}} This generates :- `
  • 10MediaWiki-Parser: List incorrectly terminated when multiline
    or table embedded inside it - https://phabricator.wikimedia.org/T212509 (10Aklapper) >>! In T212509#4842183, @ShakespeareFan00 wrote: > This generates :- > [...] I see no `
      ` in there so I'm not sure how much it is related to the testcase...