[00:01:06] (03CR) 10Legoktm: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceAuthors] - 10https://gerrit.wikimedia.org/r/400716 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [00:01:40] (03CR) 10Legoktm: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/400715 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [00:04:11] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/400766 (owner: 10Libraryupgrader) [00:11:11] 10Diffusion, 10Gerrit: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#3863848 (10Legoktm) [00:13:40] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400794 (owner: 10Libraryupgrader) [00:18:26] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400794 (owner: 10Libraryupgrader) [00:23:33] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/ElectronPdfService] - 10https://gerrit.wikimedia.org/r/400795 (owner: 10Libraryupgrader) [00:25:34] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400794 (owner: 10Libraryupgrader) [00:25:37] (03PS1) 10Legoktm: Fix @covers tags [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400807 [00:26:20] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/FileImporter] - 10https://gerrit.wikimedia.org/r/400805 (owner: 10Libraryupgrader) [00:26:47] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/400806 (owner: 10Libraryupgrader) [00:29:50] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/400800 (owner: 10Libraryupgrader) [00:33:13] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/400813 (owner: 10Libraryupgrader) [00:41:58] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400814 (owner: 10Libraryupgrader) [00:52:57] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Publish test coverage report for MediaWiki-CodeSniffer - https://phabricator.wikimedia.org/T183793#3863858 (10Legoktm) [00:53:29] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400814 (owner: 10Libraryupgrader) [00:58:08] (03PS1) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [01:02:11] 10VPS-project-libraryupgrader: Libraryupgrader should skip repos where it made the last commit - https://phabricator.wikimedia.org/T179096#3863871 (10Legoktm) 05Open>03declined [01:04:54] 10VPS-project-codesearch, 10Patch-For-Review: OpenSearch link in code search doesn't work - https://phabricator.wikimedia.org/T183728#3863872 (10Legoktm) 05Open>03Resolved Assuming resolved, please re-open if not. [01:07:08] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/400829 (owner: 10Libraryupgrader) [01:10:05] (03PS1) 10Legoktm: Redirect all HTTP requests to HTTPS [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400850 (https://phabricator.wikimedia.org/T183755) [01:10:26] (03CR) 10Legoktm: [V: 032 C: 032] Redirect all HTTP requests to HTTPS [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400850 (https://phabricator.wikimedia.org/T183755) (owner: 10Legoktm) [01:14:35] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/400841 (owner: 10Libraryupgrader) [01:15:33] 10VPS-project-codesearch, 10Patch-For-Review: Redirect http to https on new codesearch.wmflabs.org - https://phabricator.wikimedia.org/T183755#3863879 (10Legoktm) So it's HTTPS-only except... ``` km@km-pt ~> curl -I "https://codesearch.wmflabs.org/" | grep location location: http://codesearch.wmflabs.org/sear... [01:22:04] (03PS1) 10Legoktm: Set HSTS header for one day [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400858 (https://phabricator.wikimedia.org/T183755) [01:22:23] (03CR) 10Legoktm: [V: 032 C: 032] Set HSTS header for one day [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400858 (https://phabricator.wikimedia.org/T183755) (owner: 10Legoktm) [01:24:42] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/400842 (owner: 10Libraryupgrader) [01:25:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10User-Ryasmeen: [Regression wmf.1] Context menu opens up in random positions - https://phabricator.wikimedia.org/T176766#3863884 (10matmarex) 05Open>03Resolved p:05High>03Normal >>! In T176766... [01:26:07] 10VPS-project-codesearch, 10Patch-For-Review: Redirect http to https on new codesearch.wmflabs.org - https://phabricator.wikimedia.org/T183755#3863887 (10Legoktm) 05Open>03Resolved OK, with HSTS it should always always use HTTPS now. [01:26:29] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/400843 (owner: 10Libraryupgrader) [01:27:01] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/400849 (owner: 10Libraryupgrader) [01:27:43] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/400855 (owner: 10Libraryupgrader) [01:28:08] (03CR) 10Legoktm: [C: 032] "Dropped the -p from phpcbf since it confused libraryupgrader and that flag doesn't do anything." [extensions/Math] - 10https://gerrit.wikimedia.org/r/400855 (owner: 10Libraryupgrader) [01:29:17] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400864 (owner: 10Libraryupgrader) [01:36:40] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400860 (owner: 10Libraryupgrader) [01:36:52] 10Cloud-Services, 10Operations, 10Toolforge, 10Traffic, 10HTTPS: Migrate tools.wmflabs.org to https only (and set HSTS) - https://phabricator.wikimedia.org/T102367#3863889 (10Legoktm) If I have my tool set a `strict-transport-security: max-age=86400` header, will that impact other tools as well since the... [01:45:47] (03CR) 10Legoktm: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400860 (owner: 10Libraryupgrader) [01:45:57] 10MediaWiki-Configuration, 10Google-Code-in-2017: [Recurring] Migrate an extension to use extension registration (extension.json) - https://phabricator.wikimedia.org/T183763#3863890 (10Platonides) I expect other developers would be interested on this as well, but I can help mentoring this ([added](https://www.... [01:48:42] (03PS1) 10Legoktm: Drop PHP 5.6 requirement [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400879 [01:48:53] 10Commons, 10MediaWiki-File-management, 10MediaWiki-Special-pages, 10Multimedia, and 2 others: Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki - https://phabricator.wikimedia.org/T181651#3863891 (10RazeSoldier) >>! In T181651#3863610, @Ebe123 wrote: > 你是GCI的学生吗？If so,... [01:49:32] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400864 (owner: 10Libraryupgrader) [01:53:34] (03CR) 10Reedy: [C: 032] Drop PHP 5.6 requirement [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400879 (owner: 10Legoktm) [01:55:06] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400872 (owner: 10Libraryupgrader) [01:56:28] (03Merged) 10jenkins-bot: Drop PHP 5.6 requirement [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400879 (owner: 10Legoktm) [02:01:57] (03PS1) 10Reedy: Stop testing hhvm 3.12 on travis [core] - 10https://gerrit.wikimedia.org/r/400884 [02:04:45] 10Commons, 10MediaWiki-API, 10MediaWiki-File-management, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3863892 (10Reedy) [02:08:13] 10Discovery, 10Wikidata, 10Wikidata-Query-Service: Wikidata Query Helper deletes comments - https://phabricator.wikimedia.org/T183794#3863894 (10Marsupium) [02:09:03] 10Commons, 10MediaWiki-API, 10MediaWiki-File-management, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3863905 (10Reedy) [02:09:10] 10Commons, 10MediaWiki-API, 10MediaWiki-File-management, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3821936 (10Reedy) [02:09:35] 10Commons, 10MediaWiki-API, 10MediaWiki-File-management, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3821936 (10Reedy) [02:10:01] 10Discovery, 10Wikidata, 10Wikidata Query UI: Wikidata Query Helper deletes comments - https://phabricator.wikimedia.org/T183794#3863908 (10Marsupium) [02:12:52] 10TCB-Team, 10Wikimedia-General-or-Unknown, 10Developer-Relations (Jan-Mar-2018), 10User-Tgr: Provide an easy to use support system for contributors to ask technical questions - https://phabricator.wikimedia.org/T155678#3863909 (10MZMcBride) >>! In T155678#3863603, @Aklapper wrote: > If you have issues wit... [02:18:54] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/400896 (owner: 10Libraryupgrader) [02:22:16] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400905 [02:24:14] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400905 (owner: 10Eisenhaus335) [02:28:42] (03PS1) 10Ebe123: Revert ExtensionRegistry TMH check [extensions/Score] - 10https://gerrit.wikimedia.org/r/400915 [02:31:53] (03CR) 10Reedy: [C: 032] "I think you're right. Should be re-reverted when T87981 is fixed" [extensions/Score] - 10https://gerrit.wikimedia.org/r/400915 (owner: 10Ebe123) [02:33:18] 10MobileFrontend, 10Mobile, 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: Show Navbox templates in mobile skins - https://phabricator.wikimedia.org/T124168#1947834 (10Salgo60) The latest Iphone Wikipedia version 5.7.3 use the concept of **3D Touch** and **Peek quick actions** that fee... [02:34:37] (03PS1) 10Reedy: Only run count() on array() [core] - 10https://gerrit.wikimedia.org/r/400916 (https://phabricator.wikimedia.org/T182377) [02:38:47] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/400900 (owner: 10Libraryupgrader) [02:38:54] (03PS2) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [02:39:12] (03Merged) 10jenkins-bot: Revert ExtensionRegistry TMH check [extensions/Score] - 10https://gerrit.wikimedia.org/r/400915 (owner: 10Ebe123) [02:41:40] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/RevisionSlider] - 10https://gerrit.wikimedia.org/r/400911 (owner: 10Libraryupgrader) [02:43:10] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400899 (owner: 10Libraryupgrader) [02:43:28] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/400919 (owner: 10Libraryupgrader) [02:43:45] (03CR) 10Ebe123: "Added some comments on PS1." (036 comments) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [02:43:57] (03CR) 10Ebe123: [C: 04-1] Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [02:44:58] (03CR) 10Legoktm: [C: 032] "RELEASE-NOTES still says "There is experimental support for HHVM 3.6.5 or later." - we should update that." [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [02:48:41] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400926 [02:50:50] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400926 (owner: 10Eisenhaus335) [02:52:30] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400899 (owner: 10Libraryupgrader) [02:54:21] 10Cloud-Services, 10Operations, 10Toolforge, 10Traffic, 10HTTPS: Migrate tools.wmflabs.org to https only (and set HSTS) - https://phabricator.wikimedia.org/T102367#1363321 (10Krenair) >>! In T102367#3863889, @Legoktm wrote: > If I have my tool set a `strict-transport-security: max-age=86400` header, will... [02:56:07] 10MediaWiki-General-or-Unknown, 10RfC, 10TechCom-RfC (TechCom-Approved): Require either PHP 7.0+ or HHVM in MW 1.31 - https://phabricator.wikimedia.org/T172165#3863929 (10Reedy) >>! In T172165#3852411, @daniel wrote: > This has been approved after last call as per the TechCom meeting of December 13. What ex... [02:56:46] (03Abandoned) 10Ebe123: Add DOM Structure to Scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 (https://phabricator.wikimedia.org/T114757) (owner: 10Ebe123) [02:58:08] (03Merged) 10jenkins-bot: Stop testing hhvm 3.12 on travis [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [02:58:19] (03PS1) 10Reedy: Bump min supported HHVM version to 3.18.5 [core] - 10https://gerrit.wikimedia.org/r/400936 [02:58:21] 10MediaWiki-Configuration, 10Google-Code-in-2017: [Recurring] Migrate an extension to use extension registration (extension.json) - https://phabricator.wikimedia.org/T183763#3863029 (10Legoktm) I can help mentor this too. [02:59:05] (03CR) 10Reedy: "HHVM 3.6.5 is checked in PHPVersionCheck.php...." [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [02:59:47] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Reconsider the "Insert" menu because it doesn't always insert - https://phabricator.wikimedia.org/T70494#3863933 (10matmarex) [03:02:16] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400929 (owner: 10Libraryupgrader) [03:05:22] (03PS1) 10Reedy: Test HHVM LTS versions 3.21 and 3.23 on travis [core] - 10https://gerrit.wikimedia.org/r/400942 [03:05:36] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400943 [03:06:38] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/400930 (owner: 10Libraryupgrader) [03:07:19] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3863935 (10Whatamidoing-WMF) As this doesn't seem to be an emergency, and as some documentation might be helpful, could s... [03:07:46] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400943 (owner: 10Eisenhaus335) [03:09:39] (03CR) 10Reedy: Bump min supported HHVM version to 3.18.5 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400936 (owner: 10Reedy) [03:10:40] 10VPS-project-codesearch: Investigate https://searchfox.org/ as a codesearch backend - https://phabricator.wikimedia.org/T183795#3863936 (10Legoktm) p:05Triage>03Lowest [03:14:23] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/TwoColConflict] - 10https://gerrit.wikimedia.org/r/400951 (owner: 10Libraryupgrader) [03:14:47] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400948 (owner: 10Libraryupgrader) [03:16:10] (03PS17) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [03:16:13] (03CR) 10jenkins-bot: Stop testing hhvm 3.12 on travis [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [03:17:35] (03PS18) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [03:18:15] (03CR) 10GeoffreyT2000: [C: 04-1] "Something needs to be fixed in one of the files because there is currently a merge conflict. Also, if this turns out to not make its way i" [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [03:18:24] (03CR) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [03:21:16] 10Pywikibot-Other-scripts: Set expiry date for page protection in protect.py - https://phabricator.wikimedia.org/T183796#3863947 (10Billinghurst) [03:22:05] (03PS27) 10Reedy: Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [03:23:10] (03CR) 10Reedy: "PS27 is a trivial rebase to take account for I2d8bfdee0a30a54f4315c8056b7ac84f47254db2 being merged" [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [03:23:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile context in nested situations (e.g. link context inside a reference) is hopelessly broken - https://phabricator.wikimedia.org/T157084#3863958 (10matmarex) a:05Esanders>03matmarex [03:23:34] (03PS1) 10Bartosz Dziewoński: ve.ui.DesktopContext: Do not flip the popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/400954 (https://phabricator.wikimedia.org/T182907) [03:23:36] (03PS1) 10Bartosz Dziewoński: ve.ui.TargetWidget: Emit an event to allow last-minute setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/400955 (https://phabricator.wikimedia.org/T157084) [03:23:45] (03CR) 10jerkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [03:23:50] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400956 [03:24:32] (03PS1) 10Bartosz Dziewoński: Fix context menu for mobile TargetWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/400957 (https://phabricator.wikimedia.org/T157084) [03:24:34] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSettingsPage: Fix doc comment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/400958 [03:26:14] (03PS2) 10Bartosz Dziewoński: ve.ui.MWSettingsPage: Fix doc comment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/400958 [03:27:20] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400956 (owner: 10Eisenhaus335) [03:28:10] (03PS1) 10Reedy: De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 [03:29:52] (03PS19) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [03:35:22] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/TwoColConflict] - 10https://gerrit.wikimedia.org/r/400951 (owner: 10Libraryupgrader) [03:37:12] (03CR) 10jerkins-bot: [V: 04-1] De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [03:42:37] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [03:46:28] (03PS1) 10Zhuyifei1999: protect.py: Add expiry parameter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400977 (https://phabricator.wikimedia.org/T183796) [03:47:36] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link inspector inside dialog is clipped against dialog boundary, which makes it too small - https://phabricator.wikimedia.org/T74121#772694 (10matmarex) This is still an issue, with the minor difference that the inspector is not clipped, but rather for... [03:48:22] (03PS2) 10Bartosz Dziewoński: ve.ui.TargetWidget: Emit an event to allow last-minute setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/400955 (https://phabricator.wikimedia.org/T157084) [03:49:24] 10Cloud-Services, 10Operations, 10Toolforge, 10Traffic, 10HTTPS: Migrate tools.wmflabs.org to https only (and set HSTS) - https://phabricator.wikimedia.org/T102367#3863974 (10bd808) >>! In T102367#3863889, @Legoktm wrote: > If I have my tool set a `strict-transport-security: max-age=86400` header, will t... [03:50:02] (03CR) 10jerkins-bot: [V: 04-1] protect.py: Add expiry parameter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400977 (https://phabricator.wikimedia.org/T183796) (owner: 10Zhuyifei1999) [03:51:36] 10Cloud-Services, 10Operations, 10Toolforge, 10Traffic, 10HTTPS: Migrate tools.wmflabs.org to https only (and set HSTS) - https://phabricator.wikimedia.org/T102367#1363321 (10Reedy) https://hstspreload.org/?domain=tools.wmflabs.org {F12139559 size=full} [03:54:32] (03PS1) 10Reedy: [DNM] Test tests... [core] - 10https://gerrit.wikimedia.org/r/400983 [03:54:43] (03CR) 10jerkins-bot: [V: 04-1] De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [03:57:43] (03PS2) 10Zhuyifei1999: protect.py: Add expiry parameter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400977 (https://phabricator.wikimedia.org/T183796) [04:00:01] (03CR) 10Zhuyifei1999: "I tested this:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400977 (https://phabricator.wikimedia.org/T183796) (owner: 10Zhuyifei1999) [04:04:01] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400991 [04:05:26] (03Draft2) 10Yaron Koren: Fix for "group by" and "having" in query API [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/400984 [04:05:41] (03PS1) 10SamanthaNguyen: Separate styles for Special:UploadAvatar into a separate ResourceLoader module [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 [04:06:28] (03Abandoned) 10Reedy: [DNM] Test tests... [core] - 10https://gerrit.wikimedia.org/r/400983 (owner: 10Reedy) [04:08:02] (03PS5) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [04:09:02] (03CR) 10jerkins-bot: [V: 04-1] Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:09:06] 10Gerrit: @Eisenhaus335 probably needs some help over at Gerrit - https://phabricator.wikimedia.org/T183797#3863984 (10zhuyifei1999) [04:09:14] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/Moving folder in tests/phpunit shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3863994 (10Reedy) [04:10:06] (03PS1) 10Reedy: Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 [04:10:51] (03PS6) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [04:11:13] (03CR) 10Yaron Koren: [C: 032] Fix for "group by" and "having" in query API [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/400984 (owner: 10Yaron Koren) [04:11:25] (03PS1) 10Reedy: Decapitalise storage folder in includes and tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400998 [04:11:50] (03CR) 10jerkins-bot: [V: 04-1] Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:12:59] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/Moving folder in tests/phpunit shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3864005 (10Reedy) Attempting to narrow down cause in https://gerrit.wikimedia.org/r/400997 and https://gerrit.wikimedia.org/r/400998 [04:14:23] (03PS7) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [04:15:11] (03Merged) 10jenkins-bot: Fix for "group by" and "having" in query API [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/400984 (owner: 10Yaron Koren) [04:15:27] (03CR) 10Reedy: "Needs QQQ" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:15:42] (03PS1) 10BryanDavis: wikidata: Install wikibase using individual extensions [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400999 (https://phabricator.wikimedia.org/T181769) [04:16:45] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/400990 (owner: 10Libraryupgrader) [04:17:22] (03CR) 10Reedy: [C: 04-1] "plus previous comments" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:18:02] (03CR) 10Reedy: [C: 04-1] "For qqq see https://www.mediawiki.org/wiki/Help:System_message#Finding_messages_and_documentation" [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:18:13] (03CR) 10BryanDavis: "Cherry picked to https://gerrit.wikimedia.org/r/#/c/400999/ on the stretch-migration branch and updated quite a bit. If that patch is acce" [vagrant] - 10https://gerrit.wikimedia.org/r/394689 (https://phabricator.wikimedia.org/T181769) (owner: 10Addshore) [04:19:18] (03CR) 10jerkins-bot: [V: 04-1] Decapitalise storage folder in includes and tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400998 (owner: 10Reedy) [04:19:39] (03CR) 10Ebe123: [C: 04-1] "Really not what I had in mind" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:21:14] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3864009 (10Reedy) [04:22:29] (03Abandoned) 10Reedy: De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [04:22:53] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3863994 (10Reedy) [04:23:35] (03PS1) 10Reedy: Only lowercase storage tests... [core] - 10https://gerrit.wikimedia.org/r/401000 [04:39:50] 10MediaWiki-Vagrant, 10Patch-For-Review: Update role::wikidata to work with new (no)build process - https://phabricator.wikimedia.org/T181769#3864013 (10bd808) >>! In T181769#3855613, @Smalyshev wrote: > With the patch above, after enabling wikidata role in vagrant, I get this: (...snip...) > ``` > AND (page_n... [04:40:30] (03PS1) 10Eisenhaus335: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401002 [04:42:40] (03CR) 10jerkins-bot: [V: 04-1] Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401002 (owner: 10Eisenhaus335) [04:47:10] (03PS2) 10SamanthaNguyen: Separate styles for Special:UploadAvatar into a separate ResourceLoader module [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 [04:47:15] (03PS1) 10Eisenhaus335: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401003 [04:47:56] (03CR) 10SamanthaNguyen: "PS2 removes unnecessary top file comment from SpecialUploadAvatar.css (it's now self-explanatory since it's moved)" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 (owner: 10SamanthaNguyen) [04:50:00] (03CR) 10jerkins-bot: [V: 04-1] Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401003 (owner: 10Eisenhaus335) [04:55:09] (03CR) 10BryanDavis: "I haven't tested this yet, but I left 2 trivial comments in-line." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/398063 (https://phabricator.wikimedia.org/T119534) (owner: 10Nehajha) [04:56:38] (03Draft2) 10Yaron Koren: Added delimiter for list of "attached templates" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/401004 [04:58:46] (03CR) 10Yaron Koren: [C: 032] Added delimiter for list of "attached templates" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/401004 (owner: 10Yaron Koren) [04:58:52] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3864014 (10Reedy) And to narrow it down further... includes/storage is fine https://gerrit.wikimedia.org/r/401001 te... [05:00:24] (03Merged) 10jenkins-bot: Added delimiter for list of "attached templates" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/401004 (owner: 10Yaron Koren) [05:01:39] (03PS7) 10BryanDavis: Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:01:41] (03CR) 10BryanDavis: [C: 032] Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:02:25] (03PS1) 10Reedy: Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 [05:04:15] 10Gerrit: @Eisenhaus335 probably needs some help over at Gerrit - https://phabricator.wikimedia.org/T183797#3864017 (10Aklapper) 05Open>03stalled Subscribing the user to this task. :) I wonder if https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 is a possibl... [05:07:37] (03Merged) 10jenkins-bot: Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:10:00] 10Tools: PHP Error on templatecount tool - https://phabricator.wikimedia.org/T183799#3864020 (10TerraCodes) [05:14:55] (03CR) 10BryanDavis: [C: 031] "Needs a release note." [core] - 10https://gerrit.wikimedia.org/r/338911 (https://phabricator.wikimedia.org/T45086) (owner: 10Gergő Tisza) [05:17:38] (03CR) 10jenkins-bot: Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:29:46] (03PS8) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [05:36:09] (03CR) 10Ebe123: [C: 04-1] "Quick little fixes" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [05:41:24] (03CR) 10Ebe123: [C: 04-1] "There's also an inconsistency of message name" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [05:41:33] (03PS1) 10Eisenhaus335: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401006 [05:41:35] (03PS1) 10Eisenhaus335: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401007 [05:44:12] 10MediaWiki-Vagrant, 10Patch-For-Review: Update role::wikidata to work with new (no)build process - https://phabricator.wikimedia.org/T181769#3864030 (10Smalyshev) With this patch, stretch-migration seems to be able to install Wikidata and I can add items there without any error messages. [05:44:26] (03CR) 10jerkins-bot: [V: 04-1] Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401007 (owner: 10Eisenhaus335) [05:53:54] (03PS1) 10OmkarJ: add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 [05:59:23] (03PS9) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [06:00:43] 10Android-app-Bugs, 10Android-app-feature-Offline, 10Wikipedia-Android-App-Backlog: Continue reading cards on feed are inconsistently shown on the Explore feed when offline - https://phabricator.wikimedia.org/T157343#3864032 (10RHo) [06:01:01] (03CR) 10星耀晨曦: "> (4 comments)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [06:02:19] (03PS1) 10OmkarJ: Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 [06:18:27] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3864036 (10OmkarJ) [06:18:29] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Improve handling of section editing errors - https://phabricator.wikimedia.org/T154805#3864037 (10RHo) [06:18:59] (03CR) 10Ebe123: [C: 04-1] "You're correct. Just pay attention to the messages :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [06:19:24] (03PS1) 10Eisenhaus335: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401010 [06:20:17] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site(s) - https://phabricator.wikimedia.org/T154813#3864038 (10RHo) [06:21:29] (03PS10) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [06:21:52] (03CR) 10jerkins-bot: [V: 04-1] Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401010 (owner: 10Eisenhaus335) [06:26:56] (03PS1) 10Eisenhaus335: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401011 [06:42:26] 10MediaWiki-API: Special:Unusedtemplates listing templates in use - https://phabricator.wikimedia.org/T183800#3864041 (10Jacob.jose) [06:56:47] (03PS10) 10Ryan10145: Made download_dump.py download process atomic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) [07:04:48] (03CR) 10Zhuyifei1999: Made download_dump.py download process atomic (034 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) (owner: 10Ryan10145) [07:08:58] 10GitHub-Mirrors: Enable Travis CI builds for wikimedia-lucene-explain-parser - https://phabricator.wikimedia.org/T183533#3864052 (10greg) The Release Engineering Team does not maintain any Travis configurations for any repos. We only maintain config for our CI infrastructure. [07:13:06] (03PS3) 10Nehajha: Added Mediawiki OAuth for applicants [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/398063 (https://phabricator.wikimedia.org/T119534) [07:17:31] (03PS11) 10Ryan10145: Made download_dump.py download process atomic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) [07:25:20] (03CR) 10D3r1ck01: "Some issues you should fix;" (034 comments) [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (owner: 10OmkarJ) [07:25:32] (03CR) 10D3r1ck01: [C: 04-1] Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (owner: 10OmkarJ) [07:26:16] (03CR) 10Zhuyifei1999: [C: 031] "LGTM. Although readability could be improved with some comments." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) (owner: 10Ryan10145) [07:27:48] (03CR) 10D3r1ck01: [C: 04-1] "Issues to address!" (034 comments) [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (owner: 10OmkarJ) [07:32:18] 10Wikimedia-IEG-grant-review: Integrate with OAuth - https://phabricator.wikimedia.org/T74292#3864056 (10Nehajha) a:03Nehajha [07:33:00] 10GitHub-Mirrors: Enable Travis CI builds for wikimedia-lucene-explain-parser - https://phabricator.wikimedia.org/T183533#3864058 (10Smalyshev) There's no need to maintain anything, actually, just for somebody who is github mirror admin to go to https://travis-ci.org/profile/wikimedia and flip the switches for c... [07:34:42] 10Wikimedia-IEG-grant-review: Test Failures - https://phabricator.wikimedia.org/T176072#3864059 (10Nehajha) 05Open>03Invalid These tests were failing because I did not correctly build the grants app. [07:35:48] 10Wikimedia-IEG-grant-review: Group related mass DB transactions into a single one - https://phabricator.wikimedia.org/T91253#3864061 (10Nehajha) a:03Nehajha [08:01:38] (03PS12) 10Ryan10145: Made download_dump.py download process atomic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) [08:02:22] (03CR) 10Zhuyifei1999: [C: 031] Made download_dump.py download process atomic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) (owner: 10Ryan10145) [08:06:49] 10GitHub-Mirrors: Enable Travis CI builds for wikimedia-lucene-explain-parser - https://phabricator.wikimedia.org/T183533#3864064 (10greg) That's fine, that's what the #github-mirrors project is for, hopefully enough of the admins are watching it. It's just not a thing #releng maintains/does, hence removing our... [08:22:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/401012 (owner: 10L10n-bot) [08:22:39] 10MediaWiki-extensions-CentralAuth, 10Easy: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864067 (10Reception123) Was looking at CentralAuth and found this request, so might as well do it (even after 4 years :P) [08:23:26] (03CR) 10Legoktm: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [08:23:55] (03Draft2) 10Reception123: Make Special:GlobalAccount alias for Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) [08:25:26] (03CR) 10Legoktm: [C: 032] Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:27:58] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864068 (10Reception123) https://gerrit.wikimedia.org/r/#/c/401013/ [08:30:04] (03CR) 10Legoktm: [C: 04-1] "The PSR-4 future is capitalized directory names, because they need to match the namespace name." [core] - 10https://gerrit.wikimedia.org/r/400998 (owner: 10Reedy) [08:31:05] (03CR) 10jerkins-bot: [V: 04-1] Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:31:57] (03PS2) 10OmkarJ: add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) [08:32:02] (03CR) 10Legoktm: [C: 032] "..." [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:32:58] (03PS2) 10OmkarJ: Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) [08:33:57] (03CR) 10D3r1ck01: "Another minor fix" (031 comment) [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:34:01] (03CR) 10Legoktm: [C: 04-1] "MatmaRex said this looks super wrong. I expect he'll say what's wrong :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [08:34:57] (03CR) 10D3r1ck01: "Minor fix!" (031 comment) [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:37:13] (03PS3) 10OmkarJ: add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) [08:37:48] (03PS3) 10OmkarJ: Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) [08:37:50] (03Merged) 10jenkins-bot: Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:37:58] 10MediaWiki-Special-pages: Special:Unusedtemplates listing templates in use - https://phabricator.wikimedia.org/T183800#3864073 (10Legoktm) Template:! isn't a real template any more, it's a magic word handled by the software: https://www.mediawiki.org/wiki/Help:Magic_words#Other for Template:AMG, https://ml.wik... [08:38:56] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:41:08] (03PS4) 10D3r1ck01: Add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:41:53] (03CR) 10D3r1ck01: [C: 031] "LGTM! Thank you Omkar! :)" [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:45:39] (03CR) 10D3r1ck01: [C: 031] "@Phantom42, a little patience please, your patch will be reviewed and merged soon!" [integration/config] - 10https://gerrit.wikimedia.org/r/400714 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [08:45:44] (03CR) 10D3r1ck01: [C: 031] "@Phantom42, a little patience please, your patch will be reviewed and merged soon!" [integration/config] - 10https://gerrit.wikimedia.org/r/400712 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [08:47:12] (03CR) 10jenkins-bot: Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:51:51] (03CR) 10Tpt: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400899 (owner: 10Libraryupgrader) [08:52:03] (03CR) 10TerraCodes: [C: 031] "LGTM, but its missing patch one?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:52:43] (03Draft1) 10Reception123: Make Special:GlobalAccount alias for Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) [08:52:52] (03CR) 10TerraCodes: [C: 031] "nvm, patch one is showing up now..." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:52:57] (03CR) 10Tpt: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/400841 (owner: 10Libraryupgrader) [08:53:15] (03CR) 10Reception123: "I forgot to click "publish" for patch one, done now." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:53:42] (03CR) 10D3r1ck01: "A minor fix :)" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:54:07] (03PS3) 10Reception123: Make Special:GlobalAccount alias for Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) [08:55:01] 10MediaWiki-Special-pages: Special:Unusedtemplates listing templates in use - https://phabricator.wikimedia.org/T183800#3864081 (10Jacob.jose) {F12142536} Here is a screenshot of whatlinkshere for template:AMG. The templates listed here are used in various pages, for instance: {F12142538} [08:55:16] (03CR) 10D3r1ck01: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:57:24] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:59:19] 10WMDE-Fun-Team, 10WMDE-Fundraising-Funban-2: Thank You banner (2) - https://phabricator.wikimedia.org/T183538#3864082 (10Stefan_Schneider_WMDE) Hi guys, I hope we can still fix the links, so that they are directing to the landingpage as described be Kai in T183538#3863456. At the moment I cannot see the bann... [09:33:36] (03PS1) 10Legoktm: Disallow PHP 7.2+ `object` type-hint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/401044 [09:38:09] 04(no projects): Add "Previous blocks" to footer of Special:Block - https://phabricator.wikimedia.org/T183801#3864084 (10Reception123) [09:40:59] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, and 2 others: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete ho... - https://phabricator.wikimedia.org/T183716#3864093 [09:41:02] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10Patch-For-Review, 10User-Addshore: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3864094 (10Addshore) 05Open>03Resolved [09:45:11] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Publish test coverage report for MediaWiki-CodeSniffer - https://phabricator.wikimedia.org/T183793#3864095 (10Legoktm) a:03Legoktm [09:45:57] 10MobileFrontend, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: Argument 1 passed to MediaWiki\Storage\RevisionStore::getKnownCurrentRevision() must be an instance of Title, null given - https://phabricator.wikimedia.org/T183714#3864096 (10Addshore) p:05Triage>03High a:03Add... [09:46:36] (03PS1) 10Legoktm: Warn on usage of each() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/401045 (https://phabricator.wikimedia.org/T174354) [09:47:57] 10MobileFrontend, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: Argument 1 passed to MediaWiki\Storage\RevisionStore::getKnownCurrentRevision() must be an instance of Title, null given - https://phabricator.wikimedia.org/T183714#3861542 (10Addshore) [09:54:42] (03PS3) 10Legoktm: [WikivoteMapsYandex] Use composer unit tests [integration/config] - 10https://gerrit.wikimedia.org/r/393441 (owner: 10Umherirrender) [09:54:44] (03PS3) 10Legoktm: Archive RestBaseUpdateJobs from zuul [integration/config] - 10https://gerrit.wikimedia.org/r/400706 (https://phabricator.wikimedia.org/T182561) (owner: 10Reception123) [09:54:46] (03PS2) 10Legoktm: Add BlueSpiceAbout extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/400714 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [09:54:49] (03PS3) 10Legoktm: Add Form extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/400712 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [09:54:50] (03PS1) 10Legoktm: Publish PHPUnit coverage report for MediaWiki-CodeSniffer [integration/config] - 10https://gerrit.wikimedia.org/r/401046 (https://phabricator.wikimedia.org/T183793) [09:54:52] (03PS1) 10Legoktm: Whitelist Noella94 [integration/config] - 10https://gerrit.wikimedia.org/r/401047 [09:55:36] (03CR) 10Legoktm: [C: 032] Publish PHPUnit coverage report for MediaWiki-CodeSniffer [integration/config] - 10https://gerrit.wikimedia.org/r/401046 (https://phabricator.wikimedia.org/T183793) (owner: 10Legoktm) [09:55:41] (03CR) 10Legoktm: [C: 032] [WikivoteMapsYandex] Use composer unit tests [integration/config] - 10https://gerrit.wikimedia.org/r/393441 (owner: 10Umherirrender) [09:55:47] (03CR) 10Legoktm: [C: 032] Archive RestBaseUpdateJobs from zuul [integration/config] - 10https://gerrit.wikimedia.org/r/400706 (https://phabricator.wikimedia.org/T182561) (owner: 10Reception123) [09:55:52] (03CR) 10Legoktm: [C: 032] Add BlueSpiceAbout extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/400714 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [09:55:57] (03CR) 10Legoktm: [C: 032] Add Form extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/400712 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [09:56:02] (03CR) 10Legoktm: [C: 032] Whitelist Noella94 [integration/config] - 10https://gerrit.wikimedia.org/r/401047 (owner: 10Legoktm) [09:57:40] (03Merged) 10jenkins-bot: Publish PHPUnit coverage report for MediaWiki-CodeSniffer [integration/config] - 10https://gerrit.wikimedia.org/r/401046 (https://phabricator.wikimedia.org/T183793) (owner: 10Legoktm) [09:57:42] (03Merged) 10jenkins-bot: [WikivoteMapsYandex] Use composer unit tests [integration/config] - 10https://gerrit.wikimedia.org/r/393441 (owner: 10Umherirrender) [09:58:03] (03Merged) 10jenkins-bot: Archive RestBaseUpdateJobs from zuul [integration/config] - 10https://gerrit.wikimedia.org/r/400706 (https://phabricator.wikimedia.org/T182561) (owner: 10Reception123) [09:58:06] (03Merged) 10jenkins-bot: Add BlueSpiceAbout extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/400714 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [09:58:08] (03Merged) 10jenkins-bot: Add Form extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/400712 (https://phabricator.wikimedia.org/T183674) (owner: 10Phantom42) [09:58:36] 10AbuseFilter, 10MediaWiki-Change-tagging: After changing a filter to apply a tag B instead of a tag A, there is no way to undo this and make it apply tag A again - https://phabricator.wikimedia.org/T183784#3864112 (10matej_suchanek) [09:58:38] 10AbuseFilter: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#3864115 (10matej_suchanek) [09:58:40] (03Merged) 10jenkins-bot: Whitelist Noella94 [integration/config] - 10https://gerrit.wikimedia.org/r/401047 (owner: 10Legoktm) [10:00:45] (03CR) 10jenkins-bot: Release 15.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400710 (owner: 10Legoktm) [10:01:27] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10Patch-For-Review: Publish test coverage report for MediaWiki-CodeSniffer - https://phabricator.wikimedia.org/T183793#3864116 (10Legoktm) 05Open>03Resolved https://doc.wikimedia.org/cover/mediawiki-tools-codesniffer/ 90% but we can do better :) [10:04:53] 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review, 10Services (doing): Archive the RestBaseUpdateJobs extension - https://phabricator.wikimedia.org/T182561#3864118 (10Legoktm) [10:05:13] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864119 (10D3r1ck01) [10:06:45] 10Contributors-Team, 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 10VisualEditor, and 4 others: Selflinks should still be tags with CSS styling via a class, not tags - https://phabricator.wikimedia.org/T160480#3100391 (10Od1n) I was about to completely agree with Jdlrobson, but actually... [10:07:43] (03PS3) 10ArielGlenn: toy offline reader: pylint and pep8 [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280109 [10:08:13] (03CR) 10ArielGlenn: [C: 032] toy offline reader: pylint and pep8 [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280109 (owner: 10ArielGlenn) [10:10:45] 10GlobalUsage, 10MediaWiki-Special-pages, 10Multimedia, 10Google-Code-in-2017: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3864123 (10Phantom42) a:03Phantom42 This task seems to be interesting. I will work on this! [10:11:08] (03PS1) 10Legoktm: Add BlueSpiceAbout [extensions] - 10https://gerrit.wikimedia.org/r/401048 [10:11:18] (03CR) 10Legoktm: [V: 032 C: 032] Add BlueSpiceAbout [extensions] - 10https://gerrit.wikimedia.org/r/401048 (owner: 10Legoktm) [10:12:16] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3864125 (10kai.nissen) [10:13:44] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3848372 (10kai.nissen) [10:13:46] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 42 - thank you campaign - new donation app - https://phabricator.wikimedia.org/T183773#3864131 (10kai.nissen) [10:13:48] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Mob 06 - thank you campaign - new donation app - https://phabricator.wikimedia.org/T183775#3864133 (10kai.nissen) [10:14:35] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864134 (10D3r1ck01) [10:14:47] (03PS1) 10Legoktm: Add "composer test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 [10:14:49] 10MobileFrontend, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: Argument 1 passed to MediaWiki\Storage\RevisionStore::getKnownCurrentRevision() must be an instance of Title, null given - https://phabricator.wikimedia.org/T183714#3864135 (10Addshore) [10:16:11] (03CR) 10jerkins-bot: [V: 04-1] Add "composer test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:16:21] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864136 (10Legoktm) [10:17:36] (03PS2) 10Legoktm: Add "composer test" and dummy "npm test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 [10:18:47] (03PS1) 10Tpt: Makes parser tests pass [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) [10:25:10] (03PS1) 10ArielGlenn: pep8 for rsyncmedia script [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/401051 [10:25:18] (03CR) 10Legoktm: [C: 04-1] "I think this is a regression in core. I git bisected this to 3d560be428920fd4eb10ea6e9760dafbba8f9ddc." [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:26:15] (03CR) 10Legoktm: "Git bisect points to this commit as the reason for the LabeledSectionTransclusion parser test failures." [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [10:26:23] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864140 (10D3r1ck01) [10:29:06] (03CR) 10D3r1ck01: [C: 031] Add "composer test" and dummy "npm test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:30:18] (03CR) 10D3r1ck01: [C: 031] Add "composer test" and dummy "npm test" configuration (031 comment) [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:32:18] 10Wikibase-Quality, 10Wikibase-Quality-Constraints, 10Wikidata, 10Easy, and 3 others: Tidy up @covers/@uses annotations in WikibaseQualityConstraints tests - https://phabricator.wikimedia.org/T173409#3864141 (10Ladsgroup) [10:32:31] (03CR) 10D3r1ck01: [C: 031] "Ohh as a follow up, I saw this: https://github.com/npm/npm/issues/4718." [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:33:03] (03CR) 10Tpt: "> I think this is a regression in core." [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:33:27] (03CR) 10ArielGlenn: [C: 032] pep8 for rsyncmedia script [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/401051 (owner: 10ArielGlenn) [10:33:44] (03PS1) 10Legoktm: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 [10:34:25] (03CR) 10Legoktm: [C: 04-1] "Check out Change-Id: If4c140aedf16fc16a4ae2361f465798055748255 - with that applied, the parser tests pass for me." [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:34:38] (03CR) 10Bartosz Dziewoński: [C: 032] Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 (owner: 10Reedy) [10:35:28] (03CR) 10Legoktm: "See Change-Id: If4c140aedf16fc16a4ae2361f465798055748255 for follow-up." [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [10:35:54] (03Abandoned) 10Tpt: Makes parser tests pass [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:36:17] (03CR) 10Tpt: [C: 031] "This fixes LabeledSectionTransclusion in my local installation" [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [10:38:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/399573 (owner: 10L10n-bot) [10:38:56] (03PS1) 10Tpt: Applies some coding standards [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401053 [10:39:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/400177 (owner: 10L10n-bot) [10:40:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/400476 (owner: 10L10n-bot) [10:40:46] (03CR) 10jerkins-bot: [V: 04-1] Applies some coding standards [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401053 (owner: 10Tpt) [10:42:37] (03PS1) 10Nikerabbit: [repong] Fix auto-merging of some patches [translatewiki] - 10https://gerrit.wikimedia.org/r/401054 [10:42:40] (03Merged) 10jenkins-bot: Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 (owner: 10Reedy) [10:42:57] (03CR) 10Bartosz Dziewoński: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [10:46:23] (03CR) 10Legoktm: [C: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [10:50:20] (03PS6) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [10:50:53] (03CR) 10jenkins-bot: Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 (owner: 10Reedy) [10:52:09] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/ScopedCallback] - 10https://gerrit.wikimedia.org/r/401055 (owner: 10Libraryupgrader) [10:52:12] (03CR) 10Bartosz Dziewoński: "Hm, okay. The whitespace changes are still wrong." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [10:52:45] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/Equivset] - 10https://gerrit.wikimedia.org/r/401056 (owner: 10Libraryupgrader) [10:52:51] 10WMDE-Design, 10Wikidata, 10Wikidata Query UI, 10Design, and 3 others: Implement keyboard accessibility for Query.Wikidata.org - https://phabricator.wikimedia.org/T173213#3864145 (10eflyjason) Added `R` to jump to query result and `Arrow Up`/`Arrow Down` to select item in query result [10:53:06] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/Timestamp] - 10https://gerrit.wikimedia.org/r/401057 (owner: 10Libraryupgrader) [10:53:13] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RunningStat] - 10https://gerrit.wikimedia.org/r/401064 (owner: 10Libraryupgrader) [10:53:28] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [IPSet] - 10https://gerrit.wikimedia.org/r/401063 (owner: 10Libraryupgrader) [10:53:29] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/401058 (owner: 10Libraryupgrader) [10:53:31] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RelPath] - 10https://gerrit.wikimedia.org/r/401062 (owner: 10Libraryupgrader) [10:54:17] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RunningStat] - 10https://gerrit.wikimedia.org/r/401064 (owner: 10Libraryupgrader) [10:54:42] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/401061 (owner: 10Libraryupgrader) [10:54:46] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/401061 (owner: 10Libraryupgrader) [10:54:55] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/401060 (owner: 10Libraryupgrader) [10:55:02] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [AhoCorasick] - 10https://gerrit.wikimedia.org/r/401059 (owner: 10Libraryupgrader) [10:55:44] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [utfnormal] - 10https://gerrit.wikimedia.org/r/401075 (owner: 10Libraryupgrader) [10:55:48] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [utfnormal] - 10https://gerrit.wikimedia.org/r/401075 (owner: 10Libraryupgrader) [10:55:59] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [purtle] - 10https://gerrit.wikimedia.org/r/401074 (owner: 10Libraryupgrader) [10:56:18] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401073 (owner: 10Libraryupgrader) [10:56:21] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401073 (owner: 10Libraryupgrader) [10:56:31] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [php-session-serializer] - 10https://gerrit.wikimedia.org/r/401072 (owner: 10Libraryupgrader) [10:56:46] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [10:56:49] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [10:57:31] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [integration/docroot] - 10https://gerrit.wikimedia.org/r/401070 (owner: 10Libraryupgrader) [10:57:33] (03CR) 10MarcoAurelio: [C: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 (031 comment) [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/401069 (owner: 10Libraryupgrader) [10:57:52] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/401069 (owner: 10Libraryupgrader) [10:58:19] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [integration/docroot] - 10https://gerrit.wikimedia.org/r/401070 (owner: 10Libraryupgrader) [10:58:21] (03CR) 10Legoktm: [C: 031] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/401069 (owner: 10Libraryupgrader) [10:58:32] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [cdb] - 10https://gerrit.wikimedia.org/r/401068 (owner: 10Libraryupgrader) [10:58:40] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [base-convert] - 10https://gerrit.wikimedia.org/r/401067 (owner: 10Libraryupgrader) [10:58:51] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [at-ease] - 10https://gerrit.wikimedia.org/r/401066 (owner: 10Libraryupgrader) [10:58:59] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [WrappedString] - 10https://gerrit.wikimedia.org/r/401065 (owner: 10Libraryupgrader) [10:59:01] (03CR) 10MarcoAurelio: [C: 031] "wating on CI to +2, but looks good to me" [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/401069 (owner: 10Libraryupgrader) [11:00:17] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [IPSet] - 10https://gerrit.wikimedia.org/r/401063 (owner: 10Libraryupgrader) [11:00:46] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RelPath] - 10https://gerrit.wikimedia.org/r/401062 (owner: 10Libraryupgrader) [11:01:18] (03PS1) 10Legoktm: Fix duplicate phpcbf issue [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/401076 [11:01:30] (03CR) 10Legoktm: [C: 032] Fix duplicate phpcbf issue [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/401076 (owner: 10Legoktm) [11:01:52] (03Merged) 10jenkins-bot: Fix duplicate phpcbf issue [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/401076 (owner: 10Legoktm) [11:02:32] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/401061 (owner: 10Libraryupgrader) [11:03:35] (03PS3) 10MarcoAurelio: [do not merge yet] wikimania2017: closing the wiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/396581 (https://phabricator.wikimedia.org/T182493) [11:03:47] (03PS1) 10Legoktm: Use @composer for calling composer commands in scripts [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401077 [11:03:52] (03PS4) 10MarcoAurelio: wikimania2017: closing the wiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/396581 (https://phabricator.wikimedia.org/T182493) [11:05:10] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/401060 (owner: 10Libraryupgrader) [11:06:24] (03CR) 10MarcoAurelio: [C: 032] "Thank you!" [labs/tools/stewardbots] - 10https://gerrit.wikimedia.org/r/401069 (owner: 10Libraryupgrader) [11:07:44] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [AhoCorasick] - 10https://gerrit.wikimedia.org/r/401059 (owner: 10Libraryupgrader) [11:08:17] (03PS1) 10Legoktm: phpcs.xml: Use normal exclusion syntax [integration/docroot] - 10https://gerrit.wikimedia.org/r/401078 [11:08:42] 10MediaWiki-extensions-Contributors, 10MediaWiki-extensions-Page_Forms: Special:Contributors throws "MediaWiki internal error" when used in a Page Form template - https://phabricator.wikimedia.org/T181903#3864147 (10Stefahn) That didn't help but I found the culprit at another place. If I edit [[ https://phabri... [11:09:03] (03PS1) 10Legoktm: Install php-ast for SecurityCheckPlugin [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/401079 [11:09:15] (03CR) 10Legoktm: [C: 032] Install php-ast for SecurityCheckPlugin [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/401079 (owner: 10Legoktm) [11:09:29] (03Merged) 10jenkins-bot: Install php-ast for SecurityCheckPlugin [labs/libraryupgrader] - 10https://gerrit.wikimedia.org/r/401079 (owner: 10Legoktm) [11:11:24] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [base-convert] - 10https://gerrit.wikimedia.org/r/401067 (owner: 10Libraryupgrader) [11:11:44] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [utfnormal] - 10https://gerrit.wikimedia.org/r/401075 (owner: 10Libraryupgrader) [11:12:05] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401073 (owner: 10Libraryupgrader) [11:12:27] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [php-session-serializer] - 10https://gerrit.wikimedia.org/r/401072 (owner: 10Libraryupgrader) [11:12:58] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [purtle] - 10https://gerrit.wikimedia.org/r/401074 (owner: 10Libraryupgrader) [11:14:42] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [11:15:03] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [at-ease] - 10https://gerrit.wikimedia.org/r/401066 (owner: 10Libraryupgrader) [11:15:41] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [cdb] - 10https://gerrit.wikimedia.org/r/401068 (owner: 10Libraryupgrader) [11:15:44] 10MediaWiki-Special-pages: Add "Previous blocks" to footer of Special:Block - https://phabricator.wikimedia.org/T183801#3864148 (10Peachey88) [11:16:06] (03PS1) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/401080 [11:16:58] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [WrappedString] - 10https://gerrit.wikimedia.org/r/401065 (owner: 10Libraryupgrader) [11:17:18] (03CR) 10Legoktm: [C: 032] phpcs.xml: Use normal exclusion syntax [integration/docroot] - 10https://gerrit.wikimedia.org/r/401078 (owner: 10Legoktm) [11:17:40] (03Merged) 10jenkins-bot: phpcs.xml: Use normal exclusion syntax [integration/docroot] - 10https://gerrit.wikimedia.org/r/401078 (owner: 10Legoktm) [11:17:46] (03CR) 10jenkins-bot: phpcs.xml: Use normal exclusion syntax [integration/docroot] - 10https://gerrit.wikimedia.org/r/401078 (owner: 10Legoktm) [11:19:27] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/401080 (owner: 10Legoktm) [11:20:47] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/401080 (owner: 10Legoktm) [11:22:26] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Handle cases when the dump file already exists - https://phabricator.wikimedia.org/T183667#3864150 (10eflyjason) I assume that with > If the same file already exists in the folder : > - If the filename doesn't contain `la... [11:23:34] 10Pywikibot-Other-scripts, 10Pywikibot-core: download_dump.py: Support for "date specified" dumps - https://phabricator.wikimedia.org/T183789#3863772 (10eflyjason) I think if the user don't specify the `-revision` we will assume that the revision is latest and find out the latest date from the site. See T18366... [11:29:03] 10Readers-Web-Backlog, 10Vector, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), 10Readers-Web-Kanban-Board, 10Technical-Debt: Remove $wgVectorExperimentalPrintStyles from Vector codebase - https://phabricator.wikimedia.org/T178028#3864155 (10phuedx) The changes for {T183640} have been me... [11:33:29] (03CR) 10Jonas Kress (WMDE): "Works fine except for arrow navigation." [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [11:36:38] (03CR) 10Eflyjason: "By "navigate columns" do you mean select the text on the right or?" [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [11:43:59] (03CR) 10Urbanecm: [C: 031] wikimania2017: closing the wiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/396581 (https://phabricator.wikimedia.org/T182493) (owner: 10MarcoAurelio) [11:44:50] (03CR) 10Urbanecm: [C: 031] "LGTM" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/400682 (https://phabricator.wikimedia.org/T183764) (owner: 10Jayprakash12345) [11:48:01] 10Wikimedia-Site-requests, 10Spanish-Sites, 10User-MarcoAurelio, 10Wikimedia-maintenance-script-run: Set uca-es-u-kn as category collation for es.wikipedia - https://phabricator.wikimedia.org/T183802#3864157 (10MarcoAurelio) p:05Triage>03Low [11:52:26] (03PS5) 10MarcoAurelio: Close wikimania2017.wikimedia.org [mediawiki-config] - 10https://gerrit.wikimedia.org/r/396581 (https://phabricator.wikimedia.org/T182493) [11:53:57] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864174 (10Rameho) [11:54:28] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864183 (10Rameho) [11:55:26] (03Draft1) 10MarcoAurelio: Set category collation to uca-es-u-kn for eswiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/401081 (https://phabricator.wikimedia.org/T183802) [11:55:29] (03PS2) 10MarcoAurelio: Set category collation to uca-es-u-kn for eswiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/401081 (https://phabricator.wikimedia.org/T183802) [11:56:50] (03PS7) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [11:57:11] 10AutoWikiBrowser, 10WorkType-NewFunctionality: [Migrated] Beep sound when done - https://phabricator.wikimedia.org/T100616#1316683 (10Himanshuc3) I am **//new//** to Wikimedia. I've setup the core repo. What else repos do I need to setup to work on this issue? PEACE. [11:57:49] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Spanish-Sites, 10User-MarcoAurelio, 10Wikimedia-maintenance-script-run: Set uca-es-u-kn as category collation for es.wikipedia - https://phabricator.wikimedia.org/T183802#3864189 (10MarcoAurelio) As for the script, it should be run for all rows with `--for... [11:58:29] (03CR) 10jerkins-bot: [V: 04-1] Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [11:59:54] (03PS12) 10MarcoAurelio: Actually mark abusefilter creations as such in the AbuseFilter log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/384496 (https://phabricator.wikimedia.org/T178283) [12:01:26] (03PS1) 10Tpt: Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 [12:02:39] (03CR) 10Tpt: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [12:02:53] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3864191 (10kai.nissen) [12:03:20] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3848372 (10kai.nissen) [12:05:36] (03CR) 10Jonas Kress (WMDE): "I would expect it to behave similar to spreadsheet navigation in libre office or google docs." [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [12:10:01] 10WMDE-Fun-Team, 10WMDE-Fundraising-Funban-2: Thank You banner (2) - https://phabricator.wikimedia.org/T183538#3864195 (10kai.nissen) I changed the background images to prevent that white space and changed the button text in mobile view. I also deployed the current status to meta again. @Stefan_Schneider_WMDE... [12:11:21] (03CR) 10Xqt: "Please ammend your pathes while keeping the Change-Id instead of uploading it as a new patch set every time" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401011 (owner: 10Eisenhaus335) [12:11:43] (03Abandoned) 10Xqt: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400905 (owner: 10Eisenhaus335) [12:11:45] (03CR) 10Jonas Kress (WMDE): "When I press ctr+shift+r page should reload." [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [12:11:50] (03Abandoned) 10Xqt: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400926 (owner: 10Eisenhaus335) [12:11:58] (03Abandoned) 10Xqt: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400943 (owner: 10Eisenhaus335) [12:12:08] (03Abandoned) 10Xqt: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400956 (owner: 10Eisenhaus335) [12:12:15] (03Abandoned) 10Xqt: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401002 (owner: 10Eisenhaus335) [12:12:27] (03Abandoned) 10Xqt: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401003 (owner: 10Eisenhaus335) [12:12:41] (03Abandoned) 10Xqt: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401006 (owner: 10Eisenhaus335) [12:12:49] (03Abandoned) 10Xqt: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401007 (owner: 10Eisenhaus335) [12:12:59] (03Abandoned) 10Xqt: Create editor_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401010 (owner: 10Eisenhaus335) [12:13:15] (03CR) 10Rafidaslam: Implement basic keyboard accessibility for Query.Wikidata.org (031 comment) [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [12:13:59] (03Abandoned) 10Xqt: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400465 (owner: 10Eisenhaus335) [12:18:16] (03PS8) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [12:23:53] 10MediaWiki-General-or-Unknown, 10Wikidata: Links from Wikidata generate errors on huWiki - https://phabricator.wikimedia.org/T183804#3864197 (10Bencemac) [12:30:02] (03CR) 10Xqt: [C: 04-1] "please rebase it to master branch" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401011 (owner: 10Eisenhaus335) [12:30:52] (03CR) 10Xqt: [C: 04-1] "Please rebase it to master branch" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400991 (owner: 10Eisenhaus335) [12:42:20] (03CR) 10Ladsgroup: [C: 032] Properly load collapsible sitelinks CSS exactly when needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400684 (https://phabricator.wikimedia.org/T175492) (owner: 10Thiemo Kreuz (WMDE)) [12:53:29] (03Merged) 10jenkins-bot: Properly load collapsible sitelinks CSS exactly when needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400684 (https://phabricator.wikimedia.org/T175492) (owner: 10Thiemo Kreuz (WMDE)) [12:54:43] (03CR) 10jenkins-bot: Properly load collapsible sitelinks CSS exactly when needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400684 (https://phabricator.wikimedia.org/T175492) (owner: 10Thiemo Kreuz (WMDE)) [13:04:49] (03CR) 10Jack Phoenix: [C: 032] "This is clearly an improvement over the status quo so I'm more than happy to +2 this, but we should see if we could in the future make Use" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 (owner: 10SamanthaNguyen) [13:06:31] (03Merged) 10jenkins-bot: Separate styles for Special:UploadAvatar into a separate ResourceLoader module [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 (owner: 10SamanthaNguyen) [13:06:56] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864210 (10Rameho) [13:07:00] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3864211 (10tmletzko) all banners in CN are not device specific. that means in the end we have one tracking for CTRL and VAR on .org, right? @kai.nissen [13:13:14] 10WMDE-Fun-Team, 10WMDE-Fundraising-Funban-2: Thank You banner (2) - https://phabricator.wikimedia.org/T183538#3864214 (10Verena) Sieht gut aus, danke! [13:14:34] 10User-Addshore, 10WMDE-New-Editors-Banner-Campaigns (Banner-Campaign-Thanks-2018): Deploy 'hack' patch & logging for tracking user registrations and guided tour - https://phabricator.wikimedia.org/T182794#3864215 (10Verena) @Addshore Will you be able to deploy the patch in time? [13:17:21] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864216 (10Rameho) [13:21:31] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864217 (10Aklapper) 05Open>03Invalid Welcome to Wikimedia's Phabricator instance. Wikimedia does not develop Phabricator. To report bugs about Phabricator, you need to report them to the Phabricator developers: ht... [13:23:51] 10Cite, 10MediaWiki-General-or-Unknown, 10Wikidata: Links from Wikidata generate errors on huWiki - https://phabricator.wikimedia.org/T183804#3864220 (10Tacsipacsi) Seems more like a bug in the Cite extension for me. [13:27:19] 10Pywikibot-core, 10Easy: Add expiry option in protect.py - https://phabricator.wikimedia.org/T183805#3864222 (10Mpaa) [13:27:55] 10Cite, 10MediaWiki-General-or-Unknown, 10Wikidata: Citations from Wikidata generate errors on huWiki: "Invalid tag; name defined multiple times with different content" - https://phabricator.wikimedia.org/T183804#3864232 (10Aklapper) [13:27:59] 10Cite, 10Wikidata: Citations from Wikidata generate errors on huWiki: "Invalid tag; name defined multiple times with different content" - https://phabricator.wikimedia.org/T183804#3864197 (10Aklapper) [13:28:05] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3864234 (10tmletzko) * on wp.de the message within the progress bar is missing * on the landingpage the sentence "Privatpersonen können Fördermitglied oder aktives Mitglied... [13:31:28] 10Pywikibot-core, 10Easy: Add expiry option in protect.py - https://phabricator.wikimedia.org/T183805#3864237 (10Billinghurst) [13:31:30] 10Pywikibot-Other-scripts, 10Patch-For-Review: Set expiry date for page protection in protect.py - https://phabricator.wikimedia.org/T183796#3864240 (10Billinghurst) [13:31:32] 10Pywikibot-core, 10Easy: Add expiry option in protect.py - https://phabricator.wikimedia.org/T183805#3864241 (10Mpaa) [13:31:34] 10Pywikibot-Other-scripts, 10Patch-For-Review: Set expiry date for page protection in protect.py - https://phabricator.wikimedia.org/T183796#3864242 (10Mpaa) [13:37:28] (03CR) 10Mpaa: protect.py: Add expiry parameter (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400977 (https://phabricator.wikimedia.org/T183796) (owner: 10Zhuyifei1999) [13:39:02] 10Cite, 10Math: Many articles containing UNIQ--postMath-00000001-QINU - https://phabricator.wikimedia.org/T138453#2400797 (10Tacsipacsi) It’s not only ``s: [[https://hu.wiktionary.org/wiki/koszinusztétel|huwiktionary:koszinusztétel]] produced the same error when a template called a nonexistent Lua module... [13:43:55] 10Cite: Error using {{#tag:references|group=x}}: Invalid tag; no input is allowed. Use - https://phabricator.wikimedia.org/T17839#3864245 (10Tacsipacsi) [13:54:23] (03CR) 10Albert221: Add popup with score stuff (033 comments) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [14:06:25] (03CR) 10Seb35: "Thanks for merging!" [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/393010 (https://phabricator.wikimedia.org/T142127) (owner: 10Seb35) [14:10:17] 10Discovery, 10Wikidata, 10Wikidata-Query-Service, 10Easy, and 2 others: Some areas of Query Service are not translatable - https://phabricator.wikimedia.org/T171636#3471672 (10Liuxinyu970226) The "ms" part of "some results in some ms" seems to be from CLDR? [14:11:17] 10MediaWiki-extensions-HitCounters, 10Patch-For-Review: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference" - https://phabricator.wikimedia.org/T142127#3864251 (10Seb35) 05Open>03Resolved a:03Seb35 [14:15:53] (03PS1) 10Anpans: Provide Test for site.botusers() method #GCI2017 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 [14:17:41] (03CR) 10jerkins-bot: [V: 04-1] Provide Test for site.botusers() method #GCI2017 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 (owner: 10Anpans) [14:20:16] 10Diffusion, 10Gerrit: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#3863848 (10Paladox) @Legoktm hi, if the repo is not frequently updated, the time it takes for it to check for updates gets increased. This is to prevent the phabricator host f... [14:20:48] 10Diffusion, 10Gerrit: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#3864255 (10Paladox) cc @mmodell. [14:23:36] 10Diffusion, 10Gerrit: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#3864257 (10mmodell) I wouldn't be apposed to integrating something in gerrit to trigger the updates. Phabricator tries to scale it's update frequency based on the commit frequ... [14:29:16] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3864258 (10kai.nissen) >>! In T183263#3864211, @tmletzko wrote: > all banners in CN are not device specific. that means in the end we have one tracking for CTRL and VAR on .... [14:38:29] (03PS2) 1001tonythomas: Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [14:40:38] 10Africa-Wikimedia-Developers, 10MediaWiki-extensions-SendGrid: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3864259 (10BamLifa) @ >>! In T176575#3862798, @D3r1ck01 wrote: >>>! In T176575#3858900, @BamLifa wrote: >> @D3r1ck01 I am ready to improve the README.... [14:43:16] (03PS9) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [14:44:18] (03CR) 10jerkins-bot: [V: 04-1] Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [14:44:56] (03CR) 1001tonythomas: [C: 032] Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [14:45:19] (03PS10) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [14:45:51] 10Africa-Wikimedia-Developers, 10MediaWiki-extensions-SendGrid: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3864263 (10D3r1ck01) Okay! Looking forward to your patch :) Happy New Year to you too :) [14:46:00] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3864265 (1001tonythomas) [14:46:01] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183620#3864264 (1001tonythomas) 05Open>03Resolved [14:46:14] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3858732 (1001tonythomas) [14:46:17] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183618#3864266 (1001tonythomas) 05Open>03Resolved [14:46:39] (03Merged) 10jenkins-bot: Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [14:46:46] (03Abandoned) 10Multichill: Speeding up touch.py by setting async=True [pywikibot/core] - 10https://gerrit.wikimedia.org/r/141682 (owner: 10Nullzero) [14:47:06] (03CR) 10jerkins-bot: [V: 04-1] Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [14:48:01] (03Abandoned) 10Multichill: WIP: Make Family.languages_by_size dynamic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/150791 (https://phabricator.wikimedia.org/T78396) (owner: 10John Vandenberg) [14:48:14] (03Abandoned) 10Multichill: Add requests versions to build matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/219488 (owner: 10John Vandenberg) [14:48:27] (03Abandoned) 10Multichill: [L10N] Add needed template for de-wiki [pywikibot/core] - 10https://gerrit.wikimedia.org/r/238732 (owner: 10Xqt) [14:48:37] (03PS11) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [14:48:39] (03Abandoned) 10Multichill: [WIP] EverySiteBot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/246213 (owner: 10John Vandenberg) [14:48:52] (03Abandoned) 10Multichill: add option to detect edited section automagically [pywikibot/core] - 10https://gerrit.wikimedia.org/r/118795 (https://phabricator.wikimedia.org/T67989) (owner: 10Ricordisamoa) [14:49:00] (03Abandoned) 10Multichill: Add tests for Claim fromJSON-methods [pywikibot/core] - 10https://gerrit.wikimedia.org/r/247041 (owner: 10Tobias47n9e) [14:49:00] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `addNewsletterIssue` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183806#3864272 (1001tonythomas) [14:49:07] (03Abandoned) 10Multichill: Changes done to solve processing time issue [pywikibot/core] - 10https://gerrit.wikimedia.org/r/312739 (owner: 10Ankit.0905) [14:49:21] (03Abandoned) 10Multichill: [bugfix] Use RangeMessage map xml file from International ISBN Agency [pywikibot/core] - 10https://gerrit.wikimedia.org/r/209176 (https://phabricator.wikimedia.org/T60942) (owner: 10Xqt) [14:49:28] (03Abandoned) 10Multichill: [WIP] Add label parameter to Page.title() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/148349 (owner: 10Xqt) [14:49:31] (03PS3) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [14:49:42] (03Abandoned) 10Multichill: Move reflinks stop page checker in Bot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/166395 (owner: 10John Vandenberg) [14:49:53] (03Abandoned) 10Multichill: [FEAT] More flexible threaded generators [pywikibot/core] - 10https://gerrit.wikimedia.org/r/186610 (https://phabricator.wikimedia.org/T85667) (owner: 10XZise) [14:50:02] (03Abandoned) 10Multichill: Porting overcat_simple_filter.py from compat to core/scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/185673 (https://phabricator.wikimedia.org/T66876) (owner: 10Prianka) [14:50:30] (03Abandoned) 10Multichill: Add Travis OSX build [pywikibot/core] - 10https://gerrit.wikimedia.org/r/203794 (owner: 10John Vandenberg) [14:50:41] (03Abandoned) 10Multichill: [WIP|BREAKING] Unbreak entity types [pywikibot/core] - 10https://gerrit.wikimedia.org/r/202661 (owner: 10Ricordisamoa) [14:50:48] (03Abandoned) 10Multichill: Force tests to run in simulation mode by default [pywikibot/core] - 10https://gerrit.wikimedia.org/r/206069 (owner: 10John Vandenberg) [14:50:54] (03Abandoned) 10Multichill: Merging tag_commons.py with nowcommons.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/181354 (owner: 10Prianka) [14:51:09] (03CR) 10jerkins-bot: [V: 04-1] Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [14:51:21] (03Abandoned) 10Multichill: Multi-session cookie jar [pywikibot/core] - 10https://gerrit.wikimedia.org/r/209873 (https://phabricator.wikimedia.org/T67196) (owner: 10John Vandenberg) [14:51:28] (03Abandoned) 10Multichill: support Extension:TemplateData for Page and Site objects [pywikibot/core] - 10https://gerrit.wikimedia.org/r/118983 (owner: 10Ricordisamoa) [14:51:36] (03Abandoned) 10Multichill: improvements to match_images.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/183519 (owner: 10Ricordisamoa) [14:51:56] (03Abandoned) 10Multichill: WIP: flickrripper batch upload [pywikibot/core] - 10https://gerrit.wikimedia.org/r/181126 (owner: 10Anshoe) [14:52:08] (03Abandoned) 10Multichill: [FEAT] Configuration classes [pywikibot/core] - 10https://gerrit.wikimedia.org/r/186638 (owner: 10XZise) [14:52:22] (03CR) 10Xqt: Provide Test for site.botusers() method #GCI2017 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 (owner: 10Anpans) [14:53:01] 10WMDE-Design, 10Wikidata, 10Wikidata Query UI, 10Design: Add highlight and selection feature for query result table for Query.Wikidata.org - https://phabricator.wikimedia.org/T183807#3864290 (10eflyjason) [14:53:04] (03CR) 10Xqt: Provide Test for site.botusers() method #GCI2017 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 (owner: 10Anpans) [14:53:25] (03Abandoned) 10Multichill: Simplify QueryGenerator.__iter__ flow control [pywikibot/core] - 10https://gerrit.wikimedia.org/r/176013 (owner: 10John Vandenberg) [14:53:32] (03Abandoned) 10Multichill: Allow some Claim methods to be performed locally [pywikibot/core] - 10https://gerrit.wikimedia.org/r/176934 (https://phabricator.wikimedia.org/T57148) (owner: 10John Vandenberg) [14:53:37] (03Abandoned) 10Multichill: Bug:T77968 Skip search tests if search is disabled [pywikibot/core] - 10https://gerrit.wikimedia.org/r/180409 (owner: 10Maverick) [14:53:39] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getNewsletterSubscribersCount` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183808#3864304 (1001tonythomas) [14:53:42] (03Abandoned) 10Multichill: Preloading: workaround problems with api module [pywikibot/core] - 10https://gerrit.wikimedia.org/r/177800 (owner: 10John Vandenberg) [14:53:49] (03Abandoned) 10Multichill: @disallow_redirect [pywikibot/core] - 10https://gerrit.wikimedia.org/r/175408 (https://phabricator.wikimedia.org/T58188) (owner: 10John Vandenberg) [14:53:57] (03Abandoned) 10Multichill: Generic preloading of page data [pywikibot/core] - 10https://gerrit.wikimedia.org/r/172577 (owner: 10John Vandenberg) [14:54:01] (03Abandoned) 10Multichill: [WIP] Wikibase: load raw JSON from loadrevisions [pywikibot/core] - 10https://gerrit.wikimedia.org/r/137399 (owner: 10John Vandenberg) [14:54:07] (03Abandoned) 10Multichill: Use source for __init__ of Page subclasses [pywikibot/core] - 10https://gerrit.wikimedia.org/r/153759 (owner: 10John Vandenberg) [14:54:16] (03Abandoned) 10Multichill: Add main() to makecat [pywikibot/core] - 10https://gerrit.wikimedia.org/r/155231 (owner: 10John Vandenberg) [14:54:23] (03Abandoned) 10Multichill: Add {{Filehistory}} support to imagetransfer [pywikibot/core] - 10https://gerrit.wikimedia.org/r/151576 (owner: 10John Vandenberg) [14:54:28] (03Abandoned) 10Multichill: bot help: list site configuration parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/233211 (owner: 10Merlijn van Deen) [14:55:55] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getPublishersFromID` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183809#3864316 (1001tonythomas) [14:57:49] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183810#3864326 (1001tonythomas) [14:59:33] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183811#3864339 (1001tonythomas) [15:01:40] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getSubscribersFromID` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183812#3864351 (1001tonythomas) [15:01:54] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/WPtouch] - 10https://gerrit.wikimedia.org/r/400717 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:02:05] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/400718 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:02:17] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/400719 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:03:07] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `newsletterExistsForMainPage` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183813#3864361 (1001tonythomas) [15:03:10] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/WPtouch] - 10https://gerrit.wikimedia.org/r/400717 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:03:19] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/400718 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:03:25] (03CR) 10Anpans: "Lol sorry." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 (owner: 10Anpans) [15:03:31] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/400719 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:04:51] (03CR) 10Florianschmidtwelzow: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:04:59] 10MediaWiki-extensions-Newsletter, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)): Remove code duplication in EditPage and NewsletterContentUpdate - https://phabricator.wikimedia.org/T178743#3864374 (1001tonythomas) 05Open>03Resolved Oh yes. resolving then. [15:05:51] 10MediaWiki-extensions-Newsletter, 10MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), 10Patch-For-Review: 'Wiki page to be linked as main page' field in the 'Create Newsletter' form is unclear - https://phabricator.wikimedia.org/T166002#3864377 (1001tonythomas) 05Open>03Resolved [15:05:58] (03CR) 10Florianschmidtwelzow: "This repo seems to doesn't have any CI jobs running automatically. OmkarJ: Do you want to open a phabrucator task for that, so we do not f" [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:06:22] (03CR) 10Florianschmidtwelzow: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:10:02] (03CR) 1001tonythomas: [C: 032] Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 (owner: 10Thiemo Kreuz (WMDE)) [15:11:37] (03Merged) 10jenkins-bot: Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 (owner: 10Thiemo Kreuz (WMDE)) [15:25:58] 10MediaWiki-Configuration, 10Google-Code-in-2017: [Recurring] Migrate an extension to use extension registration (extension.json) - https://phabricator.wikimedia.org/T183763#3863029 (10Fz-29) @Aklapper : I cannot find this task on https://codein.withgoogle.com/tasks/, should I add it there? I want to mentor t... [15:28:46] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3864383 (1001tonythomas) 05Resolved>03Open My patchset https... [15:29:28] (03PS1) 10OmkarJ: Add minusx to composer.json [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) [15:29:34] (03CR) 10Tpt: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [15:30:18] (03CR) 10D3r1ck01: "Why does Jenkins said it can't be merged?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) (owner: 1001tonythomas) [15:30:41] (03PS5) 1001tonythomas: Add a unit test to check newsletter creation validation [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) [15:31:40] (03CR) 10jerkins-bot: [V: 04-1] Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [15:32:25] (03PS1) 10OmkarJ: Add minusx to composer.json [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) [15:33:29] (03CR) 10D3r1ck01: "recheck" [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:34:25] (03CR) 10jerkins-bot: [V: 04-1] Add minusx to composer.json [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:35:53] 10Operations, 10ops-esams: Degraded RAID on bast3002 - https://phabricator.wikimedia.org/T183814#3864387 (10ops-monitoring-bot) [15:37:06] (03CR) 10D3r1ck01: [C: 04-1] "So you have to change the mode of the file called `TimelineTable.php` in that extension from 100755 to 100644." [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:38:01] 10Operations, 10ops-esams: Degraded RAID on lvs3001 - https://phabricator.wikimedia.org/T183815#3864391 (10ops-monitoring-bot) [15:38:50] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3864394 (10OmkarJ) [15:39:28] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to Newsletter create operations - https://phabricator.wikimedia.org/T183816#3864395 (1001tonythomas) [15:40:33] (03CR) 10D3r1ck01: "recheck" [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:41:19] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to Newsletter create operations - https://phabricator.wikimedia.org/T183816#3864405 (1001tonythomas) [15:41:27] (03CR) 10jerkins-bot: [V: 04-1] Add minusx to composer.json [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:41:57] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Add unit tests to Newsletter create operations - https://phabricator.wikimedia.org/T183816#3864395 (1001tonythomas) This should possibly go to tests/specials/SpecialNewsletterCreateTest.php as well. [15:44:02] (03PS4) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [15:44:04] (03CR) 10D3r1ck01: "SkinPerPage.php and SkinPerPage.i18n.magic.php should not be executable. Use the command I mentioned here: I2dc666d5237f689d." [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:44:45] (03CR) 10D3r1ck01: [C: 04-1] "Ops sorry, here: Ied331a7fd4a17148a." [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:45:40] (03CR) 10jerkins-bot: [V: 04-1] Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [15:46:42] (03PS5) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [15:48:15] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to API operations on Newsletter namespace - https://phabricator.wikimedia.org/T183817#3864408 (1001tonythomas) [15:49:21] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3864418 (10kai.nissen) >>! In T183263#3864234, @tmletzko wrote: > * on wp.de the message within the progress bar is missing > * on the landingpage the sentence "Privatperson... [15:51:04] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: "Thank You" campaign - https://phabricator.wikimedia.org/T183263#3864419 (10tmletzko) in addition: with one campaign, user will get to see four banners, with specific device campaign the user will see a maximum of 12 impression. Since it... [15:51:31] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to API operations on Newsletter namespace - https://phabricator.wikimedia.org/T183817#3864420 (1001tonythomas) [15:52:15] 10MediaWiki-extensions-Newsletter: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created - https://phabricator.wikimedia.org/T183818#3864421 (1001tonythomas) [15:54:44] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 41 - two pager - https://phabricator.wikimedia.org/T183748#3864431 (10tmletzko) I trust on the current results. Could you set up var as the only and last banner until the end? @kai.nissen [15:55:51] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes - https://phabricator.wikimedia.org/T183819#3864432 (1001tonythomas) [15:56:03] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created - https://phabricator.wikimedia.org/T183818#3864442 (1001tonythomas) [15:56:04] (03PS6) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [15:56:19] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Handle cases when the dump file already exists - https://phabricator.wikimedia.org/T183667#3864443 (10rafidaslam) @eflyjason I think I didn't write the task description clearly, sorry about that. I wanna clarify everythin... [16:01:07] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work - https://phabricator.wikimedia.org/T183820#3864445 (1001tonythomas) [16:02:17] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work - https://phabricator.wikimedia.org/T183821#3864455 (1001tonythomas) [16:08:54] (03PS7) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [16:12:28] 10AbuseFilter: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#3544310 (10Huji) Even when a tag is actively being used by another filter, why should it not be available to another filter? Why shouldn't multiple filters be able to assign the same tag? [16:15:48] (03PS8) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [16:16:42] (03PS9) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [16:18:38] (03PS1) 10OmkarJ: Add minusx to composer.json Change mode of TimelineTable.php to 100644 [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 [16:20:57] (03PS2) 10OmkarJ: Add minusx to composer.json Change mode of TimelineTable.php to 100644 [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 (https://phabricator.wikimedia.org/T175794) [16:26:23] 10MediaWiki-extensions-Scribunto, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10User-MarcoAurelio: "Module:" on abwiki is in Russian instead of Abkhazian - https://phabricator.wikimedia.org/T182654#3864468 (10Surprizi) Good evening! Happy new year! If there is no late, please instead of... [16:34:55] (03PS1) 10Raimond Spekking: [RestBaseUpdateJobs] Removed deleted repo [translatewiki] - 10https://gerrit.wikimedia.org/r/401087 [16:36:18] (03CR) 10Raimond Spekking: [C: 032] [RestBaseUpdateJobs] Removed deleted repo [translatewiki] - 10https://gerrit.wikimedia.org/r/401087 (owner: 10Raimond Spekking) [16:36:48] (03Merged) 10jenkins-bot: [RestBaseUpdateJobs] Removed deleted repo [translatewiki] - 10https://gerrit.wikimedia.org/r/401087 (owner: 10Raimond Spekking) [16:45:48] 10AbuseFilter, 10MediaWiki-Change-tagging: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#3864469 (10He7d3r) [16:54:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/401038 (owner: 10L10n-bot) [16:55:13] 10WMDE-Fun-Team, 10WMDE-Fundraising-Funban-2: Thank You banner (2) - https://phabricator.wikimedia.org/T183538#3864471 (10Stefan_Schneider_WMDE) Awesome - now everything is fine! Thank you guys for weekend finalisation! [16:56:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/401027 (owner: 10L10n-bot) [17:01:42] (03CR) 10Daniel Kinzler: [MCR] Revision::newFromArchiveRow remove recently added $title param (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400605 (owner: 10Addshore) [17:04:45] (03CR) 10Daniel Kinzler: [C: 032] Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [17:08:23] (03CR) 10Anomie: Only run count() on array() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400916 (https://phabricator.wikimedia.org/T182377) (owner: 10Reedy) [17:08:54] 10Wikimedia-IEG-grant-review: Group related mass DB transactions into a single one - https://phabricator.wikimedia.org/T91253#1077999 (10bd808) > This will take some work in the AbstractDao class to make it possible. @Nehajha has noted in an email that `Wikimedia\Slimapp\Dao\AbstractDao` already uses transactio... [17:10:59] (03Merged) 10jenkins-bot: Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [17:13:38] 10Cloud-Services, 10Operations, 10Toolforge, 10Traffic, 10HTTPS: Migrate tools.wmflabs.org to https only (and set HSTS) - https://phabricator.wikimedia.org/T102367#1363321 (10Bawolff) HSTS should help with (a) [17:15:00] (03PS1) 10Anomie: Add missing visibility declarations [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/401088 [17:19:18] (03PS1) 10Anomie: Add missing visibility declarations [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/401089 [17:20:07] (03CR) 10jenkins-bot: Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [17:21:25] (03CR) 10Anomie: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 (031 comment) [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [17:23:30] 10Timeless: Thumbs' captions dont display the "Enlarge" button - https://phabricator.wikimedia.org/T183822#3864480 (10Automatik) [17:24:50] 10Timeless: Thumbs' captions dont display the "Enlarge" button - https://phabricator.wikimedia.org/T183822#3864480 (10Automatik) a:03Isarra [17:45:42] (03Abandoned) 10NikiWiki: CategoryViewer: Remove 100% width from table listing [core] - 10https://gerrit.wikimedia.org/r/178068 (owner: 10NikiWiki) [17:49:55] 10VisualEditor, 10Wiktionary: Show both "edit" and "edit source" tabs/section edit links on the French Wiktionary - https://phabricator.wikimedia.org/T169741#3864491 (10Noe) Knock knock. Wiktionary is still waiting for this change. It is not to remove Visual Editor but to let IP have two choices: a fancy usel... [17:54:36] 10MediaWiki-API: Add 'fromsection' and 'tosection' to action=compare - https://phabricator.wikimedia.org/T183823#3864493 (10Anomie) [17:54:47] 10MW-1.30-release-notes, 10MediaWiki-API, 10Patch-For-Review, 10Technical-Debt: Deprecate parsing and diff options in ApiQueryRevisionsBase - https://phabricator.wikimedia.org/T164106#3221891 (10Anomie) >>! In T164106#3863104, @Od1n wrote: > But it seems there is no equivalent for the `rvsection` parameter... [17:55:00] 10MediaWiki-API: Add 'fromsection' and 'tosection' to action=compare - https://phabricator.wikimedia.org/T183823#3864493 (10Anomie) [17:56:14] (03Restored) 10ArielGlenn: hackdeploy pylint cleanup: invalid names, indentation, docstrings mostly [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280100 (owner: 10ArielGlenn) [17:56:27] (03PS2) 10ArielGlenn: hackdeploy pylint cleanup: invalid names, indentation, docstrings mostly [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280100 [17:58:59] (03CR) 10ArielGlenn: [C: 032] hackdeploy pylint cleanup: invalid names, indentation, docstrings mostly [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280100 (owner: 10ArielGlenn) [18:02:07] (03PS1) 10Anomie: ApiComparePages: Add 'fromsection' and 'tosection' parameters [core] - 10https://gerrit.wikimedia.org/r/401090 (https://phabricator.wikimedia.org/T183823) [18:07:18] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864513 (10MZMcBride) Thanks for working on this. I'd prefer that the Special page be renamed to "Special:GlobalAccount" or maybe even "Special:AccountInfo" over keepin... [18:08:25] (03Restored) 10ArielGlenn: prep-dumps-deploy full pylint and pep8 cleanup [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280101 (owner: 10ArielGlenn) [18:08:33] (03PS2) 10ArielGlenn: prep-dumps-deploy full pylint and pep8 cleanup [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280101 [18:08:38] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864514 (10Reception123) Since this is a WMF-used extension, I assume someone needs to decide this / approve? [18:09:16] (03CR) 10Anomie: "> Something needs to be fixed in one of the files because there is" [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [18:09:54] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864515 (10MZMcBride) >>! In T73275#3864514, @Reception123 wrote: > Since this is a WMF-used extension, I assume someone needs to decide this / approve? Not really. It... [18:10:12] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for or rename Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864516 (10MZMcBride) [18:10:21] (03CR) 10ArielGlenn: [C: 032] prep-dumps-deploy full pylint and pep8 cleanup [dumps] (ariel) - 10https://gerrit.wikimedia.org/r/280101 (owner: 10ArielGlenn) [18:10:33] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for or rename Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864517 (10Reception123) Well it should probably be discussed more anyway :D [18:10:47] (03PS3) 10Zhuyifei1999: protect.py: Add expiry parameter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400977 (https://phabricator.wikimedia.org/T183796) [18:13:29] (03PS1) 10Rafidaslam: download_dump: Add -revision parameter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401091 (https://phabricator.wikimedia.org/T183789) [18:14:48] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for or rename Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864521 (10MZMcBride) >>! In T73275#3864517, @Reception123 wrote: > Well it should probably be discussed more anyway :D All right. This task has been sitting... [18:17:05] (03PS2) 10Rafidaslam: download_dump: Add -revision parameter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401091 (https://phabricator.wikimedia.org/T183789) [18:23:12] (03CR) 10Zhuyifei1999: download_dump: Add -revision parameter (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401091 (https://phabricator.wikimedia.org/T183789) (owner: 10Rafidaslam) [18:41:41] (03PS3) 10Rafidaslam: download_dump: Add -revision parameter [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401091 (https://phabricator.wikimedia.org/T183789) [18:48:33] (03CR) 10Volans: [C: 04-1] "Thanks for taking care of this. I've a couple of main comments and more smaller ones inline." (0313 comments) [puppet] - 10https://gerrit.wikimedia.org/r/400615 (https://phabricator.wikimedia.org/T82937) (owner: 10Dzahn) [18:50:08] (03PS2) 10Umherirrender: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [18:50:12] (03CR) 10Umherirrender: [C: 032] Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [18:56:41] (03PS10) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [18:56:58] (03Merged) 10jenkins-bot: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [18:58:02] (03CR) 10Umherirrender: [C: 032] Fix @covers tags [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400807 (owner: 10Legoktm) [18:58:52] (03CR) 10Ebe123: [C: 032] Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [18:59:34] (03CR) 10Ebe123: [C: 032] "Even though it is not perfect on Safari, it works well." [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [19:00:50] (03Merged) 10jenkins-bot: Fix @covers tags [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400807 (owner: 10Legoktm) [19:00:52] (03Merged) 10jenkins-bot: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [19:05:08] (03CR) 10jenkins-bot: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [19:07:26] (03PS1) 10Phantom42: Create Special:GloballyUnusedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) [19:07:37] 10Diffusion, 10Gerrit, 10Release-Engineering-Team (Someday): Diffusion links are broken from within Gerrit - https://phabricator.wikimedia.org/T177277#3864530 (10Paladox) The repo exists now in diffusion. https://phabricator.wikimedia.org/r/branch/maps/kartotherian;refs/heads/master works and redirects to t... [19:07:57] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/400846 (owner: 10Libraryupgrader) [19:08:02] (03CR) 10Umherirrender: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/400846 (owner: 10Libraryupgrader) [19:09:08] 10Community-Tech, 10Tool-Pageviews: Allow importing of watchlist into Massviews (requires OAuth) - https://phabricator.wikimedia.org/T168546#3864532 (10He7d3r) [19:11:40] (03CR) 10Umherirrender: [V: 032] "T178517" [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/400896 (owner: 10Libraryupgrader) [19:12:38] 10Gerrit: Gerrit word diff is really bad at matching - https://phabricator.wikimedia.org/T181961#3807855 (10Paladox) Gerrit uses a java + codemirror (which is javascript). The merge view uses the google-diff-match-patch library https://code.google.com/archive/p/google-diff-match-patch/ . https://github.com/code... [19:16:04] (03PS2) 10Phantom42: Create Special:GloballyUnusedFiles page [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) [19:18:16] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [19:19:02] (03CR) 10Umherirrender: "Try to update the whitespace issue" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [19:25:10] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400947 (owner: 10Libraryupgrader) [19:26:03] 10GlobalUsage, 10MediaWiki-Special-pages, 10Multimedia, 10Google-Code-in-2017, 10Patch-For-Review: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3864536 (10Phantom42) > Have 2 wikis setup, one of which setup like "Commons"... [19:26:14] (03CR) 10Ebe123: "Message thing. Please read https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for the commit." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [20:00:27] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [skins/apex] - 10https://gerrit.wikimedia.org/r/400995 (owner: 10Libraryupgrader) [20:00:40] (03CR) 10Umherirrender: "Fixed whitespace issue" [skins/apex] - 10https://gerrit.wikimedia.org/r/400995 (owner: 10Libraryupgrader) [20:02:31] 10ContentTranslation: ContentTranslator tries to load an old published translation when starting a new translation of the same article - https://phabricator.wikimedia.org/T183824#3864539 (10He7d3r) [20:03:23] (03CR) 10Umherirrender: [C: 031] Add @covers tags for more tests [core] - 10https://gerrit.wikimedia.org/r/400780 (owner: 10Legoktm) [20:06:16] (03PS1) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:06:46] (03CR) 10Umherirrender: "Please amend your first patch set and not uploading a new one" [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [20:07:29] (03CR) 10Albert221: [C: 04-1] Add minusx to composer.json Change mode of TimelineTable.php to 100644 (031 comment) [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [20:07:53] (03CR) 10jerkins-bot: [V: 04-1] Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [20:09:11] (03PS2) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:09:22] 10ConfirmEdit (CAPTCHA extension), 10Technical-Debt: Define an interface for CAPTCHA modules - https://phabricator.wikimedia.org/T178597#3864552 (10Florian) When I think about that, it isn't really suitable for GCI :/ [20:10:32] (03CR) 10Umherirrender: [C: 032] Add missing visibility declarations [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/401088 (owner: 10Anomie) [20:12:00] (03Merged) 10jenkins-bot: Add missing visibility declarations [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/401088 (owner: 10Anomie) [20:12:55] (03CR) 10Umherirrender: [C: 032] Add missing visibility declarations [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/401089 (owner: 10Anomie) [20:13:44] (03CR) 10Umherirrender: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [20:14:25] (03Merged) 10jenkins-bot: Add missing visibility declarations [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/401089 (owner: 10Anomie) [20:15:52] 10Diffusion, 10Gerrit: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#3864554 (10Legoktm) 5 minutes is significantly better than 2 hours. The delayed polling thing makes sense I suppose, except we do have a push mechanism available to us and don... [20:20:55] (03CR) 10Ebe123: "Almost there!" (034 comments) [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [20:22:39] 10MediaWiki-extensions-Translate, 10Easy: Fix dropdown position for autocomplete suggestions for Special:SearchTranslations - https://phabricator.wikimedia.org/T178872#3705775 (10Florian) Deleted task in GCI. [20:23:29] 10ContentTranslation: ContentTranslation should not reload the whole page after 10 seconds (FOUC?) - https://phabricator.wikimedia.org/T183825#3864557 (10He7d3r) [20:26:11] 10ContentTranslation: ContentTranslator tries to load an old published translation when starting a new translation of the same article - https://phabricator.wikimedia.org/T183824#3864567 (10He7d3r) [20:26:32] (03CR) 10Umherirrender: "recheck" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401053 (owner: 10Tpt) [20:38:55] (03PS1) 10NikiWiki: Specials: Add LibraryInfoHook [core] - 10https://gerrit.wikimedia.org/r/401094 [20:39:26] (03PS3) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:45:28] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/apex] - 10https://gerrit.wikimedia.org/r/401095 (https://phabricator.wikimedia.org/T153505) [20:46:21] (03PS23) 10Huji: Links to blocked/locked users should have a class indicating so [core] - 10https://gerrit.wikimedia.org/r/370137 (https://phabricator.wikimedia.org/T172348) [20:46:29] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/Truglass] - 10https://gerrit.wikimedia.org/r/401096 (https://phabricator.wikimedia.org/T153505) [20:47:14] (03CR) 10Huji: "@Gergo: I removed the caching, it should be ready to merge now." [core] - 10https://gerrit.wikimedia.org/r/370137 (https://phabricator.wikimedia.org/T172348) (owner: 10Huji) [20:48:02] (03PS82) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [20:48:53] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/401097 (https://phabricator.wikimedia.org/T153505) [20:49:33] 10AbuseFilter, 10Security-Team, 10Stewards-and-global-tools, 10Patch-For-Review: Log accessing private information by those with 'abusefilter-private' permission - https://phabricator.wikimedia.org/T152934#3864571 (10Huji) p:05High>03Unbreak! We have an LTA actively harassing the fawiki community, who... [20:52:07] (03CR) 10Florianschmidtwelzow: [C: 04-1] Check the dismissed cookie on client-side before calling geolocation (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/400099 (https://phabricator.wikimedia.org/T183657) (owner: 10Martineznovo) [20:52:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Sorry for the late review :(" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/400099 (https://phabricator.wikimedia.org/T183657) (owner: 10Martineznovo) [20:54:11] (03PS4) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:55:54] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/apex] - 10https://gerrit.wikimedia.org/r/401095 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:56:03] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/Truglass] - 10https://gerrit.wikimedia.org/r/401096 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:56:11] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/401097 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:57:05] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/apex] - 10https://gerrit.wikimedia.org/r/401095 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:57:07] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/Truglass] - 10https://gerrit.wikimedia.org/r/401096 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:57:19] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/401097 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:58:41] (03CR) 10Legoktm: "I'm pretty skeptical about trying to hide libraries like this. What about the API which exposes library versions? Or even wikis that keep " [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [20:58:53] (03CR) 10Florianschmidtwelzow: [C: 032] Specials: Add LibraryInfoHook [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [20:59:31] (03CR) 10Florianschmidtwelzow: Specials: Add LibraryInfoHook [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [21:01:15] (03PS2) 10Legoktm: Use MediaWikiCoversValidator for tests that don't use MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/400748 [21:02:16] (03CR) 10Florianschmidtwelzow: "Ok, having legoktm's comment in mind, I think you should go with the solution he proposes, instead of semi-hiding this information using a" [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [21:03:37] (03PS5) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [21:05:53] (03CR) 10Legoktm: Improve (weak and strict) type hints invarious places (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [21:06:38] (03CR) 10NikiWiki: "I added the hook to keep the class consistent, as it has hooks to overwrite *all* other information." [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [21:08:55] (03CR) 10Florianschmidtwelzow: "I'm wondering why this is needed (other builds, excluding for I469735e1cb5c5c2527d5db4456376c979e5b60ad are passing). Also, the log in the" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/400263 (owner: 10Umherirrender) [21:09:01] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 41 - two pager - https://phabricator.wikimedia.org/T183748#3864577 (10kai.nissen) ended on 2017-12-30 18:15 CET [21:09:16] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 41 - two pager - https://phabricator.wikimedia.org/T183748#3864578 (10kai.nissen) 05Open>03Resolved [21:09:38] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 39 - dark blue - https://phabricator.wikimedia.org/T183715#3864579 (10kai.nissen) 05Open>03Resolved [21:09:57] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 31 - direct redirect - https://phabricator.wikimedia.org/T182567#3864580 (10kai.nissen) 05Open>03Resolved [21:10:46] (03CR) 10Brian Wolff: [C: 04-1] "Overall this looks very good. I havent reviewed this fully yet, but a few small things" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) (owner: 10Phantom42) [21:11:31] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 40 - campaign enhancement - https://phabricator.wikimedia.org/T183742#3864581 (10kai.nissen) 05Open>03Resolved [21:11:51] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 33 - Redesign vs. Pommes Schranke - https://phabricator.wikimedia.org/T182974#3864582 (10kai.nissen) 05Open>03Resolved [21:11:59] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 34 - animated underlining (option B) - https://phabricator.wikimedia.org/T182977#3864583 (10kai.nissen) 05Open>03Resolved [21:12:37] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Sprint-12: Banner 09 - less copy - https://phabricator.wikimedia.org/T177392#3864584 (10kai.nissen) 05Open>03Resolved [21:12:48] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Sprint-12: Banner Test 08 (Jimmy) - https://phabricator.wikimedia.org/T176727#3864585 (10kai.nissen) 05Open>03Resolved [21:12:58] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Sprint-10, 10WMDE-Fundraising-Sprint-11: Banner 07 - 3 vs 5 intervals (retest) - https://phabricator.wikimedia.org/T175259#3864586 (10kai.nissen) 05Open>03Resolved a:05gabriel-wmde>03None [21:13:37] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: EN Banner 02 form arrow - https://phabricator.wikimedia.org/T181389#3864588 (10kai.nissen) 05Open>03Resolved [21:13:52] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Banner Backup Campaigns - https://phabricator.wikimedia.org/T180945#3864589 (10kai.nissen) 05Open>03Resolved [21:13:54] (03PS103) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [21:15:18] (03CR) 10Florianschmidtwelzow: "I personally agree, that having comments that does not help at all is worse then having no comment at all. However, I also think that fixi" [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [21:17:18] (03CR) 10Florianschmidtwelzow: [C: 031] "+1 from my side. I'm not sure, if the copyright header is somehow needed, though. So keeping this change open for some time so someone cou" [core] - 10https://gerrit.wikimedia.org/r/400584 (owner: 10Thiemo Kreuz (WMDE)) [21:19:10] (03CR) 10Florianschmidtwelzow: [C: 032] Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 (owner: 10Thiemo Kreuz (WMDE)) [21:19:31] (03PS2) 10Tpt: Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (https://phabricator.wikimedia.org/T182943) [21:25:16] (03Merged) 10jenkins-bot: Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 (owner: 10Thiemo Kreuz (WMDE)) [21:25:51] (03CR) 10Florianschmidtwelzow: [C: 032] Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [21:29:02] (03PS3) 10Phantom42: Create Special:GloballyUnusedFiles page [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) [21:29:51] (03PS6) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [21:29:53] (03CR) 10Phantom42: "Thank you for reviewing! I fully agree with your comments and fixed those issues!" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) (owner: 10Phantom42) [21:30:58] (03CR) 10jerkins-bot: [V: 04-1] Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [21:32:10] (03Merged) 10jenkins-bot: Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [21:33:56] (03CR) 10Legoktm: [C: 04-2] "As I said on the Cite patch, don't remove the copyright holders." [core] - 10https://gerrit.wikimedia.org/r/400584 (owner: 10Thiemo Kreuz (WMDE)) [21:34:06] (03CR) 10jenkins-bot: Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 (owner: 10Thiemo Kreuz (WMDE)) [21:34:15] (03PS7) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [21:34:34] (03CR) 10jenkins-bot: Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [21:36:09] (03CR) 10Florianschmidtwelzow: [C: 04-1] "This changes the default behaviour for all non-extsing pages to something which would evaluate to "No edit restrictions apply". This is no" [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) (owner: 10Divadsn) [21:36:30] (03CR) 10Legoktm: [C: 032] Slightly improve some type hints in PHPDoc blocks [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400573 (owner: 10Thiemo Kreuz (WMDE)) [21:38:19] 10Ladies-That-FOSS-MediaWiki, 10MediaWiki-Page-protection, 10MediaWiki-extensions-EducationProgram, 10Easy, and 3 others: wgRestrictionEdit should be defined (as an empty array) on Education Program pages - https://phabricator.wikimedia.org/T133289#2227133 (10Florian) Couldn't this be changed somewhere in... [21:38:40] (03Merged) 10jenkins-bot: Slightly improve some type hints in PHPDoc blocks [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400573 (owner: 10Thiemo Kreuz (WMDE)) [21:43:12] (03CR) 10Florianschmidtwelzow: "Having the other hooks here has the same implications as the one proposed here: YOu can still request version information of each extensio" [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [21:46:02] (03CR) 10Florianschmidtwelzow: "I agree Legoktm: If I understood @hashar correctly, his goal is to get rid of this docker container at all, so such a change may go into t" [integration/config] - 10https://gerrit.wikimedia.org/r/400002 (https://phabricator.wikimedia.org/T183643) (owner: 10Florianschmidtwelzow) [21:48:46] 10Cloud-Services: "Error 503 Backend fetch failed" on wikistream.wmflabs.org - https://phabricator.wikimedia.org/T183826#3864595 (10Framawiki) [21:50:31] (03CR) 10Umherirrender: "minus-x is a new repository added to composer.json, on of the dependency of minus-x (one of symfony/*, if needed I can search for it) is u" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/400263 (owner: 10Umherirrender) [21:56:37] (03PS1) 10Umherirrender: Use relative path in require_once [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/401098 [22:02:23] (03CR) 10Legoktm: "> I added the hook to keep the class consistent, as it has hooks to overwrite *all* other information." [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [22:02:30] (03CR) 10Umherirrender: [C: 031] "I have no idea if tests in /libs/ folder also should have no MediaWiki* inside or if that is just for the includes/libs/ folder." [core] - 10https://gerrit.wikimedia.org/r/400748 (owner: 10Legoktm) [22:08:29] (03CR) 10Legoktm: "I think it should be fine for tests/, MediaWikiCoversValidator has no dependency upon MediaWiki itself, I just named it that to match Medi" [core] - 10https://gerrit.wikimedia.org/r/400748 (owner: 10Legoktm) [22:08:47] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 [22:11:34] (03PS3) 10Umherirrender: Add "composer test" and dummy "npm test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:11:58] 10Timeless: Timeless: images (eg smileys) are not middle aligned with text - https://phabricator.wikimedia.org/T183827#3864605 (10Automatik) [22:12:49] (03CR) 10Umherirrender: "Missed by Libraryupgrader" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 (owner: 10Umherirrender) [22:15:38] (03PS8) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [22:16:13] (03PS4) 10Umherirrender: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:16:17] (03PS5) 10Umherirrender: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:16:20] (03CR) 10Umherirrender: [C: 032] Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:16:26] (03CR) 10Legoktm: [C: 032] "Weird...it looks like libraryupgrader missed this repo entirely, there's not even an error log." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 (owner: 10Umherirrender) [22:17:12] (03CR) 10Legoktm: [C: 032] "Thanks" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/400962 (owner: 10Libraryupgrader) [22:18:31] (03Merged) 10jenkins-bot: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:18:37] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 (owner: 10Umherirrender) [22:23:11] 10MediaWiki-Special-pages: Add "Previous blocks" to footer of Special:Block - https://phabricator.wikimedia.org/T183801#3864084 (10Umherirrender) A log extract is shown under this links ("This user has been blocked previously. The block log is provided below for reference: "), I am not sure if a link to the same... [22:25:22] (03PS1) 10Umherirrender: Use always tabs in composer.json [extensions/BlueSpiceAuthors] - 10https://gerrit.wikimedia.org/r/401100 [22:25:30] (03PS1) 10Umherirrender: Use always tabs in composer.json [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/401101 [22:25:43] 10AbuseFilter, 10Security-Team, 10Stewards-and-global-tools, 10Patch-For-Review: Log accessing private information by those with 'abusefilter-private' permission - https://phabricator.wikimedia.org/T152934#3864617 (10Bawolff) >>! In T152934#3864571, @Huji wrote: > We have an LTA actively harassing the fawi... [22:29:47] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/401102 [22:30:03] (03CR) 10Umherirrender: "Missed by Libraryupgrader" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/401102 (owner: 10Umherirrender) [22:34:11] (03CR) 10Albert221: [C: 031] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400947 (owner: 10Libraryupgrader) [22:34:40] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/401103 [22:41:46] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/401104 [22:41:54] (03PS9) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [22:42:52] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/401105 [22:43:23] (03CR) 10Umherirrender: "Missed by Libraryupgrader" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/401105 (owner: 10Umherirrender) [22:45:04] (03CR) 10Framawiki: "Few comments." (034 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401091 (https://phabricator.wikimedia.org/T183789) (owner: 10Rafidaslam) [22:48:36] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/401106 [22:49:51] (03CR) 10Umherirrender: "Missed by Libraryupgrader" [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/401106 (owner: 10Umherirrender) [22:51:57] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Handle cases when the dump file already exists - https://phabricator.wikimedia.org/T183667#3864621 (10Framawiki) I think solving first {T183789} is the best solution. >>! In T183667#3864443, @rafidaslam wrote: > Then the... [22:57:04] (03CR) 10Framawiki: [C: 031] protect.py: Add expiry parameter (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400977 (https://phabricator.wikimedia.org/T183796) (owner: 10Zhuyifei1999) [22:58:59] (03CR) 10Framawiki: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 (owner: 10Anpans) [23:01:33] 10MediaWiki-Codesniffer: Undefined index: scope_opener in IfElseStructureSniff - https://phabricator.wikimedia.org/T183828#3864623 (10Umherirrender) [23:02:07] (03CR) 10jerkins-bot: [V: 04-1] Provide Test for site.botusers() method #GCI2017 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 (owner: 10Anpans) [23:03:25] (03CR) 10Framawiki: [C: 04-1] "Good work, please just edit your patch to take into account our two comments." (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401083 (owner: 10Anpans) [23:04:11] (03PS10) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:06:24] (03CR) 10Framawiki: "This help page can help you: https://www.mediawiki.org/wiki/Gerrit/Getting_started, particularly the last three commands." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/401011 (owner: 10Eisenhaus335) [23:08:47] (03CR) 10Framawiki: [C: 032] Made download_dump.py download process atomic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) (owner: 10Ryan10145) [23:11:42] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017, 10Patch-For-Review: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3864634 (10Framawiki) A remark for a future patch: do you think that it's possible to remove this big loop, that makes the code... [23:12:22] (03Merged) 10jenkins-bot: Made download_dump.py download process atomic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) (owner: 10Ryan10145) [23:15:24] (03CR) 10jenkins-bot: Made download_dump.py download process atomic [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400616 (https://phabricator.wikimedia.org/T183675) (owner: 10Ryan10145) [23:20:49] (03CR) 10Ladsgroup: [C: 032] Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (https://phabricator.wikimedia.org/T182943) (owner: 10Tpt) [23:22:48] (03Merged) 10jenkins-bot: Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (https://phabricator.wikimedia.org/T182943) (owner: 10Tpt) [23:30:07] (03CR) 10SamanthaNguyen: [C: 032] "Thanks!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/401098 (owner: 10Umherirrender) [23:31:46] (03Merged) 10jenkins-bot: Use relative path in require_once [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/401098 (owner: 10Umherirrender) [23:36:03] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/401107 [23:36:20] (03CR) 10Umherirrender: "There was an error on update: T183828" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/401107 (owner: 10Umherirrender) [23:41:28] (03CR) 10Kghbln: "@Sam I have installed patch-set 5 on https://sandbox.semantic-mediawiki.org/wiki/Sp%C3%A9cial:Version so if you would like to give it some" [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/398784 (https://phabricator.wikimedia.org/T176594) (owner: 10Samwilson) [23:43:33] (03PS11) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:46:28] (03PS1) 10Umherirrender: Revert "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 [23:52:51] (03PS12) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:56:05] (03PS13) 10Albert221: Add source DL link to popup, fix $needMidi cond [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:56:19] (03PS2) 10Umherirrender: Revert some parts of "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 [23:56:24] (03PS3) 10Umherirrender: Revert some parts of "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 [23:56:38] (03CR) 10Umherirrender: [V: 032 C: 032] Revert some parts of "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 (owner: 10Umherirrender)