[00:08:54] (03PS1) 10Boboivancich: Add a label to the logout link, which is otherwise presented as <0> in MW 1.29 when UserSwitch is not allowed [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/400453 [00:10:29] (03PS1) 10Legoktm: Add tox configuration, fix flake8 issues [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400454 [00:10:31] (03PS1) 10Legoktm: Fix broken open search links [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400455 (https://phabricator.wikimedia.org/T183728) [00:10:55] (03CR) 10Legoktm: [V: 032 C: 032] Add tox configuration, fix flake8 issues [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400454 (owner: 10Legoktm) [00:22:36] (03CR) 10Legoktm: [V: 032 C: 032] Fix broken open search links [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400455 (https://phabricator.wikimedia.org/T183728) (owner: 10Legoktm) [00:26:37] (03PS1) 10Legoktm: Set open search description in the right place [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400456 [00:26:49] (03CR) 10Legoktm: [V: 032 C: 032] Set open search description in the right place [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400456 (owner: 10Legoktm) [00:27:41] 10VPS-project-codesearch, 10Patch-For-Review: OpenSearch link in code search doesn't work - https://phabricator.wikimedia.org/T183728#3862078 (10Legoktm) a:03Legoktm @Krinkle try it now? Should be all fixed. [00:35:06] 10Internet-Archive, 10Offline-Working-Group, 10Operations: Create backups of Wikimedia content in diverse geographic places - https://phabricator.wikimedia.org/T156544#3862080 (10Pine) 05Open>03stalled Can we get an update about the status of this project, please? I am marking this as "stalled" pending a... [01:30:57] 10MediaWiki-Parser: Add a magic word to identify the wiki with its name - https://phabricator.wikimedia.org/T183733#3862083 (10Cyberpower678) [01:30:57] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183618#3862094 (10divadsn) a:03divadsn Will do that now, patch coming soon :) [01:34:11] (03PS3) 10Dalba: utils.py: Use more descriptive variable names in detailed_show_warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 [01:35:05] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862096 (10Legoktm) [01:35:37] (03CR) 10Dalba: utils.py: Use more descriptive variable names in detailed_show_warning (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 (owner: 10Dalba) [01:39:25] (03PS4) 10Dalba: utils.py: Use more descriptive variable names in detailed_show_warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 [01:43:34] (03CR) 10jerkins-bot: [V: 04-1] utils.py: Use more descriptive variable names in detailed_show_warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 (owner: 10Dalba) [01:53:45] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3862098 (10divadsn) >>! In T179202#3861385, @jayvdb wrote: > Repeating some of what I put into the code review of https://github.com/python-social-auth/social-core/pull/169 > > I... [01:55:08] (03PS5) 10Samwilson: Regenerate graphs even when user is not permitted to upload [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/398784 (https://phabricator.wikimedia.org/T176594) [01:56:39] (03CR) 10Samwilson: "Good points! Fixed." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/398784 (https://phabricator.wikimedia.org/T176594) (owner: 10Samwilson) [01:56:42] (03PS5) 10Dalba: utils.py: Use more descriptive variable names in detailed_show_warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 [01:58:37] (03Abandoned) 10Isarra: Fix language and category wrapping issue [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/396809 (owner: 10Isarra) [02:24:53] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862044 (10Reedy) Do you know if this was a problem before? It uses TINYTEXT, which is 255 bytes... But, if we look at the code, it does truncate... https://github.com/wi... [02:28:55] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862101 (10Reedy) ``` > echo mb_strlen( $wgContLang->truncate( 'Unnecessary page: content was: "Hi everyone, I am translating the system messages in Translatewiki.net to S... [02:29:56] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862102 (10Reedy) [02:53:07] 10Pywikibot-core, 10Pywikibot-textlib.py, 10Patch-For-Review: Add an add_only parameter to replaceCategoryInPlace in textlib - https://phabricator.wikimedia.org/T183707#3861335 (10Dalba) It feels odd to me for a `replace_in_place` function to have an `add_only` parameter, because when `add_only` is `True` it... [02:54:18] (03PS1) 10Legoktm: Run Pygments using Python 3 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400457 (https://phabricator.wikimedia.org/T182851) [02:54:48] (03PS1) 10Legoktm: mediawiki: Ensure Python 3 is available for Pygments [puppet] - 10https://gerrit.wikimedia.org/r/400458 (https://phabricator.wikimedia.org/T182851) [02:57:27] 10SyntaxHighlight, 10MW-1.31-release, 10Patch-For-Review: SyntaxHighlight should run Pygments with Python 3 - https://phabricator.wikimedia.org/T182851#3862109 (10Legoktm) a:03Legoktm [03:03:02] (03PS1) 10Divadsn: Unit test NewsletterDb::updateDescription [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400459 (https://phabricator.wikimedia.org/T183618) [03:08:25] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3862113 (10jayvdb) @divadsn , you have three commits on https://github.com/python-social-auth/social-core/pull/169/commits ; that is unnecessary , and in gerrit world it would be... [03:18:31] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862114 (10Glendales) @Legoktm I am using Safari on an Apple iPhone 7 and an iPad Air 2, both of which give the problem. I don’t have... [03:40:20] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3862115 (10divadsn) @jayvdb but isn't it how it's supposed to be done on GitHub where you squash those commits during merge? I mean, people are always telling you not to force pus... [03:42:25] (03PS1) 10Ebe123: Remove rawAndMidi from cache options [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) [03:43:56] (03CR) 10Ebe123: "To not invalidate too many existing keys, especially as this is a follow-" [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [03:46:14] (03PS1) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [03:46:42] (03CR) 10Ebe123: "Please check I56c603483, removing logic that came from this change." [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 (owner: 10Brian Wolff) [03:47:23] (03CR) 10jerkins-bot: [V: 04-1] Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [03:53:42] 10Wikidata, 10Wikidata Query UI, 10Epic, 10Google-Code-in-2017, 10Patch-For-Review: Implement keyboard accessibility for Query.Wikidata.org - https://phabricator.wikimedia.org/T173213#3862121 (10eflyjason) `Ctrl`/`Command`+`Enter`: Run query `Esc`: Leave current input field/textarea `Alt`+`F`: Click "Fli... [03:55:06] (03CR) 10Pwirth: [C: 032] Fix use of boolean in extension.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/400418 (owner: 10Umherirrender) [03:55:32] (03CR) 10Pwirth: [C: 032] Fix register of extension in extension.json [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/400419 (owner: 10Umherirrender) [03:55:51] (03PS1) 10MarkAHershberger: Add methods to retrieve log and latest entry [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 [03:57:17] (03CR) 10jerkins-bot: [V: 04-1] Add methods to retrieve log and latest entry [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 (owner: 10MarkAHershberger) [03:58:49] (03PS2) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [04:04:55] 10MediaWiki-extensions-Score, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add version to Score hashes - https://phabricator.wikimedia.org/T49448#3862124 (10Ebe123) [04:10:51] (03PS3) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [04:10:59] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3862126 (10Pppery) [04:11:03] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate - https://phabricator.wikimedia.org/T183637#3862125 (10Pp... [04:11:46] (03PS1) 10Ebe123: Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) [04:11:59] (03CR) 10jerkins-bot: [V: 04-1] Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) (owner: 10Eflyjason) [04:12:39] 10Advanced-Search, 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3862129 (10Ebe123) [04:20:01] (03PS4) 10Eflyjason: Implement basic keyboard accessibility for Query.Wikidata.org [wikidata/query/gui] - 10https://gerrit.wikimedia.org/r/400461 (https://phabricator.wikimedia.org/T173213) [04:21:16] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate - https://phabricator.wikimedia.org/T183637#3859134 (10Ry... [04:23:06] (03PS6) 10Ryan10145: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) [04:23:17] (03PS1) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [04:26:23] 10MediaWiki-extensions-Newsletter, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)): Remove code duplication in EditPage and NewsletterContentUpdate - https://phabricator.wikimedia.org/T178743#3862140 (10Pppery) (patch was merged a more month ago) [04:26:55] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3862142 (10eflyjason) [04:29:59] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3862143 (10eflyjason) [04:44:52] (03CR) 10Aude: [WIP] Switch to load extension using MediaWiki's extension registration (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/399437 (https://phabricator.wikimedia.org/T88258) (owner: 10WMDE-leszek) [04:54:35] 10Wikidata, 10Google-Code-in-2017: Create a Wikidata fact about a Google Code-in organisation or project - https://phabricator.wikimedia.org/T182766#3862144 (10jayvdb) [04:58:12] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400465 [05:00:00] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400465 (owner: 10Eisenhaus335) [05:03:41] 10Addwiki, 10Documentation, 10Easy, 10User-Addshore: Describe in the documentation how to add a basic statement - https://phabricator.wikimedia.org/T160732#3862145 (10Dheerajmalisetty) Should I clone the wikidata seperately or is it to work in wikibase? [05:04:18] 10Addwiki, 10Documentation, 10Easy, 10User-Addshore: Describe in the documentation how to add a basic statement - https://phabricator.wikimedia.org/T160732#3862146 (10Dheerajmalisetty) Is this bug related to wikimedia? [05:28:34] (03CR) 10Xqt: [C: 032] utils.py: Use more descriptive variable names in detailed_show_warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 (owner: 10Dalba) [05:34:09] (03Merged) 10jenkins-bot: utils.py: Use more descriptive variable names in detailed_show_warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 (owner: 10Dalba) [05:37:10] (03CR) 10jenkins-bot: utils.py: Use more descriptive variable names in detailed_show_warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400400 (owner: 10Dalba) [05:52:02] 10SyntaxHighlight: Support ignoring the line attribute when attribute "line" set to "off" (or 0) - https://phabricator.wikimedia.org/T114483#1697073 (10jayvdb) The entire problem space has moved, as Wikimedia now uses Pygments. @Oetterer , are you still using the syntax highlighter that uses GeSHi ? [05:54:13] (03PS3) 10Prtksxna: statsbar: Update colors according to WikmediaUI palette [extensions/Translate] - 10https://gerrit.wikimedia.org/r/388379 [06:00:08] 10SyntaxHighlight, 10JavaScript, 10Regression, 10User-notice: No syntax highlight for large JavaScript/CSS/Lua/API pages - https://phabricator.wikimedia.org/T104109#3862149 (10jayvdb) @ori created https://people.wikimedia.org/~ori/bad.js as a test case, and 'Python' failed badly (likely Pygments with all o... [06:06:46] (03PS1) 10Prtksxna: Use findItemFromData instead getItemFromData [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400466 (https://phabricator.wikimedia.org/T76630) [06:07:07] (03CR) 10Prtksxna: [C: 04-2] "(Wait till the right version of OOUI is included in core.)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400466 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [06:07:38] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862151 (10Prtksxna) [06:13:33] (03PS1) 10Prtksxna: Use findItemFromData instead getItemFromData [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/400467 (https://phabricator.wikimedia.org/T76630) [06:13:50] (03CR) 10Prtksxna: [C: 04-2] "(Wait till the right version of OOUI is included in core.)" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/400467 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [06:14:21] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862153 (10Prtksxna) [06:16:43] (03PS1) 10Prtksxna: Use findItemFromData instead getItemFromData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/400468 (https://phabricator.wikimedia.org/T76630) [06:17:00] (03CR) 10Prtksxna: [C: 04-2] "(Wait till the right version of OOUI is included in core.)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/400468 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [06:17:22] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862155 (10Prtksxna) [06:20:27] 10MediaWiki-extensions-Score, 10Multimedia: Score doesn't output image size (width/height) - https://phabricator.wikimedia.org/T50088#3862156 (10Ebe123) [06:21:46] 10MediaWiki-extensions-Score, 10Multimedia, 10TimedMediaHandler, 10Wikisource, 10Performance: Audio player takes a long time to initialize when requesting Vorbis output via invocation - https://phabricator.wikimedia.org/T49533#3862157 (10Ebe123) [06:23:46] (03PS1) 10Prtksxna: Use findItemFromData instead getItemFromData [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/400469 (https://phabricator.wikimedia.org/T76630) [06:24:05] (03CR) 10Prtksxna: [C: 04-2] "(Wait till the right version of OOUI is included in core.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/400469 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [06:24:19] 10Support-and-Safety: Change email address for Mrszelvesz - https://phabricator.wikimedia.org/T183734#3862159 (10Tgr) [06:24:24] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862169 (10Prtksxna) [06:28:21] (03PS1) 10Prtksxna: Use findItemFromData instead getItemFromData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/400470 (https://phabricator.wikimedia.org/T76630) [06:28:35] (03CR) 10Prtksxna: [C: 04-2] "Wait for OOUI" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/400470 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [06:28:54] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862171 (10Prtksxna) [06:29:48] 10Support-and-Safety: Change email address for Mrszelvesz - https://phabricator.wikimedia.org/T183734#3862172 (10Tgr) [06:30:09] 10Support-and-Safety: Change email address for Mrszelvesz - https://phabricator.wikimedia.org/T183734#3862159 (10Tgr) 05Open>03Resolved a:03Tgr Ran `resetUserEmail.php`. [06:37:42] (03PS14) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [06:51:32] 10Addwiki, 10Documentation, 10Easy, 10User-Addshore: Describe in the documentation how to add a basic statement - https://phabricator.wikimedia.org/T160732#3862176 (10Aklapper) @Dheerajmalisetty: The project tags of this task show that this task is about https://phabricator.wikimedia.org/project/profile/14... [06:53:23] (03PS7) 10Shilad Sen: Spark job to create desktop page ids viewed and searches performed in each session. [analytics/refinery/source] (nav-vectors) - 10https://gerrit.wikimedia.org/r/383761 (https://phabricator.wikimedia.org/T174796) [06:53:37] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862177 (10Aklapper) What would this show for `www.mydomain.xyz/wiki`? [06:53:43] 10Citoid, 10VisualEditor, 10User-Ryasmeen: Add Highwire Press, Eprints, BE Press, to html-metadata lib - https://phabricator.wikimedia.org/T76225#3862179 (10Ryan10145) [06:53:46] 10Citoid, 10VisualEditor, 10Google-Code-in-2017, 10User-Ryasmeen: Add scraping of PRISM tags to html-metadata node library - https://phabricator.wikimedia.org/T118636#3862178 (10Ryan10145) 05Open>03Resolved [06:55:19] 10Internet-Archive, 10Offline-Working-Group, 10Operations: Create backups of Wikimedia content in diverse geographic places - https://phabricator.wikimedia.org/T156544#3862182 (10Aklapper) >>! In T156544#3077677, @Pine wrote: > I am not understanding why this would be low priority. Can you please explain? [[... [06:56:20] (03CR) 10Umherirrender: [V: 032] Fix use of boolean in extension.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/400418 (owner: 10Umherirrender) [06:56:27] 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Multimedia: Error uploading XML files: "This file contains HTML or script code that may be erroneously interpreted by a web browser." - https://phabricator.wikimedia.org/T183727#3862183 (10Aklapper) [06:56:29] (03CR) 10Umherirrender: [V: 032] Fix register of extension in extension.json [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/400419 (owner: 10Umherirrender) [06:57:01] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [07:00:29] (03CR) 10Umherirrender: Change php extract() to explicit code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [07:02:56] 10MediaWiki-Codesniffer, 10Patch-For-Review: IfElseStructureSniff creates php error on autofix with alternative if else - https://phabricator.wikimedia.org/T178772#3862184 (10Umherirrender) 05Open>03Resolved [07:02:58] (03Merged) 10jenkins-bot: @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [07:03:01] (03CR) 10Yaron Koren: "Hi - could you explain the purpose of the ShowLog.php script? I understand what it does, but I don't understand what benefit it provides, " [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 (owner: 10MarkAHershberger) [07:13:50] (03PS1) 10Marostegui: test-s4.hosts: New file with the test-s4 hosts [software] - 10https://gerrit.wikimedia.org/r/400471 (https://phabricator.wikimedia.org/T180788) [07:14:48] (03PS2) 10Marostegui: test-s4.hosts: New file with the test-s4 hosts [software] - 10https://gerrit.wikimedia.org/r/400471 (https://phabricator.wikimedia.org/T180788) [07:22:26] (03CR) 10Marostegui: [C: 032] test-s4.hosts: New file with the test-s4 hosts [software] - 10https://gerrit.wikimedia.org/r/400471 (https://phabricator.wikimedia.org/T180788) (owner: 10Marostegui) [07:23:10] (03Merged) 10jenkins-bot: test-s4.hosts: New file with the test-s4 hosts [software] - 10https://gerrit.wikimedia.org/r/400471 (https://phabricator.wikimedia.org/T180788) (owner: 10Marostegui) [07:30:55] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [07:32:28] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [07:33:37] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Daily Campaign Counter - https://phabricator.wikimedia.org/T180285#3862187 (10tmletzko) @kai.nissen donations: 331.257 [07:34:42] (03CR) 10Nikerabbit: [C: 04-1] Fix """ in title on infopages (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [07:50:57] (03PS1) 10Nikerabbit: [puppet] Update elastic-elasticsearch [translatewiki] - 10https://gerrit.wikimedia.org/r/400472 [07:51:32] 10DBA, 10Goal: Check data consistency across production shards - https://phabricator.wikimedia.org/T183735#3862188 (10Marostegui) [07:51:45] 10DBA, 10Goal: Check data consistency across production shards - https://phabricator.wikimedia.org/T183735#3862198 (10Marostegui) p:05Triage>03Normal [07:52:12] 10DBA, 10Patch-For-Review: Checksum data on s7 - https://phabricator.wikimedia.org/T163190#3862201 (10Marostegui) [07:52:14] 10DBA, 10Goal: Check data consistency across production shards - https://phabricator.wikimedia.org/T183735#3862188 (10Marostegui) [07:52:16] 10DBA, 10Patch-For-Review: Run pt-table-checksum on s1 (enwiki) - https://phabricator.wikimedia.org/T162807#3862202 (10Marostegui) [07:54:39] 10DBA, 10Goal: Check data consistency across production shards - https://phabricator.wikimedia.org/T183735#3862203 (10Marostegui) [07:56:01] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862083 (10Legoktm) Whatever the output of `wfWikiID()` is. [07:58:03] (03CR) 10Legoktm: [C: 04-1] [WIP] Switch to load extension using MediaWiki's extension registration (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/399437 (https://phabricator.wikimedia.org/T88258) (owner: 10WMDE-leszek) [08:03:41] 10PAWS, 10Design, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3732727 (10takidelfin) It's acctually done? I'm interested in this task. But I can't see it on GCI website, and on WIkimedia Commons are some designs (but old, after it many users propose... [08:11:47] (03PS9) 10Ebe123: Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) [08:12:25] (03CR) 10Ebe123: Fix """ in title on infopages (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [08:13:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/400474 (owner: 10L10n-bot) [08:24:16] 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3862216 (10Od1n) Thanks :) `@grey-bright` [[ https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/variables.less | variable ]] is `#eee`.... [08:26:01] (03CR) 10WMDE-leszek: "Thanks Aude and Legoktm for early comments, that helps." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/399437 (https://phabricator.wikimedia.org/T88258) (owner: 10WMDE-leszek) [08:28:11] (03CR) 10WMDE-leszek: "I wouldn't mind if this patch also renamed "foreignRepositories" to "repositories", as it looks quite odd now." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400415 (https://phabricator.wikimedia.org/T153767) (owner: 10Ladsgroup) [08:31:27] 10Internet-Archive, 10Wikisource, 10Community-Wishlist-Survey-2016: Upload/import wizard for Wikisource works - https://phabricator.wikimedia.org/T154413#2910569 (10Alex_brollo) Just a small list of "it can be done" ideas. 1. to add to Book template a field, to post the contents of a good pagelist tag (bot... [08:35:55] 10MediaWiki-extensions-TweetANew, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3862219 (10Aklapper) Hmm, I wonder how maintained [[ https://www.mediawiki.org/wiki/Extension_talk:TweetANew | TweetANew ]] is, and how large a chunk of work s... [08:38:02] (03CR) 10Legoktm: [C: 04-1] Replace class_exists with ExtensionRegistry checks (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:38:52] 10MediaWiki-Special-pages: Allow for an easy copy-paste representation of information on "Special:Version" - https://phabricator.wikimedia.org/T176643#3632223 (10Rical) In fr.wikisource.org with 10.0.32-MariaDB which differ from 10.0.31-MariaDB in www.mediawiki.org, I get and error, 10 minuts after a good run: *... [08:40:21] (03PS2) 10Ebe123: Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) [08:40:54] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3862224 (10Aklapper) Published as https://codein.withgoogle.com/tasks/5873488822796288/ [08:40:56] (03CR) 10Ebe123: Replace class_exists with ExtensionRegistry checks (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:43:47] 10Analytics, 10EventBus, 10Google-Code-in-2017, 10Technical-Debt: EventBusHooks::onArticleRevisionVisibilitySet should not create global functions - https://phabricator.wikimedia.org/T183730#3862226 (10Aklapper) Published as https://codein.withgoogle.com/tasks/5509074319835136/ [08:43:49] (03PS1) 10Nikerabbit: Harden YAML parsing by disallowing serialization [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400484 [08:44:10] (03PS1) 10Legoktm: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 [08:44:12] (03PS1) 10Legoktm: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 [08:44:14] (03PS1) 10Legoktm: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 [08:44:17] (03PS1) 10Legoktm: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 [08:44:19] (03PS1) 10Legoktm: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 [08:44:21] (03PS1) 10Legoktm: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 [08:44:23] (03PS1) 10Legoktm: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 [08:44:25] (03PS1) 10Legoktm: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 [08:46:45] (03CR) 10jerkins-bot: [V: 04-1] Harden YAML parsing by disallowing serialization [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400484 (owner: 10Nikerabbit) [08:47:40] 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Move namespaced extensions to use PSR-4 autoloading - https://phabricator.wikimedia.org/T182943#3862228 (10Aklapper) @Reedy: How can a contributor identify such an ext... [08:48:13] (03PS2) 10Nikerabbit: Harden YAML parsing by disallowing serialization [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400484 [08:49:45] (03CR) 10jerkins-bot: [V: 04-1] tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [08:50:19] (03CR) 10Legoktm: [C: 032] Remove rawAndMidi from cache options [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [08:52:17] (03CR) 10Legoktm: [C: 032] Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:52:37] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3862230 (10Aklapper) > extensions/Collection/OfflineContentGenerator/epub_renderer - not... [08:52:49] (03PS2) 10Legoktm: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 [08:52:52] (03CR) 10jerkins-bot: [V: 04-1] Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [08:52:58] (03PS2) 10Legoktm: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 [08:53:05] (03PS2) 10Legoktm: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 [08:53:13] (03PS2) 10Legoktm: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 [08:53:17] (03Merged) 10jenkins-bot: Remove rawAndMidi from cache options [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [08:53:24] (03PS2) 10Legoktm: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 [08:53:33] (03PS2) 10Legoktm: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 [08:53:41] (03PS2) 10Legoktm: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 [08:55:14] (03Merged) 10jenkins-bot: Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:56:19] (03PS2) 10Legoktm: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 [08:57:40] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3862233 (10Aklapper) [08:59:51] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not properly update subscriber count - https://phabricator.wikimedia.org/T183189#3862234 (10Aklapper) @01tonythomas : Once this task is ready / its task description is clear enough for #GCI2017, please give a heads... [09:00:38] 10Scoring-platform-team, 10Wikimania-Hackathon-2017, 10Documentation: [Wikimania doc sprint] docs on how to install ORES - https://phabricator.wikimedia.org/T170506#3862235 (10Aklapper) No reply, hence removing tags. Feel free to re-add once my previous comment has been answered. Thanks! [09:01:42] 10UI-Standardization, 10Documentation: Update documentation about where page styling and skin css comes from - https://phabricator.wikimedia.org/T178641#3862237 (10Aklapper) @Zppix: No reply, hence removing the #GCI2017 tag. Feel free to re-add once my previous comment has been answered. Thanks! [09:02:21] 10Wikidata: Wikidata database corruption? - https://phabricator.wikimedia.org/T181486#3791841 (10Rical) In fr.wikisource.org with 10.0.32-MariaDB which differ from 10.0.31-MariaDB in www.mediawiki.org, I get and error, 10 minuts after a good run: Erreur Lua dans Module:Central-s-fr à la ligne 1709 : attempt... [09:02:25] 10Scoring-platform-team, 10Wikilabels, 10Easy, 10Google-Code-in-2017: qunit tests for wikilabels - https://phabricator.wikimedia.org/T171083#3862241 (10Aklapper) @Ladsgroup: Any chance / time to reply to my previous comment so we could maybe turn this into GCI tasks (how much to do per 1 task)? Thanks in a... [09:03:12] 10WM-Bot: Add French to the supported languages of wm-bot - https://phabricator.wikimedia.org/T103852#3862242 (10Aklapper) @Petrb: Could you answer my last questions please? Removing the #GCi2017 tag until this has happened. Feel free to re-add once done. [09:06:43] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862244 (10Ebe123) p:05Triage>03Low [09:07:15] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862244 (10Ebe123) I don't know if this would be admissible as a little project, but here's an idea. [09:07:24] (03PS15) 10Legoktm: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [09:07:27] 10Wikidata: Wikidata database corruption? - https://phabricator.wikimedia.org/T181486#3862256 (10Marostegui) >>! In T181486#3862239, @Rical wrote: > In fr.wikisource.org with 10.0.32-MariaDB which differ from 10.0.31-MariaDB in www.mediawiki.org, > I get and error, 10 minuts after a good run: > > Erreur Lua... [09:08:06] (03PS3) 10Nikerabbit: Harden YAML parsing by disallowing serialization [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400484 [09:08:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400519 (owner: 10L10n-bot) [09:08:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/400522 (owner: 10L10n-bot) [09:09:11] (03PS1) 10Simon04: MWParameterPage: tabindex for action buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/400561 [09:10:20] (03PS4) 10Nikerabbit: Harden YAML parsing by disallowing unserialization of objects [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400484 [09:11:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/400555 (owner: 10L10n-bot) [09:11:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400559 (owner: 10L10n-bot) [09:12:52] 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Google-Code-in-2017: Flow: Notification icons point to different directions - https://phabricator.wikimedia.org/T161330#3862257 (10Aklapper) Could someone clarify what is wanted here, so this could maybe become a #GCI2017 task? Is thi... [09:13:44] 10MediaWiki-extensions-InputBox, 10UI-Standardization, 10Google-Code-in-2017: Convert InputBox to use OOUI where possible - https://phabricator.wikimedia.org/T106948#3862258 (10Aklapper) @Prtksxna, @matmarex: Could you answer the last comment please, if you still think this could be suitable for creating #GC... [09:13:46] (03CR) 10Legoktm: [C: 032] maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [09:14:13] 10Collaboration-Team-Triage, 10Possible-Tech-Projects, 10UI-Standardization, 10WikiLove, 10Google-Code-in-2017: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#3862259 (10Aklapper) If anyone knowledgeable enough could use T89815#3743426 to edit the task description t... [09:16:03] (03PS3) 10Legoktm: Avoid PHP 7.1 warning of &$this usage [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [09:17:37] (03CR) 10Legoktm: [C: 032] Add AvailableRights in extension.json [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/400422 (owner: 10Umherirrender) [09:17:53] (03CR) 10D3r1ck01: "Minor fix :)" (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [09:18:22] (03CR) 10Legoktm: [C: 032] Skip unit tests, if diff3 is not installed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400388 (owner: 10Umherirrender) [09:18:45] (03CR) 10Legoktm: [C: 032] Fix strict standard about ApiBase::getWebUITokenSalt [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400399 (owner: 10Umherirrender) [09:18:47] (03CR) 10Nikerabbit: [C: 032] Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [09:20:06] 10WM-Bot: Add French to the supported languages of wm-bot - https://phabricator.wikimedia.org/T103852#3862260 (10Petrb) Yes, let's remove it from GCI for now. I don't speak French :( also it's rather complex thing [09:20:53] (03CR) 10Legoktm: Use ExtensionRegistry instead of class_exists (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [09:21:21] 10MediaWiki-extensions-WikimediaIncubator, 10Easy, 10Patch-For-Review: Quotation marks are shown as " in title - https://phabricator.wikimedia.org/T72240#3862261 (10Ebe123) [09:21:29] 10MediaWiki-extensions-WikimediaIncubator, 10Easy, 10Patch-For-Review: Quotation marks are shown as " in title - https://phabricator.wikimedia.org/T72240#741300 (10Ebe123) 05Open>03Resolved [09:22:01] (03CR) 10Legoktm: [C: 04-1] Use ExtensionRegistry instead of class_exists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [09:22:03] (03Merged) 10jenkins-bot: maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [09:22:05] (03Merged) 10jenkins-bot: Add AvailableRights in extension.json [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/400422 (owner: 10Umherirrender) [09:22:07] (03Merged) 10jenkins-bot: Skip unit tests, if diff3 is not installed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400388 (owner: 10Umherirrender) [09:22:26] (03Merged) 10jenkins-bot: Fix strict standard about ApiBase::getWebUITokenSalt [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400399 (owner: 10Umherirrender) [09:22:29] (03Merged) 10jenkins-bot: Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [09:23:52] (03CR) 10Legoktm: [C: 04-1] Harden YAML parsing by disallowing unserialization of objects (032 comments) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400484 (owner: 10Nikerabbit) [09:25:06] (03CR) 10Legoktm: [C: 032] "I think there's a bigger problem here of why this extension doesn't support 32-bit?" [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400438 (owner: 10Umherirrender) [09:26:45] (03Merged) 10jenkins-bot: Skip unit tests on 32 bit machine [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400438 (owner: 10Umherirrender) [09:27:59] (03CR) 1001tonythomas: "recheck" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [09:28:38] 10Cognate: Cognate's StringHasher requires 64-bit PHP, doesn't work with 32-bit - https://phabricator.wikimedia.org/T183737#3862264 (10Legoktm) [09:28:48] (03CR) 10Legoktm: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [09:28:58] (03CR) 10Legoktm: [C: 032] "Filed T183737 for follow-up" [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400438 (owner: 10Umherirrender) [09:29:58] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [09:31:04] (03CR) 10Legoktm: [C: 031] tests: Commit initial version of DevelopmentSettings.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/383041 (https://phabricator.wikimedia.org/T177669) (owner: 10Krinkle) [09:31:59] (03CR) 10Legoktm: [C: 032] Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [09:32:05] (03CR) 1001tonythomas: [C: 032] Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [09:33:42] (03CR) 10jenkins-bot: maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [09:35:15] 10MediaWiki-Gallery, 10Multimedia, 10Parsing-Team, 10Patch-For-Review: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number - https://phabricator.wikimedia.org/T129372#3862276 (10Legoktm) Adding #parsing-team since this is apparently blocke... [09:35:34] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/erudite] - 10https://gerrit.wikimedia.org/r/400562 (https://phabricator.wikimedia.org/T153505) [09:36:57] (03CR) 10Legoktm: [C: 032] build: Run phplint for inc files [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/400261 (owner: 10Umherirrender) [09:37:19] (03PS16) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) [09:37:48] (03Merged) 10jenkins-bot: Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [09:37:50] (03Merged) 10jenkins-bot: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [09:38:41] (03Merged) 10jenkins-bot: build: Run phplint for inc files [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/400261 (owner: 10Umherirrender) [09:38:46] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/400563 (https://phabricator.wikimedia.org/T153505) [09:38:54] (03CR) 10Legoktm: [C: 032] Change php extract() to explicit code [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [09:40:43] (03CR) 10Legoktm: [C: 032] Fix class name for QueryPages (no behaviour change) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/400235 (owner: 10Brian Wolff) [09:41:11] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3862285 (1001tonythomas) [09:41:13] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate - https://phabricator.wikimedia.org/T183638#3862282 (1001tonythomas) 05Open>03Resolved a:03Ryan10145 Great work. Thanks ! [09:43:30] (03CR) 1001tonythomas: [C: 032] "LGTM :) Thanks." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400459 (https://phabricator.wikimedia.org/T183618) (owner: 10Divadsn) [09:44:38] (03CR) 10Nikerabbit: [C: 032] [puppet] Update elastic-elasticsearch [translatewiki] - 10https://gerrit.wikimedia.org/r/400472 (owner: 10Nikerabbit) [09:45:00] (03Merged) 10jenkins-bot: Change php extract() to explicit code [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [09:45:02] (03Merged) 10jenkins-bot: Fix class name for QueryPages (no behaviour change) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/400235 (owner: 10Brian Wolff) [09:45:06] (03Merged) 10jenkins-bot: Unit test NewsletterDb::updateDescription [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400459 (https://phabricator.wikimedia.org/T183618) (owner: 10Divadsn) [09:46:37] (03Merged) 10jenkins-bot: [puppet] Update elastic-elasticsearch [translatewiki] - 10https://gerrit.wikimedia.org/r/400472 (owner: 10Nikerabbit) [09:46:39] (03CR) 10jenkins-bot: Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [09:47:07] (03CR) 10Legoktm: "I'm not really sure about this, the capitalization comes from the GPL, which was probably meant for plain text, not HTML. The only differe" [core] - 10https://gerrit.wikimedia.org/r/399818 (owner: 10Lucas Werkmeister (WMDE)) [09:47:27] 10PAWS, 10Design, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3862287 (10Framawiki) >>! In T179677#3862214, @takidelfin wrote: > It's acctually done? I'm interested in this task. But I can't see it on GCI website, and on WIkimedia Commons are some de... [09:48:28] 10PAWS, 10Design, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3862288 (10takidelfin) Ok, thanks! [09:48:53] (03CR) 1001tonythomas: [C: 031] "Looking good actually. Sadly, I cannot really test it before another 10 hours or so. Adding in others so that they can review and +2." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [09:49:27] (03CR) 10Legoktm: [C: 032] Clean up ESLint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399822 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [09:49:35] (03Abandoned) 10Framawiki: Added foo to the bar [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400416 (owner: 10Eisenhaus335) [09:50:07] (03CR) 10Legoktm: [C: 032] Switch from jshint to eslint [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/398640 (owner: 10Fomafix) [09:50:24] 10MediaWiki-Containers, 10Services (next): Separate RESTBase and Parsoid into their own images and deployments - https://phabricator.wikimedia.org/T183738#3862289 (10mobrovac) p:05Triage>03Normal [09:51:55] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/390896 (owner: 10Fomafix) [09:52:04] (03Merged) 10jenkins-bot: Clean up ESLint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399822 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [09:52:05] (03Merged) 10jenkins-bot: Switch from jshint to eslint [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/398640 (owner: 10Fomafix) [09:52:51] (03CR) 10Legoktm: [C: 032] make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [09:53:05] (03PS1) 10Nikerabbit: [puppet] Add puppet-lint and make pass [translatewiki] - 10https://gerrit.wikimedia.org/r/400564 [09:55:55] (03CR) 10jenkins-bot: Change php extract() to explicit code [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [09:57:13] (03PS1) 10Nikerabbit: [puppet] Manage mailman with librarian-puppet [translatewiki] - 10https://gerrit.wikimedia.org/r/400565 [09:57:41] (03CR) 10D3r1ck01: [C: 04-1] "No, I asked for just the commit message. Not to include the files Legoktm has changed. I clearly see you worked from your branch, but inst" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) (owner: 10Noella94) [09:58:08] (03CR) 10jerkins-bot: [V: 04-1] Let Html::element do the HTML encoding [core] - 10https://gerrit.wikimedia.org/r/390896 (owner: 10Fomafix) [09:58:28] (03CR) 10Nikerabbit: [C: 032] [puppet] Add puppet-lint and make pass [translatewiki] - 10https://gerrit.wikimedia.org/r/400564 (owner: 10Nikerabbit) [09:59:11] (03Merged) 10jenkins-bot: make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [10:00:19] (03Merged) 10jenkins-bot: [puppet] Add puppet-lint and make pass [translatewiki] - 10https://gerrit.wikimedia.org/r/400564 (owner: 10Nikerabbit) [10:01:56] (03PS5) 10Nikerabbit: Harden YAML parsing by disallowing unserialization of objects [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400484 [10:02:14] (03CR) 10Nikerabbit: [C: 032] [puppet] Manage mailman with librarian-puppet [translatewiki] - 10https://gerrit.wikimedia.org/r/400565 (owner: 10Nikerabbit) [10:02:42] (03Merged) 10jenkins-bot: [puppet] Manage mailman with librarian-puppet [translatewiki] - 10https://gerrit.wikimedia.org/r/400565 (owner: 10Nikerabbit) [10:04:23] (03PS1) 10Thiemo Kreuz (WMDE): Update inline documentation [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400566 [10:04:25] (03PS1) 10Thiemo Kreuz (WMDE): Add more strict type hints to hook handlers [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400567 [10:05:41] (03CR) 10jerkins-bot: [V: 04-1] Add more strict type hints to hook handlers [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400567 (owner: 10Thiemo Kreuz (WMDE)) [10:06:07] (03CR) 10jerkins-bot: [V: 04-1] Update inline documentation [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400566 (owner: 10Thiemo Kreuz (WMDE)) [10:06:48] (03CR) 10Thiemo Kreuz (WMDE): "recheck" [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400566 (owner: 10Thiemo Kreuz (WMDE)) [10:07:19] (03PS2) 10Thiemo Kreuz (WMDE): Add more strict type hints to hook handlers [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400567 [10:08:28] (03CR) 10jenkins-bot: make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [10:08:59] (03CR) 10jerkins-bot: [V: 04-1] Add more strict type hints to hook handlers [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400567 (owner: 10Thiemo Kreuz (WMDE)) [10:12:05] 10Cognate: Cognate's StringHasher requires 64-bit PHP, doesn't work with 32-bit - https://phabricator.wikimedia.org/T183737#3862307 (10thiemowmde) 05Open>03Invalid The extension is 64-bit-only by design, see T150404. The TL;DR is: The risk of hash collisions is to big on 32 bit. [10:12:15] (03CR) 10Thiemo Kreuz (WMDE): "The extension is 64-bit-only by design, see T150404. The TL;DR is: The risk of hash collisions is to big on 32 bit." [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400438 (owner: 10Umherirrender) [10:18:25] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862316 (10Dvorapa) 05Open>03Resolved The first section can not be archived, because it hasn't got a timestamp. Archive m... [10:22:23] 10MediaWiki-Codesniffer: Forbid parse_str() without a second argument - https://phabricator.wikimedia.org/T183739#3862318 (10Ricordisamoa) [10:22:26] (03CR) 10Thiemo Kreuz (WMDE): Add tests for TextboxBuilder (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [10:24:53] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10Design, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3862330 (10kai.nissen) @Pablo-WMDE as you see fit. we can target the devices using centralnotice, so it's fine to not... [10:25:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] tests: Complete test coverage of HtmlArmor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [10:26:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [10:27:15] 04(no projects): not path "/srv/phab/phabricator/bin" to install sprint extension - https://phabricator.wikimedia.org/T183740#3862331 (10Rameho) [10:27:16] (03CR) 10Legoktm: tests: Complete test coverage of HtmlArmor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [10:28:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "TemplateParser is a nice little 220 lines class. I agree that having a single top-level @covers tag is fine in such cases." [core] - 10https://gerrit.wikimedia.org/r/400491 (owner: 10Legoktm) [10:30:05] 10MobileFrontend, 10Wikidata, 10I18n: First character of Wikidata labels incorrectly rendered in some languages on mobile, as the tagline class has ::first-letter { text-transform: capitalize; } - https://phabricator.wikimedia.org/T183388#3862340 (10BukhariSaeed) {F12100560} on urwiki [10:31:11] 10ProofreadPage, 10Wikisource: Create OOUI widget for Index page pagelists - https://phabricator.wikimedia.org/T172953#3514335 (10Alex_brollo) Very interesting, but consider too that the "hard work" is, to browse carefully the djvu file and to find djvu pages/ book pages ("name" or number) relationship; an opp... [10:33:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Add @covers tags to database tests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [10:34:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Remove resolved todo from MWNamespace test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400489 (owner: 10Legoktm) [10:34:49] (03Merged) 10jenkins-bot: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 (owner: 10Legoktm) [10:35:01] 10Cognate: Cognate's StringHasher requires 64-bit PHP, doesn't work with 32-bit - https://phabricator.wikimedia.org/T183737#3862343 (10Legoktm) 05Invalid>03Open Unfortunately that doesn't answer the question of what the risk actually is (such as if you have less than X items, does it become safe?), but I mos... [10:35:25] (03PS17) 10Noella94: Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) [10:36:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "The test serves one purpose: it makes sure the constructor is not made private. But it's redundant anyway because there are a ton more "ne" [core] - 10https://gerrit.wikimedia.org/r/400488 (owner: 10Legoktm) [10:39:08] 10WMDE-Design, 10Wikidata, 10Wikidata Query UI, 10Design, and 3 others: Implement keyboard accessibility for Query.Wikidata.org - https://phabricator.wikimedia.org/T173213#3862346 (10Lydia_Pintscher) [10:40:12] (03Merged) 10jenkins-bot: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 (owner: 10Legoktm) [10:40:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Individual review done. This looks absolutely fine for me, and I'm willing to merge this within the next days. I just want to give others " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [10:41:44] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) (owner: 10Noella94) [10:42:15] (03Merged) 10jenkins-bot: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 (owner: 10Legoktm) [10:43:56] (03CR) 10jenkins-bot: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 (owner: 10Legoktm) [10:44:43] (03CR) 10Legoktm: Add @covers tags to database tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [10:50:39] 10MobileFrontend, 10Wikidata, 10I18n: First character of Wikidata labels incorrectly rendered in some languages on mobile, as the tagline class has ::first-letter { text-transform: capitalize; } - https://phabricator.wikimedia.org/T183388#3851752 (10matej_suchanek) Let's just abandon the capitalizing: {T1310... [10:51:18] 10§ Phabricator Sprint Extension [2014-12-11]: not path "/srv/phab/phabricator/bin" to install sprint extension - https://phabricator.wikimedia.org/T183740#3862353 (10Aklapper) 05Open>03Invalid If your Phabricator installation is not installed in the path `/srv/phab/` then you need to adjust that path accor... [10:51:40] 10Phabricator-Sprint-Extension: not path "/srv/phab/phabricator/bin" to install sprint extension - https://phabricator.wikimedia.org/T183740#3862356 (10Aklapper) [10:51:58] 10WMDE-Fun-Team, 10WMDE-Fundraising-Funban-2: Thank You banner (2) - https://phabricator.wikimedia.org/T183538#3862358 (10kai.nissen) [10:52:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Screenreaders typically ignore capitalization entirely. What blind users read on their Braille line is typically all uppercase." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399818 (owner: 10Lucas Werkmeister (WMDE)) [10:52:54] (03CR) 10jenkins-bot: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 (owner: 10Legoktm) [10:52:56] (03CR) 10Legoktm: [C: 04-1] "Needs parser test updates" [core] - 10https://gerrit.wikimedia.org/r/390896 (owner: 10Fomafix) [10:53:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] thumb.php: Set ENT_NOQUOTES for htmlspecialchars [core] - 10https://gerrit.wikimedia.org/r/390223 (owner: 10Fomafix) [10:57:35] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862360 (10Kghbln) > Do you know if this was a problem before? I cannot tell for sure since I very rarely delete threads but I am pretty sure that this did not happen when... [10:59:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] tests: Complete test coverage of HtmlArmor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [11:00:18] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Tests: Figure out how to accurately backfill MediaWiki core test code coverage data - https://phabricator.wikimedia.org/T182750#3862361 (10Legoktm) p:05Triage>03Low I'm not really convinced this is worth spending time on any more. My current investi... [11:00:55] (03CR) 10jenkins-bot: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 (owner: 10Legoktm) [11:02:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to database tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [11:03:03] 10MediaWiki-extensions-Quiz: Problem with ' caracter in answer textfields - https://phabricator.wikimedia.org/T183741#3862364 (10MarcodeFreitas) [11:03:29] 10Addwiki, 10Documentation, 10Easy, 10User-Addshore: Describe in the documentation how to add a basic statement - https://phabricator.wikimedia.org/T160732#3862375 (10Addshore) [11:03:38] (03PS1) 10Dvorapa: Update git submodules [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400568 [11:04:05] (03Abandoned) 10Dvorapa: Update git submodules [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400568 (owner: 10Dvorapa) [11:05:53] (03Merged) 10jenkins-bot: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [11:08:11] (03Merged) 10jenkins-bot: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [11:09:49] 10User-GoranSMilovanovic, 10WMDE-New-Editors-Banner-Campaigns (Banner-Campaign-Thanks-2018): Campaign report - https://phabricator.wikimedia.org/T182792#3862378 (10Addshore) >>! In T182792#3861662, @GoranSMilovanovic wrote: > @Addshore Just to remind you that I was already able to fetch some data on this campa... [11:11:48] (03CR) 10Addshore: [C: 032] Update inline documentation [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400566 (owner: 10Thiemo Kreuz (WMDE)) [11:12:04] 10MediaWiki-Codesniffer: Investigate upstreaming some of our custom sniffs - https://phabricator.wikimedia.org/T103642#3862382 (10Legoktm) [11:12:07] (03PS3) 10Addshore: Add more strict type hints to hook handlers [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400567 (owner: 10Thiemo Kreuz (WMDE)) [11:13:26] (03Merged) 10jenkins-bot: Update inline documentation [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400566 (owner: 10Thiemo Kreuz (WMDE)) [11:13:40] (03CR) 10jerkins-bot: [V: 04-1] Add more strict type hints to hook handlers [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400567 (owner: 10Thiemo Kreuz (WMDE)) [11:14:16] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862385 (10Tacsipacsi) The first section doesn’t have a timestamp, so it won’t be archived, but it is a section. The above co... [11:15:47] (03PS1) 10Thiemo Kreuz (WMDE): Remove some obvious, self-explaining PHPDoc snippets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400569 [11:17:08] (03CR) 10jenkins-bot: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [11:17:40] 10Analytics, 10EventBus, 10Google-Code-in-2017, 10Technical-Debt: EventBusHooks::onArticleRevisionVisibilitySet should not create global functions - https://phabricator.wikimedia.org/T183730#3862387 (10Phantom42) a:03Phantom42 I will fix this issue! [11:19:00] (03PS18) 10Fomafix: Hide TOC with CSS instead of JavaScript [core] - 10https://gerrit.wikimedia.org/r/372515 [11:19:21] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/372515 (owner: 10Fomafix) [11:19:56] (03PS1) 10Thiemo Kreuz (WMDE): Remove spaces from the "Wikibase …" extension names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400570 [11:20:15] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Daily Campaign Counter - https://phabricator.wikimedia.org/T180285#3862389 (10kai.nissen) done [11:21:21] (03CR) 10Addshore: [C: 04-1] ""no one uses it" is inaccurate." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/400248 (owner: 10Kaldari) [11:23:27] (03PS4) 10Thiemo Kreuz (WMDE): Add more strict type hints to hook handlers [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400567 [11:26:20] (03CR) 10jenkins-bot: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [11:26:30] 10MediaWiki-Special-pages: Allow for an easy copy-paste representation of information on "Special:Version" - https://phabricator.wikimedia.org/T176643#3862394 (10Kghbln) @Rical I am pretty sure you are on the wrong issue here. It looks to me like you should first conact the creator of the module in question. [11:28:15] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 40 - campaign enhancement - https://phabricator.wikimedia.org/T183742#3862395 (10tmletzko) [11:28:43] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 40 - campaign enhancement - https://phabricator.wikimedia.org/T183742#3862407 (10tmletzko) [11:29:20] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Add a "Change template" option - https://phabricator.wikimedia.org/T95718#3862408 (10Magol) Why not allow to change to any template? If the user choose to change to a template with not matching parameters, it up to the user to fix that. I think that even if... [11:32:38] 10MediaWiki-Templates, 10VisualEditor, 10VisualEditor-Tables, 10User-Ryasmeen, and 3 others: Support editing table cells whose formatting is defined by a template - https://phabricator.wikimedia.org/T85648#3862413 (10Magol) [11:34:05] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862414 (10Addshore) [11:34:20] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862415 (10Aklapper) @Ebe123: Thanks a lot! I've sent an invitation email to register as a #GCI2017 mentor. Could you also add yourself to the [[ https://www.mediawiki... [11:34:33] 10Analytics, 10EventBus, 10Google-Code-in-2017, 10Technical-Debt: EventBusHooks::onArticleRevisionVisibilitySet should not create global functions - https://phabricator.wikimedia.org/T183730#3862416 (10Phantom42) By the way, I noticed that function `onBlockIpComplete` unintentionally creates new global fun... [11:35:41] 10WMDE-Fun-Team, 10WMDE-Fundraising-Funban-2: Thank You banner (2) - https://phabricator.wikimedia.org/T183538#3862418 (10Pablo-WMDE) @gabriel-wmde FYI: I messed with re-coloring SVGs in https://github.com/wmde/fundraising-banners/pull/102/commits/50ac15e6551adab8aba2ea0d5fb462740ae7be9d of T183280 [11:41:11] 10Wikidata: Wikidata database corruption? - https://phabricator.wikimedia.org/T181486#3862421 (10Rical) I work on a the [[ https://fr.wikisource.org/wiki/Module:Central-s-fr | Module:Central ]] able to convert any scribunto Lua module as multilingual with automatic import of arguments and wikidatas, see T135845.... [11:41:36] (03PS1) 10Phantom42: Fix unintentionally created global functions in EventBusHooks [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) [11:43:29] 10MediaWiki-Containers, 10Services (doing): FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862426 (10mobrovac) p:05Triage>03Normal [11:43:50] 10MediaWiki-Containers, 10Operations, 10Release-Engineering-Team, 10Epic, and 3 others: FY2017/18 Program 6 - Outcome 2 - Objective 3: Integrated, container-based development environment - https://phabricator.wikimedia.org/T170456#3862438 (10mobrovac) [11:43:54] 10MediaWiki-Containers, 10Services (doing): FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862437 (10mobrovac) [11:44:05] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862439 (10Glendales) @Legoktm I am using Safari on an Apple iPhone 7 and an iPad Air 2, both of which give the problem. I don’t have... [11:44:17] 10MediaWiki-Containers, 10Goal, 10Services (doing): FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862426 (10mobrovac) [11:45:57] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862441 (10Glendales) @Aklapper I don’t see the “network” link you were talking about earlier. Can you point out on the screenshot bel... [11:47:16] (03PS1) 10Thiemo Kreuz (WMDE): Add missing @param docs and such [extensions/WikibaseQualityConstraints] - 10https://gerrit.wikimedia.org/r/400572 [11:48:58] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862442 (10Addshore) [11:49:37] (03PS1) 10Thiemo Kreuz (WMDE): Slightly improve some type hints in PHPDoc blocks [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400573 [11:49:39] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete hook - https://phabricator.wikimedia.org/T183716#3862443 (10Addshor... [11:52:49] (03PS1) 10Thiemo Kreuz (WMDE): Remove obvious, non-helpful documentation snippets [extensions/SemanticGenealogy] - 10https://gerrit.wikimedia.org/r/400574 [11:54:34] 10MediaWiki-extensions-WikimediaIncubator, 10Easy, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Quotation marks are shown as " in title - https://phabricator.wikimedia.org/T72240#3862444 (10Nikerabbit) [11:55:45] (03PS1) 10Thiemo Kreuz (WMDE): Remove some superfluous parameter descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 [11:56:12] (03CR) 10Mobrovac: [C: 04-1] "Looking good, but could you please group these methods to the top of the class where the private static functions are? Mixing private and " (033 comments) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [11:57:08] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete hook - https://phabricator.wikimedia.org/T183716#3862445 (10Addshor... [11:58:11] (03PS1) 10Thiemo Kreuz (WMDE): Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) [12:00:41] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862447 (10Addshore) [12:00:47] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862449 (10Addshore) p:05Triage>03Unbreak! [12:00:54] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete hook - https://phabricator.wikimedia.org/T183716#3862450 (10Addshor... [12:01:02] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862451 (10Addshore) p:05Unbreak!>03High a:03Addshore [12:01:08] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComple... - https://phabricator.wikimedia.org/T183716#3862455 [12:01:20] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [12:13:56] (03PS2) 10Phantom42: Fix unintentionally created global functions in EventBusHooks [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) [12:14:20] (03CR) 10Phantom42: "Thank you for reviewing! I agree with you and fixed those issues!" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [12:17:00] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_prefix_redirect_accent_squashing_accented_namespace_suggest_search_prefer" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 (owner: 10Thiemo Kreuz (WMDE)) [12:21:24] (03CR) 10Nikerabbit: [V: 031] Support long titles in selected source page (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400452 (https://phabricator.wikimedia.org/T181701) (owner: 10Petar.petkovic) [12:21:58] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 40 - campaign enhancement - https://phabricator.wikimedia.org/T183742#3862462 (10tmletzko) [12:24:41] (03CR) 10Nikerabbit: [V: 031 C: 032] statsbar: Update colors according to WikmediaUI palette [extensions/Translate] - 10https://gerrit.wikimedia.org/r/388379 (owner: 10Prtksxna) [12:25:53] (03CR) 10Nikerabbit: "recheck" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400425 (owner: 10Petar.petkovic) [12:27:14] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [12:28:09] (03PS6) 10Fomafix: Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [12:28:29] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [12:32:10] (03Merged) 10jenkins-bot: statsbar: Update colors according to WikmediaUI palette [extensions/Translate] - 10https://gerrit.wikimedia.org/r/388379 (owner: 10Prtksxna) [12:32:41] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862464 (10Dvorapa) For me the page **hu:User talk:Wegyor** works as expected. You can see its history. Have you got updated... [12:32:56] 10Vector, 10Patch-For-Review: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards - https://phabricator.wikimedia.org/T182602#3862466 (10He7d3r) This seems to be related to {T182907}. [12:34:10] (03CR) 10Nikerabbit: [C: 032] Remove @file and @ingroup annotations in comments [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400425 (owner: 10Petar.petkovic) [12:37:16] 10MediaWiki-Containers, 10Goal, 10Services (doing), 10User-mobrovac: FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862469 (10mobrovac) a:03mobrovac [12:38:53] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#3862471 (10Scott) [12:39:26] 10WMF-Legal, 10Tracking: Copyright license and attribution issues (tracking) - https://phabricator.wikimedia.org/T87268#3862474 (10Scott) [12:39:28] 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: Include action=credits output into action=info as well - https://phabricator.wikimedia.org/T41533#3862475 (10Scott) [12:39:30] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#323614 (10Scott) 05duplicate>03Open [12:39:32] 10MediaWiki-Database, 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extensions-CentralAuth, and 3 others: Provide consistent native way to attribute offsite users in revision history - https://phabricator.wikimedia.org/T20209#3862476 (10Scott) [12:39:38] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862477 (10Dvorapa) BTW the code you checked is only a half of the code responsible for the thread header recognition... [12:39:54] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#323614 (10Scott) [12:39:56] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3862479 (10Scott) [12:40:35] 10Analytics, 10EventBus, 10MediaWiki-JobQueue, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862480 (10mobrovac) p:05Triage>03Normal [12:42:23] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#3862493 (10Scott) Per Helder at T4994#3860813, rephrased task to only be about external authors as T4994 already covers on-... [12:42:30] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3862494 (10Scott) @He7d3r - you're right, sorry; looks like I glossed over that part. Done. [12:42:35] (03Merged) 10jenkins-bot: Remove @file and @ingroup annotations in comments [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400425 (owner: 10Petar.petkovic) [12:42:39] 10Analytics, 10EventBus, 10MediaWiki-JobQueue, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862495 (10mobrovac) [12:42:44] 10Analytics, 10ChangeProp, 10EventBus, 10MediaWiki-JobQueue, and 3 others: [EPIC] Develop a JobQueue backend based on EventBus - https://phabricator.wikimedia.org/T157088#3862496 (10mobrovac) [12:42:50] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 40 - campaign enhancement - https://phabricator.wikimedia.org/T183742#3862497 (10kai.nissen) [12:44:37] 10Analytics, 10EventBus, 10MediaWiki-JobQueue, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862480 (10mobrovac) [12:44:42] 10Analytics, 10ChangeProp, 10EventBus, 10MediaWiki-JobQueue, and 5 others: Select candidate jobs for transferring to the new infrastucture - https://phabricator.wikimedia.org/T175210#3862498 (10mobrovac) [12:46:10] 10Analytics, 10EventBus, 10MediaWiki-JobQueue, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862501 (10mobrovac) [12:46:14] 10Analytics, 10ChangeProp, 10EventBus, 10MediaWiki-JobQueue, and 3 others: Services Q2 2017/18 goal: Migrate a subset of jobs to multi-DC enabled event processing infrastructure. - https://phabricator.wikimedia.org/T175212#3862502 (10mobrovac) [12:46:18] 10Analytics, 10ChangeProp, 10EventBus, 10MediaWiki-JobQueue, and 4 others: Migrate htmlCacheUpdate job to Kafka - https://phabricator.wikimedia.org/T182023#3862500 (10mobrovac) [12:49:16] 10MediaWiki-Platform-Team, 10Operations, 10Epic, 10Performance-Team (Radar), 10Services (watching): 2017/18 Annual Plan Program 8: Multi-datacenter support, Q2 goals - https://phabricator.wikimedia.org/T175213#3862507 (10mobrovac) [12:49:20] 10Analytics, 10ChangeProp, 10EventBus, 10MediaWiki-JobQueue, and 3 others: [EPIC] Develop a JobQueue backend based on EventBus - https://phabricator.wikimedia.org/T157088#3862508 (10mobrovac) [12:49:23] 10Analytics, 10ChangeProp, 10EventBus, 10MediaWiki-JobQueue, and 2 others: Services Q2 2017/18 goal: Migrate a subset of jobs to multi-DC enabled event processing infrastructure. - https://phabricator.wikimedia.org/T175212#3862504 (10mobrovac) 05Open>03Resolved For all intents and purposes, this task h... [12:57:22] 10Vector, 10Patch-For-Review: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards - https://phabricator.wikimedia.org/T182602#3862509 (10matmarex) It's the same cause (we allowed all kinds of menus and popups to open upwards), but it will pr... [12:57:27] (03CR) 10Nikerabbit: [C: 04-1] "Outside Wikimedia, ULS stores geolocation info in mw.cookie.get( 'ULSGeo' )." (034 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400266 (https://phabricator.wikimedia.org/T111094) (owner: 10Petar.petkovic) [12:58:29] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862510 (10Aklapper) See https://developer.apple.com/safari/tools/ which shows a "Network" tab. I do not have any systems that can run... [13:00:36] 10Cassandra, 10RESTBase, 10RESTBase-Cassandra, 10Goal, 10Services (doing): FY17/18 Q3 Program 7 Services Goal: Full migration to Cassandra 3 - https://phabricator.wikimedia.org/T183745#3862511 (10mobrovac) p:05Triage>03Normal [13:00:59] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 40 - campaign enhancement - https://phabricator.wikimedia.org/T183742#3862523 (10tmletzko) tracks are in. you can enable [13:01:31] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862525 (10Tacsipacsi) Of course, the actual archive bot works as expected, as it doesn’t use the latest code (it uses a cust... [13:03:00] 10Cassandra, 10RESTBase, 10RESTBase-Cassandra, 10Goal, 10Services (doing): FY17/18 Q3 Program 7 Services Goal: Full migration to Cassandra 3 - https://phabricator.wikimedia.org/T183745#3862529 (10mobrovac) [13:03:02] 10Cassandra, 10RESTBase, 10RESTBase-Cassandra, 10Epic, and 2 others: Program 7 Outcome 2 Objective 1, Q2: Develop a scalable and cost-effective storage solution for backing the REST API - https://phabricator.wikimedia.org/T179416#3862530 (10mobrovac) [13:03:06] 10Mathoid, 10RESTBase, 10RESTBase-Cassandra, 10Services (blocked): Migrate mathoid storage from legacy to new strategy - https://phabricator.wikimedia.org/T179419#3862528 (10mobrovac) [13:03:42] 10Cassandra, 10RESTBase, 10RESTBase-Cassandra, 10Epic, and 2 others: Program 7 Outcome 2 Objective 1, Q2: Develop a scalable and cost-effective storage solution for backing the REST API - https://phabricator.wikimedia.org/T179416#3723954 (10mobrovac) [13:03:44] 10Cassandra, 10RESTBase, 10RESTBase-Cassandra, 10Goal, 10Services (doing): FY17/18 Q3 Program 7 Services Goal: Full migration to Cassandra 3 - https://phabricator.wikimedia.org/T183745#3862511 (10mobrovac) [13:03:47] 10Cassandra, 10Services (doing), 10User-Eevans: Investigate aberrant Cassandra columnfamily read latency of restbase101{0,2,4} - https://phabricator.wikimedia.org/T178177#3862531 (10mobrovac) [13:04:25] 10Cassandra, 10RESTBase, 10RESTBase-Cassandra, 10Goal, 10Services (doing): FY17/18 Q3 Program 7 Services Goal: Full migration to Cassandra 3 - https://phabricator.wikimedia.org/T183745#3862511 (10mobrovac) [13:04:28] 10Cassandra, 10RESTBase, 10Services (doing), 10User-Eevans: Clean metrics for restbase erroneus legacy tables from cassandra 3 cluster - https://phabricator.wikimedia.org/T181964#3862534 (10mobrovac) [13:04:31] 10Parsoid, 10RESTBase, 10RESTBase-Cassandra, 10Services (done): Migrate Parsoid from legacy to new storage - https://phabricator.wikimedia.org/T179417#3862536 (10mobrovac) [13:04:58] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862537 (10Tacsipacsi) The first section of [[https://hu.wikipedia.org/w/index.php?title=Wikipédia:Járőrök_üzenőfala&oldid=19... [13:06:55] (03CR) 10Mobrovac: [C: 031] "LGTM, +1. Leaving to Petr and Kunal to double-check it." [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [13:07:39] 10MediaWiki-extensions-Linter: Provide additional Linter statistics about template-generated issues - https://phabricator.wikimedia.org/T170874#3862538 (10He7d3r) On ptwiki, I prioritized the list of "tidy-font-bug" by starting with the most transcluded templates containing errors: https://quarry.wmflabs.org/que... [13:10:32] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 40 - campaign enhancement - https://phabricator.wikimedia.org/T183742#3862540 (10kai.nissen) started on 2017-12-28 at 14:15 CET [13:10:43] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 39 - dark blue - https://phabricator.wikimedia.org/T183715#3862541 (10kai.nissen) ended on 2017-12-28 at 14:15 CET [13:14:31] 10Wikidata: Wikidata database corruption? - https://phabricator.wikimedia.org/T181486#3862543 (10Rical) The bug happens when I query the first data from wikibase, not when I configure the link using wikibase.getEntityIdForTitle(). No matter Firefox or Chromium. [13:15:37] (03PS1) 10Addshore: [MCR] pass $queryFlags into RevisionStore::getTitle [core] - 10https://gerrit.wikimedia.org/r/400577 (https://phabricator.wikimedia.org/T183716) [13:16:12] (03PS1) 10Addshore: Remove duplicate getTitle call in RevisionStore::getNextRevision [core] - 10https://gerrit.wikimedia.org/r/400578 [13:22:46] 10Operations, 10Traffic, 10Browser-Support-Internet-Explorer, 10Patch-For-Review, 10User-notice: Removing support for DES-CBC3-SHA TLS cipher (drops IE8-on-XP support) - https://phabricator.wikimedia.org/T147199#2684468 (10Izno) Just for documentation's sake, this ended AutoWikiBrowser on XP ([[https://e... [13:24:52] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862556 (10He7d3r) [13:32:02] 10Commons, 10Wikimedia-Site-requests, 10Patch-For-Review: "Add pages I create and files I upload to my watchlist" should be checked by default on Commons - https://phabricator.wikimedia.org/T178750#3701646 (10Steinsplitter) See [[https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals#Watch_creatio... [13:35:58] 10Commons, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: "Add pages I create and files I upload to my watchlist" should be checked by default on Commons - https://phabricator.wikimedia.org/T178750#3862572 (10Urbanecm) a:03Urbanecm Will do. [13:40:39] 10MediaWiki-Containers: Apache in mediawiki-docker(wikimedia/mediawiki) crashes because the Apache was complaining about MEDIAWIKI_RESTBASE_URL - https://phabricator.wikimedia.org/T151051#3862576 (10Addshore) [13:40:42] 10MediaWiki-Containers: Apache in mediawiki-docker(wikimedia/mediawiki) crashes because the Apache was complaining about MEDIAWIKI_RESTBASE_URL - https://phabricator.wikimedia.org/T151051#2805758 (10Addshore) [13:40:49] (03CR) 10Petar.petkovic: Add nearby suggestions (034 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400266 (https://phabricator.wikimedia.org/T111094) (owner: 10Petar.petkovic) [13:42:37] (03PS1) 10Urbanecm: Set 'watchcreations' preference to true by default on Commons [mediawiki-config] - 10https://gerrit.wikimedia.org/r/400579 (https://phabricator.wikimedia.org/T178750) [13:45:25] 04(no projects): Context-dependent sort key: SECTIONSORT - https://phabricator.wikimedia.org/T183747#3862579 (10Takasugi_Shinji) [13:46:09] (03CR) 10Esanders: "This changes the DOM output from being inline-block (img) to block (div). While it wouldn't be very sensible to use scores inline, people " [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 (https://phabricator.wikimedia.org/T114757) (owner: 10Ebe123) [13:47:00] (03CR) 10Petar.petkovic: Support long titles in selected source page (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400452 (https://phabricator.wikimedia.org/T181701) (owner: 10Petar.petkovic) [13:47:02] 10Commons, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: "Add pages I create and files I upload to my watchlist" should be checked by default on Commons - https://phabricator.wikimedia.org/T178750#3701646 (10Urbanecm) Patch uploaded. Will be deployed at January 2nd. If anybody have time,... [13:47:04] 10MediaWiki-Parser: Create context-dependent sort key SECTIONSORT for use on Wiktionary (in addition to DEFAULTSORT) - https://phabricator.wikimedia.org/T183747#3862590 (10Aklapper) p:05Triage>03Low [13:48:10] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862595 (10Dvorapa) I don't understand what is wrong. For me everything is working with pages you listed. The whole code to t... [13:48:31] (03PS2) 10Petar.petkovic: Support long titles in selected source page [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400452 (https://phabricator.wikimedia.org/T181701) [13:48:59] 10Wikimedia-Site-requests, 10User-Urbanecm: Arbcom wikis are in both wikipedia.dblist and special.dblist - https://phabricator.wikimedia.org/T183549#3862597 (10Urbanecm) p:05Triage>03Low [13:50:52] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Banner 41 - two pager - https://phabricator.wikimedia.org/T183748#3862599 (10tmletzko) [13:52:22] 10Edit-Review-Improvements, 10Operations, 10Collaboration-Feature-Rollouts (Collaboration-WL-Graduated-Everywhere), 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3625823 (10... [13:52:26] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862615 (10Dvorapa) >>! In T182496#3862525, @Tacsipacsi wrote: > If you’re speaking about lines 471–474 You should test the... [13:52:48] (03PS4) 10Petar.petkovic: Add nearby suggestions [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400266 (https://phabricator.wikimedia.org/T111094) [13:53:58] 10Front-end-Standards-Group, 10Performance-Team: Avoid or minimise impact of "unready" Grade A state - https://phabricator.wikimedia.org/T183720#3861747 (10Izno) This problem manifests on changes lists with the beta filters option (possibly specific to ORES/Wikidata changes/enhanced RC/WL). [13:55:32] 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3862618 (10Urbanecm) [13:58:54] 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: class="wikitable plainrowheaders" does not work in mobile - https://phabricator.wikimedia.org/T183704#3862620 (10Izno) This is not a code-in task. Plainrowheaders are supported at the community level, not the code level, and nee... [14:01:14] 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3862622 (10Urbanecm) Waiting on system administrator who will reserve a window and create the Wiki for real. @Dereckson, will we wait for another wikis? [14:02:28] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862624 (10Dvorapa) Please provide an example of an unexpected behavior I could test on clean updated pywikibot installation.... [14:02:32] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862083 (10Izno) I'm sure there's a reason for this request, but what is that reason? [14:08:31] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862627 (10Cyberpower678) >>! In T183733#3862625, @Izno wrote: > I'm sure there's a reason for this request, but what is that reason? IABot makes use of these identifiers to identify which wiki to access. Making... [14:14:27] 04(no projects): Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#3862628 (10Pginer-WMF) [14:14:42] 10Collaboration-Team-Triage, 10Notifications, 10UI-Standardization: Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#3862638 (10Pginer-WMF) [14:19:07] 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should ignore section headers within 'nowiki' segments (and commented out segments) - https://phabricator.wikimedia.org/T182496#3862640 (10Tacsipacsi) I used the current master code (with some lines added for printing section titles) for testing (so I d... [14:19:33] 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Google-Code-in-2017: Flow: Notification icons point to different directions - https://phabricator.wikimedia.org/T161330#3862642 (10Pginer-WMF) >>! In T161330#3862257, @Aklapper wrote: > Could someone clarify what is wanted here, so th... [14:20:53] 10Collaboration-Team-Triage, 10Notifications, 10UI-Standardization: Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#3862628 (10Pginer-WMF) [14:23:51] 10MediaWiki-General-or-Unknown: W3C Validator complains about
elements missing
children, and some unknown "language" parameter values - https://phabricator.wikimedia.org/T168624#3862651 (10Izno) [14:23:54] 10MediaWiki-Parser, 10Parsoid, 10Accessibility: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing - https://phabricator.wikimedia.org/T6521#3862649 (10Izno) [14:28:55] 10DBA, 10Operations, 10ops-codfw: pc2005 CPU2 internal error - https://phabricator.wikimedia.org/T183750#3862652 (10Marostegui) [14:29:21] 10DBA, 10Operations, 10ops-codfw: pc2005 CPU2 internal error - https://phabricator.wikimedia.org/T183750#3862652 (10Marostegui) p:05Triage>03Normal [14:29:28] 10DBA, 10Operations, 10ops-codfw: pc2005 crashed: CPU2 internal error - https://phabricator.wikimedia.org/T183750#3862652 (10Marostegui) [14:30:50] 10MediaWiki-General-or-Unknown: W3C Validator complains about
elements missing
children, and some unknown "language" parameter values - https://phabricator.wikimedia.org/T168624#3862667 (10Izno) I've merged the task because the rest of it is invalid. The reason the validator complains about the languag... [14:31:30] (03CR) 10MarkAHershberger: "The script was a quick way for me to test the functionality of the code I wrote. Looking at this again, after a night of sleep, though, I" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 (owner: 10MarkAHershberger) [14:31:41] (03CR) 10Awight: [C: 04-1] "Please also include tests for updateModelVersion" (037 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) (owner: 10Ladsgroup) [14:37:56] 10DBA, 10Operations, 10ops-codfw: pc2005 crashed: CPU2 internal error - https://phabricator.wikimedia.org/T183750#3862668 (10Marostegui) [14:42:18] 10Internet-Archive, 10InternetArchiveBot: Bad url not recognized - https://phabricator.wikimedia.org/T183751#3862669 (10Igel_B_TyMaHe) [14:45:17] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [QA] Exploratory testing when users with multiple devices use synced reading lists - https://phabricator.wikimedia.org/T177309#3862680 (10RHo) [14:54:23] (03PS1) 10Thiemo Kreuz (WMDE): Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 [14:55:25] (03CR) 10jerkins-bot: [V: 04-1] Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 (owner: 10Thiemo Kreuz (WMDE)) [14:58:58] (03PS1) 10Thiemo Kreuz (WMDE): Remove some obscure comments [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 [15:02:06] 10MediaWiki-Vagrant, 10Scoring-platform-team, 10Patch-For-Review: Clean up ORES vagrant role - https://phabricator.wikimedia.org/T181850#3862683 (10awight) [15:04:40] (03CR) 10jerkins-bot: [V: 04-1] Remove some obscure comments [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [15:08:04] (03PS1) 10Thiemo Kreuz (WMDE): Remove @param comments that literally repeat what the code says [core] - 10https://gerrit.wikimedia.org/r/400582 [15:11:29] (03CR) 10Zppix: [C: 031] "LGTM" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/400579 (https://phabricator.wikimedia.org/T178750) (owner: 10Urbanecm) [15:13:53] (03PS1) 10Thiemo Kreuz (WMDE): Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 [15:16:13] 10MediaWiki-extensions-Newsletter: Newsletters with non-main-namespace pages don't work correctly - https://phabricator.wikimedia.org/T183752#3862684 (10Pppery) [15:19:36] (03PS1) 10Thiemo Kreuz (WMDE): Simplify documentation headers of includes/widgets/…Widget.php files [core] - 10https://gerrit.wikimedia.org/r/400584 [15:22:05] (03PS1) 10Thiemo Kreuz (WMDE): Remove very, very old disabled test cases and todos [core] - 10https://gerrit.wikimedia.org/r/400585 [15:22:41] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3862695 (10Pppery) 05Open>03Resolved Closing task as resolve... [15:25:15] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862698 (10Glendales) Ok, i found the network tab - but what do I do with it? [15:27:47] (03CR) 10jerkins-bot: [V: 04-1] Remove very, very old disabled test cases and todos [core] - 10https://gerrit.wikimedia.org/r/400585 (owner: 10Thiemo Kreuz (WMDE)) [15:30:39] 10MediaWiki-extensions-Newsletter: Add a way to view the list of subscribers to newsletter - https://phabricator.wikimedia.org/T110192#3862700 (10Pppery) [15:30:42] 10MediaWiki-extensions-Newsletter, 10Google-Code-In-2016: New subpage to list down subscribers for a newsletter - https://phabricator.wikimedia.org/T153639#3862703 (10Pppery) [15:31:00] (03PS1) 10Thiemo Kreuz (WMDE): Remove leading backslashes from "use \…" tags [core] - 10https://gerrit.wikimedia.org/r/400586 [15:31:57] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10Design, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3849035 (10Pablo-WMDE) a:05Pablo-WMDE>03None [15:32:21] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862706 (10Reedy) It's nothing to do with MySQL, AFAIK. It's obvious that MW hasn't truncated the string properly, the question is why. What content language is set on the... [15:32:32] (03PS1) 10Thiemo Kreuz (WMDE): Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 [15:32:42] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10Design, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3849035 (10Pablo-WMDE) * made 660px the break point for "Mobile Banner", kept it in the same code PR https://github.c... [15:33:14] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183620#3862709 (10divadsn) a:03divadsn Will do that :) [15:34:59] (03PS1) 10Thiemo Kreuz (WMDE): Start using RevisionRecord in favor of Revision in trivial cases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400588 [15:41:49] (03PS7) 10Thiemo Kreuz (WMDE): Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [15:42:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [15:43:08] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862711 (10Izno) >>! In T183733#3862627, @Cyberpower678 wrote: >>>! In T183733#3862625, @Izno wrote: >> I'm sure there's a reason for this request, but what is that reason? > > IABot makes use of these identifiers... [15:43:09] (03CR) 10Thiemo Kreuz (WMDE): "The test failure can not be related as this patch exclusively touches PHPDoc comments." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 (owner: 10Thiemo Kreuz (WMDE)) [15:43:31] (03CR) 10GeoffreyT2000: [C: 031] "Introducing a "$wmgWatchPagesCreated" variable sounds like a great idea to me." [mediawiki-config] - 10https://gerrit.wikimedia.org/r/400579 (https://phabricator.wikimedia.org/T178750) (owner: 10Urbanecm) [15:46:32] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862712 (10Cyberpower678) I believe it does. I believe the global user page is transmitted as wiki text to the local page, and then rendered locally. If I place a working template on my meta template, that doesn'... [15:49:16] (03PS2) 10Thiemo Kreuz (WMDE): Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 [15:49:36] (03PS1) 10Pppery: Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) [15:50:22] (03Merged) 10jenkins-bot: Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [15:54:19] 10Commons, 10MediaWiki-File-management, 10MediaWiki-Special-pages, 10Multimedia, and 2 others: Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki - https://phabricator.wikimedia.org/T181651#3797130 (10Ebe123) I'd be willing to mentor this task. [15:59:12] (03CR) 10jenkins-bot: Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [16:09:01] (03CR) 10Thcipriani: [C: 031] "> Do I really need to add the dumps repo here or will it be picked up" (031 comment) [puppet] - 10https://gerrit.wikimedia.org/r/400237 (owner: 10ArielGlenn) [16:10:55] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862083 (10matmarex) You can already use `{{SERVERNAME}}`, "en.wikipedia.org" is probably more useful than "enwiki" for most cases anyway. https://www.mediawiki.org/wiki/Help:Magic_words#Technical_metadata This wi... [16:12:12] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862723 (10Cyberpower678) >>! In T183733#3862720, @matmarex wrote: > You can already use `{{SERVERNAME}}`, "en.wikipedia.org" is probably more useful than "enwiki" for most cases anyway. https://www.mediawiki.org/w... [16:30:41] (03CR) 1001tonythomas: "Can you add a unit test which verify the same ?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [16:32:23] (03CR) 10Ladsgroup: [C: 032] Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [16:32:51] (03CR) 10Florianschmidtwelzow: [C: 04-1] Improve visual hierarchy on Newsletter page (033 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [16:33:59] (03CR) 10Ladsgroup: [C: 032] Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:36:46] (03PS1) 10ArielGlenn: update for stretch build of same source [debs/mwbzutils] - 10https://gerrit.wikimedia.org/r/400590 [16:37:19] (03CR) 10Ladsgroup: [C: 032] Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [16:38:20] (03CR) 10Ladsgroup: [C: 032] Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [16:39:12] (03Merged) 10jenkins-bot: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [16:39:32] (03CR) 10Pppery: "The code with which I'm making changes to has no tests at all to begin with, so it's not exactly clear where I should put such a test." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [16:40:32] (03PS4) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) [16:40:37] (03CR) 10Ladsgroup: "Done :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [16:41:13] (03CR) 10jerkins-bot: [V: 04-1] Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:42:15] (03CR) 10ArielGlenn: [C: 032] update for stretch build of same source [debs/mwbzutils] - 10https://gerrit.wikimedia.org/r/400590 (owner: 10ArielGlenn) [16:42:25] (03CR) 10Ladsgroup: [C: 032] "Kicking jenkins" [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:42:38] (03PS1) 10Eisenhaus335: Creating daemonzie_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400591 [16:44:52] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonzie_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400591 (owner: 10Eisenhaus335) [16:45:18] (03Merged) 10jenkins-bot: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [16:47:05] (03CR) 1001tonythomas: "Ideally, it should go to mediawiki-extensions-Newsletter/tests/content/" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [16:47:47] (03Merged) 10jenkins-bot: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [16:51:09] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400592 [16:51:29] (03PS2) 10Pppery: Update i18n messages using old "view subscribers" terminology [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/331202 [16:52:34] (03CR) 10Ladsgroup: [C: 032] Remove some obvious, self-explaining PHPDoc snippets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400569 (owner: 10Thiemo Kreuz (WMDE)) [16:52:55] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400592 (owner: 10Eisenhaus335) [16:53:40] (03Merged) 10jenkins-bot: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:54:55] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400593 [16:55:34] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [16:57:09] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400593 (owner: 10Eisenhaus335) [16:57:56] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Generalize wording of audio formats in the code - https://phabricator.wikimedia.org/T183753#3862728 (10Ebe123) p:05Triage>03Normal [17:00:56] (03CR) 10Ladsgroup: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [17:01:59] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Generalize wording of audio formats in the code - https://phabricator.wikimedia.org/T183753#3862739 (10Ebe123) https://codein.withgoogle.com/dashboard/tasks/6221738243260416/ [17:02:32] 10TCB-Team, 10Wikimedia-General-or-Unknown, 10Developer-Relations (Jan-Mar-2018), 10User-Tgr: Provide an easy to use support system for contributors to ask technical questions - https://phabricator.wikimedia.org/T155678#3862740 (10MZMcBride) >>! In T155678#3861681, @Qgil wrote: > Let's consider the [[ http... [17:02:34] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862741 (10Ebe123) https://codein.withgoogle.com/dashboard/tasks/4771869758586880/ [17:03:06] 10Commons, 10MediaWiki-File-management, 10MediaWiki-Special-pages, 10Multimedia, and 2 others: Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki - https://phabricator.wikimedia.org/T181651#3862743 (10Ebe123) https://codein.withgoogle.com/dashboard/tasks/5677924248190976/ [17:03:45] (03Merged) 10jenkins-bot: Remove some obvious, self-explaining PHPDoc snippets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400569 (owner: 10Thiemo Kreuz (WMDE)) [17:03:50] (03CR) 10jenkins-bot: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [17:04:22] 10Developer-Relations, 10Operations, 10cloud-services-team (Kanban): Create discourse-mediawiki.wmflabs.org (pilot instance) - https://phabricator.wikimedia.org/T180854#3862744 (10MZMcBride) [17:04:57] (03CR) 10jenkins-bot: Remove some obvious, self-explaining PHPDoc snippets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400569 (owner: 10Thiemo Kreuz (WMDE)) [17:07:23] 10MediaWiki-extensions-Newsletter, 10Patch-For-Review: Newsletters with non-main-namespace main pages don't work correctly - https://phabricator.wikimedia.org/T183752#3862745 (10Pppery) [17:09:56] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400594 [17:10:19] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862746 (10Kghbln) > It's nothing to do with MySQL, AFAIK. It's obvious that MW hasn't truncated the string properly, the question is why. Ah, ok. No worries. I trust your... [17:10:23] (03CR) 10Brian Wolff: "tbh, I'm undecided if removing these is actually best" [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [17:12:13] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400594 (owner: 10Eisenhaus335) [17:13:11] (03CR) 10jenkins-bot: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [17:13:52] (03PS2) 10Bartosz Dziewoński: Add release notes for v0.24.4 [oojs/ui] - 10https://gerrit.wikimedia.org/r/399474 (owner: 10VolkerE) [17:14:00] (03CR) 10Brian Wolff: "Well this is correct that there is no need to escape quotes, is there really any benefit here? Using ENT_NOQUOTES means that reviewers hav" [core] - 10https://gerrit.wikimedia.org/r/390223 (owner: 10Fomafix) [17:14:04] (03CR) 10Bartosz Dziewoński: [C: 04-2] "To be merged after we actually release it, eh" [oojs/ui] - 10https://gerrit.wikimedia.org/r/399474 (owner: 10VolkerE) [17:21:52] (03CR) 10jenkins-bot: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [17:24:33] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400595 [17:24:35] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400596 [17:25:32] 10Google-Code-in-2017: Convert MediaWiki Templates on Commons to make them Translateable - https://phabricator.wikimedia.org/T179225#3862747 (10Aklapper) I think both could be fine, however I simply would not know how to //identify// templates //in need// of being marked as translatable. That should be covered i... [17:26:09] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400595 (owner: 10Eisenhaus335) [17:26:18] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400596 (owner: 10Eisenhaus335) [17:30:32] (03CR) 10jenkins-bot: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [17:31:16] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400597 [17:31:52] 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3862748 (10Isarra) @grey-bright is what is used for image borders in thumbs. It should be the same. Whether or not the value is too light in general is a separa... [17:33:09] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400597 (owner: 10Eisenhaus335) [17:33:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] Improve visual hierarchy on Newsletter page (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [17:34:27] (03PS1) 10ArielGlenn: add wmflabs config for dumps scap [dumps/scap] - 10https://gerrit.wikimedia.org/r/400598 [17:39:44] (03CR) 10ArielGlenn: "really no idea if this is how to set up targets for labs, I just stole from someone else..." [dumps/scap] - 10https://gerrit.wikimedia.org/r/400598 (owner: 10ArielGlenn) [17:42:13] 10WMDE-Fun-Team, 10WMDE-Fundraising-Funban-2: Thank You banner (2) - https://phabricator.wikimedia.org/T183538#3862749 (10gabriel-wmde) A preview of the current state is at https://de.wikipedia.org/wiki/Wikipedia:Hauptseite?banner=B17WMDE_thankyou_authors&force=1 TODO (at least as far as I can see): * Switch... [17:43:16] (03PS2) 10Albert221: Improve visual hierarchy on Newsletter page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) [17:44:34] 10Wiki-Loves-Monuments (2017): Move WLM-IL tasks to Wikidata - https://phabricator.wikimedia.org/T183713#3862750 (10eranroz) >>! In T183713#3861489, @LilyOfTheWest wrote: > Can you also check if Wikidata already has a property corresponding to your monuments? Can you please clarify what kind of property we are... [17:45:08] (03PS1) 10Eisenhaus335: Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400599 [17:47:10] (03CR) 10jerkins-bot: [V: 04-1] Creating daemonize_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400599 (owner: 10Eisenhaus335) [17:48:55] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: Individual newsletter pages should have a visual hierarchy - https://phabricator.wikimedia.org/T180982#3862751 (10Florian) That's the result of the patch: {F12107908} [17:49:12] (03CR) 10Florianschmidtwelzow: [C: 032] Improve visual hierarchy on Newsletter page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [17:49:22] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: Individual newsletter pages should have a visual hierarchy - https://phabricator.wikimedia.org/T180982#3862752 (10Florian) 05Open>03Resolved a:03Florian [17:49:24] 10Analytics, 10Research: Formal announcement of productized clickstream dataset - https://phabricator.wikimedia.org/T183097#3862754 (10DarTar) p:05Triage>03Low [17:50:48] (03Merged) 10jenkins-bot: Improve visual hierarchy on Newsletter page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [17:52:46] (03CR) 10Tpt: [C: 032] Remove obvious, non-helpful documentation snippets [extensions/SemanticGenealogy] - 10https://gerrit.wikimedia.org/r/400574 (owner: 10Thiemo Kreuz (WMDE)) [17:53:27] (03Merged) 10jenkins-bot: Remove obvious, non-helpful documentation snippets [extensions/SemanticGenealogy] - 10https://gerrit.wikimedia.org/r/400574 (owner: 10Thiemo Kreuz (WMDE)) [17:56:07] (03CR) 10Addshore: Remove spaces from the "Wikibase …" extension names (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/400570 (owner: 10Thiemo Kreuz (WMDE)) [17:59:16] (03PS2) 10Ladsgroup: Update model version when it's different in ScoreParser [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) [17:59:33] (03CR) 10Ladsgroup: "Tests added" (034 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) (owner: 10Ladsgroup) [17:59:55] 10Wikidata: Wikidata database corruption? - https://phabricator.wikimedia.org/T181486#3791841 (10Tpt) @Rical > Erreur Lua dans Module:Central-s-fr à la ligne 1709 : attempt to index global 'wikibase' (a nil value). I do not see the relation between this error and the topic of this task. The function `getEntityI... [18:13:33] 10Research, 10Research-management: Baha: Systems and programs onboarding - https://phabricator.wikimedia.org/T183754#3862759 (10DarTar) [18:13:43] 10Research, 10Research-management: Baha: Systems and programs onboarding - https://phabricator.wikimedia.org/T183754#3862774 (10DarTar) p:05Triage>03Normal [18:19:20] (03PS1) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [18:20:46] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [18:23:08] 10Research, 10Research-management, 10Research-outreach, 10Epic: Subdomain and hosting for research landing page - https://phabricator.wikimedia.org/T179871#3862778 (10DarTar) a:05DarTar>03bmansurov [18:28:12] (03CR) 10Phantom42: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [18:32:59] (03PS1) 10Jayprakash: Add lfn.wikipedia.org to RESTBase [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/400601 (https://phabricator.wikimedia.org/T183561) [18:36:32] (03CR) 10Jayprakash: [C: 04-1] "until wiki creation." [services/restbase/deploy] - 10https://gerrit.wikimedia.org/r/400601 (https://phabricator.wikimedia.org/T183561) (owner: 10Jayprakash) [18:37:25] (03CR) 10Divadsn: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [18:38:06] (03PS2) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [18:41:49] (03Draft1) 10Addshore: Revert "[MCR] Add optional $title param to Revision byId methods" [core] - 10https://gerrit.wikimedia.org/r/400602 (https://phabricator.wikimedia.org/T183505) [18:43:09] (03CR) 10Thiemo Kreuz (WMDE): "recheck" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [18:43:21] (03CR) 10Thiemo Kreuz (WMDE): "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 (owner: 10Thiemo Kreuz (WMDE)) [18:44:35] (03PS2) 10Thiemo Kreuz (WMDE): Remove very, very old disabled test cases and todos [core] - 10https://gerrit.wikimedia.org/r/400585 [18:44:51] (03PS1) 10Addshore: Revert "Pass a Title to Revision::newFromId in onRevisionInsertComplete" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400603 [18:45:36] (03PS2) 10Thiemo Kreuz (WMDE): Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) [18:49:08] (03CR) 10jerkins-bot: [V: 04-1] Remove some obscure comments [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [18:49:43] (03CR) 10Ppchelko: [C: 031] "LGTM as well" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [18:52:11] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [18:57:53] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Change the user-created list name if it the same name as the default list - https://phabricator.wikimedia.org/T183588#3857804 (10Tgr) Is this (list name uniqueness) something that should be enforced... [19:01:55] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [19:03:21] (03PS1) 10Thiemo Kreuz (WMDE): Improve 1-letter variable names in MutableContext and implementations [core] - 10https://gerrit.wikimedia.org/r/400606 [19:09:02] 10MediaWiki-extensions-InputBox, 10UI-Standardization, 10Google-Code-in-2017: Convert InputBox to use OOUI where possible - https://phabricator.wikimedia.org/T106948#3862791 (10matmarex) I don't think it makes sense to convert only one of the many forms. Using OOUI instead of plain HTML elements d... [19:09:36] (03CR) 10Thiemo Kreuz (WMDE): "I'm happy to revert individual lines if you think it's better to keep some of these comments. (TBH, I will most probably write an actual c" [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [19:10:32] 10Wikidata: Wikidata database corruption? - https://phabricator.wikimedia.org/T181486#3862792 (10Rical) Your help answer the question. Many thanks. Sorry to have disturb this task. [19:11:04] 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?) - https://phabricator.wikimedia.org/T183435#3862794 (10ma... [19:11:36] (03CR) 10Thiemo Kreuz (WMDE): "I get a weird error message about Phan in an unrelated patch now, see I9c128f7. Can you tell me what's going on there, or help me fix this" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:13:29] (03PS3) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:14:35] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:15:31] (03PS4) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:15:50] (03PS1) 10Thiemo Kreuz (WMDE): Remove leading backslashes from "use \…" tags [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400607 [19:16:23] (03CR) 10Phantom42: [C: 031] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:16:51] (03Draft1) 10Addshore: Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next" [core] - 10https://gerrit.wikimedia.org/r/400604 [19:16:56] (03CR) 10Addshore: [V: 031] Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next" [core] - 10https://gerrit.wikimedia.org/r/400604 (owner: 10Addshore) [19:17:01] (03CR) 10Addshore: [V: 031] Revert "[MCR] Add optional $title param to Revision byId methods" [core] - 10https://gerrit.wikimedia.org/r/400602 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [19:17:02] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:17:11] (03CR) 10Addshore: [V: 031] [MCR] pass $queryFlags into RevisionStore::getTitle [core] - 10https://gerrit.wikimedia.org/r/400577 (https://phabricator.wikimedia.org/T183716) (owner: 10Addshore) [19:18:05] (03PS2) 10Addshore: [MCR] Revision::newFromArchiveRow remove recently added $title param [core] - 10https://gerrit.wikimedia.org/r/400605 [19:19:35] (03CR) 10Phantom42: "The problem is that change I4cc1fab which added phan checks to zuul is already merged, while this one, which adds needed config and fixes " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:19:38] (03CR) 10Divadsn: "Ok, let me see later why it fails" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:23:56] (03CR) 10Phantom42: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:24:05] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Revision::newFromArchiveRow remove recently added $title param [core] - 10https://gerrit.wikimedia.org/r/400605 (owner: 10Addshore) [19:25:55] (03PS3) 10Thiemo Kreuz (WMDE): Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) [19:29:10] (03PS5) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:29:15] (03CR) 10Divadsn: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:29:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Brian, I understand the concern and find it very valid, but unfortunately can't see how it applies here. These two methods don't return an" [core] - 10https://gerrit.wikimedia.org/r/390223 (owner: 10Fomafix) [19:30:00] (03PS6) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:30:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [19:31:29] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:31:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Use ExtensionRegistry instead of class_exists (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [19:32:14] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400607 (owner: 10Thiemo Kreuz (WMDE)) [19:36:29] (03CR) 10Phantom42: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:38:38] (03PS7) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:41:47] (03CR) 10Divadsn: "Anyway, thanks Phantom42 :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:43:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Clean up ThresholdLookup, make the cache key use model version (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) (owner: 10Ladsgroup) [19:44:25] (03CR) 10Phantom42: [C: 031] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:44:49] (03Merged) 10jenkins-bot: Clean up ThresholdLookup, make the cache key use model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) (owner: 10Ladsgroup) [19:45:18] 10Africa-Wikimedia-Developers, 10MediaWiki-extensions-SendGrid: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3862798 (10D3r1ck01) [19:46:05] 10Africa-Wikimedia-Developers, 10MediaWiki-extensions-SendGrid: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3630149 (10D3r1ck01) >>! In T176575#3858900, @BamLifa wrote: > @D3r1ck01 I am ready to improve the README. Assign it to me @BamLifa, what's your progre... [19:47:34] 10Africa-Wikimedia-Developers, 10Toolforge, 10Wikidata, 10Documentation: Wiki(pedi&dat)a RSS user manual updates & IFTTT Flask application UI improvements (on Toolforge) - https://phabricator.wikimedia.org/T146750#3862800 (10D3r1ck01) [19:48:00] (03PS1) 10Nikerabbit: [puppet] Pin elasticsearch to avoid cron spam [translatewiki] - 10https://gerrit.wikimedia.org/r/400608 [19:52:20] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [19:58:26] (03PS3) 10Addshore: [MCR] Revision::newFromArchiveRow remove recently added $title param [core] - 10https://gerrit.wikimedia.org/r/400605 [19:59:51] 10Cloud-Services, 10PAWS: paws: 502 bad gateway - https://phabricator.wikimedia.org/T183142#3862801 (10madhuvishy) I think this is fixed now, and PAWS is back up. Hub pods were on CrashLoopBackOff, and I looked at the hub pod logs and found this: ``` [E 2017-12-28 18:51:08.521 JupyterHub app:1626] Traceb... [20:00:11] 10Cloud-Services, 10PAWS: paws: 502 bad gateway - https://phabricator.wikimedia.org/T183142#3862802 (10madhuvishy) p:05High>03Normal [20:00:30] (03PS1) 10Ryan10145: Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) [20:04:21] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862807 (10Legoktm) For cases where Remex changes the rendering, the "edit" link uses the ParserMigration tool that will show a diff of the current rendering, and the future broken rend... [20:05:48] (03CR) 10Anomie: "I note that the MediaWiki.Commenting.FunctionComment.MissingParamComment phpcs sniff (currently disabled here) complains about the lack of" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [20:06:26] 10Community-Liaisons, 10Contributors-Team, 10MediaWiki-Page-editing, 10MediaWiki-extensions-WikibaseRepository, and 8 others: Re-label the "Save" links to be "Publish" in structured data inline edit links on Wikidata.org - https://phabricator.wikimedia.org/T161367#3862809 (10Lea_Lacroix_WMDE) Announcement... [20:06:43] (03CR) 10Legoktm: [C: 032] "Nice work :)" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [20:07:49] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862810 (10ssastry) >>! In T183746#3862807, @Legoktm wrote: > For cases where Remex changes the rendering, the "edit" link uses the ParserMigration tool that will show a diff of the cur... [20:08:15] (03CR) 10Legoktm: [C: 032] uprightdiff (1.3.0-1) unstable; urgency=medium [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/387521 (owner: 10Legoktm) [20:08:15] (03Merged) 10jenkins-bot: Fix unintentionally created global functions in EventBusHooks [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [20:09:14] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862812 (10ssastry) >>! In T183746#3862810, @ssastry wrote: >>>! In T183746#3862807, @Legoktm wrote: >> For cases where Remex changes the rendering, the "edit" link uses the ParserMigra... [20:09:45] (03Merged) 10jenkins-bot: uprightdiff (1.3.0-1) unstable; urgency=medium [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/387521 (owner: 10Legoktm) [20:10:16] (03CR) 10Phantom42: "Thank you for reviewing and merging!" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [20:10:46] 10Analytics, 10EventBus, 10Google-Code-in-2017, 10Patch-For-Review, 10Technical-Debt: EventBusHooks::onArticleRevisionVisibilitySet should not create global functions - https://phabricator.wikimedia.org/T183730#3862813 (10Legoktm) 05Open>03Resolved >>! In T183730#3862416, @Phantom42 wrote: > By the w... [20:13:41] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 2 others: Create maintenance script for cleaning up stale indexes - https://phabricator.wikimedia.org/T166243#3862815 (10Smalyshev) > It's unclear to me which codebase this is about, CirrusSearch extension, specifically maintenance scripts. I've... [20:22:25] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862819 (10Phantom42) a:03Phantom42 I will work on this migration! [20:23:52] (03CR) 10Legoktm: [C: 04-1] "Please do not remove copyright statements without the approval of the copyright holders." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [20:26:17] (03CR) 1001tonythomas: [C: 04-1] "https://phabricator.wikimedia.org/source/mediawiki/browse/master/tests/phpunit/MediaWikiTestCase.php;8eaee6fd06d9089ef90032530af9a9d25a52a" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [20:26:43] (03CR) 10Legoktm: "Sorry for letting this sit - I'll make sure this gets reviewed/merged today." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:28:18] (03CR) 1001tonythomas: [C: 04-1] "recheck" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:29:17] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:29:45] (03PS2) 10Ryan10145: Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) [20:31:03] (03CR) 1001tonythomas: "recheck" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:33:30] (03CR) 1001tonythomas: [C: 032] "LGTM :) Thanks!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:33:55] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3862827 (1001tonythomas) [20:33:58] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183616#3862824 (1001tonythomas) 05Open>03Resolved a:03Ryan10145 Nice one! Thanks. [20:35:07] (03Merged) 10jenkins-bot: Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:35:42] 10MediaWiki-Parser, 10Tracking: HTML validity (tracking) - https://phabricator.wikimedia.org/T2209#3862830 (10divadsn) [20:35:48] 10EasyTimeline, 10Easy, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3862829 (10divadsn) 05Open>03Resolved [20:45:54] 10Cognate, 10Documentation: Cognate's StringHasher requires 64-bit PHP, doesn't work with 32-bit - https://phabricator.wikimedia.org/T183737#3862831 (10Umherirrender) [20:49:42] (03CR) 10Nikerabbit: [C: 032] [puppet] Pin elasticsearch to avoid cron spam [translatewiki] - 10https://gerrit.wikimedia.org/r/400608 (owner: 10Nikerabbit) [20:50:12] (03Merged) 10jenkins-bot: [puppet] Pin elasticsearch to avoid cron spam [translatewiki] - 10https://gerrit.wikimedia.org/r/400608 (owner: 10Nikerabbit) [20:50:14] 10MediaWiki-Codesniffer: Forbid parse_str() without a second argument - https://phabricator.wikimedia.org/T183739#3862318 (10Umherirrender) Usage: http://codesearch.wmflabs.org/search/?q=parse_str&i=nope&files=&repos= It seems to exists as `mb_parse_str`, too. [20:51:21] (03CR) 10Umherirrender: [C: 031] "I was always wonder, if there are required or not. Should one usage be part of the code style (and codesniffer)?" [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE)) [20:58:36] (03PS1) 1001tonythomas: Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 [20:59:46] (03CR) 1001tonythomas: [C: 031] "sadly, this needs to go after https://gerrit.wikimedia.org/r/#/c/400610/ as the API edit was broken sadly :-(" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:02:25] (03PS1) 10Umherirrender: Fix function names in @covers [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/400611 [21:03:48] (03PS4) 10Umherirrender: Install mediawiki/maps over composer [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/393107 [21:03:52] (03CR) 10Umherirrender: [C: 032] Install mediawiki/maps over composer [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/393107 (owner: 10Umherirrender) [21:04:34] (03Merged) 10jenkins-bot: Install mediawiki/maps over composer [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/393107 (owner: 10Umherirrender) [21:04:49] (03CR) 10Reedy: [C: 04-1] "per irc" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:05:18] (03PS2) 1001tonythomas: Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 [21:06:01] 10VPS-project-codesearch: Redirect http to https on new codesearch.wmflabs.org - https://phabricator.wikimedia.org/T183755#3862836 (10Umherirrender) [21:07:16] (03CR) 1001tonythomas: [C: 031] "Locally tested, works." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:07:28] (03CR) 10Reedy: [C: 032] Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:08:11] (03PS6) 10Umherirrender: Check if $responseData['responses'] is set before use [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395883 (https://phabricator.wikimedia.org/T161283) [21:08:28] (03PS2) 1001tonythomas: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:09:08] (03Merged) 10jenkins-bot: Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:10:02] (03CR) 10jerkins-bot: [V: 04-1] Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:13:53] (03PS3) 1001tonythomas: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:15:20] (03CR) 10jerkins-bot: [V: 04-1] Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:16:51] (03CR) 1001tonythomas: [C: 04-1] "You will have to fix tests now. Something is not working on removal." (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:19:52] (03PS1) 10Umherirrender: Use :: instead of -> in @covers [extensions/TwoColConflict] - 10https://gerrit.wikimedia.org/r/400612 [21:23:42] (03CR) 10Pppery: "Test failure was caused by a conflict with 8df149be2bc0543af897669f2f3c25c4b3bebeee" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:27:07] (03PS4) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [21:32:55] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862846 (10Albert221) a:03Albert221 [21:41:03] (03PS5) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [21:42:43] (03CR) 10Pppery: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [21:43:48] (03CR) 1001tonythomas: [C: 04-1] Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [21:44:47] (03CR) 10Divadsn: "I am currently not on my dev environment, could someone tell me if UTPage is saved please? :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [21:45:09] 10MediaWiki-Codesniffer: Detect global functions definied inside static functions - https://phabricator.wikimedia.org/T183756#3862847 (10Umherirrender) [21:46:48] (03CR) 1001tonythomas: Publisher add/remove functions now take user ids array (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:47:20] (03CR) 1001tonythomas: "recheck" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:51:10] 10Advanced-Search, 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3862859 (10Umherirrender) [21:55:38] (03CR) 1001tonythomas: [C: 04-1] "I get this on an API edit on this branch :-(" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:02:31] (03CR) 10Pppery: "Just to make sure, where is that output displayed?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:03:27] 10MediaWiki-extensions-HitCounters, 10Patch-For-Review: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference" - https://phabricator.wikimedia.org/T142127#3862860 (10Seb35) @maiden_taiwan: can you try my patch, either downloading it with git or as as .tar file (link “down... [22:03:52] (03Abandoned) 10ArielGlenn: cleanup old files after dataset100 rsync of dumps to labs [puppet] - 10https://gerrit.wikimedia.org/r/336451 (owner: 10ArielGlenn) [22:04:17] (03PS3) 10BryanDavis: rake: move test definitions to tests directory [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400201 [22:05:02] (03Abandoned) 10ArielGlenn: remove python script for cron rsync of dumps from dataset1001 to labstore [puppet] - 10https://gerrit.wikimedia.org/r/336205 (owner: 10ArielGlenn) [22:07:04] 10AutoWikiBrowser, 10XTools: Request to add tool to AutoEdits - https://phabricator.wikimedia.org/T183757#3862861 (10Mr.Ibrahem) [22:07:06] (03CR) 1001tonythomas: [C: 04-1] "Special:ApiSandbox and try to action=edit, with title=Newsletter:Foo and content to match a newslettercontent JSON, like:" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:11:29] (03CR) 10Pppery: "Cannot reproduce" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:12:33] (03CR) 1001tonythomas: [C: 04-1] "oh - this is available on the inspector console > networks > check the response of request to api.php." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:22:03] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Change the user-created list name if it the same name as the default list - https://phabricator.wikimedia.org/T183588#3862871 (10RHo) + @Fjalepeno @cmadeo Hi @Tgr - this ticket was per my understand... [22:22:56] (03CR) 10Pppery: "Still not seeing this error" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:24:46] (03PS1) 10Phantom42: Update groups GettextFFS keyAlgorithm [translatewiki] - 10https://gerrit.wikimedia.org/r/400613 (https://phabricator.wikimedia.org/T178882) [22:28:02] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862877 (10Phantom42) I just pushed a change to translatewiki.net repo. That patch removes... [22:28:13] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860147 (10Ryan10145) I'm trying to run this script on my computer so I can do this task, but whenever I try to download the abstract.xml file, I get... [22:31:21] (03PS1) 10Phantom42: Migrate GettextFFS keyAlgorithm default value to simple [extensions/Translate] - 10https://gerrit.wikimedia.org/r/400614 (https://phabricator.wikimedia.org/T178882) [22:33:52] (03PS6) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [22:35:20] 10MediaWiki-extensions-HitCounters, 10Patch-For-Review: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference" - https://phabricator.wikimedia.org/T142127#3862881 (10maiden_taiwan) Works for me! Thanks so much, @Seb35!! [22:36:42] (03CR) 10Pppery: "Fixes one case I forgot to fix before, which previously broke newsletter creation via API" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:39:11] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862882 (10Phantom42) And I pushed a second patch (to Translate extension) which changes de... [22:40:20] 10MassMessage, 10Outreachy (Round-15), 10Patch-For-Review: [Outreachy/Round 15] Proposal : Refactoring the MediaWiki MassMessage Extension - https://phabricator.wikimedia.org/T178215#3862883 (10Noella94) [22:41:13] 10DBA, 10Data-Services, 10Goal, 10cloud-services-team (FY2017-18): Create backups of user tables from decommissioned database servers - https://phabricator.wikimedia.org/T183758#3862884 (10Dispenser) p:05Triage>03High [22:42:08] 10AutoWikiBrowser, 10XTools: Request to add tool to AutoEdits - https://phabricator.wikimedia.org/T183757#3862896 (10Matthewrbowker) p:05Triage>03Low a:05Mr.Ibrahem>03None [22:42:39] (03CR) 10Ladsgroup: [C: 032] Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [22:42:59] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860147 (10Dalba) >>! In T183675#3862878, @Ryan10145 wrote: > ``` > python scripts/maintenance/download_dump.py -filename > abstract.xml > > Enter th... [22:45:04] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Change the user-created list name if it the same name as the default list - https://phabricator.wikimedia.org/T183588#3862901 (10Tgr) Current server behavior is to identify the lists by ID (which is... [22:45:55] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3862902 (10Ryan10145) Thank you for the help, I didn't see this before because my web browser would automatically correct the slashes when I clicked o... [22:47:30] 10Collaboration-Team-Triage, 10MediaWiki-Special-pages, 10TechCom-RfC, 10Patch-For-Review: Introduce article creation log - https://phabricator.wikimedia.org/T12331#3862903 (10kaldari) @WMDE-leszek fixed it! @daniel: Do you still want to have an IRC meeting about this? There's clearly desire for this from... [22:47:40] 10DBA, 10Data-Services: Create backups of user tables from decommissioned database servers - https://phabricator.wikimedia.org/T183758#3862905 (10bd808) [22:49:35] (03Merged) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [22:51:08] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862907 (10Phantom42) I checked #mediawiki_language_extension_bundle and #release workboard... [22:52:24] 10DBA, 10Data-Services: Create backups of user tables from decommissioned database servers - https://phabricator.wikimedia.org/T183758#3862909 (10dschwen) @dispenser, backup is fine, but have you thought about making GHEL work with the new setup? [22:52:46] 10DBA, 10Data-Services: Create backups of user tables from decommissioned database servers - https://phabricator.wikimedia.org/T183758#3862910 (10bd808) @Dispenser are there particular databases/tables that you know should be backed up which have not already been taken care of by their maintainers? I'm not opp... [23:03:48] 10MediaWiki-extensions-ORES, 10ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: Wikidata beta edit filters are showing every edit in watchlist as damaging - https://phabricator.wikimedia.org/T180686#3766448 (10Ladsgroup) 05Open>03Resolved [23:12:20] (03CR) 10Ladsgroup: Use ExtensionRegistry instead of class_exists (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:12:38] (03PS4) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) [23:14:59] 10MediaWiki-Shell, 10MediaWiki-extensions-Score: MediaWiki::shell with parameter fails on Windows - https://phabricator.wikimedia.org/T183759#3862943 (10Ebe123) [23:18:00] (03PS1) 10Dzahn: icinga: script to send custom SMS to Icinga contacts [puppet] - 10https://gerrit.wikimedia.org/r/400615 (https://phabricator.wikimedia.org/T82937) [23:18:29] (03CR) 10jerkins-bot: [V: 04-1] icinga: script to send custom SMS to Icinga contacts [puppet] - 10https://gerrit.wikimedia.org/r/400615 (https://phabricator.wikimedia.org/T82937) (owner: 10Dzahn) [23:19:23] 10MediaWiki-Shell, 10MediaWiki-extensions-Score: MediaWiki::shell with parameter fails on Windows - https://phabricator.wikimedia.org/T183759#3862955 (10Ebe123) p:05Triage>03High `Shell::command( $wgScoreLilyPond . '--version' )` works (notice concatenation instead of parametration) on Windows. [23:26:33] (03PS2) 10Dzahn: icinga: script to send custom SMS to Icinga contacts [puppet] - 10https://gerrit.wikimedia.org/r/400615 (https://phabricator.wikimedia.org/T82937) [23:26:56] (03CR) 10jerkins-bot: [V: 04-1] icinga: script to send custom SMS to Icinga contacts [puppet] - 10https://gerrit.wikimedia.org/r/400615 (https://phabricator.wikimedia.org/T82937) (owner: 10Dzahn) [23:41:47] (03CR) 10Legoktm: [C: 032] "I can't think of a reason they'd ever be needed...if there are none, I think we should add it to MW-CS." [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE)) [23:42:36] (03CR) 10Legoktm: [C: 032] Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:43:22] (03CR) 10Legoktm: [C: 032] Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:48:22] (03Merged) 10jenkins-bot: Remove leading backslashes from "use \…" tags [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE)) [23:48:48] (03Merged) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:50:26] (03Merged) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:53:03] (03CR) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:53:15] 10Wiki-Setup (Create): Create Wikivoyage Pashto - https://phabricator.wikimedia.org/T183706#3861294 (10Baloch007) After four months of work and 1,848 edits (150 pages) I think we deserve our own wiki. Because only in Afghanistan and Pakistan there is more than 50 million people's who speaks Pashto as there moth... [23:57:16] 10Gerrit: Create a code coverage plugin for polygerrit - https://phabricator.wikimedia.org/T183760#3862961 (10Paladox) [23:58:56] (03CR) 10jenkins-bot: Remove leading backslashes from "use \…" tags [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE))