[00:00:49] 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860124 (10D3r1ck01) [00:04:51] (03CR) 10jenkins-bot: WikimediaUI theme: Align 'transparency' icon to WikimedaUI color palette [oojs/ui] - 10https://gerrit.wikimedia.org/r/400109 (owner: 10VolkerE) [00:05:22] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860127 (10D3r1ck01) [00:05:34] (03CR) 10jenkins-bot: [MCR] Introduce BlobStoreFactory [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) (owner: 10Addshore) [00:12:56] (03PS1) 10Albert221: Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) [00:13:13] (03Abandoned) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400122 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [00:13:33] (03CR) 10jenkins-bot: [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [00:13:56] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [00:15:56] (03PS2) 10Albert221: Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) [00:20:13] (03CR) 10Divadsn: "Oh alright, no problem" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [00:22:09] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860131 (10Phantom42) [00:28:40] (03CR) 10Phantom42: [C: 031] Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [00:29:13] (03PS2) 10Divadsn: Replace deprecated tag with custom styled
tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) [00:32:26] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3860132 (10Albert221) [00:39:23] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3860135 (10eflyjason) I would suggest something like https://stackoverflow.com/a/15645088/2603230. (See also: https://github.com/wikimedia/pywikibot/blob/master... [00:43:06] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3859839 (10rafidaslam) There's also a library to make progressbar and some command-line related things in Python: https://github.com/kennethreitz/clint [00:46:06] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3860139 (10eflyjason) If we are to use external library, does that mean we have to add this library to `requirements.txt`? [00:47:14] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Handle cases when the dump file already exists - https://phabricator.wikimedia.org/T183667#3860140 (10eflyjason) Would timezone settings on bot user's computer be a problem to this? [00:48:17] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3860141 (10rafidaslam) @eflyjason yup [00:53:46] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Verify the file using the checksum - https://phabricator.wikimedia.org/T183670#3860142 (10eflyjason) It seems that file like `enwiki-latest-abstract.xml` does not have a md5 code in https://dumps.wikimedia.org/enwiki/latest... [00:56:09] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Use response.iter_content - https://phabricator.wikimedia.org/T183666#3860144 (10eflyjason) [00:56:12] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3860143 (10eflyjason) [00:57:52] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3859839 (10eflyjason) Adding parent task {T183666} as we cannot implement progress bar without using `iter_content`. [01:04:57] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Use response.iter_content - https://phabricator.wikimedia.org/T183666#3860146 (10eflyjason) [01:09:21] (03PS1) 10Legoktm: Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 [01:10:03] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860147 (10zhuyifei1999) p:05Triage>03Normal [01:12:17] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Epic, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3860158 (10Albert221) [01:12:50] 10MediaWiki-General-or-Unknown, 10CSS: Replace layout-only span.mw-editButtons-pipe-separator in favor of CSS - https://phabricator.wikimedia.org/T183672#3859983 (10Nirmos) I suppose the same could be said for the pipes in `#contentSub` on Special:Contributions and Special:DeletedContributions. On the other h... [01:14:12] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Epic, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3860158 (10Albert221) [01:15:37] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860171 (10zhuyifei1999) [01:16:50] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks: CLL shows wrong number for "X more languages" label - https://phabricator.wikimedia.org/T183649#3860172 (10Petar.petkovic) [01:19:13] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860173 (10eflyjason) [01:20:51] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages, 10Regression: Special:Contributions no longer shows contributions by name - problems listing contributions stored with user ID = 0 - https://phabricator.wikimedia.org/T36873#3860175 (10Graham87) Also, for example, this link should show far more than 19... [01:21:04] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860177 (10zhuyifei1999) (clarification: by [[https://en.wiktionary.org/wiki/iff|iff]] I meant if and only if) [01:22:35] 10Proton, 10Readers-Web-Backlog, 10User-Jdlrobson, 10User-notice: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser. - https://phabricator.wikimedia.org/T182059#3860180 (10Liuxinyu970226) [01:22:45] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860181 (10eflyjason) [01:22:52] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks: CLL shows wrong number for "X more languages" label - https://phabricator.wikimedia.org/T183649#3860183 (10Petar.petkovic) 05Open>03Invalid Since I have discovered this to be the problem with plural rules with message translations, I'm c... [01:23:06] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860147 (10eflyjason) >>! In T183675#3860177, @zhuyifei1999 wrote: > (clarification: by [[https://en.wiktionary.org/wiki/iff|iff]] I meant if and only... [01:24:08] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860186 (10zhuyifei1999) Thanks for proofreading though :) [01:28:06] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Make download process atomic - https://phabricator.wikimedia.org/T183675#3860187 (10eflyjason) > One implementation is to perform file locking on whichever is being downloaded on, and exit with an error if the will-be-writt... [01:31:53] 10Ladies-That-FOSS-MediaWiki, 10MediaWiki-extensions-EducationProgram, 10Easy, 10Google-Code-in-2017, 10JavaScript: wgRestrictionEdit should be defined (as an empty array) on Education Program pages - https://phabricator.wikimedia.org/T133289#3860189 (10divadsn) So after looking up the code I noticed tha... [01:32:59] 10Pywikibot-General, 10Pywikibot-core, 10Documentation, 10Google-Code-in-2017, 10Pywikibot-Documentation: Create a "Play with Pywikibot" set of tasks for GCI - https://phabricator.wikimedia.org/T183016#3841178 (10eflyjason) >>! In T183016#3847447, @jayvdb wrote: > I suggest using https://www.mediawiki.or... [01:35:07] (03PS1) 10Legoktm: Add tests for TextboxBuilder [core] - 10https://gerrit.wikimedia.org/r/400130 [01:37:44] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [01:38:23] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceGroupManager] - 10https://gerrit.wikimedia.org/r/400114 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [01:42:22] 04(no projects): Quantcast: switch to HTTPS - https://phabricator.wikimedia.org/T183677#3860195 (10MtMNC) [01:43:44] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10eflyjason) Is there any way we could use `phan` in MediaWiki-Vagrant... [01:45:03] (03CR) 10Rafidaslam: [C: 031] Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [01:45:17] (03CR) 10Legoktm: [C: 04-1] "Please submit the MinusX change as a separate commit like you had previously, as that should be easy to merge without a more involved revi" (035 comments) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [01:47:05] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10Bawolff) >>! In T179554#3860205, @eflyjason wrote: > Is there any way... [01:48:52] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3860209 (10Legoktm) See https://lists.wikimedia.org/pipermail/wikitech-l/2017-De... [01:55:49] (03PS1) 10Ladsgroup: Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 [01:57:27] (03PS3) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) [01:58:02] (03PS4) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:07:15] (03PS5) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:08:13] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [02:08:30] (03PS6) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:09:26] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [02:09:53] (03PS7) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:10:56] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [02:11:18] (03PS1) 10Legoktm: Add favicon [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400132 (https://phabricator.wikimedia.org/T183445) [02:11:34] 10Citoid, 10VisualEditor, 10I18n: Restore the translations of "null" in VisualEditor Cite and Citoid messages as "optional" - https://phabricator.wikimedia.org/T183678#3860213 (10Liuxinyu970226) [02:11:42] 10Citoid, 10VisualEditor, 10I18n: Restore the translations of "null" in VisualEditor Cite and Citoid messages as "optional" - https://phabricator.wikimedia.org/T183678#3860223 (10Liuxinyu970226) [02:11:58] (03CR) 10Legoktm: [V: 032 C: 032] Add favicon [labs/codesearch] - 10https://gerrit.wikimedia.org/r/400132 (https://phabricator.wikimedia.org/T183445) (owner: 10Legoktm) [02:13:35] 10Citoid, 10VisualEditor, 10I18n: Restore the translations of "null" in VisualEditor Cite and Citoid messages as "optional" - https://phabricator.wikimedia.org/T183678#3860213 (10Liuxinyu970226) [02:14:04] (03PS8) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:15:02] (03CR) 10Legoktm: [C: 04-1] Add tests for several methods of Xml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [02:17:26] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860227 (10bd808) p:05Triage>03Normal [02:18:49] 10VPS-project-codesearch, 10Patch-For-Review: codesearch: Needs a favicon - https://phabricator.wikimedia.org/T183445#3860240 (10Legoktm) 05Open>03Resolved a:03Legoktm {F12037246} That's the source of the ico file I generated. I hope that the little git logo in the corner is visually distinctive enough... [02:20:00] (03CR) 10Legoktm: "Shouldn't this have some kind of skip if firejail is not installed?" [core] - 10https://gerrit.wikimedia.org/r/399767 (owner: 10Gergő Tisza) [02:20:25] 10MediaWiki-Shell, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Add shell restriction to deny access to LocalSettings.php - https://phabricator.wikimedia.org/T182484#3860244 (10Legoktm) 05Open>03Resolved [02:20:30] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860245 (10bd808) ``` $ sudo /usr/bin/mysql -qfsAe "USE centralauth; SOURCE /vagrant/mediawiki/extensions/CentralAuth/central-auth.sql;" ERROR 1709 (HY000) a... [02:20:46] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:21:22] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3860247 (10Albert221) [02:21:40] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:23:10] 10MobileFrontend, 10Wikidata, 10I18n: Some wikidata labels in Urdu have incorrectly rendered Urdu characters on the mobile site - https://phabricator.wikimedia.org/T183388#3851752 (10Liuxinyu970226) Might be suitable for #browser-support-android-google-chrome ? [02:23:24] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:24:22] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:26:33] (03CR) 10Legoktm: [C: 04-1] Add minus-x to composer test and fix (031 comment) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:27:05] (03PS3) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:27:53] (03PS4) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:28:11] 10MediaWiki-Shell: firejail < 0.9.50 doesn't support --seccomp=@default - https://phabricator.wikimedia.org/T183680#3860250 (10Legoktm) [02:33:35] (03PS1) 10Divadsn: Always define wgRestrictionEdit as an empty array for pages [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) [02:36:16] (03CR) 10Legoktm: [C: 032] Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:36:51] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860263 (10bd808) This cause of this seems to be that the default CHARSET is now utf8mb4: ``` (02:31) vagrant@localhost:[centralauth]> show create table glob... [02:37:43] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:40:47] (03Abandoned) 10Divadsn: Always define wgRestrictionEdit as an empty array for pages [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) (owner: 10Divadsn) [02:42:50] (03PS1) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [02:45:40] (03PS2) 10Ladsgroup: Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 [02:45:44] (03CR) 10Ladsgroup: Add tests for several methods of Xml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [02:46:40] (03CR) 10Legoktm: [C: 032] Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [02:48:15] (03PS9) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:48:24] (03PS2) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [02:50:19] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Epic, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3860266 (10Albert221) [02:50:43] 10OCG-General: PDF export extension problem with
(03CR) 10jerkins-bot: [V: 04-1] Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [02:56:07] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/400136 (https://phabricator.wikimedia.org/T175749) [02:56:16] (03PS3) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [02:57:23] (03PS1) 10Ryan10145: Added a unit test to check that the main page exists [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400137 (https://phabricator.wikimedia.org/T183632) [02:57:55] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/400138 (https://phabricator.wikimedia.org/T175749) [02:58:29] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3860280 (10Albert221) [02:58:37] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/400138 (https://phabricator.wikimedia.org/T175794) [02:59:10] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/400136 (https://phabricator.wikimedia.org/T175794) [03:01:21] (03PS4) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [03:01:31] (03CR) 10Gergő Tisza: "I'll add one, although right now this test has to be executed manually so it doesn't make much difference." [core] - 10https://gerrit.wikimedia.org/r/399767 (owner: 10Gergő Tisza) [03:03:40] (03CR) 10jenkins-bot: Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [03:07:03] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [03:07:38] (03PS3) 10Gergő Tisza: Integration tests for FirejailCommand [core] - 10https://gerrit.wikimedia.org/r/399767 [03:10:28] (03PS1) 10Legoktm: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 [03:14:05] (03PS1) 10Legoktm: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 [03:16:00] (03CR) 10Legoktm: Add tests for several methods of Xml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [03:16:47] (03PS1) 10Legoktm: Fix @covers in XmlTest [core] - 10https://gerrit.wikimedia.org/r/400141 [03:17:01] (03CR) 10Legoktm: [C: 032] "self-merge to unbreak coverage..." [core] - 10https://gerrit.wikimedia.org/r/400141 (owner: 10Legoktm) [03:19:31] (03CR) 10Gergő Tisza: Add formatversion=2 to all API examples (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [03:20:13] (03CR) 10Gergő Tisza: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [03:23:51] (03Merged) 10jenkins-bot: Fix @covers in XmlTest [core] - 10https://gerrit.wikimedia.org/r/400141 (owner: 10Legoktm) [03:24:23] (03CR) 10Legoktm: Add formatversion=2 to all API examples (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [03:26:17] 10MediaWiki-extensions-Other: Quantcast: switch to HTTPS - https://phabricator.wikimedia.org/T183677#3860289 (10Peachey88) [03:26:45] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-General: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860290 (10Legoktm) [03:27:04] 10MediaWiki-Core-Tests, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3860292 (10Legoktm) [03:27:06] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-General: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3858410 (10Legoktm) [03:27:44] (03Merged) 10jenkins-bot: Allow fallbacks for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [03:29:26] (03PS1) 10Legoktm: Remove invalid @covers tag [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/400142 (https://phabricator.wikimedia.org/T183604) [03:30:16] (03PS1) 10Legoktm: Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) [03:30:48] (03PS1) 10Legoktm: Remove invalid @covers tag [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400144 (https://phabricator.wikimedia.org/T183604) [03:32:06] 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, and 2 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860299 (10Legoktm) a:03Legoktm [03:33:13] (03CR) 10jenkins-bot: Fix @covers in XmlTest [core] - 10https://gerrit.wikimedia.org/r/400141 (owner: 10Legoktm) [03:41:41] (03CR) 10jenkins-bot: Allow fallbacks for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [03:43:58] (03PS2) 10BryanDavis: mysql: break Mysql::User['vagrant'] dependency cycle [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) [03:44:00] (03PS1) 10BryanDavis: mysql: Provide default charset for MediaWiki tables [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400145 (https://phabricator.wikimedia.org/T183679) [03:44:02] (03PS1) 10BryanDavis: mysql: Fix service notification in mysql::large_prefix [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400146 [03:44:41] (03CR) 10BryanDavis: [C: 032] mysql: break Mysql::User['vagrant'] dependency cycle [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) (owner: 10BryanDavis) [03:44:52] (03CR) 10BryanDavis: [C: 032] mysql: Provide default charset for MediaWiki tables [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400145 (https://phabricator.wikimedia.org/T183679) (owner: 10BryanDavis) [03:45:04] (03CR) 10BryanDavis: [C: 032] mysql: Fix service notification in mysql::large_prefix [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400146 (owner: 10BryanDavis) [03:45:13] (03Merged) 10jenkins-bot: mysql: break Mysql::User['vagrant'] dependency cycle [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) (owner: 10BryanDavis) [03:45:48] (03Merged) 10jenkins-bot: mysql: Provide default charset for MediaWiki tables [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400145 (https://phabricator.wikimedia.org/T183679) (owner: 10BryanDavis) [03:45:50] (03Merged) 10jenkins-bot: mysql: Fix service notification in mysql::large_prefix [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400146 (owner: 10BryanDavis) [03:47:25] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860308 (10bd808) [03:47:27] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860307 (10bd808) 05Open>03Resolved [03:47:46] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847555 (10bd808) [03:47:48] 10MediaWiki-Vagrant, 10Patch-For-Review: Fix default .my.cnf/grants for vagrant user on Stretch - https://phabricator.wikimedia.org/T181918#3860310 (10bd808) 05Open>03Resolved [03:50:30] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860312 (10bd808) [03:53:02] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860313 (10bd808) [03:53:28] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847763 (10bd808) [04:09:54] (03PS2) 10Legoktm: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 [04:09:56] (03PS2) 10Legoktm: Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 [04:09:58] (03PS2) 10Legoktm: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 [04:10:00] (03PS1) 10Legoktm: Add @covers tags for RevisionStoreDbTest [core] - 10https://gerrit.wikimedia.org/r/400147 [04:10:02] (03PS1) 10Legoktm: Add @covers tags to includes/debug tests [core] - 10https://gerrit.wikimedia.org/r/400148 [04:10:04] (03PS1) 10Legoktm: Add @covers tags to LinksUpdate test [core] - 10https://gerrit.wikimedia.org/r/400149 [04:10:06] (03PS1) 10Legoktm: Add @covers tags to filerepo tests [core] - 10https://gerrit.wikimedia.org/r/400150 [04:10:08] (03PS1) 10Legoktm: Add @covers tags to HTMLForm test [core] - 10https://gerrit.wikimedia.org/r/400151 [04:10:10] (03PS1) 10Legoktm: Add @covers tags to jobqueue tests [core] - 10https://gerrit.wikimedia.org/r/400152 [04:18:48] (03PS3) 10Rafidaslam: Add phan configuration for static analysis and fix phan warnings [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) [04:21:21] (03CR) 10Rafidaslam: "check experimental" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [04:42:02] (03CR) 10Gergő Tisza: "Oh right, the array is the initial value of a static variable. Static/constant expressions are introduced in PHP 5.6." [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [04:45:39] (03PS3) 10Gergő Tisza: Add formatversion=2 to all API examples [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) [04:52:06] (03PS2) 10Legoktm: Whitelist eflyjason (GCI) [integration/config] - 10https://gerrit.wikimedia.org/r/400103 (owner: 10Framawiki) [04:52:10] (03PS1) 10Legoktm: Whitelist Rafidaslam [integration/config] - 10https://gerrit.wikimedia.org/r/400153 [04:52:15] (03CR) 10Legoktm: [C: 032] Whitelist eflyjason (GCI) [integration/config] - 10https://gerrit.wikimedia.org/r/400103 (owner: 10Framawiki) [04:52:19] (03CR) 10Legoktm: [C: 032] Whitelist Rafidaslam [integration/config] - 10https://gerrit.wikimedia.org/r/400153 (owner: 10Legoktm) [04:53:28] (03Merged) 10jenkins-bot: Whitelist Rafidaslam [integration/config] - 10https://gerrit.wikimedia.org/r/400153 (owner: 10Legoktm) [04:54:10] (03Merged) 10jenkins-bot: Whitelist eflyjason (GCI) [integration/config] - 10https://gerrit.wikimedia.org/r/400103 (owner: 10Framawiki) [04:56:34] (03CR) 10Rafidaslam: "check experimental" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [05:00:33] 10Internet-Archive, 10InternetArchiveBot: IABot misreporting added archive - https://phabricator.wikimedia.org/T183681#3860317 (10Black_Falcon) [05:12:35] 10MobileFrontend, 10Wikidata, 10I18n: Some wikidata labels in Urdu have incorrectly rendered Urdu characters on the mobile site - https://phabricator.wikimedia.org/T183388#3860328 (10Amire80) It happens in both Firefox and Chrome. [05:15:53] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860331 (10bd808) [05:15:55] 10MediaWiki-Vagrant, 10Operations, 10Patch-For-Review: Import kibana package from jessie into stretch - https://phabricator.wikimedia.org/T183071#3860329 (10bd808) 05Open>03Resolved a:03bd808 [05:18:54] (03PS1) 10Legoktm: Fix typo in elasticsearch::repository [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400154 [05:19:37] (03CR) 10BryanDavis: [C: 032] Fix typo in elasticsearch::repository [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400154 (owner: 10Legoktm) [05:20:20] (03Merged) 10jenkins-bot: Fix typo in elasticsearch::repository [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400154 (owner: 10Legoktm) [05:43:38] 10VPS-project-codesearch, 10Patch-For-Review: codesearch: Handle hound being down more gracefully - https://phabricator.wikimedia.org/T183443#3860332 (10Legoktm) 05Open>03Resolved a:03Legoktm This is probably OK for now. [05:54:25] (03PS1) 10BryanDavis: elk: Fix kibana reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400155 [05:57:41] 10MediaWiki-Vagrant: Puppet failing when using stretch-migration branch - https://phabricator.wikimedia.org/T183067#3860336 (10bd808) @Paladox, now that {T181918} is fixed can you recheck this problem? To have a fair comparison with your past tests you will need to enable the hhvm role as php7 is the default run... [05:57:58] (03CR) 10BryanDavis: [C: 032] elk: Fix kibana reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400155 (owner: 10BryanDavis) [05:58:31] (03Merged) 10jenkins-bot: elk: Fix kibana reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400155 (owner: 10BryanDavis) [05:58:42] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860337 (10bd808) [06:02:31] 10MediaWiki-Vagrant: /vagrant/cache/apt permissions issues with Stretch - https://phabricator.wikimedia.org/T183150#3860338 (10bd808) I do not see this error when using VirtualBox file shares (`vagrant config nfs_shares off`), but I'll check with NFS to see if I can recreate it. [06:20:33] (03PS1) 10Phantom42: Add phan configuration for static analysis [skins/Vector] - 10https://gerrit.wikimedia.org/r/400156 (https://phabricator.wikimedia.org/T179554) [06:29:40] (03PS1) 10Phantom42: Run phan for mediawiki/skins/Vector [integration/config] - 10https://gerrit.wikimedia.org/r/400157 (https://phabricator.wikimedia.org/T179554) [06:31:19] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/400136 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [06:31:47] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/400138 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [06:38:56] 10MediaWiki-Vagrant: /vagrant/cache/apt permissions issues with Stretch - https://phabricator.wikimedia.org/T183150#3860344 (10bd808) Confirmed that this warning occurs with NFS shares and not with VirtualBox shares. It does not seem to effect actual usage or Puppet's processing of package resources. ``` $ vagr... [06:39:43] 10MediaWiki-Vagrant: /vagrant/cache/apt permissions warnings with Stretch sandboxed apt settings - https://phabricator.wikimedia.org/T183150#3860345 (10bd808) [06:40:26] (03CR) 10Legoktm: [C: 04-1] Add minus-x to extension PagesList (032 comments) [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:42:47] (03PS2) 10Clockery: Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) [06:43:34] (03PS2) 10Clockery: Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) [06:44:44] (03CR) 10Legoktm: [C: 032] Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:44:52] (03CR) 10Legoktm: [C: 032] Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:46:13] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:46:53] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:50:06] (03PS1) 10Phantom42: Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) [06:51:13] (03CR) 10jerkins-bot: [V: 04-1] Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [06:53:05] (03PS1) 10Phantom42: Run phan for mediawiki/skins/Modern [integration/config] - 10https://gerrit.wikimedia.org/r/400159 (https://phabricator.wikimedia.org/T179554) [06:54:41] (03PS2) 10Phantom42: Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) [06:55:51] (03CR) 10jerkins-bot: [V: 04-1] Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [06:57:17] (03PS3) 10Phantom42: Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) [07:13:17] (03CR) 10Legoktm: "check experimental" [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [07:13:28] (03CR) 10Legoktm: "check experimental" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400156 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [07:25:03] 10TCB-Team, 10Wikimedia-General-or-Unknown, 10Developer-Relations (Jan-Mar-2018), 10User-Tgr: Provide an easy to use support system for contributors to ask technical questions - https://phabricator.wikimedia.org/T155678#3516131 (10Psychoslave) So I started to play with discourse. One thing I wonder is what... [07:25:14] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3860350 (10Jayprakash12345) @Dereckson Sir, ok Can someone help me to make RfC? [07:29:18] (03PS1) 10Legoktm: Add @covers tags to logging tests [core] - 10https://gerrit.wikimedia.org/r/400160 [07:29:18] (03PS1) 10Legoktm: Add @covers tags to media tests [core] - 10https://gerrit.wikimedia.org/r/400161 [07:29:19] (03PS1) 10Legoktm: Add @covers tags to objectcache tests [core] - 10https://gerrit.wikimedia.org/r/400162 [07:29:21] (03PS1) 10Legoktm: Add @covers tags to page tests [core] - 10https://gerrit.wikimedia.org/r/400163 [07:29:23] (03PS1) 10Legoktm: Add @covers tags to parser tests [core] - 10https://gerrit.wikimedia.org/r/400164 [07:29:25] (03PS1) 10Legoktm: Add @covers tags to specials tests [core] - 10https://gerrit.wikimedia.org/r/400165 [07:29:27] (03PS1) 10Legoktm: Add @covers tags to user tests [core] - 10https://gerrit.wikimedia.org/r/400166 [07:29:29] (03PS1) 10Legoktm: Add @covers tags to utils tests [core] - 10https://gerrit.wikimedia.org/r/400167 [07:29:31] (03PS1) 10Legoktm: Add @covers tags to miscellaneous tests [core] - 10https://gerrit.wikimedia.org/r/400168 [08:08:24] (03PS1) 10Rafidaslam: Fix the return type of Scribunto_LuaLibraryBase::register() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/400169 [08:12:40] (03PS2) 10Rafidaslam: Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) [08:12:47] 10PAWS, 10Design, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3860352 (10Fullmeteor172) >>! In T179677#3824780, @Gabe_Mitnick wrote: > GCI Submission: > I went full out with the "PAWS" name. My favorite is paws-01, but I created paws-02 in case 01 ha... [08:16:42] (03CR) 10Rafidaslam: "check experimental" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [08:28:11] (03CR) 10Rafidaslam: "I think we need to add Scribunto to the dependency list in integration-config repo" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [08:30:20] (03CR) 10Rafidaslam: "or ignore it? I don't see Scribunto_LuaTitleBlacklistLibrary is used anywhere" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [08:40:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/400170 (owner: 10L10n-bot) [08:43:18] (03PS19) 10Iniquity: Adaptive design for babel-box and turning on CSS for mobile version [extensions/Babel] - 10https://gerrit.wikimedia.org/r/385852 (https://phabricator.wikimedia.org/T178782) [09:24:03] (03PS1) 10PortalsBuilder: Assets build - 2017-12-25 09:24:01+00:00 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/400172 [09:26:30] 10MobileFrontend, 10Wikidata, 10I18n: Some wikidata labels in Urdu have incorrectly rendered Urdu characters on the mobile site - https://phabricator.wikimedia.org/T183388#3860354 (10Amire80) I attempted to report this upstream: - CSS: https://github.com/w3c/csswg-drafts/issues/2135 - Mozilla: https://bugzi... [10:04:11] (03PS2) 10Rafidaslam: Add phan configuration for static analysis [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) [10:04:20] (03CR) 1001tonythomas: [C: 032] "LGTM. Thanks." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400137 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [10:04:47] 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Daily Campaign Counter - https://phabricator.wikimedia.org/T180285#3860355 (10tmletzko) @kai.nissen reached sum: 6,8 donations: 315.131 [10:05:51] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3860358 (1001tonythomas) [10:05:54] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test condition "The main page should exist" in NewsletterCreate - https://phabricator.wikimedia.org/T183635#3860356 (1001tonythomas) 05Open>03Resolved a:03Ryan10145 [10:05:59] (03CR) 10Rafidaslam: "check experimental" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [10:06:18] (03Merged) 10jenkins-bot: Added a unit test to check that the main page exists [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400137 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [10:11:36] (03CR) 10Umherirrender: [C: 04-1] "Error: /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/MsWikiEditor/README.md should not be executable" [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [10:13:45] (03CR) 10Umherirrender: "The failures coming from an external lib in modules/DataTables" [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [10:14:26] (03CR) 10Umherirrender: [C: 032] Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:14:58] 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): [BUG] Incorrect language counts in "About this page" section - https://phabricator.wikimedia.org/T180182#3860360 (10Kaartic) 05Resolved>03Open [10:15:10] (03CR) 10Umherirrender: [C: 032] Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:16:13] (03Merged) 10jenkins-bot: Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:16:25] 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): [BUG] Incorrect language counts in "About this page" section - https://phabricator.wikimedia.org/T180182#3749643 (10Kaartic) Re-opening just in case the comment wasn't noticed. [10:16:36] (03Merged) 10jenkins-bot: Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:19:57] (03CR) 10Hashar: "That magically fixed it :-}" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) (owner: 10BryanDavis) [10:21:30] 10MediaWiki-General-or-Unknown: srcset uses incorrect radix character - https://phabricator.wikimedia.org/T183660#3860365 (10Ciencia_Al_Poder) [10:21:32] 10MediaWiki-General-or-Unknown: locale-aware float to string conversion in Html::srcSet - https://phabricator.wikimedia.org/T183659#3860368 (10Ciencia_Al_Poder) [10:22:05] (03CR) 10Umherirrender: "Looks good otherwise" (031 comment) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [10:22:23] 10MediaWiki-General-or-Unknown: locale-aware float to string conversion in Html::srcSet - https://phabricator.wikimedia.org/T183659#3859667 (10Ciencia_Al_Poder) >>! In T183660#3859726, @TheDJ wrote: > We could either use number_format, but then we end up with 1.0x instead of 1x, or I guess we can do character re... [10:26:12] 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Page status indicator should not be automatically sorted outside main namespace - https://phabricator.wikimedia.org/T94307#1159433 (10TheDragonFire) @Edokter Hey! Over two years on from the opening of this ticket, {{[top icon](https://en.wikipedia.org/wiki/Te... [10:29:46] 10Wikipedia-Android-App-Backlog: Suggestions to improve (?) "On the Day" screen of the app - https://phabricator.wikimedia.org/T179278#3860374 (10Kaartic) It seems the ones in the task description have already been completed. I've added one other minor thing I noticed, now. [10:31:52] 10PAWS: 504 Gateway Time-Out when loading PAWS - https://phabricator.wikimedia.org/T173983#3547077 (10Herzi.Pinki) Since some days I get the //504 Gateway Time-out// error in a reproducible way. [10:33:46] (03CR) 10Rafidaslam: "10:06:33 RecursiveDirectoryIterator::__construct(./../EventLogging): failed to open dir: No such file or directory" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [10:58:27] 10MobileFrontend, 10Wikidata, 10I18n: First character of Wikidata labels incorrectly rendered in some languages on mobile, as the tagline class has ::first-letter { text-transform: capitalize; } - https://phabricator.wikimedia.org/T183388#3860385 (10Aklapper) [10:58:28] (03PS2) 10Nehajha: Added Mediawiki OAuth for applicants [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/398063 (https://phabricator.wikimedia.org/T119534) [11:11:58] 10MediaWiki-Patrolling: New pages if moved or deleted cannot be marked as verified - https://phabricator.wikimedia.org/T177703#3860387 (10Andyrom75) Same thing happens to this redirect: https://it.wikivoyage.org/w/index.php?title=Utente:Yiyi/Il_Liberty_a_Cernobbio,_Como_e_Brunate&redirect=no It's the original p... [11:16:33] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Use response.iter_content - https://phabricator.wikimedia.org/T183666#3860388 (10Aklapper) Imported and published as https://codein.withgoogle.com/tasks/6224337721884672/ [11:18:22] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Use symlink instead of a copy for toolforge users - https://phabricator.wikimedia.org/T183668#3860390 (10Aklapper) Imported and published as https://codein.withgoogle.com/tasks/5155973465374720/ [11:45:15] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [skins/Vector] - 10https://gerrit.wikimedia.org/r/400156 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [11:45:50] (03CR) 10Florianschmidtwelzow: [C: 031] Run phan for mediawiki/skins/Vector [integration/config] - 10https://gerrit.wikimedia.org/r/400157 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [11:46:13] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [11:46:23] (03CR) 10Florianschmidtwelzow: [C: 031] Run phan for mediawiki/skins/Modern [integration/config] - 10https://gerrit.wikimedia.org/r/400159 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [11:57:10] (03PS10) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [12:07:06] (03CR) 10D3r1ck01: [C: 031] "LGTM! Thanks for the great work @Albert221." [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [12:07:08] (03CR) 10Ladsgroup: [C: 032] Remove invalid @covers tag [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/400142 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:07:10] (03CR) 10Ladsgroup: [C: 032] Remove invalid @covers tag [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400144 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:07:12] (03CR) 10Ladsgroup: [C: 032] Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:09:24] (03CR) 10Ladsgroup: Add tests for several methods of Xml (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [12:10:30] (03PS1) 10Rafidaslam: parameter_functions: Add EventLogging to WikiEditor dependency [integration/config] - 10https://gerrit.wikimedia.org/r/400173 [12:13:10] (03CR) 10Rafidaslam: "Opened a CR for adding EventLogging to WikiEditor test dependency (https://gerrit.wikimedia.org/r/400173) the CR dependency need to be mer" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [12:15:43] (03Merged) 10jenkins-bot: Remove invalid @covers tag [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/400142 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:15:44] (03Merged) 10jenkins-bot: Remove invalid @covers tag [extensions/Cognate] - 10https://gerrit.wikimedia.org/r/400144 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:15:46] (03Merged) 10jenkins-bot: Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:21:15] (03PS5) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [12:28:14] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [12:33:40] 10TCB-Team, 10Wikimedia-General-or-Unknown, 10Developer-Relations (Jan-Mar-2018), 10User-Tgr: Provide an easy to use support system for contributors to ask technical questions - https://phabricator.wikimedia.org/T155678#3860396 (10Aklapper) @Psychoslave: [[ https://en.wikipedia.org/wiki/Phabricator | Phab... [12:34:17] (03Abandoned) 10Umherirrender: Adding php code sniffer [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/317805 (owner: 10Paladox) [12:34:54] 10GlobalUsage, 10MediaWiki-Special-pages, 10Multimedia: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3860397 (10Aklapper) p:05Triage>03Lowest [12:35:05] (03CR) 10Rafidaslam: "recheck" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [12:35:17] (03CR) 10Umherirrender: [C: 032] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [12:36:16] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [12:36:50] (03Merged) 10jenkins-bot: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [12:56:16] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860399 (10D3r1ck01) [12:58:50] 10User-Jayprakash12345: Hindi Wikiversity is not showing in Wikimedia Stats - https://phabricator.wikimedia.org/T183682#3860400 (10Jayprakash12345) [12:58:57] 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, and 2 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860410 (10thiemowmde) >>! In T183604#3859996, @Legoktm wrote: > PHPUnit. Did you read https://phpu... [12:59:21] 10Hindi-Sites: Hindi Wikiversity is not showing in Wikimedia Stats - https://phabricator.wikimedia.org/T183682#3860411 (10Jayprakash12345) [13:02:13] 10Analytics, 10Analytics-Wikistats, 10Hindi-Sites: Hindi Wikiversity is not showing in Wikimedia Stats - https://phabricator.wikimedia.org/T183682#3860413 (10Aklapper) [13:07:00] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860415 (10D3r1ck01) [13:13:39] 10Apex, 10BlueSpice, 10Bouquet, 10DeepSea, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3860416 (10thiemowmde) > […] if we weren't commenting it […] Comments don't solve the issue here. Comments can give reasons, but they can not magically... [13:13:55] (03PS6) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [13:23:24] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860418 (10D3r1ck01) [13:24:39] (03PS1) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [13:24:58] 10ContentTranslation: Issue with autoloading of ContentTranslation\Translation from SpecialContentTranslation.php - https://phabricator.wikimedia.org/T183683#3860420 (10Albert221) [13:34:59] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860430 (10D3r1ck01) [13:35:47] 10Discovery: Project Progress (internal) - https://phabricator.wikimedia.org/T154592#3860431 (10Aklapper) One year later: Any updates? Is this task still "used"? What is "CW"? [13:40:39] (03PS1) 10Albert221: Fix $.fn.hover deprecation error [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400175 (https://phabricator.wikimedia.org/T182758) [13:45:03] (03CR) 10Nikerabbit: [C: 031] Fix $.fn.hover deprecation error [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400175 (https://phabricator.wikimedia.org/T182758) (owner: 10Albert221) [13:47:47] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860435 (10D3r1ck01) [13:55:10] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860438 (10D3r1ck01) [13:58:16] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860439 (10D3r1ck01) [14:07:24] (03CR) 10Rafidaslam: "12:36:06 Generating optimized autoload files" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/399480 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [14:27:20] 10MediaWiki-General-or-Unknown, 10CSS: Replace layout-only span.mw-editButtons-pipe-separator in favor of CSS - https://phabricator.wikimedia.org/T183672#3860440 (10matmarex) Pipes like on Special:Contributions and Special:DeletedContributions are used in a large number of places (see usages of the 'Language::... [14:28:25] 10OOjs-UI, 10UI-Standardization, 10CSS, 10Design, and 3 others: Adding 'margin-bottom' for widgets which are part of OOUI HorizontalLayout - https://phabricator.wikimedia.org/T179040#3860441 (10matmarex) 05Open>03Resolved [14:31:46] (03CR) 10Bartosz Dziewoński: [C: 032] Remove font-size now it is set by editfont [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399616 (https://phabricator.wikimedia.org/T180678) (owner: 10Esanders) [14:33:36] (03Merged) 10jenkins-bot: Remove font-size now it is set by editfont [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399616 (https://phabricator.wikimedia.org/T180678) (owner: 10Esanders) [14:34:49] 10Analytics, 10Analytics-Wikistats, 10Hindi-Sites: Hindi Wikiversity is not showing in Wikimedia Stats - https://phabricator.wikimedia.org/T183682#3860444 (10Aklapper) And for context: https://phabricator.wikimedia.org/T171831#3502959 [14:37:20] (03PS2) 10Bartosz Dziewoński: Add collation for Abkhaz (ab) [core] - 10https://gerrit.wikimedia.org/r/399537 (https://phabricator.wikimedia.org/T183430) [14:37:48] (03CR) 10Bartosz Dziewoński: [C: 032] Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [14:53:02] 10Pywikibot-Other-scripts, 10Pywikibot-core: patrol.py: Disable limit for patrolling changes - https://phabricator.wikimedia.org/T182580#3860445 (10Zoranzoki21) Can this be added for #google-code-in-2017? [14:57:04] 10Pywikibot-Other-scripts, 10Pywikibot-core: transferbot.py: Add option for disabling creating /edithistory subpages - https://phabricator.wikimedia.org/T183684#3860446 (10Zoranzoki21) [15:01:05] 10Community-Tech, 10Tool-Pageviews, 10User-Jayprakash12345: Wrong Label "Daily average:" intead of "Monthly average:" in Pageviews - https://phabricator.wikimedia.org/T183685#3860457 (10Jayprakash12345) [15:08:43] (03PS1) 10Ladsgroup: Update model version when it's different in ScoreParser [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) [15:09:28] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860473 (10D3r1ck01) [15:22:35] 10Community-Tech, 10Tool-Pageviews, 10User-Jayprakash12345: Wrong Label "Daily average:" intead of "Monthly average:" in Pageviews - https://phabricator.wikimedia.org/T183685#3860474 (10Jayprakash12345) See https://github.com/MusikAnimal/pageviews/blob/master/messages/en.json "daily-average": "Daily average... [15:26:55] (03PS1) 10Hashar: swift: remove unused list of packages [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400184 [15:27:53] (03CR) 10Hashar: Fix dupe python-setuptools (033 comments) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [15:31:01] (03PS3) 10Hashar: keystone: remove python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) [15:39:33] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860475 (10D3r1ck01) [15:40:39] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10D3r1ck01) I've iterated over `mediawiki/extensions/*` for all extensions not found in `zuul/layout.yaml`... [15:40:59] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860477 (10D3r1ck01) [15:42:37] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10D3r1ck01) [16:04:35] (03PS1) 10Phantom42: Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) [16:04:41] (03PS13) 10Fomafix: Strip soft hyphens (U+00AD) from title [core] - 10https://gerrit.wikimedia.org/r/393381 (https://phabricator.wikimedia.org/T121979) [16:05:33] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/393381 (https://phabricator.wikimedia.org/T121979) (owner: 10Fomafix) [16:06:35] (03PS2) 10Phantom42: Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) [16:09:15] (03PS1) 10Phantom42: Run phan for mediawiki/extensions/Cite [integration/config] - 10https://gerrit.wikimedia.org/r/400186 (https://phabricator.wikimedia.org/T179554) [16:11:35] (03PS1) 10Phantom42: Run phan for mediawiki/extensions/CiteThisPage [integration/config] - 10https://gerrit.wikimedia.org/r/400187 (https://phabricator.wikimedia.org/T179554) [16:11:59] (03CR) 10Phantom42: "check experimental" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:12:11] (03CR) 10Phantom42: "check experimental" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:15:55] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3860482 (10matmarex) The patches here got merged, but we still do not have a help page and we do not have an announcement... [16:24:07] 10Community-Tech, 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-LoginNotify, and 2 others: "Login to Wikidata as QuickStatementsBot from a computer you have not recently used" - https://phabricator.wikimedia.org/T182867#3837192 (10Vituzzu) Same happens with my Irclogbot, only... [16:24:57] (03CR) 10Phantom42: [C: 031] Fix $.fn.hover deprecation error [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/400175 (https://phabricator.wikimedia.org/T182758) (owner: 10Albert221) [16:54:13] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:56:34] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:57:12] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [integration/config] - 10https://gerrit.wikimedia.org/r/400186 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:57:56] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [integration/config] - 10https://gerrit.wikimedia.org/r/400187 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:06:31] (03PS1) 10Ladsgroup: [WIP] Split ThresholdLookup into two class [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400188 (https://phabricator.wikimedia.org/T181892) [17:06:44] 10Africa-Wikimedia-Developers, 10Toolforge, 10Wikidata, 10Documentation: Wiki(pedi&dat)a RSS user manual updates & IFTTT Flask application UI improvements (on Toolforge) - https://phabricator.wikimedia.org/T146750#3860487 (10D3r1ck01) [17:07:33] 10Africa-Wikimedia-Developers, 10Toolforge, 10Wikidata, 10Documentation: Wiki(pedi&dat)a RSS user manual updates & IFTTT Flask application UI improvements (on Toolforge) - https://phabricator.wikimedia.org/T146750#2670168 (10D3r1ck01) p:05High>03Normal [17:12:11] 10Wikidata, 10Google-Summer-of-Code (2016), 10Story: [Story] Wikidata support for IFTTT - https://phabricator.wikimedia.org/T118463#3860490 (10D3r1ck01) >>! In T118463#3843267, @D3r1ck01 wrote: > Okay @Lydia_Pintscher, could you please put your mentor *hat* back on and ping @Slaporte so this can be expedited... [17:14:58] 10Africa-Wikimedia-Developers, 10Toolforge, 10Wikidata, 10Documentation: Wiki(pedi&dat)a RSS user manual updates & IFTTT Flask application UI improvements (on Toolforge) - https://phabricator.wikimedia.org/T146750#3860491 (10D3r1ck01) [17:22:09] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3854002 (10Anamdas) >>! In T183465#3859807, @Dereckson wrote: > So, for the on-wiki consensus part, you could start by Hi... [17:35:41] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:35:55] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:36:02] (03CR) 10Florianschmidtwelzow: [C: 031] Run phan for mediawiki/extensions/Cite [integration/config] - 10https://gerrit.wikimedia.org/r/400186 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:36:11] (03CR) 10Florianschmidtwelzow: [C: 031] Run phan for mediawiki/extensions/CiteThisPage [integration/config] - 10https://gerrit.wikimedia.org/r/400187 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:36:28] (03CR) 10Florianschmidtwelzow: [C: 031] "Changes in the repo:" [integration/config] - 10https://gerrit.wikimedia.org/r/400186 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:36:41] (03CR) 10Florianschmidtwelzow: [C: 031] "Changes in the repo:" [integration/config] - 10https://gerrit.wikimedia.org/r/400187 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [18:13:30] (03CR) 10Yaron Koren: "This looks great! Another big improvement to the code. Is this okay to merge now, or are there still issues with it?" [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/394752 (owner: 10Umherirrender) [18:18:12] (03PS1) 10Xqt: [doc] Update package info [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400189 [18:28:58] (03PS1) 10Xqt: [doc] Show new features in HIYSTORY.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400190 [18:45:15] 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, and 3 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860495 (10Legoktm) >>! In T183604#3860410, @thiemowmde wrote: >>>! In T183604#3859996, @Legoktm wr... [18:45:30] (03PS2) 10Xqt: [doc] Update package info [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400189 [18:46:32] 10Discovery, 10Wikimedia-Portals: Change "liguru" in "lìgure" in the Wikipedia portal - https://phabricator.wikimedia.org/T180772#3860496 (10Samuele2002) You have to replace Liguru with Lìgure. [18:50:02] 10MediaWiki-Core-Tests, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3860498 (10Legoktm) [18:50:06] 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, and 3 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860497 (10Legoktm) 05Open>03Resolved [19:13:56] (03CR) 10Legoktm: "check experimental" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:30:52] (03CR) 10Legoktm: [C: 032] "Nice find :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/400169 (owner: 10Rafidaslam) [19:31:11] (03Restored) 10Divadsn: Always define wgRestrictionEdit as an empty array for pages [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) (owner: 10Divadsn) [19:31:26] (03PS3) 10Legoktm: Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:34:06] (03PS2) 10Legoktm: WikiEditor depends upon EventLogging for phan checks [integration/config] - 10https://gerrit.wikimedia.org/r/400173 (owner: 10Rafidaslam) [19:34:08] (03PS1) 10Legoktm: TitleBlacklist depends upon Scribunto for phan checks [integration/config] - 10https://gerrit.wikimedia.org/r/400191 [19:34:12] (03Merged) 10jenkins-bot: Fix the return type of Scribunto_LuaLibraryBase::register() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/400169 (owner: 10Rafidaslam) [19:34:27] (03CR) 10Legoktm: [C: 032] WikiEditor depends upon EventLogging for phan checks [integration/config] - 10https://gerrit.wikimedia.org/r/400173 (owner: 10Rafidaslam) [19:34:32] (03CR) 10Legoktm: [C: 032] TitleBlacklist depends upon Scribunto for phan checks [integration/config] - 10https://gerrit.wikimedia.org/r/400191 (owner: 10Legoktm) [19:35:41] (03Merged) 10jenkins-bot: TitleBlacklist depends upon Scribunto for phan checks [integration/config] - 10https://gerrit.wikimedia.org/r/400191 (owner: 10Legoktm) [19:35:59] (03Merged) 10jenkins-bot: WikiEditor depends upon EventLogging for phan checks [integration/config] - 10https://gerrit.wikimedia.org/r/400173 (owner: 10Rafidaslam) [19:36:46] (03CR) 10Legoktm: "check experimental" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:37:12] (03CR) 10Legoktm: "check experimental" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:42:13] (03PS3) 10Legoktm: Run phan for mediawiki/extensions/CiteThisPage [integration/config] - 10https://gerrit.wikimedia.org/r/400187 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:42:15] (03PS3) 10Legoktm: Run phan for mediawiki/extensions/Cite [integration/config] - 10https://gerrit.wikimedia.org/r/400186 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:42:17] (03PS3) 10Legoktm: Run phan for mediawiki/extensions/WikiEditor [integration/config] - 10https://gerrit.wikimedia.org/r/400084 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:42:19] (03PS3) 10Legoktm: Run phan for mediawiki/extensions/TitleBlackList [integration/config] - 10https://gerrit.wikimedia.org/r/400082 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:42:21] (03PS4) 10Legoktm: Run phan for mediawiki/extensions/SyntaxHighlight_GeSHi [integration/config] - 10https://gerrit.wikimedia.org/r/400080 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:42:31] (03CR) 10Legoktm: [C: 032] Run phan for mediawiki/extensions/SyntaxHighlight_GeSHi [integration/config] - 10https://gerrit.wikimedia.org/r/400080 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:42:38] (03CR) 10Legoktm: [C: 032] Run phan for mediawiki/extensions/CiteThisPage [integration/config] - 10https://gerrit.wikimedia.org/r/400187 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:42:42] (03CR) 10Legoktm: [C: 032] Run phan for mediawiki/extensions/Cite [integration/config] - 10https://gerrit.wikimedia.org/r/400186 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:42:46] (03CR) 10Legoktm: [C: 032] Run phan for mediawiki/extensions/WikiEditor [integration/config] - 10https://gerrit.wikimedia.org/r/400084 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:42:50] (03CR) 10Legoktm: [C: 032] Run phan for mediawiki/extensions/TitleBlackList [integration/config] - 10https://gerrit.wikimedia.org/r/400082 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:44:19] (03Merged) 10jenkins-bot: Run phan for mediawiki/extensions/CiteThisPage [integration/config] - 10https://gerrit.wikimedia.org/r/400187 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:44:21] (03Merged) 10jenkins-bot: Run phan for mediawiki/extensions/Cite [integration/config] - 10https://gerrit.wikimedia.org/r/400186 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:44:40] (03Merged) 10jenkins-bot: Run phan for mediawiki/extensions/WikiEditor [integration/config] - 10https://gerrit.wikimedia.org/r/400084 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:44:45] (03Merged) 10jenkins-bot: Run phan for mediawiki/extensions/TitleBlackList [integration/config] - 10https://gerrit.wikimedia.org/r/400082 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:44:47] (03Merged) 10jenkins-bot: Run phan for mediawiki/extensions/SyntaxHighlight_GeSHi [integration/config] - 10https://gerrit.wikimedia.org/r/400080 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:44:54] (03CR) 10Legoktm: "To be honest, I'm not sure if this will work for skins. I'll look into that, but I think you did your part for GCI." [integration/config] - 10https://gerrit.wikimedia.org/r/400157 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:45:52] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:46:12] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:46:19] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis and fix phan warnings [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:46:20] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:46:22] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:48:03] (03Merged) 10jenkins-bot: Add phan configuration for static analysis [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:50:34] (03Merged) 10jenkins-bot: Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:50:36] (03Merged) 10jenkins-bot: Add phan configuration for static analysis and fix phan warnings [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:50:38] (03Merged) 10jenkins-bot: Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:53:07] (03CR) 10jerkins-bot: [V: 04-1] Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:55:37] 10Security-Team, 10phan-taint-check-plugin, 10Google-Code-in-2017: Make phan-taint-check-plugin support Hooks::runWithoutAbort - https://phabricator.wikimedia.org/T183194#3860515 (10Phantom42) a:03Phantom42 I will work on fixing this! [19:59:47] 10AutoWikiBrowser, 10WorkType-Maintenance: Possible bug around WikiFunctions.Parse.Parsers - https://phabricator.wikimedia.org/T183686#3860517 (10Archimea) [20:00:30] (03CR) 10Legoktm: [C: 04-1] "Looks like there are 2 phan errors that need to be fixed :/" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:02:05] 10AutoWikiBrowser, 10WorkType-Maintenance: Possible bug around WikiFunctions.Parse.Parsers - https://phabricator.wikimedia.org/T183686#3860527 (10Archimea) [20:02:59] 10AutoWikiBrowser, 10WorkType-Maintenance: Possible bug around WikiFunctions.Parse.Parsers - https://phabricator.wikimedia.org/T183686#3860517 (10Archimea) p:05Triage>03High [20:07:04] (03CR) 10Phantom42: "Hm. Strange. It doesn't fail on my machine. Anyway, I will try to fix it now" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:15:46] (03CR) 10Hashar: thumbor: `nproc` => $::processorcount (032 comments) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400098 (https://phabricator.wikimedia.org/T183462) (owner: 10Hashar) [20:16:55] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Use response.iter_content - https://phabricator.wikimedia.org/T183666#3860530 (10rafidaslam) a:03rafidaslam Claimed on GCI [20:23:17] (03PS2) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [20:25:16] (03PS3) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [20:28:27] (03CR) 10Phantom42: "I am done! Let's try once more and see if it fails this time!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:28:38] 10ContentTranslation: Issue with autoloading of ContentTranslation\Translation from SpecialContentTranslation.php - https://phabricator.wikimedia.org/T183683#3860420 (10Nikerabbit) Your mediawiki core might be too old. The namespace based autoloading is a very recent feature. [20:32:41] (03PS1) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [20:34:28] 10Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10iOS-app-v5.7.3-Corgi-On-A-Moose: [BUG] Article "Find in Page" not working for search terms containing apostrophe - https://phabricator.wikimedia.org/T182637#3860539 (10Pppery) Oops, ignore that, made a typo in my bug id [20:35:24] (03PS2) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [20:36:56] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate - https://phabricator.wikimedia.org/T183637#3860544 (10Pppery) a:03Pppery [20:39:58] (03CR) 10Phantom42: [C: 031] Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [20:42:04] (03CR) 1001tonythomas: "Looking good, minor improvements." (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [20:46:22] (03CR) 10Anomie: "It's probably not a matter for this task, but do you have any idea if we can get ApiStructureTest to cover the stuff it covers? It seems t" [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [20:47:32] (03CR) 10Anomie: Add @covers tags API tests without them (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [20:52:25] (03PS3) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [20:52:46] (03CR) 10Pppery: "Wow, remarkably fast review" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [20:55:16] 10Pywikibot-Other-scripts, 10Pywikibot-core, 10Google-Code-in-2017: download_dump.py: Use symlink instead of a copy for toolforge users - https://phabricator.wikimedia.org/T183668#3860546 (10divadsn) a:03divadsn Importing `symlink` from `os` should do the fix, right? :) [20:58:31] (03CR) 1001tonythomas: "Almost there. :)" (033 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [21:16:11] 10MediaWiki-Maintenance-scripts: fix needed for cases where users have multiple userids, such as user:0 on enwiki - https://phabricator.wikimedia.org/T182374#3821874 (10Anomie) If you're pointing out how enwiki has 1356 edits where the revision table has `rev_user_text` as '0' (meaning https://en.wikipedia.org/w... [21:22:58] (03CR) 10Legoktm: "I'll look into ApiStructureTest separately, I think we can come up with something..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [21:24:54] (03PS4) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [21:26:32] (03PS5) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [21:36:23] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages, 10Regression: Special:Contributions no longer shows contributions by name - problems listing contributions stored with user ID = 0 - https://phabricator.wikimedia.org/T36873#3860553 (10Anomie) >>! In T36873#3860045, @Ebe123 wrote: > Hein? T179831 hasn'... [21:44:59] (03CR) 1001tonythomas: [C: 032] "LGTM. Thanks :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [21:46:31] (03Merged) 10jenkins-bot: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [21:48:30] (03CR) 10Anomie: Add @covers tags API tests without them (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [21:58:40] (03PS3) 10Legoktm: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 [21:59:02] (03PS3) 10Legoktm: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 [21:59:06] (03CR) 10Legoktm: [C: 032] Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [22:01:39] (03CR) 10Legoktm: [C: 04-1] Add phan configuration for static analysis (033 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [22:06:14] (03Merged) 10jenkins-bot: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [22:06:38] (03PS2) 10BryanDavis: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:06:45] (03CR) 10BryanDavis: [C: 032] tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:06:51] (03PS4) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [22:08:42] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3860561 (10Leg... [22:09:57] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10Leg... [22:10:22] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10Leg... [22:13:26] (03Merged) 10jenkins-bot: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:13:56] (03PS5) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [22:17:25] (03CR) 10jenkins-bot: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [22:22:57] (03PS6) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [22:24:00] (03CR) 10Phantom42: "Thank you for reviewing! Hopefully we will get all issues fixed soon with this :)" (033 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [22:24:04] (03PS3) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [22:24:27] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [22:26:53] (03CR) 10jenkins-bot: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:29:09] (03PS4) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [22:37:34] (03CR) 10BryanDavis: [C: 032] swift: remove unused list of packages [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400184 (owner: 10Hashar) [22:37:53] (03CR) 10BryanDavis: [C: 032] keystone: remove python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [22:38:06] (03Merged) 10jenkins-bot: swift: remove unused list of packages [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400184 (owner: 10Hashar) [22:38:24] (03Merged) 10jenkins-bot: keystone: remove python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [22:46:21] (03CR) 10Umherirrender: "It is ready" [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/394752 (owner: 10Umherirrender) [22:51:34] (03PS1) 10SamanthaNguyen: Use newer DBUpdater function for LoadExtensionSchemaUpdates hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400193 [22:59:52] (03PS1) 10Phantom42: Add Hooks::runWithoutAbort support [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/400194 (https://phabricator.wikimedia.org/T183194) [23:03:34] (03PS1) 10Divadsn: Use symlink instead of copyfile in download_dump.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) [23:07:08] (03CR) 10jerkins-bot: [V: 04-1] Use symlink instead of copyfile in download_dump.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) (owner: 10Divadsn) [23:07:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Almost ready, yes. I'm looking forward to merge this. :-)" (039 comments) [extensions/PageForms] - 10https://gerrit.wikimedia.org/r/394752 (owner: 10Umherirrender) [23:11:23] (03CR) 10Divadsn: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) (owner: 10Divadsn) [23:14:56] (03CR) 10jerkins-bot: [V: 04-1] Use symlink instead of copyfile in download_dump.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) (owner: 10Divadsn) [23:19:09] (03CR) 10Zhuyifei1999: [C: 04-1] "Inconsistent behavior: shutil.copyfile will not terminate with an error if the target file exists, but os.symlink will raise OSError with " [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) (owner: 10Divadsn) [23:20:31] (03CR) 10Divadsn: "Oh, didn't knew that, so a simple path.exists should do it I guess" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) (owner: 10Divadsn) [23:28:30] (03PS2) 10Divadsn: Use symlink instead of copyfile in download_dump.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) [23:31:08] (03CR) 10Zppix: "Recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) (owner: 10Divadsn) [23:31:35] 10Maps-Sprint, 10Maps (Kartographer): Zoom buttons not present - https://phabricator.wikimedia.org/T183254#3860571 (10Ssola) 05Open>03Resolved [23:33:52] (03CR) 10Zhuyifei1999: [C: 04-1] "Rethinking about it, we don't need to check for target file's existence if T183675 were resolved." (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/400195 (https://phabricator.wikimedia.org/T183668) (owner: 10Divadsn) [23:48:44] 10MediaWiki-Parser, 10Parsoid, 10Accessibility: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing - https://phabricator.wikimedia.org/T6521#3860572 (10SMcCandlish) Agreed with TheDJ on all counts, except that it's actually worse. What's happening is that... [23:52:18] 10Maps (Kartographer): Full screen button looks off on static maps - https://phabricator.wikimedia.org/T183687#3860573 (10Ssola) [23:53:20] 10Maps (Kartographer): Full screen button looks off on static maps - https://phabricator.wikimedia.org/T183687#3860583 (10Ssola)