[00:00:36] (03CR) 10Krinkle: "Unless you intentionally added less specific syntax, there is no reason to have this interpreted as less. Might as well roundtrip it to gz" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [00:00:49] (03PS3) 10Jdlrobson: Switch to JsDuck for documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 [00:01:23] (03PS1) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 [00:02:23] (03PS1) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [00:02:27] (03CR) 10jenkins-bot: [V: 04-1] WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [00:03:38] (03CR) 10Krinkle: "Where do you intend to use this by the way? Given that this is something that would be part of the skin (not loaded as its own module, bec" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [00:05:38] (03CR) 10Ori.livneh: [C: 04-2] "I don't think this is right. The crux of the optimization here is that "it's not cheating if you don't get caught" -- that is, we can misr" [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:05:58] (03PS2) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [00:08:48] (03PS3) 10Alex Monk: Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 [00:09:26] (03PS1) 10Aaron Schulz: Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 [00:10:23] (03CR) 10jenkins-bot: [V: 04-1] Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [00:10:59] (03CR) 10Hoo man: "I don't really think that strict consistency is needed over here (for what purpose?). Also changing the format of the array can be an addi" [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:13:58] (03PS1) 10Ssmith: Finishing form touches. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125362 [00:15:30] (03CR) 10Jdlrobson: [C: 031] "Will look closer at code tomorrow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 (owner: 10JGonera) [00:15:37] (03CR) 10Krinkle: "That would be redundant (and possibly less efficient) given gzip doing for us that already (and it'd probably keep the code simpler when n" [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:15:55] (03Abandoned) 10Jdlrobson: Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124649 (owner: 10Jdlrobson) [00:17:05] (03CR) 10Ori.livneh: [C: 04-1] "@Hoo: No, don't kill it. I'll think it over in light of the follow-up comments." [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:17:41] (03CR) 10JGonera: [C: 04-1] "Small issue to fix and ready to go." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson) [00:17:51] (03CR) 10Tim Landscheidt: "So the problem lies not with this change, but apparently is present before when it tries to install openjdk-7-jre-headless. I'll file a b" [operations/puppet] - 10https://gerrit.wikimedia.org/r/125241 (owner: 10Yuvipanda) [00:18:22] (03CR) 10Adamw: "Brilliant! I haven't reviewed includes/persistence/internal/db or the tests yet, otherwise it looks mergeable." (0331 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [00:18:52] (03PS1) 10Mwjames: Add NavbarHorizontalTest [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 [00:19:38] (03CR) 10BryanDavis: "Tested with manual edit on deployment-bastion" [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [00:19:48] (03CR) 10Ori.livneh: [C: 031] Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [00:20:08] (03PS5) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 [00:20:16] (03CR) 10Jdlrobson: Card 1905: Make content transparent when drawer open (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson) [00:21:16] (03PS2) 10JGonera: Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson) [00:21:18] (03CR) 10Adamw: [C: 032] Dont continue if API token validation has failed (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/123797 (owner: 10Mwalker) [00:21:21] (03PS21) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [00:21:29] (03CR) 10Krinkle: "Why is EP included in the first place? Don't we check "content namespace" and "wikitext" model? Either one of those should not be true, or" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [00:21:42] (03CR) 10JGonera: [C: 032] Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson) [00:21:53] (03CR) 10Krinkle: "Ideally VisualEditor doesn't contain code knowing about other extensions, acceptible last resort or temp solution though." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [00:22:09] (03CR) 10jenkins-bot: [V: 04-1] Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson) [00:22:19] (03Merged) 10jenkins-bot: Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson) [00:22:36] (03CR) 10Adamw: [C: 032] Do GenerateToken call after form validation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125065 (owner: 10Mwalker) [00:23:15] (03CR) 10Ori.livneh: [C: 04-1] Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [00:23:25] (03PS2) 10Mwjames: Add NavbarHorizontalTest [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 [00:23:29] (03CR) 10Aaron Schulz: [WIP] Added HHVM support (032 comments) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/120469 (owner: 10Aaron Schulz) [00:24:43] (03CR) 10Adamw: More specific credit card validation. Not pretty but it works. (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/123911 (owner: 10Ssmith) [00:25:56] (03CR) 10Adamw: [C: 032] cleaned up cc validation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124019 (owner: 10Ssmith) [00:26:59] (03CR) 10Mwalker: cleaned up cc validation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124019 (owner: 10Ssmith) [00:28:38] (03PS6) 10JGonera: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 [00:28:58] (03CR) 10Adamw: [C: 032] Finishing form touches. (033 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125362 (owner: 10Ssmith) [00:29:04] (03CR) 10JGonera: Make .mw-ui-button height the same for all buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [00:30:23] (03CR) 10Jeroen De Dauw: Factor hard constraints out of EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124984 (owner: 10Daniel Kinzler) [00:33:06] (03CR) 10Mwalker: [C: 032] "The stuff I was complaining about is for future work!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124019 (owner: 10Ssmith) [00:37:46] (03CR) 10Mwalker: [C: 032] "Complains resolved later in the patch chain." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/123911 (owner: 10Ssmith) [00:42:31] (03PS2) 10Bsitu: Add rev_type to lastRevCache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 [00:44:14] (03CR) 10JGonera: [C: 04-1] "A few issues (also Max's)." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 (owner: 10Jdlrobson) [00:44:16] (03PS2) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 [00:45:41] (03CR) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:01:28] (03CR) 10Ori.livneh: [C: 04-1] Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:04:39] (03CR) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:05:01] (03PS3) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 [01:06:33] (03PS1) 10Manybubbles: Add a max offset parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 [01:07:51] (03CR) 10Spage: "Had trouble running it, question about approach." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123874 (owner: 10Bencmq) [01:12:29] (03CR) 10Manybubbles: "I wonder, now that I've done this, if this isn't better to do in core. It is worse for Elasticsearch then the other backends, mostly beca" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 (owner: 10Manybubbles) [01:18:13] (03PS1) 10Bsitu: Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 [01:19:01] (03PS2) 10Bsitu: Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 [01:19:27] (03CR) 10Bsitu: "I just realize this would cause a problem. The $update is just a partial update. If there is no data in cache, it should not add the par" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125243 (owner: 10Bsitu) [01:19:57] (03CR) 10Bsitu: [C: 032] Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 (owner: 10Bsitu) [01:20:01] (03Merged) 10jenkins-bot: Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 (owner: 10Bsitu) [01:20:16] (03CR) 10Ori.livneh: [C: 032] Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:20:28] (03Merged) 10jenkins-bot: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:28:24] (03PS1) 10Bsitu: Use merge() to update cache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125366 [01:29:02] (03PS8) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [01:39:10] (03CR) 10Foxtrott: Add NavbarHorizontalTest (031 comment) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 (owner: 10Mwjames) [01:40:34] (03CR) 10Katie Horn: [C: 032] Do not fraud check authorize with full amount [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125338 (owner: 10Mwalker) [01:46:34] (03CR) 10Helder.wiki: Enhanced recent changes: explicitly disable by default (031 comment) [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/124292 (owner: 10Nemo bis) [01:55:34] (03PS2) 10MZMcBride: Check for existence before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 (owner: 10EBernhardson) [02:18:12] (03PS1) 10Ori.livneh: uWSGI: strip .ini suffix from instance names [operations/puppet] - 10https://gerrit.wikimedia.org/r/125367 [02:18:53] (03CR) 10Ori.livneh: [C: 032 V: 032] uWSGI: strip .ini suffix from instance names [operations/puppet] - 10https://gerrit.wikimedia.org/r/125367 (owner: 10Ori.livneh) [02:31:41] (03CR) 10Milimetric: [C: 04-1] Changed test_file_manager to avoid using file system (0316 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [02:39:39] (03PS1) 10Mattflaschen: Fix make kss build and explain environment variable in README [core] - 10https://gerrit.wikimedia.org/r/125368 [02:40:01] (03CR) 10Stevenroddis: "$iframeUrl = 'https://creativecommons.org/license/?' ." [core] - 10https://gerrit.wikimedia.org/r/125027 (owner: 10Gerrit Patch Uploader) [02:43:18] (03CR) 10Mattflaschen: "I think there is also a cron job that updates http://tools.wmflabs.org/styleguide/ . This will have to be updated." [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [02:47:28] (03PS4) 10Aude: Add wikidata tables for fullview [operations/software] - 10https://gerrit.wikimedia.org/r/118582 [02:47:30] (03PS1) 10Aude: Add rc_source recentchanges column to labs replica databases [operations/software] - 10https://gerrit.wikimedia.org/r/125369 [02:51:13] (03CR) 10Milimetric: "looking good, mostly cosmetic changes but I didn't look super-closely." (0311 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [02:56:50] (03PS2) 10Aude: Add rc_source recentchanges column to labs replica databases [operations/software] - 10https://gerrit.wikimedia.org/r/125369 [03:04:02] (03PS1) 1001tonythomas: Moved "Date format" user preference to "Appearence" tab [core] - 10https://gerrit.wikimedia.org/r/125370 [03:45:09] (03PS2) 1001tonythomas: Moved "Date format" user preference to "Appearence" tab [core] - 10https://gerrit.wikimedia.org/r/125370 [03:53:57] (03PS14) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [03:54:25] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [03:55:45] (03PS1) 10Hiong3-eng5: SpecialLanguages 1.22 and below compatibility [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 [03:56:57] (03PS15) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [03:57:51] (03CR) 10Mattflaschen: "Changed to use transition instead of skip (per our discussion), and fixed an inconsistency with skipBeforeShow vs. SKIP_BEFORE_SHOW, and a" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [03:58:25] (03CR) 10Mattflaschen: WIP: Refactor and add non-linear tours (034 comments) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:06:58] (03PS5) 10Mattflaschen: Update firsteditve [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 [04:09:01] (03PS3) 10KartikMistry: Disable heartbeats for development environment [services/cxserver] - 10https://gerrit.wikimedia.org/r/124519 [04:14:31] (03CR) 10Mattflaschen: "Updated to use transition" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen) [04:20:59] (03CR) 10Csalvia: Changed test_file_manager to avoid using file system (0313 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [04:21:36] (03CR) 10Csalvia: Changed test_file_manager to avoid using file system (031 comment) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [04:23:28] (03PS18) 10Csalvia: Changed test_file_manager to avoid using file system [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 [04:24:22] (03PS19) 10Csalvia: Changed test_file_manager to avoid using file system [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 [04:32:51] (03PS1) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [04:33:20] (03CR) 10AndyRussG: "See https://gerrit.wikimedia.org/r/#/c/123781/ for a different approach following comments here and on IRC." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [04:39:56] (03PS1) 10BryanDavis: Use valid hostnames in $wgLBFactoryConf [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125373 [04:56:46] (03PS2) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [04:56:59] (03CR) 10Kipcool: "Nice!" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [04:57:30] (03PS2) 10Hiong3-eng5: getPageTitle/getTitle 1.22 and below compatibility [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 [04:58:52] (03CR) 10Hiong3-eng5: "Kindly check for errors. I do not see any more problems here." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [05:00:01] (03PS3) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [05:00:56] (03CR) 10Hiong3-eng5: "Sorry Kip, just saw your comment, If you have time, can you change version checking for me, I do not have time to correct it now. gotta go" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [05:10:20] (03CR) 10Werdna: [C: 031] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [05:10:39] (03CR) 10Aaron Schulz: [C: 032] Use merge() to update cache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125366 (owner: 10Bsitu) [05:10:44] (03Merged) 10jenkins-bot: Use merge() to update cache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125366 (owner: 10Bsitu) [05:11:03] (03CR) 10Werdna: [C: 031] Use of new OutputPage() is deprecated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125345 (owner: 10Bsitu) [05:13:13] (03CR) 10Werdna: [C: 031] TopKIndex.replaceInIndex has incorrect return value in callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124514 (owner: 10Bsitu) [05:14:44] (03CR) 10BryanDavis: "Great start." (035 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [05:24:26] (03CR) 10Nemo bis: "Filed as bug 63805..." [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [05:24:42] (03CR) 10Nemo bis: "Bug 63805" [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [05:29:30] (03CR) 10Werdna: [C: 031] "LGTM, but I guess you should coordinate w/ Erik's UrlGenerator changes in change 121855." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie) [05:45:37] (03CR) 10Werdna: "Haven't reviewed it line by line but overall I really like the approach and I think it's more or less spot on." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [05:47:27] (03CR) 10Werdna: Add Parsoid's CSS modules (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124787 (owner: 10Spage) [05:53:48] (03PS2) 10EBernhardson: Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 [05:53:51] (03PS2) 10EBernhardson: Include LightnCandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 [05:54:34] (03PS3) 10EBernhardson: Check for existance before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 [05:55:13] (03PS2) 10EBernhardson: Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 [05:55:51] (03PS2) 10EBernhardson: Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 [05:59:18] (03PS2) 10EBernhardson: Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 [06:09:07] (03PS2) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [06:09:10] (03PS2) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [06:09:35] (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [06:09:41] (03CR) 10Siebrand: [C: 032 V: 032] Clarify the "Watchlist-details" message [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [06:14:15] (03CR) 10Amire80: "I addressed some somple things locally. I'll submit another patch set to split the files." (034 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/124753 (owner: 10Amire80) [06:24:14] (03Abandoned) 10EBernhardson: Check for existance before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 (owner: 10EBernhardson) [06:24:44] (03Abandoned) 10EBernhardson: More SafeString for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125354 (owner: 10EBernhardson) [06:25:38] (03CR) 10TTO: "PiRSquared: I suggest to just go ahead and add c: to the interwiki map for now. If the world blows up, so be it; but that won't happen, in" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [06:27:20] (03CR) 10Siebrand: [C: 032] "There's no need to remove qqq entries in future patch sets. See https://www.mediawiki.org/wiki/I18n#Removing_existing_messages for details" [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [06:29:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [06:31:59] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [06:53:36] (03CR) 10Tobias Gritschacher: [C: 032] Rename option 'displayBadges' to 'badgeClassNames' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [06:54:04] (03Merged) 10jenkins-bot: Rename option 'displayBadges' to 'badgeClassNames' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [06:59:54] (03PS1) 10Nikerabbit: Make compatible with MediaWiki 1.22 [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/125374 [07:00:26] (03CR) 10Nikerabbit: [C: 032 V: 032] Make compatible with MediaWiki 1.22 [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/125374 (owner: 10Nikerabbit) [07:17:26] (03CR) 10KartikMistry: [C: 04-1] "Broken." [services/cxserver] - 10https://gerrit.wikimedia.org/r/124519 (owner: 10KartikMistry) [07:19:36] (03PS3) 10Hiong3-eng5: getPageTitle/getTitle 1.22 and below compatibility [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 [07:20:26] (03CR) 10Hiong3-eng5: "Made the changes, kindly recheck the code. Thanks!" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [07:26:16] (03PS1) 10Gilles: Fix deprecated condition in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125375 [07:29:27] (03Abandoned) 10Gilles: Fix deprecated condition in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125375 (owner: 10Gilles) [07:35:49] (03CR) 10Gilles: [C: 04-1] "With this change if the author is a link, it's incorrectly escaped:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [07:49:23] (03CR) 10Hashar: [C: 032] Use valid hostnames in $wgLBFactoryConf [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125373 (owner: 10BryanDavis) [07:49:32] (03Merged) 10jenkins-bot: Use valid hostnames in $wgLBFactoryConf [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125373 (owner: 10BryanDavis) [08:00:38] (03CR) 10Nikerabbit: [C: 04-1] Replace deprecated methods (035 comments) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125232 (owner: 10Siebrand) [08:00:57] (03CR) 10Nikerabbit: [C: 032] Fix typo in comment [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [08:02:56] (03PS1) 10Netbrain: Refactored Sift [extensions/SemanticSifter] - 10https://gerrit.wikimedia.org/r/125376 [08:03:44] (03CR) 10Netbrain: [C: 032 V: 032] Refactored Sift [extensions/SemanticSifter] - 10https://gerrit.wikimedia.org/r/125376 (owner: 10Netbrain) [08:13:39] (03CR) 10Hashar: [C: 04-1] "Since the content is being reverted to sans-serif, I would revert the header back to sans-serif as well. Ie remove the stack from @content" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [08:15:51] (03CR) 10Nuria: Changed test_file_manager to avoid using file system (031 comment) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [08:21:03] (03CR) 10Matthias Mullie: Add topic summary revision type (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [08:24:28] (03PS2) 10Matthias Mullie: Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 (owner: 10Bsitu) [08:24:48] (03CR) 10Matthias Mullie: [C: 032] Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 (owner: 10Bsitu) [08:25:02] (03Merged) 10jenkins-bot: Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 (owner: 10Bsitu) [08:30:40] (03CR) 10Nuria: Allowing wikimetrics $debug parameter to be set from labsconsole (031 comment) [operations/puppet] - 10https://gerrit.wikimedia.org/r/125274 (owner: 10Ottomata) [08:56:44] (03PS5) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [08:56:46] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [08:58:02] (03CR) 10jenkins-bot: [V: 04-1] Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [09:02:19] (03CR) 10Santhosh: [C: 04-1] Allow always logging tofu detection (035 comments) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/118996 (owner: 10Amire80) [09:04:23] (03PS20) 10Nuria: Changed test_file_manager to avoid using file system [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [09:04:40] (03PS1) 10Adrian Lang: Introduce explit data-values/interfaces dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 [09:04:43] (03PS1) 10Adrian Lang: Don't catch ParseException in order to just rethrow it wrapped [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125378 [09:04:44] (03PS1) 10Adrian Lang: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 [09:04:47] (03PS1) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [09:04:49] (03PS1) 10Adrian Lang: Bump data-values/time dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [09:06:24] (03PS2) 10Gerrit Patch Uploader: Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 [09:06:26] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [09:07:41] (03CR) 10jenkins-bot: [V: 04-1] Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [09:07:44] (03CR) 10Odder: "I have no intention of modifying anything else with this patch; as I said before, I'm trying to do one thing at a time. Please submit your" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [09:13:16] (03PS4) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [09:13:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 (owner: 10Adrian Lang) [09:15:18] (03PS5) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [09:15:52] (03PS1) 10Netbrain: fixed small issue [extensions/SemanticSifter] - 10https://gerrit.wikimedia.org/r/125382 [09:16:09] (03CR) 10Netbrain: [C: 032 V: 032] fixed small issue [extensions/SemanticSifter] - 10https://gerrit.wikimedia.org/r/125382 (owner: 10Netbrain) [09:18:04] (03CR) 10Kushal124: "@Bryan Made changes as suggested." (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [09:19:58] (03PS3) 10Gerrit Patch Uploader: Exclude user interface elements in content from selection [core] - 10https://gerrit.wikimedia.org/r/110186 [09:20:00] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110186 (owner: 10Gerrit Patch Uploader) [09:20:06] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125378 (owner: 10Adrian Lang) [09:21:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [09:22:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [09:23:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [09:26:50] (03PS5) 10Gerrit Patch Uploader: wpSummaryLabel and wpSummary in one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 [09:26:52] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [09:27:45] (03CR) 10Matthias Mullie: [C: 04-1] Add rev_type to lastRevCache key (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [09:31:51] (03PS1) 10Gilles: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 [09:32:22] (03CR) 10jenkins-bot: [V: 04-1] Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [09:35:25] (03PS2) 10Adrian Lang: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 [09:35:27] (03PS2) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [09:35:29] (03PS2) 10Adrian Lang: Bump data-values/time dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [09:35:40] (03CR) 10Odder: Revert font stack to be just sans-serif (032 comments) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [09:35:49] (03CR) 10Gilles: [V: 032] "The usual doc test segfault" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [09:37:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [09:38:49] (03Abandoned) 10Adrian Lang: Don't catch ParseException in order to just rethrow it wrapped [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125378 (owner: 10Adrian Lang) [09:39:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [09:41:18] (03CR) 10Ori.livneh: [C: 032] Revoke my key, I'm relocating to SF [operations/puppet] - 10https://gerrit.wikimedia.org/r/125267 (owner: 10MaxSem) [09:41:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [09:44:52] (03CR) 10Matthias Mullie: "Just some quick notes, haven't done thorough review yet" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [09:46:35] (03PS2) 10Adrian Lang: Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb [core] - 10https://gerrit.wikimedia.org/r/121604 [09:46:56] (03CR) 10Ori.livneh: "purged on all hosts via salt as well." [operations/puppet] - 10https://gerrit.wikimedia.org/r/125267 (owner: 10MaxSem) [09:48:17] (03CR) 10Hashar: [C: 04-1] "Duplicates the packages defined contint::android-sdk . You might want to create a common class for tools labs and contint :]" (031 comment) [operations/puppet] - 10https://gerrit.wikimedia.org/r/125241 (owner: 10Yuvipanda) [09:49:58] (03PS2) 10Zfilipin: Changed Cucumber tags according to the convention [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/125123 [09:54:20] (03PS2) 10Gilles: Restore article scroll after closing Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 [09:58:21] (03PS1) 10Whym: textlib.py: provide zero value for timedelta [pywikibot/core] - 10https://gerrit.wikimedia.org/r/125384 [10:00:24] (03PS1) 10WikidataBuilder: New Wikidata Build - 11/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 [10:00:51] (03PS2) 10Gerrit Patch Uploader: Remove #bodyContent { width: 100%; } [core] - 10https://gerrit.wikimedia.org/r/120528 [10:00:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/120528 (owner: 10Gerrit Patch Uploader) [10:04:10] (03CR) 10Nemo bis: Revert font stack to be just sans-serif (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [10:06:37] (03CR) 10Matthias Mullie: "This is still WIP. The patch should work already, but I have not thoroughly tested it, there's undoubtedly some things to be cleaned up, a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125228 (owner: 10Matthias Mullie) [10:07:02] (03PS7) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 [10:07:04] (03PS11) 10Phuedx: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [10:07:48] (03PS3) 10Zfilipin: Changed Cucumber tags according to the convention [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/125123 [10:08:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [10:11:30] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 11/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [10:12:39] (03PS1) 10Zfilipin: Cucumber should only run tests tagged both @clean and @firefox or @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:13:12] (03PS2) 10Zfilipin: Cucumber should only run tests tagged both @clean and @firefox or @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:13:28] (03CR) 10jenkins-bot: [V: 04-1] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [10:14:33] (03Merged) 10jenkins-bot: New Wikidata Build - 11/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [10:15:29] (03CR) 10jenkins-bot: [V: 04-1] Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 (owner: 10Phuedx) [10:16:02] (03CR) 10Siebrand: "Can't submit changes to Gerrit from where I am now. WIll do that when I get home." (034 comments) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125232 (owner: 10Siebrand) [10:17:05] (03PS1) 10Pginer: Grid system for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/125387 [10:18:23] (03PS3) 10Zfilipin: Cucumber should only run tests tagged both @clean and @firefox or @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:18:48] (03PS4) 10Zfilipin: Cucumber should only run tests tagged both @clean and (@firefox or @phantomjs) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:21:45] (03CR) 10Siebrand: Grid system for mediawiki.ui (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [10:22:17] (03PS1) 10Daniel Kinzler: Changing a message's lang must reset cached text. [core] - 10https://gerrit.wikimedia.org/r/125388 [10:22:20] (03CR) 10KartikMistry: Grid system for mediawiki.ui (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [10:23:25] (03CR) 10Nikerabbit: Replace deprecated methods (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125232 (owner: 10Siebrand) [10:24:04] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Overall this change is very good. Please let me know if I can help you. If it's ok for you I can do some of the fixes I mentioned in the c" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [10:26:36] (03PS4) 10Zfilipin: Changed Cucumber tags according to the convention [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/125123 [10:26:54] (03PS2) 10Pginer: Grid system for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/125387 [10:29:49] (03PS1) 10Nikerabbit: Replace deprecated methog usages [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125389 [10:31:58] (03CR) 10Siebrand: [C: 032] Replace deprecated methog usages [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125389 (owner: 10Nikerabbit) [10:33:04] (03Merged) 10jenkins-bot: Replace deprecated methog usages [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125389 (owner: 10Nikerabbit) [10:35:09] (03CR) 10Siebrand: Replace deprecated methods (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125232 (owner: 10Siebrand) [10:43:47] (03PS1) 10Marcoil: Ensure parsoid server is killed when exiting roundtrip-test [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 [10:47:04] (03CR) 10Mpaa: [C: 032] textlib.py: provide zero value for timedelta [pywikibot/core] - 10https://gerrit.wikimedia.org/r/125384 (owner: 10Whym) [10:47:16] (03Merged) 10jenkins-bot: textlib.py: provide zero value for timedelta [pywikibot/core] - 10https://gerrit.wikimedia.org/r/125384 (owner: 10Whym) [10:56:02] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I'm sorry but I will not merge this change. All it does (now) is removing something that's unused and does no harm. There was a reason arr" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [10:58:46] (03PS8) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 [10:58:48] (03PS12) 10Phuedx: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [11:00:17] (03PS1) 10Aude: Add method to get EnhancedChanges cache grouping key [core] - 10https://gerrit.wikimedia.org/r/125391 [11:03:29] (03CR) 10Nikerabbit: Replace deprecated methog usages (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125389 (owner: 10Nikerabbit) [11:06:04] (03CR) 10Nikerabbit: [C: 04-1] "Please fix inContentLanguage as well." [core] - 10https://gerrit.wikimedia.org/r/125388 (owner: 10Daniel Kinzler) [11:12:54] (03CR) 10Siebrand: Replace deprecated methog usages (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/125389 (owner: 10Nikerabbit) [11:27:13] (03CR) 10Milimetric: Allowing wikimetrics $debug parameter to be set from labsconsole (031 comment) [operations/puppet] - 10https://gerrit.wikimedia.org/r/125274 (owner: 10Ottomata) [11:28:27] (03PS2) 10Hashar: Add checks for WikiForum extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124731 (owner: 10Addshore) [11:28:40] (03CR) 10Hashar: [C: 032] Add checks for WikiForum extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124731 (owner: 10Addshore) [11:29:26] (03Merged) 10jenkins-bot: Add checks for WikiForum extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124731 (owner: 10Addshore) [11:30:16] (03PS3) 10Hashar: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:35:24] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [11:35:58] (03PS1) 10Prtksxna: Replace animiationend with setTimeout [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 [11:36:11] (03PS4) 10Hashar: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:37:53] (03CR) 10Hashar: [C: 032] Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:38:03] (03Merged) 10jenkins-bot: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:38:56] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:39:15] (03CR) 10Prtksxna: "This is a quick fix for IE9" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 (owner: 10Prtksxna) [11:47:27] (03CR) 10Nuria: Changed test_file_manager to avoid using file system (035 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [11:50:07] (03CR) 10Milimetric: Changed test_file_manager to avoid using file system (034 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [11:50:21] (03CR) 10Nikerabbit: "The longest unchanging parts are "{{fullurl:Special:UserLogin/signup|returnto={{FULLPAGENAMEE}}" which can be supplied as $-type variable" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [11:50:33] (03CR) 10Addshore: "zuul / jenkins seems to have got stuck" [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [11:50:37] (03PS2) 10Addshore: Fix typo in comment [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [11:50:41] (03CR) 10Addshore: [C: 032] Fix typo in comment [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [11:51:42] (03CR) 10Mwjames: Add NavbarHorizontalTest (031 comment) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 (owner: 10Mwjames) [11:54:00] (03CR) 10Bartosz Dziewoński: [C: 04-1] Make .mw-ui-button height the same for all buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [12:14:45] (03CR) 10Adrian Lang: [C: 032] Fix site links group filtering in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124332 (owner: 10Aude) [12:15:16] (03Merged) 10jenkins-bot: Fix site links group filtering in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124332 (owner: 10Aude) [12:17:55] (03CR) 10Hashar: [C: 032] "Yes that should be enough :-] Deploying." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:18:11] (03PS2) 10Hashar: Trigger unit tests for the Campaigns extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:18:19] (03CR) 10Hashar: [C: 032] Trigger unit tests for the Campaigns extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:18:29] (03Merged) 10jenkins-bot: Trigger unit tests for the Campaigns extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:19:18] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/70381 (owner: 10Hashar) [12:19:24] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/70381 [12:21:18] (03CR) 10Hashar: "Tests are passing. I created the dummy change https://gerrit.wikimedia.org/r/#/c/70381/ which triggered the successful job https://integra" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:21:20] (03CR) 10jenkins-bot: [V: 04-1] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [12:21:22] (03CR) 10jenkins-bot: [V: 04-1] Moved "Date format" user preference to "Appearence" tab [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [12:21:29] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/70381 (owner: 10Hashar) [12:24:29] (03CR) 10Adrian Lang: [C: 032] "Had a short talk with Lydia; she is pretty sure we want it like that and she is aware of the technical implications." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121361 (owner: 10Daniel Kinzler) [12:24:40] (03Merged) 10jenkins-bot: (bug 57693) supply id for claim group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121361 (owner: 10Daniel Kinzler) [12:27:18] (03CR) 10Adrian Lang: [C: 032] Have travis test variety of setups (client-only, repo-only and both) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123864 (owner: 10Aude) [12:27:42] (03Merged) 10jenkins-bot: Have travis test variety of setups (client-only, repo-only and both) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123864 (owner: 10Aude) [12:29:47] (03CR) 10Aude: [C: 04-1] "given bug 63710 deals with similar issues, we might want to rethink this some and come up with a solution that works for both places where" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [12:30:42] (03CR) 10Adrian Lang: [C: 032] Add tests for formatting dates in different langs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 (owner: 10Addshore) [12:31:09] (03Merged) 10jenkins-bot: Add tests for formatting dates in different langs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 (owner: 10Addshore) [12:32:12] (03Abandoned) 10Aude: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 (owner: 10Aude) [12:35:27] (03Abandoned) 10Aude: Pass Message object as param in MessageException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121123 (owner: 10Aude) [12:36:05] (03Abandoned) 10Aude: Improve TermPropertyLabelResolver and test, including more cache scenarios [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100192 (owner: 10Aude) [12:37:27] (03Abandoned) 10Aude: (bug 43506) Fix pager in Special:Categories, make offset default param [core] - 10https://gerrit.wikimedia.org/r/41215 (owner: 10Aude) [12:38:49] (03CR) 10Aude: "typo" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [12:39:04] (03PS1) 10Hashar: Make mwext-InputBox-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125393 [12:39:23] (03CR) 10Hashar: [C: 032] Make mwext-InputBox-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125393 (owner: 10Hashar) [12:39:33] (03Merged) 10jenkins-bot: Make mwext-InputBox-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125393 (owner: 10Hashar) [12:43:47] (03PS1) 10Manybubbles: send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 [12:47:48] (03PS2) 10Manybubbles: send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 [12:49:45] (03CR) 10Manybubbles: "After this fix I reran it. 50% of enwiki's traffic pushed us to 45% load. Obviously not good enough but much better then before." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 (owner: 10Manybubbles) [12:54:21] (03PS1) 10Manybubbles: Prefer title for prefix search match [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125395 [12:54:51] (03PS1) 10Manybubbles: Add support for the experimental highlighter [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125396 [12:58:48] (03PS1) 10TheDJ: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 [13:00:29] (03PS4) 10Addshore: Normalise digits in time formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124868 (owner: 10Aude) [13:01:07] (03CR) 10Tobias Gritschacher: [C: 032] "Fine with that as an improvement over the '?'." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:01:32] (03Merged) 10jenkins-bot: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:01:52] (03CR) 10Adrian Lang: Handle exceptions in ClaimDifferenceVisualizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:03:19] (03CR) 10Aude: Handle exceptions in ClaimDifferenceVisualizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:03:32] (03CR) 10Tobias Gritschacher: "@aude can't we use the MismatchingDataValueTypeException for the other cases too?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:03:41] (03PS2) 10TheDJ: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 [13:04:26] (03CR) 10Aude: "maybe do in snak formatter, although might not work because we then want to be able to apply css classes for the error styling and such" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:05:38] (03CR) 10Aude: "this is okay as an improvement, though further work is needed to use mismatch exception in more places (including EntityIdValue formatters" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:06:01] (03CR) 10Tobias Gritschacher: "Is this blocked on something specific in going further as DanielK suggested? Also this needs rebasing. This is likely to get stale, so I w" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [13:06:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124868 (owner: 10Aude) [13:06:48] (03CR) 10Addshore: [C: 032 V: 031] Normalise digits in time formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124868 (owner: 10Aude) [13:07:05] (03CR) 10Addshore: [C: 04-2] Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:07:45] (03PS19) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [13:08:20] (03PS20) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [13:09:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:09:57] (03PS3) 10Bartosz Dziewoński: Moved "Date format" user preference to "Appearance" tab [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [13:10:08] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] "Per Siebrand." [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [13:11:29] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:15:23] (03PS13) 10Addshore: Fix formatting dates in all languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 [13:16:11] (03CR) 10Addshore: Fix formatting dates in all languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:16:20] (03PS5) 10Addshore: Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [13:16:31] (03CR) 10Addshore: [C: 04-2] When precision is a <= year use 'Y' dateformat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125177 (owner: 10Addshore) [13:20:27] (03PS21) 10Tobias Gritschacher: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:24:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:26:52] (03PS14) 10Addshore: Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 [13:28:03] (03PS2) 10Addshore: Fallback to en formatting of dates on failure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 [13:28:17] (03Abandoned) 10Addshore: When precision is a <= year use 'Y' dateformat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125177 (owner: 10Addshore) [13:28:28] (03CR) 10Addshore: "See https://gerrit.wikimedia.org/r/124836" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125177 (owner: 10Addshore) [13:28:40] (03Abandoned) 10Addshore: Stop ALWAYS using regex to fix dateFormats [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124833 (owner: 10Addshore) [13:29:00] (03Draft1) 10Addshore: Add extension composer-install bash script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125041 [13:29:05] (03PS2) 10Addshore: Add extension composer-install bash script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125041 [13:29:11] (03CR) 10Addshore: "This is untested" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125041 (owner: 10Addshore) [13:29:14] (03Draft3) 10Addshore: Add composer-install-extensions builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125042 [13:29:18] (03PS4) 10Addshore: Add composer-install-extensions builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125042 [13:29:22] (03CR) 10Addshore: "This is untested" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125042 (owner: 10Addshore) [13:30:05] (03PS6) 10Addshore: Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [13:32:39] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [13:38:13] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:38:21] (03PS11) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [13:41:02] (03CR) 10Jeroen De Dauw: [C: 04-1] "it bumps number, not time" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [13:41:35] (03PS1) 10Zfilipin: Releasing patch version 0.1.2 [ruby/api] - 10https://gerrit.wikimedia.org/r/125398 [13:41:48] (03CR) 10Umherirrender: "replay to inline comments" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [13:41:52] (03CR) 10Jeroen De Dauw: [C: 031] "Generally looks good to me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [13:42:02] (03CR) 10Zfilipin: [C: 032] Releasing patch version 0.1.2 [ruby/api] - 10https://gerrit.wikimedia.org/r/125398 (owner: 10Zfilipin) [13:42:04] (03Merged) 10jenkins-bot: Releasing patch version 0.1.2 [ruby/api] - 10https://gerrit.wikimedia.org/r/125398 (owner: 10Zfilipin) [13:43:24] (03PS1) 10Addshore: Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 [13:43:34] (03CR) 10jenkins-bot: [V: 04-1] Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [13:45:04] (03PS2) 10Addshore: Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 [13:46:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:50:04] (03CR) 10Chad: Add a max offset parameter (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 (owner: 10Manybubbles) [13:52:10] (03PS3) 10Manybubbles: Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 [13:53:41] (03CR) 10Manybubbles: Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 (owner: 10Manybubbles) [13:55:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [13:56:36] (03CR) 10Csalvia: Changed test_file_manager to avoid using file system (032 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [13:58:15] (03CR) 10Csalvia: Changed test_file_manager to avoid using file system (032 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [13:59:19] (03PS3) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [14:02:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [14:03:03] (03CR) 10Csalvia: Changed test_file_manager to avoid using file system (033 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [14:04:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:06:06] (03PS1) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:06:42] (03CR) 10jenkins-bot: [V: 04-1] Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [14:07:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [14:07:53] (03PS2) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:10:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [14:13:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [14:14:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [14:15:07] (03PS8) 10Cmcmahon: QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [14:15:09] (03PS3) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:18:57] (03PS1) 10Dan-nl: wfStripIllegalFilenameChars truncates title [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125401 [14:21:14] (03PS21) 10Csalvia: Changed test_file_manager to avoid using file system [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 [14:24:11] (03PS3) 10Milimetric: Support public recurrent report links [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125245 [14:24:17] (03PS3) 10Milimetric: Make private recurrent reports not possible [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125261 [14:24:22] (03PS3) 10Milimetric: Permanent option for site messages [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125265 [14:24:26] (03PS3) 10Milimetric: Messages on report screen persist [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125266 [14:31:17] (03PS1) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [14:31:49] (03CR) 10jenkins-bot: [V: 04-1] Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [14:32:41] (03PS2) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [14:35:54] (03CR) 10Chad: [C: 032] Prefer title for prefix search match [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125395 (owner: 10Manybubbles) [14:36:04] (03Merged) 10jenkins-bot: Prefer title for prefix search match [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125395 (owner: 10Manybubbles) [14:37:36] (03CR) 10Chad: [C: 032] Add support for the experimental highlighter [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125396 (owner: 10Manybubbles) [14:37:45] (03Merged) 10jenkins-bot: Add support for the experimental highlighter [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125396 (owner: 10Manybubbles) [14:38:02] (03CR) 10Shirayuki: "Wow!" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [14:39:19] (03CR) 10Chad: [C: 032] Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 (owner: 10Manybubbles) [14:39:27] (03Merged) 10jenkins-bot: Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 (owner: 10Manybubbles) [14:41:21] (03PS1) 10Ottomata: Adding hdfs user to stats group [operations/puppet] - 10https://gerrit.wikimedia.org/r/125403 [14:42:15] (03CR) 10Cmcmahon: [C: 04-1] "This sort of thing works better with smaller, more granular commits." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [14:44:17] (03CR) 10Anomie: [C: 04-1] "Good catch! But neither of those make a whole lot of sense, really. The intention here is to turn "

foo

" into "foo", but neither tra" [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [14:49:22] (03PS10) 10Anomie: HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 [14:49:24] (03PS9) 10Anomie: Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 [14:49:26] (03PS7) 10Anomie: HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 [14:54:11] (03PS3) 10Anomie: API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 [14:54:25] (03CR) 10Anomie: "PS3: Rebase" [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [14:55:11] (03PS3) 10Pginer: Grid system for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/125387 [14:58:32] (03PS5) 10Anomie: Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [14:58:55] (03PS4) 10Gilles: Load oojs-ui on demand when "use this file" is clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 [14:58:57] (03PS3) 10Gilles: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 [15:00:26] (03PS2) 10Ottomata: Adding hdfs user to stats group [operations/puppet] - 10https://gerrit.wikimedia.org/r/125403 [15:00:27] (03CR) 10Anomie: [C: 031] "Code looks like it'll work, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [15:02:40] (03PS2) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 [15:03:00] (03CR) 10Ottomata: [C: 032 V: 032] Adding hdfs user to stats group [operations/puppet] - 10https://gerrit.wikimedia.org/r/125403 (owner: 10Ottomata) [15:03:41] (03PS3) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 [15:05:55] (03PS1) 10Ottomata: Need to fully qualify all executables in unless command [operations/puppet] - 10https://gerrit.wikimedia.org/r/125404 [15:06:14] (03CR) 10Ottomata: [C: 032 V: 032] Need to fully qualify all executables in unless command [operations/puppet] - 10https://gerrit.wikimedia.org/r/125404 (owner: 10Ottomata) [15:07:45] (03PS3) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 [15:07:49] (03PS12) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [15:08:15] (03CR) 10jenkins-bot: [V: 04-1] (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:09:00] (03PS1) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:09:21] (03PS2) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:09:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:09:36] (03PS4) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 [15:09:40] (03PS1) 10Ottomata: Using exec path rather than fully qualifying [operations/puppet] - 10https://gerrit.wikimedia.org/r/125406 [15:10:14] (03CR) 10Ottomata: [C: 032 V: 032] Using exec path rather than fully qualifying [operations/puppet] - 10https://gerrit.wikimedia.org/r/125406 (owner: 10Ottomata) [15:11:26] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 (owner: 10Hashar) [15:11:31] (03PS5) 10Zfilipin: Cucumber should only run tests tagged both @clean and (@firefox or @phantomjs) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [15:11:33] (03PS9) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [15:11:34] (03CR) 10Bene: Insert classes for badges on client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:12:23] (03PS4) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 [15:16:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:18:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:18:51] (03PS3) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:19:07] (03CR) 10Tobias Gritschacher: [C: 032] Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [15:19:51] (03PS5) 10Zfilipin: Changed Cucumber tags according to the convention [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/125123 [15:23:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [15:23:55] (03CR) 10Nuria: Changed test_file_manager to avoid using file system (031 comment) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [15:26:52] (03CR) 10Hashar: "That broke the qa-browsertests-build and qa-browsertests-postmerge jobs which are expecting the Gemfile to be at the root of the repositor" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/111997 (owner: 10Zfilipin) [15:27:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:28:00] (03PS4) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:28:38] (03PS1) 10Pginer: Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 [15:29:11] (03CR) 10jenkins-bot: [V: 04-1] Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 (owner: 10Pginer) [15:29:51] (03CR) 10Hashar: [C: 032] "Confirmed it fix the postmerge and build jobs." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 (owner: 10Hashar) [15:30:21] (03PS2) 10Pginer: Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 [15:30:32] (03Merged) 10jenkins-bot: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 (owner: 10Hashar) [15:31:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:31:39] (03PS1) 10Jeroen De Dauw: Update used Diff and DM versions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125408 [15:38:21] (03CR) 10Stefan.petrea: "sloccount indicates there are 3116 lines of Python code in wikimetrics(at the time this commit was merged)." [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124333 (owner: 10QChris) [15:38:23] (03PS1) 10Manybubbles: Small docs fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125409 [15:39:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125408 (owner: 10Jeroen De Dauw) [15:42:00] (03Abandoned) 10Stefan.petrea: Fixing mingle 358 [analytics/wikistats] - 10https://gerrit.wikimedia.org/r/62422 (owner: 10Stefan.petrea) [15:46:06] (03PS1) 10Manybubbles: Switch Cirrus to a faster query type ` [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125410 [15:48:52] (03PS1) 10Hashar: browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 [15:49:29] (03CR) 10Hashar: "For the browsertests-qa-* jobs that is done by follow up https://gerrit.wikimedia.org/r/#/c/125411/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112682 (owner: 10Hashar) [15:49:58] (03CR) 10Hashar: "Will look at that on monday evening. Too late to play with that on a friday night :]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 (owner: 10Hashar) [15:51:31] (03CR) 10Manybubbles: [C: 032] browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 (owner: 10Hashar) [15:51:46] (03CR) 10Hashar: "Added myself as a reviewer as a reminder. Might look at it next Tuesday." [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [15:51:49] (03PS1) 10Ottomata: Changing Licenses from GPL-2 to Apache-2 [analytics/kraken] - 10https://gerrit.wikimedia.org/r/125412 [15:52:13] (03Merged) 10jenkins-bot: browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 (owner: 10Hashar) [15:57:13] (03PS1) 10Arlolra: Fix template nesting when end unreachable [services/parsoid] - 10https://gerrit.wikimedia.org/r/125413 [15:58:33] (03CR) 10Arlolra: "Something similar is happening in arwiki:كأس_الأمم_الآسيوية_لكرة_القدم_2000:" [services/parsoid] - 10https://gerrit.wikimedia.org/r/125413 (owner: 10Arlolra) [15:59:12] (03PS1) 10Zfilipin: APIPage can create pages via API [selenium] - 10https://gerrit.wikimedia.org/r/125414 [16:02:17] (03CR) 10Kipcool: [C: 032 V: 032] "I also didn't have time ;)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [16:02:23] (03CR) 10Cmcmahon: [C: 032] "paired with Zeljko for this" [selenium] - 10https://gerrit.wikimedia.org/r/125414 (owner: 10Zfilipin) [16:07:23] (03PS1) 10Zfilipin: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 [16:07:42] (03PS2) 10Zfilipin: QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 [16:15:49] (03CR) 10Arlolra: "does tests/client/client.js need something similar? should these all get pushed in apiServer.js?" [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [16:17:49] (03CR) 10Cmcmahon: [C: 031] "Paired with Zeljko for this, tested with the live Ruby gem. +1 for now while people look it over before merging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin) [16:23:39] (03CR) 10MarkTraceur: "Weird, the test should have caught this. Will fix between meetings, 'round 11:00 PDT" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [16:24:47] (03CR) 10Marcoil: "Yes, I think client.js will need it as well. And as it's going to be the same for everything that uses apiServer.js, moving it there would" [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [16:27:23] (03CR) 10Milimetric: "Thanks Stefan :) It's true, I looked at the same thing. While that's double the original amount, I think it's still not a huge number. " [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124333 (owner: 10QChris) [16:27:57] (03CR) 10Chad: [C: 032 V: 032] Small docs fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125409 (owner: 10Manybubbles) [16:28:19] (03CR) 10Chad: [C: 032] Strip citation links (like [1], [2], etc) from HTML [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123878 (owner: 10Chad) [16:28:28] (03Merged) 10jenkins-bot: Strip citation links (like [1], [2], etc) from HTML [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123878 (owner: 10Chad) [16:29:15] (03CR) 10Chad: [C: 032] send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 (owner: 10Manybubbles) [16:29:22] (03Merged) 10jenkins-bot: send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 (owner: 10Manybubbles) [16:30:03] (03PS2) 10Chad: Switch Cirrus to a faster query type [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125410 (owner: 10Manybubbles) [16:32:09] (03CR) 10Tim Landscheidt: [C: 031] "I'm now confident that the change as is is good(TM), and that the Puppet failure is unrelated (cf. bug #63823 for that)." [operations/puppet] - 10https://gerrit.wikimedia.org/r/125241 (owner: 10Yuvipanda) [16:34:34] (03CR) 10Arlolra: "A concern is that it might not be obvious that the apiServer is co-opting those signals." [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [16:40:25] (03PS1) 10Milimetric: Final UI for public recurrent [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125418 [16:50:24] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Disable crashy AutoCompleteTextView in edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125271 (owner: 10Brion VIBBER) [16:50:49] (03Merged) 10jenkins-bot: [Gingerbread] Disable crashy AutoCompleteTextView in edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125271 (owner: 10Brion VIBBER) [16:56:04] (03CR) 10Milimetric: [C: 032] "For the record, this change was made after we received the consent of all contributors to this repository with one exception. The person " [analytics/kraken] - 10https://gerrit.wikimedia.org/r/125412 (owner: 10Ottomata) [17:02:52] (03PS3) 10Krinkle: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 [17:03:00] (03PS4) 10Krinkle: IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [17:03:39] (03CR) 10Nuria: [WIP] Runs of reports that are public should create corresponding files on disk. (0310 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [17:04:48] (03CR) 10Krinkle: [C: 04-1] "Good in general, but a bit confusing atm." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [17:05:08] (03PS3) 10Krinkle: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [17:05:29] (03PS2) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [17:06:09] (03CR) 10SirComputer: [C: 031] "I think it all looks good, and it's been quite a while since a response was given on this." [core] - 10https://gerrit.wikimedia.org/r/111532 (owner: 10UltrasonicNXT) [17:06:15] (03CR) 10Addshore: [C: 032] Update used Diff and DM versions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125408 (owner: 10Jeroen De Dauw) [17:06:17] (03CR) 10Brion VIBBER: [C: 032] Add ability to read config parameters from a URL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125327 (owner: 10Yuvipanda) [17:06:56] (03CR) 10jenkins-bot: [V: 04-1] API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [17:08:13] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [17:08:15] (03PS4) 10Nuria: Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 [17:09:06] (03CR) 10Catrope: doc: Clean up (remove redundant @method and minor fixes) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125339 (owner: 10Krinkle) [17:10:10] (03PS1) 10Mhurd: Renamed "Wikipedia-iOS" folder to "wikipedia". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125419 [17:10:12] (03PS1) 10Mhurd: First pass at channeling web assets through GruntJS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125420 [17:10:25] (03CR) 10Catrope: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [17:11:01] (03CR) 10Brion VIBBER: [C: 032] Support hiding edit button for anon users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125332 (owner: 10Yuvipanda) [17:11:03] (03PS1) 10Marcoil: Bug 58677: Fetch list of WMF wikis dinamically from SiteMatrix API [services/parsoid] - 10https://gerrit.wikimedia.org/r/125421 [17:12:25] (03CR) 10Marcoil: "I'll add the checks to client.js in this patch too, if we want to move all of them to apiServer.js we can do it later." [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [17:12:40] (03PS2) 10EBernhardson: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 [17:13:32] (03CR) 10Csalvia: Public reports create files on disk (032 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [17:13:47] (03CR) 10Arlolra: "maybe make a helper that explicitly gets called from each of the files?" [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [17:14:09] (03PS1) 10Catrope: Fix JS error when opening VE on redirect page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125422 [17:14:30] (03CR) 10Catrope: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [17:14:45] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [17:15:50] (03PS6) 10Krinkle: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:16:01] (03CR) 10Esanders: [C: 032] Fix JS error when opening VE on redirect page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125422 (owner: 10Catrope) [17:17:06] (03PS1) 10Ottomata: pom.xml GPL-2 to Apache-2 [analytics/kraken] - 10https://gerrit.wikimedia.org/r/125423 [17:17:21] (03CR) 10Ottomata: [C: 032 V: 032] pom.xml GPL-2 to Apache-2 [analytics/kraken] - 10https://gerrit.wikimedia.org/r/125423 (owner: 10Ottomata) [17:18:30] (03Merged) 10jenkins-bot: Fix JS error when opening VE on redirect page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125422 (owner: 10Catrope) [17:19:01] (03CR) 10Csalvia: Public reports create files on disk (031 comment) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [17:19:34] (03PS1) 10Ottomata: Enabling base::firewall on stat1003 [operations/puppet] - 10https://gerrit.wikimedia.org/r/125425 [17:21:52] (03CR) 10Ottomata: [C: 032 V: 032] Enabling base::firewall on stat1003 [operations/puppet] - 10https://gerrit.wikimedia.org/r/125425 (owner: 10Ottomata) [17:22:35] (03PS1) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [17:25:33] (03CR) 10Catrope: [C: 04-1] "There's a clear missing somewhere or something, because things now render as:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [17:27:20] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:27:26] (03PS2) 10Marcoil: Add method to ensure parsoid and mock servers are killed when exiting [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 [17:28:23] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:28:25] (03CR) 10jenkins-bot: [V: 04-1] Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:30:31] (03PS3) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [17:30:58] (03PS1) 10JGonera: Fix a FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 [17:31:16] (03PS1) 10Mooeypoo: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [17:31:26] (03PS4) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [17:31:50] (03CR) 10Jforrester: "Helps to actually put a clear: into the CSS. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [17:36:27] (03CR) 10Arlolra: Add method to ensure parsoid and mock servers are killed when exiting (034 comments) [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [17:36:43] (03PS11) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [17:36:46] (03PS1) 10Catrope: Fix JS error when opening VE on redirect page [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125429 [17:36:48] (03CR) 10Krinkle: [C: 04-1] "Initial -1 for code conventions, and documentation syntax seems made up (doesn't parse in jsduck)." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:36:58] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:39:17] (03PS7) 10Ori.livneh: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 [17:39:49] (03PS3) 10Marcoil: Add method to ensure parsoid and mock servers are killed when exiting [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 [17:39:52] (03CR) 10Ori.livneh: "It's been thirty days now since I0c9edac35 has been merged, so this is good to go." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [17:40:12] (03CR) 10jenkins-bot: [V: 04-1] ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [17:40:28] (03PS8) 10Ori.livneh: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 [17:41:01] (03CR) 10Catrope: [C: 04-1] "This breaks inserting citations. It inserts the citation template *after* the reference rather than inside it: {{cite web|...}}" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [17:42:07] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:42:16] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [17:43:47] (03CR) 10Martineznovo: Avoid making a derivative request to Special:RunJobs when the job queue is empty (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124629 (owner: 10Aaron Schulz) [17:43:56] (03PS5) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [17:44:07] (03CR) 10Arlolra: [C: 032] Add method to ensure parsoid and mock servers are killed when exiting [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [17:46:01] (03CR) 10Tim Landscheidt: ""Change as is" = patch set #2." [operations/puppet] - 10https://gerrit.wikimedia.org/r/125241 (owner: 10Yuvipanda) [17:46:03] (03CR) 10jenkins-bot: [V: 04-1] ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [17:46:15] (03PS2) 10Catrope: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:46:17] (03CR) 10Jforrester: "@Nikerabbit: I think adding $1s adds unnecessary complexity." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [17:46:41] (03Merged) 10jenkins-bot: Add method to ensure parsoid and mock servers are killed when exiting [services/parsoid] - 10https://gerrit.wikimedia.org/r/125390 (owner: 10Marcoil) [17:50:17] (03PS3) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [17:51:39] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [17:51:41] (03PS2) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [17:52:06] (03CR) 10Umherirrender: "Patch Set 2: Fixed spacing, add suppressWarnings/restoreWarnings calls and addressed inline comments" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:53:10] (03CR) 10Jforrester: "@Shirayuki: Suggestions (or patches!) welcome – https://github.com/jdforrester/grunt-banana-checker etc. Things I've thought of adding inc" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [17:53:20] (03CR) 10Catrope: [C: 04-1] Small validation fixes to scalable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:54:13] (03CR) 10Catrope: "What bugs is this fixing that I can test are now fixed?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:56:36] (03CR) 10Catrope: [C: 032] Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [17:56:49] (03CR) 10Ottomata: Make Elasticsearch more reliable in beta (035 comments) [operations/puppet] - 10https://gerrit.wikimedia.org/r/125331 (owner: 10Manybubbles) [17:57:18] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:57:35] (03Merged) 10jenkins-bot: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [17:57:37] (03CR) 10Ottomata: [C: 032] "Shall I merge?" [operations/puppet] - 10https://gerrit.wikimedia.org/r/124903 (owner: 10Manybubbles) [17:57:39] (03CR) 10Nikerabbit: "It doesn't add complexity. Just moves it around. I prefer that the complexity is in the code rathar than in front of hundreds of translato" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [17:57:58] (03CR) 10Manybubbles: "Sure!" [operations/puppet] - 10https://gerrit.wikimedia.org/r/124903 (owner: 10Manybubbles) [17:58:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Nothing seems to explode once derived data is cleared :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125419 (owner: 10Mhurd) [17:58:40] (03CR) 10Jforrester: "It binds complexity into the code rather than leaving it to the translators to decide." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [17:59:24] (03PS2) 10Ottomata: Elasticsearch config to better spread shards [operations/puppet] - 10https://gerrit.wikimedia.org/r/124903 (owner: 10Manybubbles) [17:59:31] (03CR) 10Ottomata: [C: 032 V: 032] Elasticsearch config to better spread shards [operations/puppet] - 10https://gerrit.wikimedia.org/r/124903 (owner: 10Manybubbles) [18:05:04] (03PS4) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [18:05:47] (03PS4) 10Ottomata: Adding logster module and using it to monitor CirrusSearch-slow.log [operations/puppet] - 10https://gerrit.wikimedia.org/r/123466 [18:05:54] (03CR) 10Ottomata: [C: 032 V: 032] Adding logster module and using it to monitor CirrusSearch-slow.log [operations/puppet] - 10https://gerrit.wikimedia.org/r/123466 (owner: 10Ottomata) [18:06:21] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [18:06:58] (03PS5) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [18:07:15] (03PS1) 10Krinkle: grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 [18:07:40] (03CR) 10Krinkle: [C: 032] grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 (owner: 10Krinkle) [18:07:43] (03PS2) 10Krinkle: grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 [18:07:46] (03CR) 10Krinkle: [C: 032] grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 (owner: 10Krinkle) [18:07:49] (03Merged) 10jenkins-bot: grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 (owner: 10Krinkle) [18:08:17] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [18:09:26] (03PS9) 10Krinkle: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [18:10:23] (03PS1) 10Catrope: Update VE core submodule to master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 [18:11:45] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [18:12:20] (03CR) 10Krinkle: Add jquery.accessKeyLabel javascript module (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:14:04] (03PS1) 10Krinkle: grunt: Update include paths [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125432 [18:14:12] (03CR) 10Krinkle: [C: 032] grunt: Update include paths [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125432 (owner: 10Krinkle) [18:14:15] (03Merged) 10jenkins-bot: grunt: Update include paths [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125432 (owner: 10Krinkle) [18:14:44] (03PS10) 10BryanDavis: [WIP] Configure scap master and clients in beta [operations/puppet] - 10https://gerrit.wikimedia.org/r/123674 [18:14:50] (03PS2) 10Trevor Parscal: Remove remaining uses of surfaceModel#getSelection in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [18:15:05] (03CR) 10MarkAHershberger: "@krinkle, I don't expect you to write it, but since you have more experience in this area, could you point to an example of this so that " [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [18:15:15] (03PS10) 10Krinkle: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [18:15:47] (03PS1) 10Ssmith: Fix form layout and switch position of expiration date and cvv. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125433 [18:16:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] "does not appear to explode. \o/" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125420 (owner: 10Mhurd) [18:17:17] (03PS3) 10Bsitu: Add rev_type to lastRevCache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 [18:17:24] (03PS2) 10Brion VIBBER: Work in progress: fallback-friendly MWLocalizedString to replcae NSLocalizedString [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 [18:17:51] (03CR) 10Krinkle: "This is basic event handling and DOM manipulation (event.preventDefault(), event.stopPropagation(), and inputElement.disabled = true. Any " [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [18:19:13] (03PS2) 10Krinkle: Update VE core submodule to latest master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [18:19:25] (03CR) 10Mhurd: [C: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 (owner: 10Brion VIBBER) [18:19:55] (03PS6) 10Krinkle: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [18:20:39] (03PS4) 10Krinkle: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 [18:20:48] (03PS5) 10Krinkle: IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:20:58] (03PS6) 10Krinkle: IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:22:32] (03PS3) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [18:23:21] (03CR) 10Umherirrender: "Patch Set 3: Addressed inline comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:24:12] (03CR) 10Aaron Schulz: [C: 04-1] API: Make more continuations unique (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [18:25:05] (03CR) 10Aaron Schulz: [C: 032] API: Make more continuations unique (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [18:26:39] (03PS2) 10Ori.livneh: Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 (owner: 10Aaron Schulz) [18:26:46] (03CR) 10Ori.livneh: [C: 032] Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 (owner: 10Aaron Schulz) [18:27:00] (03Merged) 10jenkins-bot: Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 (owner: 10Aaron Schulz) [18:28:08] (03CR) 10Tobias Gritschacher: [C: 04-1] Fix formatting dates in most languages (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [18:29:19] (03Merged) 10jenkins-bot: API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [18:30:26] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [18:30:38] (03CR) 10Aaron Schulz: [C: 04-1] "Needs rebase as well :)" [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [18:31:27] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:32:57] (03PS7) 10Krinkle: IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:34:17] (03PS3) 10Brion VIBBER: Fallback-friendly MWLocalizedString to replace NSLocalizedString [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 [18:37:09] (03PS12) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [18:37:13] (03CR) 10Mhurd: [C: 031] "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 (owner: 10Brion VIBBER) [18:37:16] (03CR) 10EBernhardson: [C: 032] "No new code, straight vendor import." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 (owner: 10EBernhardson) [18:37:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok let's merge this baby" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 (owner: 10Brion VIBBER) [18:37:53] (03Merged) 10jenkins-bot: Include LightnCandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 (owner: 10EBernhardson) [18:40:44] (03CR) 10Catrope: [C: 032] Remove remaining uses of surfaceModel#getSelection in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [18:40:59] (03PS1) 10Krinkle: qunit: Remove race condition in 'test.mediawiki.qunit.testrunner' [core] - 10https://gerrit.wikimedia.org/r/125434 [18:41:09] (03PS1) 10Aaron Schulz: Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 [18:41:24] (03CR) 10Bartosz Dziewoński: "I've read the entire wikitech-l thread (89 emails as of writing) and pondered this carefully. My summary of the situation is:" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:41:37] (03CR) 10Umherirrender: "jenkins failure is bug 63579" [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:41:49] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] Revert font stack to be just sans-serif [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:42:06] (03PS13) 10Krinkle: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [18:42:34] (03CR) 10Krinkle: "Excuse the build failures. QUnit testing is under maintenance and not going as planned." [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [18:43:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [18:43:16] (03Merged) 10jenkins-bot: Remove remaining uses of surfaceModel#getSelection in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [18:45:29] (03PS2) 10Arlolra: Fix template nesting when end unreachable [services/parsoid] - 10https://gerrit.wikimedia.org/r/125413 [18:45:46] (03PS1) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [18:46:04] (03PS2) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [18:46:24] (03CR) 10Gergő Tisza: [C: 032] Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 (owner: 10Pginer) [18:49:49] (03CR) 10Swalling: "Bartosz: thanks for the considered, factual take on the matter. I appreciate you taking the time to read up on everything." [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:50:06] (03Merged) 10jenkins-bot: Spacing adjustment for repository link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125407 (owner: 10Pginer) [18:50:55] (03PS7) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [18:51:22] (03PS3) 10Arlolra: Fix template nesting where end was unreachable [services/parsoid] - 10https://gerrit.wikimedia.org/r/125413 [18:52:35] (03CR) 10MarkTraceur: "I cannot reproduce this issue...what kind of link is causing the problem?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [18:53:31] (03PS1) 10Krinkle: Lower defaut timeout from 360 minutes to 30 minutes [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 [18:58:32] (03CR) 10SG: [C: 032] Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 (owner: 10EBernhardson) [18:58:56] (03Merged) 10jenkins-bot: Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 (owner: 10EBernhardson) [19:00:52] (03PS1) 10Catrope: Followup b2296bdd2: the property is called requiresRange, not requiresFocus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125439 [19:00:56] (03PS4) 10Arlolra: Fix template nesting where end was unreachable [services/parsoid] - 10https://gerrit.wikimedia.org/r/125413 [19:04:27] (03CR) 10Eloquence: "The commit message is still inaccurate, since the changeset only touches the body fonts (which were sans serif fonts, just explicitly spec" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [19:05:41] (03PS1) 10Catrope: Followup 7e39f497: call parent method in DialogTool so disabling works [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125440 [19:06:07] (03CR) 10Jforrester: [C: 032] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:06:15] (03CR) 10Esanders: [C: 032] Followup b2296bdd2: the property is called requiresRange, not requiresFocus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125439 (owner: 10Catrope) [19:06:52] (03PS1) 10Jforrester: Update VE core submodule to master (1064150) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125441 [19:06:54] (03CR) 10Esanders: [C: 032] Followup 7e39f497: call parent method in DialogTool so disabling works [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125440 (owner: 10Catrope) [19:08:21] (03Merged) 10jenkins-bot: Followup 7e39f497: call parent method in DialogTool so disabling works [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125440 (owner: 10Catrope) [19:08:32] (03Merged) 10jenkins-bot: Followup b2296bdd2: the property is called requiresRange, not requiresFocus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125439 (owner: 10Catrope) [19:09:36] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:09:44] (03CR) 10Jforrester: [C: 032] Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [19:10:32] (03CR) 10BryanDavis: "A couple of trivial comments inline. I'm looking forward to seeing the next steps for this." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [19:10:36] (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-qunit'" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:10:41] (03CR) 10Krinkle: "Pushed 'analytics-kraken'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:11:09] (03CR) 10Subramanya Sastry: [C: 032] "This is quite the edge case scenario ... template start is a text node and is found in a table node in fosterable position and where the p" [services/parsoid] - 10https://gerrit.wikimedia.org/r/125413 (owner: 10Arlolra) [19:11:12] (03Merged) 10jenkins-bot: Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [19:11:20] (03Merged) 10jenkins-bot: Lower defaut timeout from 360 minutes to 30 minutes [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:11:40] (03PS11) 10Catrope: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [19:12:00] (03PS2) 10Krinkle: (DRAFT) Hotfix: grunt-lib-phantomjs Date mockery protection [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125039 [19:12:02] (03PS1) 10Esanders: Fix styling of list tool group label when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/125444 [19:12:05] (03Abandoned) 10Krinkle: (DRAFT) Hotfix: grunt-lib-phantomjs Date mockery protection [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125039 (owner: 10Krinkle) [19:13:08] (03CR) 10Hashar: "The beta jobs are updated as well, I dont think any of them ever hit 30 minutes." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:13:38] (03PS1) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/125445 [19:13:45] (03CR) 10Jforrester: [C: 032] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:14:20] (03PS1) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/125446 [19:14:30] (03CR) 10Hashar: "Oh and to have Jenkins Job Builder to run in parallel you can give a try at https://review.openstack.org/#/c/75514/ Then use --threads=0" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:14:44] (03Merged) 10jenkins-bot: Fix template nesting where end was unreachable [services/parsoid] - 10https://gerrit.wikimedia.org/r/125413 (owner: 10Arlolra) [19:14:54] (03CR) 10Catrope: [C: 032] Fix styling of list tool group label when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/125444 (owner: 10Esanders) [19:15:01] (03PS1) 10Bartosz Dziewoński: Revert font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 [19:15:04] (03PS1) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/125448 [19:15:56] (03PS9) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:16:44] (03CR) 10Bartosz Dziewoński: "Per Greg and Steven, we probably want to backport this change "one branch back" and then let it roll out with the deployment train." [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [19:18:00] (03Merged) 10jenkins-bot: Fix styling of list tool group label when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/125444 (owner: 10Esanders) [19:18:37] (03CR) 10Hashar: "> The commit message is still inaccurate, since the changeset only touches the body fonts (which were sans serif fonts, just explicitly sp" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [19:18:57] (03PS3) 10EBernhardson: Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 [19:19:10] (03CR) 10jenkins-bot: [V: 04-1] QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [19:19:32] (03PS1) 10Catrope: Also set requiresRange for CitationDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 [19:20:16] (03PS2) 10Swalling: Revert body font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [19:20:20] (03Merged) 10jenkins-bot: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:21:42] (03CR) 10Gergő Tisza: [C: 04-1] Load oojs-ui on demand when "use this file" is clicked (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125400 (owner: 10Gilles) [19:21:44] (03CR) 10Jforrester: [C: 032] IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [19:21:46] (03CR) 10Bartosz Dziewoński: "This only touches the body text (it's now "sans-serif"); heading text is still using the serif fonts after this change. I didn't want to m" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [19:22:11] (03PS22) 10Csalvia: Add support for coalesced recurrent reports [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 [19:22:25] (03PS2) 10Milimetric: Final UI for public recurrent [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125418 [19:23:28] (03PS23) 10Csalvia: Add support for coalesced recurrent reports [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 [19:24:19] (03CR) 10Esanders: [C: 032] "Statistically we should probably default requiresRange to true." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 (owner: 10Catrope) [19:24:26] (03CR) 10Krinkle: "Shouldn't this go into includes/ somewhere?" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [19:24:43] (03CR) 10jenkins-bot: [V: 04-1] Add support for coalesced recurrent reports [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [19:25:25] (03PS24) 10Csalvia: Add support for coalesced recurrent reports [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 [19:26:18] (03CR) 10jenkins-bot: [V: 04-1] Also set requiresRange for CitationDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 (owner: 10Catrope) [19:26:34] (03Merged) 10jenkins-bot: Also set requiresRange for CitationDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 (owner: 10Catrope) [19:27:18] (03CR) 10Milimetric: [C: 032] Add support for coalesced recurrent reports [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/122638 (owner: 10Csalvia) [19:27:27] (03PS5) 10Milimetric: Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [19:27:38] (03CR) 10Gergő Tisza: [C: 04-1] Load moment.js on demand (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles) [19:28:10] (03Merged) 10jenkins-bot: IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [19:29:01] (03CR) 10Tobias Gritschacher: [C: 04-1] Reuse Entity info array whenever possible in Entity formatters (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [19:29:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 (owner: 10Krinkle) [19:29:47] (03CR) 10Umherirrender: "By the way: The current way does not respect aliases or localised version of NAMESPACE. It is also valid to wrote {{ NAMESPACE }} or to us" [core] - 10https://gerrit.wikimedia.org/r/124784 (owner: 10Brian Wolff) [19:30:38] (03CR) 10Aaron Schulz: [C: 04-1] Improve UDP logging code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex) [19:32:06] (03PS10) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:33:08] (03PS3) 10Jforrester: Update VE core submodule to latest master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [19:33:57] (03PS11) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:34:39] (03PS12) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:35:12] (03Abandoned) 10Jackmcbarn: Allow transcluding Special:Gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 (owner: 10Jackmcbarn) [19:35:27] (03PS1) 10Brion VIBBER: Update paths in Wikipedia-iOS; a directory got renamed [translatewiki] - 10https://gerrit.wikimedia.org/r/125451 [19:35:55] (03PS3) 10Anomie: API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 [19:36:10] (03CR) 10Anomie: "PS3: Rebase" [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [19:38:03] (03PS3) 10EBernhardson: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 [19:38:08] (03CR) 10jenkins-bot: [V: 04-1] Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 (owner: 10EBernhardson) [19:39:10] (03PS4) 10EBernhardson: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 [19:39:37] (03PS3) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [19:39:46] (03PS4) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [19:41:02] (03PS5) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [19:42:18] (03CR) 10IAlex: Improve UDP logging code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex) [19:42:50] (03CR) 10SG: [C: 032] Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 (owner: 10EBernhardson) [19:43:06] (03Merged) 10jenkins-bot: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 (owner: 10EBernhardson) [19:43:13] (03CR) 10jenkins-bot: [V: 04-1] API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [19:46:49] (03PS13) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:47:15] (03CR) 10Spage: [C: 04-1] "Basically OK, vform is a bit of a rat's nest. It's trying to support lots of core forms but in fact few have been converted to it (just lo" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/124383 (owner: 10Wctaiwan) [19:50:35] (03CR) 10BryanDavis: "> Shouldn't this go into includes/ somewhere?" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [19:50:44] (03CR) 10Jforrester: "Why on Earth is this attempt at documentation not just using the existing https://doc.wikimedia.org/ system?" [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [19:54:36] (03CR) 10Milimetric: Public reports create files on disk (037 comments) [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [19:55:08] (03CR) 10Swalling: "KSS is for generating a living style guide, with button examples and much more design-oriented documentation. Can doc.wikimedia.org do tha" [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [19:56:20] (03CR) 10Jforrester: "https://doc.wikimedia.org/ can take arbitrary HTML and JS in each of the sub-directories." [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [19:58:28] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125492 (owner: 10L10n-bot) [19:59:00] (03PS2) 10Jdlrobson: Fix a stylesheet FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 (owner: 10JGonera) [19:59:13] (03CR) 10Jdlrobson: [C: 032] "I renamed patchset to be more descriptive." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 (owner: 10JGonera) [19:59:21] (03PS1) 10Ottomata: Now importing webrequest_bits into Hadoop [analytics/kraken] - 10https://gerrit.wikimedia.org/r/125498 [19:59:44] (03CR) 10Ottomata: [C: 032 V: 032] Now importing webrequest_bits into Hadoop [analytics/kraken] - 10https://gerrit.wikimedia.org/r/125498 (owner: 10Ottomata) [19:59:59] (03PS1) 10Jdlrobson: Story 1538: History page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 [20:00:10] (03Merged) 10jenkins-bot: Fix a stylesheet FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 (owner: 10JGonera) [20:00:42] (03PS1) 10Ottomata: Updating kraken to latest [analytics/kraken/deploy] - 10https://gerrit.wikimedia.org/r/125500 [20:00:53] (03CR) 10Ottomata: [C: 032 V: 032] Updating kraken to latest [analytics/kraken/deploy] - 10https://gerrit.wikimedia.org/r/125500 (owner: 10Ottomata) [20:03:03] (03PS18) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [20:09:26] (03CR) 10Mwalker: [C: 032] Fix form layout and switch position of expiration date and cvv. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125433 (owner: 10Ssmith) [20:11:20] (03CR) 10Swalling: [C: 031] "Backport is fine with me though not required. Otherwise this won't go out until the 24th." [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [20:12:41] (03PS1) 10Mpaa: listpages.py: add unicode support and fix page.title [pywikibot/core] - 10https://gerrit.wikimedia.org/r/125501 [20:13:54] (03PS1) 10Mhurd: Edit preview html is now styled correctly. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 [20:14:02] (03CR) 10Adamw: "Finished reviewing, it looks great! I'll review again when it's out of WIP." (037 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [20:16:07] (03PS19) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [20:16:23] (03PS10) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [20:17:10] (03CR) 10Brion VIBBER: Edit preview html is now styled correctly. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd) [20:17:39] (03CR) 10Adamw: [C: 04-1] Participation on create account via campaign url (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG) [20:17:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [20:19:25] (03CR) 10Mhurd: "Replied to comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd) [20:25:08] (03CR) 10Bartosz Dziewoński: "1.23wmf18 has only left production on 27 March, so we might want to wait a few days more." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [20:25:38] (03PS20) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [20:26:15] (03PS5) 10Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 [20:26:22] (03CR) 10jenkins-bot: [V: 04-1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 (owner: 10Adamw) [20:27:56] (03CR) 10Bartosz Dziewoński: [C: 032] qunit: Remove race condition in 'test.mediawiki.qunit.testrunner' [core] - 10https://gerrit.wikimedia.org/r/125434 (owner: 10Krinkle) [20:31:16] (03Merged) 10jenkins-bot: qunit: Remove race condition in 'test.mediawiki.qunit.testrunner' [core] - 10https://gerrit.wikimedia.org/r/125434 (owner: 10Krinkle) [20:31:29] (03PS1) 10Mhurd: Exclude gruntJS www files from build. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125503 [20:33:06] (03CR) 10Odder: "See https://gerrit.wikimedia.org/r/#/c/124475/ as a follow-up to the patch mention in commit message." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 (owner: 10Thiemo Mättig (WMDE)) [20:34:40] (03CR) 10Brion VIBBER: [C: 032 V: 032] "yay! fixes the accidental bloated output size :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125503 (owner: 10Mhurd) [20:34:54] (03CR) 10Bartosz Dziewoński: ChangeEmail special page rewritten to use vforms. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [20:34:56] (03PS2) 10Brion VIBBER: Edit preview html is now styled correctly. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd) [20:36:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] Edit preview html is now styled correctly. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd) [20:36:48] (03CR) 10Bartosz Dziewoński: "zzz…" [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [20:38:07] (03PS1) 10Milimetric: Make get_json_result available more widely [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125504 [20:39:02] (03PS6) 10Csalvia: Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [20:39:09] (03CR) 10jenkins-bot: [V: 04-1] Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [20:42:05] (03CR) 10Aaron Schulz: [C: 031] API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [20:43:44] (03PS7) 10Csalvia: Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [20:47:28] (03PS2) 10Milimetric: Make get_json_result available more widely [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125504 [20:47:51] (03CR) 10Csalvia: [C: 031] Make get_json_result available more widely [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125504 (owner: 10Milimetric) [20:49:47] (03CR) 10Milimetric: [C: 032] Make get_json_result available more widely [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125504 (owner: 10Milimetric) [20:51:09] (03PS8) 10Milimetric: Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [20:53:36] (03PS1) 10Manybubbles: Add fetch_fields support [search/highlighter] - 10https://gerrit.wikimedia.org/r/125505 [20:55:05] (03PS13) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [20:58:06] (03CR) 10Bartosz Dziewoński: "Rebased. I'd really like to get this into 1.23, to sort of complete the cleanup." [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [21:02:26] (03PS1) 10Ottomata: Running CirrusSearch-slow.log logster job every 60 minutes [operations/puppet] - 10https://gerrit.wikimedia.org/r/125506 [21:03:09] (03CR) 10Manybubbles: [C: 032] Add fetch_fields support [search/highlighter] - 10https://gerrit.wikimedia.org/r/125505 (owner: 10Manybubbles) [21:03:12] (03CR) 10Ottomata: [C: 032 V: 032] Running CirrusSearch-slow.log logster job every 60 minutes [operations/puppet] - 10https://gerrit.wikimedia.org/r/125506 (owner: 10Ottomata) [21:04:49] (03PS1) 10Ottomata: Running CirrusSearch-log at 0 minute every hour [operations/puppet] - 10https://gerrit.wikimedia.org/r/125507 [21:05:04] (03CR) 10Ottomata: [C: 032 V: 032] Running CirrusSearch-log at 0 minute every hour [operations/puppet] - 10https://gerrit.wikimedia.org/r/125507 (owner: 10Ottomata) [21:05:39] (03PS5) 10Nemo bis: Display outdated page translations as such, without removing them [extensions/Translate] - 10https://gerrit.wikimedia.org/r/118959 [21:06:50] (03CR) 10Nemo bis: "Well, there was no reply there till now, I think this is the best solution available." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/118959 (owner: 10Nemo bis) [21:07:59] (03PS1) 10Manybubbles: [maven-release-plugin] prepare release experimental-0.0.3 [search/highlighter] - 10https://gerrit.wikimedia.org/r/125508 [21:08:01] (03PS1) 10Manybubbles: [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/125509 [21:08:22] (03CR) 10Manybubbles: [C: 032 V: 032] "Merging release commits." [search/highlighter] - 10https://gerrit.wikimedia.org/r/125508 (owner: 10Manybubbles) [21:08:34] (03CR) 10Manybubbles: [C: 032 V: 032] "Merging release commits." [search/highlighter] - 10https://gerrit.wikimedia.org/r/125509 (owner: 10Manybubbles) [21:11:07] (03CR) 10JGonera: Make .mw-ui-button height the same for all buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [21:12:26] (03PS3) 10Mooeypoo: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [21:13:01] (03PS9) 10Milimetric: Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [21:13:16] (03PS4) 10Milimetric: Support public recurrent report links [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125245 [21:13:20] (03PS4) 10Milimetric: Make private recurrent reports not possible [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125261 [21:13:23] (03PS4) 10Milimetric: Permanent option for site messages [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125265 [21:13:27] (03PS4) 10Milimetric: Messages on report screen persist [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125266 [21:13:30] (03PS3) 10Milimetric: Final UI for public recurrent [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125418 [21:14:34] (03PS1) 10Gergő Tisza: Fix icon positioning for secondary repo link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125510 [21:23:10] (03CR) 10Spage: "select control presentation notes." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124383 (owner: 10Wctaiwan) [21:26:34] (03PS7) 10JGonera: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 [21:26:36] (03PS1) 10JGonera: Fix KSS mediawiki.ui style guide (docs) [core] - 10https://gerrit.wikimedia.org/r/125511 [21:26:57] (03PS6) 10Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 [21:27:21] (03CR) 10Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 (owner: 10Adamw) [21:28:34] (03CR) 10jenkins-bot: [V: 04-1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 (owner: 10Adamw) [21:29:32] (03PS10) 10Milimetric: Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [21:30:00] (03CR) 10Milimetric: [C: 032] Public reports create files on disk [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/124829 (owner: 10Nuria) [21:30:09] (03PS5) 10Milimetric: Support public recurrent report links [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125245 [21:30:13] (03CR) 10Milimetric: [C: 032] Support public recurrent report links [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125245 (owner: 10Milimetric) [21:30:40] (03PS5) 10Milimetric: Make private recurrent reports not possible [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125261 [21:30:54] (03CR) 10Milimetric: [C: 032] Make private recurrent reports not possible [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125261 (owner: 10Milimetric) [21:31:02] (03PS5) 10Milimetric: Permanent option for site messages [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125265 [21:31:10] (03CR) 10Milimetric: [C: 032] Permanent option for site messages [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125265 (owner: 10Milimetric) [21:31:16] (03PS5) 10Milimetric: Messages on report screen persist [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125266 [21:31:22] (03CR) 10Milimetric: [C: 032 V: 032] Messages on report screen persist [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125266 (owner: 10Milimetric) [21:31:28] (03PS4) 10Milimetric: Final UI for public recurrent [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125418 [21:31:30] (03PS4) 10Manybubbles: WIP: Deploy experimental highlighter [operations/software/elasticsearch/plugins] - 10https://gerrit.wikimedia.org/r/123704 [21:33:13] (03CR) 10Ssmith: [C: 031 V: 031] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 (owner: 10Adamw) [21:33:29] (03PS7) 10Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 [21:34:30] (03PS1) 10Manybubbles: Update installation instructions [search/highlighter] - 10https://gerrit.wikimedia.org/r/125512 [21:34:44] (03CR) 10Manybubbles: [C: 032 V: 032] Update installation instructions [search/highlighter] - 10https://gerrit.wikimedia.org/r/125512 (owner: 10Manybubbles) [21:36:05] (03PS5) 10Milimetric: Final UI for public recurrent [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125418 [21:36:17] (03CR) 10Milimetric: [C: 032] Final UI for public recurrent [analytics/wikimetrics] - 10https://gerrit.wikimedia.org/r/125418 (owner: 10Milimetric) [21:42:54] (03PS1) 10Bartosz Dziewoński: PrefixSearch: Remove unnecessary wfSuppressWarnings() [core] - 10https://gerrit.wikimedia.org/r/125513 [21:43:06] (03PS1) 10Arlolra: Insert transclusion metas around siblings [services/parsoid] - 10https://gerrit.wikimedia.org/r/125514 [21:43:48] (03CR) 10Bartosz Dziewoński: "At least it *seems* unnecessary…" [core] - 10https://gerrit.wikimedia.org/r/125513 (owner: 10Bartosz Dziewoński) [21:45:37] (03CR) 10Spage: "blue outline glow when active doesn't seem desirable. It's hard to evolve Agora styling from its limited beginnings." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124383 (owner: 10Wctaiwan) [21:45:52] (03PS1) 10BryanDavis: Make logging destinations configurable [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 [21:48:00] (03CR) 10Arlolra: "This still doesn't fix arwiki:كأس_الأمم_الآسيوية_لكرة_القدم_2000: because it manages to stick an unrelated
after all the siblings, a" [services/parsoid] - 10https://gerrit.wikimedia.org/r/125514 (owner: 10Arlolra) [21:48:20] (03CR) 10JGonera: [C: 04-1] "Please make it look like in the assets:" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 (owner: 10Jdlrobson) [21:49:06] (03PS2) 10Jdlrobson: WIP: Story 1538: History page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 [21:49:23] (03CR) 10Jdlrobson: [C: 04-1] "Sorry not completely done with this. Forgot to mark it as such." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 (owner: 10Jdlrobson) [21:50:12] (03PS5) 10BryanDavis: Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [21:50:27] (03PS1) 10Katie Horn: Adding a mechanism through which we can clean and log outbound requests. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125516 [21:53:27] (03CR) 10Aaron Schulz: [C: 04-1] Improve UDP logging code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex) [21:54:05] (03CR) 10EBernhardson: [C: 032] TopKIndex.replaceInIndex has incorrect return value in callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124514 (owner: 10Bsitu) [21:54:07] (03PS2) 10Arlolra: Insert transclusion metas around siblings [services/parsoid] - 10https://gerrit.wikimedia.org/r/125514 [21:54:23] (03Merged) 10jenkins-bot: TopKIndex.replaceInIndex has incorrect return value in callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124514 (owner: 10Bsitu) [21:54:43] (03CR) 10Arlolra: "Although it does fix 24/25 of the errors on that page." [services/parsoid] - 10https://gerrit.wikimedia.org/r/125514 (owner: 10Arlolra) [21:56:03] (03PS1) 10Catrope: Make OO.ui.Element.onDOMEvent/offDOMEvent static [oojs/ui] - 10https://gerrit.wikimedia.org/r/125517 [21:56:06] (03CR) 10Jdlrobson: [C: 032] QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin) [21:57:20] (03PS3) 10Arlolra: Insert transclusion metas around siblings [services/parsoid] - 10https://gerrit.wikimedia.org/r/125514 [21:57:43] (03PS13) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [22:00:21] (03PS1) 10Aaron Schulz: Avoid site outages due to broken job queues [core] - 10https://gerrit.wikimedia.org/r/125518 [22:00:27] (03PS1) 10Dr0ptp4kt: Bump version for alpha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125519 [22:01:01] (03CR) 10Adamw: [C: 032] "Nice instrumentation!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125516 (owner: 10Katie Horn) [22:02:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [22:04:40] (03PS1) 10Thiemo Mättig (WMDE): Revert font stack to be just sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 [22:06:45] (03CR) 10Katie Horn: [C: 04-1] "Just a couple minor things. I'll wait. :)" (035 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 (owner: 10Adamw) [22:07:22] (03PS2) 10Ori.livneh: Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 (owner: 10Aaron Schulz) [22:07:27] (03CR) 10Ori.livneh: [C: 032] Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 (owner: 10Aaron Schulz) [22:08:26] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Bump version for alpha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125519 (owner: 10Dr0ptp4kt) [22:09:31] (03Merged) 10jenkins-bot: Bump version for alpha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125519 (owner: 10Dr0ptp4kt) [22:09:39] (03PS1) 10MarkAHershberger: Revert "Provide RequestContext from fixDoubleRedirects" [core] - 10https://gerrit.wikimedia.org/r/125521 [22:10:14] (03PS1) 10Mooeypoo: Fix typo in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125522 [22:10:41] (03Abandoned) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/125448 (owner: 10MarkAHershberger) [22:11:12] (03Abandoned) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/125446 (owner: 10MarkAHershberger) [22:11:45] (03Abandoned) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/125445 (owner: 10MarkAHershberger) [22:12:05] (03PS4) 10Mooeypoo: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [22:12:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 (owner: 10Thiemo Mättig (WMDE)) [22:15:15] (03CR) 10JGonera: [C: 04-1] Don't show language button after edit when no languages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 (owner: 10Jdlrobson) [22:22:13] (03CR) 10Gergő Tisza: [C: 04-1] "There is a bunch of scrolling-related code in lightboxinterface.js (and its tests) which I think is unnecessary after this." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [22:24:11] (03CR) 10Trevor Parscal: [C: 032] Make OO.ui.Element.onDOMEvent/offDOMEvent static [oojs/ui] - 10https://gerrit.wikimedia.org/r/125517 (owner: 10Catrope) [22:24:37] (03Merged) 10jenkins-bot: Make OO.ui.Element.onDOMEvent/offDOMEvent static [oojs/ui] - 10https://gerrit.wikimedia.org/r/125517 (owner: 10Catrope) [22:26:02] (03CR) 10Jdlrobson: "fixing..." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 (owner: 10Jdlrobson) [22:26:32] (03CR) 10Gergő Tisza: Restore article scroll after closing Media Viewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125383 (owner: 10Gilles) [22:26:52] (03CR) 10Jdlrobson: QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin) [22:26:56] (03CR) 10Jdlrobson: [C: 032] QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin) [22:28:14] (03CR) 10Bartosz Dziewoński: [C: 032] "So many changes :o" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 (owner: 10Thiemo Mättig (WMDE)) [22:28:31] (03Merged) 10jenkins-bot: Revert font stack to be just sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 (owner: 10Thiemo Mättig (WMDE)) [22:29:40] (03PS3) 10Jdlrobson: Don't show language button after edit when no languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 [22:29:54] (03CR) 10BryanDavis: "recheck" [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [22:32:51] (03CR) 10Jdlrobson: [C: 04-1] "Something odd going on here. Please cherry pick to master it's based off an abandoned patchset." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 (owner: 10JGonera) [22:36:50] (03PS3) 10JGonera: Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 [22:38:44] (03PS4) 10JGonera: Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 [22:39:49] (03CR) 10Telesliveca: [C: 031] Local assignment of accountcreator flag on ptwiki [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125210 (owner: 10Odder) [22:40:44] (03CR) 10Jdlrobson: [C: 032] Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 (owner: 10JGonera) [22:41:00] (03PS1) 10BryanDavis: labs_vagrant: Allow wikidev group to sudo as vagrant [operations/puppet] - 10https://gerrit.wikimedia.org/r/125523 [22:41:17] (03CR) 10MarkTraceur: [C: 032] Fix icon positioning for secondary repo link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125510 (owner: 10Gergő Tisza) [22:41:24] (03CR) 10BryanDavis: [C: 032] Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [22:41:52] (03Abandoned) 10Krinkle: [WIP] Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/108053 (owner: 10Krinkle) [22:42:51] (03PS2) 10BryanDavis: labs_vagrant: Allow wikidev group to sudo as vagrant [operations/puppet] - 10https://gerrit.wikimedia.org/r/125523 [22:43:33] (03PS1) 10Jforrester: Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 [22:50:53] (03PS8) 10Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 [22:50:55] (03CR) 10jenkins-bot: [V: 04-1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 (owner: 10Adamw) [22:51:55] (03CR) 10Jdlrobson: [C: 032] Fix KSS mediawiki.ui style guide (docs) [core] - 10https://gerrit.wikimedia.org/r/125511 (owner: 10JGonera) [22:51:57] (03PS9) 10Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 [22:52:16] (03PS2) 10Jdlrobson: QA 1807: Provide tests for full text search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 [22:52:29] (03PS6) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 [22:52:43] (03PS5) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [22:56:57] (03PS1) 10Jforrester: doc: Fix errored variadic symbol on mediawiki.action.edit addButtons [core] - 10https://gerrit.wikimedia.org/r/125525 [23:00:16] (03PS1) 10Cmcmahon: update test to pass with new locator [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125526 [23:01:17] (03CR) 10Cmcmahon: [C: 032] "self-merging for basic maintenance to keep the build green" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125526 (owner: 10Cmcmahon) [23:04:19] (03PS6) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 [23:05:21] (03PS1) 10Aaron Schulz: Wrap djvu large local copy downloads in pool counter [core] - 10https://gerrit.wikimedia.org/r/125527 [23:06:51] (03PS1) 10Aaron Schulz: Use standard "GetLocalFileCopy" pool name [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/125528 [23:07:16] (03PS1) 10Aaron Schulz: Use standard "GetLocalFileCopy" pool name [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/125529 [23:07:46] (03CR) 10Aaron Schulz: "Needs https://gerrit.wikimedia.org/r/#/c/125527/" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/125528 (owner: 10Aaron Schulz) [23:07:54] (03CR) 10Aaron Schulz: "Needs https://gerrit.wikimedia.org/r/#/c/125527/" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/125529 (owner: 10Aaron Schulz) [23:08:11] (03PS1) 10Gergő Tisza: Adjust OOjs UI TextInputWidget text style [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125530 [23:09:29] (03CR) 10Jforrester: "@Nemo: Are you saying that this patch fixed bug 63805 and should have been tagged with it? The bug was created after this was landed…" [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [23:10:04] (03PS1) 10Esanders: Prevent iframe windows from wiping parent document selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/125531 [23:10:19] (03PS1) 10Mwalker: Make sure we always create UTF-8 XML [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125532 [23:10:27] (03CR) 10jenkins-bot: [V: 04-1] Make sure we always create UTF-8 XML [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125532 (owner: 10Mwalker) [23:10:41] (03PS4) 10Krinkle: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [23:15:25] (03PS1) 10Krinkle: Update QUnit from v1.11.0 to v1.14.0 [core] - 10https://gerrit.wikimedia.org/r/125533 [23:17:03] (03CR) 10Catrope: [C: 032] Prevent iframe windows from wiping parent document selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/125531 (owner: 10Esanders) [23:17:34] (03Merged) 10jenkins-bot: Prevent iframe windows from wiping parent document selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/125531 (owner: 10Esanders) [23:18:36] (03PS2) 10Krinkle: Update QUnit from v1.11.0 to v1.14.0 [core] - 10https://gerrit.wikimedia.org/r/125533 [23:20:28] (03PS12) 10Catrope: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [23:21:21] (03CR) 10jenkins-bot: [V: 04-1] Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [23:22:47] (03PS2) 10Mwalker: Make sure we always create UTF-8 XML [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125532 [23:24:10] (03CR) 10CSteipp: "Html::element should correctly escape any attributes you pass in. If not, can you open a Security bug with details about what wasn't being" [extensions/HTMLTags] - 10https://gerrit.wikimedia.org/r/124995 (owner: 10Yaron Koren) [23:24:19] (03CR) 10Ssmith: [C: 032 V: 032] Make sure we always create UTF-8 XML [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/125532 (owner: 10Mwalker) [23:25:12] (03PS10) 10Mwalker: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/124466 (owner: 10Adamw) [23:25:50] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (d7cbc785a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 [23:26:49] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (d7cbc785a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 (owner: 10Catrope) [23:34:16] (03PS6) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [23:37:54] (03PS1) 10Catrope: Fix jsduck errors [oojs/ui] - 10https://gerrit.wikimedia.org/r/125535 [23:38:25] (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (eca1fc20e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 [23:41:24] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (eca1fc20e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 (owner: 10Catrope) [23:42:19] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (eca1fc20e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 (owner: 10Catrope) [23:44:17] (03PS4) 10Krinkle: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [23:44:20] (03PS13) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [23:44:46] (03PS7) 10JGonera: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson) [23:44:51] (03CR) 10Krinkle: "Added to jsduck index and confirmed syntax." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [23:44:57] (03CR) 10JGonera: [C: 032] Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson) [23:45:11] (03CR) 10Esanders: [C: 032] Fix jsduck errors [oojs/ui] - 10https://gerrit.wikimedia.org/r/125535 (owner: 10Catrope) [23:45:57] (03Merged) 10jenkins-bot: Fix jsduck errors [oojs/ui] - 10https://gerrit.wikimedia.org/r/125535 (owner: 10Catrope) [23:48:39] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (eca1fc20e7) [core] - 10https://gerrit.wikimedia.org/r/125536 [23:49:16] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (eca1fc20e7) [core] - 10https://gerrit.wikimedia.org/r/125536 (owner: 10Catrope) [23:49:54] (03CR) 10Ori.livneh: [C: 032] "I won't pretend to have reviewed every changed line in QUnit, but I am +2ing because: 1) things are pretty broken right now; 2) the change" [core] - 10https://gerrit.wikimedia.org/r/125533 (owner: 10Krinkle) [23:56:59] (03PS1) 10Aaron Schulz: Limit large (djvu) file downloads for thumbnails [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125537 [23:58:41] (03CR) 10jenkins-bot: [V: 04-1] WIP: Story 1538: History page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 (owner: 10Jdlrobson) [23:58:45] (03CR) 10jenkins-bot: [V: 04-1] Fix KSS mediawiki.ui style guide (docs) [core] - 10https://gerrit.wikimedia.org/r/125511 (owner: 10JGonera) [23:59:06] (03Merged) 10jenkins-bot: QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin) [23:59:22] (03Merged) 10jenkins-bot: Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 (owner: 10Aaron Schulz) [23:59:44] (03PS1) 10Catrope: Enable VisualEditor on French Wikinews [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/125538