still contains the full page title (NS + page title); the h1.firstHeading elem that we're hiding with CSS also contains the full title incl. NS and we don't want that, so we need to tweak the PHP code in BlogPageClass.php a b [22:18:26] <ashley> it [22:20:12] <ashley> as I wrote on the patchset, you'll want to move the lines $output->setHTMLTitle( $this->getTitle()->getText() ); and $output->setPageTitle( $this->getTitle()->getText() ); in BlogPage::view() a few lines below, after these lines: $output->addHTML( "\n\n" ); parent::view(); [22:20:25] <SamanthaNguyen> ashley: right, that should be enough to fix :-) just a few moments [22:21:04] <ashley> re:AFTv5 tooltip, no strong opinion from me, you're the design guru and I trust your judgement :) [22:21:42] <SamanthaNguyen> sounds good! [22:21:52] <ashley> re:MWC, I'll, uh, happily leave that to you and UltrasonicNXT :P [22:23:05] <SamanthaNguyen> OK :P [22:23:25] <SamanthaNguyen> yeah that one is a bit complex :P [22:28:20] <SamanthaNguyen> hmm looking at BlogPage and Comments reminds me of a new ticket I was going to create this week [22:28:29] <SamanthaNguyen> I'll do it after I submit this new patchset :P [22:33:26] <SamanthaNguyen> ashley: https://gerrit.wikimedia.org/r/#/c/333809/2/ [22:36:52] <ashley> if I'm reading this right, there are three newlines in where those page title related calls used to be (lines 68-70) whereas one newline (to separate the wfDebug() call from the comment on L71) would suffice; also 1) EOL whitespace on new line 120 and 2) could really do with a comment as to why we're setting the page title there, it's non-obvious since I had to test it an' all, so chances... [22:36:54] <ashley> ...are it's gonna be non-obvious to the next dev unless you add a comment explaining the situation :) [22:37:22] <ashley> oh btw, I dunno if I ever mentioned it or not, but ImageRating is now back and also enabled on social-tools [22:37:35] <SamanthaNguyen> sweet! [22:37:47] <SamanthaNguyen> also I'll try to amend the patch again, 1 sec [22:38:29] <SamanthaNguyen> Oh hey ashley, can you create a new phabricator project for ImageRating? It should probably deserve it's own tag, just like all the social tools [22:39:09] <ashley> and funnily enough, there's one bug or "bug" that you can see by simply accessing [[Special:ImageRating]] -- the thing is paginated at 5 images per page and the total amount of images is taken from the SiteStats class (SiteStats::images()), which should theoretically return the amount of uploaded images, which it kinda does; it just doesn't take things like missing images (i.e. desc page is... [22:39:11] <ashley> ...there but the actual file isn't) into account, and we have a fair amount of those on social-tools [22:39:13] <ashley> sure thing [22:40:16] <SamanthaNguyen> I found another bug as well :P [22:41:17] <SamanthaNguyen> oh wait actually I think it's just VoteNY since ImageRating has a hard dependency on that [22:43:10] <ashley> quoth from what I posted to another channel, [22:43:12] <ashley> [00:43:02] <ashley> hm, so Phabricator seems to have been upgraded or something? now how the hell do I create a new project there? I can't seem to find the link... [22:43:31] <SamanthaNguyen> Go to the stars icon and press create project ;) [22:43:45] <SamanthaNguyen> that /should/ work [22:44:26] <ashley> except I only see five items under there [22:44:52] <ashley> "Report Security Issues", "Create Task (Simple)", "Browse Source Code", "Calendar" and "Edit Favorites" [22:45:00] <SamanthaNguyen> oh, hmm [22:45:11] <SamanthaNguyen> You can go to https://phabricator.wikimedia.org/project/ and press Create project in the grey subheader [22:46:06] <ashley> yeah, figured out that https://phabricator.wikimedia.org/project/edit/form/default/ works, too :P thankfully ShoutWiki Phab is running a slightly older version of Phab ;) [22:46:39] <SamanthaNguyen> You can also add a form to your Favorites by going to https://phabricator.wikimedia.org/favorites/personal/item/configure/ (which can also be accessed through Edit Favorites), then press "+ Form", and then type Create "component" project which will provide you a shortcut [22:46:52] <SamanthaNguyen> alright :P [22:47:56] <SamanthaNguyen> ashley: https://phabricator.wikimedia.org/T156430 [22:49:12] <ashley> https://phabricator.wikimedia.org/project/manage/2461/ -- created the project [22:49:58] <SamanthaNguyen> awesome! also btw, I fixed the EOL whitespace on patchset 4 [22:55:55] <ashley> now just add a comment explaining why you're setting the title there and we can deploy the patch to social-tools and then +2 it ;-) [22:58:12] <SamanthaNguyen> done :-) [23:00:44] <SamanthaNguyen> hmm looks like the ImageRating CSS needs a little cleanup [23:06:14] <ashley> deployed https://gerrit.wikimedia.org/r/#/c/333809/5 to social-tools: http://social-tools.wmflabs.org/wiki/Blog:MiniInvite_test [23:06:26] <ashley> still need to remove the line $output->addHTML( "<h1 class=\"page-title\">{$this->getTitle()->getText()}</h1>\n" ); from BlogPageClass.php [23:07:15] <ashley> also the code comment related to page titles could slightly be improved, just gimme a moment [23:07:15] <SamanthaNguyen> oops sorry, thought I did that [23:09:49] <ashley> The page title is being set here before the Article::view() call above overrides whatever we set if we set the title above that line. <-- something like that (I mean, we're literally inside the class named "BlogPage" in an extension named "BlogPage", so it's obvious we're talking about BlogPage :p) [23:11:00] <SamanthaNguyen> I [23:11:16] <SamanthaNguyen> *I'll just copy that and format it :P [23:12:05] <SamanthaNguyen> hmm looks like that needs a comma [23:12:59] <SamanthaNguyen> done! [23:17:30] <ashley> http://social-tools.wmflabs.org/wiki/Blog:MiniInvite_test -- looks good to me :) (although I should note that you're gonna have to prepare a PS8 nevertheless -- literally a spacing issue in the aforementioned comment :P you have two spaces but you only need one (after "*" but before the "The" in "The page title")) [23:18:50] <SamanthaNguyen> fixed :P [23:45:48] <SamanthaNguyen> ashley: hey o/ apologies for leaving so abruptly, wi-fi decided to cut out randomly [23:51:38] <SamanthaNguyen> oh ashley: Can you uninstall Semantic MediaWiki? It turns out it's installed with Composer, so it needs to be removed by typing composer remove mediawiki/semantic-media-wiki [23:52:19] <SamanthaNguyen> (you see, I would do that, and although I have a PuTTY session for brickimedia saved, i trying going into vendor/composer but it looks like I can't access anything) [23:59:23] <ashley> I tried, no luck so far :/ [23:59:31] <ashley> (I haaaaaaaate composer with a burning passion)

[00:32:05] hey SamanthaNguyen \o I'm about to head to bed, it's been a long day, but if you need any help, just leave me a message somewhere; please keep up the good work with the patches, I'll try to review as many of 'em as I can in a reasonable time (but rest assured I *definitely* want us to kill those $wgSupress* globals!) [00:33:20] ashley: sounds good, night o/ same here honestly, i'm a bit tired (and yeah! I think they should be removed too :-) [21:42:38] !logs [21:42:38] Channel logs available at http://wm-bot.wmflabs.org/browser/index.php?display=%23brickimedia [21:42:47] ashley: hey, how are you? :D [21:43:39] afternoon SamanthaNguyen :) I'm fine, thanks; you? [21:44:54] just got home fairly recently, about 30-45 mins(ish) ago! looking at more of the comments you posted [21:45:27] i read them in my inbox actually, although I'm gonna take another look just so I make sure I get everything right in the next patchset :P [21:46:16] super :D also there's a new patchset by rlot that OO-ifies some of QuizGame, would appreciate if you could take a look at it :) lemme go dig up the link... [21:46:46] https://gerrit.wikimedia.org/r/#/c/334378/ [21:47:37] ah yes, thanks for reminding me about that :P I'll comment on it [21:48:43] if it looks good to you, I'll be more than happy to +2 it and push it to social-tools [21:51:26] Submitted a comment little early (meant to write another comment too for in en.json), writing that down right now [22:03:40] ashley: Done, I finished posting all my comment on Filip's patch [22:09:42] Hmm looks like you wanted to talk about the BlogPage patch for removing the global? [22:13:35] probably, yea; gimme a few mins [22:16:09] okeydokey [22:17:12] ah yes, the title funkiness stuff [22:18:21] Yep (and oh btw there's also some other things I want to talk about after this patch, which are: https://phabricator.wikimedia.org/T146524#2967450 and https://phabricator.wikimedia.org/T144144#2967891 ) [22:18:24] so right now on a page like http://social-tools.wmflabs.org/wiki/Blog:MiniInvite_test the user-facing h1 title is the one w/o the namespace, although the HTML element still contains the full page title (NS + page title); the h1.firstHeading elem that we're hiding with CSS also contains the full title incl. NS and we don't want that, so we need to tweak the PHP code in BlogPageClass.php a b [22:18:26] <ashley> it [22:20:12] <ashley> as I wrote on the patchset, you'll want to move the lines $output->setHTMLTitle( $this->getTitle()->getText() ); and $output->setPageTitle( $this->getTitle()->getText() ); in BlogPage::view() a few lines below, after these lines: $output->addHTML( "\n\n" ); parent::view(); [22:20:25] <SamanthaNguyen> ashley: right, that should be enough to fix :-) just a few moments [22:21:04] <ashley> re:AFTv5 tooltip, no strong opinion from me, you're the design guru and I trust your judgement :) [22:21:42] <SamanthaNguyen> sounds good! [22:21:52] <ashley> re:MWC, I'll, uh, happily leave that to you and UltrasonicNXT :P [22:23:05] <SamanthaNguyen> OK :P [22:23:25] <SamanthaNguyen> yeah that one is a bit complex :P [22:28:20] <SamanthaNguyen> hmm looking at BlogPage and Comments reminds me of a new ticket I was going to create this week [22:28:29] <SamanthaNguyen> I'll do it after I submit this new patchset :P [22:33:26] <SamanthaNguyen> ashley: https://gerrit.wikimedia.org/r/#/c/333809/2/ [22:36:52] <ashley> if I'm reading this right, there are three newlines in where those page title related calls used to be (lines 68-70) whereas one newline (to separate the wfDebug() call from the comment on L71) would suffice; also 1) EOL whitespace on new line 120 and 2) could really do with a comment as to why we're setting the page title there, it's non-obvious since I had to test it an' all, so chances... [22:36:54] <ashley> ...are it's gonna be non-obvious to the next dev unless you add a comment explaining the situation :) [22:37:22] <ashley> oh btw, I dunno if I ever mentioned it or not, but ImageRating is now back and also enabled on social-tools [22:37:35] <SamanthaNguyen> sweet! [22:37:47] <SamanthaNguyen> also I'll try to amend the patch again, 1 sec [22:38:29] <SamanthaNguyen> Oh hey ashley, can you create a new phabricator project for ImageRating? It should probably deserve it's own tag, just like all the social tools [22:39:09] <ashley> and funnily enough, there's one bug or "bug" that you can see by simply accessing [[Special:ImageRating]] -- the thing is paginated at 5 images per page and the total amount of images is taken from the SiteStats class (SiteStats::images()), which should theoretically return the amount of uploaded images, which it kinda does; it just doesn't take things like missing images (i.e. desc page is... [22:39:11] <ashley> ...there but the actual file isn't) into account, and we have a fair amount of those on social-tools [22:39:13] <ashley> sure thing [22:40:16] <SamanthaNguyen> I found another bug as well :P [22:41:17] <SamanthaNguyen> oh wait actually I think it's just VoteNY since ImageRating has a hard dependency on that [22:43:10] <ashley> quoth from what I posted to another channel, [22:43:12] <ashley> [00:43:02] <ashley> hm, so Phabricator seems to have been upgraded or something? now how the hell do I create a new project there? I can't seem to find the link... [22:43:31] <SamanthaNguyen> Go to the stars icon and press create project ;) [22:43:45] <SamanthaNguyen> that /should/ work [22:44:26] <ashley> except I only see five items under there [22:44:52] <ashley> "Report Security Issues", "Create Task (Simple)", "Browse Source Code", "Calendar" and "Edit Favorites" [22:45:00] <SamanthaNguyen> oh, hmm [22:45:11] <SamanthaNguyen> You can go to https://phabricator.wikimedia.org/project/ and press Create project in the grey subheader [22:46:06] <ashley> yeah, figured out that https://phabricator.wikimedia.org/project/edit/form/default/ works, too :P thankfully ShoutWiki Phab is running a slightly older version of Phab ;) [22:46:39] <SamanthaNguyen> You can also add a form to your Favorites by going to https://phabricator.wikimedia.org/favorites/personal/item/configure/ (which can also be accessed through Edit Favorites), then press "+ Form", and then type Create "component" project which will provide you a shortcut [22:46:52] <SamanthaNguyen> alright :P [22:47:56] <SamanthaNguyen> ashley: https://phabricator.wikimedia.org/T156430 [22:49:12] <ashley> https://phabricator.wikimedia.org/project/manage/2461/ -- created the project [22:49:58] <SamanthaNguyen> awesome! also btw, I fixed the EOL whitespace on patchset 4 [22:55:55] <ashley> now just add a comment explaining why you're setting the title there and we can deploy the patch to social-tools and then +2 it ;-) [22:58:12] <SamanthaNguyen> done :-) [23:00:44] <SamanthaNguyen> hmm looks like the ImageRating CSS needs a little cleanup [23:06:14] <ashley> deployed https://gerrit.wikimedia.org/r/#/c/333809/5 to social-tools: http://social-tools.wmflabs.org/wiki/Blog:MiniInvite_test [23:06:26] <ashley> still need to remove the line $output->addHTML( "<h1 class=\"page-title\">{$this->getTitle()->getText()}</h1>\n" ); from BlogPageClass.php [23:07:15] <ashley> also the code comment related to page titles could slightly be improved, just gimme a moment [23:07:15] <SamanthaNguyen> oops sorry, thought I did that [23:09:49] <ashley> The page title is being set here before the Article::view() call above overrides whatever we set if we set the title above that line. <-- something like that (I mean, we're literally inside the class named "BlogPage" in an extension named "BlogPage", so it's obvious we're talking about BlogPage :p) [23:11:00] <SamanthaNguyen> I [23:11:16] <SamanthaNguyen> *I'll just copy that and format it :P [23:12:05] <SamanthaNguyen> hmm looks like that needs a comma [23:12:59] <SamanthaNguyen> done! [23:17:30] <ashley> http://social-tools.wmflabs.org/wiki/Blog:MiniInvite_test -- looks good to me :) (although I should note that you're gonna have to prepare a PS8 nevertheless -- literally a spacing issue in the aforementioned comment :P you have two spaces but you only need one (after "*" but before the "The" in "The page title")) [23:18:50] <SamanthaNguyen> fixed :P [23:45:48] <SamanthaNguyen> ashley: hey o/ apologies for leaving so abruptly, wi-fi decided to cut out randomly [23:51:38] <SamanthaNguyen> oh ashley: Can you uninstall Semantic MediaWiki? It turns out it's installed with Composer, so it needs to be removed by typing composer remove mediawiki/semantic-media-wiki [23:52:19] <SamanthaNguyen> (you see, I would do that, and although I have a PuTTY session for brickimedia saved, i trying going into vendor/composer but it looks like I can't access anything) [23:59:23] <ashley> I tried, no luck so far :/ [23:59:31] <ashley> (I haaaaaaaate composer with a burning passion)