[02:49:34] !logs [02:49:34] Channel logs available at http://wm-bot.wmflabs.org/browser/index.php?display=%23brickimedia [09:02:35] (03CR) 10Prtksxna: "Let me know if you need help with the OOUI part of this. I'd be happy to update the documentation at places where you're struggling." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) (owner: 10SamanthaNguyen) [15:03:28] afternoon SamanthaNguyen, how goes it? :) [15:06:57] hey ashley o/ sick again but it'll over soon i think [15:07:40] how about you? :D hopefully not sick like me haha [15:08:04] sick *of* a few people IRL, but not otherwise sick :P [15:08:34] been trying to tackle https://phabricator.wikimedia.org/T143145 [15:08:48] ah okay :P [15:09:06] ah yes! i remember that ticket [15:09:11] let me fix up my patch [15:10:48] nice patches btw :D so it looks like you're just adding the CSS to each extensions? are we planning to not use shared CSS anymore? [15:14:08] https://gerrit.wikimedia.org/r/#/c/333557/2/ tada [15:19:12] OK so before we merge, I think we need to discuss the design [15:23:27] hurr [15:23:38] so turns out that Windows sucks >.> [15:24:00] test [15:24:00] I did the three-finger salute to bring up the task manager...it's still stuck at a black screen [15:24:25] Elektra are you ashley? :P [15:26:46] /whois is still your best friend, or you can just take a look at a few lines above and look at the cloak ;-] [15:27:28] oh, I see :P [15:27:31] alright :P [15:27:32] so anyway, as I was about to say before Windows decided to take a dump (and not of the database kind) on me [15:28:05] you have a good point! however, the reason why I was doing that -- I think :P -- was because a lot (if not all!) of the affected CSS files already had h1.firstHeading { display: none; } [15:28:15] which is like the CSS equivalent of $wgSupressPageTitle = true; [15:28:34] and the other two $wgSupress* globals aren't used that often [15:29:02] ah okay, i think that makes sense [15:29:12] so I figured all I need is a few changes in some ShoutWiki skins -- to remove support for those misspelled globals and to add the firstHeading class to the h1 element on the Games skin -- and then we should be good to go [15:29:27] okay, before we're ready to go, i need to point something out real quick :P [15:29:33] sure! [15:29:59] (also I still gotta do PictureGame, maybe QuizGame?, PollNY and SocialProfile...but later.) [15:30:22] the one thing I love about having multiple computers is that if and when one decides to act up, it's not the end of the world [15:30:32] although, well, it *is* the box where most of my development stuff lives, so... :P [15:31:22] heheh :P [15:32:04] let me draw something out real quick since i'm bad at explaining stuff verbally [15:32:10] should only take a few minutes [15:32:14] alright :) [15:33:08] hmm wait i need a skin where the h1 heading still shows, do you know what skin I can use? [15:34:10] just unhide it with your browser's dev tools? [15:35:36] derp, sorry i think i'm still like half-asleep :P [15:36:51] heh, no worries, even the best of us make mistakes every now and then :) especially when you live by the "commit early, commit often" mantra! [15:40:18] https://cloud.githubusercontent.com/assets/4723983/22210580/edad3b88-e14f-11e6-9745-6522ea7039b1.png [15:40:20] there we go [15:41:10] (don't mind all the github tabs I have open :P ) so why are we generating our own duplicate heading (in the black), and then hiding the first one (circled in red)? shouldn't we be keeping the one circled in red and not generating our own (circled in the black)? [15:42:49] hmm wait I could've shown a line of code [15:43:04] okay why aren't we removing this line instead? https://github.com/wikimedia/mediawiki-extensions-LinkFilter/blob/master/SpecialLinksHome.php#L177 is basically what I'm trying to ask :P [15:47:00] I wish I had a sane answer for you, but I don't :P [15:47:22] well, we should be doing that instead :P [15:53:55] patches welcome ;) [15:55:17] alright, I'll push some patches out real quick :D [16:02:22] wonderful \o/ [16:10:57] tada, patch for PictureGame -> https://gerrit.wikimedia.org/r/333669 [16:12:20] unrelatedly: https://forum.videolan.org/viewtopic.php?t=124924 -- I think it's silly to argue against that handy feature because it "breaks DVD [and BluRay] menus". DVD most certainly isn't the only medium to store videos on...not to mention it's relatively obsolete these days [16:13:43] patch looks otherwise nice but there's a syntax error on new L1785, you're missing a single quote and a semicolon from that line (they used to be on the line that you removed, old L1792) [16:15:24] ah yes, that feature would be very useful! Like the post mentions, YT already has that [16:16:24] (also thanks for pointing out :-) I added that semi-colon in but I think I forgot to save it a second time before submitting it in the first patchset; it's fixed now though) [16:17:19] super :D I'll play around with it later on & will merge; in the meanwhile, feel free to submit similar patchsets for other extensions :-) [16:17:30] gotcha! [16:19:36] hmm, it seems pretty weird how the action for creating a game form in QuizGame is called createForm (action=createForm), but in PictureGame the action is startCreate (action=startCreate) [16:19:48] this is one of those situations where you'd wish the original devs would be around -- so that it'd be possible to ask 'em about the duplicate page titles [16:20:09] yeah, no such thing as "consistency" over here :p [16:20:30] there's a ticket I'll write up and self-assign :P should be pretty easy I think [16:20:52] ah yes, it'd be very interesting to be able to talk to them [16:25:55] https://gerrit.wikimedia.org/r/#/c/333670 :D [16:26:59] lgtm :) [16:27:44] https://twitter.com/davidpean -- heh, Dave still seems to be working with sports and technology [16:28:56] https://twitter.com/awrigh01 -- and Aaron, who, I believe, originally built some of 'em (like Comments and whatnot) [16:30:28] :o that's cool! [16:30:50] i wonder what they'll think of the current state of social tools stuff if they saw them again [16:37:19] heh, indeed...such a shame they don't work with MediaWiki anymore [16:37:30] oh well, I'll be heading afk, back later \o [20:27:37] back [20:28:01] (well, gonna go grab a bite soon-ish, haven't eaten much today and it's starting to feel, ugh...) [20:28:46] sounds good [20:28:53] o/ [21:17:56] SamanthaNguyen: did you test out https://gerrit.wikimedia.org/r/#/c/333674/1/SpecialFanBoxes.css ? I think it's somewhat of a drastic change [21:18:25] Yep, it looked fine to me [21:18:51] I'll take a screenshot, can you take a screenshot as well? [21:19:06] @ ashley [21:19:50] sure, just a moment; also you didn't edit FanBoxPage.php although you'll need to do that to remove the nowadays superfluous h1 element from UserBox: pages (see line 43) [21:20:30] hmm, thought I did [21:21:16] maybe I didn't add that file into my patch, gimme 1 sec :-) [21:22:35] http://social-tools.wmflabs.org/wiki/File:SpecialUserBoxes-current.png (before) vs. http://social-tools.wmflabs.org/wiki/File:SpecialUserBoxes-proposed.png (after -- I used my browser's dev tools to toggle off the four rules that the proposed patch removes from the source CSS file) [21:23:01] Also sorry, was only looking at the heading! https://cloud.githubusercontent.com/assets/4723983/22223222/b49d8138-e17f-11e6-8854-63066d0b2b7e.png so I just realized that all of the headings in the form are h1 which is non-semantic and not-accessible, all of the form labels should be

instead [21:23:06] so I'll change that as well [21:23:54] cool :) [21:26:06] ashley: https://gerrit.wikimedia.org/r/#/c/333674/2 should be OK now [21:27:28] alright, let's test it out! [21:28:47] sure :-) 1 sec [21:31:56] http://social-tools.wmflabs.org/w/index.php?title=Special:UserBoxes&id=72 -- something isn't quite right...or maybe it's a cache thing? in any case, the "add colors" doesn't appear to be where it should be [21:32:58] right, we need to change the css block that had the clear: both; because it's descendant selector in that block was h1, which no longer applies [21:34:29] 1 sec [21:41:32] ashley: sorry, had to restart my git bash :P there should be another patchset out very soon [21:41:44] no worries :) [21:44:18] oh btw, is there a fallback for YUI if the user disables JS and is using the UserBoxes special page? [21:47:52] guess :P [21:48:04] i bet its no :P [21:48:12] yep :P [21:48:55] it should probably fall back to the native (it's not fully supported by all browsers, but it's probably better than nothing) [21:49:39] aye, feel free to ticket that; then again I'd argue that it's probably not a huge deal -- nice to have, sure, but not exactly critical; would be more critical to have navigation in Refreshed working even for the no-JS users, because skins are a bit bigger deal than an obscure extension's obscure special page ;-) [21:50:31] I was just wondering, because replacing the form stuff with OOUI requires replacing the textarea for the category stuff with capsuleMultiselectWidget which requires JS [21:50:40] sounds good (y) [21:50:44] http://social-tools.wmflabs.org/w/index.php?title=Special:UserBoxes&id=72 -- click on "add an image" and the result isn't quite what you'd expect [21:51:23] lol, its using the deprecated font element [21:51:31] thanks for pointing that out, I'll change that too [21:53:24] (should probably mention, it's always better to use classes as a descendant selector rather than an element) [22:08:08] ashley: https://gerrit.wikimedia.org/r/333674/5/ should be OK now [22:08:45] instead of adding our own CSS block for clear: both; i just used the clear class provided by mediawiki core [22:12:53] http://social-tools.wmflabs.org/w/index.php?title=Special:UserBoxes&id=72 -- I don't think it's quite working, sorry :-/ [22:14:23] oh hm [22:14:36] well, it should be...let me see [22:14:59] .clear is a class provided by mediawiki core, right? [22:15:55] i swore it was, huh [22:19:59] (don't merge yet) [22:23:30] ashley: should be okay now :) https://gerrit.wikimedia.org/r/#/c/333674 7th patchset (will get it, eventually!) [22:52:59] the core-provided class is called visualClear, can you update the patchset to use that? :) [22:53:41] ahh, okay [22:53:45] thanks :) [22:54:57] ashley: another patch is out now [22:55:44] http://social-tools.wmflabs.org/w/index.php?title=Special:UserBoxes&id=72 -- now it's looking spiffy :D [22:57:59] awesome :D [22:58:29] https://gerrit.wikimedia.org/r/#/c/333674/8/SpecialFanBoxes.php -- unnecessary backslash on L178 [22:58:42] after that, I think it should be good to go [23:00:18] ashley: done :) [23:02:17] awesome, thanks :D I'll +2 it after jerkins has V+2'd it [23:02:48] sweet :D [23:04:22] huh, for some reason i didn't submit a patch for the wgSupress in BlogPage (i did it for every other extension though besides SocialProfile - I abandoned the old one and submitting a new one for that) [23:06:37] I think I can do it for every skin except Monaco (since that's closed-source, y'know? but I have faith that you'll submit a patch for that skin and the global will shoo :P ) [23:08:18] that and a few other closed-source ones, yeah :P [23:08:33] anyway, lemme say this out loud before I forget again: [23:08:47] we should look into refactoring the tab stuff used on Special:Prefs [23:08:53] (I'll elaborate on that in a bit) [23:09:12] OK, because I'm a bit confused :P [23:12:03] ashley: https://gerrit.wikimedia.org/r/#/c/333637/1/BlogPageHooks.php what do the lines on 27 through 30 mean? [23:13:03] oh nvm, it's explained on line 22 (i'm blind :P ) [23:20:00] so there are two separate but related issues with the Special:Preferences tab code: [23:20:28] 1) the JS is hardcoded to work only on Special:Preferences and isn't reusable but users want to generate tabbed content [23:20:50] for that, we have http://www.shoutwiki.com/wiki/Help:Tabs on ShoutWiki which is essentially the core JS (well, an older version of it) refactored to be more generic [23:21:18] 2) the "default" Special:Preferences tab styles are per-skin but there really should be a core RL module for that [23:22:57] Ah right, e.g Refreshed has to provide it's own style [23:23:14] also, not that related, but an #easy task for you: clean up Truglass' resources/assets folder (skins/Truglass/truglass/); there's a lot of unused legacy crap in there [23:23:15] i remember submitting a ticket about that back when we used to use GitHub [23:23:33] sure :) i'll go ahead and do thata [23:23:36] *that [23:24:58] I'm not sure how current the preftoc CSS that Truglass has is, but it's almost literally 100 lines long, and that's a lot of stuff to copy over for each and every damn skin [23:25:20] yeah, lots of technical debt [23:26:21] are you thinking of submitting a patch to core? or do you want me to? [23:26:23] https://gerrit.wikimedia.org/r/333809 [23:26:40] (it'd probably be better if you did, but I can help refactor stuff I think? :P ) [23:27:27] @ ashley [23:28:23] yeah, eventually, though I most certainly wouldn't mind helping you out with your first core patch -- everyone's gotta start somewhere, right? :-) [23:29:00] true! :P submitting a patch to the core would actually be pretty cool [23:30:24] oh i also just noticed a typo; so in BlogPage, there's a special page called Special:ArticleLists, which is pretty weird, because it's only just one long list, it should probably be Special:ArticlesList instead (switch around the s, also makes it consistent with Special:ArticlesHome) [23:31:51] I was gonna say "I'm pretty sure there's more to that special page than meets the eye" but apparently not :P [23:32:34] nope, it looks quite simple :P [23:33:20] oh and there's also https://gerrit.wikimedia.org/r/#/c/333557/, which I fixed earlier today :-) [23:35:46] lgtm but I can't +2 (which is slightly ironic, because I'm a sorta major contributor to that extension) [23:36:41] oh that's weird, I thought you had +2 rights to the repo as well [23:38:24] oh btw ashley, have you heard of the Developer Wishlist? (I'm sure you already have, but asking just in case :P ) It seems pretty cool, although I don't happen to have any ideas to submit to the wishlist [23:39:23] yeah I have; people encouraged me to submit something, but like I said, "take a page out of Microsoft's book and consider this silly thing called 'backwards compatibility'" wouldn't be a popular request _among those who decide_ of this stuff [23:41:30] ahh I see; maybe trying won't hurt? (or I'm guessing you've already tried before, considering how long you've been working with mediawiki stuff) [23:42:46] extension/skin developers are a necessary evil and nothing else, it would appear [23:51:56] ashley: unrelated kinda, https://gerrit.wikimedia.org/r/#/c/333813/ just pushed a new patch :) [23:52:03] I'll work on that Truglass skin now [23:59:15] [13LocalSettings] 15SamanthaNguyen pushed 1 new commit to 06master: 02https://git.io/vMFCs [23:59:15] 13LocalSettings/06master 14d1c9435 15Samantha Nguyen: disable SMW per http://en.brickimedia.org/wiki/Brickipedia:Forum#Disable_SMW