[00:03:31] ashley: apologies for flooding your notifications ;-) I flooded my own notifications too: https://cloud.githubusercontent.com/assets/4723983/22178684/bcac701e-e003-11e6-8b91-0d2f3efb0fbb.png [00:03:53] (that includes email as well as on phabricator, haha :P ) [00:10:12] (03PS1) 10SamanthaNguyen: Remove empty messages; unusedredirects-text isn't meant to be ignored [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/333469 [00:12:40] (03PS2) 10SamanthaNguyen: Remove empty messages; unusedredirects-text is meant to be ignored [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/333469 [00:14:15] (03CR) 10SamanthaNguyen: [C: 032] Remove empty messages; unusedredirects-text is meant to be ignored [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/333469 (owner: 10SamanthaNguyen) [00:15:36] (03Merged) 10jenkins-bot: Remove empty messages; unusedredirects-text is meant to be ignored [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/333469 (owner: 10SamanthaNguyen) [00:36:09] no worries, I'm happy to see progress :D [00:38:25] it's somewhat late so I'm heading to bed, g'night \o [00:40:12] sounds good :) goodnight o/ [13:57:59] hey SamanthaNguyen, sup? \o [13:59:31] hey o/ i actually got on an hour ago (but you already noticed that), but I was still a little groggy at the time so I was still quiet :P Not much is happening right now, although my medicine decided to replace my runny nose with a stuffy nose :-( [14:00:13] (hopefully it goes away soon!) [14:00:19] how are you? :D [14:06:06] looking through my flooded inbox :P you've been busy! [14:07:09] haha :P I think most of them was just fixing the typos in the alias files [14:08:37] (fun fact: $aliases wasn't a typo at some point. I don't care too much about translated special page names which is why I don't bother on explicitly testing out if they work or not >.>) [14:09:49] :o that's an interesting fact [14:13:23] oh btw, based on your patch and the OOUI docs, I don't think https://phabricator.wikimedia.org/T145310 should be too hard hopefully, so I'm thinking of claiming the task and working on it [14:13:42] awesome :D [14:14:57] oh and you might've missed https://phabricator.wikimedia.org/T155911 while looking through your inbox (since I'm usually busy on phab :P), any thoughts on it? [14:15:41] I haven't, will post something on the ticket soon :) [14:18:11] * SamanthaNguyen gives a thumbs up [14:23:44] just saw your comment :) I'll reply to it later (it was more of a random thought really) [14:30:54] i wish i had a bigger screen for my code editor lol [14:32:01] https://phabricator.wikimedia.org/T155914 [14:32:08] now let's wait for shit to hit the fan once again >.> [14:34:35] sorry :-( I just thought it'd at least be okay to have a ticket for it [14:36:32] not your fault [14:37:21] the problem IMO is that TWN is a monopoly that's above any and all oversight since it's not officially a WMF project or anything; as such, they're free to treat developers as they like and the majority of developers don't care to question their decisions [14:38:10] I don't understand what so-called support they need to provide besides the platform (translatewiki.net), yet this vague and mysterious support is the reason why they refuse to add things that don't have complete qqq.json files [14:41:12] there are, of course, some i18n-related things which are obviously wrong, but overall I think that the developers should be in charge of things, not TWN staff; TWN staff provides the platform and automatically exports translations from there to the source code repo and that's it (in my view, that is) [14:47:36] (wait, I actually thought it was officially a WMF project? didn't know that) it does seem silly to require qqq.json though [14:49:22] nope, it's a separate project that started out as "Betawiki" and it has close ties to the WMF (given that plenty of current TWN staff work or have worked for the WMF), but it's not an official WMF project the way, say, MediaWiki.org or the English Wikipedia is [14:52:18] ah, okay [14:52:32] that explains why it requires a separate account, always wondered about that [14:53:53] with OAuth and stuff being a thing, one day it might be that it can use federated login ("Log in with your WMF account") instead [14:54:18] yeah, maybe [14:55:00] also unrelated question but: do you know why the alias and namespace files require to be in PHP and not in JSON format? [14:55:55] I'm not sure about the specifics, but in the past i18n strings, too, were in PHP; they were switched over to JSON because of performance reasons [14:55:55] it sounds like leftover technical debt I think, it looks like they were the leftovers of a mass migration to json i18n conversion (I'm guessing there was something blocking it from being converted?) [14:59:02] hmm I thought there was a more interesting story behind it, but that makes sense too :P [15:02:58] Hmm, for some reason I feel like there's a core message that says "cancel" [15:03:25] i mean, it's such a common word especially for interfaces, so there must be! :P let me look... [15:08:08] https://github.com/wikimedia/mediawiki/blob/master/languages/i18n/en.json#L144 :D [15:19:46] ashley: Hmm, so I want to log the block action in MWC, should that be done in a different patch or with the patch for the block dialog? [15:20:14] log into a log in Special:Log? do it in the same patch, that makes sense IMO [15:20:57] Yeah; alright, will do [15:21:50] mm https://gerrit.wikimedia.org/r/#/c/327931/ reminds me of some tickets I need to create [15:22:04] i need to remind myself to create them today :P [15:26:55] doc.wikimedia.org is so much more helpful than mediawiki.org [15:37:11] hehe [15:37:50] SamanthaNguyen: oh btw, a CSS(-ish?) bug I was wondering if you'd be able to take a look at & fix: http://social-tools.wmflabs.org/wiki/Special:AdminPoll [15:39:09] (03PS1) 10SamanthaNguyen: [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) [15:39:14] sure :) [15:39:20] cheers :D [15:40:53] lol I don't even need you to tell me what's wrong [15:42:35] yea, it's painfully obvious :p [15:43:27] whoo, I merged almost all of the UNIX_TIMESTAMP-related patches of mine and didn't break anything, it would appear :D [15:43:45] yep, just saw those patches in #wikimedia-dev :D [15:44:22] this doesn't mean that all social tools are UNIX_TIMESTAMP-free, but...progress is still progress! [15:45:02] https://phabricator.wikimedia.org/T155932 [15:45:03] kinda stupid that SQLite doesn't have that function tho [15:45:31] yay tickets :D [15:45:36] Looks like its because of floats and absolute positioning, should be easy to fix by making them display as blocks and inline-blocks [15:46:19] yea, I guess the CSS was originally written for http://social-tools.wmflabs.org/wiki/Special:ViewPoll and the admin page was added later or something? [15:47:21] probably! the poll result layout page seems kinda bleh but that's for another ticket :-) [15:48:27] *poll list layout page for both [15:48:57] Hmm, I wonder if I could mix a HTMLForm within a prompt dialog [15:52:20] maybe? I know Isarra did some awful things with HTMLForm + EditPage for CollaborationKit [15:52:31] also, unrelatedly, I submitted a request for ImageRating repo creation: https://www.mediawiki.org/wiki/Git/New_repositories/Requests [15:53:20] (only one way to find out, right? :-) I'll play around with it) [15:53:28] awesome :D hope it gets accepted soon [15:53:42] also repo histories are always definitely nice [15:54:59] (03CR) 10SamanthaNguyen: [C: 04-2] "This is a WIP, so anyone who wants to review this yet, please don't until I remove the tag :)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) (owner: 10SamanthaNguyen) [15:58:22] yeah, it's just that a lot of repo history is hidden behind a lock and a key, so to speak, for obvious reasons; but at least the ArmchairGM codebase is fully free and open these days and it's available on two sites (GitHub & WMF Phab), so it probably can't get lost very easily :-) [15:59:07] (it was actually almost lost *again* when Wikia migrated from wikia-code.com -- their own, self-hosted SVN server -- to GitHub some years ago; luckily I managed to pull a copy of the AGM codebase from an old & failing hard drive and upload it on GitHub) [16:01:54] :o very lucky! [16:05:49] psst, can you explain to me how you were able to make Special:RegexBlock get the reasons from MediaWiki:Ipbreason-dropdown? I want to do that with MWC prompt dialog also [16:06:39] well except with our own custom dropdown [16:08:44] well RegexBlock('s UI) these days is largely copypasta from Special:Block :P [16:10:08] Mm yeah I was looking at https://github.com/wikimedia/mediawiki-extensions-RegexBlock/commit/5653590010c620e778645a5e01412ec77a7ea78e, I thought you might've knew how it worked though :P [16:10:10] so SpecialRegexBlock class has the getSuggestedDurations() method (which is currently a 1:1 copy of SpecialBlock::getSuggestedDurations() -- I copied it over in case if we ever want to have RegexBlock to have a different list of reasons than Special:Block) [16:11:20] ah kk [16:14:02] does user.name get the username of a person? I want it so that the dialog shows something like "You are about to block $1", where $1 is equal to the username so it prevents less accidental blocks [16:14:35] *so there's less accidental blocks [16:20:28] mw.user.getName() (provided that your ResourceLoader module has registered a dependency on the mediawiki.user RL module) [16:21:59] ooh cool :o [16:22:01] thanks! [16:24:10] Also it looks like you can create your own form with OOUI https://www.mediawiki.org/wiki/OOjs_UI/Using_OOjs_UI_in_MediaWiki#Example [16:24:37] nice :) [16:25:00] Just need to follow https://www.mediawiki.org/wiki/OOjs_UI/PHP_examples#Adding_JavaScript_behaviors and it should work [16:27:07] I wonder if I could get anyone familar with OOjsUI to code review this patch also...I know Filip is familar with it, but more reviewers is always nice [16:31:16] once you have a patch ready for review, I can try asking MatmaRex for CR, I'd imagine he knows a thing or two about OO stuff because he's written significant chunks of it :p [16:31:35] :D awesome, thanks! [16:31:53] also just posted https://phabricator.wikimedia.org/T155936 [16:32:40] I'm not sure how I could check for that but I was hoping you could possibly guide me with that? :) (not right now ofc since I'm already working on a different patch for MWC, but a later day?) [16:34:06] I...uh, can try, but no promises, really; all I know is that MWC behaves really funkily when you have two chat sessions open at the same time [16:36:59] ah okeydokey [16:41:15] just found https://www.mediawiki.org/wiki/OOjs_UI/Windows/Process_Dialogs, this looks like the type of dialog I need, looks a bit more complicated than the other dialogs though [17:01:08] poor filip, subscribed to social-tools but then they unsubscribed later, it was probably because i was blowing up their notifications (phab and email included) :P [17:01:57] heh :p [17:07:53] ashley: do you know which extensions use the TagCloud class besides BlogPage? [17:08:07] currently renaming a ticket and need to add the appropriate project tags [17:08:29] FanBoxes (but there are some subtle differences betweeen these two classes, even if like 80-90% of the code is identical) [17:09:29] thanks, anything else? [17:10:18] doesn't look like that [17:11:14] there we go, renamed [17:11:16] [11:11:02] BlogPage, FanBoxes, Social-Tools, Technical-Debt: Convert instances of the social tools TagCloud class in FanBoxes and BlogPage to use CapsuleMultiselectWidget - https://phabricator.wikimedia.org/T146000#2959750 (SamanthaNguyen) [17:11:28] thanks btw :) [17:14:56] oh btw, do you have time to look at https://phabricator.wikimedia.org/T145980 ? I'm not sure how to move forward with it [17:31:24] (03PS2) 10SamanthaNguyen: [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) [17:31:52] I looked at it and based on a quick look through the code and the changes, I see no reason why it wouldn't work; then again I should warn you that I'm not overly familiar with MWC from a backend POV [17:32:38] (03CR) 10jerkins-bot: [V: 04-1] [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) (owner: 10SamanthaNguyen) [17:36:19] apparently a message called test must exist [17:36:46] oh lmao i accidentally added that somehow [17:37:18] (03PS3) 10SamanthaNguyen: [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) [17:37:58] hopefully adam has time to look over the textarea commit [17:38:16] (03CR) 10jerkins-bot: [V: 04-1] [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) (owner: 10SamanthaNguyen) [17:40:12] (03PS4) 10SamanthaNguyen: [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) [17:47:13] I got a database error changing an article feedback status and now I can't change the status on any [17:48:32] https://supload.com/ry9vldfwx [17:52:13] wrote a ticket - https://phabricator.wikimedia.org/T155949 [17:53:32] alright [17:53:53] maybe ashley can take a look at it [17:56:15] wrote a reply [17:57:19] I can see the problem (there should be the option to do something about the feedback, but there isn't), but there's nothing exciting in the error logs or anything -- the DB error log is basically full of OOM errors, no "real" ones [17:58:41] that sounds like it's just falling back to T152737 then [17:58:48] https://phabricator.wikimedia.org/T152737 [17:59:15] are you fine with me closing the aftv5 ticket as a duplicate? [18:02:58] Well it's certainly the same issue that causes it but the fact that one database error that I incurred yesterday prevents article feedback from ever being usable again is kinda a different issue [18:05:33] OK, I'll keep them separate [19:26:01] mmm the ooui docs are so scattered [19:30:54] self-note, there should probably be a custom input for chat block expiry along with a dropdown list too [19:43:51] (03PS5) 10SamanthaNguyen: [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) [19:46:26] (03PS6) 10SamanthaNguyen: [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) [19:50:40] (03CR) 10SamanthaNguyen: [C: 04-2] "Note: Currently it doesn't implement everything listed in the commit message, but it's everything that's planned to be implemented. Still " [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) (owner: 10SamanthaNguyen) [19:51:05] ashley: Could you get someone like MatmaRex to take a look at the patch? thank you in advance :) [20:04:50] (03CR) 10SamanthaNguyen: [C: 04-2] [WIP] v2.20.2 - open up a prompt dialog when pressing block (032 comments) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) (owner: 10SamanthaNguyen) [20:52:03] (03PS7) 10SamanthaNguyen: [WIP] v2.20.2 - open up a prompt dialog when pressing block [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333503 (https://phabricator.wikimedia.org/T145310) [21:44:07] ashley: taking a break from the block dialog, it's eating up quite a bit of time [22:05:16] !logs [22:05:16] Channel logs available at http://wm-bot.wmflabs.org/browser/index.php?display=%23brickimedia