[12:22:03] (03PS1) 10Jack Phoenix: Add special page aliases file + bump version number [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333347 [12:22:26] (03CR) 10jerkins-bot: [V: 04-1] Add special page aliases file + bump version number [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333347 (owner: 10Jack Phoenix) [12:23:18] (03PS2) 10Jack Phoenix: Add special page aliases file + bump version number [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333347 [12:26:08] (03CR) 10Jack Phoenix: [C: 032] Add special page aliases file + bump version number [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333347 (owner: 10Jack Phoenix) [12:27:20] (03Merged) 10jenkins-bot: Add special page aliases file + bump version number [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/333347 (owner: 10Jack Phoenix) [14:17:54] test [14:18:01] hey ashley :{P just woke up lol [14:18:41] well not *just*, i guess more like woke up about an hour ago but then got out of bed fairly recently :P [14:18:58] how are ya? :P [14:53:27] https://phabricator.wikimedia.org/T155894 just wrote a long ticket that's more or less a response to https://phabricator.wikimedia.org/T155884 [17:11:38] howdy SamanthaNguyen :) I was afk, just got back; found & filed a few bugs earlier on, which you've seen [17:12:05] the sidebar modules probably make(/made) sense in the original context, i.e. Games/Sports skin(s); stuff looks pretty nifty with the Games skin, but like with skin-specific stuff in general, what works for one skin doesn't necessary work for another [17:12:41] and that's why I hate sites and developers who design only for one skin with a burning passion; it's ugly, it's lazy, it's not very scalable in general [17:13:18] if you look at things like phpBB or WordPress -- both popular FOSS platforms written in PHP -- no matter how crappy their overall code might be, they have lots of "themes" available [17:17:37] Yeah, where as MediaWiki only has 67 skins ( http://mediawiki.org/wiki/Category:All_skins ), and not many of them are well made anyways [17:24:24] Just responded to the latter ticket btw, https://phabricator.wikimedia.org/T155884#2958241 [17:29:22] more like "MediaWiki has a few skins and a fuckton of Vector rip-offs" :P because srsly a lot of 'em are just that [17:29:37] because [[mw:Extension:Theme]] isn't 1) a core feature (yet!) and 2) as well-known as it should be [17:30:05] SamanthaNguyen: pretty much exactly the response I was hoping for :D [17:30:23] (I dunno, did using images there make sense even in 2007 or so? but yeah, probably doesn't make sense at all in 2017) [17:31:31] yeah, not at all :P [17:32:17] Maybe one day https://phabricator.wikimedia.org/T122924 could be resolved, but we're going to be waiting a while (my prediction, at least) [17:34:45] https://phabricator.wikimedia.org/T145310#2958260 [17:53:22] also ashley: https://phabricator.wikimedia.org/T155904 [18:02:33] I'll try to see if I can solicit some feedback from Isarra on that, but in general I'm pretty conservative on major user-facing changes, so please don't take that personally [18:06:17] ashley: sounds good :) [18:15:05] ashley: https://phabricator.wikimedia.org/T154220#2958335 [18:17:13] WORKSFORME, go ahead :) [18:17:31] awesome! [18:28:22] ashley: Are you fine with me making it read-only on gerrit as well? [18:30:40] sure, why not? I mean, it was a Brickipedia-specific ext. and there's a more maintained, more general replacement for it, so what reason could someone possibly have for using it instead of the WMF-maintained one? [18:31:25] ¯\_(ツ)_/¯ just asking just to make sure you're fine with it :P [18:31:47] https://phabricator.wikimedia.org/T154220#2958340 :D [18:45:00] Just posted https://phabricator.wikimedia.org/T155904#2958346, you might wanna show that comment too if you do decide to show it to Isarra :) [18:45:13] @ ashley [19:10:25] (03PS1) 10SamanthaNguyen: 1.2.3 - Add a note about archiving Snippet [extensions/Snippet] - 10https://gerrit.wikimedia.org/r/333361 (https://phabricator.wikimedia.org/T154220) [19:12:00] (03CR) 10SamanthaNguyen: [C: 032] 1.2.3 - Add a note about archiving Snippet [extensions/Snippet] - 10https://gerrit.wikimedia.org/r/333361 (https://phabricator.wikimedia.org/T154220) (owner: 10SamanthaNguyen) [19:13:47] (03Merged) 10jenkins-bot: 1.2.3 - Add a note about archiving Snippet [extensions/Snippet] - 10https://gerrit.wikimedia.org/r/333361 (https://phabricator.wikimedia.org/T154220) (owner: 10SamanthaNguyen) [19:39:04] ashley: https://gerrit.wikimedia.org/r/#/c/333363/ [19:39:51] SamanthaNguyen: I was gonna comment on the ticket, but tl,dr: I'm pretty sure that's not how it works [19:44:04] oops [19:44:06] (03Abandoned) 10Florianschmidtwelzow: Replace Linker::link*() usage with LinkRenderer [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/327140 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [19:44:32] see AFTv5 for an example [19:44:40] https://phabricator.wikimedia.org/diffusion/EAFF/browse/master/extension.json -- L66-68 [19:44:46] https://phabricator.wikimedia.org/diffusion/EAFF/browse/master/ArticleFeedbackv5.alias.php [19:45:24] AFTv5 defines two new special pages but there's only one alias file definition [19:46:05] Oh I see [19:46:27] I think it's because the alias file in the extensions like QuizGame have $aliases instead of $specialPageAliases [19:46:31] IMO it's fairly stupid that the lack of an alias file emits an E_NOTICE -- normally things like mistyped variable names or attempts to access an array's nonexistent index result in an E_NOTICE; those are real problems, the lack of an i18n alias file isn't [19:47:01] I thought so too and tested it out on social-tools but swapping aliases to specialPageAliases didn't seem to do anything, I think? feel free to test it out locally, though, and report back with your findings :) [19:52:00] mm why is it named QuestionGame.alias.php instead of QuizGame.alias.php? [19:53:20] @ ashley [19:53:27] that's a good question :D [19:58:57] s [19:59:05] seaside98: hey o/ [19:59:19] Hey! [20:00:56] fun news at seaside98 and ashley: Mozilla just got rebranded (or at final stage of it, I think): https://blog.mozilla.org/opendesign/arrival/ [20:03:00] Very nice designs! Do they do anything other than firefox? [20:08:27] Currently it's for the Mozilla logo itself, Firefox is just a project within Mozilla; did you see a new Firefox logo on there? I don't think I see any [20:09:59] Although AFAIK they're also going to apply the rebranding across the board [20:20:47] nice :) (and reminds me of the fact that I was asked to update Fennec translations recently and I haven't done that or even replied to the email... >.>) [20:25:32] heheh, I tend to forget to do stuff too [20:33:32] ashley: thoughts on http://en.brickimedia.org/wiki/Brickipedia:Forum#Server_move.2Fupgrade ? it was posted earlier this morning [20:33:47] well, *earlier today (b/c timezones :P ) [20:35:21] well, I think my thoughts on the matter are rather well-known and I'm not exactly overly fond of settling for the "next best thing" or so if and when we could have the best option, too [20:37:27] mm yeah not too surprised by your answer [20:38:32] Hopefully we can reach some sort of conclusion to the host-changing proposal, it currently has a net vote of 1 support [20:38:42] (7 supports - 6 opposes, and 1 neutral) [20:41:07] I guess we allow the proposer to vote on the proposal? if and when we seem to be allowing anons from a dynamic IP range to oppose based on something else than facts [20:43:01] Well actually I guess it should already be assumed that the proposal's support is counted as well so the net vote would be 2, but [[http://wikipedia.org/wiki/WP:BOLD|be bold]] :-) [20:44:32] (I was actually going to strike the vote, btw, although I didn't mention that earlier) [20:45:25] I did read the comments that were posted after mine but didn't acknowledge it if we're considering acknowledging by making an edit in response [22:53:00] ashley: Could you take a look at https://gerrit.wikimedia.org/r/#/c/332083/ for me if you have time? thanks :) [22:56:59] {{done}} [22:58:11] hmm, not sure how to fix this [22:58:34] so I just published https://gerrit.wikimedia.org/r/#/c/333458/ fairly recently [22:59:06] and it's parent commit was the one I just linked to you [23:00:19] is there a way I could fix this? (rebasing always seemed to be complicated to me as trying to do the steps just makes everything messy; although I guess downloading the former patch could work) [23:04:38] ashley: fixed :) https://gerrit.wikimedia.org/r/#/c/332083/3/ [23:06:04] +2'd, thanks :) [23:07:02] ashley: np :) there's also https://gerrit.wikimedia.org/r/#/c/333458/ (I'm going to be uploaded a series of patches for https://phabricator.wikimedia.org/T112434 btw ) [23:14:29] (03PS1) 10SamanthaNguyen: Fix typo to prevent PHP alias-notices from being thrown [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/333459 (https://phabricator.wikimedia.org/T112434) [23:14:40] awesome :) [23:15:52] (03CR) 10jerkins-bot: [V: 04-1] Fix typo to prevent PHP alias-notices from being thrown [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/333459 (https://phabricator.wikimedia.org/T112434) (owner: 10SamanthaNguyen) [23:17:57] bleh, error seems to be unrelated [23:20:44] ya, just remove jerkins and force-merge it [23:22:26] (03CR) 10SamanthaNguyen: [V: 032 C: 032] Fix typo to prevent PHP alias-notices from being thrown [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/333459 (https://phabricator.wikimedia.org/T112434) (owner: 10SamanthaNguyen) [23:23:16] done :) thanks, forgot I could do that lol [23:23:33] :D [23:26:06] unrelated: One day I'm gonna figure out how to make it so that when i type a certain keyword and press enter, It'll auto-replace with the commit-msg file [23:26:32] (I believe that's called a symlink?) I don't wanna copy paste it every time :P [23:49:54] (03PS1) 10SamanthaNguyen: Fix typo to prevent PHP alias-notices from being thrown [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/333465 (https://phabricator.wikimedia.org/T112434) [23:51:58] (03CR) 10Umherirrender: [C: 032] Fix typo to prevent PHP alias-notices from being thrown [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/333465 (https://phabricator.wikimedia.org/T112434) (owner: 10SamanthaNguyen) [23:52:56] (03Merged) 10jenkins-bot: Fix typo to prevent PHP alias-notices from being thrown [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/333465 (https://phabricator.wikimedia.org/T112434) (owner: 10SamanthaNguyen)