[01:44:56] hey ashley o/ how are ya? [01:47:43] howdy SamanthaNguyen :) filed a task (https://phabricator.wikimedia.org/T155511) earlier on and wrote a bunch of patches to improve the sucky timestamp handling in social tools. you? [01:54:00] hey! i'm alright, high school is kinda bleh though [01:54:52] i'm kinda glad at back at home at least [01:55:21] also neat :) i actually saw that earlier today! didn't have time to really comment, although i think the ticket is a good idea [01:56:48] oh yeah, did you see Filip's comment on T155324? if not, go take a look and voice your opinion on it! it was actually my idea but I wasn't 100% sure so I figured I'd ask a real designer instead :P [01:57:47] Ah I did, it was about what the comment would look like after it was deleted [01:57:58] so I do have an idea, although it requires filing a new task kinda [01:58:19] So, I'll link it here once I finish creating it :P [01:59:02] oh btw, I replied to https://gerrit.wikimedia.org/r/#/c/332417/ too [02:01:26] And another thing :P http://en.brickimedia.org/wiki/Brickipedia:Forum#Install_OATHAuth proposed by an anon [02:06:35] https://phabricator.wikimedia.org/T155602 [02:15:04] ashley: thoughts on them? :) [02:17:01] re:RevisionDelete, not sure; sounds good in theory, although in practise I'd imagine that inappropriate user names get blocked and their comments get deleted; probably can stash that ticket among other "nice to eventually have but nobody's actively working on this right now" tickets [02:17:23] Mihir said he'll work on it actually, in PM [02:18:01] OATHAuth -- good idea in theory, in practise I'm not sure if it'll actually work with Brickipedia's outdated MW (yes, I know what the doc page on MW.org says, and we all know how up-to-date the docs are :P) [02:18:16] gerrit patchset -- gimme a few minutes [02:18:51] He also mentioned he also got the code working for the ticket (so that only the parent comment is deleted and the child comments aren't), now he's just writing code for what the text will say [02:18:56] cool cool :) [02:20:09] Just realized my wording was kinda weird, I meant to say " but I think it should be removed from the document by default with JS" [02:27:04] I gotta fire up my local test instance to test out a few things, but anyway, long story short: the wgSupress* globals are originally related to the Games and Sports skins (the latter of which no longer exists as a separate skin, but rather as a theme of Games, thanks to you :D) and their design and weird design choices [02:27:24] I've later on implemented support for 'em in some other skins (Monaco, Nimbus, Quartz at least, IIRC) [02:32:34] anyway, before I address the whole page title (&subtitle) junk, can I ask you to take a look at something else? :P [02:32:57] Oh sorry, I thought you were going to elaborate which is why I didn't say anything :P [02:33:02] Sure! [02:33:32] http://social-tools.wmflabs.org/wiki/Talk:Main_Page -- if you're not ignoring anyone's comments yet, add someone to the ignore list, then refresh the page [02:33:39] and open up your DOM inspector [02:34:05] woah, there's a block icon [02:34:18] you'll notice that ignored comment containers (div.c-ignored) have style="display: none;" [02:34:22] this...is just mind-boggling [02:34:39] when you're ignoring someone's comments, it should show the "You are ignoring the author of this comment" message, surely? [02:34:42] It's actually not working for me [02:34:50] Like, it's not going away [02:34:52] It just stays there [02:35:09] oh, refresh the page, oops [02:35:23] oh for fuck's sake [02:35:25] (this should definitely be an immediate action, otherwise people will get confused, like me) [02:35:25] you're right [02:35:28] there's a bug again somewhere [02:35:36] the API request returns HTTP 500 :| [02:35:55] Nope nevermind, refreshing doesn't work [02:35:57] aww [02:37:05] okay, this isn't even funny anymore :| [02:37:21] This is a good example of where confirmation and acknowledgement comes in, because usually if messages that don't respond to a user's action makes it seem like the action isn't registered [02:37:41] (and sometimes the action isn't actually registered, but sometimes the action is registered, its just that the person is unaware of that) [02:38:22] https://material.io/guidelines/patterns/confirmation-acknowledgement.html good article [02:44:53] (also yeah, this is definitely a problem) [02:45:12] Do you want me to go ahead and write some tickets? [02:46:00] no need to, just gimme a few minutes and I should have this sorted out... [02:46:11] Sounds good [02:50:23] [04:50:19] (PS1) Jack Phoenix: Fix comment blocking [extensions/Comments] - https://gerrit.wikimedia.org/r/332719 [02:50:39] just saw it in #wikimedia-dev, but thanks :) [02:52:53] https://github.com/wikimedia/mediawiki-extensions-Comments/commits/master/api/CommentBlock.api.php [02:53:03] * ashley is not amused [02:53:20] it had literally been broken since the big rewrite, 31 December 2014 >___> [02:54:27] oh dear :( [02:54:31] that's..crazy [02:55:06] basically 2 entire years (i mean, that's basically jan 1 2015 lol), wow [02:56:08] yea... [03:00:21] well both of us be can glad though that it's fixed at least! no matter how small that fix actually was, I probably would've thought it'd take way more lines to fix it and would be super confused [03:01:03] well I guess I can say that since I'm still a beginner, but I still try to practice of course :P [03:05:19] Oh hey, so I claimed https://phabricator.wikimedia.org/T155466 yesterday.. I'm thinking it's easy and already figured out the steps on how it should go [03:05:38] # Write a query that gets the first editor of whichever page [03:05:38] # Write a query that gets all the comments by that editor in the comments section [03:05:38] # Append a specific CSS class to those comments [03:05:38] # Write CSS that styles those comments [03:05:59] I'm just not sure how to do step 1 and 2, would you be able to help with me that? :) [03:13:34] oops, sorry, kvirc crashed [03:16:23] no worries; re:your previous question, I believe I can help you out, yes; can it wait 'till tomorrow or maybe even Friday? (in the meanwhile, recommended reading: [[mw:Manual:revision table]], maybe also [[mw:Manual:page table]] as well as familiarizing yourself w/ how to do a SQL query w/ MW's DB abstraction layer) [03:17:00] sure, that's fine with me! thanks for the links, I'll read through both of them [03:32:11] https://phabricator.wikimedia.org/T155606 [03:32:29] that's just mindbogglingly stupid IMHO... [03:34:03] Wow yeah, that definitely is [03:36:33] also you probably already saw this, but mihir just submitted a patch :) https://gerrit.wikimedia.org/r/#/c/332723/ [03:38:03] I'll write a bug about how ignored comments should be removed instead of just hidden, too [03:40:27] uh? wanna elaborate a bit on that? [03:40:58] earlier when you mentioned: [03:41:05] 2017-01-18 02:34:18 you'll notice that ignored comment containers (div.c-ignored) have style="display: none;" [03:41:05] 2017-01-18 02:34:22 this...is just mind-boggling [03:41:30] They should actually be removed instead of being hidden [03:41:54] the superfluous .c-ignored divs? definitely! that's what the ticket is about :) [03:43:17] Oh, oops [03:43:29] Sorry, that was me being stupid P [03:43:40] I'll merge the ticket I just wrote and close it as a duplicate [03:48:09] re:page title (hiding) stuff, it might boil down to "technical debt" (and/or "bad design") anyway, but lemme try to explain it in any case [03:48:59] okeydokey [03:49:17] so on some social tools' pages, like the quiz creation form (http://social-tools.wmflabs.org/w/index.php?title=Special:QuizGameHome&questionGameAction=createForm) the page title is already present in the actual "page content" -- if you view that page with a skin like MonoBook or Vector that doesn't support the aforementioned wgSupress* globals, you'll notice the string "Create a quiz... [03:49:19] ...question" appears there twice, once as the actual

and again as a part of the extension-controlled page content [03:50:00] I'm not sure why the page title is hidden from pages like Special:UpdateProfile, though [03:53:19] So so far it sounds like bad design to me (in how the form is designed), but I don't think you're finished explaining it fully (or giving out more examples, in case I'm not sure if you are but I'll wait just in case? :P ) [03:54:28] Just keep the title there, and then remove "Create a quiz question" title in the special page form thats inside the grey box [03:54:31] Instead of vice versa [03:54:50] Evening Samantha! [03:55:19] good evening :) or night? is that the same thing? I guess I'm too tired to think at this time, i duno :P [03:55:38] woah, it's already 10:00 p.m, time sure passes by flast [03:55:40] *fast [03:56:01] Eh, it's night. I'm exausted myself too :P [03:56:36] Haha :P [03:56:58] I'll eventually go to sleep, mediawiki-related stuff usually keeps me up though :P [03:57:24] I feel ya. Coding is exhilerating :P [03:57:39] Whether that's good or bad for me is relative ;) [03:57:45] hehe [03:58:06] I get all my adrenaline rushes from writing code [03:59:53] ha :P coding really is great tbh [04:00:36] even debugging can be, because it's like solving a puzzle (although i'll admit, it can also give headaches :P ) [04:01:43] that's both the challenge and also the fun :) [04:02:03] Ashley, have we met? [04:02:15] sure we have [04:02:22] ashley: agreed! [04:02:43] seaside, you've seen this person many times before :P [04:02:57] I maintain the social tools, fix Brickipedia every now and then and also try to write stuff for ShoutWiki :P among many, many other things, such as translating Android apps and god knows what else [04:03:07] I can't track different usernames across sites :P [04:03:26] /whois is your new best friend ;-) [04:04:25] Oh nice [04:05:37] Any particular reason why half my brickimedia searches are failing? [04:06:18] SamanthaNguyen: I'm trying to justify the existence of those globals with something else than my hopeless nostalgy for ArmchairGM and recreating something like it in the future...and I cannot seem to do that :P [04:06:31] seaside98: what do you mean by failing? no results? error page? something else? [04:06:42] "A database query error has occurred. This may indicate a bug in the software." [04:06:48] http://en.brickimedia.org/index.php?title=Special%3ASearch&search=ashley [04:06:54] Just refresh a few times [04:08:20] http://en.brickimedia.org/wiki/Brickipedia:Proposal_to_move_Brickipedia_to_ShoutWiki#Why.3F -- "Site slowness, occasional timeouts, database errors, error 502/504 etc. are all too common and they're things that really shouldn't be happening at all. Needless to say that this is directly linked to the current server's insufficient resources." [04:08:47] (basically all recent logged DB errors are "Out of memory" ones...) [04:10:08] That's fun. You might be able to better optimize MySQL (though it's been a while since I've had to mess with sql configs) [04:10:56] Is the server truely out of memory, or just mysql? [04:23:07] Hey guys [04:23:17] This is Samantha btw sorry [04:23:42] Don't you love it when your internet goes out on your computer :) (i don't :P) [04:26:03] Ashley: just saw your comment in the log and I agree, there's no reason for them to be hidden nor for the globales to exist :P [04:26:18] * ashley [04:26:39] well, given that things like RAM etc. are finite, I wouldn't be surprised if it'd be more than just mysql that's out of memory; the server isn't the most powerful one and that's been a public secret for quite some time now [04:30:50] I'm all in favor of a new server [04:44:51] ashley: hey o/ think I'm gonna go and get sleep [04:45:17] good night SamanthaNguyen and talk to you later on :) [04:45:20] oh also, georgebarnick posted an interesting comment at https://phabricator.wikimedia.org/T145312#2944903, wanna check it out and see what you think? [04:45:51] there are arguments for and against, that's for sure [04:46:07] speak of the devil I guess? :P [04:46:13] what [04:46:14] !logs [04:46:14] Channel logs available at http://wm-bot.wmflabs.org/browser/index.php?display=%23brickimedia [04:46:22] too bad I can't really talk anymore, I need sleep [04:46:41] so you guys can discuss it if you want while I'm gone, and I'll catch up later :P o/ [04:46:55] ok [04:47:06] im just watching bitcoin rn just got home