[02:18:58] sup SamanthaNguyen? :) [02:22:44] hey! Just got home about half an hour ago [02:24:14] I'm doing pretty alright, just getting stuff ready since I have to go back to school tomorrow, and also working on rebasing some patches in AFTv5 (I also need to test out the patch for the tooltip more, since I only tested it for vector) [02:28:04] ah, nice (schools -- as in elementary through high -- started yesterday (Monday) over here, but I don't have to go back to the uni this week, so there's that :P); lemme know if you need help with the rebasing or whatever :) [02:28:57] I honestly don't really like tooltips that much, because (usually) they require magic numbers for placing, and if you want to attach a triangle for the tooltip, that requires magic numbers too - they could be calculated using calc() or JavaScript, but that just seems unnecessary (although it's already using JS anyways, so I guess it's not a big deal if I added a 2nd patchset for the magic numbers? [02:29:23] Hey that's nice! :P I will if I do - thanks for teaching me how to rebase btw :) [02:32:12] Although I mean..they could probably just be appended as a small paragraph at the bottom of the AFTv5 cards that say "Was this article helpful for you? Yes / No", similar to how the Special:CreateBlogPost form appends legal jargon like "Please note that all contributions to Social Tools Devel Wiki may be edited," etc etc [02:47:15] yeah, tooltips are kinda hard to nail down properly :-( that being said, AFTv5 is largely built with JS so I'm pretty sure assuming that the user who sees AFTv5 has JS enabled is a sane assumption to make :P [02:51:35] Agreed - I do try to avoid using absolute positioning, top/left/right/bottom props, clear prop, and floats because they just make everything more complicated, and usually you can avoid using those types of properties, but tooltips (from what I know so far!) is an exception. I'm hoping I can eventually find a solution to avoid it for tooltip, but that's been unsccessful so far [02:52:31] the difference between a real designer (you) and me :P I go for what seems to work and fixes the problem ("and that's how we ended up with this awful hack from 2009!") [02:54:09] ha :P [03:15:54] Hmm, is it possible to temporarily abandon a patch? [03:17:53] sorta, I mean you can abandon a patch and then "resurrect" it later, but that's about it [03:22:00] Alright, I think I [03:22:11] *I think I'll temp abandon one of my patches [03:31:03] bleh, I'll just delete my clone and re-clone it [03:36:17] ashley: could you review this patch? https://gerrit.wikimedia.org/r/#/c/330097/ Thanks in advance :) [04:18:02] SamanthaNguyen: at a glance it seems okay, though I think the globalcontributions msg might be used by the special page as the page title on Special:SpecialPages; there's a method you can override to change that, lemme find out what it's called [04:19:04] getDescription(), it seems [04:24:25] I just ran a grep for globalcontributions and it's showing that its not used [04:25:23] it's not *directly* used, i.e. grep finds no mentions of it, but since we're dealing with a SpecialPage, SpecialPage::getDescription() basically references that, so after your patch you'd likely see in Special:SpecialPages [04:25:51] you can change this behavior by defining a getDescription() method in the special page class and have it return $this->msg( 'globalcontribs' )->escaped() instead [04:26:41] ah, alright [04:32:19] er, I'm not sure I did this right, but I'm going to submit a 2nd patch [04:33:31] submitted [04:41:58] alright, time to sleep - I'll look at more stuff from gerrit tomorrow, night o/ [22:26:44] \o hey SamanthaNguyen, how goes it? [22:27:50] hey ashley! I'm alright, just a bit tired although I'm gonna try to do what I can today [22:28:23] how are you doing? :D [22:29:16] somewhat tired, likewise; I look forward to your patches :) [22:48:21] :) [22:50:18] Hmm I have a question - if you're defining a function and you don't specify whether or not it's public or private, is it by default public? Should you explicitly state it's visibility? [22:51:40] https://gerrit.wikimedia.org/r/330097 just published another patchset [22:59:29] http://php.net/manual/en/language.oop5.visibility.php Nvm, this is a useful doc :) Although I'm still not sure if you should explicitly state it although maybe I skipped through that part in the PHP code conventions, so I'll take another look.. [23:15:07] it's public by default; new code probably should state the visibility (although my personal preference is still for public and for that it doesn't matter if you specify it or not) [23:28:47] ah alright [23:51:59] thanks for the patch btw, +2'd it :) [23:52:27] np :) [23:59:49] http://social-tools.wmflabs.org/w/index.php?title=Main_Page&useskin=material -- am I imagining things or didn't you fix the footer issue once already?