[16:00:35] <github-bm>	 [13extensions] 15UltrasonicNXT pushed 1 new commit to 06master: 02http://git.io/vwmdzA
[16:00:36] <github-bm>	 13extensions/06master 146f15d98 15UltrasonicNXT: Update Comments
[16:32:17] <UltrasonicNXT>	 Lcawte: https://gerrit.wikimedia.org/r/#/c/185989/ :) :) :)
[17:42:21] <legoktm>	 hm
[17:42:23] <legoktm>	 tests broken?
[17:42:37] <UltrasonicNXT>	 legoktm: yeah
[17:42:45] <legoktm>	 ah, sqlite
[17:42:55] <UltrasonicNXT>	 Jack +2d manually yesterday
[17:43:02] <UltrasonicNXT>	 yeah, sqlite was being annoying
[17:43:15] <UltrasonicNXT>	 do you know how to fix it? SQL error reports are so bad
[17:43:27] <legoktm>	 https://www.mediawiki.org/wiki/Manual:Database_access#SQLite_compatibility
[17:45:40] <legoktm>	 I think that's exactly your issue :P
[17:46:21] <legoktm>	 why aren't your sql table/fields lowercase?
[17:47:32] <legoktm>	 UltrasonicNXT: also, interested in joining https://www.mediawiki.org/wiki/Project:MediaWiki_Farmers_user_group ? :)
[17:48:37] <UltrasonicNXT>	 Er Comments was taken from ArmchairGM, which was taken from Wikia.... Really old code basically
[17:48:56] <legoktm>	 oh lol, it's one of those extensions :P
[17:48:57] <UltrasonicNXT>	 this rewrite merged yesterday was some love it was needed
[17:49:00] <UltrasonicNXT>	 yeah :/
[17:49:12] <UltrasonicNXT>	 Renaming the DB fields was a lot of effort though...
[17:49:13] <UltrasonicNXT>	 :P
[17:49:18] <UltrasonicNXT>	 I might get round to it one day
[17:49:22] <Lcawte>	 legoktm: I'm looking into bringing things up to date, including that. Had a discussion with Jack about it over the weekend or something.
[17:49:40] <legoktm>	 :D
[17:50:04] <UltrasonicNXT>	 About that group - yeah, I've done a lot of work with global-ifying stuff so yeah
[17:50:07] <legoktm>	 well it's probably not worth migrating data just to rename tables to be "correct"
[17:50:14] <UltrasonicNXT>	 exactly
[17:50:17] <UltrasonicNXT>	 so I just left it
[17:50:35] <UltrasonicNXT>	 the variable names were also shocking before I started
[17:50:44] <UltrasonicNXT>	 I did the same with WikiForum
[17:50:49] <UltrasonicNXT>	 (rewrite it)
[17:52:21] <UltrasonicNXT>	 legoktm: can you see anything wrong with those SQL files though? As far as I can see, they what's layed out in that manual
[17:52:24] <Lcawte>	 legoktm: Is https://phabricator.wikimedia.org/T87240 going to have notes/minutes and / or an IRC chat?
[17:56:19] <UltrasonicNXT>	 ah I think it might be trailing commas
[17:57:00] <legoktm>	 UltrasonicNXT: it's because you have a primary key set in the table definition
[17:57:03] <legoktm>	  CommentID int(11) NOT NULL AUTO_INCREMENT PRIMARY KEY,
[17:57:12] <legoktm>	 wait no
[17:57:15] <legoktm>	 I'm reading it backwards
[17:58:25] <legoktm>	 UltrasonicNXT: I'm not fully awake yet apparently. No clue!
[18:19:47] <UltrasonicNXT>	 legoktm: ahah ok no worries :)
[18:23:20] <UltrasonicNXT>	 Thanks for merging that!
[18:58:38] <ugh>	 UltrasonicNXT: still failing :/
[18:58:54] <ugh>	 18:58:04 Function: DatabaseBase::sourceFile( /srv/ssd/jenkins-slave/workspace/mwext-Comments-testextension-zend/src/extensions/Comments/sql//comments.sql ) 18:58:04 Error: 1 near "AUTOINCREMENT": syntax error
[18:59:03] <ugh>	 also, we need to whitelist you
[18:59:23] <UltrasonicNXT>	 ugh: aww still? :( My SQL syntax checker thinks it's okay atm
[18:59:28] <UltrasonicNXT>	 for gerrit?
[19:00:48] <ugh>	 well https://integration.wikimedia.org/ci/job/mwext-Comments-testextension-zend/9/console is failing
[19:00:56] <ugh>	 have you tried just running your code through sqlite? :P
[19:01:48] <Lcawte>	 Hang on, doesn't the thing say to use AUTO_INCREMENT? Or has that already been tried?
[19:12:38] <UltrasonicNXT>	 using AUTO_INCREMENT as opposed to AUTOINCREMENT atm, if that's what you mean?
[20:51:46] <UltrasonicNXT>	 legoktm: cheers for adding the whitelist thing, just wondering, what does it mean? :p
[20:56:37] <github-bm>	 [13LocalSettings] 15UltrasonicNXT pushed 1 new commit to 06master: 02http://git.io/YAu4GA
[20:56:37] <github-bm>	 13LocalSettings/06master 14e5eb200 15UltrasonicNXT: Some GBC config
[21:05:03] <UltrasonicNXT>	 Lcawte: do you have the mysql root pass?
[21:05:18] <Lcawte>	 Yes, why do you need it?
[21:17:47] <UltrasonicNXT>	 creating a db for great ball contraption
[21:17:51] <UltrasonicNXT>	 you do it if you like
[21:17:56] <UltrasonicNXT>	 (Ajr asked in skype)
[21:34:13] <legoktm>	 UltrasonicNXT: right now jenkins only runs +1 tests (basic lint checks) when you upload a new patch, once you're whitelisted it'll run the full test suite on every patch rather than just whenever something is +2'd
[21:34:28] <UltrasonicNXT>	 ah I see!
[21:34:32] <UltrasonicNXT>	 That'll be handy!
[21:34:34] <UltrasonicNXT>	 Thanks!