[01:09:22] [13extensions] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/UoqMFw [01:09:22] 13extensions/06master 141281cd4 15George Barnick: Update extensions to REL1_23 branches [01:31:31] [13extensions] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/L9BgyQ [01:31:31] 13extensions/06master 1468a7ca4 15George Barnick: Updating extensions to REL1_24 branches [01:36:23] Lcawte|Away: http://i.imgur.com/2ycKCrt.jpg this is what happens with 1.24 [01:38:32] [13extensions] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/VViuIg [01:38:32] 13extensions/06master 14a70e99a 15George Barnick: Revert "Updating extensions to REL1_24 branches"... [01:41:08] I can't distinguish any of the errors because there are a million different ones and a million of the same ones that I don't even know what they are. If you want to redo the update and find out the problems please go ahead. [02:57:33] mmm, the 1.24 upgrade sure was "fun" at ShoutWiki, too :/ [03:40:01] ashley: did you have this same problem or not? [03:41:20] we had a bunch, but looking at the screenshot, it's probably related to /skins/common/, specifically that dir being removed in 1.24 and your skin likely attempts to load something from that dir in its ResourceLoader module definition(s) [03:59:17] oh [03:59:54] If I create a bug report for it on GitHub in Brickimedia's repo will you respond with that information for anyone who tries to debug it? [04:00:08] (ashley forgot to ping) [04:01:46] sure, go ahead -- we don't want to have Brickimedia stuck on 1.23 forever, do we now? ;) [04:10:19] [13Refreshed] 15MtMNC pushed 1 new commit to 06refreshed-beta: 02http://git.io/iTaXnw [04:10:19] 13Refreshed/06refreshed-beta 14f34ae49 15MtMNC: More search fixes... [04:38:30] ashley: https://github.com/Brickimedia/brickimedia/issues/307 [05:22:37] Also if anyone has any insight on this issue: [05:22:38] [12/18/2014 12:20:44 PM] George Barnick: Two people in the past two days have said they can't log in because it says their password is incorrect. I think we should look into this [05:24:15] An update to that, one of the users experiencing the issue has had to reset their password a second time. This is a critical issue because if a user doesn't have an email address associated with their account, they're completely locked out of their account as one user currently is. [05:24:23] And I would highly prefer we not be losing users. [05:29:44] Also GlobalCssJs isn't working anymore... [05:31:57] I'm just going to undo all my changes to extensions from today. Too many things aren't working as they should. Lcawte|Away if you and I are on at the same time tomorrow it'd be good to get these issues resolved ASAP [05:42:10] [13extensions] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/u5boZA [05:42:10] 13extensions/06master 146d67eb2 15George Barnick: Revert "Update extensions to REL1_23 branches"... [05:44:45] georgebarnick: when you tested MW 1.24 & Refreshed, which version of Refreshed did you use? master? if so, yeah, then it's obvious what's broken and how to fix it [05:45:46] ashley: Really? What's wrong with it? (I also tried refreshed-beta on 1.24 the other day and it was broken as well, which is odd because development on refreshed 3.0 took place on 1.24) [05:46:45] I just reverted that extensions update for other reasons though [05:46:54] the /skins/common/ directory is no more as of 1.24, so you can't load modules/files from that dir; this is essentially what you need to do (different skin, same fix): https://gerrit.wikimedia.org/r/#/c/176614/ [05:47:56] basically 1) decouple the loading of /skins/common/common*.css files from your skin's main CSS module, and instead 2) load the appropriate mediawiki.skinning.* RL module in your skin class' setupSkinUserCss() [05:48:50] Will changing that on master keep support for 1.23? Or will I need to make a new branch? [05:48:57] ('mediawiki.skinning.content.externallinks' is an unrelated but handy RL module for loading standard, MonoBook-esque external link icons; useful for most somewhat normal skins which do not implement their own ext. link icons; requires one element to have the "mw-body" class) [05:49:06] no, this breaks 1.23 support [05:49:21] (also would be awesome if you could submit the patch because idk what the heck I'm doing) [05:49:51] I don't understand RL and never have and probably never will [05:51:33] it's annoying, pesky and sometimes outright awful, but it's not *that* complicated once you get the hang of it; but the first couple times you try to use (and/or understand) it...yeah [05:54:57] yeah and given I've really done no programming whatsoever besides some basic (and scrappy) HTML and CSS in months [06:00:59] [13Refreshed] 15mary-kate pushed 1 new commit to 06master: 02http://git.io/m0aWcQ [06:00:59] 13Refreshed/06master 145d59d2a 15Jack Phoenix: A bunch of MediaWiki 1.24 things to make Refreshed 1.24-compatible... [06:01:27] there we go; the actual change needed to make it 1.24-compatible was literally a few lines, but I decided to clean up some other stuff, too :> [06:03:13] Thanks! :D [06:03:24] [13Refreshed] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/gd5m2g [06:03:24] 13Refreshed/06master 14af56646 15George Barnick: Syntax fix [06:03:28] I think I fixed a syntax error there [06:03:42] It just sort of stood out even though I'm half asleep and multitasking [06:04:50] As soon as this show I'm watching is over I'll pull these to the server and see if 1.24 works [06:09:10] haha, thanks :D (can you tell I didn't test my changeset? ;-) [06:09:31] I never test anything lol that's why I never make big changes [06:14:24] testing is good, but often difficult and/or time-consuming (also, given that it's 8AM and I really really really should be heading to bed, I quite didn't feel like firing up XAMPP, installing the skin and seeing whether everything works, especially since I've done a similar changeset way too many times recently :P) [06:15:25] try not to fall asleep before I need to ask you questions about 1.24 lol [06:24:00] heading to bed now, but you can leave your 1.24-related questions here (given the low activity of the channel, I don't think it's gonna bother anybody ;) or PM 'em [06:24:49] ok [06:24:52] 'night [06:28:18] It works :DDDDD [06:28:23] wow it's fast too [06:28:54] meta's broken [06:28:57] oh well [06:29:03] seems to be Extension:Translate [06:32:52] [13extensions] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/jWBczw [06:32:52] 13extensions/06master 14068b9a7 15George Barnick: Update some submodules [06:34:46] WikiEditor is on 1.24 but isn't working... [06:34:58] That's not breaking anything but it's hard to not have that feature [06:43:47] Well I think I'm done for the night [06:44:01] I'll stay signed into IRC though unless Windows decides it doesn't want to [16:15:52] Lcawte [16:19:45] http://en.brickimedia.org/wiki/Special:Preferences this is broken [16:20:28] georgebarnick: King of Helpful Bug reports [16:20:49] mainly just passing along everything our users have complained about and I can't fix [16:21:07] seems deepsea is gone too [16:21:32] Have you actually read the release notes and updated extensions? [16:23:44] I looked through the mile long release notes of 90% stuff I don't understand and I tried updating extensions yesterday and it seemed some of them did not want to work [16:23:46] DeepSea is still there, it's enabled - see Special:Version, but it's broken since nobody maintains it and from what I remember, nobody really bothered to do skins properly. [16:24:36] mm [16:26:28] Hence why ashley spent a while fixing up a bunch of them for you. I don't have time to fix things now (and tbh, I already manage the ShoutWiki version upgrades, I don't like doing release upgrades), I'll let you have a go at reading error messages and try to fix things. But for starters "some of them did not want to work" ... answering which ones and why normally helps you fix them. [16:26:38] What's breaking Special:Preferences? [16:32:13] georgebarnick: hm, talk about an unhelpful backtrace...anyway, you could set https://www.mediawiki.org/wiki/Manual:$wgSpecialVersionShowHooks to true (at least temporarily, but why not permanently, too; IMO it being set to false by default is just stupid) and see what hooks into the GetPreferences hook and try disabling those extensions one-by-one and refreshing Special:Preferences after... [16:32:15] ...disabling an extension to see if the error goes away or not [16:44:49] [13extensions] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/zL3o8g [16:44:49] 13extensions/06master 14d5749fe 15UltrasonicNXT: attempt commit rollback - committed by @georgebarnick from brickimedia server [16:47:09] So my last commit didn't even change anything on the server so I'm lost [16:47:55] Lcawte: if you can at least fix Special:Preferences that would be great because that's preventing some users from even using the site if they're in a broken skin currently [16:48:03] which is a lot of our most active contributors [16:51:14] either that or I'll just downgrade to 1.23.7 and we'll stay there [16:54:10] georgebarnick: did you (not) see my previous message about debugging that particular issue? :-x [17:05:38] no, freenode's been disconnecting me repeatedly [17:06:58] [18:46:27] georgebarnick: hm, talk about an unhelpful backtrace...anyway, you could set https://www.mediawiki.org/wiki/Manual:$wgSpecialVersionShowHooks to true (at least temporarily, but why not permanently, too; IMO it being set to false by default is just stupid) and see what hooks into the GetPreferences hook and try disabling those extensions one-by-one and refreshingSpecial:Preferen [17:07:00] ces after... [18:32:13] [17:07:02] [18:46:27] ...disabling an extension to see if the error goes away or not [18:32:15] [17:08:18] well right now I don't even know what's up with extensions because I just updated them through git and none of them are updated [17:10:08] the fact that I'm even having to be the one to do this bothers me because 1) I'm the least knowledgeable about this setup we have and 2) I didn't set it up. All I know is that I'm primarily responsible for our community and I can't sit around and let our community have no ability to use the site. This is how we lose our users. [17:11:38] and every other issue I've raised in the past month or so, nothing's been done so I'm not expecting this to be fixed either [17:12:16] I'd rather just downgrade back to 1.23 and stay there from now on until the rest of the technical staff want to step in [17:15:01] hey, whatever the issue is, it's probably relatively easy to fix -- we managed to upgrade ShoutWiki to 1.24 and I'd argue our setup is somewhat more complex, with all the extensions, hacks and whatnot [17:17:01] [13Refreshed] 15georgebarnick created 06REL1_23 from 06master (+0 new commits): 02http://git.io/WEImgg [17:18:23] [13Refreshed] 15georgebarnick pushed 1 new commit to 06REL1_23: 02http://git.io/g5lPkQ [17:18:23] 13Refreshed/06REL1_23 141c0053d 15George Barnick: 1.23 release [17:20:46] I can't even fucking downgrade MediaWiki because this git setup is broken as hell [17:32:59] [13extensions] 15georgebarnick pushed 1 new commit to 06master: 02http://git.io/eaQWHw [17:32:59] 13extensions/06master 14b187891 15George Barnick: Going back to how it was before [17:35:23] there [17:35:28] everything's how it was last week [19:03:50] Lcawte: The current things of actual importance are: [19:04:07] - MediaWiki 1.24 has problems on our site in many aspects that I can't fix (I fixed what I could) [19:04:27] - Multiple users are getting locked out of their accounts with the site saying their password is incorrect for unknown reasons [19:04:36] That's pretty much it right now [19:05:48] The ShoutWiki Tech Team is going to do/finish your release upgrade. As for users getting locked out of their accounts, idk. I'd suggest getting your password right? [19:06:50] This is, after we've cleared a couple of things off today's ToDo. [19:07:38] The thing is it seems they're typing in the same password as they always do. [19:08:24] One user had to create two new accounts, saying that the first two had long passwords and the account stopped working and the third account had a short password that worked. I don't know if that's relevant or a coincidental observation or not. [19:09:12] It's not a huge problem for users with email addresses associated to their account because they can reset the password but users who don't have email on their account are pretty much locked out [19:09:31] One user has had to reset their password twice though, so it's still an inconvenience [19:51:24] [13LocalSettings] 15lewiscawte pushed 1 new commit to 06master: 02http://git.io/VLL6Iw [19:51:25] 13LocalSettings/06master 14f4a3d5f 15Lewis Cawte: Enable Monobook and Vector [19:53:59] Lcawte: You updating right now? [19:54:08] Yes. [19:54:15] awesome [20:00:14] you'll need to change the Refreshed branch to master. It's on REL1_23 right now [20:32:11] georgebarnick: So guess what! I fixed Special:Preferences. You'll never guess the cause... your old friend BetaFeatures! [20:33:31] Why does that break it? [20:35:20] Because it's a 1.22 branch that wasn't updated? It hooks Preferences to add the tab. [20:39:07] I updated all the extensions at one point yesterday though [20:39:19] And I know that was one that was updated [20:43:09] [13SocialProfile] 15lewiscawte opened pull request #7: Pull upstream changes (06master...06master) 02http://git.io/TnPZnA [20:46:30] [13DeepSea] 15mary-kate pushed 1 new commit to 06master: 02http://git.io/jv3I4A [20:46:30] 13DeepSea/06master 142fff016 15Jack Phoenix: Trying to fix this thing for MediaWiki 1.24 [20:50:26] I just ran update.sh to pull ashley's changes hope this doesn't break what you're doing Lcawte [20:51:02] I'm surprised it hasn't thrown you a billion errors because I'm doing most of hte stuff on the server. [20:57:19] nothing's erroring for me anywhere right now knock on wood [21:03:01] http://en.brickimedia.org/index.php?title=UserWiki:Belle&redirect=no bleh we have this again (no offense ashley) [21:03:15] the only reason I don't like that is because it confuses a lot of users [21:04:32] [13extensions] 15lewiscawte pushed 1 new commit to 06master: 02http://git.io/SKPWyQ [21:04:33] 13extensions/06master 140dd0cfe 15Lewis Cawte: Updated submodules file [21:14:33] georgebarnick: Because I really dislike downstream hacks/"core" hacks due to the fact they're a insanely huge pain to manage and break upgrades, I switched it back to using the upstream version. File the various changes in the foundation Phabricator and we may look at integrating options for them upstream so we can avoid issues like this in the future. [21:16:34] [13extensions] 15lewiscawte pushed 1 new commit to 06master: 02http://git.io/XmndKg [21:16:34] 13extensions/06master 1499a2212 15Lewis Cawte: Kill Phalanx [21:18:20] Lcawte: yeah I realize that. ashley are there ways to disable some of the features individually? Some of them confuse our users who are used to normal MediaWiki setups or who aren't familiar with MediaWiki at all (e.g. having multiple places they get messages, having multiple user pages, etc, confuse new users) [21:19:03] georgebarnick: re: ^. Read the message you were replying to. [21:22:00] I know I was just wondering if there are existing methods to disable them through LocalSettings or something [21:22:43] No, hence why I said file the issues upstream. [21:23:20] ok [21:23:33] Also, WikiEditor still isn't working. Wasn't working last night either [21:23:36] dunno why [21:26:03] [13extensions] 15lewiscawte pushed 1 new commit to 06master: 02http://git.io/SitVIg [21:26:03] 13extensions/06master 147fe0ad8 15Lewis Cawte: Submodule AjaxLogin [21:29:25] [13extensions] 15lewiscawte pushed 1 new commit to 06master: 02http://git.io/P47CVg [21:29:25] 13extensions/06master 149fc9434 15Lewis Cawte: Submodule GlobalUserrights [21:30:54] [13SocialProfile] 15lewiscawte closed pull request #7: Pull upstream changes (06master...06master) 02http://git.io/TnPZnA [21:40:05] georgebarnick: Most of your social tools related forks are broken, including BlogPage and Comments. Most of these are fixed upstream as far as we're aware... [21:40:16] I'm aware [21:40:58] BlogPage is modified a bit on Brickimedia but I can most-likely "redo" those modifications through frontend CSS and/or JS. idk what we've changed on comments [21:41:27] UltrasonicNXT did a good deal with Comments but I think he's merged most of his changes upstream so I don't know if using upstream Extension:Comments will change anything we have currently [21:43:32] Adam did a lot of upstream work... [21:52:21] http://i.imgur.com/iJvbZI3.png as I said [21:53:44] also http://en.brickimedia.org/wiki/User_talk:ToaMeiko#MediaWiki_issues Lcawte if you can reply with what you know here before I go saying anything I'm not certain of [21:54:11] you might want to join brickipedia chat too idk [22:00:18] maybe I should post a blog update just so everyone in the community who isn't in chat knows? [22:00:52] Sure, have you switched BlogPage out yet? [22:02:14] no [22:02:20] I thought you'd do that since you did all the others [22:02:44] I got distracted... I'll sort that in a moment. [22:02:47] it doesn't matter if we lose downstream changes right now since they'll still be in our repository [22:04:06] I'll start working on front-end versions of some of the "hacks" we had [22:05:36] http://en.brickimedia.org/wiki/Brickipedia_News:News_Roundup_(Dec_12_-_Dec_19) this is broken for some reason [22:06:04] [13extensions] 15lewiscawte pushed 1 new commit to 06master: 02http://git.io/AM51LQ [22:06:04] 13extensions/06master 14e813459 15Lewis Cawte: Switch SP-related extensions to upstream repository [22:06:31] georgebarnick: Comments extension. [22:06:41] ah right [22:08:59] I'm going to suggest you mention [[Special:ToggleUserPage]] in your blog, since some people are missing their user profiles. [22:16:19] alright [22:16:36] http://en.brickimedia.org/index.php?title=Special:Search&search=Minifigure is search broken for some unknown reason or are you doing something right now [22:19:29] Was in the process of fixing Comments + BlogPage, files were temporarily missing causing a fatal. [22:22:17] alright [22:33:15] It seems someone hardcoded the path to the poweredby_mediawiki button somewhere in one of the skins because it's throwing a /lot/ of 404s to the error logs. [22:38:12] Check Custard or DeepSea [22:38:21] I'm fairly certain it isn't Refreshed that's causing it [22:38:34] Also is Echo up to date because it's acting funny [22:38:57] http://en.brickimedia.org/wiki/User_talk:ToaMeiko#Chat_2 and apparently chat isn't working for some user [22:39:00] *users [23:02:04] http://en.brickimedia.org/wiki/User_blog:ToaMeiko/MediaWiki_1.24_update [23:02:46] feel free to add to that Lcawte [23:03:30] georgebarnick: Reading it now, I'm watching all the chats so there is no need to ping me all over the place ;) [23:03:40] :p [23:06:28] Lcawte: (posting here not to cram bricki chat with stuff nobody else in there understands) http://en.brickimedia.org/index.php?title=User_blog:ToaMeiko/MediaWiki_1.24_update&curid=69598&diff=942441&oldid=942440 [23:06:43] The issue's been going on since before I updated anything so I don't think its related [23:06:55] It first occured earlier this week before I ever tried to update past 1.23.7 [23:08:17] Most of the extensions didn't have branches set until earlier today which means they'd default to master... they might of been ahead of 1.23 and using new things. Obviously I've not verified that yet, and tbh, I'm not entirely sure what's going on with that yet, but it's best not to rule it out for now. [23:09:19] I noticed the unassigned branches too but from what Special:Version looked like all of them were as they were at 1.22 [23:10:23] eww. [23:12:34] well at least they all worked :P [23:13:06] (also some would have been 1.23 because periodically I or NXT would manually update them such as Chat or MultimediaViewer) [23:13:41] Speaking of that, MultimediaViewer isn't working anymore either [23:15:40] I disabled it with VisualEditor (which I assume didn't work as Parsoid wasn't running and I don't remember it ever working properly) and BetaFeatures. The newer version probably don't depend on BetaFeatures does it? [23:15:51] yeah we never got VE working [23:15:54] it was on the todo [23:16:19] MMV shouldn't depend on BetaFeatures because it's run on my test wiki without it since 1.23 or 1.24 (I forget) [23:16:44] I think MMV is just broken right now which I've seen it do before [23:17:10] I'm fairly sure MMV had a 1.22 / WMF1.23 branch set in .gitmodules [23:17:43] Note: '''had''' ... I changed them all to 1.24 earlier. [23:18:11] it might have been [23:18:26] But if it's on 1.24 now then it should be working fine without betafeatures [23:18:55] I disabled it before I did that... you're right, it should probably work fine, it just needs re-enabling for you to find out.