[07:15:45] Good Morning! [07:18:34] good morning! [07:18:45] morning [07:28:52] isaranto: Could you take a second look at this patch in a free minute? 🥺 https://gerrit.wikimedia.org/r/c/machinelearning/liftwing/inference-services/+/1156234 [07:37:15] on it! [07:38:16] morning folks [07:40:33] (03CR) 10Ilias Sarantopoulos: [C:03+1] "LGTM!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1156234 (https://phabricator.wikimedia.org/T393865) (owner: 10Bartosz Wójtowicz) [07:41:56] isaranto: thank you! 🙌 [07:42:14] (03CR) 10Bartosz Wójtowicz: [C:03+2] ci: Fix blubber file for pre-commit-check CI job. [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1156234 (https://phabricator.wikimedia.org/T393865) (owner: 10Bartosz Wójtowicz) [07:43:40] (03Merged) 10jenkins-bot: ci: Fix blubber file for pre-commit-check CI job. [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1156234 (https://phabricator.wikimedia.org/T393865) (owner: 10Bartosz Wójtowicz) [08:13:55] Heyy team, after adding the new CI job running pre-commit check on the whole repository, I'm thinking about cleaning up other CI jobs running pre-commit. It seems to me that majority of our model-specific CI jobs run only pre-commit checks on model code without any unit tests [08:14:19] I'm thinking about removing those jobs now that we have global pre-commit job running on any change within repo. What do you think about this? Do you see any benefits of keeping those model-specific jobs running only pre-commit? [08:26:58] I think I'd just remove all the redundant jobs and triggers from the integration/config repo. So leave just the ones that have additional things (unit tests) [08:27:03] what do others think? [09:02:19] +1 ~~~~^ [09:02:51] Does anybody used kokkuri ? [09:04:56] (03PS1) 10Bartosz Wójtowicz: ci: Remove unnecessary CI stages running lint checks on subset of repository. [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1159368 (https://phabricator.wikimedia.org/T393865) [09:06:53] georgekyz: I haven't. Go ahead and ask your question though:) [09:07:20] or even better write it also in phabricator [09:14:27] Context: I am trying to setup a `gitlab-ci` pipelline which runs `kokkuri` for building/pushing to our docker-registry, in order to be used via the `WMFKubernetesPodOperator`. Question: Should we set-up some access first in the gitlab repo for pushing images to the registry? Do you know anybody that I can ask? [09:39:22] I think the best thing is to write a comment on phabricator with what you are trying to do. Then you can reference this and ask a question #wikimedia-releng in IRC [09:40:30] and then you can also follow up on phabricator with the info from the response you got (or someone else will already reply directly on phab) [09:40:58] thnx [10:05:01] 06Machine-Learning-Team: Inputs for tone check model prediction - https://phabricator.wikimedia.org/T397013 (10achou) 03NEW [10:10:25] 06Machine-Learning-Team: Build model training pipeline using WMF ML Airflow instance - https://phabricator.wikimedia.org/T396495#10917637 (10gkyziridis) I am trying to setup a `gitlab-ci` pipeline in [[ https://gitlab.wikimedia.org/repos/machine-learning/ml-pipelines/-/tree/retraining_tone_check?ref_type=heads |... [10:13:52] 10Lift-Wing, 06Machine-Learning-Team, 10EditCheck, 10Editing-team (Tracking): Create SLO dashboard for tone (peacock) check model - https://phabricator.wikimedia.org/T390706#10917651 (10isarantopoulos) I tried to address the above comments. - Organizational: the ML team is solely responsible for this se... [11:41:42] Folks in order to build/push images from our gitlab repo to docker registry via kokkuri we need special accesses and configuration in this repo: https://gitlab.wikimedia.org/repos/releng/gitlab-trusted-runner [11:42:48] When that is configured and merged, then our `ml-pipelines`repo will be registered as `trusted-runner` and we can then push images to the registry. [11:42:57] Should I proceed to that one ? [11:44:21] sure go ahead! thanks for following up on this. [11:46:42] I will update the phab ticket with the updates, there is also this ticket over here: https://phabricator.wikimedia.org/T372417 which we all need to take into account moving to `miniforge` for licensing reasons according to Balthazar [13:55:20] 10Lift-Wing, 06Machine-Learning-Team, 10EditCheck, 10Editing-team (Tracking): Create SLO dashboard for tone (peacock) check model - https://phabricator.wikimedia.org/T390706#10918639 (10elukey) Really great updates! >>! In T390706#10917651, @isarantopoulos wrote: > - Operational: At the moment we get no... [14:07:28] georgekyz: o/ I did a review on the third batch for the ores extension and there were a couple of issues https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1155652 [14:08:03] georgekyz: do you want me to address them while I'm at it? I have all the config values in my head at the moment :P [14:28:29] if you have it ready yes go ahead! It was my bad that I squashed again the commits but gerrit was forcing me. [14:28:39] otherwise I can do it asap if you want [14:36:24] I'll do it and you can review. I was thinking to schedule this for deployment Wednesday morning. wdyt? [14:41:17] yes I'm in! [14:48:49] georgekyz: I implemented the changes in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1155652 [14:54:33] I reviewed it, are we going to set the thresholds for `trwiki` and `simplewiki` ?? [14:59:41] I thought it wouldn't hurt as it doesnt do anything. shall I remove them? [14:59:50] we can then add them in the patch related to these wikis [15:03:44] if it does not hurt lets keep them [15:05:54] ah, I removed them alreayd [15:06:50] *already. Let's add them when we add these wikis since that what we do in all relevant patches [15:46:26] perrfet [15:46:27] thnx [15:47:18] should I schedule it for Wednesday morning ? [15:48:31] Ja!! [15:48:45] Bedankt [15:51:32] 06Machine-Learning-Team, 06Security-Team, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919352 (10sbassett) [15:52:55] geen probleem :P [15:53:47] Done: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20250618T0700 [15:58:18] I created an inv for Wednesday morning I added you all as optional for morning coffee and happy deployments [15:58:38] 😋 [15:58:41] 06Machine-Learning-Team, 06Security-Team, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919390 (10sbassett) >>! In T396466#10899251, @Aklapper wrote: > Some of the listed users currently do not have 2FA according to https://phabricator.wikim... [16:00:01] 06Machine-Learning-Team, 06Security-Team, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919396 (10sbassett) [16:15:54] 06Machine-Learning-Team, 06Security-Team, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919473 (10kevinbazira) @sbassett, I have enabled Phab 2FA. Thanks! [16:23:51] 06Machine-Learning-Team, 06Security-Team, 07SecTeam-Processed, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919517 (10sbassett) 05Open→03In progress p:05Triage→03Medium a:03Mstyles [16:24:23] 06Machine-Learning-Team, 06Security-Team, 07SecTeam-Processed, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919525 (10sbassett) [16:24:41] 06Machine-Learning-Team, 06Security-Team, 07SecTeam-Processed, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919539 (10sbassett) >>! In T396466#10919473, @kevinbazira wrote: > @sbassett, I have enabled Phab 2FA. Thanks! Thanks! [16:48:33] awesome! [16:56:45] 06Machine-Learning-Team, 06Security-Team, 07SecTeam-Processed, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919736 (10sbassett) [16:57:10] 06Machine-Learning-Team, 06Security-Team, 07SecTeam-Processed, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10919738 (10sbassett) Confirmed that @achou now has Phab 2FA set up. Thanks! [22:34:20] 06Machine-Learning-Team, 06Security-Team, 07SecTeam-Processed, 07Security: Security Issue Access Request for Machine Learning team - https://phabricator.wikimedia.org/T396466#10920821 (10Mstyles) 05In progress→03Resolved The ML team now has security issue access!