[14:16:32] <elukey>	 hey folks! I have some patches to introduce new ingress-based endpoints in service.yaml and mesh's configs: https://gerrit.wikimedia.org/r/c/operations/puppet/+/1280433
[14:16:48] <elukey>	 I know they are not really "fun" but if anybody has time to review lemme know :)
[15:34:27] <cdanis>	 elukey: one thing I recommend for service.yaml edits -- run PCC for at least one deployment host, that will help catch some possible sneaky mistakes
[15:38:42] <elukey>	 okok!
[15:40:07] <elukey>	 cdanis: wait I am confused, do you mean the envoy.yaml? Does service.yaml renders on deploy1003 too?
[15:42:21] <cdanis>	 hmmh maybe it doesn't at service_setup time
[15:43:33] <cdanis>	 but service_setup might affect envoy.yaml, it's for setting up the 'realservers', which
[15:43:44] <cdanis>	 is effectively ingress/Envoy from the LVS perspective?
[15:43:54] <cdanis>	 (sorry, I didn't sleep much last night)
[15:45:20] <elukey>	 I'll check with PCC and report back :)
[15:46:44] <cdanis>	 [in general, though, it's been in the back of my mind for a while that we could probably smooth over a lot of the issues with the service catalog by making puppet CI smarter about what to check on whcih state transitions]