[08:30:42] Alright, I have a reviewable patch for this on which we can iterate https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1074099 [13:08:19] brouberol: what I meant is that the change is the metadata.labels.chart stuff, which in our helper functions is in the "base.meta.labels", with a value of {{ template "base.name.chartid" . }}, which, long story short is {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }} [13:08:56] yep, that's the one [13:09:27] and because we checksum the entire file, any version bump causes the secret checksum to change, causing the Deployment spec to change, causing a pod rolling restart [13:09:38] even if the actual secret didn't change, nor the Deployment pod spec [13:09:42] which is present almost everywhere and it very often shows up when doing helmfile apply (arguably needlessly, it's the only diff for most resources, except the one you actually care about. [13:09:57] I am wondering whether it makes sense to change that instead of working around that [13:10:53] so, in past experiences, I found it useful to have the version with which a chart was deployed appear in the resources and be easily discoverable. This is personal preference, really [13:11:52] my ultimate goal is to avoid triggering pod rolling-restarts at every deployment. However we reach that goal is fine by me TH [13:11:54] *TBH [13:14:43] I think we made the same assumption back then, that the version would be indeed useful. And it definitely is in some cases. In others, it's pointless diffs. [13:15:18] e.g. do we really need the secret resources to be versioned in the exact same way as the deployment ? Or the service for that matter.