[07:19:46] Hi akosiaris! It seems that we reached a consensus related to cloudnative-pg RBAC (https://phabricator.wikimedia.org/T364797#10022548). Would you be able to have a look at https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1049084/3 and https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1037731/4? The CRs might look big, [07:19:47] but they're just copy & paste of the upstream CRDs and chart, really. Thank you! [07:20:16] sure. let me see what I can do [07:20:22] good morning btw! [07:20:29] The other CRs have already been reviewed by inflatador and b.tullis IIRC [07:20:32] morning! [10:15:53] brouberol: let me go through the patches first [10:16:01] I should have seen them, but managed to miss them [10:17:23] no worries! Many of your comments are valid _and_ unaddressed in the further stacked patches. I think it makes sense to collapse everything into a single reviewable unit [10:24:20] akosiaris: I saw you have +1ed many of the stacked patches. How do you want to proceed? Should I a) fixup everything into the chart CR or b) rework the chart CR while leaving the other changes into the stacked changes? [10:26:08] (I'm happy either way) [10:54:17] brouberol: Add the changes to a new CR at the top of the task, I 'd say [10:54:29] and let the original one (the import) as is [10:54:43] aka, continue your original approach [11:18:14] gotcha! [11:25:45] all done [13:00:11] all reviewed on my side as well [13:04:16] I've addressed your comments on the RBAC CR. Can I assume the chart import CR can be merged as-is, as it's being "corrected" by the subsequent stacked patches? [13:05:08] yeah, let me be explicit about that [13:05:32] done [13:09:32] Thanks again for the reviews and the time you gave us. This has been really useful m(_ _)m [13:18:55] thanks as well for reaching out and addressing feedback!