[14:08:34] klausman looks like you merged https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1054538, should I review the rest of the chain or https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1058153 next? [14:09:25] only the non-WIP one (..153) for now [14:11:56] while the others are sortof ready, I want to do some more testing in staging before I deem them actually ready for review [14:14:46] klausman: curiosity, why are you doing all those steps instead a single one? [14:14:54] debuggability [14:15:01] (or so I thoight) [14:15:20] I think it may lead to more confusion, but my 2c :) [14:17:17] My thoguth was that breaking all networking of all pods at the same time would be harder to debug than breaking one at a a time [14:18:07] The use of quotes within the selector string is tweaking my OCD a bit ;) https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1058153/1/charts/knative-serving/templates/networkpolicy-activator.yaml#45 [14:18:52] no objections to using it, just wanted to share my neuroses ;) [14:20:49] anyway, +1 [14:21:15] ty! And AIUI, the quotes (and lack thereof on the LHS) is required. [14:32:16] ah, must be some magic I haven't encountered yet [14:37:37] if you'd prefer the reainder as one big review, I am fine with converting them [14:37:54] amkes for a little less rebasing and conflict resolution, too :) [14:40:48] also those code changes need a chart bump each :) [14:54:28] yeah, that's the main bummer.