[06:40:49] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy Card Payment AVS check triggering false positives. - https://phabricator.wikimedia.org/T396355#11015852 (10RKumar_WMF) Thank you Evelyn. [08:13:17] (03CR) 10Reedy: [C:03+2] build: Updating mediawiki/mediawiki-phan-config to 0.16.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1168358 (owner: 10Libraryupgrader) [08:48:02] (03Abandoned) 10Reedy: build: Updating brace-expansion to 1.1.12 [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1157127 (owner: 10Libraryupgrader) [08:48:41] (03Abandoned) 10Reedy: build: Updating brace-expansion to 1.1.12 [extensions/FundraisingEmailUnsubscribe] (REL1_42) - 10https://gerrit.wikimedia.org/r/1157354 (owner: 10Libraryupgrader) [08:48:43] (03Abandoned) 10Reedy: build: Updating brace-expansion to 1.1.12 [extensions/FundraisingTranslateWorkflow] (REL1_42) - 10https://gerrit.wikimedia.org/r/1157358 (owner: 10Libraryupgrader) [09:02:54] (03PS3) 10Reedy: Campaign: Add and use ability to read from primary in getCampaignSettings [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1170395 (https://phabricator.wikimedia.org/T389348) [09:06:45] (03CR) 10CI reject: [V:04-1] Campaign: Add and use ability to read from primary in getCampaignSettings [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1170395 (https://phabricator.wikimedia.org/T389348) (owner: 10Reedy) [09:38:35] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] CentralNotice: Remove return from outputHeader() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1170406 (owner: 10Reedy) [09:45:52] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] "I assume this was a copy-paste mistake. The comment was added in 2012 via I456b576. The call was changed via I9934565. It uses auto-detect" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1170377 (owner: 10Reedy) [09:47:04] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Use === comparison for _action [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1170379 (owner: 10Reedy) [10:04:17] (03Merged) 10jenkins-bot: CentralNotice: Remove return from outputHeader() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1170406 (owner: 10Reedy) [14:37:30] (03CR) 10Jforrester: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1160191 (https://phabricator.wikimedia.org/T397230) (owner: 10Reedy) [15:18:49] 06Fundraising-Backlog, 13Patch-For-Review: [Discussion] Recurring subscr_id handling: Mixed approaches across processors - Feature or Bug? - https://phabricator.wikimedia.org/T399868#11017286 (10jgleeson) I also reviewed what we do for Adyen, and it appears that we do use the seed transaction ID as the recurri... [15:24:05] 06Fundraising-Backlog, 13Patch-For-Review: [Discussion] Recurring subscr_id handling: Mixed approaches across processors - Feature or Bug? - https://phabricator.wikimedia.org/T399868#11017313 (10AnnWF) I think we can add a mapper to indicate which payment methods are expecting subscription id and others are lo... [15:25:08] 06Fundraising-Backlog, 13Patch-For-Review: [Discussion] Recurring subscr_id handling: Mixed approaches across processors - Feature or Bug? - https://phabricator.wikimedia.org/T399868#11017316 (10jgleeson) [15:26:05] wfan: I just updated that task description. The fix I tried last night (getting the right ID inside the smashpig job) didn't work as we can't retrieve it with the data available to us inside the scope of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1167625/7/PaymentProviders/Gravy/Jobs/RecurringCancellationJob.php [15:27:45] Instead, I pushed up an alternative solution, which is to use the recurring payment token as the civicrm_contribution_recur.trxn_id, like we do for our direct PayPal integration. That patch is here, and it should allow us to leave everything else as it is. https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1170438 [15:28:34] ok looking~ btw I am also going to take PTO next week since my parents want to see kid so they are coming to Thailand for a week~ [15:31:28] This tmp fix seems work, as I comments, I think we can add a mapper for the gateway_subscr_id we looking for, then we can better understand what id each ipn is sending to us and I am going to test yours now, thanks Jack! [15:39:20] thanks wfan ! [15:44:23] fr-tech, gravy just issued an amber notice https://status.gr4vy.com [15:44:37] "Intermittent processing issues" [15:45:18] 06Fundraising-Backlog, 10fundraising-tech-ops: Email send delays for yahoo and aol domains - https://phabricator.wikimedia.org/T399670#11017335 (10greg) It didn't happen yesterday even though we had the usual daily recurring go through. {F65204293} [15:50:55] (03CR) 10Wfan: [C:03+1] "Overall looks reasonable, since this is a tmp fix, let's add some todo and explanation inline" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1170438 (https://phabricator.wikimedia.org/T399868) (owner: 10Jgleeson) [15:52:26] (03PS5) 10Jgleeson: Temp Fix: Use recurring_payment_token for Gravy PayPal subscription trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1170438 (https://phabricator.wikimedia.org/T399868) [15:53:04] thanks for the review wfan. I'll look at those now. [15:53:20] also, I just messaged gravy on slack to see if they can add some extra data to the webhook notifications https://wikimedia.slack.com/archives/C070F1DVBRN/p1752853815093409 [16:10:07] cool, thanks Jack~ I also slacked dlocal for that pending status, they suspect that would be our config issue, but we do see the pending status when click no bank and exit from their api, so I suggested to return something else https://docs.dlocal.com/reference/payment-status-codes#rejection-status in rejection status for that case [16:37:29] 03Fundraising Sprint: Naan-Sequitur, 06Fundraising-Backlog, 07fr-current-sprint: Implement Gravy payment method deletion handling for subscription cancellations - https://phabricator.wikimedia.org/T398723#11017462 (10EMartin) @jgleeson Is this deployment indicating this matter is now /soon to be resolved on... [17:23:08] (03PS6) 10Jgleeson: Temp Fix: Use recurring_payment_token for Gravy PayPal subscription id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1170438 (https://phabricator.wikimedia.org/T399868) [17:23:21] wfan: I've made those updates to the patch from earlier [17:23:47] Ok checking [17:26:08] (03CR) 10Wfan: [C:03+2] Temp Fix: Use recurring_payment_token for Gravy PayPal subscription id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1170438 (https://phabricator.wikimedia.org/T399868) (owner: 10Jgleeson) [17:30:56] I'll push that out and do the end-to-end test again [17:35:05] 06Fundraising-Backlog, 13Patch-For-Review: [Discussion] Recurring subscr_id handling: Mixed approaches across processors - Feature or Bug? - https://phabricator.wikimedia.org/T399868#11017575 (10jgleeson) [17:35:23] once CI does its thing... [17:37:29] 03Fundraising Sprint: Naan-Sequitur, 06Fundraising-Backlog, 07fr-current-sprint: Implement Gravy payment method deletion handling for subscription cancellations - https://phabricator.wikimedia.org/T398723#11017579 (10jgleeson) Copying reply from Slack: > Hi @emartin, we did deploy all the changes. However,... [17:41:11] (03Merged) 10jenkins-bot: Temp Fix: Use recurring_payment_token for Gravy PayPal subscription id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1170438 (https://phabricator.wikimedia.org/T399868) (owner: 10Jgleeson) [17:43:11] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1170590 [17:43:35] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1170590 (owner: 10Jgleeson) [17:44:23] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1170590 (owner: 10Jgleeson) [17:49:50] !log civicrm upgraded from bf098cc5 to 60b2a914 [17:49:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:50:36] ok that's out. end-to-end test time [17:50:47] paypal is gonna think I'm a fraudster soon [18:00:30] :) [18:04:45] ok! the recurring subscription got imported with the *new* ID that we can match to the data gravy sends us in the webhooks [18:04:57] now I'll trigger the cancellation from paypal [18:05:31] * jgleeson is thinking of all the processors to depend on for this test on a friday @_@ [18:08:12] Jul 18 18:06:54 frpig1002 SmashPig-Gravy: SPCID-0353822348 | (PaymentMethodDeleteAction) Processing PayPal payment method deletion for ID: 7d65a483-239c-4179-b078-78a4aa0c790a | | [18:08:16] that's a good sign [18:12:45] woohoo it got cancelled! [18:12:45] \o/ [18:12:51] https://civicrm.wikimedia.org/civicrm/contact/view/contributionrecur?reset=1&id=2325347&cid=9860166&context=contribution [18:12:59] (I was a little early with my \o/ but glad it's good!) [18:16:29] :D [18:16:45] I just let Evelyn know on Slack https://wikimedia.slack.com/archives/C045WH0QYS2/p1752862583805239 [18:20:26] 👍 [18:22:59] Ok I'm gonna wrap up for tonight as I promised Roxy I'D be done at 7 so we could watch the remainder of The Accountant 2 ha! fr-tech as promised I'll write up a vacation handover email and share it round and I'll also spend an hour on Monday morning getting the Gravy Adyen 3D Secure patches into a more complete state for ejegg|away to pick up when he gets back. [18:26:24] 06Fundraising-Backlog, 13Patch-For-Review: [Discussion] Recurring subscr_id handling: Mixed approaches across processors - Feature or Bug? - https://phabricator.wikimedia.org/T399868#11017702 (10jgleeson) That fix worked. I just performed the same end-to-end test, setting up a PayPal recurring subscription via... [18:28:04] see you all in 2 weeks! o/ [19:06:30] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Infrastructure Security, 06Infrastructure-Foundations, and 2 others: Re-opening our DMarcian Trial - https://phabricator.wikimedia.org/T394788#11017745 (10nisrael) Hi SRE team, Checking in on this task. Do you have an approximate timeline when we'd be able... [19:59:49] 06Fundraising-Backlog, 10Quibble, 10Continuous-Integration-Infrastructure (Zuul upgrade), 07Essential-Work: Remove reliance on EXECUTOR_NUMBER environment variable in CI - https://phabricator.wikimedia.org/T399283#11017820 (10thcipriani) [20:02:30] (03CR) 10Ladsgroup: [C:04-1] Campaign: Add and use ability to read from primary in getCampaignSettings (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1170395 (https://phabricator.wikimedia.org/T389348) (owner: 10Reedy) [20:13:11] bye jgleeson|away - enjoy, and also enjoy the accountant 2 :) [23:13:46] 06Fundraising-Backlog, 07payments-orchestration: Add Gravy to queue dashboard graphs - https://phabricator.wikimedia.org/T399983 (10greg) 03NEW