[02:12:04] <_chrs_> just noticed something interesting: changing the content model of a page does not get pushed to discord feeds (does go to irc ones though) [02:33:36] Thanks! [02:35:48] huh [02:42:00] <_chrs_, replying to pixldev> yeah looks like this has something to do with the specific hook that gets called by changecontentmodel vs normal page edits [02:43:35] <_chrs_> on that note, I encountered this while making a script that makes the managewiki permissions log less cursed ([[User:Chrs/improvedManageWikiLog.js]]) if anyone else finds that useful [02:43:36] [02:50:40] <_chrs_, replying to _chrs_> hmm no that actually shouldn't? weird... [02:54:56] [1/2] https://github.com/miraheze/DiscordNotifications/blob/main/includes/Hooks/Hooks.php [02:54:56] [2/2] Need to add the hook to this file I think? [02:55:52] <_chrs_, replying to posix_memalign> well that was my first thought but then I went through the MW code and it looks like changecontentmodel should eventually find its way down to `onPageSaveComplete`??? [02:55:54] <_chrs_> oh lmao think I found it [02:56:04] <_chrs_> probably the `isNullEdit` check [05:59:35] [1/2] I think you mentioned something about it being a null edit? That seems to be the case in my local testing. [05:59:36] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1465949409790398617/image.png?ex=697af747&is=6979a5c7&hm=94b6ca8b057f29f7f5940125e9a80534ebc23e2a95af31a6f0a71b5e47858ba1& [06:01:14] <_chrs_, replying to posix_memalign> yeah I saw that and thought it was it but then assumed it couldn't be that because of the MW documentation that states null edits aren't saved as a revision [06:01:48] <_chrs_> then upon further looking there were some variables that indicated it may be possible but etc etc etc didn't look likely [06:02:09] <_chrs_> guess that identifies it [06:02:38] i mean, content model changes make a new rev [06:03:46] p sure DN ignores null edits [06:04:58] which is why you'll sometimes see content model changes logged when they result in size changes somehow [06:05:00] how fun [06:05:28] ooh, guess! json that gets pretty formatted? [06:06:29] <_chrs_, replying to blankeclair> my first guess was "something to do with massmessage" and what do you know it does in fact do syntax checking when you try to convert something to a mailing list [06:07:22] i gotta get up so here: https://discord.com/channels/407504499280707585/475350160428498964/1463842159739535426 [06:19:20] <_chrs_> looks like massmessage does this as well [06:19:55] anything with a pst i bet [06:27:36] <_chrs_> broke testwiki lol: `[7e7287bfc647302232480728] 2026-01-28 06:25:18: Fatal exception of type "Wikimedia\Assert\ParameterTypeException"` (you can repeat this at home by trying to changecontentmodel something invalid into a delivery list) [07:23:59] We'd be bored if people didn't break the wikis [07:27:20] no we'd have 37 page long schizo emails to entertain us [07:27:49] Please read this email!!! We've been trying to inform you about car deals for your business! [07:28:04] <_chrs_, replying to pskyechology> so this is how they lure people into T&S [07:28:40] <_chrs_, replying to blankeclair> the extended warranty on your servers is about to expire! you must renew now or else Linus Torvalds will break in and smash them with a hammer! [07:29:24] oooooo you wanna buy ubuntu security updates for your ancient version oooooooo [07:30:16] <_chrs_> for those who haven't already seen it: https://en.wikipedia.org/w/index.php?title=User:Jimbo_Wales&oldid=142746739 [07:31:05] BAHAHAHAHAHA i love this [07:31:22] can vandals do more of that instead of SEO spam bullshit [07:31:36] please i beg you, be funny [07:32:18] We've been trying to reach you about your site's extended guest posts [07:33:33] Or security reports telling us that stealing a session cookie will result in a stolen session cookie @pskyechology [07:43:45] <_chrs_, replying to rhinosf1> critical security vulnerability: pages on your website are open for public editing [07:44:57] I don't actually know if we've had that tbh [07:45:18] lets unblock wordpress paths and find out [07:46:11] We have had someone complain sign in with Google has a security issue [07:46:14] We don't even have that setup [07:47:08] <_chrs_> wat [07:47:56] We get... a lot of very dumb 'security reports' in search of payout [07:48:18] Most of them are the same researcher [07:48:24] Who is now blocked [07:49:10] We've had some complete and utter nonsense reports about things that either don't exist or completely misunderstand the fundamentals of how they work [07:49:35] from the same researcher under a few variations of their name [07:50:09] IIRC one of them was as silly as "I can change the CSS using F12" [07:50:25] Good job, bud. [07:50:28] I didn't see that one [07:50:48] ts also gets a bunch of those, interestingly [07:51:02] We've had stealing a session cookie results in a stolen session, google sign in doesn't revoke properly, OAuth doesn't revoke properly [07:51:12] A lot of crap [07:51:37] They are very long nicely bolded probably AI generated emails [07:51:39] tempted to setup an autoresponder that just replies "womp womp" [07:52:02] We get a lot of spam that asks to join our bug bounty program too [07:52:08] Which we've never operated [07:52:15] too broke for that [07:52:27] We do offer free yubikeys to actual volunteers though [07:52:32] At the cost of postage [07:52:36] <_chrs_, replying to notaracham> hold on going to go grab that "1337 h4x0r edit webpages chrome extension" that went around a decade ago [07:52:59] did the states stop being stupid about it yet [07:53:13] "The day it goes wrong is the day you rue: the story of how a candidate lost a job offer" [07:53:22] We can deliver to the US at the moment [07:53:28] yay [07:54:28] Although any post to areas affected by the cold snap may of course be delayed [19:46:58] [1/2] @paladox i finally got annoyed enough by our phorge embeds on discord, namely the forever loading logo [19:46:58] [2/2] i think its because we use a svg file, right? i dont think anyone would notice if we switched to png, or worse yet, jpg [19:47:39] What do you mean? (i don't understand) [19:48:02] [1/3] for comparison: us vs wmf [19:48:03] [2/3] https://issue-tracker.miraheze.org/T14862 [19:48:03] [3/3] https://phabricator.wikimedia.org/T14862 [19:48:22] you'll notice the logo on ours doesnt load [19:48:59] [1/2] oh i see you mean the [19:48:59] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1466158132693565747/Screenshot_2026-01-28_at_19.48.55.png?ex=697bb9aa&is=697a682a&hm=8b39acafdfc4c6f0ab1645fcf25ba8c04d9522d2713a4a7b3c536ee9019afd78& [19:49:17] [1/2] yup, or in my case the [19:49:18] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1466158211366391952/image.png?ex=697bb9bd&is=697a683d&hm=b12a14f89516142afce5fe7eae56b48471d9879e234d2ac84ca672ebab8abca8& [19:49:28] i dunno why it doesn't load [19:49:32] im fairly certain discord doesnt know how to handle svgs [19:49:33] it links to https://phorge-static.wikitide.net/file/data/rht34vgnchwyai3wkh7d/PHID-FILE-ngtyjn6lyl6qg24fymjc/logo [19:50:07] wmf: https://phab.wmfusercontent.org/file/data/2gfkyy3hb6rw7liqgav5/PHID-FILE-oyvjnb2icqujlbh4rbxf/logo [19:50:32] oh i see wikimedia embeds [19:50:40] https://phab.wmfusercontent.org/file/data/2gfkyy3hb6rw7liqgav5/PHID-FILE-oyvjnb2icqujlbh4rbxf/logo loads in the browser vs ours [19:50:49] theirs seems to be a png [19:51:10] if you want, convert it to png and i can change it to that to see [19:53:56] wonder if it's x-download-options: noopen? [19:54:12] oh that might also be it [19:54:55] because i dont think any of us wouldve bothered to convert the source to svg [19:55:25] and i cant open the logo as a svg when i download it from phorge [19:55:39] i'm not sure why ours set it and not wikimedias? [19:55:46] https://github.com/phorgeit/phorge/blob/ec0ef684427ba89cd0c13ca7ade69c03f560d522/src/aphront/response/AphrontFileResponse.php#L141 [19:56:08] no puppet weirdness? [19:57:54] we don't set it in puppet (varnish) etc [19:58:10] our logo is a png anyways [19:58:11] https://issue-tracker.miraheze.org/F747487 [19:59:38] oh we set something different in the DB? [19:59:52] https://issue-tracker.miraheze.org/F4422460 [20:00:03] so it is a svg after all [20:00:08] yeh seems to be SVG that does it [20:00:11] https://issue-tracker.miraheze.org/F4422460 [20:00:51] the only remedy i guess is you could hack varnish to remove the header [20:00:53] [1/2] can shrink down more if necessary [20:00:53] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1466161127799918876/Miraheze_pride_logo.png?ex=697bbc74&is=697a6af4&hm=55882ccbc4f23c93491a6dfdf5c0796f1bfaec6128615c5939f2362d4d0df1f2& [20:01:09] actually lemme do that to match the 80x80 of wmf [20:01:25] https://issue-tracker.miraheze.org/F5477937 [20:02:34] changed [20:02:39] https://issue-tracker.miraheze.org/T14862 [20:02:50] yay!!!!!! [20:03:12] yeah that size is fine actually [20:04:08] finally this pet peeve of mine is fixed lol