[00:38:16] [1/3] Something might need to be done to get some thumbnail generation jobs unstuck (e.g. https://static.wikitide.net/stellasorawiki/thumb/7/72/Disc_icon_Starlit_Hope.png/148px-Disc_icon_Starlit_Hope.png) [00:38:16] [2/3] > Error generating thumbnail [00:38:17] [3/3] > There have been too many recent failed attempts (4 or more) to render this thumbnail. Please try again later. [00:38:44] Also this [00:40:03] wiki was created in the backrooms [00:41:57] This is weird. I'm under the impression that thumbnails only get generated once upon upload, but apparently MW might have generated this one on-demand when I created a page that uses smaller versions of the icons during maintenance. [05:08:12] smaller versions are indeed generated on-demand [19:46:03] whenever a skin is updated, is there another security review on the changes, and approximately how long/often does it take for a skin to be updated [19:49:08] can't say anything about security reviews but skin updates usually vary. some older skins probably only get updated just to be compatible with the latest MediaWiki, whereas others like Citizen get new features frequently [19:49:38] skins are updated with version updates or on a as-screamed-at basis [19:50:34] no in-depth security reviews after the initial one [19:57:39] alr [19:57:51] yea i meant when mira updates them [19:58:06] cos im planning to create a custom skin for our wiki [19:58:19] which might need updating quite frequently [20:07:10] I always security review Citizen since there are usually a lot of changes compared to other skins. However that usually only takes me like 10 mins [20:08:24] in that case I'd probably review the changes if it's actively in development [20:09:33] alright [20:19:17] good luck with creating a custom skin. I'd hope that since most of your wiki's customisations are already done in JS it would just be a matter of making that happen on the initial page load. There are some people in this server who've created skins (e.g. Cosmos skin) so you can probably ask here if you need any help with it [20:19:25] (not that I would know anything about making a skin) [20:20:20] our current [Vector.js](https://forsaken.wiki/MediaWiki:Vector.js) is huge because we completely reorganise everything, especially on mobile [20:20:31] thanks tho [20:28:14] why do you actually want to create a skin? is there anything special you want to do on the PHP side? [20:28:32] if you want to load resources earlier, waiting for RenderBlocking to be installed might be faster [20:29:25] because on lower-powered devices our js takes a bit to load and if the page appears before it is loaded and evaluated the page appears broken for a second [20:29:33] and once it is evaluated theres CLS [20:29:55] we can also add a hook to LocalWiki to append things earlier to the page [20:30:32] i know but if u look at the js file it makes a lot of changes and doing that even with a hook feels hacky [20:30:56] i would rather we do the proper method, and we can do other patches and things that we have done or want to [20:31:50] alright [20:32:01] do you plan to fork an existing skin or write one from scratch? [20:32:07] fork vector [20:32:18] probably [20:33:54] im not sure if anyone else in the team knows php and i havent used it properly for years so could take a while [20:33:59] I guess that sounds feasible then, assuming you can devote enough time on this project and are aware that our extension review backlog is quite large [20:35:04] only 28 itll be fiiiine [20:35:07] Forking vector might need some PHP work if you want to get rid of Vector 2022 and all the bloat added by WMF [20:35:23] yeah thats fine [20:36:07] if your skin is based on vector it might not take as long as other reviews since it's probably fine to review the diff and not the full code [21:53:54] I'll learn PHP in like a year give me time