[18:48:04] <MirahezeRelay>	 <posix_memalign> [1/6] I've been thinking about forking FlowThread (a commenting extension) for a while. It was declined in https://issue-tracker.miraheze.org/T14323 due to the maintainer not fixing a security vulnerability in a timely manner. The maintainer seems to have lost interest in the project a long time ago, hence the thought of forking. Here's the plan:
[18:48:05] <MirahezeRelay>	 <posix_memalign> [2/6] 1. Ask someone more familiar with MW extensions on what things need to be improved (e.g. use `isset` instead of `in_array`, which CA mentioned a while back). Hopefully this is not as time-consuming as a review since it is meant to catch broader issues with how the extension is written.
[18:48:05] <MirahezeRelay>	 <posix_memalign> [3/6] 2. Fix the issues mentioned in 1.
[18:48:05] <MirahezeRelay>	 <posix_memalign> [4/6] 3. Add some more features to integrate with other MH extensions (e.g. UserProfileV2).
[18:48:06] <MirahezeRelay>	 <posix_memalign> [5/6] 4. Resubmit for review.
[18:48:06] <MirahezeRelay>	 <posix_memalign> [6/6] I'd like to know if this sounds like a reasonable plan. I'm also not sure how the security vulnerability would be handled in this case: we don't want to patch it in a public repository before upstream (with a lot more users) fixes it.
[18:53:01] <MirahezeRelay>	 <pixldev, replying to posix_memalign> seems the author did recently commit to it?
[18:58:50] <MirahezeRelay>	 <posix_memalign, replying to pixldev> RazeSoldier is not the original author. I think they got push access because they have been quite diligent in fixing compatibility issues.
[18:59:22] <MirahezeRelay>	 <posix_memalign> There was also a 2-year gap where no code was merged at all.
[19:11:37] <MirahezeRelay>	 <tmwyk> @posix_memalign i'd be happy to take a look if you want
[19:15:09] <MirahezeRelay>	 <tmwyk> forking seems reasonable to me
[20:06:41] <MirahezeRelay>	 <posix_memalign, replying to tmwyk> If you (or anyone else) have any thoughts about how the extension is written, feel free to send them here. I will collect them and carry out fixes if upstream continues to be unresponsive.
[20:07:22] <MirahezeRelay>	 <tmwyk> Alright, I have some time tomorrow to explore it
[20:08:40] <MirahezeRelay>	 <posix_memalign> [1/2] Also, CommentStreams seems to sort comments in ascending order of votes (instead of descending). I have a test comment downvoted once and it appears at the top. Meanwhile, the bottom comment has more upvotes than everything else.
[20:08:41] <MirahezeRelay>	 <posix_memalign> [2/2] https://strinova.org/wiki/Main_Page
[20:11:01] <MirahezeRelay>	 <posix_memalign> If I add this to Phorge I think we will end up with another patch on gerrit that is never reviewed, so I'll just leave it like that...
[20:19:55] <MirahezeRelay>	 <pskyechology, replying to posix_memalign> cant believe they tiktokified commentstreams (negative content elicits stronger reactions -> longer usage times)
[20:20:52] <MirahezeRelay>	 <tmwyk, replying to posix_memalign> (which gerrit?)
[20:21:57] <MirahezeRelay>	 <tmwyk> if it’s mediawiki/wikimedia’s gerrits I have +2 code review weight so I can pass and push
[20:22:15] <MirahezeRelay>	 <pskyechology> oh my god they're the chosen one
[20:22:31] <MirahezeRelay>	 <tmwyk> more like the project admin that was chosen to throw the trash out
[20:23:00] <MirahezeRelay>	 <pskyechology> we're gonna have so many patches for you to merge come extension testing season :3
[20:23:06] <MirahezeRelay>	 <tmwyk> yaaay
[20:23:29] <MirahezeRelay>	 <tmwyk> thank god I’ve put my calendar on public view on phab lol
[20:23:31] <MirahezeRelay>	 <pskyechology> (jk you can let them rot in gerrit we're gonna be sleeping during christmas anyway)
[20:23:55] <MirahezeRelay>	 <tmwyk> (no cause gerrit sends me patches for review digests every 2 days)
[20:48:36] <MirahezeRelay>	 <tmwyk> @posix_memalign alternatively, maybe you can alert the maintainer via email to the security vulerability, see if they respond
[20:58:02] <MirahezeRelay>	 <pixldev, replying to tmwyk> You have my sympathy
[20:58:55] <MirahezeRelay>	 <tmwyk, replying to pixldev> you know when you get a promotion but the actual workload of it is hidden until you're locked down with a contract?
[20:59:06] <MirahezeRelay>	 <tmwyk> same feeling
[20:59:57] <MirahezeRelay>	 <pixldev> Not quite fortunaletly (never come up in my part time job), and with volunteering, there's always the funny Alt F4 from discord option)
[21:00:00] <MirahezeRelay>	 <pixldev> but i get your point
[21:43:03] <MirahezeRelay>	 <thewwrnerdguy, replying to posix_memalign> [1/2] https://battlecats.miraheze.org/wiki/Cat_Dictionary
[21:43:03] <MirahezeRelay>	 <thewwrnerdguy, replying to posix_memalign> [2/2] Doesn't appear on the battle cats wiki...
[21:48:17] <MirahezeRelay>	 <thewwrnerdguy, replying to thewwrnerdguy> also does anyone know why this page takes SO LONG to load when I'm logged in
[21:50:19] <MirahezeRelay>	 <originalauthority, replying to thewwrnerdguy> Not particularly, no
[21:50:25] <MirahezeRelay>	 <originalauthority> Works almost instantly for me
[21:50:41] <MirahezeRelay>	 <thewwrnerdguy> works almost instantly for me when in private mode
[21:50:58] <MirahezeRelay>	 <originalauthority> Do you have some weird JS or CSS loaded
[21:52:20] <MirahezeRelay>	 <thewwrnerdguy> [1/2] no idea if I'm using this right (this is for the initial html download)
[21:52:20] <MirahezeRelay>	 <thewwrnerdguy> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1429950385879257128/image.png?ex=68f80093&is=68f6af13&hm=9e4c14767e9cfb523f86d80313fa2d75fdf20ddcc690d99789b42a700d815a80&
[21:52:27] <MirahezeRelay>	 <thewwrnerdguy> and it's not an issue I find on any other page
[21:52:57] <MirahezeRelay>	 <pskyechology> i have a feeling its because its getting ALL the comments
[21:53:03] <MirahezeRelay>	 <thewwrnerdguy> even https://battlecats.miraheze.org/wiki/Enemy_Dictionary loads reasonably quickly despite still being slow
[21:53:11] <MirahezeRelay>	 <thewwrnerdguy> yeah comments is the only thing I could think of
[21:53:37] <MirahezeRelay>	 <thewwrnerdguy> it has the most comments on the wiki I'm pretty sure
[21:53:48] <MirahezeRelay>	 <originalauthority, replying to pskyechology> Author hasn't heard of async clearly
[21:53:56] <MirahezeRelay>	 <pskyechology> isn't this commentstreams
[21:54:07] <MirahezeRelay>	 <pskyechology> y'know the cool extension that blue$pice took over
[21:54:20] <MirahezeRelay>	 <pskyechology> they really cooked with it huh
[21:54:54] <MirahezeRelay>	 <originalauthority> That kinda horrific that getting all the comments is taking 14 seconds anyway jesus
[22:09:25] <MirahezeRelay>	 <abaddriverlol, replying to posix_memalign> paladox did +2 two of my bug fixes for CS already, that's not the problem. the problem is only that some patched I made are feature changes, one of them refactors a lot of code, so I'd prefer having bluespice actually review it since only they fully know the codebase
[22:22:17] <MirahezeRelay>	 <abaddriverlol, replying to tmwyk> ah, cool, what kind of patches / in which repositories do you usually review?
[22:22:47] <MirahezeRelay>	 <tmwyk> being a chaotic code reviewer, pretty much any and every thing
[22:23:18] <MirahezeRelay>	 <tmwyk> whatever catches my eye I'm happy to review (or block)
[22:23:33] <MirahezeRelay>	 <abaddriverlol> nice, maybe you can try resubmitting <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/RelatedArticles/+/1154891> for me then because for some reason the gate pipeline build failed
[22:24:10] <MirahezeRelay>	 <tmwyk> looking into it right now
[22:25:37] <MirahezeRelay>	 <tmwyk> [1/14] ```shell
[22:25:38] <MirahezeRelay>	 <tmwyk> [2/14] 22:17:13         cy:command ✘  get    .ve-ui-mwSaveDialog .oo-ui-processDialog-actions-primary
[22:25:38] <MirahezeRelay>	 <tmwyk> [3/14] 22:17:13         cy:command ✘  assert    expected .ve-ui-mwSaveDialog .oo-ui-processDialog-actions-primary to be visible
[22:25:38] <MirahezeRelay>	 <tmwyk> [4/14] 22:17:13                       Actual:     ".ve-ui-mwSaveDialog .oo-ui-processDialog-actions-primary"
[22:25:38] <MirahezeRelay>	 <tmwyk> [5/14] 22:17:13                       Expected:     "visible"
[22:25:39] <MirahezeRelay>	 <tmwyk> [6/14] 22:17:13   2 passing (48s)
[22:25:39] <MirahezeRelay>	 <tmwyk> [7/14] 22:17:13   1 pending
[22:25:39] <MirahezeRelay>	 <tmwyk> [8/14] 22:17:13   1 failing
[22:25:40] <MirahezeRelay>	 <tmwyk> [9/14] 22:17:13 
[22:25:40] <MirahezeRelay>	 <tmwyk> [10/14] 22:17:13   1) Revise Tone
[22:25:40] <MirahezeRelay>	 <tmwyk> [11/14] 22:17:13        On mobile
[22:25:41] <MirahezeRelay>	 <tmwyk> [12/14] 22:17:13          Shows the Revise Tone Edit Check and tags edits:
[22:25:41] <MirahezeRelay>	 <tmwyk> [13/14] 22:17:13      AssertionError: Timed out retrying after 20000ms: Expected to find element: `.ve-ui-mwSaveDialog .oo-ui-processDialog-actions-primary`, but never found it.
[22:25:42] <MirahezeRelay>	 <tmwyk> [14/14] 22:17:13       at Context.eval (webpack://GrowthExperiments/./cypress/e2e/ReviseTone.cy.ts:116:72)```
[22:26:43] <MirahezeRelay>	 <abaddriverlol> yup, that's a flaky test per <https://phabricator.wikimedia.org/T407152#11274845>, so it needs to be resubmitted (which I can't do since I don't have +2 rights)