[05:09:38] [1/3] @.labster [05:09:38] [2/3] https://github.com/labster/HideSection/pull/6 [05:09:38] [3/3] Or I can fork it to gerrit if you'd rather also... [05:14:22] <.labster> First time I saw it, easy merge. [05:14:51] thanks [05:15:15] Just didn't know if you wanted to maintain it or wanted me to fork it lol [05:15:37] Same for https://github.com/labster/HighlightLinksInCategory/pull/12 btq [05:18:33] <.labster> I wish GitHub had a way to see all open PRs on all my repos [05:22:34] https://github.com/search?q=is%3Apr+user%3Alabster+is%3Aopen&type=pullrequests [05:22:55] yw ^_^ [05:23:34] would be nice to be able to in alerts though lol [05:23:43] true [05:23:44] https://github.com/pulls [05:23:52] oh wait [05:23:55] nvm, i misread it [05:24:29] just set yourself as the global codeowner of your repos so you get notified on all repos [05:24:45] or the bazillion other ways [05:24:55] emeow [05:25:03] [1/2] lol yeah mattermost can give you that information too lol [05:25:04] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1396362249496559748/Screenshot_20250719_232231_Mattermost_Beta.png?ex=687dcf2f&is=687c7daf&hm=4989305eeb35cb17f1f34705dad8c5973964f0e581a33672da5c932f9f108e48& [05:25:16] wtf?? [05:26:33] If you link your github to mattermost. [05:27:55] FYI all I plan to have all the priority extensions fully tested by Monday at that point we will launch the nexttide program (if we are ready) [05:28:16] CC @pskyechology @posix_memalign @abaddriverlol [05:28:22] oh [05:28:29] sooo, by tomorrow? [05:28:45] might be saturday for your still, in which case overmorrow [05:29:05] I guess depending on timezone. Basically will test everything urgent remaining tomorrow (like CentralNotice is one) [05:29:28] All global and very high use extensions that is. [05:29:37] GlobalBlocking is another. [05:30:09] {to,over}morrow [05:30:43] It would kinda be cool to start it Tuesday on our (MHs) birthday lol [05:32:11] The program has never been done before but its been planned for a very long time. [05:33:17] I think next time we should have the global ones at the top in bold lol [05:33:27] lowkey have been testing everything but those [05:33:33] nexttide! [05:36:05] Yep maybe [05:36:59] Anyway I will finish testing any remaining global ones + default ones + top in popularity (if they aren't already) tomorrow at that point we can launch nexttide. [05:37:56] Any extension still proven broken at that point will have something added in config to disable only on 1.44 until fixed also. [05:38:28] So that wikis dont enable one after they opt in to the program and make their site inaccessible. [05:39:10] Only if they are totally broken though as in fatal everything, including ManageWiki so cant revert themselves probably. [05:40:11] I forgot about IPInfo how do you even text that one lol. I've never even used it... [05:40:35] i cant help but read it as i pee info 😭 [05:40:37] unfortunate name [05:43:53] and I just realized I said text it. I definitely dont know how to text an extension for sure lol [05:44:28] the one time i was actually able to infer the true meaning from context [05:44:55] you would not believe how often i will blindly listen to incorrect (from spoken/typed mistakes) instructions [05:44:58] new apple product let's gooo [05:45:03] LMAO [05:54:32] @.labster any objection if I move JavascriptSlideshow to gerrit? Trying to reduce what we actually have to deal with in our own repos lol [05:54:48] <.labster> None at all [05:55:19] <.labster> I wouldn’t mind having +2 on something, though [05:55:42] Ill give you +2 on it post-import [05:56:23] <.labster> Do we have a miraheze org on Gerrit? [05:59:10] idts [06:02:53] No but we really should since we will be using it more going forward. Especially for any forks we make from non-gerrit repos we will move to gerrit. I've moved all my own forks over there except DPL and PortableInfobox also. Which I may also move eventually... or at least probably PortableInfobox... [06:03:09] 7 repos over the last few days. [06:03:47] Im moving MachineTranslation also since I just randomly made it for some reason but we dont even use it at Miraheze lol [06:04:27] <.labster> Gerrit is nice for collaboration, once you get used to the interface. [06:04:43] yeah took me 5 years but I finally got more used to it lol [06:05:10] <.labster> It’s kind of like vim, I guess [06:06:37] Also I want to evaluate if we can decom our forks of YouTube and PDFEmbed. YouTube can probably be decommed in favor of EmbedVideo though. [06:08:00] PDFEmbed there is https://gerrit.wikimedia.org/r/q/repo:mediawiki/extensions/PDFEmbed so I'm not sure if we need our fork.... [06:11:41] @pskyechology thoughts about getting rid of the YouTube extension with the MediaWiki 1.44 upgrade in favor of it being replaced with EmbedVideo? (just curious about thoughts) [06:12:42] EmbedVideo is more privacy based as well so its just a better extension and more secure too. [06:13:19] CC @rhinosf1 @blankeclair also ^ [06:13:59] embedvideo does more than just youtube and is better maintained, I'm all for it [06:14:07] Indeed. [06:17:02] does EV have a back compat feature i wonder? [06:17:49] Im not sure. [06:17:54] let me check [06:19:50] [1/2] well... it won't work anyway lol [06:19:51] [2/2] [06:20:06] bruh moment [06:20:34] sigh [06:20:50] https://github.com/StarCitizenWiki/mediawiki-extensions-EmbedVideo/pull/128 [06:21:25] [1/2] looks like it does have a YouTube hook though from [06:21:26] [2/2] https://github.com/StarCitizenWiki/mediawiki-extensions-EmbedVideo/blob/5c0f542d29c59fe57b020868093d38e99c3bc95b/includes/EmbedVideoHooks.php#L158 [06:21:39] so it should be completely compatible [06:22:03] sgtm then [06:22:13] maybe automatically change the exts too [06:22:38] We could yeah. [06:23:36] Why did they remove class aliases breaking back compat completely for versions that are still supported (1.39)... that PR just reminded me that lol... [06:24:42] this whole process has been a pain, especially with everything that wishes to maintain compatibility [06:25:11] fym backwards compatible if you dont even forwards compatible [06:26:18] and we have the joy of doing it even more in 1.45 :3 [06:27:35] we will likely have more to deal with in 1.41. Like Config and other Config, Pager, SpecialPage and similar classes... [06:27:40] https://github.com/search?q=repo%3Awikimedia%2Fmediawiki%20%22%40deprecated%20class%20alias%20since%201.41%22&type=code [06:28:03] https://github.com/search?q=repo%3Awikimedia%2Fmediawiki%20%22%40deprecated%20class%20alias%20since%201.41%22&type=code [06:28:13] yup, that's waiting for us in 1.45 [06:28:26] meant to click remove embed and accidentally deleted the message lol [06:28:33] lmao happens [06:28:54] the dehoustonification of mediawiki [06:30:14] Oh the User class also. Which some of these are probably just as used if not more so then Title [06:30:15] [1/2] personally i like the little X instead of digging in the menu somewhere tho [06:30:15] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1396378654392586311/image.png?ex=687dde76&is=687c8cf6&hm=74887a101902e2812b3b8067c2b28b8d63cc3c1aca684ee258316ae8be66ec4b& [06:30:25] buuut you''re on mobile [06:30:34] Im on mobile so its right above the delete button lll [06:30:54] me putting the test nuke button next to the nuke everyone button [06:31:33] Sanitizer too is another pretty heavily used one on some extensions. [06:33:02] User and Title are probably the biggest two though [06:34:19] HtmlForm and Parser in 1.46 probably [06:34:54] oh Config, especially GlobalVarConfig will be fun [06:35:07] idk could've just ripped it off like a bandaid if you ask me [06:35:59] Since that needs changes to extension.json it is missed a lot and nothing like phan picks up on it.... [06:36:15] and almost every single extension uses it these days. [06:36:23] if they have configs they use it [06:36:23] ohh that'll be juicy [06:37:00] I wouldnt be surprised if they skip purging that alias in 1.45 but we'll see.... [06:37:17] Its not even fixed on all WMF deployed repos yet... [06:37:58] [06:38:09] not even fixed on CentralAuth lol [06:39:45] I guess the WMF could just add a check to if using GlobalVarConfig there overwrite it to use the namespaced class in ExtensionProccessor.... [06:44:10] hawaii emergency alert system [06:44:42] you get it :3 [06:45:08] [1/2] nahhh [06:45:08] [2/2] fucks over everyone else as usual [06:46:26] if they remove that one its going to be the worst one yet and will be since 1.49-1.50 (when LogEntry and related are removed) if they keep that schedule [06:47:01] even then its still probably the largest most use and most breaking changes will be GlobalVarConfig. [06:47:21] I guess we'll see if they'll remove it in 1.45 [06:47:21] tempted to bet that they'll fuck everyone else anyway lol [06:48:16] I doubt it since they havent even begun to switch their own deployed extensions to namespaced GlobalVarConfig lol but there's still time... [06:48:28] future bet :p [06:50:27] https://phabricator.wikimedia.org/T156646 interesting lol [06:50:44] https://phabricator.wikimedia.org/T155154 [06:51:14] oh? how though [06:52:11] seems they want to deprecate GlobalVarConfig and getConfig completely [06:52:20] yeah but like [06:52:26] how'd they populate GlobalVarConfig [06:52:27] wait [06:52:30] how do you get the HashConfig?? [06:54:00] I used HashConfig with new DPL4 in order to use like `$this->config->get( 'maxCategoryCount' )` where this->config is just Config::getInstance() HashConfig is populated from the $wgDplSettings global. What they want to do is just have a service you have to use DI with rather than getting it from RequestContext. [06:54:14] oh [06:55:58] I actually used MultiConfig which mixed hasconfig and GlobalVarConfig for wg access to also at the same time be able to access mediawiki core globals rather than having 2 seperate Config objects for it lol. So I used MultiConfig with both HashConfig and GlobalVarConfig. [06:56:55] https://github.com/Universal-Omega/DynamicPageList3/blob/pre-release/includes/Config.php [07:02:46] vs the old version lol https://github.com/Universal-Omega/DynamicPageList3/blob/main/includes/Config.php [08:28:22] [1/5] Some problematic popular extensions (close to 300 installs on public wikis): [08:28:23] [2/5] 1. Known to be broken: `EmbedVideo`, `CreatePage`, `Math`, `SimpleBatchUpload`, `FontAwesome`, `CommentStreams`, `EmbedSpotify`, `SimpleChanges` [08:28:23] [3/5] 2. Untested: `PageForms`, `MediaSpoiler`, `PDFEmbed`, `PageNotice`, `PagedTiffHandler`, `Translate` [08:28:23] [4/5] 3. Not broken but missing functionality: `ProtectSite`, `3D`, `DynamicSidebar` [08:28:23] [5/5] I can test the ones in 2 tomorrow. [08:29:28] the known to be broken ones will not block nexttide deployment it will just be made clear to wikis who opt in to it. [08:38:59] I see. I think I marked every untested global/default extension on T13645. I would assume they are working fine, though, since mirabeta is still up and running. [08:39:31] probably lol. At least they dont fatal every page. [09:08:25] i did it [09:24:38] TBH DPL3/4 worries me the most with its complexity as well as the lack of test coverage. Maybe I'll try use some of its features on wikis I administer to learn what it can do... [09:26:02] I've been testing that extension extremely well. [09:26:21] dpl3wiki is already on 1.44 [09:26:44] running DPL4 [09:29:19] yes dpl3wiki is running DPL4 lol [09:32:13] Anyway I'm going to sleep