[17:55:56] visualeditor does not load. clicking the Edit tab will trigger it to show the progress bar, and then it quits and the editor does not appear. error in the browser console looks like this: https://termbin.com/q6ka [17:56:34] my deployment system is pulling mediawiki and extensions from github, and initializing submodules with --recursive. it looks like its pulling the ve submodule within the ve extension the way its supposed to, and i can see files in the extension directory: https://termbin.com/2mba [17:56:50] i feel like ive seen this before, and i can't remember how i fixed it [18:02:23] the relevant part of .gitmodules looks like this https://termbin.com/58fk and the mediawiki is https://hub.docker.com/_/mediawiki/ tag 1.43 [18:03:29] i don't know if i need to pin the ve module inside of the VisualEditor repo or something else [18:03:40] but it looks like the module's files are being deployed [18:05:14] i think the extension has the corresponding REL1_43 branch specified within it https://github.com/wikimedia/mediawiki-extensions-VisualEditor/tree/REL1_43/lib [20:26:18] interestingly the link there "ve @ f5b79fe" returns a 404 https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/REL1_43/lib/ve [20:28:07] im guessing thats normal [20:34:10] probably because the .gitmodules entry is not on github [20:37:14] i think that's just github's poor handling of submodules not hosted on github\ [20:51:37] yea the broken link on github probably isn't the issue [21:01:03] What does your browser console say, for example? [21:23:20] Reedy: https://termbin.com/q6ka looks like this [21:23:58] type error exception in visualEditor.core it looks like [21:24:31] It doesn't look like you're running the REL1_43 version of VE [21:24:58] interesting. let me see if i can check out the repo manually so as to pin the branch [21:25:02] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1167679/2/extension.json is in REL1_45+ [21:25:36] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/REL1_43/extension.json doesn't reference ve.dm.DomFromModelConverter [21:26:49] ah this is the extension version. let me see why that might be happening, that would be strange given my .gitmodules file [21:27:10] ie: extension versus the ve module that gets checked out inside it as a submodule [22:46:25] looks like composer install is being blocked by https://github.com/advisories/GHSA-vvj3-c3rp-c85p that's always fun [22:53:37] Don't use composer 2.9 [22:58:31] Reedy: currently im grabbing https://getcomposer.org/installer with container image build is there a better way [22:59:48] it would be good to not deploy the site with --no-security-blocking [23:12:06] Ideally you wouldn't be installing dev dependancies for production, but I'm not sure whther composer blocks it regardless [23:12:25] yeah im using install --no-dev also [23:12:42] regarding my VE problem, it looks like VE is the correct version? im seeing "requires": { "MediaWiki": ">= 1.43" }, in the extensions.json [23:13:01] the master branch would have>= 1.46 on this line [23:14:13] purging cache from browser and skipping it at edge, purging from edge anyway [23:19:52] but it looks like the /lib/ve submodule is not the correct branch, maybe because there's no branch specified here? https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/REL1_43/.gitmodules [23:22:18] where is the logic for the /lib/ve module branch selection supposed to be [23:26:02] It tracks a commit https://github.com/wikimedia/mediawiki-extensions-VisualEditor/tree/REL1_43/lib [23:26:07] hence ve @ f5b79fe [23:42:15] thanks Reedy