[13:44:17] oh! [13:44:46] With MW 1.41 I get: [13:44:49] https://www.irccloud.com/pastebin/4Pn56zYJ/ [13:45:10] On MW 1.42 I get: [mNamespaceIds:protected] => [13:45:12] (empty) [13:45:24] this is using \MediaWiki\MediaWikiServices::getInstance()->getContentLanguage() [13:45:40] Whilst I get: [13:45:43] https://www.irccloud.com/pastebin/QjJf6Xtu/ [13:45:51] On both MW 1.42/MW 1.41 [18:48:44] I found something interesting [18:49:30] $this->language in https://github.com/wikimedia/mediawiki/blob/master/includes/title/MediaWikiTitleCodec.php doesn't seem to be getting the ContentLanguage we set where as when I use \MediaWiki\MediaWikiServices::getInstance()->getContentLanguage()->getNamespaceIds() directly it works. [19:12:59] paladox: setting wgContLang so late is not going to work for services already created [19:16:00] paladox: https://gerrit.wikimedia.org/g/mediawiki/core/+/94d4c10b2c9eb9696698c79d29291f35bd1cbc16/tests/phpunit/MediaWikiIntegrationTestCase.php#1468 has a tip, or call resetServices or resetServiceForTesting directly [19:23:54] Nikerabbit: ohh? https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/a3fa98cb6250814f52f020a7895ba7578e20074c/tests/phpunit/JSONScriptTestCaseRunner.php#L151 is what we do now. [19:33:41] not sure where to put that or do it [20:11:25] oh doing: [20:11:28] https://www.irccloud.com/pastebin/HTnYNtOA/ [20:11:33] in there appears to fix it? [20:15:58] seems brittle, maybe just reset all services instead? [20:20:14] Nikerabbit: reset all services? Inside that callback? Also how'd I do that? [20:21:47] MediaWikiTestCase::resetServices() [20:22:06] Depending on your test class inheritance tree.. [20:26:15] oh thanks! [20:27:58] I'm not sure I can use resetServices as we don't call any of the functions in there that sets a service. [20:38:23] oh I only needed: [20:38:24] ``` [20:38:28] https://www.irccloud.com/pastebin/PVIAfNpr/ [21:54:47] seems to be in line with the suspicion I had yesterday :D