[11:02:16] Hey. I'm looking for some feedback on https://phabricator.wikimedia.org/T421954 -> for the Attribution API I need to define a short name that currently is not present. I also see that our configs are all over place ( we have like at least four configs - RightsPage, RightsUrl, RightsText and even wgRightsIcon that most likely is not used. [11:02:16] the option is or to introduce a new config `wgRightsShort` or comeup with some mapping - but IMHO we could merge all those config variables into one. The only concerning thing is the `wgRightsUrl` which is in `@replaceableSettings` ( https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/2a1d8792d15ad0a38af3167eb0293808973027af/wmf-config/InitialiseSettings.php#45 ) [19:02:50] Is there any chance we could backport the deprecation of the EditFilter hook (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1281874) to 1.46, or is it too late for that? I just realized that we wouldn't be able to use the new PageEdit class outside of EditPage (e.g. ApiEditPage or VE) otherwise in 1.47, as the EditFilter hook requires an EditPage instance, and not calling it for edits might be a security risk if third party code [19:02:51] relies on it [19:03:32] (it would need to be backported so it can be removed in 1.47) [19:07:03] it [19:07:06] it's not too late [19:07:58] SomeRandomDev: you can just prepare the patch to move the release note to 1.46, and the backport patch, and i'll merge them [19:08:35] Or ping me if MatmaRex is somehow not responding within seconds. :-) [19:08:35] MatmaRex: thanks, will do that [19:33:10] James_F: while you're here, question about https://phabricator.wikimedia.org/T261462#11773201 … is it fair to say that if it works, and the only problem is PHP deprecation warnings, then that's okay? [19:45:08] also, OAuth is not even bundled, so i'm not sure why we care [19:51:37] MatmaRex: Yes, and yes. I think we care because of the core changes to make OAuth go. [19:53:40] oh… i saw that league/oauth2-server is not in REL1_xx mediawiki/vendor, so i thought it doesn't matter, but some of the other dependencies are included there [19:55:01] okay, i guess i'll just have to test if it works… [20:02:26] yeah we were able to remove it but I don't know what else is still hanging around in there