[14:43:32] ori: looking at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1220661/2/includes/Config/SiteConfiguration.php, I wonder if you’d be interested in benchmarking array_key_exists() vs. \array_key_exists()? [14:43:46] (I’m guessing that you already have a good setup to benchmark MW whereas I don’t ^^) [14:44:30] It would be good to have a policy on that and/or having use statements for these global functions... [14:44:52] Didn't Tim have a benchmark for this at one point? [14:44:54] yeah I’ve been wondering about that in the back of my head for a while, but performance numbers on it would be a much better argument [14:48:04] (for reference, https://github.com/php/php-src/commit/f5044a12dd and https://github.com/php/php-src/commit/0bbfebb6d9, via https://github.com/php/php-src/pull/3360, are the optimizations that could benefit from knowing that array_key_exists() isn’t a function in MediaWiki\Config\ or MediaWiki\) [14:49:24] Reedy: I can’t find anything on Phabricator at least (but it doesn’t help with the search that “namespace” is a very overloaded word) [14:49:42] I can't remember if it was in a library... [14:49:51] Similarly searching for global functions isn't helpful either :D [14:53:56] do we still sometimes load it from a symfony polyfill or is that old enough to be in all the versions we support? [14:54:47] array_key_exists [14:54:47] (PHP 4 >= 4.0.7, PHP 5, PHP 7, PHP 8) [16:49:51] Lucas_WMDE: that's so interesting, thanks for flagging it! Busy week at work but I'll try to benchmark it in the next couple of days. Please poke me if you don't hear back.