[18:50:25] <Reedy>	 if someone fancies doing some CR to help clean up some deprecated/warning logspam on PHP 8.5
[18:50:34] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/1211198https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1211199
[18:50:39] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1211199
[18:50:47] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1211135
[20:14:50] <Krinkle>	 taavi: I can't seem to find any record of codesearch having run out of space before, followed by an increase in disk space.
[20:15:23] <Krinkle>	 each past task was about something else. I've updated the T411047 desc just now.
[20:15:23] <stashbot>	 T411047: "error: No space left on device" for codesearch9:/srv - https://phabricator.wikimedia.org/T411047
[20:15:29] <Krinkle>	 haven't we like bumped it a few times in the past?
[20:15:41] <Reedy>	 lots and lots of small files...
[20:16:03] <Krinkle>	 yeah, but at 11G free, it's probably a good idea to also actually increase space
[20:16:34] <Krinkle>	 but yeah we could squeeze a bit more if we find whereever it changes the inodes. probalby something we overrode in the past via puppet?
[20:19:55] <Krinkle>	 https://sal.toolforge.org/log/AWHkdPJWkkJ8OkTwiKCs
[20:20:11] <Krinkle>	 I guess it's not puppetised then and lost since
[20:38:50] <bvibber>	 So I'm cleaning up Popups to get it to obey wgThumbnailSteps and I really want some common logic here ;) i'm trying by copying the thumbnail width stepping logic from File into an mw.util helper for client-side extension code to use in common. Any thoughts on this patch? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1211230
[20:39:26] <bvibber>	 we're hoping to get it out in a hurry as the weird-size thumbnails are eating up logs of folks trying to look for other sources of trouble ;)
[20:40:35] <bvibber>	 if putting it in mw.util is too much i could break it out into another module, but i feel like it's gonna get used so widely as we clean up front-end code it's worth stuffing it in mw.util
[20:41:19] <Krinkle>	 CR'ed
[20:41:37] <bvibber>	 tx
[20:41:38] <Krinkle>	 We have other thumb url parsing code there already. seems fine
[20:43:36] <bvibber>	 *nod* yeah, cross reference and a qunit test should do it :D
[22:05:48] <bvibber>	 woot the qunit test replicating the phpunit test _appears_ to work in ci :D
[22:07:53] <Krinkle>	 Or Special:JavaScripTest?filter=mediawiki.util  locally :)
[22:45:09] <bvibber>	 ok, that last tweak should make the linter happy ;)
[23:10:56] <Krinkle>	 Landing..
[23:13:22] <bvibber>	 \o/
[23:13:24] <bvibber>	 thx
[23:13:32] <bvibber>	 your addl tests look good :D
[23:15:01] <bvibber>	 any objection to me +2ing the followup tests in core or is that too self-dealing ;)
[23:22:17] <Krinkle>	 go ahead, assuming the rest of CI passes
[23:22:55] <ori>	 Krinkle: you're on Hacker News :P
[23:25:19] <bvibber>	 just waiting for selenium :D
[23:30:41] <Krinkle>	 thx. https://news.ycombinator.com/item?id=46047958