[20:06:59] DannyS712: do you not have +2 in extensions/ChessBrowser? Or you purposefully want Wugapodes to approve all changes in that repo? [20:07:06] *Or do you [20:34:51] ori I have +2 both for that extension and for mediawiki/* generally, but I wanted to give Wugapodes a chance to see the patch [21:16:51] * ori nods [21:30:49] DannyS712: IMO, for code clean-ups we can just go right ahead [21:31:42] never mind if it made it onto WMF production... we can and will make changes as necessary :P [21:32:03] plus it's in git, Wugapodes is CC'd, etc. [21:39:44] noted. I also sent a patch for adding chessbrowser to patchdemo to make it easier to test. I'm doing another review of the namespacing now and will probably +2 [21:40:09] what's patchdemo? [21:40:38] https://patchdemo.wmflabs.org/ create a wiki based on the results *after* a patch is applied, to be able to easily test it [21:40:49] oooooooooh this is fancy [21:41:44] yeah, its a real lifesaver [21:41:59] it's not like installing that extension is difficult though :P [21:42:28] no, its not at all (though you then need to add example chess boards, which patchdemo should probably do automatically...) [21:43:34] https://www.mediawiki.org/wiki/Extension:ChessBrowser/Test_games [21:43:50] https://stackoverflow.blog/2021/03/31/the-key-copy-paste/ [21:44:02] yup, I'm saying patchdemo has functionality somewhere to automatically add those [21:44:22] but again, that's really not difficult