[00:03:46] Reedy: hey, thanks for the note about compile-font-repo.php [00:03:56] np :) [00:04:08] I'm trying to run it, seems like you need to embed UniversalLanguageSelector in a mediawiki install in the extensions folder [00:04:30] but still not getting it to work, I get: Class 'FontRepoCompiler' not found [00:04:35] Yeah, it's a MW maintenance script, so the extension needs to be part of your install [00:04:42] So then the autoloader can do its magic in the background [00:04:43] it's in the includes dir for the extension [00:04:54] ok... am I running it from the wrong dir or something? [00:05:15] Have you got wfLoadExtension( 'UniversalLanguageSelector' ); in your LocalSettings.php? [00:05:20] ah no. I'll do that [00:05:46] cool it seems to have worked now [00:06:17] if the script was standalone, you wouldn't need it, but as it refers to another class inside, MW needs to load it to know to autoload the various classes [00:06:29] hrm... weirdly it seems to have changed the hash for a different font [00:06:35] that I didn't do anything to [00:07:11] It's possible someone forgot to run it first [00:07:12] let me try [00:07:27] Padauk is the font [00:07:50] anyway, assuming this is ok, what do I do in order to commit the new change and make sure it's in the same patch set / review? [00:08:00] I know git but not gerrit [00:08:36] As far as gerrit is concerned, and the branch doesn't change... as long as the change-id is the same, it's the same [00:08:50] Yeah, I see the same behaviour [00:09:09] So... a few options here [00:09:24] I mean, I can add -p and exclude it [00:09:35] one, make a commit under your commit that commits these changes that aren't yours. And then put your commit ontop and re-run the script to include your options [00:09:50] two, I make that commit (but I won't self merge it) and you can cherry pick ontop/rebase when it's merged [00:10:12] I'd rather just commit my own stuff, doesn't that make more sense? [00:10:34] Someone has to fix it ;) [00:10:41] well yes [00:10:42] And there's nothing wrong with keeping that out of your commit [00:11:00] As there's no actual full file hash or anything... [00:11:06] I didn't mean you shouldn't, just that I'd rather commit my changes and let you or whoever fix it after or in some way that doesn't interfere [00:11:07] You could just revert those specific lines, indeed [00:11:20] Two different commits wouldn't interfere [00:12:21] so in the initial stuff I did "git review" to send to gerrit, what do I do now after commit? [00:12:30] it seems there is no git push needed [00:12:41] make the changes, amend, run git review again [00:12:45] ah ok [00:12:55] yes, I see that now in the summary [00:13:23] I'll make the change to make the repo consistent if you want? [00:14:10] yes, that's fine [00:14:19] I just amended my commit (without changing Padauk) [00:15:18] if I want to add a comment on gerrit (not in commit line) that the new patch set includes compile-font-repo.php, should I click the "reply" button in the web interface? [00:16:02] Yeah [00:18:30] ok, done [00:18:53] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UniversalLanguageSelector/+/577691/2/resources/js/ext.uls.webfonts.repository.js [00:19:00] Still has the Padauk changes [00:19:12] oh weird [00:19:21] ahh maybe it was the --all that did it [00:19:27] must have been [00:20:28] urgh [00:23:09] fixed it, I think [00:25:05] That looks better, yeah [00:51:15] Reedy: do you have info on input methods somewhere and how they work? [00:51:51] ok, jquery.ime apparently [00:54:01] Yeah, I think so [01:41:46] ok I see, there's support for alt and shift modifiers, and for context [01:45:11] going to be a royal pain to adapt the keyman stuff though