[13:36:27] Is the lock icon loaded in resource loader if I do $out->enableOOUI() ? [13:36:44] It isn't working for me... [13:41:53] do you mean in JS or PHP? [13:44:25] sorry, forget my last word. [13:44:37] $out->enableOOUI() loads 'oojs-ui-core.styles', 'oojs-ui.styles.indicators', 'mediawiki.widgets.styles' and 'oojs-ui-core.icons' [13:52:55] Okay... how do I know which icons are in which bundle ? [13:53:25] Could you try `$out->addModuleStyles( [ 'oojs-ui.styles.icons-moderation' ] );`? but I not sure... [13:54:04] Ah... thanks [13:54:15] That worked.. :) [13:55:28] I has searched in codes and found https://github.com/wikimedia/oojs-ui/blob/c9d3a6d/demos/pages/icons.js#L78 [13:55:30] and https://github.com/wikimedia/mediawiki/blob/c656980/resources/Resources.php#L2978-L2981 [13:55:58] :) [15:00:20] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:50:18] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:52:34] Hi, I've got a quick question before the Technical Advice IRC meeting starts: I uploaded new patch sets to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/549127 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/544296, yet Jenkins does not seem to activate and none of the changes show up on [15:52:35] https://integration.wikimedia.org/zuul/. Is something broken? For the CirrusSearch change, Cindy-the-browser-test-bot did run however. [15:54:09] mainframe98: lemme check, (and thanks for working on this by the way! :) [16:04:54] aren’t there any hosts? I have a question [16:05:07] it should have started [16:05:17] its 5 [16:05:24] i mean 4 [16:05:27] UTC [16:05:58] Pining @wm-bot [16:06:07] wm-bot doesn't announce the beginning [16:06:24] Nobody is listed on https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [16:06:25] I don't know if we have any hosts today, but if you have a question, feel free to ask [16:08:43] ok, thanks. I hope to know how manage Phan to include vendor dependencies in a correct way. [16:09:17] I am working on a task: https://phabricator.wikimedia.org/T237609 [16:12:53] when I executed Phan on my system, it seems to be only analyse `${MW_INSTALL_PATH}/vendor` even though my patch require vendor of the extension. [16:17:58] is Phabricator the better place to ask my question? [16:27:37] had to restart my computer [17:00:48] I have another question, it is simpler. [17:01:15] is `recheck` only permitted for users who have a right? [17:01:27] (in gerrit) [17:04:30] I think it’s allowed for the same people whose changes also get checked automatically on upload? [17:04:33] i. e. whitelisted ones [17:04:51] https://www.mediawiki.org/wiki/Continuous_integration/Whitelist [17:05:58] oh, I see, thank you! [17:06:27] Yup, the bot will only listen to whitelisted users