[12:32:40] <bblack>	 Does anyone here have a contact (or is the contact) for Wikiwix (wiki search service hosted at CRIHAN) ?
[15:00:24] <wm-bot>	 Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
[15:07:51] <Lucas_WMDE>	 (no WMF host yet)
[15:46:52] <Nemo_bis>	 bblack: we used to have contacts with Linterweb/Pascal Martin over ten years ago, not sure nowadays
[15:48:23] <bblack>	 we found his talk page on frwiki, he's been in active this past year or so, so I think we can find him :)
[15:48:26] <bblack>	 thanks though
[15:48:35] <Nemo_bis>	 oki
[15:50:22] <wm-bot>	 Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
[16:00:31] <Lucas_WMDE>	 Okay, welcome to the Technical Advice IRC Meeting! :)
[16:00:41] <apergos>	 \o/
[16:00:48] <Lucas_WMDE>	 we don’t have any pre-scheduled topics, so fire away if you have questions ^^
[16:00:57] <Lucas_WMDE>	 (preferably technical ones ;) )
[16:09:09] <apergos>	 sorry, I have no questions to fill the void :-D
[16:12:45] <MishMoshKeel21>	 Hi
[16:12:52] <Lucas_WMDE>	 hi!
[16:13:02] <fnielsen63>	 I wonder if this channel is the correct to pose a question on ssh login to Wikimedia?
[16:13:55] <fnielsen63>	 I have a ssh-key on the Wikimedia system and I can login to Toolforge with ssh. Now I am trying to host and clone repos. I am trying to set up my own but failing when trying to push. I have tried to ssh-clone another repo: "git clone ssh://vcs@git-ssh.wikimedia.org/source/tool-speedpatrolling.git". I get the same error "vcs@git-ssh.wikimedia.org:
[16:13:55] <Lucas_WMDE>	 I think in general that would be something for #wikimedia-cloud, but during TAIM it fits here, sure
[16:13:56] <fnielsen63>	 Permission denied (publickey,keyboard-interactive).
[16:14:27] <Lucas_WMDE>	 I think for that you need to set up your SSH key in Phabricator
[16:14:37] <Lucas_WMDE>	 IIRC that’s completely independent from the Toolforge / Cloud VPS SSH access
[16:14:40] <Lucas_WMDE>	 let me check
[16:15:05] <Lucas_WMDE>	 yeah, I use different SSH keys for them
[16:15:35] <fnielsen63>	 I think I have found the settings
[16:15:39] <Lucas_WMDE>	 https://phabricator.wikimedia.org/settings/user/Fnielsen/page/ssh/
[16:15:57] <Lucas_WMDE>	 (you can use the same SSH key, of course)
[16:16:18] <fnielsen63>	 Yes, the same I am looking at 
[16:16:19] <hauskater>	 well, if we're still in time, I'd like to ask a question once you're free
[16:16:58] <Lucas_WMDE>	 MishMoshKeel21: did you have a question?
[16:17:28] <MishMoshKeel21>	 Just curious...
[16:19:22] <Lucas_WMDE>	 ok
[16:19:29] <Lucas_WMDE>	 hauskater: I think you can go ahead
[16:19:37] <fnielsen63>	 Thanks for the ssh help
[16:19:42] <Lucas_WMDE>	 did it work?
[16:19:49] <fnielsen63>	 yes
[16:19:51] <Lucas_WMDE>	 yay
[16:20:39] <hauskater>	 Lucas_WMDE: Well, good afternoon for starters :)
[16:20:56] <hauskater>	 I'd like to inquire re T238202
[16:20:56] <stashbot>	 T238202: Message "apihelp-blogpage-param-pageName" should be in lowercase - https://phabricator.wikimedia.org/T238202
[16:21:19] <hauskater>	 I guess I not only need to change the messages in the i18n folders
[16:21:35] <hauskater>	 but also the instances where such messages are used in the PHP code, right?
[16:21:42] <Lucas_WMDE>	 yes
[16:21:50] <hauskater>	 So I did a "git grep <message here>" but found none
[16:21:50] <Lucas_WMDE>	 and also move the translation pages on translatewiki, I think
[16:21:59] <Lucas_WMDE>	 oh wait
[16:22:03] <hauskater>	 so I'm a bit confused as to how to proceed
[16:22:09] <hauskater>	 BlogPage does not use twn yet
[16:22:15] <Lucas_WMDE>	 ok
[16:22:22] <Lucas_WMDE>	 oh, but this is an apihelp message
[16:22:34] <Lucas_WMDE>	 those typically aren’t accessed directly in PHP
[16:22:38] <hauskater>	 yeah, I'm a bit confused
[16:22:44] <Lucas_WMDE>	 the API framework uses them to describe parameters
[16:23:02] <Lucas_WMDE>	 so you probably declare a pageName parameter in the getAllowedParameters() of the blogpage module?
[16:23:27] <Lucas_WMDE>	 and you’d see the message contents e. g. in the API sandbox and in ?action=help&modules=blogpage
[16:23:32] <Lucas_WMDE>	 (not sure if it’s module or modules for the latter one)
[16:23:53] <Lucas_WMDE>	 (oh, and getAllowedParams(), not getAllowedParameters())
[16:23:54] <hauskater>	 I see $pageName = $params['pageName'];
[16:24:46] <Lucas_WMDE>	 ok, here it is https://gerrit.wikimedia.org/g/mediawiki/extensions/BlogPage/+/3d77d6f694bcb1d0c8a55877e4a13a2a6b46cf36/includes/api/ApiBlogPage.php#38
[16:24:51] <hauskater>	 If it requires changing more than a line or two of code I think I'll better leave the task for the extension maintainers maybe
[16:25:10] <Lucas_WMDE>	 … https://gerrit.wikimedia.org/g/mediawiki/extensions/BlogPage/+/3d77d6f694bcb1d0c8a55877e4a13a2a6b46cf36/includes/api/ApiBlogPage.php#11
[16:25:14] <hauskater>	 yup, I thought about changing that to "pagename" instead
[16:25:25] <Lucas_WMDE>	 I’m checking what this BlogPage extension is
[16:25:33] <Lucas_WMDE>	 renaming the parameter would probably be the cleanest solution
[16:25:37] <Lucas_WMDE>	 no idea if that’s feasible though
[16:25:39] * Lucas_WMDE reads mw.org
[16:26:09] <Lucas_WMDE>	 huh, https://www.mediawiki.org/wiki/Extension:BlogPage#API_documentation actually documents it in all-lowercase
[16:26:20] <hauskater>	 ashley is one of its maintainers but I'm not sure they're online a.t.m.
[16:26:39] <ashley>	 sup?
[16:26:45] <hauskater>	 oh, hi ashley 
[16:26:51] <ashley>	 rar
[16:26:53] <hauskater>	 we're talking about BlogPage ashley 
[16:27:09] <hauskater>	 T238202
[16:27:09] <stashbot>	 T238202: Message "apihelp-blogpage-param-pageName" should be in lowercase - https://phabricator.wikimedia.org/T238202
[16:27:29] <hauskater>	 looked easy at first
[16:28:09] <ashley>	 that requires renaming the API param from upperCamelCase to lowercase (but for what it's worth, I for one believe that tools should accommodate devs' needs, and not the other way around, but I'm not gonna fight over it :)
[16:28:11] <Nemo_bis>	 eh yes, renaming API parameters is not that painless
[16:28:43] <hauskater>	 ashley, Nemo_bis I feel you
[16:29:50] <ashley>	 basically tweak the PHP API module as needed (pageName -> pagename) and L44 of /extensions/BlogPage/resources/js/ext.blogpage.createblogpost.js accordingly and you should be good to go
[16:30:10] <Lucas_WMDE>	 I just left a comment on the Phab task
[16:30:20] <Lucas_WMDE>	 you can also disable that check in the grunt-banana-checker, to unblock the upgrade
[16:30:28] <Lucas_WMDE>	 without having to rename the param
[16:30:31] <ashley>	 if you wanna be extra nice you can add some b/c compat code to the API module to check for the lowerCamelCase param name but I don't think that's strictly needed since you're tweaking the only known caller of it
[16:30:34] <Lucas_WMDE>	 (though I still think the rename would be a good idea in general)
[16:31:03] <ashley>	 probably, yes; mind you, I'm sure that BlogPage is not the *only* social tool with upperCamelCase API params :-/
[16:31:09] <Lucas_WMDE>	 ashley: I was thinking of $params['pagename'] ?? $params['pageName'] but I’m not sure if that would actually work
[16:31:28] <Lucas_WMDE>	 I rather suspect that extractRequestParams() will throw away the pageName param if it’s not defined in getAllowedParams()
[16:31:46] <Lucas_WMDE>	 I suppose getAllowedParams() could actually define both params for a transitional period, marking one as deprecated
[16:31:48] <Lucas_WMDE>	 and then it would work
[16:34:25] <ashley>	 mmm...that might make sense in general, yes; for BlogPage (and related social tools) I don't think you need to go through any deprecation period since it's not like they're WMF-deployed or anything (you're supposed to use either latest MW stable or whatever version of MW ShoutWiki is using -- currently still 1.32.x -- and latest (master) version of social tools, any and all other combinations are unsupported; that being said, given that 
[16:34:25] <ashley>	 ShoutWiki's still stuck on 1.32.x, I'm not too sure as to how social tools behave on newer versions of MW...especially as I have some actor-related patches of mine stuck in review limbo, which probably means "I'll need to +2 'em myself and see what, if anything, blows up" so that things aren't failing horribly on newer MWs which only use the actor table)
[16:38:03] <MishMoshKeel21>	 hello?
[16:38:12] <Lucas_WMDE>	 hello?
[16:38:43] <Lucas_WMDE>	 ashley, hauskater: i added another comment on Phabricator summarizing the steps to rename the param (at least how I’d do it)
[16:43:22] <apergos>	 MishMoshKeel21: if you have a question, just ask
[16:46:10] <hauskater>	 Lucas_WMDE: sorry, I had to go afk for a minute due to a phone call
[16:46:44] <Lucas_WMDE>	 ok, no problem
[16:46:48] <hauskater>	 I'll take a look at your comments
[16:47:18] <hauskater>	 Thanks all, I appreciate it.
[17:01:34] <Lucas_WMDE>	 okay, that concludes the Technical Advice IRC Meeting! thanks to everyone who participated :)
[17:01:55] <Lucas_WMDE>	 and don’t forget you can ask questions at any time over at the Wikimedia Developer Support forum! bridge 
[17:01:57] <Lucas_WMDE>	 oops ^^
[17:02:04] <Lucas_WMDE>	 https://discourse-mediawiki.wmflabs.org/
[17:02:06] <Lucas_WMDE>	 that’s the link
[17:02:14] <Lucas_WMDE>	 (firefox not copying urls correctly…)
[17:04:12] <apergos>	 thanks a lot for hosting!
[18:03:16] <Sujal>	 hey there! someone here who is into wikipedia-mobile (for android)
[18:08:39] <Sujal>	 per info-de/otrs: how is it, that on tools.wmflabs/topviews there is a list for false positives, but the android app still shows some of those entrys flagged as false positive?
[18:09:46] <Sujal>	 https://tools.wmflabs.org/topviews/?project=de.wikipedia.org&platform=all-access&date=yesterday&excludes=
[18:10:29] <Sujal>	 while pornhub and xhamster are not shown as most read in-app, edguy is
[18:11:10] <Sujal>	 i totally feel for the guy asking, therefore I am asking here. 
[18:11:20] <Sujal>	 Any thoughts?