[09:19:08] tools.wmflabs.org seems to be timing out at the moment [13:01:16] Hello, could someone please help me with user rights on the beta cluster? [13:01:26] Daimona: sure [13:01:32] Thanks :) [13:01:36] cinquemille [13:01:38] :P [13:02:02] DannyS712 asked me to be added to global developers but I have no idea how to do that 0:) [13:02:25] You file a task on Phab for #wikitech.wikimedia.org [13:02:36] but afaik there's no 'global devs' [13:02:52] it's been a while that I don't look at the list over there though [13:03:21] There's one: https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:GlobalGroupPermissions/developer [13:03:32] Though I don't know anything else [13:04:31] I see [13:05:27] I don't think there would be any issues adding you there. Please file a task and if no one objects we can add you :) [13:06:00] did I say wikitech project? Scratch that, beta cluster infraestructure [13:06:28] post-lunch coffee not yet flowing properly :) [13:06:43] Danny wants to be added, not me :) [13:06:49] I don't even know what that group is for [13:06:58] As I said, I'm completely ignorant about that :D [13:07:12] Will open a task anyway, thanks :) [13:07:17] Ah, well, the process is the same for anyone [13:35:25] Daimona: fwiw to grant global privs you can use https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:GlobalUserRights [14:00:24] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:50:22] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:54:24] I’ll be happy to help answer questions for the Advice meeting if there aren’t any hosts (per the bot). [14:54:47] we have a WMDE host in the spreadsheet, but no WMF host yet (at least as of ~20 mins ago) [14:54:57] guess the wiki page wasn’t updated yet [14:55:36] Right. [14:56:00] I’m stuck on a train right now waiting for it to move, so I’m all ears. [14:56:47] James_F: well, since you volunteered, I was wondering if we shall implement Umherirrender's comments at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/329810/ [14:56:53] see last comment [14:57:00] or if it is okay to merge as-is [14:57:37] Hmm. Might be simpler to use the built-in function. [14:57:48] When it changes later you get it for free. [14:58:07] also, having https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/475930/ would be a dream to come true [14:58:21] but I think it kinda requires a more paused review [14:58:26] idk [14:58:52] That’ll need DBA assistance to make the production schema changes first. [14:59:09] With back-compat/forwards-compat code. [14:59:37] But it makes sense as a feature. [15:00:16] Given that we already have temporary local user rights, it'd be awesome to have the global counterpart [15:00:21] Yeah. [15:00:36] I guess Melos is waiting to have that patch reviewed before asking DBAs for help? [15:01:04] Possibly. Will look later. [15:01:41] I can also answer questions for the first half [15:01:56] Thanks, tgr [15:02:56] If you can take that look later James_F that'd be awesome. I think tgr does too some CentralAuth stuff iirc [15:03:12] I'll ask Manuel A. too [15:05:06] tgr knows far more about CentralAuth code than I do. :-) But I can do a quick review. [15:05:47] the expiry patch makes sense, I can't commit to review it anytime soon though [15:05:47] Thanks both, I appreciate your time [15:05:54] Easiest way is just to split that schema change into a different patch. Get it reviewed, merged [15:06:04] Yeah. [15:06:06] feel free to poke me in a month if it hasn't moved by then [15:06:06] Then merge the code using it when WMF schema changes are all done [15:06:17] But we should check that the schema change is right first. :-) [15:06:22] the other patch needs to be rewritten as James says [15:07:53] I was also doing Reedy's proposed task to update some extensions to use manifest_version 2 and I'm stuck at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AntiSpoof/+/539727/ [15:08:31] the script also converted the unicode stuff into words and I'm not sure if we should keep the original u+numbers stuff or it's okay as it's now [15:08:48] the other timestampts in the centralauth DB use varchar, not varbinary [15:09:33] I think MediaWiki is inconsistent in general, but maybe you'd want to be consistent within a single extension at least [15:09:52] I agree [15:16:28] should be trivial enough things to fix [15:16:30] and to split [15:16:40] DBA review should be easy enough too [15:21:20] hauskater: For the AntiSpoof, I'd just revert the unicode changes [15:22:57] Hmm. I think we can expect code editors to be Unicode-safe nowadays. [15:23:17] Reedy: okay, I'm waiting for jenkins for the phan change [15:23:33] James_F: That feels like a "famous last words" [15:23:37] I'd hope you're right though [15:23:55] Reedy: Ha. [15:24:15] So I'll just use the \u1234 format? [15:24:42] yay, v+2 [15:24:50] Sure. [15:26:30] yeah, use the \u format [15:26:45] Amending [15:26:52] there is no difference but less of a pain in the ass to find out which character it is [15:26:58] heh [15:27:22] hauskater: Seen my query on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Memento/+/543151 ? [15:27:27] I wouldn't blame the script, they have the same PHP representation [15:27:33] tgr: Less? [15:27:45] Surely, more? [15:27:59] James_F: yeah, but I don't know the answer. I see there's another .sh file there and that was the only one which was publicly executable. [15:28:11] hauskater: Eh. Let's merge for now. [15:28:34] I guess you get a vague idea at least (except for the ones which are just tofu) but U numbers are easier to goole for [15:28:43] If you hear a blast and server kittens meow, then we'll know it's time to revert [15:29:29] Those are all non-BMP. None should be tofu on a modern machine. [15:36:21] Back to unicode, and added some "description" as well for some config values [15:41:30] Cool. [15:41:48] and is passing zuul [15:41:55] I'm so proud of myself :P [15:57:17] James_F: so "public": "true", ? [15:57:34] because afaik if nothing is stated it's taken as private by default [15:59:22] hauskater: Yeah, we're defaulting to private. [15:59:29] Not that that means much. [15:59:47] Okay, I'll add the public value [15:59:49] But in the magical future there'll be Special:SiteConfiguration or whatever which will list things like this. [15:59:51] Thanks. [16:00:07] As long as it doesn't break AntiSpoof :D [16:02:30] Sounds neat [16:02:47] done James_F - rebased and waiting for jenkins as well, again :) [16:02:52] I’ve been meaning to write a Phab task for that, actually (unless it already exists?) [16:05:02] T155155 I think [16:05:03] T155155: Implement a way to view (extension) configuration options and its value on-wiki - https://phabricator.wikimedia.org/T155155 [16:05:06] but that's the general view [16:08:00] I guess [16:08:11] I was thinking more in an API direction, but that task seems general enough to cover that too [16:11:18] as for aftv5 James_F I've tried to update the whole lot of NPM dev deps but if I upgrade eslint then a whole lot of things start to break [16:11:26] like that house fire pic from yesterday [16:14:51] Argh. The phan issue I fixed was already fixed in another commit so in the rebase the changed file rightly do not appear, but I now have to ammend the commit message again [16:34:52] hauskater: :-) [16:44:01] Thanks James_F - one thing less to worry about :) [16:44:20] I'll keep an eye on logstash-beta now that it's being merged to spot any issues [16:45:26] Cool [17:07:43] ehm James_F beta-scap-eqiad is ~20 hours inactive at this moment [17:07:53] last run was a day ago or so [17:07:59] I'll ask releng