[14:00:27] <wm-bot>	 Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE & @tgr - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
[14:50:22] <wm-bot>	 Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE & @tgr - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
[15:01:09] <sario528>	 Hello
[15:01:38] <tgr>	 hi all, welcome to the Technical Advice IRC meeting!
[15:02:02] <Lucas_WMDE>	 hello!
[15:02:06] <tgr>	 feel free to ask!
[15:03:04] <Reedy>	 tgr: If you're bored... https://phabricator.wikimedia.org/T228588 class refactoring in OATHAuth broke 2FA in both our mobile apps
[15:03:31] <Reedy>	 Being questioned about whether the way/stuff we're exposing in clientlogin from authmanager is "right" or we could/should do soemthing else
[15:04:17] <tgr>	 you can provide a custom ID if you want
[15:04:47] <Reedy>	 which I guess is the answer to
[15:04:48] <Reedy>	 >I am wondering why the "id" is an actual PHP class name, rather than a "real" id, like totp, which chould just be provided by the PHP class and therefore would not change in such cases.
[15:05:01] <tgr>	 we haven't really though about clients wanting to depend on a specific ID, the vision was more about clients using the API to get the definitions for some form builder
[15:06:46] <tgr>	 there's AuthenticationRequest::getUniqueId(), although the original intent was to support use cases where you can have multiple instances of the same class (e.g. GoogleLogin where there are multiple Google accounts connected to the user) but there is no harm in using it to provide a fixed string
[15:06:54] <tgr>	 or fake the old value or whatever
[15:22:52] <[1997kB]>	 hey is there a change in mobile interface recently, the new location of notification icon seems bit dislocated
[15:23:15] <Lucas_WMDE>	 I’m not aware of anything like that
[15:23:40] <Lucas_WMDE>	 I heard of some changes to Vector and Monobook (I think?) but not the mobile skins
[15:26:20] <[1997kB]>	 https://drive.google.com/file/d/1-HDuhGgRQdbcS_hbj_JeyKrdNOgu8V1M/view?usp=drivesdk
[15:27:18] <Isarra>	 Well that's odd. Looks like it's just getting cut off on the side of the screen.
[15:27:21] <tgr>	 there's a new beta channel for mobile web
[15:27:33] <tgr>	 you have to opt in though
[15:28:32] <tgr>	 that said there are often minor changes to the interface, or the OOUI components it uses
[15:28:40] <tgr>	 best course of action is filing a bug
[15:30:29] <[1997kB]>	 tgr, opt in? how
[15:32:40] <tgr>	 maybe I'm confusing things
[15:33:16] <tgr>	 looks like there's https://www.mediawiki.org/wiki/Reading/Web/Mobile_Beta (which is not new) and https://meta.wikimedia.org/wiki/User:CKoerner_(WMF)/Advanced_mobile_contribution_options_second_update (which is newish)
[15:36:08] <iridescence>	 Is there a bug with using pywikibot's 'setSitelink()' with dictionary at test.wikidata.org. Or am I doing something wrong?
[15:38:54] <Isarra>	 Is there a betacluster commons-like wiki with wikibase and stuff?
[15:40:06] <Lucas_WMDE>	 iridescence: what do you mean? can you post your code, perhaps?
[15:40:17] <tgr>	 Isarra: don't think so, but there's testcommonswiki in the production cluster
[15:41:30] <Lucas_WMDE>	 https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Version shows WikibaseRepo
[15:41:35] <Lucas_WMDE>	 no idea if it’s configured, though
[15:41:37] <iridescence>	 Try to run this: https://pastebin.com/Pv8yYn5x
[15:41:39] <Lucas_WMDE>	 I haven’t heard anything about it
[15:42:07] <tgr>	 https://test-commons.wikimedia.org/wiki/Main_Page
[15:42:36] <[1997kB]>	 it looks like it's because of advanced mobile edit mode, I enabled that mode and it is normal now with an additional user icon.
[15:42:54] <Lucas_WMDE>	 iridescence: is that supposed to be supported? it doesn’t look like it from the code
[15:43:13] <Lucas_WMDE>	 but apparently you could call setSitelinks() (plural) with a list of sitelinks
[15:43:16] <iridescence>	 It's working on wikidata.org
[15:43:19] <Lucas_WMDE>	 huh
[15:43:48] <Lucas_WMDE>	 what’s the error? (I don’t have pwb set up locally)
[15:44:07] <Lucas_WMDE>	 oh, wait, I misunderstood you
[15:44:12] <Lucas_WMDE>	 that code looks like it should work, yes
[15:44:20] <Lucas_WMDE>	 oh, I think I know the problem
[15:44:25] <Lucas_WMDE>	 you can’t add enwiki sitelinks to testwikidata
[15:44:34] <Lucas_WMDE>	 the only legal clients are testwiki, test2wiki and a few others I think
[15:44:40] <Lucas_WMDE>	 but no non-test wikis
[15:45:58] <Lucas_WMDE>	 no, wait, https://test.wikidata.org/wiki/Q377 has links to real wikis…
[15:46:02] <Lucas_WMDE>	 o_o
[15:46:09] <Lucas_WMDE>	 not sure how that’s supposed to work
[15:46:34] <iridescence>	 I found out
[15:46:54] <Lucas_WMDE>	 yeah I just found your edit
[15:46:58] <iridescence>	 It got me a really bad error message of it was already linjed
[15:46:58] <Lucas_WMDE>	 (via Special:ItemByTitle)
[15:47:20] <iridescence>	 https://pastebin.com/9K1fV4Q1
[15:48:16] <Lucas_WMDE>	 I think the API does return more information
[15:48:19] <Lucas_WMDE>	 but not in the 'error' field
[15:48:37] <Lucas_WMDE>	 or not in some subfield of that, not sure
[15:48:50] <Lucas_WMDE>	 I *think* I’ve been annoyed at that before, that pywikibot didn’t show me the important parts ^^
[15:48:55] <Lucas_WMDE>	 but perhaps I’m confusing it with python-mwapi
[15:50:10] <iridescence>	 yeah, could be the API
[16:10:28] <Lucas_WMDE>	 I guess the Technical Advice IRC Meeting is over – thanks to all who were there, and don’t forget you can always ask questions on the Wikimedia Developer Support forum :) https://discourse-mediawiki.wmflabs.org/
[16:45:45] <Isarra>	 <3