[06:13:17] <[1997kB]> anyone know if there's already report for https://en.m.wikipedia.org/w/index.php?title=Special:Contributions&limit=50&contribs=user&target=1997kB&namespace=&tagfilter=&start=&end= [06:13:21] <[1997kB]> ? [06:22:12] works on regular site and not on mobile, it seems? [06:22:18] https://en.wikipedia.org/w/index.php?title=Special:Contributions&limit=50&contribs=user&target=1997kB&namespace=&tagfilter=&start=&end= [06:22:55] <[1997kB]> yeah only issue on mobile site [06:24:21] haven't heard of anything, but best to double check phabricator before reporting [14:00:27] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE & @tarrow - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:50:11] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE & @tarrow - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:03:19] Hello! Lucas_WMDE and I are around for the next hour for this weeks TAIM. It's my first time so no idea if there should be an official intro? [15:04:31] o/ [15:04:38] o/ [15:05:02] o/ [15:05:52] Well, TAIM stands for Technical Advice IRC Meeting and is an opportunity for anyone to ask questions or seek help on technical issues related to Wikimedia, perhaps that’s worth mentioning :) [15:06:42] o/ [15:07:27] this is a question for addshore, given it's their commit; https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/363284/ in WikiRevision.php it says, for the downloadSource method, deprecated, use UploadImporter::downloadSource but I don't find UploadImporter.php anywhere. Wheeeere is it? [15:07:40] (since no one else is asking yet) [15:08:43] ooh, I'll take a look [15:08:53] the only other downloadSource() I see in code search (https://codesearch.wmflabs.org/search/?q=function downloadSource) is in ImportableUploadRevisionImporter [15:09:01] yes, and that one has a note that says [15:09:15] *reads* [15:09:25] @deprecated DO NOT CALL ME. [15:09:29] oh, it says DO NOT CALL ME ^^ [15:09:42] yeah [15:09:46] so *cough* [15:10:05] That sounds about right [15:10:36] so.... let's suppose someone were motivated to fix up this cruft. what would they call? :-D [15:11:21] Wait ImportableUploadRevisionImporter::download source is deprecated too? [15:11:31] (I'm just on my phone currently so can't look) [15:11:31] yes [15:11:37] that's exactly the thing [15:11:46] Hi, I've now responded on the mess of the main page to the request to feedback but when the Tech team changes their mind, Would you be able to tell us? https://www.mediawiki.org/wiki/Topic:V1hxcy1m2icxznle - You should work on communication - I'm sure I'm not the only one who thinks this [15:12:00] so an UploadImporter class exists in earlier patch sets of that change, e. g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/363284/5 [15:12:10] sounds like it was renamed without fully updating the documentation [15:12:36] and that one has decprecated DO NOT CALL in it too [15:12:51] so we have no downloadSource methods to call? [15:13:41] so in PS12 the class was renamed from UploadImporter to ImportableUploadRevisionImporter, apparently [15:13:44] so that is the right class [15:13:48] no idea why its method is also deprecated… [15:13:51] RF1dle: sorry, I don't unerstand your question? [15:13:56] the right class, except that, yeah the method. sigh [15:13:56] I'm opening my laptop [15:14:09] addshore: I did not mean to nerdswipe you into it. but thank you [15:14:26] legoktm: More of a rant at people, see the linked thread on mediawiki.org [15:14:43] apergos: this comment answers your question https://gerrit.wikimedia.org/r/c/mediawiki/core/+/363284/6/includes/import/WikiRevision.php#753 [15:15:00] RF1dle: okay. that's probably not a great use of this meeting then [15:15:00] addshore deliberately introduced and deprecated the method in the same change, apparently [15:15:07] “to avoid having to announce the removal on the mailing list” [15:15:21] someone just point me to the industry-approved method for downloading media in prep for importing [15:15:27] legoktm: More seeing if anyone had an answer to the lack of communication skills as well [15:15:42] I can skip right over the comments and all that as long as someone can tell me 'use this!' [15:16:12] Well, if there is a need for that method as is, then I guess use it [15:16:58] it sounds like it was intended to be completely removed in 1.35.0 [15:17:00] there's no replacement that will do a get and stash the media file someplace? [15:17:01] Without being able to check in a nice IDE I would guess the only reason it still exists is due to waiting for the right number of versions to pass before removal [15:17:04] or 1.34.0 [15:17:10] I'm not sure it has any uses, but I can check that right now [15:17:14] I wonder what importDump is supposed to call because [15:17:21] it uses it right now, well in 1.32 I guess [15:17:26] sec [15:17:57] addshore: no uses outside of core according to code search https://codesearch.wmflabs.org/search/?q=->downloadSource\(&files=\.php%24 [15:18:00] grr [15:18:02] in uh 1.33.0-rc.0 [15:18:16] Lucas_WMDE: what about in core? :) [15:18:19] it's used because importDump eventually winds up there [15:18:27] and that's core for sure ;-) [15:18:40] but if the method is needed as is, then I'm totally fine with it not being marked as deprecated any more [15:18:42] well core is under our control, right? shouldn’t matter how many uses it has there [15:18:52] (it has two, WikiRevision and ImportableUploadRevisionImporter) [15:18:58] again, I don't care so much about the marking as 'what are we supposed to use instead' [15:19:09] just want to dtrt [15:19:40] Lucas_WMDE: if they are the only 2 uses then the plan would have been to make it private once the stuff is removed from WikiRevision [15:20:06] apergos: importDump doesnt actually call that method directly though? [15:20:14] no, not directly [15:20:20] there's a nice rabbit hole [15:20:51] (the back story is: trying to fix crap on wikitech-static and it's 1.33.0-rc0 and calling this) [15:20:55] Well, the only place it can be called via is ImportableUploadRevisionImporter::import then? [15:21:27] ImportableUploadRevisionImporter->import yeah that's right I think [15:22:12] I'v got to dash, but will read up what happens after [15:22:22] apergos: where do you want to call the method (or a replacement)? [15:22:32] $source = $this->downloadSource( $importableRevision ); [15:22:35] yeah there it is [15:22:49] well, i want to call a replacement right there I guess [15:22:56] if we shouldn't use that [15:23:46] I think the deprecation is just for it being public [15:23:48] that's in master btw so still like that [15:23:53] so the call inside ImportableUploadRevisionImporter would be fine [15:24:14] no need to replace that with anything [15:24:42] ok, so it's worth debugging the existing codepath with that in it [15:24:48] thanks, appreciate the time! [15:25:11] (updating the comments would probably be good as an aside) [15:25:19] yeah, definitely [15:25:30] I think that's how I read it too but it could indeed be clearer :) [15:28:33] ty! [15:33:20] https://gerrit.wikimedia.org/r/516641 [15:33:44] does anyone else have questions? [15:47:24] no other questions? [16:00:15] alright, that concludes this week’s Technical Advice IRC Meeting! thanks everyone for participating :) [16:00:37] Thanks! :) [16:00:40] don’t forget you can also ask such questions at any time over on the Wikimedia Developer Support forum! https://discourse-mediawiki.wmflabs.org/ [16:00:43] Lucas_WMDE: just a late thank you for making progress on the extension.jsonification of Wikibase :) [16:01:04] legoktm: you’re welcome! I hope it continues soon :) [16:01:53] I was feeling guilty about using time for a question... but maybe that's a mistake :-) [16:04:50] well we didn’t exactly run out of time for other questions :P [16:06:58] :-) [16:07:35] I think having some activity is better than silence by a long way [16:14:52] Lucas_WMDE: So this channel is still marked registered users only. I wonder if that's lessening the number of new people coming to the questions meeting [16:15:06] is anyone here? [16:16:09] jc86035: How can we help you? [16:16:40] I'm mainly here because a discussion was mentioned in the enwiki Discord server, I don't have much to say right now [16:17:03] a technical advice discussion? [16:17:05] bawolff: hm, okay [16:17:29] it was something about the talk pages consultation [16:17:45] their qualtrics survey has been delayed by about three weeks [16:18:14] Lucas_WMDE: apergos I'll try to remember to update the docs in the coming days, but won't get to it for a while [16:18:20] Lucas_WMDE: We were having spam problems a while back, maybe its died down enough that we could lift the restriction. I'm not sure [16:18:22] Jc68035: hi! It's RhinosF1 from Discord. [16:18:30] addshore: I already uploaded a change to do it [16:18:30] addshore: I think Lucas did it [16:18:32] addshore: there's a patchset already in gerrit thanks to [16:18:33] Jc86035: ^ [16:18:34] Lucas! [16:18:36] RF1dle: hi [16:19:18] Jc86035: Trizek has been asking me questions over PM. I think they're still finding out if Qualtrics is definitely off. [16:19:21] Hehe [16:19:58] RF1dle: got it [16:21:13] I just have the confirmation that the survey for talk pages consultation will not happen. The different pages will be updated soon. [16:22:30] The issue is that is has been very difficult to design that survey. And since the number of replies from newcomers is more important than expected across languages, a survey was not as needed as we thought. [16:22:57] jc86035: ^ [16:23:11] Trizek: (Mostly) unrelated question, is there a reason the banner now links to the phase 1 report instead of the landing page? [16:23:29] it seems to have caused a massive drop in page views to the local consultations, suggesting that no one is bothering to scroll down [16:26:48] jc86035: To be transparent, I was against the idea of changing the link from the landing page to the report. [16:27:37] Since it was totally inefficient as predicted, since a few hours, I've set direct links to local pages for every language. For English, it goes to the report, because it is the most central place we have (we have consultation in English for Wikipedia, Wikisource and Wikidata, so no common place to link to). [16:29:28] [correction – it only caused a drop for enwiki, where there was a page view spike for about a week, whereas on some of the other consultations, like zhwiki, there was no spike to begin with] [16:30:24] okay, that makes sense. although maybe an "I don't want to read all of this" button might perhaps be helpful? [16:30:26] It caused a drop on French and German IIRC. [16:30:42] Can you suggest it on the talk page? :) [16:32:19] Trizek: done. [16:33:23] Thank you. [16:35:00] Trizek: Furthermore (sorry to bother you), is it still planned for the consultation to end on the 15th with summaries due that day? As yet there is nowhere to post discussion summaries, and some of the discussions still seem to be a little active. [16:35:19] I'm personally a little worried about the amount of text that has to be summarized, to be honest [16:36:18] We are worried too. [16:38:57] Freeze the feedback is still scheduled for June 15, jc86035. [16:39:26] In the meantime, we will have finished to think about advice or a process to proceed all the feedback.