[14:00:21] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:05:11] I'm also hosting :) [14:50:20] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:00:22] o/ [15:00:54] \o/ [15:01:11] Hey Amir1, CFish_WMDE, I think for once I've got nothing to ask!! [15:01:21] Welcome to the Technical Advice IRC Meeting! [15:01:22] ^CFisch [15:01:36] RhinosF1: You have an hour to come up with questions :D [15:01:42] RhinosF1: ;-D [15:03:04] I normally ask something whether it be about a bug or something or even last week making quarry queries but I think all my tasks are just waiting on fixes etc. Hopefully, it won't be too quiet [15:04:01] RhinosF1: No worries, it's not that we do not have stuff that we can do while listening to the chat :-) [15:05:03] Have a good evening, I'm always around. I'll probably think of something eventually [15:05:11] Hehe :-) [15:05:40] Hi Amir1 & CFisch_WMDE, can we reboot the culture of cleaning pending patches backlog? I remember some years ago, there was a culture as such [15:06:01] some years ago? lol [15:06:06] Something like patch review day? Where we have an IRC channel say #wikimedia-code-review for this purpose only? [15:06:22] Reedy: I can't really remember, but there was something like that when I just joined the movement [15:06:29] we also used to have code-review-office hours [15:06:38] Amir1: I didn't know, truly [15:06:42] When does that happen? [15:07:08] might be of interest of developer productivity team (just a wild guess) [15:07:18] Okay! [15:07:19] xSavitar: let me dig [15:07:23] Thanks a lot [15:07:32] * xSavitar waits for Amir1 to dig :) [15:07:54] https://www.mediawiki.org/wiki/Code_Review/Office_Hours [15:08:27] Thanks for the link [15:08:51] And yes, there is already a channel [15:09:04] But Amir1 seems this is no longer happening as the page say obsolete? [15:09:22] then T177974 too :( [15:09:22] T177974: Drop #wikimedia-codereview channel - https://phabricator.wikimedia.org/T177974 [15:09:28] yup :( [15:09:50] Oh no, I really wish this could be rebooted. [15:10:00] maybe good idea to revive it but I would consult with the technical engagement team first [15:10:31] Amir1: please do that, we'll keep in touch, I'm open for any little help I can offer, no matter how little :) [15:10:50] I also know people are busy, very busy but please please please, we need this :) [15:11:07] Amir1: xSavitar So also https://phabricator.wikimedia.org/T128371#4471446 [15:11:57] We might also find the time to about this at the Hackathon [15:12:11] T200987 [15:12:12] T200987: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 [15:12:20] This also might be useful [15:12:35] Yeah, that prev links to it, thanks a lot [15:14:25] Also, I'm not sure if this is the right time or right place to ask this but is it possible for volunteers to have access to Log stash, if so, what is the criteria. Could help cleanup or file some incidents if I spot [15:14:38] Or maybe useful for me to understand the details about a particular problem [15:17:29] xSavitar: Hmm I'm not sure what the official policy is there. [15:17:40] xSavitar: The logsatsh requires NDA [15:17:49] because it has lots of private data [15:17:58] Okay Amir1 & CFisch_WMDE [15:18:34] Really, we shouldn't have people doing that manually. It should be an automated process [15:18:54] Amir1: Does it mean it's only for staffs or for anyone willing to sign the NDA? [15:18:57] for that, you need a point of contact in WMF, so if you can convince a manger to support that, it should be doable (specially since it's just LDAP group and not a real production shell access) [15:19:28] Amir1: Can I say I have you? :) [15:19:32] Or maybe Reedy :D [15:19:47] seconding Reedy, now nagios makes automatic phab tickets, why not :D [15:19:59] xSavitar: I'm not a manager nor working for WMF [15:20:00] :D [15:20:06] :) [15:20:28] Reedy: removing PII would be fun though :P [15:20:39] We redact stack traces already.. [15:21:30] I have a feeling something somewhere might still leak info [15:21:47] Shit happens [15:21:55] People leak PII on a semi regularly basis [15:22:13] /o\ [15:22:18] Reedy: what is PII so I know what I'm reading please? [15:22:26] Reedy: Not really a good argument though ^^' [15:22:27] Pentium II [15:22:34] Personally identifying information [15:22:36] Eh [15:22:48] i.e. private data [15:22:54] IP, user agent [15:23:38] Oh, I get it now, "personally identifiable information" [15:25:37] !bash Reedy: what is PII so I know what I'm reading please? [15:25:37] xSavitar: Stored quip at https://tools.wmflabs.org/bash/quip/AWpP88buEHTBTPG-qjAz [15:25:58] !bash Reedy: Pentium II [15:25:58] xSavitar: Stored quip at https://tools.wmflabs.org/bash/quip/AWpP9BeYOwpQ-3Pko1e9 [15:26:07] Those are seperate quips now [15:26:13] Oh no :( [15:27:32] !bash 16:25 xSavitar: !bash Reedy: what is PII so I know what I'm reading please?, Reedy: Pentium II [15:27:33] xSavitar: Stored quip at https://tools.wmflabs.org/bash/quip/AWpP9YoGEHTBTPG-qjLB [15:27:54] good old days, I had Pentium IV and was so proud 2.4GHz [15:29:11] Technical question: How do I use the !bash command for multi-line quotes :-D [15:29:23] Okay, there is this very weird problem I'm having with Git + Gerrit [15:29:29] I made this patch a long time ago: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/487057 [15:29:47] But the patch for removing all $wgParser has been made recently by simetrical [15:30:10] It's clear that I can't rebase on Gerrit now because there is a merge conflict and I need to do a manual rebase [15:30:29] But the funny issue is that I can't bring down that patch locally anymore, I get an error such as; [15:31:44] * xSavitar reproduces the error to paste the link here... [15:31:46] You can paste it in phabricator [15:31:59] https://phabricator.wikimedia.org/paste/edit/form/14/ [15:32:05] https://pastebin.com/LmnVrsrG [15:32:19] Oh, I already used pastebin but next time, I'll use that :) [15:33:02] Now here: https://phabricator.wikimedia.org/P8431 [15:33:11] Has anyone faced such an issue before? [15:33:31] I'm not sure how I can force this thing to overwrite those files [15:33:53] xSavitar: you need to make the commit and then rebase it [15:34:00] using git fetch and then git rebase [15:34:19] or get a clean version and then use git cherry-pick [15:34:29] (let me get a really good documentation) [15:34:46] Okay [15:34:58] Amir1: I don't have this patch locally anymore, I think I deleted the branch locally or so [15:35:17] I can get it only online and my best bet should be with git-review right? [15:35:46] xSavitar: From the error it seems your local working dir is in some weird state. - What's the output of git status? [15:35:48] xSavitar: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/84206#message-d387ac2aa2a6e83b72f18296d1a249ca2c197704 [15:35:52] Or is there a way to get patches down from Gerrit using git only, not git review? My understanding tells me that git-review runs git in the background [15:36:15] yes, you can [15:36:15] you can do "git reset --hard origin/master" [15:36:21] └─ $ ▶ git status [15:36:21] On branch core-dev [15:36:22] nothing to commit, working tree clean [15:36:27] this throws out everything you have locally [15:36:31] Download link in the top right from gerrit [15:36:31] git fetch "ssh://reedy@gerrit.wikimedia.org:29418/mediawiki/extensions/Flow" refs/changes/82/505782/3 && git cherry-pick FETCH_HEAD [15:36:34] Gives you nice stuff like that [15:37:25] xSavitar: so no untracked files in git status? o.O [15:37:38] CFisch_WMDE: No, this problem is very weird :( [15:37:50] Reedy, Amir1, CFisch_WMDE, can any of you try to reproce this? [15:38:11] Like try pulling down that patch, my core-dev branch is in sync with mw 1.34 master [15:38:22] *reproduce [15:38:53] xSavitar: I can download the patch just fine [15:39:07] Hmm... [15:39:49] git clean -fd? [15:39:59] deletes untracked stuff... [15:40:02] so be careful [15:40:14] Reedy: I can't dare that, it broke my previous local installation [15:40:21] CFisch_WMDE: Do you have this patch locally? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/502996 [15:40:33] xSavitar: Now yes, :-) [15:40:35] I have 1.34 master right now and I made that patch a while ago befure the but [15:40:47] CFisch_WMDE: You can reproduce it? [15:41:04] 1.33 cut [15:41:09] Ahh ... I'm on the current master soo maybe it's related to the cut [15:41:19] Kind of, I'm not sure [15:41:43] That stuff made me run the command Reedy suggested and lost my beautiful LocalSettings.php with a bunch of so nice configs :( [15:41:50] But I won't dare anymore :D [15:41:58] !backups [15:42:02] Copy the file :P [15:42:06] Reedy: Yes, I'll be doing that daily :D [15:42:44] So before downloading that patch maybe git checkout master [15:43:07] git reset --hard origin/master [15:43:18] and try again [15:43:36] Okay, let me try that asap [15:44:34] Oh CFisch_WMDE, before I do that, should my master be like up to date? [15:44:40] Does it matter, I guess not? [15:44:48] Would not hurt :-) [15:45:02] !always everything up2date [15:45:27] on it [15:45:34] You also want to rebase on the current master anyways [15:46:52] <[1997kB]> anybody having issues with editor in mobile site? [15:48:10] <[1997kB]> like when there's a long message, and new text is typed in bottom, it goes below keyboard. [15:49:22] CFisch_WMDE: Ops, same problem :( [15:49:33] I don't know why git is getting confused or maybe it's git-review? [15:50:02] Reedy: I've seen one weird scenario where a PR on github gets closed and a new one opened and the comments from the previous reappears on the new one [15:50:04] [1997kB]: Is it visual editor or ordinary editor [15:50:11] Is that normal? I mean that is weird but maybe it's normal behavior [15:50:26] <[1997kB]> Amir1: ordinary [15:50:32] Same code, same everything but just a new PR [15:51:04] then it's hard to say, because VE team is working on editing on mobile [15:51:11] [1997kB]: I would recommand filing a bug [15:52:00] xSavitar: No this is just strange. I mean in theory you should be on the master branch now. What's the output of git status now? [15:52:06] <[1997kB]> I was just checking, it's just me or is it really bug. [15:52:43] <[1997kB]> if anyone can confirm.. [15:52:50] CFisch_WMDE: nothing to commit, working tree is clean [15:53:03] Truth, the problem is a very strange one [15:53:38] Maybe you should throw away the complete local git dir and clone it anew :-D [15:54:15] :D [15:54:59] You could also clone it to somewhere else just to download that patch and rebase it ;-) [15:55:06] That's often less effort... [15:55:14] Before `die()` on my old repo, let me try what Reedy proposed about the gerrit link [15:55:14] But you don't really learn what went wrong/how to fix it [15:55:20] Reedy: :D [15:55:39] Reedy: Yeah, I'm really still trying to figure out what is going on [15:55:54] Reedy: Deleting and re-cloning is a fix! :-P [15:56:06] CFisch_WMDE: A hot fix :D [15:56:09] CFisch_WMDE: Let me know if you can do that for the UK Gov [15:56:28] The issue is, recloning will still have the same code structure [15:56:31] Like master 1.34 [15:56:37] So I don't think logically, it will still work [15:56:47] I mean, I can try that but I wonder if it will work [15:57:38] I tried the command Reedy, same problem :( [15:57:38] https://phabricator.wikimedia.org/P8432 [15:58:13] I also see something related to those files [15:58:22] On 1.34 master, the naming is different [15:58:46] it's SpecialActiveUsers for example instead of SpecialActiveusers [15:58:52] Is that from my renames? [15:58:58] Yes [15:59:01] git reset HEAD --hard [15:59:04] delete includes/specials/ [15:59:05] git pull [15:59:13] You did this to me once around Echo I think ;) [15:59:17] I remember I didn't sleep that night [15:59:45] Reedy: Should that be on any branch? [15:59:57] just do it wherever you currently are [16:00:03] as your working copy isn't clean [16:04:19] Ok, I'll have to leave now. I hope you get this solved xSavitar ;-) [16:04:31] I'll read about the results in the log tomorrow :-D [16:04:32] CFisch_WMDE: I really do hope [16:04:46] Reedy: Same problem and now no more includes/specials :) [16:04:53] git pull should bring them back [16:05:23] It didn't strangely enough [16:05:40] It told me everything was up to date [16:06:21] Redoing for benefit of doubt [16:07:03] `git reset HEAD --hard` again? [16:08:13] Yes I already did that, that should bring back specials [16:08:20] So after that, I'll redoing the steps you gave above [16:09:10] *redo [16:10:08] Same problem! We can leave it for now [16:10:16] I'll work on it later tonight and see what I comeup with [16:10:26] Reedy: Thanks a lot for the helping hand [16:10:34] The solution should be something like that [16:10:41] usually, when I want to do renames, I use `git mv` [16:11:06] I've realized that mv messes up git badly for some weird reason I can't tell for sure [16:11:19] it doesn't know waht you've done with the file [16:11:21] In most cases, I use `git mv` instead of `mv` for renames [16:11:28] if you git add it at the new name, it should fix it [16:11:31] if it works out it's a rename [16:11:38] Okay [16:11:43] The other one is just doing like `git reset HEAD~250 --hard` [16:11:44] And then git pull [16:12:23] Reedy: Okay, in that case, I'll retry this tonight and see how it goes. I'll document this if it finally works [16:12:32] Meh, I won't want someone to go through this kinda hustle :D [16:12:50] "don't use windows" [16:12:52] ;) [16:12:55] I don't [16:13:05] I'm using a Mac [16:13:08] based off unux [16:13:11] unix [16:13:39] macs are stupid with case sensitivity [16:13:51] Yup, I feel you, the pain :) [16:13:58] I remember we had this kinda problem before [16:14:10] When you did some rename around Echo when we were working on the namespace issue [16:14:11] I don't do this stuff locally... because it tends to just work better on linux [16:14:14] It freaked me out the whole night [16:14:32] Okay, so you do the renames on pure linux? Not a mac? [16:14:59] Like ubuntu for example [16:15:04] Yup [16:15:10] I don't do much locally [16:15:44] Reedy: Okay, wait in that case, let's try something, could you reproduce this? Like on master (latest), can you pull down that patch locally? [16:16:15] which patch? [16:16:26] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/487057 [16:16:34] Numerous people do use mac... So if it was problematic, more people would've been shouting [16:16:40] I'm pretty sure it's going ot be a local to you problem :P [16:16:53] CFisch_NA: reproduced it [16:16:57] If I'm not making a mistake? [16:18:18] I didn't touch Special:Version though [16:18:35] Oh, I bet [16:18:38] let me rebase that patch for you [16:18:41] I bet that's enough to fix it [16:18:57] As then you're not swapping between trees [16:19:04] (you'll still need to cleanup locally) [16:19:40] If you succeed in rebasing, I can download that patch [16:20:13] rebased [16:20:46] I think you got conflicts and fixed them right? [16:20:55] manually [16:21:20] yeah [16:21:34] Now the download will work [16:23:53] FWIW, in future, if you use the gerrit download links, and then just do a cherry pick onto master... That saves the rebase issues [16:24:25] Okay, copy that [16:24:47] I just tried downloading the patch again, let's see how it goes [16:24:55] And yes, Reedy, it worked [16:25:01] Thanks a lot [16:25:35] So it means in such a scenario, I need a rebase (with linux) or the other approach you suggested [16:25:45] Hmm.... I need to rethink my OS :D [16:25:49] Reedy: TU [16:26:17] It shouldn't be a regular problem [16:26:34] Yeah, it's a rare one, Reedy, should we document this? [16:26:56] For someone who doesn't have access to linux, the person can plead on IRC for someone to rebase [16:27:06] If the "someone" has the time to do so, it's worth documenting [16:32:36] * xSavitar owes Reedy 2 beers now :) [16:34:53] Reedy: I'm documenting it, can you linked me to the rename you made? [16:34:58] *link [16:35:10] The patch that did the renaming [16:52:48] Reedy: https://www.mediawiki.org/wiki/User:X-Savitar/Sub-pages/Manual_git_rebase_with_file_renames_on_Mac, I need the rename patch to complete the doc :), thanks [16:56:52] Oh, I found one: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/139873, that should do it [16:57:00] * xSavitar completes the doc :) [17:18:13] * McJohn quietly chuckles at technical advice meeting becoming git office hour [17:18:59] I feel like GitHub probably has a whole team of “okay here’s how you use git” employees [17:25:56] McJohn: Sorry about that, it was kinda Git + Gerrit related for a patch uploaded to Wikimedia Gerrit [17:26:17] It took us a while to figure out but I think it will help someone in the future? :) [17:26:27] Oh and Mac related too [17:27:05] haha not complaining at all! Just very bemused. It’s certainly appropriate, I think, just amusing. git makes us all smack our heads now and then [20:10:07] Browser stats are only available on a WMF-wide basis, is that right? [20:10:27] That is, can’t get this for a specific project/language: https://analytics.wikimedia.org/dashboards/browsers/#desktop-site-by-browser/browser-family-and-major-hierarchical-view [20:15:12] I know we keep more detailed stats internally (for 90 days), so if you have a reasonable reason, probably someone can calculate that for you [20:15:33] You might also want to try the #wikimedia-analytics channel as well [20:16:18] Thanks, but no need — trying to justify supporting IE11 for an enwiki thing. WMF-wide has it at ~10-11%, which is probably fine [20:16:41] And thanks, didn’t know that chan existed! [20:17:12] https://www.mediawiki.org/wiki/Compatibility#Browsers [20:17:22] Yeah [20:21:16] Guess IE11 won't be going away till windows 7 usage starts really dropping [20:25:40] 7 is EoL next year I think [20:26:57] That should spur things forward, thank god, but I imagine windows 10 will persist [20:36:09] " Technical question: How do I use the !bash command for multi-line quotes :-D" -- https://tools.wmflabs.org/bash/help -- "f you want a multiline quip, use tabs where the newlines should go. You may need to write the quip in a text editor and paste it into your IRC client to do this." [20:37:04] But what if I want tabs in my quote! [20:37:09] * bawolff jk [20:37:19] use the web ui ;)