[10:25:19] <FR30799386>	 Any body having this issue with gerrit ?
[10:25:22] <FR30799386>	 https://imgur.com/a/GhIuCqA
[10:26:54] <apergos>	 I'm not on mobile to be able to check; you might ask in #wikimedia-releng about this (gerrit maintainers) if it persists/isn't just you
[10:29:35] <andre__>	 FR30799386, which browser is that? What full URL is that?
[10:29:58] <FR30799386>	 Chrome on Android
[10:30:28] <FR30799386>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/491547
[10:35:38] <FR30799386>	 The sites works now....
[15:31:49] <rhinosf1>	 Anyone able to debug https://raw.githubusercontent.com/RhinosF1/StatusChanger/master/StatusChanger.js as edit descriptions are all showing the BOW(R) one - https://en.wikipedia.org/w/index.php?title=User:RhinosF1/Status&action=history
[21:09:10] <ebernhardson>	 anyone know where the class_alias calls that make namespaced phpunit also have the old un-namespaced class names live?  In my local testing it seems PHPUnit\Framework\Warning is missing the alias, but i'm not sure where they come from
[21:11:49] <ebernhardson>	 hmm, perhaps wrong room :)
[21:17:23] <Reedy>	 ebernhardson: I don't think we did that in the end
[21:17:23] <Reedy>	 "Instead of extending PHPUnit_Framework_TestCase, extensions need to extend from PHPUnit\Framework\TestCase. The latter is available as a forwards-compat shim in PHPUnit 4.8.36 so it is safe to migrate over before PHPUnit 6 happens. "
[21:18:56] <ebernhardson>	 Reedy: well, what i actually need is to extend a phpunit class, and that class takes a PHPUnit\Framework\Warning instance
[21:19:32] <ebernhardson>	 so i get errors like this because no alias exists: Fatal error: Declaration of MediaWikiLoggerPHPUnitTestListener::addWarning(PHPUnit_Framework_Test $test, PHPUnit_Framework_Warning $e, $time) must be compatible with PHPUnit\Framework\TestListener::addWarning(PHPUnit\Framework\Test $test, PHPUnit\Framework\Warning $e, $time) in 
[21:19:37] <ebernhardson>	 /vagrant/mediawiki/tests/phpunit/MediaWikiLoggerPHPUnitTestListener.php on line 92
[21:20:12] <ebernhardson>	 these magically work in some places, PHPUnit_Framework_AssertionFailedError somehow exists, but not here
[21:20:22] <Reedy>	 are you using 4.8.36 locally? I wonder if their patching forgot some stuff
[21:21:29] <ebernhardson>	 Reedy: i'm on 6.5 i think (based on changelog in vendor/phpunit/phpunit). So i have PHPUnit\Framework\Warning, but for CI to be happy it has to be PHPUnit_Framework_Warning 
[21:23:01] <Reedy>	 https://github.com/sebastianbergmann/phpunit/blob/4.8.36/src/ForwardCompatibility/AssertionFailedError.php
[21:23:23] <Reedy>	 That folder seems rather lacking in contents
[21:24:41] <ebernhardson>	 huh, i wonder if i should just stick a `class X extends Y {}` somewhere then
[21:25:25] <ebernhardson>	 but yea, basically it has the BaseTestListener but not enough classes to implement the methods on BaseTestListener
[21:25:52] <ebernhardson>	 good find!
[21:27:50] <Reedy>	 ebernhardson: Help get rid of hhvm then we can upgrade all over ;P
[21:29:00] <ebernhardson>	 :P
[23:08:13] <ragesoss>	 anybody around who's good with Guided Tour? I've got a tour that used to work and now it doesn't, and I can't figure out why.
[23:08:38] <ragesoss>	 https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-wikiedcitingsources.js
[23:09:04] <ragesoss>	 It launches like this: https://en.wikipedia.org/wiki/Special:MyPage/citing_sources?tour=wikiedcitingsources
[23:09:35] <ragesoss>	 but it errorrs: "Error: Could not show step 'welcome' because this.initialize() failed. Underlying error: missingtitle"
[23:10:11] <ragesoss>	 This extremely similar tour works fine: https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-wikiedbebold.js
[23:12:44] <ragesoss>	 https://en.wikipedia.org/wiki/Special:MyPage/be_bold?tour=wikiedbebold2
[23:12:59] <ragesoss>	 (https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-wikiedbebold2.js)
[23:19:21] <Krenair>	 ragesoss, looking in console https://en.wikipedia.org/w/api.php?action=parse&format=json&formatversion=2&contentmodel=wikitext&uselang=en-gb&redirects=true&page=Wikipedia%3AWiki_Ed%2Ftour%2Fciting_sources12 fails
[23:19:29] <Krenair>	 er
[23:19:32] <Krenair>	 looking in the network tab
[23:20:13] <ragesoss>	 ah!
[23:20:14] <ragesoss>	 https://en.wikipedia.org/wiki/Wikipedia:Wiki_Ed/tour
[23:20:25] <Krenair>	 lots of other similar requests succeed but not 12
[23:20:43] <ragesoss>	 great
[23:20:45] <ragesoss>	 that must be it
[23:20:56] <Krenair>	 yeah
[23:21:15] <ragesoss>	 the JS console error was extremely misleading.
[23:21:22] <Krenair>	 well
[23:21:51] <Krenair>	 it wasn't very helpful for someone who isn't familiar enough with MW to recognise that as a common API error code
[23:22:06] <ragesoss>	 ah.
[23:22:18] <Krenair>	 but once you know that's from the API, it makes sense to look through the request it made
[23:22:23] <ragesoss>	 I kept looking at the code, like, 'but title is defined for that step!'
[23:22:34] <ragesoss>	 thanks so much!
[23:22:57] <Krenair>	 yay for knowing random obscure MW strings :P
[23:24:42] <ragesoss>	 woohoo, fixed!