[04:46:27] niedzielski: could you please help me out with T197883? [04:46:28] T197883: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 [04:48:27] shreyasminocha: i can try. what do you need? [04:49:26] so i updated babel-preset-env, babel-loader and babel-register [04:49:33] running tests, i get https://paste.ee/p/7E4e6 [04:52:03] ok, so you're updating the babel packages together. that sounds good. did you review each package's changelog or release notes? [04:52:50] i went through the upgrade to babel7 guide, but your suggestion sounds like a good idea [04:53:20] should've done that already [04:53:53] hi, quick question, what does the move-categorypages user right do? [04:54:43] shreyasminocha: hm, i also confused by the definition of state. i think there is a bug here too: [04:54:44] const state = eventLogging( state, action ); [04:56:01] i'm not familiar with the codebase at all, but i did notice that in the stacktrace, yes [04:56:04] you should still check out the release notes to make sure you understand the changes at a high level, but i think state is being used prior to definition [04:56:41] will do. what do you suggest i do if there is a bug on our end? [04:57:04] * niedzielski sent a long message: < https://matrix.org/_matrix/media/v1/download/matrix.org/RXHpTDZKcvdZjjXAdzXSYPIA > [04:58:26] hmm [04:59:07] baylee: i'm not sure but have you already seen this documentation? https://www.mediawiki.org/wiki/Manual:User_rights [05:00:47] niedzielski: ah, I looked on enwiki and meta, but I guess I forgot to check mediawiki too [05:01:45] so, if I'm reading this right, it lets users move the page thats in the cateogry namespace, but not the pages in the category, right? [05:04:05] niedzielski: adding let state = ... to ABANDON_END fixes it! thanks, i didn't notice the pattern before you pointed it out. i needn't worry about the lack of code coverage, right? [05:05:18] baylee: i do not know but that is my interpretation of it. if a user has the move right _and_ the move-categorypages right, they can move pages in the category namespace (14). e.g., Category:Foo, Category:Bar. categorized pages can be in other namespaces and have their own rights. e.g., Barack Obama [05:05:36] (Barack Obama being in the main namespace) [05:06:06] that's what i understood too [05:06:48] (but that's based solely on what's written there) [05:07:19] shreyasminocha: it was a preexisting bug so i wouldn't have seen it either didn't cause the tests to fail. that bug fix can and should be it's own patch! [05:07:40] sure, will do [05:07:55] thanks, and sorry for pinging out of the blue [05:08:08] coverage is important but should not be impacted significantly by upgrading [05:08:18] ah, so then if a user moved Category:ABC to Category:XYZ, the pages in category ABC wouldn't be recatorgized as XYZ, right? [05:09:08] hmm... let me try check the coverage in master [05:09:13] baylee: i'm not sure but i think they would be. [05:09:44] baylee: maybe you can try a test in sandbox? [05:10:36] ye, I'll try it on my test mw install [05:14:46] baylee: i thin i was wrong. i just made a page, Test, and added [[Category:Foo]]. i then created the Category:Foo page and moved it to Category:Bar with redirects enabled. the Test page still shows Category:Foo but redirects to Category:Bar [05:16:17] so it doesn't change the wikitext of the Test page but it does italicize the presentation on the vector skin [05:16:52] ah, thanks [07:19:42] why might updating babel reduce coverage drastically? [08:01:53] <[1997kB]> https://en.wikipedia.org/wiki/Brown_rat anybody know why there's a inter-wiki link, while it's not attached to any wikidata item. [09:55:07] [1997kB]: It's attached to https://www.wikidata.org/wiki/Q184224 [09:57:09] <[1997kB]> it is now, anyways my issue is solved, thanks [11:08:36] irc's angle brackets complement my new (temporary) nick [14:58:29] Anyone with a clue what happen in T211475: Temporary copy shows up on wrong page in the data space, and can not be deleted? [14:58:29] T211475: Temporary copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 [14:59:26] And what is the proper search term for the temporary working copy? [15:00:31] Temporary, this has been stuck for a couple of weeks unless I'm mistaken.