[22:25:51] Hi [22:25:57] Anyone good with queries? [22:26:30] eh [22:26:32] I reckon I'm okay [22:26:35] https://quarry.wmflabs.org/query/31107 [22:26:50] I'm trying to find pages I ACTUALLY validated [22:26:57] By reading the edit summaries [22:27:06] They don't seem to be in the revisions table [22:27:22] but the tempory cross reference table for looking them up in the comment table [22:27:29] doesn't seem to exist on Wikisource [22:28:24] So I'm puzzled... [22:28:41] because in the contributions record at Wikisource [22:29:13] https://en.wikisource.org/wiki/Special:Contributions/ShakespeareFan00 [22:29:17] hold on if this is SELECT DISTINCT p.page_id, p.page_title, pp1.pp_value, r.rev_id, r.rev_comment [22:29:26] why are we only getting the page ID and title in the results? [22:30:08] That's the first bug [22:30:24] okay let's discuss one bug at a time [22:30:35] How do I cross reference pages to revisions [22:31:07] I'm using the page properties table to find "Validated" pages [22:31:17] I specfically asked for that months ago [22:31:36] rev_page [22:32:28] I don't know what quarry is doing but when I run that query I get back all 5 fields [22:32:31] Should cross reference on the page_id [22:32:50] rev_page would be a foreign key referencing page.page_id, yes [22:33:15] I took at the specfics to do it as a general query to figure out if it's something to do with the WHERE clause [22:33:55] https://quarry.wmflabs.org/query/31107 I should be seeing something in rev_comment [22:33:59] ? [22:34:00] So this query should give you all pages that you've edited on enwikisource which have page prop proofread_page_quality_level set to 4 [22:34:03] I'm not [22:34:08] So either it's in XML [22:34:18] Or it's not present (but should be) [22:34:41] Krenair : Yes [22:35:05] I then wanted to use the edit comments to further narrow it down [22:35:45] to pages I had edited ONCE validated by myself or others. [22:35:51] I'd probably write this query as FROM revision and join against page [22:36:36] but I'm not sure that matters [22:37:22] https://quarry.wmflabs.org/query/31107 I'm still not seeing in rev_comment [22:37:32] https://www.mediawiki.org/wiki/Manual:Revision_table [22:37:42] says rev_comment was deprecated in 1.30 [22:37:53] oh yeah [22:37:55] forgot about this [22:38:05] rev_comment is probably no longer being written to [22:38:32] But the replacement table - https://www.mediawiki.org/wiki/Manual:Revision_comment_temp_table#revcomment_comment_id [22:38:48] Doesn't seem to exist on Wikisource under that name [22:38:58] because I tried cross referencing it [22:39:11] (or JOIN ing on it to get Comment ID's_ [22:39:13] MariaDB [enwikisource_p]> select rev_comment = '', count(1) from revision group by rev_comment = ''; [22:39:13] +------------------+----------+ [22:39:13] | rev_comment = '' | count(1) | [22:39:13] +------------------+----------+ [22:39:13] | NULL | 180 | [22:39:14] | 0 | 1529071 | [22:39:16] | 1 | 7059613 | [22:39:18] +------------------+----------+ [22:39:20] 3 rows in set (8.69 sec) [22:39:49] you want the `comment` table ShakespeareFan00 [22:39:56] Yes.. [22:40:09] How do I cross reference that with revisions? [22:40:28] https://www.mediawiki.org/wiki/Manual:Comment_table [22:40:44] has no way of crossreferencing [22:41:10] unless rev_comment is storing the cross-reference which is NOT what I understood the documentation to say [22:41:19] `describe revision;` :) [22:41:34] you have rev_comment_id [22:43:04] Ah good [22:45:15] Name of comment table isn't liked in quarry [22:46:43] hm? [22:48:32] Well it was showing up in the wrong colour [22:48:34] The query runs [22:49:00] weird [22:49:07] anyway I added rev_comment_id to the page [22:49:46] Thanks :) [22:53:41] https://quarry.wmflabs.org/query/31107 Odd. [22:53:46] Doesn't return anything [22:53:53] I guess the LIKE clause is iffy [22:58:19] Okay... I have a way of doing this :) [22:58:21] Thanks [23:03:22] Yep... Thanks :) [23:03:36] Adding the page quality as a page prop is awsome :)