[06:19:00] d3r1ck: Hello Ping ? [16:43:29] Hi, anybody to look on T207058 and correct me if I'm wrong? [16:43:30] T207058: Ignore /vendor in operations/mediawiki-config - https://phabricator.wikimedia.org/T207058 [16:45:21] Urbanecm: Vendor is purposely committed [16:45:43] You've got the usual thing that happens with running composer without --no-dev [16:47:23] Reedy, well, if I run composer install --no-dev, then composer test doesn't work [16:47:47] "Script parallel-lint --exclude vendor --ignore-fails . handling the lint event returned with error code 127" [16:48:57] Just don't use git commit -a then? [16:49:02] Just commit what you've changed [16:50:11] I know how to avoid commiting vendor files that shouldn't be committed. Isn't there some better solution than have mess in git status for a while? [16:50:26] Get jenkins to run your tests :D [16:51:26] I'm changing the tests now, which means I can grow to PS100+ in my "add test whatEver" patch, but if that's okay... [16:51:47] May I know the purpose of committing vendor? [16:52:19] We don't run composer in production [16:53:26] Ok, thanks for explaining it to me. Can you close the task please? [20:28:57] Reedy, is it right wgServer is protocol-relative for all wikis but labswiki/labtestwiki? [20:29:14] See https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/467445 for details [20:31:52] Arguably, we no longer support http [20:32:10] So maybe $wgServer should no longer be protocol relative [21:07:19] bawolff, maybe, I was just writing tests for the current rule - and I found labswiki/labtestwiki to be violating it [22:21:20] bawolff: Urbanecm: that's T118413 in case someone wants to follow up on it [22:21:21] T118413: Wikimedia wikis should use https:// in $wgServer - https://phabricator.wikimedia.org/T118413 [22:21:36] probably true for a bunch of other settings as well, not just wgServer