[00:43:26] I took care of framawiki's testwp request [00:49:21] do jenkins workers have full network access? [00:49:40] I'm a bit surprised that https://gerrit.wikimedia.org/r/c/mediawiki/core/+/445544/1/tests/phpunit/includes/MultiHttpClientTest.php seems to have passed [00:49:43] they are in the cloud (labs) [00:49:46] TimStarling ^^ [00:49:58] so what ever a wm in there can access jenkins slaves can [00:50:03] wm = vm [00:50:07] TimStarling: yes, they have full network access [00:50:34] is there a policy on remote network access in tests? [00:51:34] I don't think there's an explicit policy, but I also don't think we have any other tests that require network access. It probably should be in tests/integration/ instead [09:58:39] hi, on Meta I got recently “[W0hxHgpAMFoAAFQ5nRQAAABS] 2018-07-13 09:30:22: Fataler Ausnahmefehler des Typs „Wikimedia\Rdbms\DBQueryError“” [10:02:43] I've heard such reports more and more in the last few days [10:08:11] Nemo_bis: will you be at Wikimania? :-) [10:11:02] nope [10:11:49] (I'll go North, to Lapland) [10:12:13] But WMIT folks are currently flying south :) [11:14:27] Nemo_bis: too sad; but have fun yourself :-) [11:26:17] Martin_WMDE: FWIW, the bug you reported seems to be https://phabricator.wikimedia.org/T163597 [11:26:44] thanks [16:29:19] getting "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again" when switching between visual editor and wikitext, also reported by other user [17:02:18] Stryn, there's an open task for that [17:04:07] I created one, there was one earlier? [17:05:47] oh yeah that was you, ok: https://phabricator.wikimedia.org/T199554 [17:06:23] :) [18:54:36] can someone make me an admin on beta plz? [18:54:44] https://deployment.wikimedia.beta.wmflabs.org/wiki/User:Daniel_Kinzler_(WMDE) [18:56:50] try in -releng maybe? [18:57:07] sigh, so many channels [19:08:50] yes and if someone doesn't tell you, you would have no way to guess [19:09:54] Small question as I seem to be dumb: where is editing workflow in new Polygerrit UI? Is there any way to get to it that I am not noticing? [19:16:14] stjn hi, in 2.15 there is no editing inline support in polygerrit. This was added earlier this year and will become part of 2.16 / 3.0 [19:17:21] Alright, thanks. [21:47:41] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/445636/ Can someone experienced look into this patch? I don’t get it: I haven’t even edited anything that is related to XSS, but builds keep failing for it because of   somewhere. [21:50:55] it's a parser test that is failing [21:51:24] the commit doesn't touch the parser… [21:51:49] looks like an error [21:52:05] looks like a   becomes a space [21:53:51] but why is it failing here? [21:54:16] if master doesn't pass the parsertests [21:54:29] surely that one shouldn't have been merged? [21:54:58] it looks like jenkins is passing on other repos, and indeed recently on that repo too. this is strange [21:56:07] yes, the difference is a   becoming a space [21:56:33] it doesn't even affect the anti-XSS behavior of the parser [21:56:39] looks like   is   [21:57:35] that exact same test just passed on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TemplateWizard/+/444794/ [21:57:38] it is [21:58:24] that one didn't have any .php file [22:03:03] how did you make jenkins to rerun? [22:09:11] Platonides "recheck" [22:09:26] I provided it correctly, then [22:09:45] ah, it finally posted [22:09:47] Still failed. [22:09:51] yup [22:10:34] this is puzzling [22:22:38] uh, that's bizarre [23:13:31] Btw: is it OK to set people as reviewers on Gerrit yourself if you want them to check some of your patches or is it rude/annoying for them? I have some easy patches in extensions that are generally forgotten (CharInsert, TemplateData) but have Editing team as code stewards and I'm interested if it would be acceptable to ping them like this. [23:24:38] yep [23:24:46] stjn you can even cc people! [23:47:14] Alright, thanks.