[19:43:43] legoktm: Would you have time to take a look at https://phabricator.wikimedia.org/D613 again? It's sitting there like a year now :) [21:43:43] eddiegp: uh, I don't think I have arc installed anymore...could you turn it into a git patch or something and pastebin that? [21:44:45] Heh, me neither. I'll have a look. [21:45:15] legoktm: You can click "download raw diff" on differential [21:45:44] Alternatively, there's a "Patch without arc" command at the top of the details section :) [21:50:39] Which downloads exactly that raw diff and applies it to a new branch, you're right. :) [21:54:44] eddiegp: https://tools.wmflabs.org/ldap/ :D [21:54:49] thanks :)))) [21:55:21] legoktm: Thanks to you :) [22:05:06] legoktm: that tool doesn't seem complete... [22:05:18] which part? [22:05:20] or perhaps it's the ldap what isn't updated [22:05:33] you can look at the ldap queries its making :) [22:06:19] the good things of open source :) [22:06:33] I expected I would be at the nda list [22:06:47] seems I'm not in that group [22:07:10] are you talking about the LDAP group called "nda" or something tools related [22:07:57] the nda LDAP group [22:08:22] I noticed when poking at the LDAP tool at labs [22:08:48] that group does not mean "all people who signed any kind of NDA with wmf" [22:09:12] it is more specific just for the cases where we want to grant web-based login on some prod tools [22:09:23] like icinga or graphite [22:09:32] and the person is not a WMF employee [22:11:01] if you clone the operations/puppet repo and then [22:11:02] grep -r "cn=ops" * [22:11:05] Platonides: https://tools.wmflabs.org/ldap/user/Platonides shows your groups [22:11:10] you will see where it is used and what for [22:11:31] it's definitely possible there's an issue in the ldap queries being used [22:11:57] nah, it's just that I expected to be listed there while I wasn't [22:12:00] it usually is configured as "grant login if either ops or wmf or nda" [22:12:04] ok [22:12:07] the code is probably ok [22:12:57] not that ldap is specially pretty :P [22:13:37] oh, that whole tool is just about 100 lines [22:14:26] short and sweet [22:14:51] yep, I'm surpresed it's that short :) [22:16:21] it breaks on users with a - in their username by the looks [22:16:40] https://tools.wmflabs.org/ldap/user/neilpquinn-wmf [22:17:13] lemme tweak the regex [22:17:59] and thats my good turn for the day sorted and its not even 8:30 and a weekend [22:18:47] * legoktm huggles p858snake [22:18:49] fixed now [22:56:54] Does anybody have an idea why line 114 isn't preventing template caching? https://gerrit.wikimedia.org/r/#/c/424583/4/Variables_body.php [22:57:15] In the Cite extension it is done in a similar matter [23:00:18] https://gerrit.wikimedia.org/r/#/c/99793/ [23:01:22] After it was implemented espspecially for this case: https://gerrit.wikimedia.org/r/#/c/99792/ [23:02:26] MGChecker: is your $egVariablesVarIsVolatile == true in the environment you are testing? [23:02:56] that's the only obvious thing I see different [23:04:23] It should be, as I didn't explicitly set it… [23:04:36] Oh, there's a typo in extension.json [23:05:17] ThatÄs why the global is null which is why it is interpreted as false [23:05:42] *That's