[00:21:47] <Dispenser>	 What's is a good name for a dump search tool?
[00:23:00] <Dispenser>	 I was considering "savage" since initially it's going to search SVG dumps
[06:12:36] <Ivy>	 Dispenser: Do you mean salvage?
[06:12:43] <Ivy>	 Though "savage" is kind of cute in a separate way.
[06:12:59] <Ivy>	 Oh, maybe "savage" because of SVG? Hmm.
[06:13:06] <Ivy>	 I was thinking of "grep" and "stool" a bit.
[06:13:26] <Ivy>	 Also, scavenge?
[06:14:28] <Ivy>	 paddle?
[06:14:37] <Ivy>	 So you could be up shit's creek, but with a paddle?
[06:14:37] <Ivy>	 Idk.
[09:43:35] <Perhelion>	 anyone idea? https://commons.wikimedia.org/wiki/Commons:Village_pump#Special:Upload_prepending... 
[10:11:19] <thedj>	 Perhelion: it's due to changes this week to uploadwizard to add the patent warning for 3d models
[10:13:04] <thedj>	 https://gerrit.wikimedia.org/r/#/c/398845/ was the culprit
[10:13:33] <thedj>	 matthiasmullie knows about it, but i didn't have time to file a bugreport, and I think neither did he.
[10:13:33] <Perhelion>	 thedj: oh good, can you fix this? 
[10:20:15] <Perhelion>	 ok I fill one
[10:20:23] <matthiasmullie>	 Yeah, I have a patch for it, but didn't file a ticket
[10:20:36] <matthiasmullie>	 feel free to do so & assign it to me
[10:32:15] <Perhelion>	 done https://phabricator.wikimedia.org/T187302
[10:36:07] <matthiasmullie>	 alright thanks!
[14:03:07] <Hauskatze>	 do we have tech meeting today?
[14:06:05] <leszek_wmde>	 Hauskatze: yup, 4 PM UTC
[14:06:22] <Hauskatze>	 good good
[14:06:32] <Hauskatze>	 I'm currently a bit stuck on a thing :)
[15:56:36] <Pablo_WMDE>	 Technical Advice IRC meeting starting in 5 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @Pablo_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
[16:14:15] <andre__>	 Meouw?
[16:14:18] <Hauskatze>	 meow
[16:14:18] <Thiemo_WMDE>	 As usual, you can ask your technical questions in English. Oder auf Deutsch, wem das lieber ist. We don't have a cat here. :-)
[16:14:19] <Hauskatze>	 Thiemo_WMDE: {{fact}}
[16:14:19] <Hauskatze>	 ich bin ein Haus katze
[16:14:19] <Hauskatze>	 tech-hauskatze
[16:14:19] <Thiemo_WMDE>	 I mean here in the WMDE office.
[16:14:19] <Hauskatze>	 und ich habe eine Frage
[16:14:20] <Thiemo_WMDE>	 Gern.
[16:14:20] <Hauskatze>	 left the topics on the mediawiki page
[16:14:20] <Hauskatze>	 that's the little bad German I know, for now; hopefully one day I'll get some lessons
[16:14:21] <Thiemo_WMDE>	 The patch to cleanupSpam.php is brand new. Just give the people a little time (maybe 1 or 2 weeks) to find and review it.
[16:14:21] <Hauskatze>	 Thiemo_WMDE: will do, thanks :)
[16:14:22] <Thiemo_WMDE>	 For the other patch https://gerrit.wikimedia.org/r/409705 I can give two hints that might help:
[16:14:22] <Thiemo_WMDE>	 1.) The patch touches about 300 lines of code. Thats quite big. It would help a lot if you could split it into maybe 3 patches. One only for adding missing copyright headers. One for fixing sniffs. One for extension registration.
[16:14:22] <Thiemo_WMDE>	 2.) As long as a commit message says [WIP], many people will not even try to look at a patch.
[16:14:23] <Reedy>	 Also, if it's not WMF deployed extensions etc... People are generally less likely to look at it too
[16:14:23] <Hauskatze>	 Thiemo_WMDE: okay thanks; I'll try to do smaller changes in the future; I'm just accustomed to do everything at once
[16:14:23] <Hauskatze>	 Reedy: yeah :(
[16:14:23] <Thiemo_WMDE>	 I found it critical to upload patches that are small and focus one one single detail. That speeds up review sooo much.
[16:14:23] <Hauskatze>	 according to mainframe, there's only one little thing there that needs to be fixed, one $wgHooks thingy
[16:14:23] <Thiemo_WMDE>	 Splitting existing patches is not that hard. Gerrit supports "chains" of patches that depend on each other.
[16:14:30] <Thiemo_WMDE>	 Yea, and thats even more of a reason to split all the non-controversial details into separate patches that can be merged right now, with no further discussion. :-)
[16:14:31] <Hauskatze>	 but I don't understand him https://gerrit.wikimedia.org/r/#/c/409705/5/extension.json here and I don't want to ask him again; I find it embarrasing :)
[16:16:13] <Hauskatze>	 in any case, thanks for the advice, I'll surely take that into account for further patches I upload
[16:16:27] <Hauskatze>	 the list of extensions lacking conversion is still big :-)
[16:21:16] <Thiemo_WMDE>	 We left a comment in the patch.
[16:22:09] <HausAFKatze>	 thanks :)
[16:23:17] <HausAFKatze>	 Thiemo_WMDE: so 'public static function' etc?
[16:23:34] <Thiemo_WMDE>	 I think so.
[16:23:46] <HausAFKatze>	 okay
[16:23:52] <Thiemo_WMDE>	 Thats just one way to solve it. Did you understood the old code? Took me a while too.
[16:24:46] <HausAFKatze>	 Yes, somewhat. Took me some time too.
[16:25:48] <Thiemo_WMDE>	 That array( $example, 'ExampleClass::method' ) with $example being an instance of ExampleClass, this is a callable for a non-static, public method on an instance of that class. You replaced it with a static call. PHP does this, but complains with a warning. This is what the user tried to explain.
[16:27:14] <Pablo_WMDE>	 http://php.net/callable#example-111 shows the different ways a callable can be expressed. For "Type 4" to work the method should be static.
[16:37:11] <Thiemo_WMDE>	 37 minutes in. we are still here for an other 23. ;-)