[09:04:48] Hello. [WngdQApAME8AABNjd-cAAACR] 2018-02-05 09:01:48: «Wikimedia\Rdbms\DBQueryTimeoutError» on fetching https://commons.wikimedia.org/w/index.php?title=Special:Log/JackPotte&offset=20170819222910&limit=500&type=&user=JackPotte , retry was successful. [09:04:57] Any pretext for alarm? [09:17:31] the same shit again for offset=20170819201205: [WngetQpAIC8AACoGlesAAACK] 2018-02-05 09:08:01: Неустранимое исключение типа «Wikimedia\Rdbms\DBQueryTimeoutError» [09:18:19] is title=Special:Log/…&limit=500 really that heavy load for Wikimedia? [09:24:33] and retry didn’t help this time. [09:39:06] Again at title=Special:Log/JackPotte&offset=20170819195933&limit=320 – [WnglJApAICoAAE-2J0cAAAAO] 2018-02-05 09:35:28: «Wikimedia\Rdbms\DBQueryTimeoutError» – servers had much smoother run in þe olde goode times. [09:41:08] Some maintenace interruptions (mostly read only without other disruption) happened, but not bolts from the blue so frequently. [09:42:36] and WMF spends money for various crap like Wikipedia Zero and visual editors instead of hardware. [09:50:56] qq[IrcCity]: Hint, Try be a little less rude in how you speak [21:16:50] @seen bawolff [21:16:50] Hauskatze: Last time I saw bawolff they were quitting the network with reason: Quit: ChatZilla 0.9.93 [Firefox 52.6.0/20180118122319] N/A at 2/5/2018 5:22:50 PM (3h54m0s ago) [21:16:59] I will let you know when I see bawolff around here [21:16:59] @notify bawolff [22:36:05] How should I write the phabricator task concerning video playback controls not appearing in high contrast mode? (ping brion) Is it Kaltura Player, TimedMediaHandler player? [22:36:56] TimedMediaPlayer. [22:37:05] Do we still use Kaltura somewhere? [22:37:08] Dispenser: in TimedMediaHandler-Player section [22:37:09] Yep andre__ [22:37:13] urgh [22:37:15] yes until it's finished being removed :D [22:37:20] uhm, ok [22:37:27] however, be warned that all such bugs will just be closed out once the transition is complete [22:37:29] andre__ timemediahandler uses Kaultra Player by default, but videojs with beta feature [22:37:43] so it may be best to test against the videojs mode (and again, file in TimedMediaHandler-Player component) [22:38:39] The problem is background-image is used for the button and high contrast mode kills all background images (but leaves and alone) [22:39:07] interesting! [22:39:46] Dispenser: can you test real quick on http://ogvjs-testing.wmflabs.org/wiki/Video which uses latest ver of videojs mode (and has some known bugs, still to be fixed) ? [22:40:02] If I could write better, I'd write something about my adventures into Night mode (extension, writing CSS, etc) [22:40:20] :) [22:44:57] The best I have for testing in Pale Moon using https://addons.mozilla.org/en-US/firefox/addon/blank-your-monitor-easy-readin/ which toggles the High contrast preference in Firefox (opposed to the 10 seconds for windows to switch) [22:50:19] brion: Checked in Pale Moon and IE11. Its workable. Play, volume, and seek position are visible. Seek bar + volume bar lines missing, the ( i ) icon disappears. [22:54:50] Dispenser: thanks! be sure to include that in a phab ticket and i'll do more thorough testing of it down the line :) [22:55:16] the i icon is our extension, so our problem to fix; the volume/seek bar are video.js upstream's problem :) [22:56:52] brion i noticed that there's no icon or even text for resolution [22:56:59] i hovered and eventually found it [22:57:23] brion: An interesting is how the border property is treated. Something like background:white; border-color:white; Will be invisible, but in high contrast overrides border-color to be visible. [22:57:40] I used that to make https://en.wikipedia.org/w/index.php?title=Module%3AChart&type=revision&diff=768599588&oldid=767212167 work in high contrast mode [22:58:29] ...and apparently printing [22:59:30] paladox: yeah that broke in the videojs 6 update for some reason, have to dive in and fix it still [22:59:39] ah ok [22:59:50] brion thanks for updating to vjs 6 too :) [22:59:54] :) [23:00:32] brion do we use a customised version of it? [23:00:34] (resolution) [23:01:14] ""videojs.plugin() is deprecated; use videojs.registerPlugin() instead"' [23:01:26] ""videojs.addClass() is deprecated; use videojs.dom.addClass() instead"" [23:01:50] a forked one with some but not all vjs6 fixes in it :) [23:01:55] we'll have to just reclaim it i guess [23:01:58] :) [23:02:51] brion what features or fixes left are needed before we make vjs the default? :) [23:04:15] fix the missing icon, finish the subtitles webvtt api point and at least have directions on fixing remaining pages that don't make it through the converter, have saner handling of fullscreen (bump up resolution) maybe [23:04:48] it's not too far :D just needs some grunt work which i'm now finally having enough time to put in [23:05:12] heh :) [23:05:46] meh i can leave it at low res, as long as the icon's there. but it wouldn't hurt to be frictoinless [23:06:03] i think the current fullscreen is buggier as hell anyway [23:06:19] ah, so that's on your radar to fix (fullscreen thingy)? [23:06:42] yeah it seems good in videojs 6 now, though there might still be some edge cases [23:06:44] even works nice on iphone [23:06:49] heh :) [23:07:14] brion we should also apply https://github.com/kmoskwiak/videojs-resolution-switcher/pull/112/files [23:07:18] to our file? [23:07:39] i think we already did (or it was done on the fork we pulled) [23:07:59] oh [23:08:10] one of the plugins is complaning with ""videojs.plugin() is deprecated; use videojs.registerPlugin() instead"' [23:08:11] and [23:08:15] ""videojs.addClass() is deprecated; use videojs.dom.addClass() instead"" [23:08:16] https://www.npmjs.com/package/videojs-resolution-switcher-v6 [23:08:27] then if it hasn't we should :) [23:08:43] But will you (brion) have enough time to add AAC-LC in two weeks? https://phabricator.wikimedia.org/T166025 [23:08:52] :-) [23:09:02] ooh i should look at that [23:10:05] brion nope we never applied the fix https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/blob/master/resources/videojs-resolution-switcher/videojs-resolution-switcher.js#L365 heh [23:10:10] ahh, there's distinct AAC-LC and HE-AAC so that may be of limited utility. but something to keep an eye on [23:10:53] brion i think i've added support for a new format some where [23:11:08] Was it MP3 5 months ago? [23:11:46] brion https://gerrit.wikimedia.org/r/c/231575/ [23:12:24] ah nice, i should clean that patch up (hevc) [23:12:41] paladox: or if you clean it up i'll take a look over it and try to merge [23:12:48] Ok [23:12:50] thanks [23:12:51] will rebase [23:12:52] even if we don't use hevc/h265 output others may :D [23:13:49] heh i love that new gerrit login screen with the pleasant beach sunset background [23:13:54] it's so ... calming [23:16:58] (so aac-lc would potentially be useful with mpeg-2 source videos coming from archives, if i understand correctly) [23:22:11] brion done :) [23:27:52] brion and also https://gerrit.wikimedia.org/r/#/c/408462/ :) [23:44:02] brion hi, how would i do this part [23:44:03] "I think this should be folded back into Mp4Handler class, which should use stream metadata to detect whether a file contained an h.264 video track or an HEVC one. They're not distinct file types on input, but are different codecs in the same container type, so should be treated under the same handler." [23:44:55] paladox: so the getid3 stuff should be reporting back stream information, like which codecs are in which tracks [23:45:01] yep [23:45:18] you should from that be able to distinguish between them and return the appropriate base type description / mime type with codecs [23:45:37] hmm [23:46:05] in this kind of case, i'd just take a couple sample files and check what actually gets returned for each :D [23:46:12] then sset up a comparison in the code based on that investigation [23:46:42] brion like $metadata = self::unpackMetadata( $file->getMetadata() ); ? [23:46:53] yeah [23:47:13] you'll probably see in OggHandler and WebMHandler something similar [23:47:30] brion ah so in this function [23:47:34] function getWebType( $file ) { [23:47:41] i could use$file->getMetadata() [23:47:50] i wonder what is returned by that though? [23:48:21] how would i be able to do an if and else so that if it is hvec, it returns something differently to h.264 [23:48:22] just have to try it and see what you get ;) [23:48:41] heh [23:48:44] i'd probably put in a var_dump(...) die('xxx'); ;)))