[08:59:33] Is there a programmer that can help me? - Just wanted to start helping out with paches and changes. But I do have a few questions. [09:13:32] SimmeD: Hi! Don't ask to ask, just ask :) [09:24:29] andre__: Okai :) I claimed my first task (https://phabricator.wikimedia.org/T178550), as it seems like a easy task. But then it says it need to be approved by John Andersson. Thats fine, so this is his profile: https://se.wikimedia.org/wiki/Anv%C3%A4ndare:John_Andersson_(WMSE) - but on phabricator he looks like this https://phabricator.wikimedia.org/p/Jopparn/ :o And I'm not sure if it's... [09:24:30] ...the same person as none of them link to each other. [09:37:29] SimmeD: Yes it's the same person [09:37:46] Oh, okay. My mistake :/ [09:37:51] Usually, WMF staffs have 2 accounts [09:38:05] Their staff account and their individual/volunteer account [09:38:19] Yah, but it's the picture that confused me a bit. [09:38:20] So here is him on phab: https://phabricator.wikimedia.org/p/Jopparn/ [09:38:36] Hey hey, that shouldn't bother you :) [09:39:01] SimmeD: I think this is his volunteer account: https://meta.wikimedia.org/wiki/User:Jopparn [09:39:19] Hmm, think your right :) [09:39:23] Not "WMF staff" in this case, but in general correct [09:40:57] * d3r1ck smiles and shakes hands with andre__ :) [09:41:19] heh :P [09:43:33] Another question: They want the logo replaces, thats fine, but what do I do with the logos? - Do I replace the old picture ("\mediawiki-config\static\images\project-logos\sewikimedia.png") with the new, or rename the old picture "sewikimedia_old.png" and the upload the new? - Sorry if it's dum questions :P It's my first task [09:48:51] SimmeD: That's a good question to ask on the ticket, feel free to do so. [09:49:14] But from the look of things, they want their logo updated on most places were the old once exist [09:49:28] For example on their offical website: http://wikimedia.se/ [09:49:41] Meta page: https://meta.wikimedia.org/wiki/Wikimedia_Sverige [09:50:15] Not really sure about this though but it would be good to ask Lokal_Profil or Jopparn directly on the ticket so they can point you to the right direction. [09:52:33] SimmeD: Looking at https://meta.wikimedia.org/wiki/IRC/Channels, you can see them via #wikimedia-se but I wonder if they speak English in there because it says "mostly sv". [10:15:28] I just made a mistake in my commit :/ Forgot the "Bug: id" [10:17:13] SimmeD: just amend it and repush the change for review [10:17:46] How do I amend it? [10:20:06] There we go :) Done [10:33:03] if you are on gerrit you can edit the commit message righ there in the gui [10:33:21] but I find it's faster to edit at the terminal doing git commit --amend [10:33:36] Are people shown a warning if they access (not edit) Wikipedia with an old browser? [10:38:03] (Looking at an email where the customer claims that when he was browsing Wikipedia a while ago, he got a warning telling him to download Firefox 52 ESR (he uses Win XP), which purportedly doesn't vanish.) [10:41:25] pajz: AFAIK yes we show a page with a message like that and that link also to https://wikitech.wikimedia.org/wiki/HTTPS/Browser_Recommendations [10:41:30] ema: ^^^ [10:42:44] pajz, volans: probably this page https://en.wikipedia.org/sec-warning [10:44:46] I see, thanks! [10:44:49] yw! [11:05:23] SimmeD: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 [11:09:30] Oh, thanks. [11:20:30] Do this look right? https://gerrit.wikimedia.org/r/#/c/385165/ - With all thoes paches? [11:21:13] I only needed to upload replace one picture, but I took the wrong image https://commons.wikimedia.org/wiki/File:Wikimedia_Sverige_logo_-_vertical.svg instead of https://commons.wikimedia.org/wiki/File:Wikimedia_Sverige_logo_-_vertical_square.svg - I'm a bit confused :o [11:21:34] The latest patch is the one that is correct. [11:44:26] /c/c [12:46:12] Can anyone inhere rename on "phabricator"? [13:04:55] SimmeD, what does that mean? [13:05:01] rename what exactly? [13:05:26] If anyone inhere has permission to change my username (rename me) :) [13:06:26] SimmeD: Yes. Please file a request in Phabricator against the #Phabricator project [13:07:26] Thanks [13:11:09] SimmeD: https://phabricator.wikimedia.org/maniphest/task/edit/form/1/?projects=Phabricator [13:12:56] Thx [13:24:46] What do "recheck" mean as a comment on commits? - When people say it. [13:25:22] SimmeD: to tell Jenkins to re-run the CI jobs [13:25:51] Oh, okai [13:27:16] Who is in charge of merge all the commits? [13:33:11] SimmeD: it depends on the change, the project, etc... for your specific change, given is in the mediawiki-config repository, I'd suggest to look at [13:33:14] https://wikitech.wikimedia.org/wiki/SWAT_deploys [15:25:54] Anyone with CentralAuth / API skillz: When I want to edit on a foreign wiki via API, do I need to get a centralauthtoken first and with that then a crsf token and then I can edit. Or should I be able to edit with the centralauthtoken right away? [15:42:48] CFisch_WMDE: See https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi/blob/master/src/getLocationAgnosticMwApi.js [15:42:58] Basically you use mw.ForeignApi [15:48:57] hoo: and with PHP? :-> [15:52:38] CFisch_WMDE: In which context? External use or as a deployed MW extension? [15:55:01] The FileImporter extension that helps moving files from e.g. en.WP to commons. Sitting on commons, should then add a note to the file moved in the source wiki with the mover as author. So from the extension in commons I have a API request to en.WP to add some note to the file. [15:55:30] I can get a centralauth token that is meant to do things like that [15:56:19] so my question was if I still need a crsf token on the foreign wiki ( that I would get with the centralauthtoken ) or of the centralauth token should be enough [15:59:57] CFisch_WMDE: I think you do [16:00:24] But calling out to an API from a extension sounds awry in general [16:00:30] why not post a Job to the other wiki? [16:01:23] Echo does that all the time ^^ .... but could think about it [16:02:00] thanks [17:40:05] CFisch_NA: yes, you need to get a centralauth token, then get a csrf token, then get another centralauth token, and then make your edit [18:41:15] MatmaRex, I opened a bug about the 500 I'm getting from Commons [18:41:22] T178567 [18:41:22] T178567: Server error (500) while trying to download files from Commons from PAWS - https://phabricator.wikimedia.org/T178567 [18:42:43] thanks!